Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-04-09 Thread Shahaf Shuler
Monday, March 26, 2018 12:35 PM, Adrien Mazarguil: > Subject: Re: [PATCH v3] net/mlx4: support CRC strip toggling > > On Sun, Mar 25, 2018 at 08:19:29PM +, Ophir Munk wrote: > > Previous to this commit mlx4 CRC stripping was executed by default and > > there was no verbs API to disable it. > >

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-28 Thread Ferruh Yigit
On 3/28/2018 7:03 AM, Shahaf Shuler wrote: > Monday, March 26, 2018 3:31 PM, Thomas Monjalon: >> 26/03/2018 13:54, Adrien Mazarguil: >>> On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: On 3/25/2018 9:19 PM, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was ex

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-27 Thread Shahaf Shuler
Monday, March 26, 2018 3:31 PM, Thomas Monjalon: > 26/03/2018 13:54, Adrien Mazarguil: > > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > > Previous to this commit mlx4 CRC stripping was executed by default > > > > and there was no

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Thomas Monjalon
26/03/2018 13:54, Adrien Mazarguil: > On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > > Previous to this commit mlx4 CRC stripping was executed by default and > > > there was no verbs API to disable it. > > > > Are you aware of the disc

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Adrien Mazarguil
On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote: > On 3/25/2018 9:19 PM, Ophir Munk wrote: > > Previous to this commit mlx4 CRC stripping was executed by default and > > there was no verbs API to disable it. > > Are you aware of the discussion about CRC [1]? Is this patch compatible w

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Ferruh Yigit
On 3/25/2018 9:19 PM, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was executed by default and > there was no verbs API to disable it. Are you aware of the discussion about CRC [1]? Is this patch compatible with plans? [1] https://dpdk.org/dev/patchwork/patch/36415/ > Signed-o

Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-26 Thread Adrien Mazarguil
On Sun, Mar 25, 2018 at 08:19:29PM +, Ophir Munk wrote: > Previous to this commit mlx4 CRC stripping was executed by default and > there was no verbs API to disable it. > > Signed-off-by: Ophir Munk > --- > v1: initial version > v2: following internal reviews > v3: following dpdk.org mailing

[dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling

2018-03-25 Thread Ophir Munk
Previous to this commit mlx4 CRC stripping was executed by default and there was no verbs API to disable it. Signed-off-by: Ophir Munk --- v1: initial version v2: following internal reviews v3: following dpdk.org mailing list reviews drivers/net/mlx4/mlx4.c | 6 +- drivers/net/mlx4/ml