Re: [dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-14 Thread Yongseok Koh
Thanks! Yongseok > On Sep 13, 2017, at 10:23 PM, Shahaf Shuler wrote: > > Hi Yongseok, > > Wednesday, September 13, 2017 10:52 PM, Yongseok Koh: >>> >>> +/* Maximum number of DS in WQE. */ >>> +#define MLX5_MAX_DS 63 >> How about make it consistent with MLX5_MPW_DSEG_MAX by naming >> MLX5_DS

Re: [dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Shahaf Shuler
Hi Yongseok, Wednesday, September 13, 2017 10:52 PM, Yongseok Koh: > > > > +/* Maximum number of DS in WQE. */ > > +#define MLX5_MAX_DS 63 > How about make it consistent with MLX5_MPW_DSEG_MAX by naming > MLX5_DSEG_MAX? > It doesn't have the same meaning. The MLX5_MPW_DSEG_MAX is to limit the

Re: [dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Yongseok Koh
On Wed, Sep 13, 2017 at 01:50:39PM +0300, Shahaf Shuler wrote: > Mellanox NICs has a limitation on the number of mbuf segments a multi > segment mbuf can have. The max number depends on the Tx offloads requested. > > The current code not enforce such limitation, which might cause > malformed work

[dpdk-dev] [PATCH v4 4/4] net/mlx5: enforce Tx num of segments limitation

2017-09-13 Thread Shahaf Shuler
Mellanox NICs has a limitation on the number of mbuf segments a multi segment mbuf can have. The max number depends on the Tx offloads requested. The current code not enforce such limitation, which might cause malformed work requests to be written to the device. This commit adds verification for