Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-09 Thread Stephen Hemminger
On Mon, 9 Jan 2017 10:01:40 + Remy Horton wrote: > On 09/01/2017 07:16, Yang, Qiming wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > [..] > >> void > >> +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int > >> +fw_lengt

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-09 Thread Remy Horton
On 09/01/2017 07:16, Yang, Qiming wrote: -Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] [..] void +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int +fw_length) { + struct rte_eth_dev *dev; + + RTE_ETH_VALID_PORTID_OR_RET(por

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-08 Thread Yang, Qiming
-Original Message- From: Stephen Hemminger [mailto:step...@networkplumber.org] Sent: Monday, January 9, 2017 7:05 AM To: Yang, Qiming Cc: dev@dpdk.org; Yigit, Ferruh ; Zhang, Helin ; Horton, Remy Subject: Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get On Sun, 8 Jan

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-08 Thread Stephen Hemminger
On Sun, 8 Jan 2017 12:11:31 +0800 Qiming Yang wrote: > void > +rte_eth_dev_fw_version_get(uint8_t port_id, char *fw_version, int fw_length) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_RET(port_id); > + dev = &rte_eth_devices[port_id]; > + > + RTE_FUNC_PTR_O

Re: [dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-07 Thread Andrew Rybchenko
On 01/08/2017 07:11 AM, Qiming Yang wrote: This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- v2 changes: * modified some comment statements. v3 changes: * change API, use rte_eth_dev_fw_i

[dpdk-dev] [PATCH v5 1/5] ethdev: add firmware version get

2017-01-07 Thread Qiming Yang
This patch adds a new API 'rte_eth_dev_fw_version_get' for fetching firmware version by a given device. Signed-off-by: Qiming Yang Acked-by: Remy Horton --- v2 changes: * modified some comment statements. v3 changes: * change API, use rte_eth_dev_fw_info_get(uint8_t port_id, uint32_t *fw_major