Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2019-01-04 Thread Stephen Hemminger
On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > + role = MEMIF_ROLE_SLAVE; > + flags = 0; > + id = 0; > + buffer_size = 2048; > + log2_ring_size = 10; > + nrxq = 1; > + ntxq = 1; > + socket_filename = ETH_MEMIF_DEFAULT_SOCKET_FILENAME; > + secret = N

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2019-01-04 Thread Stephen Hemminger
On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > +static ssize_t > +memif_msg_send(int fd, memif_msg_t *msg, int afd) > +{ > + struct msghdr mh = { 0 }; > + struct iovec iov[1]; > + char ctl[CMSG_SPACE(sizeof(int))]; > + > + iov[0].iov_base = (void *)msg; Since iov_base

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2019-01-04 Thread Stephen Hemminger
On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > +CFLAGS += -O3 > +CFLAGS += -I$(SRCDIR) > +CFLAGS += $(WERROR_FLAGS) > +CFLAGS += -Wno-pointer-arith Why this additional compiler flag?

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2019-01-04 Thread Ferruh Yigit
On 12/13/2018 1:30 PM, Jakub Grajciar wrote: > Memory interface (memif), provides high performance > packet transfer over shared memory. > > Signed-off-by: Jakub Grajciar Hi Jakub, I put some comments but overall it is a long patch, I am almost sure there are some details missed, it can make ea

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-14 Thread Wiles, Keith
> On Dec 14, 2018, at 3:39 AM, Bruce Richardson > wrote: > > On Thu, Dec 13, 2018 at 10:07:09AM -0800, Stephen Hemminger wrote: >> On Thu, 13 Dec 2018 14:30:51 +0100 >> Jakub Grajciar wrote: >> >>> + >>> +typedef uint16_t memif_region_index_t; >>> +typedef uint32_t memif_region_offset_t; >>

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-14 Thread Bruce Richardson
On Thu, Dec 13, 2018 at 10:07:09AM -0800, Stephen Hemminger wrote: > On Thu, 13 Dec 2018 14:30:51 +0100 > Jakub Grajciar wrote: > > > + > > +typedef uint16_t memif_region_index_t; > > +typedef uint32_t memif_region_offset_t; > > +typedef uint64_t memif_region_size_t; > > +typedef uint16_t memif_r

Re: [dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-13 Thread Stephen Hemminger
On Thu, 13 Dec 2018 14:30:51 +0100 Jakub Grajciar wrote: > + > +typedef uint16_t memif_region_index_t; > +typedef uint32_t memif_region_offset_t; > +typedef uint64_t memif_region_size_t; > +typedef uint16_t memif_ring_index_t; > +typedef uint32_t memif_interface_id_t; > +typedef uint16_t memif_ve

[dpdk-dev] [RFC v3] /net: memory interface (memif)

2018-12-13 Thread Jakub Grajciar
Memory interface (memif), provides high performance packet transfer over shared memory. Signed-off-by: Jakub Grajciar --- config/common_base |5 + config/common_linuxapp |1 + doc/guides/nics/memif.rst | 80 ++ drivers/net