RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-16 Thread Konstantin Ananyev
> > > > > > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx > > > checksum > > > > > offload > > > > > > > > > > > examples. > > > > > > > > > > > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > > > > > > > > > > > It will cause a huge performance degradat

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-16 Thread Konstantin Ananyev
> > From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > > Sent: Monday, 15 April 2024 17.08 > > > > On 4/12/2024 3:44 PM, Morten Brørup wrote: > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum > > >> offload > > examples. > > >>> > > >>> I strongly disagree

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-16 Thread Konstantin Ananyev
> > > > > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx > > checksum > > > > offload > > > > > > > > > > examples. > > > > > > > > > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > > > > > > > > > It will cause a huge performance degradation for shaping

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-16 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, 15 April 2024 17.08 > > On 4/12/2024 3:44 PM, Morten Brørup wrote: > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum > >> offload > examples. > >>> > >>> I strongly disagree with this change! >

Re: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-15 Thread Ferruh Yigit
On 4/12/2024 3:44 PM, Morten Brørup wrote: Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum >> offload examples. >>> >>> I strongly disagree with this change! >>> >>> It will cause a huge performance degradation for shaping >> applications: >>> >

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-12 Thread Morten Brørup
> > > > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx > checksum > > > offload > > > > > > > > > examples. > > > > > > > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > > > > > > > It will cause a huge performance degradation for shaping > > > applications

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-12 Thread Konstantin Ananyev
> > > > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum > > offload > > > > > > > > examples. > > > > > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > > > > > It will cause a huge performance degradation for shaping > > applications: > > > > >

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-12 Thread Morten Brørup
> > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum > offload > > > > > > > examples. > > > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > > > It will cause a huge performance degradation for shaping > applications: > > > > > > > > > > > > A packet

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-12 Thread Konstantin Ananyev
> > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > > > > > > examples. > > > > > > > > > > I strongly disagree with this change! > > > > > > > > > > It will cause a huge performance degradation for shaping applications: > > > > > > > > > > A packet will be processe

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-10 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Wednesday, 10 April 2024 12.35 > > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > > Sent: Tuesday, 9 April 2024 15.39 > > > > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > >

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-10 Thread Konstantin Ananyev
> > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Tuesday, 9 April 2024 15.39 > > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > > Sent: Friday, 5 April 2024 16.46 > > > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offlo

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-09 Thread Morten Brørup
> From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > Sent: Tuesday, 9 April 2024 15.39 > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Friday, 5 April 2024 16.46 > > > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > > > example

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-09 Thread Konstantin Ananyev
> > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 5 April 2024 16.46 > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > > examples. > > I strongly disagree with this change! > > It will cause a huge performance degradation for shaping appl

Re: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-08 Thread David Marchand
On Fri, Apr 5, 2024 at 6:20 PM Morten Brørup wrote: > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Friday, 5 April 2024 16.46 > > > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > > examples. > > I strongly disagree with this change! Ok, I will withd

RE: [PATCH v2 3/8] mbuf: fix Tx checksum offload examples

2024-04-05 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, 5 April 2024 16.46 > > Mandate use of rte_eth_tx_prepare() in the mbuf Tx checksum offload > examples. I strongly disagree with this change! It will cause a huge performance degradation for shaping applications: A packet