Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-06-01 Thread Maxime Coquelin
Monjalon ; Eelco Chaudron ; david.march...@redhat.com Cc: dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick On 5/31/23 08:19, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, May 30, 2023 11:17 PM To: Thomas Monjalon

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-06-01 Thread Eelco Chaudron
ay, May 31, 2023 5:29 PM >>>> To: Xia, Chenbo ; Thomas Monjalon >>>> ; Eelco Chaudron ; >>>> david.march...@redhat.com >>>> Cc: dev@dpdk.org >>>> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt >>>> kick >&g

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-06-01 Thread Maxime Coquelin
4/4] vhost: add device op to offload the interrupt kick On 5/31/23 08:19, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, May 30, 2023 11:17 PM To: Thomas Monjalon ; Eelco Chaudron ; Xia, Chenbo ; david.march...@redhat.com Cc: dev@dpdk.org Subject: Re: [PATCH

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-06-01 Thread Eelco Chaudron
1:17 PM >>>> To: Thomas Monjalon ; Eelco Chaudron >>>> ; Xia, Chenbo ; >>>> david.march...@redhat.com >>>> Cc: dev@dpdk.org >>>> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the >> interrupt >>>> kick >>&

RE: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, May 31, 2023 5:29 PM > To: Xia, Chenbo ; Thomas Monjalon > ; Eelco Chaudron ; > david.march...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrup

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 16:12, David Marchand wrote: Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct vhost_virtqueue *vq) if (vhost_need_event(off, new, old)) kick = true; kick: -

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: > @@ -974,11 +994,8 @@ vhost_vring_call_packed(struct virtio_net *dev, struct > vhost_virtqueue *vq) > if (vhost_need_event(off, new, old)) > kick = true; > kick: > - if (kick && vq->callfd >= 0) { > -

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Eelco Chaudron
On 31 May 2023, at 14:48, Maxime Coquelin wrote: > On 5/31/23 14:01, David Marchand wrote: >> Eelco, Maxime, >> >> On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: >>> @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket >>> *vsocket) >>> vsocket->pa

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 14:01, David Marchand wrote: Eelco, Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket *vsocket) vsocket->path = NULL; } + if (vsocket && vsocket->malloc_notify_

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
Eelco, Maxime, On Wed, May 17, 2023 at 11:09 AM Eelco Chaudron wrote: > @@ -846,6 +848,11 @@ vhost_user_socket_mem_free(struct vhost_user_socket > *vsocket) > vsocket->path = NULL; > } > > + if (vsocket && vsocket->malloc_notify_ops) { > + free(vsocket

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread David Marchand
On Tue, May 30, 2023 at 3:02 PM Maxime Coquelin wrote: > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentiall

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Eelco Chaudron
enbo ; >>> david.march...@redhat.com >>> Cc: dev@dpdk.org >>> Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt >>> kick >>> >>> >>> >>> On 5/30/23 15:16, Thomas Monjalon wrote: >>>> 30/05/2023

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-31 Thread Maxime Coquelin
On 5/31/23 08:19, Xia, Chenbo wrote: -Original Message- From: Maxime Coquelin Sent: Tuesday, May 30, 2023 11:17 PM To: Thomas Monjalon ; Eelco Chaudron ; Xia, Chenbo ; david.march...@redhat.com Cc: dev@dpdk.org Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt

RE: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, May 30, 2023 11:17 PM > To: Thomas Monjalon ; Eelco Chaudron > ; Xia, Chenbo ; > david.march...@redhat.com > Cc: dev@dpdk.org > Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt &

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Maxime Coquelin
On 5/30/23 15:16, Thomas Monjalon wrote: 30/05/2023 15:02, Maxime Coquelin: On 5/17/23 11:09, Eelco Chaudron wrote: This patch adds an operation callback which gets called every time the library wants to call eventfd_write(). This eventfd_write() call could result in a system call, which co

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Thomas Monjalon
30/05/2023 15:02, Maxime Coquelin: > > On 5/17/23 11:09, Eelco Chaudron wrote: > > This patch adds an operation callback which gets called every time the > > library wants to call eventfd_write(). This eventfd_write() call could > > result in a system call, which could potentially block the PMD th

Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick

2023-05-30 Thread Maxime Coquelin
On 5/17/23 11:09, Eelco Chaudron wrote: This patch adds an operation callback which gets called every time the library wants to call eventfd_write(). This eventfd_write() call could result in a system call, which could potentially block the PMD thread. The callback function can decide whether