Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

04/11/2020 09:04, Wisam Monther: > Hi, > > You can add my ack: > > Acked-by: Wisam Jaddo mailto:wis...@nvidia.com>> > > Thomas, > Do you have comments left here? No comment, it looks very good. Applied, thanks

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

I think Thomas can add it if he want to merge it in this version. Moreover I think you need to keep the ack between versions and the person who acked before should comment if newer version not ok with him, otherwise he is ok with it. “Using git commit —amend”. Thomas, correct me if I’m wrong, A

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, Is what you are asking possible with a simple git commit --amend? Thanks, Georgios On Wed, Nov 4, 2020 at 10:04 AM Wisam Monther wrote: > Hi, > > > > You can add my ack: > > Acked-by: Wisam Jaddo > > > > Thomas, > > Do you have comments left here? > > > > BRs, > > Wisam Jaddo > > > > *Fro

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, You can add my ack: Acked-by: Wisam Jaddo mailto:wis...@nvidia.com>> Thomas, Do you have comments left here? BRs, Wisam Jaddo From: Georgios Katsikas Sent: Tuesday, November 3, 2020 1:26 PM To: wis...@mellanox.com Cc: dev@dpdk.org Subject: Re: [PATCH] app/flow-perf: configurable rule batc

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, Any news on this patch? Is there anything else I could do? Thanks, Georgios On Sun, Oct 11, 2020 at 1:03 PM Georgios Katsikas wrote: > Currently, flow-perf measures the performance of > rule installation/deletion operations by breaking > down the entire number of operations into windows >

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, Thanks for the feedback Thomas. Please see my updated patch, I hope it better explains the scope of this work. Best regards, Georgios On Tue, Oct 6, 2020 at 1:25 AM Thomas Monjalon wrote: > 05/10/2020 19:16, Georgios Katsikas: > > Hi, > > > > What is the conclusion? > > I haven't seen this

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

05/10/2020 19:16, Georgios Katsikas: > Hi, > > What is the conclusion? > I haven't seen this patch being committed yet. You missed updating the file doc/guides/tools/flow-perf.rst > On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther wrote: > >From: Georgios Katsikas > > > > > >* One can now configu

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, What is the conclusion? I haven't seen this patch being committed yet. Thanks, Georigos On Thu, Sep 24, 2020 at 3:01 PM Wisam Monther wrote: > Hi, > > >-Original Message- > >From: george@gmail.com On Behalf Of Georgios > >Katsikas > >Sent: Thursday, September 24, 2020 12:11 PM

Re: [dpdk-dev] [PATCH] app/flow-perf: configurable rule batches

Hi, >-Original Message- >From: george@gmail.com On Behalf Of Georgios >Katsikas >Sent: Thursday, September 24, 2020 12:11 PM >To: wis...@mellanox.com >Cc: dev@dpdk.org; Georgios Katsikas >Subject: [PATCH] app/flow-perf: configurable rule batches > >* One can now configure the number