Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-05-08 Thread Ferruh Yigit
On 3/16/2018 3:51 PM, Ferruh Yigit wrote: > Don't mandate API to pass port offload configuration during queue setup, > this is unnecessary for devices that support only port level offloads. > > Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") > Cc: shah...@mellanox.com > > Signed-o

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 03:29:57PM +, Shahaf Shuler wrote: > Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > > 21/03/2018 15:28, Ferruh Yigit: > > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > > 21/03/2018 1

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 5:27 PM, Bruce Richardson > On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > > 21/03/2018 15:28, Ferruh Yigit: > > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > > 21/03/2018 11:54, Ferruh Yigit: > > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Bruce Richardson
On Wed, Mar 21, 2018 at 03:40:43PM +0100, Thomas Monjalon wrote: > 21/03/2018 15:28, Ferruh Yigit: > > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > > 21/03/2018 11:54, Ferruh Yigit: > > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > >>> IMHO, it should be allowed to specify queue offloads

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Thomas Monjalon
21/03/2018 15:28, Ferruh Yigit: > On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > > 21/03/2018 11:54, Ferruh Yigit: > >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > >>> IMHO, it should be allowed to specify queue offloads on port level. > >>> It should simply enable these offloads on all queues.

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 2:08 PM, Thomas Monjalon wrote: > 21/03/2018 11:54, Ferruh Yigit: >> On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: >>> IMHO, it should be allowed to specify queue offloads on port level. >>> It should simply enable these offloads on all queues. Also it will >>> match dev_info [rt]x_off

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Thomas Monjalon
21/03/2018 11:54, Ferruh Yigit: > On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > > IMHO, it should be allowed to specify queue offloads on port level. > > It should simply enable these offloads on all queues. Also it will > > match dev_info [rt]x_offload_capa which include both port and queue > >

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ananyev, Konstantin
org; > Harish ; Ivan Malov > > Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description > > Wednesday, March 21, 2018 2:52 PM, Ferruh Yigit: > > On 3/21/2018 11:40 AM, Shahaf Shuler wrote: > > > Wednesday, March 21, 2018 1:37 PM, Andrew Rybchenko:

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 2:52 PM, Ferruh Yigit: > On 3/21/2018 11:40 AM, Shahaf Shuler wrote: > > Wednesday, March 21, 2018 1:37 PM, Andrew Rybchenko: > >> On 03/21/2018 02:23 PM, Shahaf Shuler wrote: > >>> > >>> Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko > >>> > Not exactly. We s

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 11:40 AM, Shahaf Shuler wrote: > Wednesday, March 21, 2018 1:37 PM, Andrew Rybchenko: >> On 03/21/2018 02:23 PM, Shahaf Shuler wrote: >>> >>> Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko >>> Not exactly. We should add statement to allow to enable queue offloads on p

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ananyev, Konstantin
onjalon ; pa...@dpdk.org; > Harish ; Ivan Malov > > Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description > > On 03/21/2018 03:03 PM, Ananyev, Konstantin wrote: > > Hi everyone, > > > >> -Original Message- > >> From: dev

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Andrew Rybchenko
; Thomas Monjalon ; pa...@dpdk.org; Harish ; Ivan Malov Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description On 03/21/2018 02:23 PM, Shahaf Shuler wrote: Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko Not exactly. We should add statement to allow to enable queue

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
igit, Ferruh > > ; Mcnamara, John ; > > Kovacevic, Marko > > Cc: dev@dpdk.org; Thomas Monjalon ; > > pa...@dpdk.org; Harish ; Ivan Malov > > > > Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API > > description > > > > On 03/21/2018

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ananyev, Konstantin
alon ; pa...@dpdk.org; > Harish ; Ivan Malov > > Subject: Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description > > On 03/21/2018 02:23 PM, Shahaf Shuler wrote: > > > > Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko > > > > >Not exactly. We

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 1:37 PM, Andrew Rybchenko: > On 03/21/2018 02:23 PM, Shahaf Shuler wrote: > > > > Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko > > > > >Not exactly. We should add statement to allow to enable queue > > >offloads on port level (to enable on all queues). > > > > Wh

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Andrew Rybchenko
On 03/21/2018 02:23 PM, Shahaf Shuler wrote: Wednesday, March 21, 2018 1:20 PM, *:*Andrew Rybchenko >Not exactly. We should add statement to allow to enable queue offloads >on port level (to enable on all queues). Why it is needed ? May be just a paranoia to avoid misreading/misunderstandin

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 1:20 PM, :Andrew Rybchenko >Not exactly. We should add statement to allow to enable queue offloads >on port level (to enable on all queues). Why it is needed ? Queue offload is also a port offload, for the simple case it is enabled on each of the queues. PMDs should rep

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Andrew Rybchenko
On 03/21/2018 02:10 PM, Shahaf Shuler wrote: Wednesday, March 21, 2018 1:09 PM, Andrew Rybchenko On 03/21/2018 01:54 PM, Ferruh Yigit wrote: On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: On 03/16/2018 06:51 PM, Ferruh Yigit wrote: Don't mandate API to pass port offload configuration during qu

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Shahaf Shuler
Wednesday, March 21, 2018 1:09 PM, Andrew Rybchenko > On 03/21/2018 01:54 PM, Ferruh Yigit wrote: > > On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > >> On 03/16/2018 06:51 PM, Ferruh Yigit wrote: > >>> Don't mandate API to pass port offload configuration during queue > >>> setup, this is unnecessa

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Andrew Rybchenko
On 03/21/2018 01:54 PM, Ferruh Yigit wrote: On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: On 03/16/2018 06:51 PM, Ferruh Yigit wrote: Don't mandate API to pass port offload configuration during queue setup, this is unnecessary for devices that support only port level offloads. Fixes: 81ac560dc

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Ferruh Yigit
On 3/21/2018 9:47 AM, Andrew Rybchenko wrote: > On 03/16/2018 06:51 PM, Ferruh Yigit wrote: >> Don't mandate API to pass port offload configuration during queue setup, >> this is unnecessary for devices that support only port level offloads. >> >> Fixes: 81ac560dc1b4 ("doc: add details on ethdev of

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-21 Thread Andrew Rybchenko
On 03/16/2018 06:51 PM, Ferruh Yigit wrote: Don't mandate API to pass port offload configuration during queue setup, this is unnecessary for devices that support only port level offloads. Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") Cc: shah...@mellanox.com Signed-off-by: Fer

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-17 Thread Shahaf Shuler
Friday, March 16, 2018 5:52 PM, Ferruh Yigit: > Don't mandate API to pass port offload configuration during queue setup, > this is unnecessary for devices that support only port level offloads. > > Fixes: 81ac560dc1b4 ("doc: add details on ethdev offloads API") > Cc: shah...@mellanox.com > > Sign

Re: [dpdk-dev] [PATCH] doc: update new ethdev offload API description

2018-03-16 Thread Patil, Harish
-Original Message- From: Ferruh Yigit Date: Friday, March 16, 2018 at 8:51 AM To: John McNamara , Marko Kovacevic Cc: "dev@dpdk.org" , Ferruh Yigit , Thomas Monjalon , "shah...@mellanox.com" , , Harish Patil Subject: [PATCH] doc: update new ethdev offload API description >Don't mandate