Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast

2018-01-19 Thread Yang, Zhiyong
Drop this one since the patch doesn't follow the convention. I will resend another new one. Thanks Zhiyong > -Original Message- > From: Yang, Zhiyong > Sent: Friday, January 19, 2018 5:13 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; Yigit, Ferruh ; Yang, > Zhiyong > Subject: [PATC

Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast

2018-01-19 Thread Yang, Zhiyong
Thank you, Thomas, I will do that according to your comments. Thanks Zhiyong > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Friday, January 19, 2018 5:38 PM > To: Yang, Zhiyong > Cc: dev@dpdk.org; Yigit, Ferruh ; > olivier.m...@6wind.com > Subject: Re

Re: [dpdk-dev] [PATCH] lib/librte_mbuf: remove void * pointer cast

2018-01-19 Thread Thomas Monjalon
Hi Zhiyong, 3 comments about patch formatting: 1/ the title must follow the convention seen in the git history. If you use git log --oneline lib/librte_mbuf you will see that it must start with "mbuf:" 2/ The * character does not play well when patch saved in a file, and it is useless: "void poi