Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-09-17 Thread Min Hu (Connor)
在 2021/9/17 16:04, Ferruh Yigit 写道: On 9/17/2021 2:08 AM, Min Hu (Connor) wrote: Hi, Ferruh, What is the status of this set of your patches ? Could they be merged? Hi Connor, I should send a new version of it, will do soon. Please Cc me next time your send the new version, tha

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-09-17 Thread Min Hu (Connor)
在 2021/9/17 16:04, Ferruh Yigit 写道: On 9/17/2021 2:08 AM, Min Hu (Connor) wrote: Hi, Ferruh, What is the status of this set of your patches ? Could they be merged? Hi Connor, I should send a new version of it, will do soon. Thanks Ferruh. 在 2021/7/22 22:43, Stephen Hemminge

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-09-17 Thread Ferruh Yigit
On 9/17/2021 2:08 AM, Min Hu (Connor) wrote: > Hi, Ferruh, > What is the status of this set of your patches ? > Could they be merged? > Hi Connor, I should send a new version of it, will do soon. > > 在 2021/7/22 22:43, Stephen Hemminger 写道: >> On Thu, 22 Jul 2021 13:15:04 +0300 >> Andr

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-09-16 Thread Min Hu (Connor)
Hi, Ferruh, What is the status of this set of your patches ? Could they be merged? 在 2021/7/22 22:43, Stephen Hemminger 写道: On Thu, 22 Jul 2021 13:15:04 +0300 Andrew Rybchenko wrote: I don't think we care about type of transmission in this level, I assume we define min MTU ma

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Stephen Hemminger
On Thu, 22 Jul 2021 13:15:04 +0300 Andrew Rybchenko wrote: > > I don't think we care about type of transmission in this level, I assume we > > define min MTU mainly for the HW limitation and configuration. That is why > > it > > makes sense to me to use Ethernet frame lenght limitation (not IPv4

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Andrew Rybchenko
On 7/22/21 1:27 PM, Ferruh Yigit wrote: On 7/22/2021 2:31 AM, Ajit Khaparde wrote: > [snip] > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h >> index faf3bd901d75..9f288f98329c 100644 >> --- a/lib/ethdev/rte_ethdev.h >> +++ b/lib/ethdev/rte_eth

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Ferruh Yigit
On 7/22/2021 2:31 AM, Ajit Khaparde wrote: > > > > > [snip] > > > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > >> index faf3bd901d75..9f288f98329c 100644 > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -410,7 +410,7

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Andrew Rybchenko
On 7/22/21 1:12 PM, Ferruh Yigit wrote: On 7/22/2021 8:21 AM, Huisong Li wrote: 在 2021/7/21 23:29, Ferruh Yigit 写道: On 7/19/2021 4:35 AM, Huisong Li wrote: Hi, Ferruh Hi Huisong, Thanks for the review. 在 2021/7/10 1:29, Ferruh Yigit 写道: There is a confusion on setting max Rx packet leng

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Ferruh Yigit
On 7/22/2021 8:21 AM, Huisong Li wrote: > > 在 2021/7/21 23:29, Ferruh Yigit 写道: >> On 7/19/2021 4:35 AM, Huisong Li wrote: >>> Hi, Ferruh >>> >> Hi Huisong, >> >> Thanks for the review. >> >>> 在 2021/7/10 1:29, Ferruh Yigit 写道: There is a confusion on setting max Rx packet length, this patch

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Huisong Li
在 2021/7/21 23:29, Ferruh Yigit 写道: On 7/19/2021 4:35 AM, Huisong Li wrote: Hi, Ferruh Hi Huisong, Thanks for the review. 在 2021/7/10 1:29, Ferruh Yigit 写道: There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API accepts max Rx

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-21 Thread Ajit Khaparde
> > [snip] > > > >> diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > >> index faf3bd901d75..9f288f98329c 100644 > >> --- a/lib/ethdev/rte_ethdev.h > >> +++ b/lib/ethdev/rte_ethdev.h > >> @@ -410,7 +410,7 @@ enum rte_eth_tx_mq_mode { > >> struct rte_eth_rxmode { > >> /** The mu

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-21 Thread Ferruh Yigit
On 7/13/2021 1:47 PM, Andrew Rybchenko wrote: > On 7/9/21 8:29 PM, Ferruh Yigit wrote: >> There is a confusion on setting max Rx packet length, this patch aims to >> clarify it. >> >> 'rte_eth_dev_configure()' API accepts max Rx packet size via >> 'uint32_t max_rx_pkt_len' filed of the config struc

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-21 Thread Ferruh Yigit
On 7/19/2021 4:35 AM, Huisong Li wrote: > Hi, Ferruh > Hi Huisong, Thanks for the review. > 在 2021/7/10 1:29, Ferruh Yigit 写道: >> There is a confusion on setting max Rx packet length, this patch aims to >> clarify it. >> >> 'rte_eth_dev_configure()' API accepts max Rx packet size via >> 'uint32

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-18 Thread Xu, Rosen
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Saturday, July 10, 2021 1:29 > To: Jerin Jacob ; Li, Xiaoyun ; > Chas Williams ; Min Hu (Connor) ; > Hemant Agrawal ; Sachin Saxena > ; Zhang, Qi Z ; Wang, > Xiao W ; Matan Azrad ; > Shahaf Shuler ; Viacheslav Ovsiienko > ; Harman Kal

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-13 Thread Andrew Rybchenko
On 7/9/21 8:29 PM, Ferruh Yigit wrote: > There is a confusion on setting max Rx packet length, this patch aims to > clarify it. > > 'rte_eth_dev_configure()' API accepts max Rx packet size via > 'uint32_t max_rx_pkt_len' filed of the config struct 'struct > rte_eth_conf'. > > Also 'rte_eth_dev_se