Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-29 Thread Thomas Monjalon
07/06/2019 10:32, David Marchand: > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > wrote: > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > return 0 or negative error code. Bus code returns positive values > > if device wasn't recognized by any driver, so the result of >

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-27 Thread David Marchand
On Wed, Jun 26, 2019 at 11:03 PM Thomas Monjalon wrote: > 07/06/2019 10:32, David Marchand: > > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > > wrote: > > > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > > return 0 or negative error code. Bus code returns positive valu

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-26 Thread Thomas Monjalon
07/06/2019 10:32, David Marchand: > Thomas, > > - Calling unplug on a device that is not attached is a bit weird to me, all > the more so that we have rte_dev_probed(). > But there might be users calling directly the bus unplug api and not the > official api... > Does this enter the ABI stability

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-26 Thread Thomas Monjalon
07/06/2019 10:32, David Marchand: > On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets > wrote: > > > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > > return 0 or negative error code. Bus code returns positive values > > if device wasn't recognized by any driver, so the result of >

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-17 Thread Ilya Maximets
On 06.06.2019 13:02, Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > return 0 or negative error code. Bus code returns positive values > if device wasn't recognized by any driver, so the result of > 'bus->plug/unplug()' must be converted. 'local_dev_probe()'

Re: [dpdk-dev] [PATCH v2] eal: fix positive error codes from probe/remove

2019-06-07 Thread David Marchand
On Thu, Jun 6, 2019 at 12:03 PM Ilya Maximets wrote: > According to API, 'rte_dev_probe()' and 'rte_dev_remove()' must > return 0 or negative error code. Bus code returns positive values > if device wasn't recognized by any driver, so the result of > 'bus->plug/unplug()' must be converted. 'local