[dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode

2015-12-03 Thread Thomas Monjalon
2015-12-02 13:38, Christian Ehrhardt: > Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was > enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). > Now the underlying issue is rather simple, the xen code needs libxenstore. > But rte.app.mk so far only conside

[dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default

2015-12-03 Thread Rasesh Mody
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Tuesday, November 24, 2015 6:26 AM > > We still have a compilation error when zlib.h is missing. > Please keep it disabled until we have a solution (probably a "configure" > script). Just to clarify - are you planning to have a

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
Fixes following error (observed when versioning macros used): LD libdpdk.so /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found for symbol @DPDK_x.y Also resulting combined library contains symbol version information: $ readelf -a build/lib/libdpdk.so | grep rte_eal_ | grep

[dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default

2015-12-03 Thread Thomas Monjalon
2015-12-03 00:54, Rasesh Mody: > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Sent: Tuesday, November 24, 2015 6:26 AM > > > > We still have a compilation error when zlib.h is missing. > > Please keep it disabled until we have a solution (probably a "configure" > > script). >

[dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script

2015-12-03 Thread Ferruh Yigit
On Wed, Dec 02, 2015 at 06:44:19AM -0500, Neil Horman wrote: > On Tue, Dec 01, 2015 at 12:37:37PM +, Robie Basak wrote: > > Re-sending this unsigned since the ML rejected my signed email. > > > > -1 from Ubuntu without further discussion since it will break us. Please > > don't commit this pat

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Thomas Monjalon
Hi Ferruh, Thanks for working on it. 2015-12-03 01:22, Ferruh Yigit: > +ifeq ($(COMBINED_BUILD),1) > include $(RTE_SDK)/mk/rte.sharelib.mk > +endif [...] > @if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LIBS) = y ]; then \ > - $(MAKE) -f $(RTE_SDK)/lib/Makefile sharelib; \ >

[dpdk-dev] [PATCH 1/4] vhost: handle VHOST_USER_SET_LOG_BASE request

2015-12-03 Thread Yuanhan Liu
On Wed, Dec 02, 2015 at 05:38:10PM +0100, Thomas Monjalon wrote: > 2015-12-02 22:31, Yuanhan Liu: > > Thomas, should I write an ABI deprecation note? Can I make it for > > v2.2 release If I make one tomorrow? (Sorry that I'm not awared > > of that it would be an ABI break). > > As Panu suggested,

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 02:36:53AM +0100, Thomas Monjalon wrote: > Hi Ferruh, > > Thanks for working on it. > > 2015-12-03 01:22, Ferruh Yigit: > > +ifeq ($(COMBINED_BUILD),1) > > include $(RTE_SDK)/mk/rte.sharelib.mk > > +endif > [...] > > @if [ $@ = drivers -a $(CONFIG_RTE_BUILD_COMBINE_LI

[dpdk-dev] [PATCH v3] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
Fixes following error (observed when versioning macros used): LD libdpdk.so /usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found for symbol @DPDK_x.y Also resulting combined library contains symbol version information: $ readelf -a build/lib/libdpdk.so | grep rte_eal_ | grep

[dpdk-dev] [PATCH] vhost: reserve some spaces for virtio_net and vhost_virtqueue struct

2015-12-03 Thread Yuanhan Liu
So that we will not break ABI in future extension by adding few more fields. Struct vhost_virtqueue is reserved with 16 qwords (the later vhost-live migration support would at least consume 3 of them), and struct virtio_net is reserved with a bit more, 64 qwords, as there is only one instance for

[dpdk-dev] [PATCH v3] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Thomas Monjalon
2015-12-03 02:15, Ferruh Yigit: > +ifeq ($(COMBINED_BUILD),1) > include $(RTE_SDK)/mk/rte.sharelib.mk > +endif I still don't understand what was the issue with this include but it seems not related to versioning. Please condider a separate patch with a detailed explanation of the bug. [...] > +F

[dpdk-dev] [PATCH 3/4] vhost: log vring changes

2015-12-03 Thread Yuanhan Liu
On Wed, Dec 02, 2015 at 06:26:37PM +0200, Michael S. Tsirkin wrote: > On Wed, Dec 02, 2015 at 05:58:24PM +0200, Victor Kaplansky wrote: > > On Wed, Dec 02, 2015 at 10:38:02PM +0800, Yuanhan Liu wrote: > > > On Wed, Dec 02, 2015 at 04:07:02PM +0200, Victor Kaplansky wrote: > > > > On Wed, Dec 02, 20

[dpdk-dev] [PATCH v4 0/2] Add support for driver directories

2015-12-03 Thread Thomas Monjalon
2015-12-02 18:07, Stephen Hemminger: > On Thu, 12 Nov 2015 16:52:32 +0100 > Thomas Monjalon wrote: > > > > > This mini-series adds support for driver directory concept > > > > based on idea by Thomas Monjalon back in February: > > > > http://dpdk.org/ml/archives/dev/2015-February/013285.html > >

[dpdk-dev] [PATCH v3 10/11] config: Enable BNX2X driver build by default

2015-12-03 Thread Rasesh Mody
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, December 02, 2015 5:30 PM > > 2015-12-03 00:54, Rasesh Mody: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > Sent: Tuesday, November 24, 2015 6:26 AM > > > > > > We still have a compilation erro

[dpdk-dev] [PATCH] app/test: fix of returning wrong value

2015-12-03 Thread Helin Zhang
In the KNI unit test, if all test cases passed, it should return with 0. This patch fixes the issue of returning wrong value. Fixes: fc27caaafd4b ("kni: remove deprecated functions") Signed-off-by: Helin Zhang --- app/test/test_kni.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

[dpdk-dev] [PATCH] eal: fix build with Xen dom0 enabled

2015-12-03 Thread Thomas Monjalon
There is a new function in the EAL API for internal use. It has neither a proper prefix nor a .map export: libethdev.so: undefined reference to `is_xen_dom0_supported' Fixes: 719dbebceb81 ("xen: allow determining DOM0 at runtime") Signed-off-by: Thomas Monjalon --- drivers/net/i40e/i40e_rxtx.c

[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

2015-12-03 Thread Jianfeng Tan
This issue was discovered under the case of software vm2vm fowarding. When pkts are received from virtio device 0 and tx_route to virtio device 1, tx of device 0 is not updated. To fix this problem, we check each rx/tx branch to update stats. Besides, the stats are printed at a separated thread, s

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
Following the recent discussions, this is a proposal to have a standard installation process while keeping compatibility with most of the old behaviours. v2 changes: - fix default build dir - RTE_TARGET subdir in $(sdkdir). - better kerneldir defaults - fix dpdk_nic_bind symlink - always install d

[dpdk-dev] [PATCH v2 01/12] mk: remove testall

2015-12-03 Thread Thomas Monjalon
It is not possible to test every configs on an unique machine. Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/dev_kit_root_make_help.rst | 13 -- mk/rte.sdkroot.mk| 4 -- mk/rte.sdktestall.mk | 57

[dpdk-dev] [PATCH v2 02/12] mk: remove multi-target install

2015-12-03 Thread Thomas Monjalon
The multi-target install create some subdirectories with the target name which is not standard for a "make install" procedure. The uninstall procedure cannot be applied properly (without removing all files in a directory). It would need to pre-compute paths. As it is a packaging issue, it is remov

[dpdk-dev] [PATCH v2 03/12] mk: move installation procedure in install rule

2015-12-03 Thread Thomas Monjalon
The real installation was called "binary install" and was done after the build when DESTDIR was specified. Remove this limitation and move the code in install rule only. Signed-off-by: Thomas Monjalon --- mk/rte.sdkbuild.mk | 16 mk/rte.sdkinstall.mk | 21 ++---

[dpdk-dev] [PATCH v2 04/12] mk: install a standard cutomizable tree

2015-12-03 Thread Thomas Monjalon
The rule "install" follows these conventions: http://gnu.org/prep/standards/html_node/Directory-Variables.html http://gnu.org/prep/standards/html_node/DESTDIR.html The variable sdkdir has been added to the more standards ones, to configure the directory used with RTE_SDK when using the DPDK makefi

[dpdk-dev] [PATCH v2 05/12] mk: introduce new install syntax

2015-12-03 Thread Thomas Monjalon
The old install command was: make install T=x86_64-native-linuxapp-gcc DESTDIR=install It still works and can be replaced by these more standard commands: make config T=x86_64-native-linuxapp-gcc 0=x86_64-native-linuxapp-gcc make O=x86_64-native-linuxapp-gcc make ins

[dpdk-dev] [PATCH v2 06/12] mk: split install rule

2015-12-03 Thread Thomas Monjalon
Provides new sub-rules to install runtime and sdk separately. The build directory must be changed from BUILD_DIR to O in install rules to avoid a bad recursive effect (O being BUILD_DIR being O + T). Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.mk | 18

[dpdk-dev] [PATCH v2 07/12] mk: install kernel modules

2015-12-03 Thread Thomas Monjalon
Add kernel modules to "make install". Nothing is done if there is no kernel module compiled. When using "make install T=", the default path is the same as before. The Linux path is based on host kernel version. Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.

[dpdk-dev] [PATCH v2 08/12] mk: install binding tool in sbin directory

2015-12-03 Thread Thomas Monjalon
sbin/dpdk_nic_bind is a symbolic link to tools/dpdk_nic_bind.py where some python objects may be generated. Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.mk | 4 1 file changed, 4 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 3daf241..884c915 100644 --

[dpdk-dev] [PATCH v2 09/12] mk: install doc

2015-12-03 Thread Thomas Monjalon
The HTML API and HTML/PDF guides may be installed if generated. Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.mk | 14 ++ 1 file changed, 14 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 884c915..902a933 100644 --- a/mk/rte.sdkinstall.mk +++ b/m

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Thomas Monjalon
The examples are part of the installed documentation. Signed-off-by: Thomas Monjalon --- mk/rte.sdkinstall.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index 902a933..13fa819 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -15

[dpdk-dev] [PATCH v2 11/12] app/proc_info: rename binary with prefix

2015-12-03 Thread Thomas Monjalon
In order to be installed system-wise, this application needs a prefix. So it makes clear that it is DPDK related. Signed-off-by: Thomas Monjalon --- app/proc_info/Makefile | 2 +- doc/guides/sample_app_ug/proc_info.rst | 8 mk/rte.sdktest.mk | 4 ++--

[dpdk-dev] [PATCH v2 12/12] pkg: update RPM with standard install

2015-12-03 Thread Thomas Monjalon
The "make install" is more standard now. So the recipe can be simplified. Signed-off-by: Thomas Monjalon --- pkg/dpdk.spec | 59 --- 1 file changed, 16 insertions(+), 43 deletions(-) diff --git a/pkg/dpdk.spec b/pkg/dpdk.spec index 7437025

[dpdk-dev] [PATCH v2] hash: move rte_hash_set_cmp_func() to ver DPDK_2.2.

2015-12-03 Thread Yu Nemo Wenbin
Also modified the comments of rte_hash_set_cmp_func(). Signed-off-by: Yu Nemo Wenbin --- lib/librte_hash/rte_hash.h | 4 ++-- lib/librte_hash/rte_hash_version.map | 8 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/librte_hash/rte_hash.h b/lib/librte_hash/r

[dpdk-dev] [PATCH 0/5 for 2.3] vhost rxtx refactor

2015-12-03 Thread Yuanhan Liu
Vhost rxtx code is derived from vhost-switch example, which is very likely the most messy code in DPDK. Unluckily, the move also brings over the bad merits: twisted logic, bad comments. When I joined this team firstly, I was quite scared off by the messy and long vhost rxtx code. While adding the

[dpdk-dev] [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst

2015-12-03 Thread Yuanhan Liu
The current rte_vhost_dequeue_burst() implementation is a bit messy and logic twisted. And you could see repeat code here and there: it invokes rte_pktmbuf_alloc() 3 at three different places! However, rte_vhost_dequeue_burst() acutally does a simple job: copy the packet data from vring desc to mb

[dpdk-dev] [PATCH 2/5] vhost: refactor virtio_dev_rx

2015-12-03 Thread Yuanhan Liu
This is a simple refactor, as there isn't any twisted logic in old code. Here I just broke the code and introduced two helper functions, reserve_avail_buf() and copy_mbuf_to_desc() to make the code more readable. It saves nearly 1K bytes of code size: # without this patch $ size /path/to/

[dpdk-dev] [PATCH 3/5] vhost: refactor virtio_dev_merge_rx

2015-12-03 Thread Yuanhan Liu
Current virtio_dev_merge_rx just looks like the old rte_vhost_dequeue_burst, twisted logic, that you can see same code block in quite many places. However, the logic virtio_dev_merge_rx is quite similar to virtio_dev_rx. The big difference is that the meregeable one could allocate more than one av

[dpdk-dev] [PATCH 4/5] vhost: do not use rte_memcpy for virtio_hdr copy

2015-12-03 Thread Yuanhan Liu
First of all, rte_memcpy() is mostly useful for coping big packets by leveraging hardware advanced instructions like AVX. But for virtio net hdr, which is 12 bytes at most, invoking rte_memcpy() will not introduce any performance boost. And, to my suprise, rte_memcpy() is huge. Since rte_memcpy()

[dpdk-dev] [PATCH 5/5] vhost: don't use unlikely for VIRTIO_NET_F_MRG_RXBUF detection

2015-12-03 Thread Yuanhan Liu
VIRTIO_NET_F_MRG_RXBUF is a default feature supported by vhost. Adding unlikely for VIRTIO_NET_F_MRG_RXBUF detection doesn't make sense to me at all. Signed-off-by: Yuanhan Liu --- lib/librte_vhost/vhost_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/

[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

2015-12-03 Thread Yuanhan Liu
On Thu, Dec 03, 2015 at 06:01:33AM +0800, Jianfeng Tan wrote: > This issue was discovered under the case of software vm2vm > fowarding. When pkts are received from virtio device 0 and > tx_route to virtio device 1, tx of device 0 is not updated. > > To fix this problem, we check each rx/tx branch

[dpdk-dev] [PATCH v3] examples/vhost: fix statistics error

2015-12-03 Thread Jianfeng Tan
This issue was discovered under the case of software vm2vm fowarding. When pkts are received from virtio device 0 and tx_route to virtio device 1, tx of device 0 is not updated. Signed-off-by: Jianfeng Tan Tested-by: Qian Xu --- examples/vhost/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[dpdk-dev] [PATCH v2] examples/vhost: fix statistics error

2015-12-03 Thread Tan, Jianfeng
> -Original Message- > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > Sent: Thursday, December 3, 2015 2:18 PM > To: Tan, Jianfeng > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] examples/vhost: fix statistics error > > On Thu, Dec 03, 2015 at 06:01:33AM +0800, Ji

[dpdk-dev] [PATCH v3] examples/vhost: fix statistics error

2015-12-03 Thread Yuanhan Liu
On Thu, Dec 03, 2015 at 07:20:26AM +0800, Jianfeng Tan wrote: > This issue was discovered under the case of software vm2vm > fowarding. When pkts are received from virtio device 0 and > tx_route to virtio device 1, tx of device 0 is not updated. > > Signed-off-by: Jianfeng Tan > Tested-by: Qian X

[dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode

2015-12-03 Thread Christian Ehrhardt
Hi Thomas, it was already after the --start-group before my patch, only guarded by the "ifeq ($(CONFIG_RTE_BUILD_COMBINE_LIBS),n)" I've had no opinion on being inside/outside the group. I just wanted to move it out of the "ifeq" which was not appropriate for the -lxenstore. I didn't want to cause

[dpdk-dev] [PATCH] mk: Make XEN_PMD build in combined library mode - v2

2015-12-03 Thread Christian Ehrhardt
Building RTE_LIBRTE_PMD_XENVIRT was broken when RTE_BUILD_COMBINE_LIBS was enabled (http://dpdk.org/ml/archives/dev/2015-November/028660.html). Now the underlying issue is rather simple, the xen code needs libxenstore. But rte.app.mk so far only considered that when RTE_BUILD_COMBINE_LIBS was disab

[dpdk-dev] [PATCH] cxgbe: explictly mark this as pci_driver

2015-12-03 Thread Rahul Lakkireddy
On Wednesday, December 12/02/15, 2015 at 14:16:18 -0800, Stephen Hemminger wrote: > The upcoming Hyper-V driver converts the pci_drv element > in struct eth_driver to a union. When vmbus is added the > pci_drv needs to be explicit. Easier to fix the issue > ahead of time. > > This is backwards c

[dpdk-dev] [PATCH 1/5] vhost: refactor rte_vhost_dequeue_burst

2015-12-03 Thread Yuanhan Liu
On Wed, Dec 02, 2015 at 11:02:44PM -0800, Stephen Hemminger wrote: > On Thu, 3 Dec 2015 14:06:09 +0800 > Yuanhan Liu wrote: > > > +#define COPY(dst, src) do { > > \ > > + cpy_len = RTE_MIN(desc_avail, mbuf_avail); \ > > + r

[dpdk-dev] [PATCH] mk: disable SCHED_VECTOR in the default config

2015-12-03 Thread Christian Ehrhardt
Hi Thomas, no it is not fixed by that commit. Even with it applied the remaining include subsequently at rte_vect.h:67 pulls in x86intrin.h which still ends up including smmintrin.h. Long story short is that the mentioned issues like the following still occur: /usr/lib/gcc/x86_64-linux-gnu/5/inclu

[dpdk-dev] [PATCH v4 0/2] Add support for driver directories

2015-12-03 Thread Panu Matilainen
On 12/03/2015 04:26 AM, Thomas Monjalon wrote: > 2015-12-02 18:07, Stephen Hemminger: >> On Thu, 12 Nov 2015 16:52:32 +0100 >> Thomas Monjalon wrote: >> > This mini-series adds support for driver directory concept > based on idea by Thomas Monjalon back in February: > http://dpdk.org/m

[dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script

2015-12-03 Thread Christian Ehrhardt
Hi Ferruh, while not tackling the "soname for combined lib" which I felt to be the center of all this discussion. I like that with your patch the symbols in the combined lib are no more anonymous, but versioned according to the maps the DPDK sub libraries are maintaining anyway. Some more technical

[dpdk-dev] Does anybody know OpenDataPlane

2015-12-03 Thread Kury Nicolas
De : Stephen Hemminger Envoy? : mercredi 2 d?cembre 2015 17:45 ? : Kury Nicolas Objet : Re: [dpdk-dev] Does anybody know OpenDataPlane De : Polehn, Mike A Envoy? : mercredi 2 d?cembre 2015 17:32 ? : Kury Nicolas

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Christian Ehrhardt
Hi Ferruh, some minor bash improvements that could be made in the next revision: On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit wrote: > diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh > new file mode 100755 > index 000..bc40dc8 > --- /dev/null > +++ b/scripts/merge_maps.sh > @@ -0,0

[dpdk-dev] [PATCH v2] hash: move rte_hash_set_cmp_func() to ver DPDK_2.2.

2015-12-03 Thread De Lara Guarch, Pablo
Hi Nemo, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yu Nemo Wenbin > Sent: Thursday, December 03, 2015 5:23 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH v2] hash: move rte_hash_set_cmp_func() to > ver DPDK_2.2. > > Also modified the comments of

[dpdk-dev] [PATCH v5 2/4] examples: add lthread subsystem for performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds the lightweight thread subsystem used by the performance-thread sample applications. Signed-off-by: Ian Betts --- .../performance-thread/common/arch/x86/atomic.h| 59 ++ examples/performance-thread/common/arch/x86/ctx.c | 93 +++ examples/performance-thr

[dpdk-dev] [PATCH v5 3/4] examples: add l3fwd-thread example in performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds an L3 forwarding application to the performace-thread example. Signed-off-by: Ian Betts --- config/common_linuxapp|1 + config/defconfig_i686-native-linuxapp-gcc |1 + config/defconfig_i686-native-linuxapp-icc

[dpdk-dev] [PATCH v5 0/4] examples: add performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This patchset comprises a layer 3 forwarding derivative intended to facilitate characterization of performance with different threading models, specifically:- 1. EAL threads running on different physical cores 2. EAL threads running on the same physical core 3. Lightweight thread

[dpdk-dev] [PATCH v5 1/4] doc: add sample application guide for performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds the sample application user guide for the performance thread sample application. Signed-off-by: Ian Betts --- doc/guides/sample_app_ug/performance_thread.rst | 1263 +++ 1 file changed, 1263 insertions(+) create mode 100644 doc/guides/sampl

[dpdk-dev] [PATCH v5 4/4] examples: add pthread_shim example to performance thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds an example that illustrates how to implement a pthread shim with the lthread subsystem included in the performance thread example application. Signed-off-by: Ian Betts --- examples/performance-thread/Makefile | 2 +- examples/performance-thread/

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Wed, Dec 02, 2015 at 05:57:10PM +0100, Thomas Monjalon wrote: > 2015-12-02 22:23, Jerin Jacob: > > On Wed, Dec 02, 2015 at 05:40:13PM +0100, Thomas Monjalon wrote: > > > 2015-12-02 20:04, Jerin Jacob: > > > > On Wed, Dec 02, 2015 at 09:13:51PM +0800, Jianbo Liu wrote: > > > > > On 2 December 201

[dpdk-dev] Does anybody know OpenDataPlane

2015-12-03 Thread Kury Nicolas
Hi Thank you everybody for your answers! @Jim I choose ODP as project because it was something new and I wanted to know more about the subject. I have read many documents about OpenDataPlane, I have tried it, implemented a small application, made some measures of throughput, etc. I know more

[dpdk-dev] [PATCH v5 0/4] examples: add performance-thread

2015-12-03 Thread Kulasek, TomaszX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of ibetts > Sent: Thursday, December 3, 2015 10:28 > To: dev at dpdk.org > Cc: Betts, Ian > Subject: [dpdk-dev] [PATCH v5 0/4] examples: add performance-thread > > From: Ian Betts > > This patchset comprises a

[dpdk-dev] [PATCH] remove blank lines at end-of-file

2015-12-03 Thread Bruce Richardson
On Wed, Dec 02, 2015 at 12:06:12PM -0800, Stephen Hemminger wrote: > This is one of those trivial things git and other tools complain > about. > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] remove double semicolons

2015-12-03 Thread Bruce Richardson
On Wed, Dec 02, 2015 at 01:02:32PM -0800, Stephen Hemminger wrote: > Trivial cleanup > > Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson

[dpdk-dev] [PATCH] eal: don't crash if one pci device fails

2015-12-03 Thread Bruce Richardson
On Wed, Dec 02, 2015 at 05:38:40PM -0800, Stephen Hemminger wrote: > If there is a failure to setup one pci device, there maybe other > devices that can be initialized. Don't call rte_exit which > is a forced crash, pass the error back to the > application to decide what it wants to do. > > Might

[dpdk-dev] [PATCH] eal: don't crash if one pci device fails

2015-12-03 Thread David Marchand
On Thu, Dec 3, 2015 at 2:38 AM, Stephen Hemminger < stephen at networkplumber.org> wrote: > If there is a failure to setup one pci device, there maybe other > devices that can be initialized. Don't call rte_exit which > is a forced crash, pass the error back to the > application to decide what it

[dpdk-dev] [PATCH v6 0/4] examples: add performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This patchset comprises a layer 3 forwarding derivative intended to facilitate characterization of performance with different threading models, specifically:- 1. EAL threads running on different physical cores 2. EAL threads running on the same physical core 3. Lightweight thread

[dpdk-dev] [PATCH v6 4/4] add pthread_shim example to performance thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds an example that illustrates how to implement a pthread shim with the lthread subsystem included in the performance thread example application. Signed-off-by: Ian Betts --- examples/performance-thread/Makefile | 2 + examples/performance-thread/p

[dpdk-dev] [PATCH v6 1/4] doc: add sample application guide for performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds the sample application user guide for the performance thread sample application. Signed-off-by: Ian Betts --- .../sample_app_ug/img/performance_thread_1.svg | 799 + .../sample_app_ug/img/performance_thread_2.svg | 865 ++ doc/

[dpdk-dev] [PATCH v6 2/4] add lthread subsystem for performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds the lightweight thread subsystem used by the performance-thread sample applications. Signed-off-by: Ian Betts --- .../performance-thread/common/arch/x86/atomic.h| 59 ++ examples/performance-thread/common/arch/x86/ctx.c | 93 +++ examples/performance-thr

[dpdk-dev] [PATCH v6 3/4] add l3fwd-thread example in performance-thread

2015-12-03 Thread ibetts
From: Ian Betts This commit adds an L3 forwarding application to the performace-thread example. Signed-off-by: Ian Betts --- config/common_linuxapp|1 + config/defconfig_i686-native-linuxapp-gcc |1 + config/defconfig_i686-native-linuxapp-icc

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > Following the recent discussions, this is a proposal to have a standard > installation process while keeping compatibility with most of the old > behaviours. > How compatible are we looking for here. The standard way of compiling up

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Ananyev, Konstantin
Hi Jerin, > -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > Sent: Thursday, December 03, 2015 9:34 AM > To: Thomas Monjalon > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs > > On Wed, Dec 02, 20

[dpdk-dev] [PATCH v6 0/4] examples: add performance-thread

2015-12-03 Thread Kulasek, TomaszX
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of ibetts > Sent: Thursday, December 3, 2015 11:32 > To: dev at dpdk.org > Cc: Betts, Ian > Subject: [dpdk-dev] [PATCH v6 0/4] examples: add performance-thread > > From: Ian Betts > > This patchset comprises a

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 10:57, Bruce Richardson: > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. > > > How compatible are we lo

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 12:02:42PM +0100, Thomas Monjalon wrote: > 2015-12-03 10:57, Bruce Richardson: > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > Following the recent discussions, this is a proposal to have a standard > > > installation process while keeping compatib

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 12:02, Thomas Monjalon: > 2015-12-03 10:57, Bruce Richardson: > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > Following the recent discussions, this is a proposal to have a standard > > > installation process while keeping compatibility with most of the old > >

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Bruce Richardson
On Thu, Dec 03, 2015 at 12:06:41PM +0100, Thomas Monjalon wrote: > 2015-12-03 12:02, Thomas Monjalon: > > 2015-12-03 10:57, Bruce Richardson: > > > On Thu, Dec 03, 2015 at 06:01:57AM +0100, Thomas Monjalon wrote: > > > > Following the recent discussions, this is a proposal to have a standard > > >

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 09:18:49AM +0100, Christian Ehrhardt wrote: > Hi Ferruh, > some minor bash improvements that could be made in the next revision: > > On Thu, Dec 3, 2015 at 2:22 AM, Ferruh Yigit > wrote: > > diff --git a/scripts/merge_maps.sh b/scripts/merge_maps.sh > > new file mode 1007

[dpdk-dev] [PATCH v3] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Ferruh Yigit
On Thu, Dec 03, 2015 at 03:22:39AM +0100, Thomas Monjalon wrote: > 2015-12-03 02:15, Ferruh Yigit: > > +ifeq ($(COMBINED_BUILD),1) > > include $(RTE_SDK)/mk/rte.sharelib.mk > > +endif > > I still don't understand what was the issue with this include but it > seems not related to versioning. > Ple

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen > Sent: Wednesday, December 2, 2015 4:51 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as > abi validation range > > In addition to git tags, sup

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Thu, Dec 03, 2015 at 11:02:07AM +, Ananyev, Konstantin wrote: Hi Konstantin, > Hi Jerin, > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jerin Jacob > > Sent: Thursday, December 03, 2015 9:34 AM > > To: Thomas Monjalon > > Cc: dev at dpdk.org >

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Ananyev, Konstantin
> -Original Message- > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > Sent: Thursday, December 03, 2015 12:17 PM > To: Ananyev, Konstantin > Cc: Thomas Monjalon; dev at dpdk.org; viktorin at rehivetech.com > Subject: Re: [dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pip

[dpdk-dev] [PATCH v2] mk: fix compile error and ABI versioning for combined shared library

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:22 AM, Ferruh Yigit wrote: > Fixes following error (observed when versioning macros used): >LD libdpdk.so >/usr/bin/ld: /root/dpdk/build/lib/libdpdk.so: version node not found >for symbol @DPDK_x.y > > Also resulting combined library contains symbol version information:

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Panu Matilainen
On 12/03/2015 07:02 AM, Thomas Monjalon wrote: > The examples are part of the installed documentation. > > Signed-off-by: Thomas Monjalon > --- > mk/rte.sdkinstall.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index 902a933..13fa819 10

[dpdk-dev] [PATCH 3/4] eal/arm: Enable lpm/table/pipeline libs

2015-12-03 Thread Jerin Jacob
On Thu, Dec 03, 2015 at 12:42:13PM +, Ananyev, Konstantin wrote: > > > > -Original Message- > > From: Jerin Jacob [mailto:jerin.jacob at caviumnetworks.com] > > Sent: Thursday, December 03, 2015 12:17 PM > > To: Ananyev, Konstantin > > Cc: Thomas Monjalon; dev at dpdk.org; viktorin at r

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Panu Matilainen
On 12/03/2015 07:01 AM, Thomas Monjalon wrote: > Following the recent discussions, this is a proposal to have a standard > installation process while keeping compatibility with most of the old > behaviours. > > v2 changes: > - fix default build dir > - RTE_TARGET subdir in $(sdkdir). > - better ker

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Thomas Monjalon
2015-12-03 12:14, Mcnamara, John: > Also, if someone has some bandwidth it would be good to add an option > to pass -j with an optional number to "make" in the script. We can use -j without any number: "make will not limit the number of jobs that can run simultaneously". It is a not so bad default

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:19, Panu Matilainen: > On 12/03/2015 07:02 AM, Thomas Monjalon wrote: > > The examples are part of the installed documentation. > > > > Signed-off-by: Thomas Monjalon > > --- > > mk/rte.sdkinstall.mk | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/mk/rte.sdkinstall.

[dpdk-dev] [PATCH v2 00/12] standard make install

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:26, Panu Matilainen: > On 12/03/2015 07:01 AM, Thomas Monjalon wrote: > > Following the recent discussions, this is a proposal to have a standard > > installation process while keeping compatibility with most of the old > > behaviours. > > > > v2 changes: > > - fix default build dir >

[dpdk-dev] [PATCH v2 10/12] mk: install examples

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:32 PM, Thomas Monjalon wrote: > 2015-12-03 15:19, Panu Matilainen: >> On 12/03/2015 07:02 AM, Thomas Monjalon wrote: >>> The examples are part of the installed documentation. >>> >>> Signed-off-by: Thomas Monjalon >>> --- >>>mk/rte.sdkinstall.mk | 1 + >>>1 file changed, 1

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Panu Matilainen
On 12/03/2015 02:14 PM, Mcnamara, John wrote: >> -Original Message- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Panu Matilainen >> Sent: Wednesday, December 2, 2015 4:51 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] scripts: support any legal git revisions as >> ab

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Thomas Monjalon
2015-12-03 15:39, Panu Matilainen: > > Also, if someone has some bandwidth it would be good to add an option > > to pass -j with an optional number to "make" in the script. > > Can do, although I'm still waiting fo my previous, semi-related > validate-abi patches from September to be applied...

[dpdk-dev] [PATCH] scripts: support any legal git revisions as abi validation range

2015-12-03 Thread Panu Matilainen
On 12/03/2015 03:28 PM, Thomas Monjalon wrote: > 2015-12-03 12:14, Mcnamara, John: >> Also, if someone has some bandwidth it would be good to add an option >> to pass -j with an optional number to "make" in the script. > > We can use -j without any number: > "make will not limit the number of jobs

[dpdk-dev] [PATCH v3 00/13] standard make install

2015-12-03 Thread Thomas Monjalon
Following the recent discussions, this is a proposal to have a standard installation process while keeping compatibility with most of the old behaviours. v2 changes: - fix default build dir - RTE_TARGET subdir in $(sdkdir). - better kerneldir defaults - fix dpdk_nic_bind symlink - always install d

[dpdk-dev] [PATCH v3 01/13] mk: remove testall

2015-12-03 Thread Thomas Monjalon
It is not possible to test every configs on an unique machine. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- doc/guides/prog_guide/dev_kit_root_make_help.rst | 13 -- mk/rte.sdkroot.mk| 4 -- mk/rte.sdktestall.mk |

[dpdk-dev] [PATCH v3 02/13] mk: remove multi-target install

2015-12-03 Thread Thomas Monjalon
The multi-target install create some subdirectories with the target name which is not standard for a "make install" procedure. The uninstall procedure cannot be applied properly (without removing all files in a directory). It would need to pre-compute paths. As it is a packaging issue, it is remov

[dpdk-dev] [PATCH v3 03/13] mk: move installation procedure in install rule

2015-12-03 Thread Thomas Monjalon
The real installation was called "binary install" and was done after the build when DESTDIR was specified. Remove this limitation and move the code in install rule only. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkbuild.mk | 16 mk/rte.sdkinstall.mk

[dpdk-dev] [PATCH v3 04/13] mk: install a standard cutomizable tree

2015-12-03 Thread Thomas Monjalon
The rule "install" follows these conventions: http://gnu.org/prep/standards/html_node/Directory-Variables.html http://gnu.org/prep/standards/html_node/DESTDIR.html The variable sdkdir has been added to the more standards ones, to configure the directory used with RTE_SDK when using the DPDK makefi

[dpdk-dev] [PATCH v3 05/13] mk: introduce new install syntax

2015-12-03 Thread Thomas Monjalon
The old install command was: make install T=x86_64-native-linuxapp-gcc DESTDIR=install It still works and can be replaced by these more standard commands: make config T=x86_64-native-linuxapp-gcc 0=x86_64-native-linuxapp-gcc make O=x86_64-native-linuxapp-gcc make ins

[dpdk-dev] [PATCH v3 06/13] mk: split install rule

2015-12-03 Thread Thomas Monjalon
Provides new sub-rules to install runtime and sdk separately. The build directory must be changed from BUILD_DIR to O in install rules to avoid a bad recursive effect (O being BUILD_DIR being O + T). Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/

[dpdk-dev] [PATCH v3 07/13] mk: install kernel modules

2015-12-03 Thread Thomas Monjalon
Add kernel modules to "make install". Nothing is done if there is no kernel module compiled. When using "make install T=", the default path is the same as before. The Linux path is based on host kernel version. Suggested-by: Mario Carrillo Signed-off-by: Thomas Monjalon Acked-by: Panu Matilain

[dpdk-dev] [PATCH v3 08/13] mk: install binding tool in sbin directory

2015-12-03 Thread Thomas Monjalon
sbin/dpdk_nic_bind is a symbolic link to tools/dpdk_nic_bind.py where some python objects may be generated. Signed-off-by: Thomas Monjalon Acked-by: Panu Matilainen --- mk/rte.sdkinstall.mk | 4 1 file changed, 4 insertions(+) diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index

  1   2   >