From: Thomas Monjalon
Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
app/test-pipeline/init.c | 2 +-
app/test-pmd/testpmd.c
Some duplex values are replaced from 0 to half-duplex when link is down.
Some drivers are still using their own constants for duplex modes.
Signed-off-by: Marc Sune
---
drivers/net/e1000/em_ethdev.c | 2 +-
drivers/net/e1000/igb_ethdev.c | 2 +-
drivers/net/ixgbe/ixgbe_ethdev.c | 2
The code for checking and parsing speed/duplex was duplicated.
The new function is also checking the speed/duplex combination.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c | 99 --
1 file changed, 47 insertions(+), 52 deletions(-)
diff
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_.
The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used
for bit flags in next patch.
Signed-off-by: Marc Sune
---
app/test-pmd/cmdline.c| 10 +-
app/test/virtual_pmd.c| 2 +-
This patch redesigns the API to set the link speed/s configuration
of an ethernet port. Specifically:
- it allows to define a set of advertised speeds for
auto-negociation.
- it allows to disable link auto-negociation (single fixed speed).
- default: auto-negociate all supported speeds.
A flag
It is a helper for the bitmap configuration.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.c | 31 +++
lib/librte_ether/rte_ethdev.h | 13 +
lib/librte_ether/rte_ether_version.map | 1 +
3
From: Thomas Monjalon
The link speed configuration is now done with bitmaps so 100G speed
requires only a new bit flag.
The actual link speed is a number so its size must be increased from
16-bit to 32-bit.
Signed-off-by: Marc Sune
Signed-off-by: Thomas Monjalon
Hi Thaomas,
> From: Bruce Richardson [mailto:bruce.richardson at intel.com]
> Sent: Tuesday, March 22, 2016 7:30 AM
>
> On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote:
> > Signed-off-by: Harish Patil
> > Signed-off-by: Rasesh Mody
> > ---
> > drivers/net/bnx2x/bnx2x.c|
Hi Konstantin,
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Thursday, March 31, 2016 3:30 PM
> To: Lu, Wenzhuo; dev at dpdk.org
> Cc: Lu, Wenzhuo
> Subject: RE: [dpdk-dev] [PATCH] igb: change default RX wthresh back
>
>
> Hi Wenzhuo,
> >
> > A problem is found on i350 VF. TX
The issue is the VF's link speed kept as 10G and status always was up.
It did not change even the physical link's status changed.
This patch fixes this issue to make VF's link info consistent with
physical link.
Fixes: 4861cde46116 (i40e: new poll mode driver)
Signed-off-by: Jingjing Wu
---
A problem is found on i350 VF. We found TX will happen once
per 4 packets. If only 1~3 packets are received, they will
not be forwarded. But the real problem is on RX side. The
reason is the default RX write-back threshold is changed to
4, so every first 3 packets may be hung there.
This patch
On 03/31/2016 06:02 PM, Thomas Monjalon wrote:
> 2016-03-22 17:37, Aaron Conole:
>> This series brings a number of code cleanups to allow building using gcc6,
>> with various legitimate warnings being fixed.
>>
>> Some of these fixes are to the drivers area, making this series a bit
>> atypical.
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley
> Sent: Saturday, March 26, 2016 12:45 AM
> To: dev at dpdk.org
> Cc: Nelson Escobar ; John Daley
> Subject: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt
> mode
>
> From:
The memory zone could be freed just after adding it to the metadata
file and just before marking it as not freeable.
This patch changes the locking logic in order to prevent it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
Update the overview.rst for e1000, igb, ixgbe.
Signed-off-by: Wenzhuo Lu
---
doc/guides/nics/overview.rst | 94 ++--
1 file changed, 47 insertions(+), 47 deletions(-)
diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst
index
Sure: http://dpdk.org/ml/archives/dev/2016-April/036884.html,
On Wed, Mar 30, 2016 at 2:10 PM, Burakov, Anatoly wrote:
> Hi Mauricio,
>
>
>
> Good points. Would you be willing to prepare a patch to fix these issues?
>
>
>
> Thanks,
>
> Anatoly
>
>
>
> *From:* Mauricio V?squez
2016-03-31 17:15, Rasesh Mody:
> Enhance the stats_get() routine to display drop counters under the
> control of a debug flag.
Why printing the stats in stats_get?
These stats should be returned in xstats.
Hi Jingjing,
Please rebase on top of Marc's patches.
2016-04-01 09:36, Jingjing Wu:
> +* **i40e: Fixed link info of VF
a blank line is missing
> + Previously, the VF's link speed kept as 10G and status always was up. It
> did not
> + change even the physical link's status changed. Now this
From: "Chen Jing D(Mark)"
Add feature support list for fm10k, fm10k-vec, fm10kvf and
fm10kvf-vec.
Signed-off-by: Chen Jing D(Mark)
---
doc/guides/nics/overview.rst | 86 +-
1 files changed, 43 insertions(+), 43 deletions(-)
From: "Chen Jing D(Mark)"
Add feature support list for fm10k, fm10k-vec, fm10kvf and
fm10kvf-vec.
Signed-off-by: Chen Jing D(Mark)
---
v2:
- fix a typo
doc/guides/nics/overview.rst | 86 +-
1 files changed, 43 insertions(+),
Hi Mauricio,
> The memory zone could be freed just after adding it to the metadata
> file and just before marking it as not freeable.
> This patch changes the locking logic in order to prevent it.
Just a nit: if the stated purpose of the patch is to prevent the memzone free
before adding it to
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Thursday, March 31, 2016 8:29 PM
> To: Xing, Beilei
> Cc: dev at dpdk.org; Marc ; Xu, Qian Q
> ; Ananyev, Konstantin intel.com>;
> Lu, Wenzhuo ; Richardson, Bruce
> ; Glynn, Michael J intel.com>
>
Fixes: eb5f411 ("port: add pcap file dump")
This patch fixes pcap supporting logic. The fix includes:
* Adding logic to detect illegal parameter.
* Clearer error message display.
* Remove unnecessary RTE_NEXT_ABI macro warping.
* Code clean-up
Signed-off-by: Fan Zhang
Acked-by: Cristian
Fixes: fe5d046 ("examples/ip_pipeline: add pcap file dump")
This patch fixes the pcap file parsing in ip_pipeline. Originally, the
parser recognizes the pcap related entries regardless of the RTE_PORT_PCAP
macro definition status.
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
The title don't talk about pcap. Is it touching only pcap?
2016-04-01 10:55, Fan Zhang:
> Fixes: eb5f411 ("port: add pcap file dump")
>
> This patch fixes pcap supporting logic. The fix includes:
What was the issue?
> * Adding logic to detect illegal parameter.
> * Clearer error message
2016-03-30 23:39, Chao Zhu:
> This patch set fixes CPU/memory parameters and correct wrong prefetch
> settings for IBM POWER8.
> Changes in v2:
> 1. Move the parameter configuration to POWER specific configuration file
> 2. Remove the memeory channel number constraint instead of adding additional
Hi Anatoly,
On Fri, Apr 1, 2016 at 11:01 AM, Burakov, Anatoly wrote:
> Hi Mauricio,
>
> > The memory zone could be freed just after adding it to the metadata
> > file and just before marking it as not freeable.
> > This patch changes the locking logic in order to prevent it.
>
> Just a nit: if
The memory zone could be freed just after adding it to the metadata
file and just before marking it as not freeable.
This patch changes the locking logic in order to prevent it.
Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
Signed-off-by: Mauricio Vasquez B
---
A new process to request the libsso library required by the SNOW3G PMD
has been put in place, through a website, replacing the previous email method.
This commit updates the SNOW3G documentation, to reflect this change.
Since the library does not support newer gcc versions, the documentation
also
> The memory zone could be freed just after adding it to the metadata
> file and just before marking it as not freeable.
> This patch changes the locking logic in order to prevent it.
>
> Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
>
> Signed-off-by: Mauricio Vasquez B
>
> ---
>
While parsing token string there may be several modes:
- fixed single string
- multi-choice single string
- any single string
This patch add one more mode - any multi string.
Signed-off-by: Piotr Azarewicz
---
app/test/test_cmdline_string.c|9 ---
Loop that calculates total number of tx descriptors in slave tx queues should
iterate up to nb_tx_queues, not nb_rx_queues.
Signed-off-by: Vladyslav Buslov
---
drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
> -Original Message-
> From: Lu, Wenzhuo
> Sent: Friday, April 01, 2016 3:09 AM
> To: dev at dpdk.org
> Cc: Ananyev, Konstantin
> Subject: [PATCH] igb: fix i350 VF RX issue
>
> A problem is found on i350 VF. We found TX will happen once
> per 4 packets. If only 1~3 packets are received,
2016-03-29 18:38, Pablo de Lara:
> rte_hash_set_cmp_func() had an incorrect Doxygen comment
> for one of its parameters.
>
> Fixes: 95da2f8e9c61 ("hash: customize compare function")
>
> Signed-off-by: Pablo de Lara
Applied, thanks
Hi Pablo,
There is a build issue for arm-armv7a-linuxapp-gcc:
lib/librte_hash/rte_cuckoo_hash.c:129:2: error:
'rte_hash_k16_cmp_eq' undeclared here
The functions rte_hash_k*_cmp_eq are defined only for x86 and ARM64.
Note that RTE_ARCH_X86 could be used instead of
2016-03-24 14:00, De Lara Guarch, Pablo:
> Hi,
>
> I just sent an alternative patch to solve the issue, without requiring
> #ifdefs.
> Could you take a look at it and check that works for you?
Please Dhananjaya Eadala,
Could you confirm the bug is fixed with this patch:
> > From: Nelson Escobar
> >
> > Stopping then re-starting a bond interface containing slaves that
> > used polling for link detection caused the bond to think all slave
> > links were down and inactive.
> >
> > Move the start of the polling for link from slave_add() to
> > bond_ethdev_start()
2016-04-01 15:16, Vladyslav Buslov:
> Loop that calculates total number of tx descriptors in slave tx queues should
> iterate up to nb_tx_queues, not nb_rx_queues.
>
> Signed-off-by: Vladyslav Buslov
Fixes: 3ef7955700e7 ("bonding: fix LACP mempool size")
Applied, thanks
On 26/03/16 00:44, John Daley wrote:
> From: Nelson Escobar
>
> Stopping then re-starting a bond interface containing slaves that
> used polling for link detection caused the bond to think all slave
> links were down and inactive.
>
> Move the start of the polling for link from slave_add() to
>
> > The memory zone could be freed just after adding it to the metadata
> > file and just before marking it as not freeable.
> > This patch changes the locking logic in order to prevent it.
> >
> > Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing")
> >
> > Signed-off-by: Mauricio Vasquez B
> >
>
This patchset fixes d4b4213 and eb5f411, plus code clean-up of port library.
Acked-by: Cristian Dumitrescu
Fan Zhang (3):
port: fix source port parameter check
port: fix sink port parameter check
port: code clean-up
lib/librte_port/Makefile | 5 -
Fixes: eb5f411 ("port: add pcap file dump")
This patch fixes sink port parameter checking logic. Originally, if user
set field "file_name" with meaning value but leave PCAP support feature
disabled, the program simply ignores this field without notifying the
user.
Signed-off-by: Fan Zhang
This patch clean-up the code in librte_port. The clean-up includes the
following:
* Clearer error message display.
* Remove unnecessary RTE_NEXT_ABI macro warping.
* Remove __rte_unused attribute
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
lib/librte_port/Makefile
2016-03-26 04:32, Rami Rosen:
> This patch removes several redundant forward declarations
> in i40e_fdir.c.
I have the feeling that writing some useless forward declarations
is common in some drivers.
So why removing only these ones? Are they the only one in i40e?
2016-04-01 10:08, Wenzhuo Lu:
> A problem is found on i350 VF. We found TX will happen once
> per 4 packets. If only 1~3 packets are received, they will
> not be forwarded. But the real problem is on RX side. The
> reason is the default RX write-back threshold is changed to
> 4, so every first 3
2016-04-01 14:41, Fan Zhang:
> --- a/mk/rte.app.mk
> +++ b/mk/rte.app.mk
> @@ -92,9 +92,7 @@ endif
> ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)
> _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse
> endif
> -ifeq ($(CONFIG_RTE_NEXT_ABI),y)
> _LDLIBS-$(CONFIG_RTE_PORT_PCAP) +=
Hi Thomas,
The reason for removing RTE_NEXT_ABI here is caused by sink port, which
is not wrapped by RTE_NEXT_ABI macro.
If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original
code will cause the compile error as pcap library is missing.
Regards,
Fan
On 01/04/2016 14:56,
2016-03-31 02:21, Jerin Jacob:
> - added VXLAN, GENEVE and NVGRE tunnel flow types
> - added PORT flow type for accounting physical/virtual
> port or channel number in flow creation
These API change could be considered for 16.07 if they are motivated
by any use. Please bring some use cases,
Hi Thomas,
The reason for removing RTE_NEXT_ABI here is caused by sink port, which is not
wrapped by RTE_NEXT_ABI macro.
If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original code
will cause the compile error as pcap library is missing.
Regards,
Fan
-Original
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, April 01, 2016 2:07 PM
> To: De Lara Guarch, Pablo
> Cc: dev at dpdk.org; Richardson, Bruce
> Subject: Re: [dpdk-dev] [PATCH v2] hash: fix to support multi process
>
> Hi Pablo,
Please Anatoly,
What do you think of this patch?
2015-12-19 23:39, David Verbeiren:
> This patch aligns the logic used to check for the presence of
> adjacent segments in has_adjacent_segments() with the logic used
> in cleanup_segments() when actually deciding to concatenate or
> not a pair of
On Fri, Apr 01, 2016 at 04:04:13PM +0200, Thomas Monjalon wrote:
> 2016-03-31 02:21, Jerin Jacob:
> > - added VXLAN, GENEVE and NVGRE tunnel flow types
> > - added PORT flow type for accounting physical/virtual
> > port or channel number in flow creation
>
> These API change could be considered
> Please Anatoly,
> What do you think of this patch?
>
> 2015-12-19 23:39, David Verbeiren:
> > This patch aligns the logic used to check for the presence of adjacent
> > segments in has_adjacent_segments() with the logic used in
> > cleanup_segments() when actually deciding to concatenate or not
>
>
>> -Original Message-
>> From: Robert Sanford [mailto:rsanford2 at gmail.com]
>> Sent: Monday, March 28, 2016 9:52 PM
>> To: dev at dpdk.org; Dumitrescu, Cristian
>> Subject: [PATCH 2/4] port: fix ring writer buffer overflow
>>
>> Ring writer tx_bulk functions may write past the
This patchset fixes the hash library to support multi-process.
It also replaces several RTE_ARCH_* with RTE_ARCH_X86, for simplicity.
Changes in v3:
- Added new #ifdefs, to fix ARMv7 compilation
- Replaced RTE_ARCH_* for X86 macros
Changes in v2:
- Added missing const
- Added extra info in
Instead of using RTE_ARCH_X86_64, RTE_ARCH_X86_32
and RTE_ARCH_I686, use directly RTTE_ARCH_X86
Signed-off-by: Pablo de Lara
---
lib/librte_hash/rte_cuckoo_hash.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/librte_hash/rte_cuckoo_hash.c
Hash library used a function pointer to choose a different
key compare function, depending on the key size.
As a result, multiple processes could not use the same hash table,
as the function addresses vary from one process to another.
Instead, a jump table is used, so each process has its own
This patch fills the missing field of ipv4_5tuple structure in acl table
test.
Signed-off-by: Fan Zhang
Acked-by: Cristian Dumitrescu
---
app/test/test_table_acl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c
index
On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody wrote:
> +struct qed_filter_ucast_params {
> + enum qed_filter_xcast_params_type type;
> + uint8_t vlan_valid;
> + uint16_t vlan;
> + uint8_t mac_valid;
> + unsigned char mac[ETHER_ADDR_LEN];
> +} __attribute__ ((__packed__));
On Thu, 31 Mar 2016 19:15:22 -0700
Rasesh Mody wrote:
> +struct qed_filter_mcast_params {
> + enum qed_filter_xcast_params_type type;
> + uint8_t num;
> + unsigned char mac[64][ETHER_ADDR_LEN];
> +};
Would prefer a #define constant for the maximum number of multicast
addresses
On Thu, 31 Mar 2016 19:15:17 -0700
Rasesh Mody wrote:
> Hi Thomas, Bruce,
>
> The v5 series incorporates the following review comments:
> - move adapter_info logs under debug
> - implement qede_mac_addr_remove()
> - remove unused rc variable in qede_dev_configure()
> - fix indentation in
>
>On Thu, 31 Mar 2016 19:15:17 -0700
>Rasesh Mody wrote:
>
>> Hi Thomas, Bruce,
>>
>> The v5 series incorporates the following review comments:
>> - move adapter_info logs under debug
>> - implement qede_mac_addr_remove()
>> - remove unused rc variable in qede_dev_configure()
>> - fix
2016-03-26 00:10, Tan, Jianfeng:
> On 3/25/2016 10:21 PM, Bruce Richardson wrote:
> > On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote:
> >> --- a/doc/guides/nics/overview.rst
> >> +++ b/doc/guides/nics/overview.rst
> >> @@ -124,7 +124,7 @@ Most of these differences are summarized
> > Please Anatoly,
> > What do you think of this patch?
> >
> > 2015-12-19 23:39, David Verbeiren:
> > > This patch aligns the logic used to check for the presence of
> > > adjacent segments in has_adjacent_segments() with the logic used in
> > > cleanup_segments() when actually deciding to
Hi Cristian,
Please see my comments inline.
>
>
>> -Original Message-
>> From: Robert Sanford [mailto:rsanford2 at gmail.com]
>> Sent: Monday, March 28, 2016 9:52 PM
>> To: dev at dpdk.org; Dumitrescu, Cristian
>> Subject: [PATCH 4/4] port: fix ethdev writer burst too big
>>
>> For
On 03/31/2016 09:35 AM, Olivier Matz wrote:
> On 03/30/2016 11:46 PM, Stephen Hemminger wrote:
>> with older memzone model, objects in huge memory area were never freed.
>> That means when application restarts it finds the old LPM and works.
>> With your change it would break such an
2016-04-01 16:03, Pablo de Lara:
> This patchset fixes the hash library to support multi-process.
>
> It also replaces several RTE_ARCH_* with RTE_ARCH_X86, for simplicity.
>
> Changes in v3:
> - Added new #ifdefs, to fix ARMv7 compilation
> - Replaced RTE_ARCH_* for X86 macros
>
> Changes in
The new compiler option -Og causes a few warning on variables
being used before being set warnings. The new option allows better
debugging then -O0 without losing a lot of performance. This option
does not include -g debug symbol option.
Signed-off-by: Keith Wiles
---
Hi Cristian,
In hindsight, I was overly agressive in proposing the same change
(approach #2, as you call it below) for rte_port_ring and rte_port_sched.
Changing local variable bsz_mask to uint64_t should be sufficient.
Please see additional comments inline below.
On 3/31/16 11:41 AM,
2016-04-01 00:12, Marc Sune:
> From: Marc Sune
>
> This series of patches adds the following capabilities:
>
> * speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs
> according to the physical device capabilities.
> * refactors link API in ethdev to allow the definition of the
We don't need to change this line, because we never access more than
RTE_PORT_IN_BURST_SIZE_MAX (64) elements in this array:
- struct rte_mbuf *mbuf[RTE_PORT_IN_BURST_SIZE_MAX];
+ struct rte_mbuf *mbuf[2 * RTE_PORT_IN_BURST_SIZE_MAX];
--
Robert
>Add code to send two 60-packet
Signed-off-by: Thomas Monjalon
---
scripts/test-build.sh | 4
1 file changed, 4 insertions(+)
diff --git a/scripts/test-build.sh b/scripts/test-build.sh
index a486244..c37fc99 100755
--- a/scripts/test-build.sh
+++ b/scripts/test-build.sh
@@ -44,6 +44,7 @@ default_path=$PATH
# -
2016-04-01 14:41, Fan Zhang:
> This patchset fixes d4b4213 and eb5f411, plus code clean-up of port library.
>
> Acked-by: Cristian Dumitrescu
>
> Fan Zhang (3):
> port: fix source port parameter check
> port: fix sink port parameter check
> port: code clean-up
Applied, thanks
2016-04-01 10:55, Fan Zhang:
> Fixes: fe5d046 ("examples/ip_pipeline: add pcap file dump")
>
> This patch fixes the pcap file parsing in ip_pipeline. Originally, the
> parser recognizes the pcap related entries regardless of the RTE_PORT_PCAP
> macro definition status.
>
> Signed-off-by: Fan
From: Marc Sune
This series of patches adds the following capabilities:
* speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs
according to the physical device capabilities.
* refactors link API in ethdev to allow the definition of the advertised
link speeds,
75 matches
Mail list logo