[dpdk-dev] [PATCH v14 1/8] ethdev: use constants for link state

2016-04-01 Thread Marc Sune
From: Thomas Monjalon Define and use ETH_LINK_UP and ETH_LINK_DOWN where appropriate. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- app/test-pipeline/init.c | 2 +- app/test-pmd/testpmd.c

[dpdk-dev] [PATCH v14 2/8] ethdev: use constants for link duplex

2016-04-01 Thread Marc Sune
Some duplex values are replaced from 0 to half-duplex when link is down. Some drivers are still using their own constants for duplex modes. Signed-off-by: Marc Sune --- drivers/net/e1000/em_ethdev.c | 2 +- drivers/net/e1000/igb_ethdev.c | 2 +- drivers/net/ixgbe/ixgbe_ethdev.c | 2

[dpdk-dev] [PATCH v14 3/8] app/testpmd: move speed and duplex parsing in a function

2016-04-01 Thread Marc Sune
The code for checking and parsing speed/duplex was duplicated. The new function is also checking the speed/duplex combination. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c | 99 -- 1 file changed, 47 insertions(+), 52 deletions(-) diff

[dpdk-dev] [PATCH v14 4/8] ethdev: rename link speed constants

2016-04-01 Thread Marc Sune
The speed numbers ETH_LINK_SPEED_ are renamed ETH_SPEED_NUM_. The prefix ETH_LINK_SPEED_ is kept for AUTONEG and will be used for bit flags in next patch. Signed-off-by: Marc Sune --- app/test-pmd/cmdline.c| 10 +- app/test/virtual_pmd.c| 2 +-

[dpdk-dev] [PATCH v14 6/8] ethdev: redesign link speed config

2016-04-01 Thread Marc Sune
This patch redesigns the API to set the link speed/s configuration of an ethernet port. Specifically: - it allows to define a set of advertised speeds for auto-negociation. - it allows to disable link auto-negociation (single fixed speed). - default: auto-negociate all supported speeds. A flag

[dpdk-dev] [PATCH v14 7/8] ethdev: convert speed number to bitmap flag

2016-04-01 Thread Marc Sune
It is a helper for the bitmap configuration. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon --- lib/librte_ether/rte_ethdev.c | 31 +++ lib/librte_ether/rte_ethdev.h | 13 + lib/librte_ether/rte_ether_version.map | 1 + 3

[dpdk-dev] [PATCH v14 8/8] ethdev: add 100G link speed

2016-04-01 Thread Marc Sune
From: Thomas Monjalon The link speed configuration is now done with bitmaps so 100G speed requires only a new bit flag. The actual link speed is a number so its size must be increased from 16-bit to 32-bit. Signed-off-by: Marc Sune Signed-off-by: Thomas Monjalon

[dpdk-dev] [PATCH 2/3] bnx2x: Tx performance improvement fixes

2016-04-01 Thread Rasesh Mody
Hi Thaomas, > From: Bruce Richardson [mailto:bruce.richardson at intel.com] > Sent: Tuesday, March 22, 2016 7:30 AM > > On Thu, Mar 10, 2016 at 05:47:56PM -0800, Rasesh Mody wrote: > > Signed-off-by: Harish Patil > > Signed-off-by: Rasesh Mody > > --- > > drivers/net/bnx2x/bnx2x.c|

[dpdk-dev] [PATCH] igb: change default RX wthresh back

2016-04-01 Thread Lu, Wenzhuo
Hi Konstantin, > -Original Message- > From: Ananyev, Konstantin > Sent: Thursday, March 31, 2016 3:30 PM > To: Lu, Wenzhuo; dev at dpdk.org > Cc: Lu, Wenzhuo > Subject: RE: [dpdk-dev] [PATCH] igb: change default RX wthresh back > > > Hi Wenzhuo, > > > > A problem is found on i350 VF. TX

[dpdk-dev] [PATCH] i40evf: fix link info update

2016-04-01 Thread Jingjing Wu
The issue is the VF's link speed kept as 10G and status always was up. It did not change even the physical link's status changed. This patch fixes this issue to make VF's link info consistent with physical link. Fixes: 4861cde46116 (i40e: new poll mode driver) Signed-off-by: Jingjing Wu ---

[dpdk-dev] [PATCH] igb: fix i350 VF RX issue

2016-04-01 Thread Wenzhuo Lu
A problem is found on i350 VF. We found TX will happen once per 4 packets. If only 1~3 packets are received, they will not be forwarded. But the real problem is on RX side. The reason is the default RX write-back threshold is changed to 4, so every first 3 packets may be hung there. This patch

[dpdk-dev] [PATCH v2 0/7] Various fixes to compile with gcc6

2016-04-01 Thread Panu Matilainen
On 03/31/2016 06:02 PM, Thomas Monjalon wrote: > 2016-03-22 17:37, Aaron Conole: >> This series brings a number of code cleanups to allow building using gcc6, >> with various legitimate warnings being fixed. >> >> Some of these fixes are to the drivers area, making this series a bit >> atypical.

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-04-01 Thread Doherty, Declan
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of John Daley > Sent: Saturday, March 26, 2016 12:45 AM > To: dev at dpdk.org > Cc: Nelson Escobar ; John Daley > Subject: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt > mode > > From:

[dpdk-dev] [PATCH] ivshmem: fix race condition

2016-04-01 Thread Mauricio Vasquez B
The memory zone could be freed just after adding it to the metadata file and just before marking it as not freeable. This patch changes the locking logic in order to prevent it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B ---

[dpdk-dev] [PATCH] doc: update overview

2016-04-01 Thread Wenzhuo Lu
Update the overview.rst for e1000, igb, ixgbe. Signed-off-by: Wenzhuo Lu --- doc/guides/nics/overview.rst | 94 ++-- 1 file changed, 47 insertions(+), 47 deletions(-) diff --git a/doc/guides/nics/overview.rst b/doc/guides/nics/overview.rst index

[dpdk-dev] Question about cd10c42eb5bc ("mem: fix ivshmem freeing")

2016-04-01 Thread Mauricio Vásquez
Sure: http://dpdk.org/ml/archives/dev/2016-April/036884.html, On Wed, Mar 30, 2016 at 2:10 PM, Burakov, Anatoly wrote: > Hi Mauricio, > > > > Good points. Would you be willing to prepare a patch to fix these issues? > > > > Thanks, > > Anatoly > > > > *From:* Mauricio V?squez

[dpdk-dev] [PATCH v2 3/4] bnx2x: Enhance stats get routine

2016-04-01 Thread Thomas Monjalon
2016-03-31 17:15, Rasesh Mody: > Enhance the stats_get() routine to display drop counters under the > control of a debug flag. Why printing the stats in stats_get? These stats should be returned in xstats.

[dpdk-dev] [PATCH] i40evf: fix link info update

2016-04-01 Thread Thomas Monjalon
Hi Jingjing, Please rebase on top of Marc's patches. 2016-04-01 09:36, Jingjing Wu: > +* **i40e: Fixed link info of VF a blank line is missing > + Previously, the VF's link speed kept as 10G and status always was up. It > did not > + change even the physical link's status changed. Now this

[dpdk-dev] [PATCH] doc: update nic overview

2016-04-01 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add feature support list for fm10k, fm10k-vec, fm10kvf and fm10kvf-vec. Signed-off-by: Chen Jing D(Mark) --- doc/guides/nics/overview.rst | 86 +- 1 files changed, 43 insertions(+), 43 deletions(-)

[dpdk-dev] [PATCH v2] doc: update nic overview

2016-04-01 Thread Chen Jing D(Mark)
From: "Chen Jing D(Mark)" Add feature support list for fm10k, fm10k-vec, fm10kvf and fm10kvf-vec. Signed-off-by: Chen Jing D(Mark) --- v2: - fix a typo doc/guides/nics/overview.rst | 86 +- 1 files changed, 43 insertions(+),

[dpdk-dev] [PATCH] ivshmem: fix race condition

2016-04-01 Thread Burakov, Anatoly
Hi Mauricio, > The memory zone could be freed just after adding it to the metadata > file and just before marking it as not freeable. > This patch changes the locking logic in order to prevent it. Just a nit: if the stated purpose of the patch is to prevent the memzone free before adding it to

[dpdk-dev] [PATCH v13 6/8] ethdev: redesign link speed config

2016-04-01 Thread Xing, Beilei
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Thursday, March 31, 2016 8:29 PM > To: Xing, Beilei > Cc: dev at dpdk.org; Marc ; Xu, Qian Q > ; Ananyev, Konstantin intel.com>; > Lu, Wenzhuo ; Richardson, Bruce > ; Glynn, Michael J intel.com> >

[dpdk-dev] [PATCH] port: fix source and sink port

2016-04-01 Thread Fan Zhang
Fixes: eb5f411 ("port: add pcap file dump") This patch fixes pcap supporting logic. The fix includes: * Adding logic to detect illegal parameter. * Clearer error message display. * Remove unnecessary RTE_NEXT_ABI macro warping. * Code clean-up Signed-off-by: Fan Zhang Acked-by: Cristian

[dpdk-dev] [PATCH] examples/ip_pipeline: fix pcap file parsing

2016-04-01 Thread Fan Zhang
Fixes: fe5d046 ("examples/ip_pipeline: add pcap file dump") This patch fixes the pcap file parsing in ip_pipeline. Originally, the parser recognizes the pcap related entries regardless of the RTE_PORT_PCAP macro definition status. Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu ---

[dpdk-dev] [PATCH] port: fix source and sink port

2016-04-01 Thread Thomas Monjalon
The title don't talk about pcap. Is it touching only pcap? 2016-04-01 10:55, Fan Zhang: > Fixes: eb5f411 ("port: add pcap file dump") > > This patch fixes pcap supporting logic. The fix includes: What was the issue? > * Adding logic to detect illegal parameter. > * Clearer error message

[dpdk-dev] [PATCH v2 0/2] Fix parameters and prefetch function on IBM POWER8

2016-04-01 Thread Thomas Monjalon
2016-03-30 23:39, Chao Zhu: > This patch set fixes CPU/memory parameters and correct wrong prefetch > settings for IBM POWER8. > Changes in v2: > 1. Move the parameter configuration to POWER specific configuration file > 2. Remove the memeory channel number constraint instead of adding additional

[dpdk-dev] [PATCH] ivshmem: fix race condition

2016-04-01 Thread Mauricio Vásquez
Hi Anatoly, On Fri, Apr 1, 2016 at 11:01 AM, Burakov, Anatoly wrote: > Hi Mauricio, > > > The memory zone could be freed just after adding it to the metadata > > file and just before marking it as not freeable. > > This patch changes the locking logic in order to prevent it. > > Just a nit: if

[dpdk-dev] [PATCH v2] ivshmem: fix race condition

2016-04-01 Thread Mauricio Vasquez B
The memory zone could be freed just after adding it to the metadata file and just before marking it as not freeable. This patch changes the locking logic in order to prevent it. Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") Signed-off-by: Mauricio Vasquez B ---

[dpdk-dev] [PATCH] doc: update the snow3g library information

2016-04-01 Thread Pablo de Lara
A new process to request the libsso library required by the SNOW3G PMD has been put in place, through a website, replacing the previous email method. This commit updates the SNOW3G documentation, to reflect this change. Since the library does not support newer gcc versions, the documentation also

[dpdk-dev] [PATCH v2] ivshmem: fix race condition

2016-04-01 Thread Burakov, Anatoly
> The memory zone could be freed just after adding it to the metadata > file and just before marking it as not freeable. > This patch changes the locking logic in order to prevent it. > > Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") > > Signed-off-by: Mauricio Vasquez B > > --- >

[dpdk-dev] [PATCH v1 1/1] cmdline: add any multi string mode to token string

2016-04-01 Thread Piotr Azarewicz
While parsing token string there may be several modes: - fixed single string - multi-choice single string - any single string This patch add one more mode - any multi string. Signed-off-by: Piotr Azarewicz --- app/test/test_cmdline_string.c|9 ---

[dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition

2016-04-01 Thread Vladyslav Buslov
Loop that calculates total number of tx descriptors in slave tx queues should iterate up to nb_tx_queues, not nb_rx_queues. Signed-off-by: Vladyslav Buslov --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[dpdk-dev] [PATCH] igb: fix i350 VF RX issue

2016-04-01 Thread Ananyev, Konstantin
> -Original Message- > From: Lu, Wenzhuo > Sent: Friday, April 01, 2016 3:09 AM > To: dev at dpdk.org > Cc: Ananyev, Konstantin > Subject: [PATCH] igb: fix i350 VF RX issue > > A problem is found on i350 VF. We found TX will happen once > per 4 packets. If only 1~3 packets are received,

[dpdk-dev] [PATCH v2] hash: fix typo in Doxygen comment

2016-04-01 Thread Thomas Monjalon
2016-03-29 18:38, Pablo de Lara: > rte_hash_set_cmp_func() had an incorrect Doxygen comment > for one of its parameters. > > Fixes: 95da2f8e9c61 ("hash: customize compare function") > > Signed-off-by: Pablo de Lara Applied, thanks

[dpdk-dev] [PATCH v2] hash: fix to support multi process

2016-04-01 Thread Thomas Monjalon
Hi Pablo, There is a build issue for arm-armv7a-linuxapp-gcc: lib/librte_hash/rte_cuckoo_hash.c:129:2: error: 'rte_hash_k16_cmp_eq' undeclared here The functions rte_hash_k*_cmp_eq are defined only for x86 and ARM64. Note that RTE_ARCH_X86 could be used instead of

[dpdk-dev] [PATCH] hash: fix memcmp function pointer in multi-process environment

2016-04-01 Thread Thomas Monjalon
2016-03-24 14:00, De Lara Guarch, Pablo: > Hi, > > I just sent an alternative patch to solve the issue, without requiring > #ifdefs. > Could you take a look at it and check that works for you? Please Dhananjaya Eadala, Could you confirm the bug is fixed with this patch:

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-04-01 Thread Thomas Monjalon
> > From: Nelson Escobar > > > > Stopping then re-starting a bond interface containing slaves that > > used polling for link detection caused the bond to think all slave > > links were down and inactive. > > > > Move the start of the polling for link from slave_add() to > > bond_ethdev_start()

[dpdk-dev] [PATCH] bonding: fix incorrect loop boundary condition

2016-04-01 Thread Thomas Monjalon
2016-04-01 15:16, Vladyslav Buslov: > Loop that calculates total number of tx descriptors in slave tx queues should > iterate up to nb_tx_queues, not nb_rx_queues. > > Signed-off-by: Vladyslav Buslov Fixes: 3ef7955700e7 ("bonding: fix LACP mempool size") Applied, thanks

[dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode

2016-04-01 Thread Declan Doherty
On 26/03/16 00:44, John Daley wrote: > From: Nelson Escobar > > Stopping then re-starting a bond interface containing slaves that > used polling for link detection caused the bond to think all slave > links were down and inactive. > > Move the start of the polling for link from slave_add() to >

[dpdk-dev] [PATCH v2] ivshmem: fix race condition

2016-04-01 Thread Thomas Monjalon
> > The memory zone could be freed just after adding it to the metadata > > file and just before marking it as not freeable. > > This patch changes the locking logic in order to prevent it. > > > > Fixes: cd10c42eb5bc ("mem: fix ivshmem freeing") > > > > Signed-off-by: Mauricio Vasquez B > > >

[dpdk-dev] [PATCH 0/3] bug fix and code clean-up

2016-04-01 Thread Fan Zhang
This patchset fixes d4b4213 and eb5f411, plus code clean-up of port library. Acked-by: Cristian Dumitrescu Fan Zhang (3): port: fix source port parameter check port: fix sink port parameter check port: code clean-up lib/librte_port/Makefile | 5 -

[dpdk-dev] [PATCH 2/3] port: fix sink port parameter check

2016-04-01 Thread Fan Zhang
Fixes: eb5f411 ("port: add pcap file dump") This patch fixes sink port parameter checking logic. Originally, if user set field "file_name" with meaning value but leave PCAP support feature disabled, the program simply ignores this field without notifying the user. Signed-off-by: Fan Zhang

[dpdk-dev] [PATCH 3/3] port: code clean-up

2016-04-01 Thread Fan Zhang
This patch clean-up the code in librte_port. The clean-up includes the following: * Clearer error message display. * Remove unnecessary RTE_NEXT_ABI macro warping. * Remove __rte_unused attribute Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu --- lib/librte_port/Makefile

[dpdk-dev] [PATCH] i40e: Remove redundant fdir forward declarations.

2016-04-01 Thread Thomas Monjalon
2016-03-26 04:32, Rami Rosen: > This patch removes several redundant forward declarations > in i40e_fdir.c. I have the feeling that writing some useless forward declarations is common in some drivers. So why removing only these ones? Are they the only one in i40e?

[dpdk-dev] [PATCH] igb: fix i350 VF RX issue

2016-04-01 Thread Thomas Monjalon
2016-04-01 10:08, Wenzhuo Lu: > A problem is found on i350 VF. We found TX will happen once > per 4 packets. If only 1~3 packets are received, they will > not be forwarded. But the real problem is on RX side. The > reason is the default RX write-back threshold is changed to > 4, so every first 3

[dpdk-dev] [PATCH 3/3] port: code clean-up

2016-04-01 Thread Thomas Monjalon
2016-04-01 14:41, Fan Zhang: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -92,9 +92,7 @@ endif > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse > endif > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > _LDLIBS-$(CONFIG_RTE_PORT_PCAP) +=

[dpdk-dev] [PATCH 3/3] port: code clean-up

2016-04-01 Thread Zhang, Roy Fan
Hi Thomas, The reason for removing RTE_NEXT_ABI here is caused by sink port, which is not wrapped by RTE_NEXT_ABI macro. If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original code will cause the compile error as pcap library is missing. Regards, Fan On 01/04/2016 14:56,

[dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types

2016-04-01 Thread Thomas Monjalon
2016-03-31 02:21, Jerin Jacob: > - added VXLAN, GENEVE and NVGRE tunnel flow types > - added PORT flow type for accounting physical/virtual > port or channel number in flow creation These API change could be considered for 16.07 if they are motivated by any use. Please bring some use cases,

[dpdk-dev] [PATCH 3/3] port: code clean-up

2016-04-01 Thread Zhang, Roy Fan
Hi Thomas, The reason for removing RTE_NEXT_ABI here is caused by sink port, which is not wrapped by RTE_NEXT_ABI macro. If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original code will cause the compile error as pcap library is missing. Regards, Fan -Original

[dpdk-dev] [PATCH v2] hash: fix to support multi process

2016-04-01 Thread De Lara Guarch, Pablo
Hi Thomas, > -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Friday, April 01, 2016 2:07 PM > To: De Lara Guarch, Pablo > Cc: dev at dpdk.org; Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v2] hash: fix to support multi process > > Hi Pablo,

[dpdk-dev] [PATCH] ivshmem: avoid infinite loop when concatenating adjacent segments

2016-04-01 Thread Thomas Monjalon
Please Anatoly, What do you think of this patch? 2015-12-19 23:39, David Verbeiren: > This patch aligns the logic used to check for the presence of > adjacent segments in has_adjacent_segments() with the logic used > in cleanup_segments() when actually deciding to concatenate or > not a pair of

[dpdk-dev] [PATCH v3 1/2] ethdev: add tunnel and port RSS offload types

2016-04-01 Thread Jerin Jacob
On Fri, Apr 01, 2016 at 04:04:13PM +0200, Thomas Monjalon wrote: > 2016-03-31 02:21, Jerin Jacob: > > - added VXLAN, GENEVE and NVGRE tunnel flow types > > - added PORT flow type for accounting physical/virtual > > port or channel number in flow creation > > These API change could be considered

[dpdk-dev] [PATCH] ivshmem: avoid infinite loop when concatenating adjacent segments

2016-04-01 Thread Burakov, Anatoly
> Please Anatoly, > What do you think of this patch? > > 2015-12-19 23:39, David Verbeiren: > > This patch aligns the logic used to check for the presence of adjacent > > segments in has_adjacent_segments() with the logic used in > > cleanup_segments() when actually deciding to concatenate or not

[dpdk-dev] [PATCH 2/4] port: fix ring writer buffer overflow

2016-04-01 Thread Sanford, Robert
> > >> -Original Message- >> From: Robert Sanford [mailto:rsanford2 at gmail.com] >> Sent: Monday, March 28, 2016 9:52 PM >> To: dev at dpdk.org; Dumitrescu, Cristian >> Subject: [PATCH 2/4] port: fix ring writer buffer overflow >> >> Ring writer tx_bulk functions may write past the

[dpdk-dev] [PATCH v3 0/2] Multi-process support in hash library

2016-04-01 Thread Pablo de Lara
This patchset fixes the hash library to support multi-process. It also replaces several RTE_ARCH_* with RTE_ARCH_X86, for simplicity. Changes in v3: - Added new #ifdefs, to fix ARMv7 compilation - Replaced RTE_ARCH_* for X86 macros Changes in v2: - Added missing const - Added extra info in

[dpdk-dev] [PATCH v3 1/2] hash: use RTE_ARCH_X86 macro for X86 systems

2016-04-01 Thread Pablo de Lara
Instead of using RTE_ARCH_X86_64, RTE_ARCH_X86_32 and RTE_ARCH_I686, use directly RTTE_ARCH_X86 Signed-off-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c

[dpdk-dev] [PATCH v3 2/2] hash: fix to support multi process

2016-04-01 Thread Pablo de Lara
Hash library used a function pointer to choose a different key compare function, depending on the key size. As a result, multiple processes could not use the same hash table, as the function addresses vary from one process to another. Instead, a jump table is used, so each process has its own

[dpdk-dev] [PATCH] app/test/test_table_acl: fill missing field

2016-04-01 Thread Fan Zhang
This patch fills the missing field of ipv4_5tuple structure in acl table test. Signed-off-by: Fan Zhang Acked-by: Cristian Dumitrescu --- app/test/test_table_acl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c index

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-01 Thread Stephen Hemminger
On Thu, 31 Mar 2016 19:15:22 -0700 Rasesh Mody wrote: > +struct qed_filter_ucast_params { > + enum qed_filter_xcast_params_type type; > + uint8_t vlan_valid; > + uint16_t vlan; > + uint8_t mac_valid; > + unsigned char mac[ETHER_ADDR_LEN]; > +} __attribute__ ((__packed__));

[dpdk-dev] [PATCH v5 05/10] qede: Add core driver

2016-04-01 Thread Stephen Hemminger
On Thu, 31 Mar 2016 19:15:22 -0700 Rasesh Mody wrote: > +struct qed_filter_mcast_params { > + enum qed_filter_xcast_params_type type; > + uint8_t num; > + unsigned char mac[64][ETHER_ADDR_LEN]; > +}; Would prefer a #define constant for the maximum number of multicast addresses

[dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD

2016-04-01 Thread Stephen Hemminger
On Thu, 31 Mar 2016 19:15:17 -0700 Rasesh Mody wrote: > Hi Thomas, Bruce, > > The v5 series incorporates the following review comments: > - move adapter_info logs under debug > - implement qede_mac_addr_remove() > - remove unused rc variable in qede_dev_configure() > - fix indentation in

[dpdk-dev] [PATCH v5 00/10] qede: Add qede PMD

2016-04-01 Thread Harish Patil
> >On Thu, 31 Mar 2016 19:15:17 -0700 >Rasesh Mody wrote: > >> Hi Thomas, Bruce, >> >> The v5 series incorporates the following review comments: >> - move adapter_info logs under debug >> - implement qede_mac_addr_remove() >> - remove unused rc variable in qede_dev_configure() >> - fix

[dpdk-dev] [PATCH 2/2] doc: update which PMDs can parse packet type

2016-04-01 Thread Thomas Monjalon
2016-03-26 00:10, Tan, Jianfeng: > On 3/25/2016 10:21 PM, Bruce Richardson wrote: > > On Fri, Mar 25, 2016 at 11:15:36AM +0800, Jianfeng Tan wrote: > >> --- a/doc/guides/nics/overview.rst > >> +++ b/doc/guides/nics/overview.rst > >> @@ -124,7 +124,7 @@ Most of these differences are summarized

[dpdk-dev] [PATCH] ivshmem: avoid infinite loop when concatenating adjacent segments

2016-04-01 Thread Burakov, Anatoly
> > Please Anatoly, > > What do you think of this patch? > > > > 2015-12-19 23:39, David Verbeiren: > > > This patch aligns the logic used to check for the presence of > > > adjacent segments in has_adjacent_segments() with the logic used in > > > cleanup_segments() when actually deciding to

[dpdk-dev] [PATCH 4/4] port: fix ethdev writer burst too big

2016-04-01 Thread Sanford, Robert
Hi Cristian, Please see my comments inline. > > >> -Original Message- >> From: Robert Sanford [mailto:rsanford2 at gmail.com] >> Sent: Monday, March 28, 2016 9:52 PM >> To: dev at dpdk.org; Dumitrescu, Cristian >> Subject: [PATCH 4/4] port: fix ethdev writer burst too big >> >> For

[dpdk-dev] [PATCH 1/4] lpm: allocation of an existing object should fail

2016-04-01 Thread Olivier Matz
On 03/31/2016 09:35 AM, Olivier Matz wrote: > On 03/30/2016 11:46 PM, Stephen Hemminger wrote: >> with older memzone model, objects in huge memory area were never freed. >> That means when application restarts it finds the old LPM and works. >> With your change it would break such an

[dpdk-dev] [PATCH v3 0/2] Multi-process support in hash library

2016-04-01 Thread Thomas Monjalon
2016-04-01 16:03, Pablo de Lara: > This patchset fixes the hash library to support multi-process. > > It also replaces several RTE_ARCH_* with RTE_ARCH_X86, for simplicity. > > Changes in v3: > - Added new #ifdefs, to fix ARMv7 compilation > - Replaced RTE_ARCH_* for X86 macros > > Changes in

[dpdk-dev] [PATCH] gcc compiler option -Og warnings fix

2016-04-01 Thread Keith Wiles
The new compiler option -Og causes a few warning on variables being used before being set warnings. The new option allows better debugging then -O0 without losing a lot of performance. This option does not include -g debug symbol option. Signed-off-by: Keith Wiles ---

[dpdk-dev] [PATCH 3/4] port: fix full burst checks in f_tx_bulk ops

2016-04-01 Thread Sanford, Robert
Hi Cristian, In hindsight, I was overly agressive in proposing the same change (approach #2, as you call it below) for rte_port_ring and rte_port_sched. Changing local variable bsz_mask to uint64_t should be sufficient. Please see additional comments inline below. On 3/31/16 11:41 AM,

[dpdk-dev] [PATCH v14 0/8] ethdev: 100G and link speed API refactoring

2016-04-01 Thread Thomas Monjalon
2016-04-01 00:12, Marc Sune: > From: Marc Sune > > This series of patches adds the following capabilities: > > * speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs > according to the physical device capabilities. > * refactors link API in ethdev to allow the definition of the

[dpdk-dev] [PATCH 1/4] app/test: enhance test_port_ring_writer

2016-04-01 Thread Sanford, Robert
We don't need to change this line, because we never access more than RTE_PORT_IN_BURST_SIZE_MAX (64) elements in this array: - struct rte_mbuf *mbuf[RTE_PORT_IN_BURST_SIZE_MAX]; + struct rte_mbuf *mbuf[2 * RTE_PORT_IN_BURST_SIZE_MAX]; -- Robert >Add code to send two 60-packet

[dpdk-dev] [PATCH] scripts: build with libsso

2016-04-01 Thread Thomas Monjalon
Signed-off-by: Thomas Monjalon --- scripts/test-build.sh | 4 1 file changed, 4 insertions(+) diff --git a/scripts/test-build.sh b/scripts/test-build.sh index a486244..c37fc99 100755 --- a/scripts/test-build.sh +++ b/scripts/test-build.sh @@ -44,6 +44,7 @@ default_path=$PATH # -

[dpdk-dev] [PATCH 0/3] bug fix and code clean-up

2016-04-01 Thread Thomas Monjalon
2016-04-01 14:41, Fan Zhang: > This patchset fixes d4b4213 and eb5f411, plus code clean-up of port library. > > Acked-by: Cristian Dumitrescu > > Fan Zhang (3): > port: fix source port parameter check > port: fix sink port parameter check > port: code clean-up Applied, thanks

[dpdk-dev] [PATCH] examples/ip_pipeline: fix pcap file parsing

2016-04-01 Thread Thomas Monjalon
2016-04-01 10:55, Fan Zhang: > Fixes: fe5d046 ("examples/ip_pipeline: add pcap file dump") > > This patch fixes the pcap file parsing in ip_pipeline. Originally, the > parser recognizes the pcap related entries regardless of the RTE_PORT_PCAP > macro definition status. > > Signed-off-by: Fan

[dpdk-dev] [PATCH v14 0/8] ethdev: 100G and link speed API refactoring

2016-04-01 Thread Marc Sune
From: Marc Sune This series of patches adds the following capabilities: * speed_capa bitmap in rte_eth_dev_info, which is filled by the PMDs according to the physical device capabilities. * refactors link API in ethdev to allow the definition of the advertised link speeds,