[dpdk-dev] [PATCH v2] examples/l3fwd-power: fix zero rxq handling

2017-04-26 Thread Jingjing Wu
If the number of rx queues is zero, it is meaningless to enable rx interrupt. This patch fixes it. Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Jingjing Wu --- v2 changes: - fix typo. examples/l3fwd-power/main

Re: [dpdk-dev] [PATCH v2 02/13] eventdev: fix errors with strict compilation flags

2017-04-26 Thread Adrien Mazarguil
On Tue, Apr 25, 2017 at 03:31:45PM +, De Lara Guarch, Pablo wrote: > Hi Adrien, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Adrien Mazarguil > > Sent: Tuesday, April 25, 2017 9:30 AM > > To: dev@dpdk.org > > Cc: Jerin Jacob > > Subject: [dpdk-dev]

Re: [dpdk-dev] [PATCH 05/13] vhost: fix errors with strict compilation flags

2017-04-26 Thread Maxime Coquelin
On 04/24/2017 05:52 PM, Adrien Mazarguil wrote: Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from /tmp/check-includes.sh.20132.c:1:0: build/include/rte_vhost.h:73:30: error: ISO C forbids zero-size array

Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Maxime Coquelin
On 04/19/2017 08:29 AM, Zhiyong Yang wrote: Current virtio_dev_stop only disables interrupt and marks link down, When it is invoked, tx/rx traffic flows still work. This is a strange behavior. The patch supports the switch of flow. Signed-off-by: Zhiyong Yang --- Changes in V2: Use the flag

[dpdk-dev] OpenSSL Cryptodev PMD and openssl engine

2017-04-26 Thread Aravamudan Srivathsan
Hi All, We have a openssl engine available. Is it possible to use the openssl Crypto PMD to do the hardware offloading? I am trying to see if i can avoid writing the cryptopmd also to reuse the use of the device shared between the DPDK and other process. Thank you Srivathsan

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alexey Kardashevskiy
On 21/04/17 18:54, Andrew Rybchenko wrote: > On 04/20/2017 10:24 AM, Alexey Kardashevskiy wrote: >> The existing code correctly checks if a container is set to a group and >> does not try attaching a group to a container for a second/third/... >> device from the same IOMMU group. >> >> However it s

Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Yuanhan Liu
On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote: > As said, only cosmetic comments, it looks otherwise valid to me. > If you fix these, feel free to add my: > Acked-by: Maxime Coquelin Oops, I forgot to reply this thread, that I have already applied it :/ --yliu

Re: [dpdk-dev] [PATCH v2] net/virtio: support to turn on/off traffic flow

2017-04-26 Thread Maxime Coquelin
On 04/26/2017 09:56 AM, Yuanhan Liu wrote: On Wed, Apr 26, 2017 at 09:45:42AM +0200, Maxime Coquelin wrote: As said, only cosmetic comments, it looks otherwise valid to me. If you fix these, feel free to add my: Acked-by: Maxime Coquelin Oops, I forgot to reply this thread, that I have alre

[dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Use correct structures for add/remove windows

2017-04-26 Thread Alexey Kardashevskiy
If Linux UAPI headers in the system do not have VFIO_SPAPR_TCE_v2_IOMMU defined, DPDK define necessary structures itself. However the existing definitions are different from ones pushed to the mainline kernel. This copies structures passed via VFIO_IOMMU_SPAPR_TCE_CREATE and VFIO_IOMMU_SPAPR_TCE_R

[dpdk-dev] [PATCH dpdk v2] pci: Initialize common rte driver pointer

2017-04-26 Thread Alexey Kardashevskiy
The existing code initializes a PCI driver pointer but not the common one. As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c crashed as dev->device->driver==NULL. This adds missing initialization. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * no change, just poste

[dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-26 Thread Alexey Kardashevskiy
Recent kernels/distros have updated firmware images, use them. In order to keep support of older distros (such as Fedora 19 or Ubuntu 14.04), this also tries fallback to an order firmware version. Signed-off-by: Alexey Kardashevskiy --- Changes: v2: * in addition to the very new firmware images,

[dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Warn if DMA window was created at unexpected offset

2017-04-26 Thread Alexey Kardashevskiy
VFIO_IOMMU_SPAPR_TCE_CREATE ioctl() returns the actual bus address for just created DMA window. It happens to start from zero because the default window is removed (leaving no windows) and new window starts from zero. However this is not guaranteed and a new window may start from another address, t

Re: [dpdk-dev] [dpdk-stable] [PATCH 01/11] net/qede: fix default MAC address handling

2017-04-26 Thread Ferruh Yigit
On 4/25/2017 8:28 AM, Rasesh Mody wrote: > From: Harish Patil > > - In qede_mac_addr_set(), in order to configure default MAC address we > first delete the existing MAC address before trying to add new one. During > init time, there is no MAC filter to begin with, so trying to remove a > non-exis

Re: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Use correct structures for add/remove windows

2017-04-26 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Wednesday, April 26, 2017 9:07 AM > To: dev@dpdk.org > Cc: Alexey Kardashevskiy > Subject: [dpdk-dev] [PATCH dpdk v2] vfio/ppc64/spapr: Use correct > structures for add/remove windows > > If Linux UAPI headers i

Re: [dpdk-dev] [PATCH v3] net/i40e: mbuf alloc failed counter not incremented

2017-04-26 Thread Ferruh Yigit
On 4/25/2017 6:31 PM, Zhang, Helin wrote: > > >> -Original Message- >> From: Allain Legacy [mailto:allain.leg...@windriver.com] >> Sent: Tuesday, April 25, 2017 8:29 PM >> To: Zhang, Helin; Wu, Jingjing >> Cc: dev@dpdk.org; Peters, Matt (Wind River) >> Subject: [PATCH v3] net/i40e: mbuf a

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Burakov, Anatoly
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey > Kardashevskiy > Sent: Wednesday, April 26, 2017 8:51 AM > To: Andrew Rybchenko ; dev@dpdk.org > Cc: j...@zurich.ibm.com; Gowrishankar Muthukrishnan > > Subject: Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if > alre

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alejandro Lucero
On Wed, Apr 26, 2017 at 9:27 AM, Burakov, Anatoly wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Alexey > > Kardashevskiy > > Sent: Wednesday, April 26, 2017 8:51 AM > > To: Andrew Rybchenko ; dev@dpdk.org > > Cc: j...@zurich.ibm.com; Gowrishankar Muthukrishnan > > > > Subject:

Re: [dpdk-dev] [PATCH] bnxt: Add new device ids

2017-04-26 Thread Ferruh Yigit
On 4/25/2017 10:53 PM, Ajit Khaparde wrote: > Add support for new device ids. Hi Ajit, Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for these new devices? Also if http://dpdk.org/doc/nics needs update please send another web patch. Thanks, ferruh > > Signed-off-by: Aji

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Burakov, Anatoly
Hi Alejandro, > I was counting on first submitted patch being accepted.  OK, that's on me then. > There is another thing to solve which is to unplug ports when there are more > than one (already plugged) in an IOMMU group. I have a patch for this but I > can not test it for that scenario, just

Re: [dpdk-dev] [PATCH] doc: update mlx4 and mlx5 release notes

2017-04-26 Thread Ferruh Yigit
On 4/25/2017 12:49 PM, Shahaf Shuler wrote: > Update release notes for 17.05. > > Signed-off-by: Shahaf Shuler Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] Too much print of testpmd

2017-04-26 Thread Gaëtan Rivet
Hi Wenzhuo, On Wed, Apr 26, 2017 at 05:10:44AM +, Lu, Wenzhuo wrote: Hi Gaetan, When using DPDK PF + DPDK VF, there's too much print like, Port 0: VF Mbox event Seems it's not good to print every event directly. If it's necessary, is it better to redirect the output to a l

Re: [dpdk-dev] [PATCH dpdk v2] bnx2x: Update firmware versions

2017-04-26 Thread Ferruh Yigit
On 4/26/2017 9:08 AM, Alexey Kardashevskiy wrote: > Recent kernels/distros have updated firmware images, use them. > In order to keep support of older distros (such as Fedora 19 or > Ubuntu 14.04), this also tries fallback to an order firmware version. > > Signed-off-by: Alexey Kardashevskiy > --

Re: [dpdk-dev] dpdk-devbind can't be used misc with kernel tools

2017-04-26 Thread Prathyusha, Guduri
Hi LijuanX A Response inline... Kindly apply the patch below (inline) and let me know the result. I will submit a formal patch once you confirm. Thanks, Prathyusha From: Tu, LijuanX A Sent: Wednesday, April 26, 2017 11:49 AM To: Prathyusha, Guduri Cc: dev@dpdk.org; Chen, WeichunX; Liu, Yu

Re: [dpdk-dev] [PATCH] doc: enic SR-IOV configurations

2017-04-26 Thread Ferruh Yigit
On 4/26/2017 6:56 AM, John Daley wrote: > Document SR-IOV passthrough setup and limitations > for enic PMD. > > Signed-off-by: John Daley Hi John, Thank you for the documentation update, just I am getting following warning [1], can you please check. Also enic feature table (enic.ini) is not an

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal > Sent: Thursday, April 20, 2017 11:48 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: Doherty, Declan; hemant.agra...@nxp.com > Subject: Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for

Re: [dpdk-dev] [PATCH dpdk v2] pci: Initialize common rte driver pointer

2017-04-26 Thread Thomas Monjalon
26/04/2017 10:07, Alexey Kardashevskiy: > The existing code initializes a PCI driver pointer but not the common one. > As the result, ring_dma_zone_reserve() in drivers/net/bnx2x/bnx2x_rxtx.c > crashed as dev->device->driver==NULL. > > This adds missing initialization. > > Signed-off-by: Alexey K

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-26 Thread Akhil Goyal
On 4/26/2017 3:08 PM, De Lara Guarch, Pablo wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Akhil Goyal Sent: Thursday, April 20, 2017 11:48 AM To: De Lara Guarch, Pablo; dev@dpdk.org Cc: Doherty, Declan; hemant.agra...@nxp.com Subject: Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH dpdk 4/5] vfio: Do try setting IOMMU type if already set

2017-04-26 Thread Alejandro Lucero
On Wed, Apr 26, 2017 at 9:58 AM, Burakov, Anatoly wrote: > Hi Alejandro, > > > I was counting on first submitted patch being accepted. > > OK, that's on me then. > > > There is another thing to solve which is to unplug ports when there are > more than one (already plugged) in an IOMMU group. I ha

[dpdk-dev] [PATCH] nfp: fix mbuf releasing when segments

2017-04-26 Thread Alejandro Lucero
If segments are used, just mbufs previously linked to head descriptor of a mbuf chain are released. Other tx descriptor are used for the mbuf chain but they keep their linked mbufs without releasing them. It is not a fatal issue because sooner or later those descriptors will be head descriptors or

[dpdk-dev] [PATCH] app/testpmd: add bus info when display port info

2017-04-26 Thread Yulong Pei
Display pci device bus info when show port info. Signed-off-by: Yulong Pei --- app/test-pmd/config.c | 8 1 file changed, 8 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index ef07925..49bf816 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@

[dpdk-dev] [PATCH] app/testpmd: initalize port_numa and ring_numa

2017-04-26 Thread Yulong Pei
Previous numa_support = 0 by default, it need to add --numa to testpmd command line to enable numa, so port_numa and ring_numa were initalized at function launch_args_parse(), now testpmd change numa_support = 1 as default, so port_numa and ring_numa also need to initalize by default, otherwise por

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Wednesday, April 26, 2017 10:53 AM > To: De Lara Guarch, Pablo; dev@dpdk.org > Cc: Doherty, Declan; hemant.agra...@nxp.com > Subject: Re: [PATCH] test/test: improve dequeue logic for crypto operation > > On 4/2

[dpdk-dev] [PATCH] vfio: fix device unplug when several devices per vfio group

2017-04-26 Thread Alejandro Lucero
VFIO allows a secure way of assigning devices to user space and those devices which can not be isolated from other ones are set in same VFIO group. Releasing or unplugging a device should be aware of remaining devices is the same group for avoiding to close such a group. Fixes: 94c0776b1bad ("vfio

[dpdk-dev] [PATCH V2] app/testpmd: initialize port_numa and ring_numa

2017-04-26 Thread Yulong Pei
Previous numa_support = 0 by default, it need to add --numa to testpmd command line to enable numa, so port_numa and ring_numa were initalized at function launch_args_parse(), now testpmd change numa_support = 1 as default, so port_numa and ring_numa also need to initalize by default, otherwise por

Re: [dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-26 Thread Alejandro Lucero
Hi Gowrishankar, The VFIO maintainer is going to accept your patch. I have just sent a patch about the unplug issue: http://www.dpdk.org/ml/archives/dev/2017-April/064737.html On Wed, Apr 26, 2017 at 11:36 AM, gowrishankar muthukrishnan < gowrishanka...@linux.vnet.ibm.com> wrote: > Thanks Al

Re: [dpdk-dev] [PATCH] vfio: set IOMMU type for the container once

2017-04-26 Thread gowrishankar muthukrishnan
Thanks Alajandro. Could this patch be merged before you make further cases considered ?. Reason is that, we need this fix in 17.05 for ppc64le as I pointed earlier (and of course any changes that would make the fix better, if possible before RCs closed). Thanks, Gowrishankar On Friday 21 April

[dpdk-dev] [PATCH v3] app/testpmd: initialize port_numa and ring_numa

2017-04-26 Thread Yulong Pei
Previous numa_support = 0 by default, it need to add --numa to testpmd command line to enable numa, so port_numa and ring_numa were initialized at function launch_args_parse(), now testpmd change numa_support = 1 as default, so port_numa and ring_numa also need to initialize by default, otherwise p

Re: [dpdk-dev] [PATCH] test/test: improve dequeue logic for crypto operation

2017-04-26 Thread Akhil Goyal
On 4/26/2017 4:12 PM, De Lara Guarch, Pablo wrote: -Original Message- From: Akhil Goyal [mailto:akhil.go...@nxp.com] Sent: Wednesday, April 26, 2017 10:53 AM To: De Lara Guarch, Pablo; dev@dpdk.org Cc: Doherty, Declan; hemant.agra...@nxp.com Subject: Re: [PATCH] test/test: improve dequ

[dpdk-dev] [PATCH] drivers/net/i40e/i40e_fdir.c: Improved i40e FDIR programming times

2017-04-26 Thread Michael Lilja
During my work (https://www.napatech.com/hw-acceleration-via-rte_flow/)on a flowtable application example that use rte_flow I discovered that the rte_flow programming times on a i40e was +11ms. The patch below result in an average programming time of 22usec with a max of 60usec instead of +11ms

[dpdk-dev] [PATCH] examples/l3fwd-power: fix Rx descriptor size

2017-04-26 Thread Pablo de Lara
L3fwd power app monitors the RX queues to see if the polling frequency should be adjusted (the busier the queue, the higher the frequency). The app uses several thresholds in the ring to determine the frequency, being 96 the highest one, when frequency should be highest. The problem is that the di

[dpdk-dev] [PATCH] usertools: reduce devbind status output

2017-04-26 Thread Ferruh Yigit
Script displays status for all device types and output is much longer than it used to be. This makes harder to read script output. This patch reduces output to the script into a device group which can be defined with new -t,--type parameter to script. Supported types: net crypto mempool eventdev

[dpdk-dev] [PATCH v3 00/14] Fixes for exported headers

2017-04-26 Thread Adrien Mazarguil
This series addresses the remaining issues seen by check-includes.sh in exported headers. Most of them may cause compilation errors in user applications: - Dependencies on missing includes. - Non-standard C/C++ constructs usage without associated safeties. - Missing C++ awareness blocks. It also

[dpdk-dev] [PATCH v3 02/14] eventdev: fix errors with strict compilation flags

2017-04-26 Thread Adrien Mazarguil
Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from build/include/rte_eventdev_pmd.h:55:0, from /tmp/check-includes.sh.25816.c:1: build/include/rte_eventdev.h:908:8: error: struct has no named membe

[dpdk-dev] [PATCH v3 01/14] crypto/scheduler: fix missing includes

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_cryptodev_scheduler.h:37:0, from /tmp/check-includes.sh.5355.c:1: build/include/rte_cryptodev_scheduler_operations.h:43:30: error: unknown type name 'uint8_t' struct rte_cryptode

[dpdk-dev] [PATCH v3 03/14] latency: fix missing includes in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from build/include/rte_latencystats.h:43:0, from /tmp/check-includes.sh.6580.c:1: build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t' [...] In file included from /tmp/check-includes.sh.6580.c:1:0:

[dpdk-dev] [PATCH v3 04/14] net: fix missing include in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from /tmp/check-includes.sh.18889.c:1:0: build/include/rte_net_crc.h:86:1: error: unknown type name 'uint32_t' [...] Fixes: 986ff526fb84 ("net: add CRC computation API") Signed-off-by: Adrien Mazarguil Acked-by: Jasvinder Singh --

[dpdk-dev] [PATCH v3 05/14] vhost: fix errors with strict compilation flags

2017-04-26 Thread Adrien Mazarguil
Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from /tmp/check-includes.sh.20132.c:1:0: build/include/rte_vhost.h:73:30: error: ISO C forbids zero-size array 'regions' [-Werror=pedantic] [...] Also: - Add C++

[dpdk-dev] [PATCH v3 07/14] net/avp: fix errors in exported headers

2017-04-26 Thread Adrien Mazarguil
This commit addresses several errors related to missing includes such as: In file included from /tmp/check-includes.sh.15315.c:1:0: build/include/rte_avp_fifo.h:77:22: error: 'struct rte_avp_fifo' declared inside parameter list [-Werror] [...] build/include/rte_avp_fifo.h: In function 'avp

[dpdk-dev] [PATCH v3 06/14] mbuf: fix missing includes in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following errors: In file included from /tmp/check-includes.sh.681.c:1:0: build/include/rte_mbuf_ptype.h:587:35: error: unknown type name 'uint32_t' [...] build/include/rte_mbuf_ptype.h:662:51: error: unknown type name 'size_t' [...] Fixes: 288541c8ff9e ("mbuf: add

[dpdk-dev] [PATCH v3 08/14] bitrate: fix errors in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following error: In file included from /tmp/check-includes.sh.28023.c:1:0: build/include/rte_bitrate.h:82:2: error: unknown type name 'uint8_t' [...] It also adds C++ awareness to rte_bitrate.h. Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Cc: Rem

[dpdk-dev] [PATCH v3 10/14] metrics: fix errors in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from /tmp/check-includes.sh.21060.c:1:0: build/include/rte_metrics.h:91:2: error: unknown type name 'uint16_t' [...] It also adds C++ awareness to rte_metrics.h. Fixes: 349950ddb9c5 ("metrics: add information metrics lib

[dpdk-dev] [PATCH v3 11/14] ethdev: fix C++ errors in flow API

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_flow_driver.h:50:0, from /tmp/check-includes.sh.1397.cc:1: build/include/rte_flow.h:428:2: error: expected primary-expression before '.' token [...] build/include/rte_flow.h:46

[dpdk-dev] [PATCH v3 09/14] efd: fix missing include in exported header

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from /tmp/check-includes.sh.8373.c:1:0: build/include/rte_efd.h:133:9: error: unknown type name 'uint8_t' [...] Fixes: 56b6ef874f80 ("efd: new Elastic Flow Distributor library") Cc: sta...@dpdk.org Cc: Byron Marohn Cc:

[dpdk-dev] [PATCH v3 13/14] ethdev: fix incomplete items in flow API

2017-04-26 Thread Adrien Mazarguil
E-Tag and NVGRE pattern items have been added hastily without updating documentation nor testpmd. This commit also adds default masks for these items based on the ixgbe implementation. Fixes: 99e7003831c3 ("net/ixgbe: parse L2 tunnel filter") Cc: sta...@dpdk.org Cc: Wei Zhao Cc: Wenzhuo Lu Sig

[dpdk-dev] [PATCH v3 12/14] ethdev: fix C++ errors in flow API (MPLS, GRE)

2017-04-26 Thread Adrien Mazarguil
This commit addresses the following compilation errors: In file included from build/include/rte_flow_driver.h:50:0, from /tmp/check-includes.sh.1397.cc:1: build/include/rte_flow.h:631:1: error: C99 designator 'label_tc_s' outside aggregate initializer [...] build/include/

[dpdk-dev] [PATCH v3 14/14] eal: fix debug macro redefinition

2017-04-26 Thread Adrien Mazarguil
The RTE_FUNC_*_RET() and RTE_PROC_*_RET() macro definitions in rte_dev.h require RTE_PMD_DEBUG_TRACE(). This macro is defined as needed by users of rte_dev.h since its value depends on their own debug settings. It may be defined multiple times as a result when including files from various componen

Re: [dpdk-dev] [PATCH] crypto/openssl: fix aad capabilities for AES-GCM

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Arek Kusztal > Sent: Tuesday, April 25, 2017 3:41 PM > To: dev@dpdk.org > Cc: Doherty, Declan; Kusztal, ArkadiuszX > Subject: [dpdk-dev] [PATCH] crypto/openssl: fix aad capabilities for AES- > GCM > > Fix aad cap

[dpdk-dev] next technical board meeting, 2017-04-27 at 3pm UTC.

2017-04-26 Thread Hemant Agrawal
Hello everyone, A meeting of the DPDK technical board will occur on this Thursday, April 27th 2017 at 3pm UTC. The meeting takes place on the #dpdk-board channel on IRC. This meeting is public, so anybody can join, see below for the agenda. Let me know if you want anything else to be added to the

[dpdk-dev] [PATCH v1] app/testpmd: add bitrate stats option

2017-04-26 Thread Remy Horton
Bit-rate collation should only be done by one core. This patch adds an option to select which core performs the bit-rate calculation, which is also disabled by default. Fixes: 7e4441c8efb9 ("app/testpmd: add bitrate statistics calculation") Signed-off-by: Remy Horton --- app/test-pmd/parameters

Re: [dpdk-dev] [PATCH] usertools: reduce devbind status output

2017-04-26 Thread Thomas Monjalon
26/04/2017 13:58, Ferruh Yigit: > Script displays status for all device types and output is much > longer than it used to be. This makes harder to read script output. > > This patch reduces output to the script into a device group which can be > defined with new -t,--type parameter to script. > >

[dpdk-dev] [PATCH] usertools: fix device binding when using with kernel tools

2017-04-26 Thread Guduri Prathyusha
The following sequence of operation gives error in binding devices 1) Bind a device using dpdk-devbind.py 2) Unbind the device using kernel tools(/sys/bus/pci/device/driver/unbind) 3) Bind the device using kernel tools(/sys/bus/pci/driver/new_id and /sys/bus/pci/driver/bind) The bind failure was d

[dpdk-dev] [PATCH] crypto/openssl: fix incomplete capability

2017-04-26 Thread Pablo de Lara
Crypto OpenSSL PMD supports 16, 24 and 32 byte keys, for AES GCM. Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library") Cc: sta...@dpdk.org Signed-off-by: Pablo de Lara --- drivers/crypto/openssl/rte_openssl_pmd_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [dpdk-dev] [PATCH] crypto/qat: fix aad capabilities for AES-GCM

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, April 25, 2017 5:10 PM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K > Subject: RE: [PATCH] crypto/qat: fix aad capabilities for AES-GCM > > > > > -Original Message-

Re: [dpdk-dev] [PATCH] crypto/openssl: fix aad capabilities for AES-GCM

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, April 26, 2017 1:13 PM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: Doherty, Declan; Kusztal, ArkadiuszX > Subject: RE: [dpdk-dev] [PATCH] crypto/openssl: fix aad capabilities for AES- > GCM > > > > > -Original

Re: [dpdk-dev] [PATCH] lib/cryptodev: fix API aad comments

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, April 25, 2017 5:08 PM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K; Doherty, Declan > Subject: RE: [PATCH] lib/cryptodev: fix API aad comments > > > > > -Original Messa

Re: [dpdk-dev] [PATCH] crypto/openssl: fix incomplete capability

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: De Lara Guarch, Pablo > Sent: Wednesday, April 26, 2017 3:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo; sta...@dpdk.org > Subject: [PATCH] crypto/openssl: fix incomplete capability > > Crypto OpenSSL PMD supports 16, 24 and 32 byte keys, > for AES GCM

Re: [dpdk-dev] [PATCH] doc: add limitation of aad size to qat rst file

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Trahe, Fiona > Sent: Tuesday, April 25, 2017 5:09 PM > To: Kusztal, ArkadiuszX; dev@dpdk.org > Cc: De Lara Guarch, Pablo; Griffin, John; Jain, Deepak K > Subject: RE: [PATCH] doc: add limitation of aad size to qat rst file > > > > > -Original Message---

Re: [dpdk-dev] [PATCH v3 02/14] eventdev: fix errors with strict compilation flags

2017-04-26 Thread Jerin Jacob
-Original Message- > Date: Wed, 26 Apr 2017 14:07:10 +0200 > From: Adrien Mazarguil > To: dev@dpdk.org > Cc: Jerin Jacob , "De Lara Guarch, Pablo" > > Subject: [PATCH v3 02/14] eventdev: fix errors with strict compilation flags > X-Mailer: git-send-email 2.1.4 > > Exported headers must

Re: [dpdk-dev] [PATCH] doc: enic SR-IOV configurations

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: John Daley [mailto:johnd...@cisco.com] > Sent: Wednesday, April 26, 2017 6:56 AM > To: Mcnamara, John > Cc: dev@dpdk.org; John Daley > Subject: [PATCH] doc: enic SR-IOV configurations > > Document SR-IOV passthrough setup and limitations for enic PMD. >

Re: [dpdk-dev] [PATCH] doc: enic SR-IOV configurations

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: Yigit, Ferruh > Sent: Wednesday, April 26, 2017 10:31 AM > To: John Daley ; Mcnamara, John > > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: enic SR-IOV configurations > > On 4/26/2017 6:56 AM, John Daley wrote: > > Document SR-IOV passthrough setu

Re: [dpdk-dev] [PATCH v2 1/4] doc: fix missing backquotes

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, April 25, 2017 11:18 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2 1/4] doc: fix missing backquotes > > Fixes: ea85e7d711b6 ("ethdev: retrieve xstats by

Re: [dpdk-dev] [PATCH v2 2/4] doc: add device removal event to release note

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, April 25, 2017 11:18 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2 2/4] doc: add device removal event to > release note > > Signed-off-by: Gaetan Rivet

Re: [dpdk-dev] [PATCH v2 3/4] doc: add LSC and RMV interrupt to testpmd user guide

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, April 25, 2017 11:18 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2 3/4] doc: add LSC and RMV interrupt to > testpmd user guide > > Signed-off-by: Gaetan

Re: [dpdk-dev] [PATCH v2 4/4] devtools: add git log checks for rmv

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Gaetan Rivet > Sent: Tuesday, April 25, 2017 11:18 AM > To: dev@dpdk.org > Cc: Yigit, Ferruh > Subject: [dpdk-dev] [PATCH v2 4/4] devtools: add git log checks for rmv > > Signed-off-by: Gaetan Rivet Acked-by:

Re: [dpdk-dev] [PATCH] doc: postpone deprecation of functions in ethdev

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, April 18, 2017 4:49 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Yigit, Ferruh > ; Iremonger, Bernard > Subject: [PATCH] doc: postpone deprecation of functions in ethdev > > The deprecation of the bypass functions in the e

Re: [dpdk-dev] [PATCH] doc: postpone ABI change in ethdev

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, April 18, 2017 4:49 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Yigit, Ferruh > ; Iremonger, Bernard > Subject: [PATCH] doc: postpone ABI change in ethdev > > The change of _rte_eth_dev_callback_process has not been done

Re: [dpdk-dev] [PATCH] doc: revise sample testpmd flow commands

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: Iremonger, Bernard > Sent: Tuesday, April 18, 2017 3:21 PM > To: dev@dpdk.org > Cc: Mcnamara, John ; Lu, Wenzhuo > ; Xing, Beilei ; Pei, Yulong > ; Iremonger, Bernard > Subject: [PATCH] doc: revise sample testpmd flow commands > > Stop port before enabling Q

Re: [dpdk-dev] [PATCH v3 08/14] bitrate: fix errors in exported header

2017-04-26 Thread Remy Horton
On 26/04/2017 13:07, Adrien Mazarguil wrote: [..] Cc: Remy Horton Signed-off-by: Adrien Mazarguil --- lib/librte_bitratestats/rte_bitrate.h | 10 ++ 1 file changed, 10 insertions(+) Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH v3 10/14] metrics: fix errors in exported header

2017-04-26 Thread Remy Horton
On 26/04/2017 13:07, Adrien Mazarguil wrote: [..] Cc: Remy Horton Signed-off-by: Adrien Mazarguil --- lib/librte_metrics/rte_metrics.h | 10 ++ 1 file changed, 10 insertions(+) Acked-by: Remy Horton

Re: [dpdk-dev] [PATCH] doc: add VF support statement

2017-04-26 Thread Mcnamara, John
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Tuesday, April 18, 2017 6:36 AM > To: dev@dpdk.org > Cc: Richardson, Bruce ; Wu, Jingjing > ; Yang, Qiming > Subject: [dpdk-dev] [PATCH] doc: add VF support statement > > This patch adds two

Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting

2017-04-26 Thread Michael S. Tsirkin
On Wed, Apr 26, 2017 at 05:44:05AM +, Tan, Jianfeng wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan@linux.intel.com] > > Sent: Wednesday, April 26, 2017 1:33 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; maxime.coque...@redhat.com; tho...@monjalon.net > >

Re: [dpdk-dev] [PATCH v3 09/14] efd: fix missing include in exported header

2017-04-26 Thread De Lara Guarch, Pablo
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, April 26, 2017 1:07 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Marohn, Byron; De Lara Guarch, Pablo > Subject: [PATCH v3 09/14] efd: fix missing include in exported header > > This comm

Re: [dpdk-dev] OpenSSL Cryptodev PMD and openssl engine

2017-04-26 Thread Trahe, Fiona
Hi Srivathsan, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Aravamudan > Srivathsan > Sent: Wednesday, April 26, 2017 8:49 AM > To: dev@dpdk.org > Subject: [dpdk-dev] OpenSSL Cryptodev PMD and openssl engine > > Hi All, > > We have a openssl engine availab

[dpdk-dev] [PATCH] config: set cache line as 128B in the generic arm64 config

2017-04-26 Thread Jerin Jacob
armv8 implementations may have 64B or 128B cache line. Setting to the maximum available cache line size in generic config to address minimum DMA alignment across all arm64 implementations. Increasing the cacheline size has no negative impact to cache invalidation on systems with a smaller cache li

Re: [dpdk-dev] [PATCH] bnxt: Add new device ids

2017-04-26 Thread Ajit Khaparde
On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit wrote: > On 4/25/2017 10:53 PM, Ajit Khaparde wrote: > > Add support for new device ids. > > Hi Ajit, > > Is NIC documentation (doc/guides/nics/bnxt.rst) needs to get updated for > these new devices? > ​Yes. It will need a small change. Do you want me

Re: [dpdk-dev] [PATCH] bnxt: Add new device ids

2017-04-26 Thread Ferruh Yigit
On 4/26/2017 7:41 PM, Ajit Khaparde wrote: > > On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit > wrote: > > On 4/25/2017 10:53 PM, Ajit Khaparde wrote: > > Add support for new device ids. > > Hi Ajit, > > Is NIC documentation (doc/guides/nics/bnxt.r

Re: [dpdk-dev] [PATCH] bnxt: Add new device ids

2017-04-26 Thread Ajit Khaparde
On Wed, Apr 26, 2017 at 2:01 PM, Ferruh Yigit wrote: > On 4/26/2017 7:41 PM, Ajit Khaparde wrote: > > > > On Wed, Apr 26, 2017 at 3:52 AM, Ferruh Yigit > > wrote: > > > > On 4/25/2017 10:53 PM, Ajit Khaparde wrote: > > > Add support for new device ids. > >

[dpdk-dev] [PATCH v2 1/2] bnxt: Add new device ids

2017-04-26 Thread Ajit Khaparde
Add support for new device ids. v2: Send an updated doc/guides/nics/bnxt.rst along with this. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 5dc3ff0..78

[dpdk-dev] [PATCH v2 2/2] doc: update bnxt.rst

2017-04-26 Thread Ajit Khaparde
Update the product family and supported speeds in bnxt.rst Signed-off-by: Ajit Khaparde --- doc/guides/nics/bnxt.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/bnxt.rst b/doc/guides/nics/bnxt.rst index ad33cd5..9826b35 100644 --- a/doc/guides/nics/bnx

Re: [dpdk-dev] [PATCH v2 1/2] bnxt: Add new device ids

2017-04-26 Thread Ferruh Yigit
On 4/26/2017 8:20 PM, Ajit Khaparde wrote: > Add support for new device ids. > > v2: > Send an updated doc/guides/nics/bnxt.rst along with this. > > Signed-off-by: Ajit Khaparde Applied to dpdk-next-net/master, thanks. (squashed into single patch)

Re: [dpdk-dev] [PATCH] nfp: fix mbuf releasing when segments

2017-04-26 Thread Ferruh Yigit
On 4/26/2017 11:27 AM, Alejandro Lucero wrote: > If segments are used, just mbufs previously linked to head descriptor of > a mbuf chain are released. Other tx descriptor are used for the mbuf chain > but they keep their linked mbufs without releasing them. It is not a fatal > issue because sooner

[dpdk-dev] [PATCH] mk: fix external builds with relative output dir

2017-04-26 Thread Jan Blunck
In case the output directory (O=) is undefined or a relative directory lets turn it into an absolute path before passing it on. Otherwise the output directory is created relative to the subdir, e.g. pktgen/app/build/... and pktgen/lib/lua/src/build/... Signed-off-by: Jan Blunck --- mk/rte.extsub

[dpdk-dev] [PATCH 2/2] bond: use rte_eth_dev_socket_id()

2017-04-26 Thread Jan Blunck
The bonded device does not have to be a PCI device. Use the rte_ethdev functions instead. Signed-off-by: Wen Chiu Signed-off-by: Stephen Hemminger Signed-off-by: Jan Blunck --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[dpdk-dev] [PATCH 1/2] bond: avoid allocating mempool on socket LCORE_ID_ANY

2017-04-26 Thread Jan Blunck
If the numa node is unknown, use the value from rte_socket_id() to avoid an allocation failure. Signed-off-by: Eric Kinzie CC: Eric Kinzie --- drivers/net/bonding/rte_eth_bond_8023ad.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net

Re: [dpdk-dev] Too much print of testpmd

2017-04-26 Thread Lu, Wenzhuo
Hi Gaëtan, > -Original Message- > From: Gaëtan Rivet [mailto:gaetan.ri...@6wind.com] > Sent: Wednesday, April 26, 2017 5:05 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Wu, Jingjing > Subject: Re: Too much print of testpmd > > Hi Wenzhuo, > > On Wed, Apr 26, 2017 at 05:10:44AM +, Lu, Wen

[dpdk-dev] [PATCH v2] doc: enic SR-IOV configurations

2017-04-26 Thread John Daley
Document SR-IOV passthrough setup and limitations for enic PMD. Signed-off-by: John Daley --- v2 - fix typos, URL targets and formatting in SR-IOV section. doc/guides/nics/enic.rst | 93 +++ doc/guides/nics/features/enic.ini | 1 + 2 files changed,

[dpdk-dev] [PATCH] doc: fix enic NIC guide syntax and copyright

2017-04-26 Thread John Daley
Fixes: 211f9a9ce2f0 ("enic: add guide") Signed-off-by: John Daley --- doc/guides/nics/enic.rst | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/doc/guides/nics/enic.rst b/doc/guides/nics/enic.rst index f744151f5..89a301585 100644 -

Re: [dpdk-dev] [PATCH v3 13/14] ethdev: fix incomplete items in flow API

2017-04-26 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Wednesday, April 26, 2017 8:07 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhao1, Wei; Lu, Wenzhuo > Subject: [PATCH v3 13/14] ethdev: fix incomplete items in flow API > > E-Tag and NVGRE patter

Re: [dpdk-dev] OpenSSL Cryptodev PMD and openssl engine

2017-04-26 Thread Aravamudan Srivathsan
Hi Fiona, Thank you for the reply. I have a crypto device that is connected to PCI. It can do standard crypto operations like AES, DES, and so on. I have openssl engine (a plugin) for this. Our environment is We have DPDK application for routing, forwarding, IPSec etc. (All routing and tun

[dpdk-dev] [PATCH] app/testpmd: terminate without freeing resources

2017-04-26 Thread Jiayu Hu
When testpmd exists, it frees the acquired resources (e.g. stop ports). However, when we terminate it by Ctrl-d, testpmd exists directly without releasing the resources. In this patch, we fix this exit issue. Signed-off-by: Jiayu Hu --- app/test-pmd/testpmd.c | 1 + 1 file changed, 1 insertion(+

  1   2   >