[dpdk-dev] [PATCH v6 01/10] crypto/virtio: add virtio crypto PMD

2018-04-03 Thread Jay Zhou
Signed-off-by: Jay Zhou --- MAINTAINERS| 4 +++ config/common_base | 14 + doc/guides/rel_notes/release_18_05.rst | 3 ++ drivers/crypto/Makefile| 1 + drivers/crypto/virtio/

[dpdk-dev] [PATCH v6 06/10] crypto/virtio: support stats related ops

2018-04-03 Thread Jay Zhou
Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_cryptodev.c | 66 +++- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.c b/drivers/crypto/virtio/virtio_cryptodev.c index 11f725a..0ab0d38 100644 --- a/drive

[dpdk-dev] [PATCH v6 09/10] test/crypto: add function tests for virtio crypto PMD

2018-04-03 Thread Jay Zhou
Only RTE_CRYPTO_CIPHER_AES_CBC cipher algorithm are tested as unit test, it is supported both by the cryptodev-backend-builtin and cryptodev-vhost-user of qemu side. Signed-off-by: Jay Zhou --- test/test/test_cryptodev.c | 48 + test/test/test_cryptod

[dpdk-dev] [PATCH v6 10/10] doc: add virtio crypto PMD guide

2018-04-03 Thread Jay Zhou
Signed-off-by: Jay Zhou --- MAINTAINERS | 2 + doc/guides/cryptodevs/features/virtio.ini | 26 +++ doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryptodevs/virtio.rst | 117 ++ doc/guides/rel_notes/release_1

[dpdk-dev] [PATCH v6 08/10] crypto/virtio: support HMAC-SHA1

2018-04-03 Thread Jay Zhou
Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_crypto_capabilities.h | 21 + drivers/crypto/virtio/virtio_cryptodev.c | 4 +++- 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/virtio/virtio_crypto_capabilities.h b/drivers/cry

[dpdk-dev] [PATCH v6 05/10] crypto/virtio: support crypto enqueue/dequeue burst API

2018-04-03 Thread Jay Zhou
Signed-off-by: Jay Zhou --- drivers/crypto/virtio/virtio_cryptodev.h | 2 + drivers/crypto/virtio/virtio_rxtx.c | 441 ++- 2 files changed, 433 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/virtio/virtio_cryptodev.h b/drivers/crypto/virtio/virtio_

Re: [dpdk-dev] [PATCH v9 7/9] test: add event timer adapter auto-test

2018-04-03 Thread Pavan Nikhilesh
On Mon, Apr 02, 2018 at 02:39:52PM -0500, Erik Gabriel Carrillo wrote: > Signed-off-by: Erik Gabriel Carrillo > --- > test/test/Makefile |1 + > test/test/test_event_timer_adapter.c | 1831 > ++ > 2 files changed, 1832 insertions(+) > create

Re: [dpdk-dev] [PATCH] build: meson set toolchain info during config init

2018-04-03 Thread Bruce Richardson
On Mon, Apr 02, 2018 at 11:58:23PM +0530, Pavan Nikhilesh wrote: > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > Signed-off-by: Pavan Nikhilesh > --- > config/arm/meson.build | 9 -

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 10:28:59AM +0100, Ferruh Yigit wrote: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already n

Re: [dpdk-dev] [PATCH v9 5/9] eventtimer: add default software driver

2018-04-03 Thread Pavan Nikhilesh
Hi Erik, On Mon, Apr 02, 2018 at 02:39:50PM -0500, Erik Gabriel Carrillo wrote: > If an eventdev PMD does not wish to provide event timer adapter ops > definitions, the library will fall back to a default software > implementation whose entry points are added by this commit. > > Signed-off-by: Eri

Re: [dpdk-dev] [PATCH v4] ethdev: replace bus specific struct with generic dev

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 10:06 AM, David Marchand wrote: > On Mon, Apr 2, 2018 at 6:13 PM, santosh > wrote: >> On Friday 30 March 2018 08:59 PM, David Marchand wrote: >>> I can see we enforce the driver name by putting it after the call to >>> .dev_infos_get. >>> http://dpdk.org/browse/dpdk/tree/lib/librte_eth

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 9:27 AM, Pascal Mazon wrote: > Hi, > > I'm not sure why you split this patch in two. > It seemed to me that it was fine to change the doc+logs in the same > patch as the code. > Especially since documentation change is very small. It was my suggestion indeed, to separate actual functi

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 9:27 AM, Pascal Mazon wrote: > Hi, > > I'm not sure why you split this patch in two. > It seemed to me that it was fine to change the doc+logs in the same > patch as the code. > Especially since documentation change is very small. It was my suggestion indeed, to separate actual functi

Re: [dpdk-dev] [PATCH] build: meson set toolchain info during config init

2018-04-03 Thread Pavan Nikhilesh
On Tue, Apr 03, 2018 at 10:55:08AM +0100, Bruce Richardson wrote: > On Mon, Apr 02, 2018 at 11:58:23PM +0530, Pavan Nikhilesh wrote: > > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > > > Sig

Re: [dpdk-dev] [PATCH v3 1/2] doc: add vfio api support

2018-04-03 Thread Thomas Monjalon
03/04/2018 10:28, Hemant Agrawal: > --- a/doc/api/doxy-api-index.md > +++ b/doc/api/doxy-api-index.md > @@ -179,4 +179,5 @@ The public API headers are grouped by topics: >[EAL config] (@ref rte_eal.h), >[common] (@ref rte_common.h), >[ABI compat] (@ref rte_co

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Thomas Monjalon
03/04/2018 10:31, Maxime Coquelin: > On 04/02/2018 06:25 PM, Stephen Hemminger wrote: > > Rather than wallpapering over the unused result, why not do real error > > checking? > > If the program was run in a non-Linux environment (such as WSL etc), maybe > > an error > > could occur. Best to retur

[dpdk-dev] [PATCH v2] build: meson set toolchain info during config init

2018-04-03 Thread Pavan Nikhilesh
Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Use get_id for identifying compiler instead of checking for compiler defines manually.(Bruce) c

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Thomas Monjalon
03/04/2018 11:28, Ferruh Yigit: > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named as ethdev. > > Also ther

[dpdk-dev] [PATCH v1 0/3]cryptodev: add unit tests and PMD for asym crypto

2018-04-03 Thread Shally Verma
This patch series includes unit test, openssl pmd and documentation patches for asymmetric crypto support in lib cryptodev framework. These are based on asym patch V1 series https://dpdk.org/dev/patchwork/patch/36575/ https://dpdk.org/dev/patchwork/patch/36576/ https://dpdk.org/dev/patchwork/patch

[dpdk-dev] [PATCH v1 2/3] crypto/openssl: add asym crypto support

2018-04-03 Thread Shally Verma
Add asymmetric crypto operation support in openssl PMD. Current list of supported asym xforms: * RSA * DSA * Deffie-hellman * Modular Operations Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- doc/guides/cryptodevs/features/openssl.ini | 11 + doc/

[dpdk-dev] [PATCH v1 1/3] lib/cryptodev: add unit testcase for asym crypto

2018-04-03 Thread Shally Verma
Initial unit test case to test openssl PMD asym crypto operations. Test case invoke asymmetric operation on DPDK Openssl PMD and cross-verify results via Openssl SW library. Tests have been verified with openssl 1.0.2m release. Tested for: * RSA Encrypt, Decrypt, Sign and Verify using pre-defined

[dpdk-dev] [PATCH v1 3/3] doc: add asym crypto in cryptodev programmer guide

2018-04-03 Thread Shally Verma
update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta --- doc/guides/prog_guide/cryptodev_lib.rst | 338 +++- 1 file changed, 329 inserti

[dpdk-dev] [PATCH V18 1/4] eal: add device event handle in interrupt thread

2018-04-03 Thread Jeff Guo
Add new interrupt handle type of RTE_INTR_HANDLE_DEV_EVENT, for device event interrupt monitor. Signed-off-by: Jeff Guo --- v18->v17: no change. --- lib/librte_eal/common/include/rte_eal_interrupts.h | 1 + lib/librte_eal/linuxapp/eal/eal_interrupts.c | 11 +- test/test/test_interrupt

[dpdk-dev] [PATCH V18 0/4] add device event monitor framework

2018-04-03 Thread Jeff Guo
About hot plug in dpdk, We already have proactive way to add/remove devices through APIs (rte_eal_hotplug_add/remove), and also have fail-safe driver to offload the fail-safe work from the app user. But there are still lack of a general mechanism to monitor hotplug event for all driver, now the hot

[dpdk-dev] [PATCH V18 2/4] eal: add device event monitor framework

2018-04-03 Thread Jeff Guo
This patch aims to add a general device event monitor framework at EAL device layer, for device hotplug awareness and actions adopted accordingly. It could also expand for all other types of device event monitor, but not in this scope at the stage. To get started, users firstly call below new adde

[dpdk-dev] [PATCH V18 4/4] app/testpmd: enable device hotplug monitoring

2018-04-03 Thread Jeff Guo
Use testpmd for example, to show how an application use device event APIs to monitor the hotplug events, including both hot removal event and hot insertion event. The process is that, testpmd first enable hotplug by below commands, E.g. ./build/app/testpmd -c 0x3 --n 4 -- -i --hot-plug then test

[dpdk-dev] [PATCH V18 3/4] eal/linux: uevent parse and process

2018-04-03 Thread Jeff Guo
In order to handle the uevent which has been detected from the kernel side, add uevent parse and process function to translate the uevent into device event, which user has subscribed to monitor. Signed-off-by: Jeff Guo --- v18->v17: refine socket configuration. --- lib/librte_eal/linuxapp/eal/ea

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Neil Horman
On Mon, Apr 02, 2018 at 09:25:15AM -0700, Stephen Hemminger wrote: > On Sat, 31 Mar 2018 14:48:55 -0400 > Neil Horman wrote: > > > On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: > > > On Sat, Mar 31, 2018 at 11:27:55AM -0400, Neil Horman wrote: > > > > On Sat, Mar 31, 2018 at 05:

Re: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads API

2018-04-03 Thread Ananyev, Konstantin
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 3, 2018 8:11 AM > To: Ananyev, Konstantin ; Zhang, Qi Z > ; Wang, Xiao W > Cc: 'dev@dpdk.org' > Subject: RE: [dpdk-dev] [PATCH v2 1/2] net/fm10k: convert to new Rx offloads > API > > Thanks, Konstantin and Zhang Qi for your

Re: [dpdk-dev] [PATCH 2/2] net/tap: add tun log and documnetation

2018-04-03 Thread Pascal Mazon
Ok Ferruh, I missed that. Apart for the type in "documentation" the patches are ok with me. Acked-by: Pascal Mazon On 03/04/2018 12:05, Ferruh Yigit wrote: > On 4/3/2018 9:27 AM, Pascal Mazon wrote: >> Hi, >> >> I'm not sure why you split this patch in two. >> It seemed to me that it was fine to

Re: [dpdk-dev] [PATCH v2] build: meson set toolchain info during config init

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 03:51:10PM +0530, Pavan Nikhilesh wrote: > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > Signed-off-by: Pavan Nikhilesh > --- > > v2 Changes: > - Use get_id for id

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > 03/04/2018 11:28, Ferruh Yigit: > > Library folder name and output library name are same except a few flaws > > including librte_ether. > > > > This library is network device abstraction layer, the name "ethdev" fits > > better tha

Re: [dpdk-dev] [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters

2018-04-03 Thread Remy Horton
On 28/03/2018 08:18, Shreyansh Jain wrote: [..] Can the change for burst size too be accommodated in this patch? I looked through them and they might not be as trivial as the change above - but if that is incorporated in this, it might serve as example for other applications. Testpmd doesn't r

Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support

2018-04-03 Thread Ferruh Yigit
On 3/31/2018 6:04 PM, Alejandro Lucero wrote: > > > On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit > wrote: > > On 3/23/2018 5:35 PM, Alejandro Lucero wrote: > > CPP refers to the internal NFP Command Push Pull bus. This patch allows > > to create CPP

Re: [dpdk-dev] [PATCH v2] build: meson set toolchain info during config init

2018-04-03 Thread Pavan Nikhilesh
On Tue, Apr 03, 2018 at 11:55:24AM +0100, Bruce Richardson wrote: > On Tue, Apr 03, 2018 at 03:51:10PM +0530, Pavan Nikhilesh wrote: > > Meson set RTE_TOOLCHAIN to clang/gcc and set RTE_TOOLCHAIN_CLANG/GCC to > > 1 during initilizing dpdk_conf so that it can be used by both x86 and arm. > > > > Sig

[dpdk-dev] [PATCH] examples/ipsec-secgw: limit inflight packets count

2018-04-03 Thread Radu Nicolau
Revert previous patch that introduce a performance degradation in certain scenarios and add a configurable limit for number inflight packets. Revert commit 84d4b5e4ec48 ("examples/ipsec-secgw: improve IPsec dequeue logic") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau --- examples/ipsec-secgw

[dpdk-dev] [PATCH v4 2/2] eal/vfio: export internal vfio functions

2018-04-03 Thread Hemant Agrawal
This patch moves some of the internal vfio functions from eal_vfio.h to rte_vfio.h for common uses with "rte_" prefix. This patch also change the FSLMC bus usages from the internal VFIO functions to external ones with "rte_" prefix Signed-off-by: Hemant Agrawal Acked-by: Anatoly Burakov --- dr

[dpdk-dev] [PATCH v4 1/2] doc: add vfio api support

2018-04-03 Thread Hemant Agrawal
Signed-off-by: Hemant Agrawal --- doc/api/doxy-api-index.md| 3 ++- doc/api/doxy-api.conf| 1 + lib/librte_eal/common/include/rte_vfio.h | 5 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/doc/api/doxy-api-index.md b/doc/api/doxy-api-index.

[dpdk-dev] [PATCH v3] build: meson set toolchain info during config init

2018-04-03 Thread Pavan Nikhilesh
Meson identify toolchain using cc.get_id and set RTE_TOOLCHAIN, RTE_TOOLCHAIN_X during initializing dpdk_conf so that it can be used by both x86 and arm. Suggested-by: Bruce Richardson Signed-off-by: Pavan Nikhilesh --- v3 Changes: - Use a generic way of setting toolchain instead of chaining

Re: [dpdk-dev] [PATCH] net/nfp: support new HW offloads API

2018-04-03 Thread Ferruh Yigit
On 3/31/2018 5:53 PM, Alejandro Lucero wrote: > > > On Tue, Mar 27, 2018 at 7:25 PM, Ferruh Yigit > wrote: > > On 3/15/2018 2:30 PM, Alejandro Lucero wrote: > > In next 18.05 the old hw offload API will be removed. This patch adds > > support for just

[dpdk-dev] [PATCH] [pktgen] [PATCH v2] Fix the compiling warnings

2018-04-03 Thread Bing Zhao
AT, fix the compiling the warnings/errors in the first patch. Signed-off-by: Bing Zhao --- app/cli-functions.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/app/cli-functions.c b/app/cli-functions.c index 1bddbbe..486c78a 100644 --- a/app/cli-functions.c +++ b

Re: [dpdk-dev] [PATCH v3] build: meson set toolchain info during config init

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 04:54:52PM +0530, Pavan Nikhilesh wrote: > Meson identify toolchain using cc.get_id and set RTE_TOOLCHAIN, > RTE_TOOLCHAIN_X during initializing dpdk_conf so that it can be used by > both x86 and arm. > > Suggested-by: Bruce Richardson > Signed-off-by: Pavan Nikhilesh > -

[dpdk-dev] [PATCH v4 0/1] server mode virtio-user

2018-04-03 Thread zhiyong . yang
In a container environment if the vhost-user backend restarts, there's no way for it to reconnect to virtio-user currently. To address this, support for server mode is added. In this mode the socket file is created by virtio-user, which the backend connects to. This means that if the backend restar

[dpdk-dev] [PATCH v4 1/1] net/virtio-user: add support for server mode

2018-04-03 Thread zhiyong . yang
virtio-user adds support for server mode in this patch. Client mode vhost-user startup firstly, server mode virtio-user startups and creates the socket file to exchange vhost messages. If the connection is broken, client mode vhost-user can support to reconnect virtio-user. Server mode virtio-us

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Thomas Monjalon
03/04/2018 12:57, Bruce Richardson: > On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > > 03/04/2018 11:28, Ferruh Yigit: > > > Library folder name and output library name are same except a few flaws > > > including librte_ether. > > > > > > This library is network device abstract

Re: [dpdk-dev] [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit support

2018-04-03 Thread Ferruh Yigit
On 3/19/2018 12:33 PM, Kumar, Ravi1 wrote: >> >> >> -Original Message- >> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] >> Sent: Friday, March 16, 2018 11:12 PM >> To: Kumar, Ravi1 ; dev@dpdk.org >> Subject: Re: [PATCH v3 01/18] net/axgbe: add minimal dev init and uninit >> support >

Re: [dpdk-dev] [PATCH v4 2/2] eal/vfio: export internal vfio functions

2018-04-03 Thread Thomas Monjalon
03/04/2018 13:10, Hemant Agrawal: > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -255,5 +255,8 @@ EXPERIMENTAL { > rte_service_set_runstate_mapped_check; > rte_service_set_stats_enable; > rte_service_start_with_defaults; > + rte_vfio

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 02:20:30PM +0200, Thomas Monjalon wrote: > 03/04/2018 12:57, Bruce Richardson: > > On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: > > > 03/04/2018 11:28, Ferruh Yigit: > > > > Library folder name and output library name are same except a few flaws > > > > i

[dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Olivier Matz
Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation is successful. The patch also updates all th

Re: [dpdk-dev] [PATCH 1/2] event/sw: code refractor to reduce the fetch stall

2018-04-03 Thread Van Haaren, Harry
Hey, > -Original Message- > From: Varghese, Vipin > Sent: Thursday, March 1, 2018 7:35 PM > To: dev@dpdk.org; Van Haaren, Harry > Cc: Varghese, Vipin > Subject: [PATCH 1/2] event/sw: code refractor to reduce the fetch stall > > With rearranging the code to prefetch the contents before >

Re: [dpdk-dev] [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf

2018-04-03 Thread Van Haaren, Harry
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, March 1, 2018 7:35 PM > To: dev@dpdk.org; Van Haaren, Harry > Cc: Varghese, Vipin > Subject: [PATCH 2/2] event/sw: code refractor for sw_refill_pp_buf > > Code changes how shadow buffer are filled up in each calls. > Refillin

Re: [dpdk-dev] [PATCH 1/4] net/nfp: add NFP CPP support

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 12:09 PM, Ferruh Yigit wrote: > On 3/31/2018 6:04 PM, Alejandro Lucero wrote: >> >> >> On Fri, Mar 30, 2018 at 11:37 AM, Ferruh Yigit > > wrote: >> >> On 3/23/2018 5:35 PM, Alejandro Lucero wrote: >> > CPP refers to the internal NFP Command Push Pu

Re: [dpdk-dev] [PATCH v4 2/2] eal/vfio: export internal vfio functions

2018-04-03 Thread Hemant Agrawal
On 4/3/2018 5:54 PM, Thomas Monjalon wrote: 03/04/2018 13:10, Hemant Agrawal: --- a/lib/librte_eal/rte_eal_version.map +++ b/lib/librte_eal/rte_eal_version.map @@ -255,5 +255,8 @@ EXPERIMENTAL { rte_service_set_runstate_mapped_check; rte_service_set_stats_enable; rte_se

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Andrew Rybchenko
On 04/03/2018 03:41 PM, Olivier Matz wrote: Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a return code is added to notify the caller (librte_ether) if an error occurred in the PMD. The new default MAC address is now copied in dev->data->mac_addrs[0] only if the operation

[dpdk-dev] [PATCH v2 0/4] fix control thread affinities

2018-04-03 Thread Olivier Matz
Some parts of dpdk use their own management threads. Most of the time, the affinity of the thread is not properly set: it should not be scheduled on the dataplane cores, because interrupting them can cause packet losses. This patchset introduces a new wrapper for thread creation that does the job

[dpdk-dev] [PATCH v2 1/4] eal: use sizeof to avoid a double use of a define

2018-04-03 Thread Olivier Matz
Only a cosmetic change: the *_LEN defines are already used when defining the buffer. Using sizeof() ensures that the length stays consistent, even if the definition is modified. Signed-off-by: Olivier Matz --- lib/librte_eal/bsdapp/eal/eal.c | 2 +- lib/librte_eal/bsdapp/eal/eal_thread.

[dpdk-dev] [PATCH v2 3/4] eal: set name when creating a control thread

2018-04-03 Thread Olivier Matz
To avoid code duplication, add a parameter to rte_ctrl_thread_create() to specify the name of the thread. This requires to add a wrapper for the thread start routine in rte_thread_init(), which will first wait that the thread is configured. Signed-off-by: Olivier Matz --- drivers/net/kni/rte_et

[dpdk-dev] [PATCH v2 2/4] eal: new function to create control threads

2018-04-03 Thread Olivier Matz
Many parts of dpdk use their own management threads. Introduce a new wrapper for thread creation that will be extended in next commits to set the name and affinity. To be consistent with other DPDK APIs, the return value is negative in case of error, which was not the case for pthread_create(). S

[dpdk-dev] [PATCH v2 4/4] eal: set affinity for control threads

2018-04-03 Thread Olivier Matz
The management threads must not bother the dataplane or service cores. Set the affinity of these threads accordingly. Signed-off-by: Olivier Matz --- lib/librte_eal/common/eal_common_thread.c | 22 +- lib/librte_eal/common/include/rte_lcore.h | 4 +++- 2 files changed, 24 in

Re: [dpdk-dev] [PATCH v3] build: meson set toolchain info during config init

2018-04-03 Thread Bruce Richardson
On Tue, Apr 03, 2018 at 12:58:16PM +0100, Bruce Richardson wrote: > On Tue, Apr 03, 2018 at 04:54:52PM +0530, Pavan Nikhilesh wrote: > > Meson identify toolchain using cc.get_id and set RTE_TOOLCHAIN, > > RTE_TOOLCHAIN_X during initializing dpdk_conf so that it can be used by > > both x86 and arm.

Re: [dpdk-dev] [PATCH v2 0/4] fix control thread affinities

2018-04-03 Thread Olivier Matz
Sorry, I forgot the --in-reply-to. This patchset is the second version of this one: http://dpdk.org/ml/archives/dev/2018-February/091576.html On Tue, Apr 03, 2018 at 03:04:35PM +0200, Olivier Matz wrote: > Some parts of dpdk use their own management threads. Most of the time, > the affinity of t

Re: [dpdk-dev] Build is broken in dpdk-next-net

2018-04-03 Thread Wiles, Keith
> On Apr 3, 2018, at 5:41 AM, Neil Horman wrote: > > On Mon, Apr 02, 2018 at 09:25:15AM -0700, Stephen Hemminger wrote: >> On Sat, 31 Mar 2018 14:48:55 -0400 >> Neil Horman wrote: >> >>> On Sat, Mar 31, 2018 at 06:21:41PM +0200, Gaëtan Rivet wrote: On Sat, Mar 31, 2018 at 11:27:55AM -040

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Wiles, Keith
> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit wrote: > > Library folder name and output library name are same except a few flaws > including librte_ether. > > This library is network device abstraction layer, the name "ethdev" fits > better than "ether", and library & header files already named a

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Wiles, Keith
> On Apr 3, 2018, at 7:33 AM, Bruce Richardson > wrote: > > On Tue, Apr 03, 2018 at 02:20:30PM +0200, Thomas Monjalon wrote: >> 03/04/2018 12:57, Bruce Richardson: >>> On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote: 03/04/2018 11:28, Ferruh Yigit: > Library folder nam

[dpdk-dev] [PATCH] ring: relax alignment constraint on ring structure

2018-04-03 Thread Olivier Matz
The initial objective of commit d9f0d3a1ffd4 ("ring: remove split cacheline build setting") was to add an empty cache line betwee, the producer and consumer data (on platform with cache line size = 64B), preventing from having them on adjacent cache lines. Following discussion on the mailing list,

Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name

2018-04-03 Thread Ferruh Yigit
On 4/3/2018 2:17 PM, Wiles, Keith wrote: > > >> On Apr 3, 2018, at 4:28 AM, Ferruh Yigit wrote: >> >> Library folder name and output library name are same except a few flaws >> including librte_ether. >> >> This library is network device abstraction layer, the name "ethdev" fits >> better than "

[dpdk-dev] [PATCH v2 1/2] crypto/aesni_mb: support IPsec MUlti-buffer lib v0.49

2018-04-03 Thread Kovacevic, Marko
From: Marko Kovacevic Adds support for the v0.49 of the IPsec Multi-buffer lib, which now gets compiled and installed as a shared object. Therefore, there is no need to pass the AESNI_MULTI_BUFFER_LIB_PATH Signed-off-by: Marko Kovacevic --- V2: Added commit message --- devtools/test-build.s

[dpdk-dev] [PATCH v2 2/2] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.49

2018-04-03 Thread Kovacevic, Marko
Adds support for the v0.49 of the IPsec Multi-buffer lib, which now gets compiled and installed as a shared object. Therefore, there is no need to pass the AESNI_MULTI_BUFFER_LIB_PATH Signed-off-by: Marko Kovacevic --- V2: Added commit body message --- devtools/test-build.sh

Re: [dpdk-dev] [PATCH] kni: optimize the kni release speed

2018-04-03 Thread zhouyangchao
On Tue, Mar 27, 2018 at 12:44 AM Ferruh Yigit wrote: > On 2/6/2018 10:33 AM, zhouyangchao wrote: > > Physical addresses in the fifo named alloc_q need to be traversed to > > release in user space. The physical address to the virtual address > > conversion in kernel space is much better. > > Yes c

[dpdk-dev] [PATCH v2] crypto/aesni_mb: support AES CMAC

2018-04-03 Thread Kovacevic, Marko
From: Marko Kovacevic Added support for AES CMAC hash algorithm with 128-bit key, which has been added in the v0.49 of the IPSec Multi-buffer lib. Signed-off-by: Marko Kovacevic --- V2: Added commit message --- doc/guides/cryptodevs/aesni_mb.rst | 1 + doc/guides/cryptodevs

[dpdk-dev] [PATCH] mbuf: remove control mbuf

2018-04-03 Thread Olivier Matz
The rte_ctrlmbuf structure is not used by any example application in dpdk. Remove it, as announced on the mailing list. Signed-off-by: Olivier Matz --- doc/guides/prog_guide/glossary.rst | 3 -- doc/guides/prog_guide/mbuf_lib.rst | 11 ++--- doc/guides/prog_guide/overview.rst | 4 +

Re: [dpdk-dev] [PATCH v2 0/2] net/e1000: convert to new Rx/Tx offloads API

2018-04-03 Thread Zhang, Qi Z
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 3, 2018 10:55 AM > To: Lu, Wenzhuo ; Zhang, Qi Z > Cc: dev@dpdk.org; Dai, Wei > Subject: [PATCH v2 0/2] net/e1000: convert to new Rx/Tx offloads API > > This patch set convert net/e1000 to new Rx/Tx offloads API. > All Rx off

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-04-03 Thread Maxime Coquelin
Hi Pawel, Fan, On 04/01/2018 09:53 PM, Zhang, Roy Fan wrote: Hi Pawel, -Original Message- From: Wodkowski, PawelX Sent: Thursday, March 29, 2018 2:48 PM To: Zhang, Roy Fan ; dev@dpdk.org Cc: maxime.coque...@redhat.com; jianjay.z...@huawei.com; Tan, Jianfeng Subject: RE: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-04-03 Thread Zhang, Roy Fan
Hi Maxime, No problem. I will work on that. Pawel, Jianfeng, if you guys have other concerns or suggestions, please give me a shout. Thanks a lot guys, for the review and help! Regards, Fan > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday

Re: [dpdk-dev] [PATCH] net/i40e: fix flow RSS tci using error

2018-04-03 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 3, 2018 2:10 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Zhao1, Wei > Subject: [PATCH] net/i40e: fix flow RSS tci using error > > Vlan tci configuration from testpmd is store in big endian, so it need to be > change to little

Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

2018-04-03 Thread Carrillo, Erik G
Hi Jerin, Question in-line: > -Original Message- > From: Jerin Jacob [mailto:jerin.ja...@caviumnetworks.com] > Sent: Monday, April 2, 2018 6:19 PM > To: Carrillo, Erik G > Cc: pbhagavat...@caviumnetworks.com; dev@dpdk.org; > hemant.agra...@nxp.com > Subject: Re: [PATCH v9 0/9] eventtimer

Re: [dpdk-dev] [PATCH v9 0/9] eventtimer: introduce event timer adapter

2018-04-03 Thread Jerin Jacob
-Original Message- > Date: Tue, 3 Apr 2018 14:09:22 + > From: "Carrillo, Erik G" > To: Jerin Jacob > CC: "dev@dpdk.org" > Subject: RE: [PATCH v9 0/9] eventtimer: introduce event timer adapter > > Hi Jerin, Hi Carrillo, > > Question in-line: > > > 1) Please fix following check-p

Re: [dpdk-dev] [PATCH 3/4] mk: allow kernel artifacts to be located in output directory

2018-04-03 Thread Ferruh Yigit
On 3/30/2018 7:23 PM, Scott Branden wrote: > Hi Ferruh, > > > On 18-03-30 03:35 AM, Ferruh Yigit wrote: >> On 3/21/2018 6:06 PM, Ajit Khaparde wrote: >>> From: Scott Branden >>> >>> Allow kernel artifacts to be located in output directory specific >>> by RTE_KERNELDIR_OUT. >> How to use this var

Re: [dpdk-dev] [PATCH v3 0/5] handle seq no overflow in IPsec offload

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: This series enables application to set the sequence number soft limit for IPsec offload. In inline IPsec offload, as the sequence number (maintained by PMD/device) reaches the specified soft limit, t

Re: [dpdk-dev] [PATCH v3 2/5] lib/security: add ESN soft limit in conf

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding ESN soft limit in conf. This will be used in case of protocol offload. Per SA, application could specify for what ESN the security device need to notify application. In case of eth dev(inline p

Re: [dpdk-dev] [PATCH v3 1/5] lib/ethdev: support for inline IPsec events

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding support for IPsec events in rte_eth_event framework. In inline IPsec offload, the per packet protocol defined variables, like ESN, would be managed by PMD. In such cases, PMD would need IPsec e

Re: [dpdk-dev] [PATCH v3 3/5] lib/security: extend userdata for IPsec events

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Extending 'userdata' to be used for IPsec events too. IPsec events would have some metadata which would uniquely identify the security session for which the event is raised. But application would nee

Re: [dpdk-dev] [PATCH v3 4/5] examples/ipsec-secgw: handle ESN soft limit event

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: For inline protocol processing, the PMD/device is required to maintain the ESN. But the application is required to monitor ESN overflow to initiate SA expiry. For such cases, application would set th

Re: [dpdk-dev] [PATCH v3 5/5] app/testpmd: support for IPsec event

2018-04-03 Thread Anoob Joseph
Adding maintainers of testpmd & lib/ethdev Thanks, Anoob On 21/03/18 16:41, Anoob Joseph wrote: Adding support for IPsec event Signed-off-by: Anoob Joseph --- v3: * No change v2: * No change app/test-pmd/parameters.c | 2 ++ app/test-pmd/testpmd.c| 2 ++ 2 files changed, 4 insertions

Re: [dpdk-dev] [PATCH v5 2/5] vhost: support selective datapath

2018-04-03 Thread Wang, Zhihong
> -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Tuesday, April 3, 2018 4:19 PM > To: Wang, Zhihong ; dev@dpdk.org > Cc: Tan, Jianfeng ; Bie, Tiwei ; > y...@fridaylinux.org; Liang, Cunming ; Wang, Xiao > W ; Daly, Dan > Subject: Re: [PATCH v5 2/5]

[dpdk-dev] Documentation build is broken because of missing nics/mrvl

2018-04-03 Thread Andrew Rybchenko
Hi all, documentation build is broken because of Marvell PMD renaming and using of old name in 17.11 release notes. Could someone fix it? /tmp/dpdk-next-net/doc/guides/rel_notes/release_17_11.rst:58: WARNING: unknown document: ../nics/mrvl I guess fixing release notes is the only way. Andr

Re: [dpdk-dev] [PATCH] mbuf: remove control mbuf

2018-04-03 Thread Jerin Jacob
-Original Message- > Date: Tue, 3 Apr 2018 15:39:13 +0200 > From: Olivier Matz > To: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] mbuf: remove control mbuf > X-Mailer: git-send-email 2.11.0 > > The rte_ctrlmbuf structure is not used by any example application > in dpdk. Remove it, as announ

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-04-03 Thread Tan, Jianfeng
On 4/3/2018 9:44 PM, Maxime Coquelin wrote: Hi Pawel, Fan, On 04/01/2018 09:53 PM, Zhang, Roy Fan wrote: Hi Pawel, -Original Message- From: Wodkowski, PawelX Sent: Thursday, March 29, 2018 2:48 PM To: Zhang, Roy Fan ; dev@dpdk.org Cc: maxime.coque...@redhat.com; jianjay.z...@huawei.

Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external backend support

2018-04-03 Thread Wodkowski, PawelX
> -Original Message- > From: Tan, Jianfeng > Sent: Tuesday, April 3, 2018 4:43 PM > To: Maxime Coquelin ; Zhang, Roy Fan > ; Wodkowski, PawelX > ; dev@dpdk.org > Cc: jianjay.z...@huawei.com > Subject: Re: [dpdk-dev] [PATCH v4 1/8] lib/librte_vhost: add external > backend support > > > >

Re: [dpdk-dev] [PATCH v2 5/7] bpf: introduce basic RX/TX BPF filters

2018-04-03 Thread Ananyev, Konstantin
Hi Jerin, > > Hi Konstantin, > > > +/* > > + * Marks given callback as used by datapath. > > + */ > > +static __rte_always_inline void > > +bpf_eth_cbi_inuse(struct bpf_eth_cbi *cbi) > > +{ > > + cbi->use++; > > + /* make sure no store/load reordering could happen */ > > + rte_smp_mb(); >

Re: [dpdk-dev] [PATCH v2] ethdev: return diagnostic when setting MAC address

2018-04-03 Thread Adrien Mazarguil
On Tue, Apr 03, 2018 at 02:41:03PM +0200, Olivier Matz wrote: > Change the prototype and the behavior of dev_ops->eth_mac_addr_set(): a > return code is added to notify the caller (librte_ether) if an error > occurred in the PMD. > > The new default MAC address is now copied in dev->data->mac_addr

[dpdk-dev] [PATCH v3 00/12] event/octeontx: add event timer adapter driver

2018-04-03 Thread Pavan Nikhilesh
The event timer adapter[1] provides APIs to configure an event timer device that allows an application to arm timers which on expiry push events to an event device such as OcteonTx SSO. The OcteonTx TIM is a co-processor that can be configured as an event timer adapter which can be used by an appli

[dpdk-dev] [PATCH v3 01/12] mempool/octeontx: probe timvf PCIe devices

2018-04-03 Thread Pavan Nikhilesh
On Octeontx HW, each event timer device is enumerated as separate SRIOV VF PCIe device. In order to expose as a event timer device: On PCIe probe, the driver stores the information associated with the PCIe device and later when appliacation requests for a event timer device through `rte_event_time

[dpdk-dev] [PATCH v3 02/12] usertools: add Cavium TIM as an event device

2018-04-03 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ff4b186e8..d0c420906 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -22,12 +22

[dpdk-dev] [PATCH v3 04/12] event/octeontx: add support to start and stop timer device

2018-04-03 Thread Pavan Nikhilesh
When application requests to start the timer adapter through `rte_event_timer_adapter_start`, Octeontx TIMvf ring does the following: - Uses mbox to communicate TIMpf driver about, * SCLK frequency used to convert ns<->cycles. * program the ring control parameters and start the ring. * get th

[dpdk-dev] [PATCH v3 03/12] event/octeontx: add support to create and free timer adapter

2018-04-03 Thread Pavan Nikhilesh
When the application requests to create a timer device, Octeontx TIM create does the following: - Get the requested TIMvf ring based on adapter_id. - Verify the config parameters supplied. - Allocate memory required for * Buckets based on min and max timeout supplied. * Allocate the chunk pool

[dpdk-dev] [PATCH v3 05/12] event/octeontx: add event timer stats get and reset

2018-04-03 Thread Pavan Nikhilesh
Add functions to get and reset event timer adapter stats. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 26 ++ drivers/event/octeontx/timvf_evdev.h | 1 + 2 files changed, 27 insertions(+) diff --git a/drivers/event/octeontx/timvf_evdev.c b/

[dpdk-dev] [PATCH v3 06/12] event/octeontx: add multiproducer timer arm and cancel

2018-04-03 Thread Pavan Nikhilesh
Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/Makefile | 5 + drivers/event/octeontx/meson.build| 1 + drivers/event/octeontx/timvf_evdev.c | 7 +- drivers/event/octeontx/timvf_evdev.h | 32 drivers/event/octeontx/timvf_worker.c | 95 drivers/even

[dpdk-dev] [PATCH v3 07/12] event/octeontx: add single producer timer arm variant

2018-04-03 Thread Pavan Nikhilesh
When application creates the timer adapter by passing `RTE_EVENT_TIMER_ADAPTER_F_SP_PUT` flag, we can optimize the arm sequence by removing the locking overhead. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 15 --- drivers/event/octeontx/timvf_evdev.h | 2

[dpdk-dev] [PATCH v3 09/12] event/octeontx: optimize timer adapter resolution parameters

2018-04-03 Thread Pavan Nikhilesh
When application sets `RTE_EVENT_TIMER_ADAPTER_F_ADJUST_RES` flag while creating adapter underlying driver is free to optimize the resolution for best possible configuration. Signed-off-by: Pavan Nikhilesh --- drivers/event/octeontx/timvf_evdev.c | 48 +++- driver

  1   2   3   4   >