[dpdk-dev] [PATCH v9 1/5] vfio: extend data structure for multi container

2018-04-17 Thread Xiao Wang
Currently eal vfio framework binds vfio group fd to the default container fd during rte_vfio_setup_device, while in some cases, e.g. vDPA (vhost data path acceleration), we want to put vfio group to a separate container and program IOMMU via this container. This patch extends the vfio_config struc

[dpdk-dev] [PATCH v9 0/5] add ifcvf vdpa driver

2018-04-17 Thread Xiao Wang
IFCVF driver The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works as a HW vhost backend which can send/receive packets to/from virtio directly by DMA. Besides, it supports dirty pa

[dpdk-dev] [PATCH v9 3/5] net/virtio: skip device probe in vdpa mode

2018-04-17 Thread Xiao Wang
If we want a virtio device to work in vDPA (vhost data path acceleration) mode, we could add a "vdpa=1" devarg for this device to specify the mode. This patch let virtio pmd skip device probe when detecting this parameter. Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin Reviewed-by: Ferru

[dpdk-dev] [PATCH v9 4/5] net/ifcvf: add ifcvf vdpa driver

2018-04-17 Thread Xiao Wang
The IFCVF vDPA (vhost data path acceleration) driver provides support for the Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it works as a HW vhost backend which can send/receive packets to/from virtio directly by DMA. Different VF devices serve different virtio frontends

[dpdk-dev] [PATCH v9 5/5] doc: add ifcvf driver document and release note

2018-04-17 Thread Xiao Wang
Signed-off-by: Xiao Wang Reviewed-by: Maxime Coquelin Reviewed-by: Ferruh Yigit --- doc/guides/nics/features/ifcvf.ini | 8 +++ doc/guides/nics/ifcvf.rst | 98 ++ doc/guides/nics/index.rst | 1 + doc/guides/rel_notes/release_18_05.

[dpdk-dev] [PATCH v9 2/5] vfio: add multi container support

2018-04-17 Thread Xiao Wang
This patch adds APIs to support container create/destroy and device bind/unbind with a container. It also provides API for IOMMU programing on a specified container. A driver could use "rte_vfio_container_create" helper to create a new container from eal, use "rte_vfio_container_group_bind" to bin

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-17 Thread Nélio Laranjeiro
On Tue, Apr 17, 2018 at 04:53:15AM +, Xueming(Steven) Li wrote: > > > > -Original Message- > > From: Adrien Mazarguil > > Sent: Tuesday, April 17, 2018 12:03 AM > > To: Xueming(Steven) Li > > Cc: Nélio Laranjeiro ; Shahaf Shuler > > ; dev@dpdk.org; > > Olivier Matz > > Subject: Re

Re: [dpdk-dev] [PATCH v6 51/70] mem: add support for mapping hugepages at runtime

2018-04-17 Thread Thomas Monjalon
17/04/2018 04:06, Yongseok Koh: > There's a bug in the old RedHat release: > Bug 1476120 - glibc headers don't include linux/falloc.h, and therefore > doesn't include fallocate() flags [1] > > How about adding "#include " ahead of fcntl.h? I'm quite lazy > to update my host and using CentOS 7.2.

[dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

2018-04-17 Thread Yanglong Wu
JUMBO_FRAME offload should be set as default, missing it will lead to start failing for I40e. Signed-off-by: Yanglong Wu --- drivers/net/i40e/i40e_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index

Re: [dpdk-dev] [PATCH v3 4/4] ethdev: add VLAN and MPLS pop push action in flow API

2018-04-17 Thread Shahaf Shuler
Monday, April 16, 2018 9:11 AM, Qi Zhang: > Subject: [dpdk-dev] [PATCH v3 4/4] ethdev: add VLAN and MPLS pop push > action in flow API > > Add couple Openflow frienldy VLAN/MPLS push/pop actions. > > RTE_FLOW_ACTION_VLAN_POP - pop a VLAN header. > RTE_FLOW_ACTION_VLAN_PUSH - push a VLAN header. >

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-17 Thread Xueming(Steven) Li
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 17, 2018 6:43 AM > To: Xueming(Steven) Li > Cc: dev@dpdk.org; Wenzhuo Lu ; Jingjing Wu > ; Yongseok Koh > ; Olivier MATZ ; Shahaf Shuler > ; > Ferruh Yigit > Subject: Re: [dpdk-dev] [PATCH v4 1/4] ethdev: introduce g

[dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading

2018-04-17 Thread Wei Dai
This patch adds missing supported Tx multi-segs offloading. Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API") Cc: sta...@dpdk.org Signed-off-by: Wei Dai --- drivers/net/ixgbe/ixgbe_rxtx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixg

Re: [dpdk-dev] [PATCH v4 1/4] ethdev: introduce generic IP/UDP tunnel checksum and TSO

2018-04-17 Thread Thomas Monjalon
17/04/2018 09:53, Xueming(Steven) Li: > From: Thomas Monjalon > > 08/04/2018 14:32, Xueming Li: > > > --- a/lib/librte_mbuf/rte_mbuf.h > > > +++ b/lib/librte_mbuf/rte_mbuf.h > > > @@ -210,6 +210,8 @@ extern "C" { > > > #define PKT_TX_TUNNEL_GENEVE (0x4ULL << 45) /**< TX packet with > > > MPLS-i

Re: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer

2018-04-17 Thread Maxime Coquelin
On 04/06/2018 05:13 PM, Pavan Nikhilesh wrote: Add event timer adapter as producer option that can be selected by passing --prod_type_timerdev. Signed-off-by: Pavan Nikhilesh Acked-by: Erik Gabriel Carrillo Acked-by: Jerin Jacob --- v5 Changes: - Resending cause missing Acked-by. v4

Re: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer

2018-04-17 Thread Pavan Nikhilesh
> It seems your patch introduce build regression on RHEL 7.5: > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) > > $ make -j32 install T=x86_64-native-linuxapp-gcc DESTDIR=legacy_destdir > > == Build app/test-eventdev > CC test_perf_common.o > /tmp/dpdk_build/app/test-eventdev/tes

Re: [dpdk-dev] [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer

2018-04-17 Thread Maxime Coquelin
On 04/17/2018 10:22 AM, Pavan Nikhilesh wrote: It seems your patch introduce build regression on RHEL 7.5: $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) $ make -j32 install T=x86_64-native-linuxapp-gcc DESTDIR=legacy_destdir == Build app/test-eventdev CC test_perf_common.o

Re: [dpdk-dev] [PATCH v5 10/11] ethdev: fix missing boolean values in flow command

2018-04-17 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 07:17:44PM +, Matan Azrad wrote: > Hi Adrien > > I think the title should be "app/testpmd: ..." ... Indeed, I'll update it in the next iteration, thanks. -- Adrien Mazarguil 6WIND

Re: [dpdk-dev] [PATCH] eal/ipc: fix missing mutex unlocks on failed msg send

2018-04-17 Thread Thomas Monjalon
13/04/2018 16:16, Anatoly Burakov: > Earlier fix for race condition introduced a bug where mutex > wasn't unlocked if message failed to be sent. Fix all of this > by moving locking out of mp_request_sync() altogether. > > Fixes: da5957821bdd ("eal: fix race condition in IPC request") > Cc: anatoly

Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading

2018-04-17 Thread Yao, Lei A
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 17, 2018 3:44 PM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Yao, Lei A > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading > > This patch adds missing sup

[dpdk-dev] [PATCH v2] ethdev: remove new to old offloads API helpers

2018-04-17 Thread Shahaf Shuler
According to commit 315ee8374e0e ("doc: reduce initial offload API rework scope to drivers") All PMDs should have moved to the new offloads API. Therefore it is safe to remove the new->old convert helps. The old->new helpers will remain to support application which still use

Re: [dpdk-dev] [PATCH v4 2/5] ethdev: introduce new tunnel VXLAN-GPE

2018-04-17 Thread Mohammad Abdul Awal
On 16/04/2018 23:23, Thomas Monjalon wrote: 13/04/2018 13:02, Xueming Li: +struct vxlan_gpe_hdr { + uint8_t vx_flags; /**< flag (8). */ + uint8_t reserved[2]; /**< Reserved (16). */ + uint8_t proto; /**< next-protocol (8). */ + uint32_t vx_vni; /**< VNI (24) + Reserve

Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile

2018-04-17 Thread Zhang, Roy Fan
Hi Thomas, In fact Meson compile enables all library builds so you cannot turn off cryptodev manually. So the condition checking to disable vhost crypto build is not necessary. Regards, Fan > -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, April 1

Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile

2018-04-17 Thread Bruce Richardson
On Mon, Apr 16, 2018 at 11:42:57PM +0200, Thomas Monjalon wrote: > 16/04/2018 16:08, Fan Zhang: > > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") > > > > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled. > > This patch fix this by adding checking to Makefile. > > > > Signed

Re: [dpdk-dev] [PATCH] net/sfc: fix meson build warning with gcc

2018-04-17 Thread Bruce Richardson
On Mon, Apr 16, 2018 at 06:09:29PM +0100, Ferruh Yigit wrote: > icc flag is causing build error with gcc, build error: > cc1: warning: unrecognized gcc debugging option: i > cc1: warning: unrecognized gcc debugging option: g > cc1: warning: unrecognized gcc debugging option: - > cc1: warning: unrec

[dpdk-dev] [PATCH v3 2/2] net/mlx5: fix flow director mask

2018-04-17 Thread Nelio Laranjeiro
During the transition to resurrect flow director on top of rte_flow, mask handling was removed by mistake. Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director") Cc: sta...@dpdk.org Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 56 ++

[dpdk-dev] [PATCH v3 1/2] net/mlx5: split L3/L4 in flow director

2018-04-17 Thread Nelio Laranjeiro
This will help to bring back the mask handler which was removed when this feature was rewritten on top of rte_flow. Signed-off-by: Nelio Laranjeiro Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 122 --- 1 file changed, 42 insertions(+), 80 deletio

[dpdk-dev] [PATCH v3 0/2] net/mlx5: fix flow director mask

2018-04-17 Thread Nelio Laranjeiro
Flow director mask as been mistakenly removed from mlx5 PMD. This series brings it back. Changes in v3: Let flow API handle the mask from the user. Changes in v2: Use the L3 structures instead of the l4 in the conversion. Nelio Laranjeiro (2): net/mlx5: split L3/L4 in flow director net/ml

Re: [dpdk-dev] [PATCH] examples/ipsec-secgw: fix usage print

2018-04-17 Thread Radu Nicolau
On 4/16/2018 1:23 PM, Anoob Joseph wrote: The usage print was not updated when jumbo frames & crypto_dev mask support was added. Fixing that. Also, the optional arguments were not properly highlighted in the usage header. This is also fixed. General cleanup of the usage print was also done to m

Re: [dpdk-dev] [PATCH v2 0/4] Hyper-V Netvsc PMD

2018-04-17 Thread Raslan Darawsheh
Hi Stephan, I've just tried to apply your patches on top of current master branch and I have the following two issues: 1- compilation is failing with the following error when compiling with RTE_TARGET=x86_64-native-linuxapp-gcc: /root/dpdk/x86_64-native-linuxapp-gcc/include/rte_common.h:122:30:

Re: [dpdk-dev] [PATCH v6 44/70] net/mlx5: use virt2memseg instead of iteration

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 3:48 AM, Yongseok Koh wrote: On Apr 11, 2018, at 5:30 AM, Anatoly Burakov wrote: Reduce dependency on internal details of EAL memory subsystem, and simplify code. Signed-off-by: Anatoly Burakov Tested-by: Santosh Shukla Tested-by: Hemant Agrawal Tested-by: Gowrishankar Muthuk

Re: [dpdk-dev] [PATCH] net/nfp: fix possible resource leak

2018-04-17 Thread Alejandro Lucero
Acked-by: Alejandro Lucero On Tue, Apr 17, 2018 at 6:59 AM, Yangchao Zhou wrote: > Signed-off-by: Yangchao Zhou > --- > drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c > b/drive

Re: [dpdk-dev] [PATCH 2/8] net/vmxnet3: return unknown IPv4 extension len ptype

2018-04-17 Thread Didier Pallard
Hi wang, Indeed, this one is not strictly needed and does not fix anything, anyway: - If application does not need the information (ethernet bridge, for example), this access is not needed and it will never be done, so application performance will be improved. - If application needs the info

Re: [dpdk-dev] [PATCH v4 15/16] ethdev: add physical port action to flow API

2018-04-17 Thread Mohammad Abdul Awal
On 16/04/2018 17:22, Adrien Mazarguil wrote: This patch adds the missing action counterpart to the PHY_PORT pattern item, that is, the ability to directly inject matching traffic into a physical port of the underlying device. It breaks ABI compatibility for the following public functions: - r

Re: [dpdk-dev] [PATCH v5 00/11] Bunch of flow API-related fixes

2018-04-17 Thread Ferruh Yigit
On 4/16/2018 5:21 PM, Adrien Mazarguil wrote: > This series contains several fixes for rte_flow and its implementation in > PMDs and testpmd. Upcoming work on the flow API depends on it. > > v5 changes: > > - No change, rebased series to address conflicts. > > v4 changes: > > - Rebased again. >

Re: [dpdk-dev] [dpdk-stable] [PATCH v5 09/11] ethdev: fix shallow copy of flow API RSS action

2018-04-17 Thread Nélio Laranjeiro
On Mon, Apr 16, 2018 at 06:22:03PM +0200, Adrien Mazarguil wrote: > The rss_conf field is defined as a pointer to struct rte_eth_rss_conf. > > Even assuming it is permanently allocated and a pointer copy is safe, > pointed data may change and not reflect an applied flow rule anymore. > > This pat

[dpdk-dev] [PATCH] net/nfp: support MAC address change

2018-04-17 Thread Alejandro Lucero
This patch allows to use another MAC address than the one coming with the NIC by default. The change requires to tell the vNIC after writing into the port BAR space. The change will fail if the port is enabled and the vNIC does not support a live address change. Signed-off-by: Alejandro Lucero -

Re: [dpdk-dev] [PATCH v5 02/11] net/mlx4: fix ignored RSS hash types

2018-04-17 Thread Nélio Laranjeiro
On Mon, Apr 16, 2018 at 06:21:50PM +0200, Adrien Mazarguil wrote: > When an unsupported hash type is part of a RSS configuration structure, it > is silently ignored instead of triggering an error. This may lead > applications to assume that such types are accepted, while they are in fact > not part

Re: [dpdk-dev] [PATCH v5 01/11] net/mlx4: fix RSS resource leak in case of error

2018-04-17 Thread Nélio Laranjeiro
On Mon, Apr 16, 2018 at 06:21:48PM +0200, Adrien Mazarguil wrote: > When memory cannot be allocated for a flow rule, its RSS context reference > is not dropped. > > Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") > Cc: sta...@dpdk.org > > Signed-off-by: Adrien Mazarguil > Cc:

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-17 Thread Ananyev, Konstantin
Hi everyone, Few comments from me below. In summary I am also in favor to keep binding decision at system level (outside DPDK). Konstantin > -Original Message- > From: Matan Azrad [mailto:ma...@mellanox.com] > Sent: Monday, April 16, 2018 5:11 PM > To: Richardson, Bruce > Cc: Burakov, A

[dpdk-dev] [PATCH v11 02/10] crypto/virtio: support virtio device init

2018-04-17 Thread Jay Zhou
This patch implements the initialization of the virtio crypto device. The virtio crypto device conforms to virtio-1.0, so this patch only supports modern mode operation. The cryptodev is created at the virtio crypto pci device probing stage. The function of virtio_crypto_pkt_tx_burst() is used to b

[dpdk-dev] [PATCH v11 05/10] crypto/virtio: support crypto enqueue/dequeue burst API

2018-04-17 Thread Jay Zhou
This patch implements the functions of virtio_crypto_pkt_tx_burst() and virtio_crypto_pkt_rx_burst(). The encryption and decryption requests are placed in the data queue and are ultimately handled by the backend crypto accelerators. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zh

[dpdk-dev] [PATCH v11 03/10] crypto/virtio: support basic PMD ops

2018-04-17 Thread Jay Zhou
This patch implements the basic operations of virtio crypto PMD, which includes start, stop, close, information getting, queue setup and release of the device. The virtio crypto device has two types of queues, data queue and control queue. It has one data queue at least and has one and only one con

[dpdk-dev] [PATCH v11 08/10] crypto/virtio: support HMAC-SHA1

2018-04-17 Thread Jay Zhou
The AES-CBC with HMAC-SHA1 has been supported now. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zhang --- drivers/crypto/virtio/virtio_crypto_capabilities.h | 21 + drivers/crypto/virtio/virtio_cryptodev.c | 4 +++- 2 files changed, 24 insertions(

[dpdk-dev] [PATCH v11 06/10] crypto/virtio: support stats related ops

2018-04-17 Thread Jay Zhou
This patch implements the statistics of the packets. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zhang --- drivers/crypto/virtio/virtio_cryptodev.c | 66 +++- 1 file changed, 64 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/virtio/virti

[dpdk-dev] [PATCH v11 04/10] crypto/virtio: support session related ops

2018-04-17 Thread Jay Zhou
This patch implements session related operations, which includes creating and destroying the session. For now, it only supports the session-oriented API implementation. The control queue used to create or destroy sessions for symmetric algorithms. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang A

[dpdk-dev] [PATCH v11 00/10] crypto: add virtio poll mode driver

2018-04-17 Thread Jay Zhou
This patch series introduce virtio crypto poll mode driver. Since it is limited by the vhost crypto backend of the virtio-crypto, this patch series only supports a limited subset of crypto services. Only the following algorithms are tested: Cipher algorithms: - RTE_CRYPTO_CIPHER_AES_CBC (128-bi

[dpdk-dev] [PATCH v11 01/10] crypto/virtio: add virtio crypto PMD

2018-04-17 Thread Jay Zhou
The virtio crypto device is a virtual cryptography device as well as a kind of virtual hardware accelerator for virtual machines. The linux kernel virtio-crypto driver has been merged, and this patch introduces virtio crypto PMD to achieve better performance. Signed-off-by: Jay Zhou Reviewed-by:

[dpdk-dev] [PATCH v11 07/10] crypto/virtio: support AES-CBC

2018-04-17 Thread Jay Zhou
The AES-CBC cipher only algorithm has been supported now. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zhang --- drivers/crypto/virtio/virtio_crypto_capabilities.h | 30 ++ drivers/crypto/virtio/virtio_cryptodev.c | 11 2 files changed, 41

[dpdk-dev] [PATCH v11 10/10] doc: add virtio crypto PMD guide

2018-04-17 Thread Jay Zhou
This patch adds the guide for virtio crypto PMD. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zhang --- MAINTAINERS | 2 + doc/guides/cryptodevs/features/virtio.ini | 26 +++ doc/guides/cryptodevs/index.rst | 1 + doc/guides/cryp

[dpdk-dev] [PATCH v11 09/10] test/crypto: add function tests for virtio crypto PMD

2018-04-17 Thread Jay Zhou
Only RTE_CRYPTO_CIPHER_AES_CBC cipher algorithm are tested as unit test, it is supported both by the cryptodev-backend-builtin and cryptodev-vhost-user of qemu side. Signed-off-by: Jay Zhou Reviewed-by: Fan Zhang Acked-by: Fan Zhang --- test/test/test_cryptodev.c | 48

Re: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported by linux kernel

2018-04-17 Thread Ferruh Yigit
On 4/16/2018 9:51 PM, Ajit Khaparde wrote: > From: Scott Branden > > Starting from Linux v3.16 pci_is_bridge() is in linux/pci.h, > in previous versions it is in drivers/pci/pci.h which is private header. > > Fix build error when calling pci_is_bridge by not calling/supporting > pci_is_bridge w

Re: [dpdk-dev] [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading

2018-04-17 Thread Ananyev, Konstantin
> -Original Message- > From: Dai, Wei > Sent: Tuesday, April 17, 2018 8:44 AM > To: Lu, Wenzhuo ; Ananyev, Konstantin > ; Yao, Lei A > Cc: dev@dpdk.org; Dai, Wei ; sta...@dpdk.org > Subject: [PATCH] net/ixgbe: fix missing suppport of multi-segs offloading > > This patch adds missing su

[dpdk-dev] [PATCH] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Yangchao Zhou
Fixes: cb97d93e9d3bb5607681085d20acaca1aa16deb1("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/librte_eal/linuxapp/ea

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-04-17 Thread Fan Zhang
Coverity issue: 272563 Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object") Signed-off-by: Fan Zhang --- v2: - using more generic strlcpy approach examples/ip_pipeline/swq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/swq.c b/example

Re: [dpdk-dev] [PATCH v2 4/4] ether: add packet modification aciton in flow API

2018-04-17 Thread Adrien Mazarguil
On Mon, Apr 16, 2018 at 03:03:39PM +, Zhang, Qi Z wrote: > > -Original Message- > > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > > Sent: Monday, April 16, 2018 9:31 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > > Sugesh ; Glynn, Michael J >

Re: [dpdk-dev] [PATCH] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 10:43 AM, Yangchao Zhou wrote: Fixes: cb97d93e9d3bb5607681085d20acaca1aa16deb1("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou --- Please use proper formatting for "fixes" line (refer to DPDK docs for correct way to generate it). Also, this fixes

[dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Fan Zhang
Coverity issue: 272572 Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") Signed-off-by: Fan Zhang --- v2: - use more generic strlcpy approach examples/ip_pipeline/action.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/action.c

Re: [dpdk-dev] [disscussion] A problem about dpdk backup-mode bond switching with mlx4 VF devices

2018-04-17 Thread Adrien Mazarguil
On Tue, Apr 17, 2018 at 06:40:20AM +, chenchanghu wrote: > > Hi, > When I used the mlx4 pmd, I meet a problem about mlx4 VF bond > switching which bond mod is backup-mode . The detail test is descripted below. > 1.Test environmemt infomation: > a. Linux distribution: CentOS > b.

[dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Yangchao Zhou
Coverity issue: 272585 Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou Acked-by: Anatoly Burakov --- lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/lib/

Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile

2018-04-17 Thread Thomas Monjalon
16/04/2018 16:08, Fan Zhang: > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") > > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled. > This patch fix this by adding checking to Makefile. > > Signed-off-by: Fan Zhang Applied with title "vhost/crypto: fix build without crypto

Re: [dpdk-dev] [PATCH] malloc: fix not unlocking hotplug on fail to init

2018-04-17 Thread Thomas Monjalon
13/04/2018 17:58, Anatoly Burakov: > We lock the hotplug during init, but do not unlock it if we couldn't > register multiprocess callbacks. Add the missing unlock. > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > Cc: anatoly.bura...@intel.com > > Signed-off-by: Anatoly B

Re: [dpdk-dev] [PATCH v4 04/11] mempool: add op to calculate memory size to be allocated

2018-04-17 Thread Burakov, Anatoly
On 16-Apr-18 2:24 PM, Andrew Rybchenko wrote: Size of memory chunk required to populate mempool objects depends on how objects are stored in the memory. Different mempool drivers may have different requirements and a new operation allows to calculate memory size in accordance with driver requirem

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Thomas Monjalon
17/04/2018 12:06, Yangchao Zhou: > Coverity issue: 272585 > Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") > > Signed-off-by: Yangchao Zhou > Acked-by: Anatoly Burakov Better to provide a small explanation. > - retval = strdup(splitst

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 11:24 AM, Thomas Monjalon wrote: 17/04/2018 12:06, Yangchao Zhou: Coverity issue: 272585 Fixes: cb97d93e9d3b ("mem: share hugepage info primary and secondary") Signed-off-by: Yangchao Zhou Acked-by: Anatoly Burakov Better to provide a small explanation. -

Re: [dpdk-dev] [PATCH v2 4/4] ether: add packet modification aciton in flow API

2018-04-17 Thread Zhang, Qi Z
> -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, April 17, 2018 5:55 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Doherty, Declan ; Chandran, > Sugesh ; Glynn, Michael J > ; Liu, Yu Y ; Ananyev, > Konstantin ; Richardson, Bruce > > Subject:

[dpdk-dev] [PATCH v1] crypto/ccp: use contiguous allocation for DMA memory

2018-04-17 Thread Ravi Kumar
rte_eal_get_physmem_layout() is obsolete now. This patch fix the broken API usage and allocates DMA memory with RTE_MEMZONE_IOVA_CONTIG memzone flag. Signed-off-by: Ravi Kumar --- drivers/crypto/ccp/ccp_dev.c | 45 +++- 1 file changed, 19 insertions(+), 26

Re: [dpdk-dev] [PATCH v1] crypto/ccp: use contiguous allocation for DMA memory

2018-04-17 Thread Burakov, Anatoly
On 17-Apr-18 11:32 AM, Ravi Kumar wrote: rte_eal_get_physmem_layout() is obsolete now. This patch fix the broken API usage and allocates DMA memory with RTE_MEMZONE_IOVA_CONTIG memzone flag. Signed-off-by: Ravi Kumar --- FWIW, Reviewed-by: Anatoly Burakov -- Thanks, Anatoly

Re: [dpdk-dev] [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME offload

2018-04-17 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Yanglong > Sent: Tuesday, April 17, 2018 3:29 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Dai, Wei ; Yao, > Lei A ; Wu, Yanglong > Subject: [PATCH] net/i40e: fix I40e start failing for missing JUMBO_FRAME > offload > > JUMBO_FRAME offload should be set as

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-17 Thread Matan Azrad
Hi Konstantin From: Ananyev, Konstantin, Tuesday, April 17, 2018 12:23 PM > To: Matan Azrad ; Richardson, Bruce > > Cc: Burakov, Anatoly ; Thomas Monjalon > ; dev@dpdk.org; pmati...@redhat.com; > david.march...@6wind.com; Guo, Jia ; > step...@networkplumber.org; f...@redhat.com > Subject: RE: ke

[dpdk-dev] [PATCH] net/pcap: physical interface MAC support

2018-04-17 Thread Juhamatti Kuusisaari
Support for PCAP MAC address using physical interface MAC. Support for getting proper link status, speed and duplex. Signed-off-by: Juhamatti Kuusisaari --- config/common_base | 1 + drivers/net/pcap/rte_eth_pcap.c | 52 - 2 files changed, 52

Re: [dpdk-dev] [PATCH v3 1/5] net/ixgbevf: set the inter-interrupt interval for EITR.

2018-04-17 Thread Ferruh Yigit
On 3/22/2018 1:01 PM, xiangxia.m@gmail.com wrote: > From: Tonghao Zhang > > Set EITR interval as default. This patch can improve the > performance when we enable the rx-intrrupt to process the > packets because we hope rx-intrrupt reduce CPU. For example, > the 200us value of EITR makes the p

Re: [dpdk-dev] kernel binding of devices + hotplug

2018-04-17 Thread Ananyev, Konstantin
Hi Matan, > > > Hi Konstantin > > From: Ananyev, Konstantin, Tuesday, April 17, 2018 12:23 PM > > To: Matan Azrad ; Richardson, Bruce > > > > Cc: Burakov, Anatoly ; Thomas Monjalon > > ; dev@dpdk.org; pmati...@redhat.com; > > david.march...@6wind.com; Guo, Jia ; > > step...@networkplumber.org;

Re: [dpdk-dev] [PATCH v9 0/5] add ifcvf vdpa driver

2018-04-17 Thread Ferruh Yigit
On 4/17/2018 8:06 AM, Xiao Wang wrote: > IFCVF driver > > The IFCVF vDPA (vhost data path acceleration) driver provides support for the > Intel FPGA 100G VF (IFCVF). IFCVF's datapath is virtio ring compatible, it > works as a HW vhost backend which can send/receive packets to/from virt

Re: [dpdk-dev] [PATCH v3 2/2] eal: fix signed integers in fbarray

2018-04-17 Thread Burakov, Anatoly
On 14-Apr-18 11:03 AM, Burakov, Anatoly wrote: On 13-Apr-18 7:43 PM, Adrien Mazarguil wrote: While debugging startup issues encountered with Clang (see "eal: fix undefined behavior in fbarray"), I noticed that fbarray stores indices, sizes and masks on signed integers involved in bitwise operati

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread zhouyangchao
As Burakov said, for no other reason, I just followed the old version. On Tue, Apr 17, 2018 at 6:31 PM Burakov, Anatoly wrote: > On 17-Apr-18 11:24 AM, Thomas Monjalon wrote: > > 17/04/2018 12:06, Yangchao Zhou: > >> Coverity issue: 272585 > >> Fixes: cb97d93e9d3b ("mem: share hugepage info prim

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 10:52:52AM +0100, Fan Zhang wrote: > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > Signed-off-by: Fan Zhang > --- > v2: > - use more generic strlcpy approach > > examples/ip_pipeline/action.c | 4 +++- > 1 file chan

Re: [dpdk-dev] whether DPDK support FreeBSD Guest OS VM on Xen hypervisor.

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 05:06:38AM +, Zhongliang Shu wrote: > Hi, Guys: > > I have found the DPDK Xen Guideline and there have example and steps > > About how DPDK supporting Linux Guest OS VM on Xen Hypervisor. > > But I cannot find similar document  about FreeBSD Guest OS VM on Xen > Hype

Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated.

2018-04-17 Thread Bruce Richardson
On Tue, Apr 17, 2018 at 10:45:46AM +0100, Fan Zhang wrote: > Coverity issue: 272563 > Fixes: 8245472c58c8 ("examples/ip_pipeline: add sw queue object") > > Signed-off-by: Fan Zhang > --- Acked-by: Bruce Richardson

Re: [dpdk-dev] [PATCH v2] ethdev: remove new to old offloads API helpers

2018-04-17 Thread Ferruh Yigit
On 4/17/2018 9:33 AM, Shahaf Shuler wrote: > According to > > commit 315ee8374e0e ("doc: reduce initial offload API rework scope >to drivers") > > All PMDs should have moved to the new offloads API. Therefore it is safe > to remove the new->old convert helps. > > The old->new

Re: [dpdk-dev] [PATCH] drivers/net: update link status

2018-04-17 Thread Ferruh Yigit
On 4/17/2018 5:54 AM, Tiwei Bie wrote: > On Mon, Apr 16, 2018 at 05:10:24PM +0100, Ferruh Yigit wrote: >> On 4/14/2018 11:55 AM, Tiwei Bie wrote: >>> On Fri, Apr 13, 2018 at 10:53:55PM +0100, Ferruh Yigit wrote: On 4/10/2018 4:41 PM, Tiwei Bie wrote: > On Tue, Mar 13, 2018 at 06:05:34PM +0

[dpdk-dev] [PATCH v3] drivers/net: update link status

2018-04-17 Thread Ferruh Yigit
Update link status related feature document items and minor updates in some link status related functions. Signed-off-by: Ferruh Yigit Acked-by: Adrien Mazarguil --- Cc: Nélio Laranjeiro Cc: Tiwei Bie Cc: Qi Z Zhang v2: * update virtio.ini (Tiwei) * update i40e_vf_vec.ini (Qi) * update avf.i

Re: [dpdk-dev] [PATCH v2] mem: memory leaks of hubedir caused by strdup

2018-04-17 Thread Thomas Monjalon
I see no reason to accept this patch, replacing strdup by snprintf, given that we have strlcpy. Please do a v3 with strlcpy. 17/04/2018 13:16, zhouyangchao: > As Burakov said, for no other reason, I just followed the old version. > > On Tue, Apr 17, 2018 at 6:31 PM Burakov, Anatoly > wrote: > >

Re: [dpdk-dev] [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification

2018-04-17 Thread Xueming(Steven) Li
> -Original Message- > From: Nélio Laranjeiro > Sent: Tuesday, April 17, 2018 3:20 PM > To: Xueming(Steven) Li > Cc: Adrien Mazarguil ; Shahaf Shuler > ; dev@dpdk.org; > Olivier Matz > Subject: Re: [PATCH v3 04/14] net/mlx5: support Rx tunnel type identification > > On Tue, Apr 17, 2

Re: [dpdk-dev] [PATCH v2] ethdev: remove new to old offloads API helpers

2018-04-17 Thread Thomas Monjalon
17/04/2018 13:23, Ferruh Yigit: > On 4/17/2018 9:33 AM, Shahaf Shuler wrote: > > According to > > > > commit 315ee8374e0e ("doc: reduce initial offload API rework scope > > to drivers") > > > > All PMDs should have moved to the new offloads API. Therefore it is safe > > to remove

[dpdk-dev] [PATCH] eal/linux: use strlcpy in uevent parsing

2018-04-17 Thread Thomas Monjalon
Support of strlcpy has recently been added to DPDK. This replacement has been generated by the coccinelle script: devtools/cocci.sh devtools/cocci/strlcpy.cocci Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Cc: jia@intel.com Signed-off-by: Thomas Monjalon --- lib/

Re: [dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

2018-04-17 Thread Maxime Coquelin
Hi Hemant On 03/29/2018 01:48 PM, Rybalchenko, Kirill wrote: Hello Hemant, I found that a number of patches submitted for 18.05 release fail in compilation: Failed Build #1: OS: CentOS7_64 Target: x86_64-native-linuxapp-clang In file included from /home/patchWorkOrg/compilation/drivers/bus/fs

Re: [dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

2018-04-17 Thread Hemant Agrawal
I missed it. We will check it asap. Sent from my Android phone using TouchDown (www.symantec.com) -Original Message- From: Maxime Coquelin [maxime.coque...@redhat.com] Received: Tuesday, 17 Apr 2018, 5:43PM To: Rybalchenko, Kirill [kirill.rybalche...@intel.com]; Hemant Agrawal [hemant.ag

[dpdk-dev] [PATCH v2] eal/linux: use strlcpy in uevent parsing

2018-04-17 Thread Thomas Monjalon
Support of strlcpy has recently been added to DPDK. This replacement has been generated by the coccinelle script: devtools/cocci.sh devtools/cocci/strlcpy.cocci Fixes: 0d0f478d0483 ("eal/linux: add uevent parse and process") Signed-off-by: Thomas Monjalon --- v2: add missing include ---

Re: [dpdk-dev] [PATCH v3 2/2] eal: fix signed integers in fbarray

2018-04-17 Thread Thomas Monjalon
17/04/2018 13:14, Burakov, Anatoly: > On 14-Apr-18 11:03 AM, Burakov, Anatoly wrote: > > On 13-Apr-18 7:43 PM, Adrien Mazarguil wrote: > >> While debugging startup issues encountered with Clang (see "eal: fix > >> undefined behavior in fbarray"), I noticed that fbarray stores indices, > >> sizes an

[dpdk-dev] [PATCH v2 2/2] net/pcap: physical interface MAC support

2018-04-17 Thread Juhamatti Kuusisaari
Support for PCAP MAC address using physical interface MAC. Support for getting proper link status, speed and duplex. Signed-off-by: Juhamatti Kuusisaari --- v2: * Fix whitespace --- drivers/net/pcap/rte_eth_pcap.c | 39 ++- 1 file changed, 26 insertions(+),

[dpdk-dev] [PATCH v2 1/2] net/pcap: physical interface MAC support

2018-04-17 Thread Juhamatti Kuusisaari
Support for PCAP MAC address using physical interface MAC. Support for getting proper link status, speed and duplex. Signed-off-by: Juhamatti Kuusisaari --- config/common_base | 1 + drivers/net/pcap/rte_eth_pcap.c | 52 - 2 files changed, 52

Re: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported by linux kernel

2018-04-17 Thread Iremonger, Bernard
Hi Scott, Ajit, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ajit Khaparde > Sent: Monday, April 16, 2018 9:51 PM > To: dev@dpdk.org > Cc: Scott Branden > Subject: [dpdk-dev] [PATCH] igb_uio: only check for pci bridge in supported by > linux kernel > > From

Re: [dpdk-dev] [PATCH v1] crypto/ccp: use contiguous allocation for DMA memory

2018-04-17 Thread De Lara Guarch, Pablo
> -Original Message- > From: Ravi Kumar [mailto:ravi1.ku...@amd.com] > Sent: Tuesday, April 17, 2018 11:32 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; > hemant.agra...@nxp.com > Subject: [PATCH v1] crypto/ccp: use contiguous allocation for DMA memory > > rte_eal_get_physmem_layou

[dpdk-dev] [PATCH v3] doc: announce ethdev CRC strip flag deprecation

2018-04-17 Thread Ferruh Yigit
Make CRC stripping default behavior, deprecate flag DEV_RX_OFFLOAD_CRC_STRIP. Signed-off-by: Ferruh Yigit --- v2: * Make CRC behavior active in this release v3: * Distribute switch into next two releases for more smooth transition v18.08: add new flag to keep crc, and implement this in PMDs

[dpdk-dev] [PATCH] eventdev: fix icc build

2018-04-17 Thread Pablo de Lara
ICC complains about variable being used before its value is set. Since the variable is only assigned in the for loop, its declaration is moved inside and is initialized. lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592: variable "ret" is used before its value is set RTE_SET_U

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Jasvinder Singh
The destination string may not have a null termination if the source string's length is equal to the sizeof(tap->name). Fix by replacing strncpy with strlcpy that guarantees NULL-termination. Coverty issue: 272603 Fixes: 2f74ae28e23f ("examples/ip_pipeline: add tap object") Signed-off-by: Jasvin

Re: [dpdk-dev] [PATCH] eal: force gcc to inline rte_movX function

2018-04-17 Thread Thomas Monjalon
12/04/2018 07:16, Junjie Chen: > From: "Chen, Junjie" > > Sometimes gcc does not inline the function despite keyword *inline*, > we obeserve rte_movX is not inline when doing performance profiling, > so use *always_inline* keyword to force gcc to inline the function. > > Signed-off-by: Chen, Jun

Re: [dpdk-dev] [PATCH] eventdev: fix icc build

2018-04-17 Thread Ferruh Yigit
On 4/17/2018 2:13 PM, Pablo de Lara wrote: > ICC complains about variable being used before its value is set. > Since the variable is only assigned in the for loop, > its declaration is moved inside and is initialized. > > lib/librte_eventdev/rte_event_timer_adapter.c(708): error #592: > variable

[dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated

2018-04-17 Thread Jasvinder Singh
The destination string may not have a null termination if the source string's length is equal to the sizeof(pipeline->name). Fix by replacing strncpy with strlcpy that guarantees NULL-termination. Coverty issue: 272606 Fixes: d75c371e9b46 ("examples/ip_pipeline: add pipeline object") Signed-off-

Re: [dpdk-dev] [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable

2018-04-17 Thread Zhang, Qi Z
Hi Rosen: > -Original Message- > From: Xu, Rosen > Sent: Tuesday, April 17, 2018 11:03 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Helin > ; Zhang, Qi Z ; Wu, Jingjing > > Subject: [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at > device disable > > v3 updates: > ==

  1   2   3   >