Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-03 Thread Asaf Sinai
Additional questions: Is it possible to use MLNX_OFED-4.3 on Ubuntu 12.04? Why is the driver related to OS version? -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Asaf Sinai Sent: Monday, July 2, 2018 05:22 PM To: Shahaf Shuler Cc: dev@dpdk.org; Nitin Katiyar ; Né

Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues

2018-07-03 Thread Nélio Laranjeiro
On Mon, Jul 02, 2018 at 06:07:03PM -0700, Yongseok Koh wrote: > On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: > > Drop queues are essentially used in flows due to Verbs API, the > > information if the fate of the flow is a drop or not is already present > > in the flow. Due to

Re: [dpdk-dev] [PATCH v3] crypto/scheduler: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Hari Kumar > Sent: Friday, June 29, 2018 3:01 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Vemula, Hari KumarX > > Subject: [dpdk-dev] [PATCH v3] crypto/scheduler: add dynamic logging >

Re: [dpdk-dev] [PATCH v2] crypto/null: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Jananee Parthasarathy > Sent: Friday, June 29, 2018 1:29 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Poornima, PallantlaX > > Subject: [dpdk-dev] [PATCH v2] crypto/null: add dynamic loggi

Re: [dpdk-dev] [PATCH v2] crypto/openssl: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Somarowthu, Naga SureshX > Sent: Friday, June 29, 2018 1:51 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [PATCH v2] crypto/openssl: add dynamic logging > > 1.added new logtype for openssl driver.

Re: [dpdk-dev] [PATCH v2] crypto/aesni_mb: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Somarowthu, Naga SureshX > Sent: Friday, June 29, 2018 10:55 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [PATCH v2] crypto/aesni_mb: add dynamic logging > > 1.added new logtype for aesni_mb drive

Re: [dpdk-dev] [PATCH v2] crypto/kasumi: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Somarowthu, Naga SureshX > Sent: Friday, June 29, 2018 10:48 AM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Somarowthu, Naga SureshX > > Subject: [PATCH v2] crypto/kasumi: add dynamic logging > > 1.added new logtype for kasumi driver. >

Re: [dpdk-dev] [PATCH v2] crypto/zuc: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, June 28, 2018 4:00 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH v2] crypto/zuc: add dynamic logging > > From: Agalya Babu RadhaKrishnan > >

Re: [dpdk-dev] [PATCH v2] crypto/aesni_gcm: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Somarowthu, Naga SureshX > Sent: Thursday, June 28, 2018 3:47 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Chaitanya Babu, TalluriX > > Subject: [PATCH v2] crypto/aesni_gcm: add dynamic logging > > From: Chaitanya Babu Talluri > > 1

Re: [dpdk-dev] [PATCH v2] crypto/zuc: add dynamic logging

2018-07-03 Thread De Lara Guarch, Pablo
> -Original Message- > From: Parthasarathy, JananeeX M > Sent: Thursday, June 28, 2018 4:00 PM > To: dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Pattan, Reshma > ; Babu Radhakrishnan, AgalyaX > > Subject: [PATCH v2] crypto/zuc: add dynamic logging > > From: Agalya Babu RadhaKrishnan >

[dpdk-dev] [PATCH v1] examples/multi_process: add l2fwd_fork to Makefile

2018-07-03 Thread Emma Kenny
l2fwd_fork is not complied by default, this will make it compile Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") Signed-off-by: Emma Kenny --- examples/multi_process/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makef

[dpdk-dev] [PATCH] test/compress: add scatter-gather tests

2018-07-03 Thread Pablo de Lara
Added Scatter-Gather test, which split input data into multi-segment mbufs and compresses/decompresses the data into also a multi-segment mbuf. Signed-off-by: Pablo de Lara --- test/test/test_compressdev.c | 390 ++- 1 file changed, 351 insertions(+), 39 d

Re: [dpdk-dev] [PATCH 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-03 Thread Burakov, Anatoly
On 02-Jul-18 6:26 PM, Alejandro Lucero wrote: A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if thi

Re: [dpdk-dev] [PATCH 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-03 Thread Burakov, Anatoly
On 02-Jul-18 6:27 PM, Alejandro Lucero wrote: Although VT-d emulation currently only supports 39 bits, it could be iovas being within that supported range. This patch allows IOVA mode in such a case. Indeed, memory initialization code can be modified for using lower virtual addresses than those

Re: [dpdk-dev] [PATCH 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Burakov, Anatoly
On 02-Jul-18 6:27 PM, Alejandro Lucero wrote: Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address

Re: [dpdk-dev] [PATCH v8 01/19] ethdev: add function to release port in local process

2018-07-03 Thread Thomas Monjalon
Hi, 02/07/2018 07:44, Qi Zhang: > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -70,6 +70,19 @@ int rte_eth_dev_release_port(struct rte_eth_dev *eth_dev); > > /** > * @internal > + * Release the specified ethdev port in local process, only set

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Thomas Monjalon
Hi Qi, Sorry I do not understand neither the commit log, nor the doxygen. If it can help, consider your reader is in a bad mood and needs a pleasant description. 02/07/2018 07:44, Qi Zhang: > Introduce new API rte_eal_register_mp_init that help to register > a callback function which will be invo

Re: [dpdk-dev] [PATCH V4 8/9] app/testpmd: show example to handle hot unplug

2018-07-03 Thread Guo, Jia
mantan, On 7/1/2018 3:46 PM, Matan Azrad wrote: Hi Jeff A good advance, thank you, but as I said in previous version, this patch inserts a bug and the next one fixes it. Patch 9 should be before patch 8 while this patch just add 1 more option for EAL hotplug. i agree that patch 9 before pa

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
Hi, 02/07/2018 07:44, Qi Zhang: > --- /dev/null > +++ b/lib/librte_ethdev/ethdev_mp.h > @@ -0,0 +1,41 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2018 Intel Corporation > + */ > + > +#ifndef _RTE_ETHDEV_MP_H_ > +#define _RTE_ETHDEV_MP_H_ > + > +#define MAX_DEV_ARGS_LEN 0x80 >

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Thomas Monjalon
02/07/2018 07:44, Qi Zhang: > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > application lock or unlock on specific ethdev, a locked device > can't be detached, this help applicaiton to prevent unexpected > device detaching, especially in multi-process envrionment. Trying to unders

Re: [dpdk-dev] [PATCH 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-03 Thread Alejandro Lucero
On Tue, Jul 3, 2018 at 10:07 AM, Burakov, Anatoly wrote: > On 02-Jul-18 6:26 PM, Alejandro Lucero wrote: > >> A device can suffer addressing limitations. This functions checks >> memsegs have iovas within the supported range based on dma mask. >> >> PMD should use this during initialization if su

Re: [dpdk-dev] [PATCH 6/7] examples/kni: fix dependency check for building with meson

2018-07-03 Thread Bruce Richardson
On Tue, Jul 03, 2018 at 12:47:18AM +0100, Ferruh Yigit wrote: > On 6/8/2018 5:38 PM, Bruce Richardson wrote: > > Rather than hard-coding the example app to be built only when a set of > > conditions are met, we can simplify things by having the app built when > > KNI library itself is available. Th

Re: [dpdk-dev] [PATCH 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-03 Thread Alejandro Lucero
On Tue, Jul 3, 2018 at 10:10 AM, Burakov, Anatoly wrote: > On 02-Jul-18 6:27 PM, Alejandro Lucero wrote: > >> Although VT-d emulation currently only supports 39 bits, it could >> be iovas being within that supported range. This patch allows >> IOVA mode in such a case. >> >> Indeed, memory initia

[dpdk-dev] [PATCH v2 0/8] Enable 32-bit native builds with meson

2018-07-03 Thread Bruce Richardson
This patchset enables building DPDK on 32-bit systems, and has been tested using debian 32-bit on x86 i.e. doing an "i686" build in the old build system. v2: - fixed LIB_LIBRTE_KNI to RTE_LIBRTE_KNI in examples/kni patch [Ferruh] - added patch to make same change in drivers/net/kni [Ferruh] Bru

[dpdk-dev] [PATCH v2 2/8] bpf: fix 32-bit build support with meson

2018-07-03 Thread Bruce Richardson
The JIT is only supported on x86_64 so disable for 32-bit builds. Fixes: cc752e43e079 ("bpf: add JIT compilation for x86_64 ISA") Signed-off-by: Bruce Richardson Acked-by: Konstantin Ananyev Series-acked-by: Hemant Agrawal --- lib/librte_bpf/meson.build | 2 +- 1 file changed, 1 insertion(+),

[dpdk-dev] [PATCH v2 3/8] net/sfc: disable for 32-bit builds

2018-07-03 Thread Bruce Richardson
The sfc driver is not supported on 32-bit so disable in meson in those cases. Signed-off-by: Bruce Richardson Acked-by: Andrew Rybchenko Series-acked-by: Hemant Agrawal --- drivers/net/sfc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/meson.bui

[dpdk-dev] [PATCH v2 4/8] build: disable pointer to int conversion warnings for 32-bit

2018-07-03 Thread Bruce Richardson
Converting a 32-bit pointer to a 64-bit integer is generally safe, but generates a lot of warnings when compiling 32-bit code with meson. The warnings are not flagged when using make, so just disable them for 32-bit meson builds. Signed-off-by: Bruce Richardson Acked-by: Hemant Agrawal Series-ac

[dpdk-dev] [PATCH v2 1/8] kni: disable for 32-bit meson builds

2018-07-03 Thread Bruce Richardson
The kni library is not supported on 32-bit so disable it for those builds using meson. Signed-off-by: Bruce Richardson Acked-by: Ferruh Yigit Series-acked-by: Hemant Agrawal --- lib/librte_kni/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_kni/meson.

[dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson

2018-07-03 Thread Bruce Richardson
Rather than hard-coding the example app to be built only when a set of conditions are met, we can simplify things by having the app built when KNI library itself is available. That saves us duplicating the same set of restrictions on both library and example app. Fixes: 89f0711f9ddf ("examples: bu

[dpdk-dev] [PATCH v2 7/8] net/avp: fix 32-bit meson builds

2018-07-03 Thread Bruce Richardson
When compiling with meson, extra warnings are enabled about casting from integers to different size pointers. This triggers an error in AVP as the addition of the offset to the pointer address causes the result to be a 64-bit integer which doesn't fit a 32-bit pointer. The fix here is to explicitly

[dpdk-dev] [PATCH v2 5/8] dpaa2: fix default IOVA build setting for meson builds

2018-07-03 Thread Bruce Richardson
By default, the DPAA2_USE_PHYS_IOVA setting with the make build-system is "y", which is overridden to "n" in the config file specifically for the arm64-dpaa2-linuxapp-gcc builds. The lack of this setting in meson builds causes issues for 32-bit build, as the alternative code paths have compiler war

[dpdk-dev] [PATCH v2 8/8] net/kni: fix check for meson build

2018-07-03 Thread Bruce Richardson
The configuration value indicating that KNI was build was incorrect, causing the driver to never be built. Fixes: 3479586fe636 ("net/kni: add to meson build") Signed-off-by: Bruce Richardson Series-acked-by: Hemant Agrawal --- drivers/net/kni/meson.build | 2 +- 1 file changed, 1 insertion(+),

Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx and Tx

2018-07-03 Thread Ferruh Yigit
On 7/3/2018 2:36 AM, Liu, Yong wrote: > > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Tuesday, July 03, 2018 12:57 AM >> To: Maxime Coquelin ; Liu, Yong >> ; Bie, Tiwei >> Cc: Wang, Zhihong ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v5 7/9] net/virtio: support in-order Rx

Re: [dpdk-dev] [PATCH 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Alejandro Lucero
On Tue, Jul 3, 2018 at 10:17 AM, Burakov, Anatoly wrote: > On 02-Jul-18 6:27 PM, Alejandro Lucero wrote: > >> Linux kernel uses a really high address as starting address for >> serving mmaps calls. If there exists addressing limitations and >> IOVA mode is VA, this starting address is likely too

Re: [dpdk-dev] [PATCH 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 11:44 AM, Alejandro Lucero wrote: +               addr = mmap(addr_hint,                                 (*size) + hugepage_sz, PROT_READ,   #ifdef RTE_ARCH_PPC_64                                 MAP_PRIVATE | MAP_ANONYMOUS | MAP_HUGETLB,

Re: [dpdk-dev] Compilation of MLX5 driver

2018-07-03 Thread Shahaf Shuler
Tuesday, July 3, 2018 10:01 AM, Asaf Sinai: > Subject: Re: [dpdk-dev] Compilation of MLX5 driver > > Additional questions: > Is it possible to use MLNX_OFED-4.3 on Ubuntu 12.04? I am not sure if there is such build, the oldest OFED build I see is for ubuntu14.10. ubuntu12.04 is really old. > Wh

Re: [dpdk-dev] [PATCH V4 5/9] bus: add helper to handle sigbus

2018-07-03 Thread Guo, Jia
hi, gaetan and konstantin answer both of your questions here as below. On 6/29/2018 8:52 PM, Gaëtan Rivet wrote: On Fri, Jun 29, 2018 at 12:21:39PM +, Ananyev, Konstantin wrote: -Original Message- From: Guo, Jia Sent: Friday, June 29, 2018 12:23 PM To: Ananyev, Konstantin ; step

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems

2018-07-03 Thread Shahaf Shuler
Tuesday, July 3, 2018 12:00 AM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for 32bit systems > > > > On Jul 2, 2018, at 4:11 AM, Moti Haimovsky wrote: > > > > This patch adds support for building and running mlx5 PMD on 32bit > > systems such as i686. > > > > The ma

[dpdk-dev] [PATCH v2 5/6] net/nfp: check hugepages IOVAs based on DMA mask

2018-07-03 Thread Alejandro Lucero
NFP devices can not handle DMA addresses requiring more than 40 bits. This patch uses rte_dev_check_dma_mask with 40 bits and avoids device initialization if memory out of NFP range. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 8 1 file changed, 8 insertions(+) diff

[dpdk-dev] [PATCH v2 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Alejandro Lucero
Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address in the process virtual address space as with 64

[dpdk-dev] [PATCH v2 2/6] ethdev: add function for checking IOVAs by a device

2018-07-03 Thread Alejandro Lucero
A PMD should invoke this function for checking memsegs iovas are within the supported range by the device. Signed-off-by: Alejandro Lucero --- lib/librte_ether/rte_ethdev.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_eth

[dpdk-dev] [PATCH v2 0/6] use IOVAs check based on DMA mask

2018-07-03 Thread Alejandro Lucero
This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs can abort initialization. For the VT-d case, IOVA

Re: [dpdk-dev] [PATCH v2 6/8] examples/kni: fix dependency check for building with meson

2018-07-03 Thread Ferruh Yigit
On 7/3/2018 11:31 AM, Bruce Richardson wrote: > Rather than hard-coding the example app to be built only when a set of > conditions are met, we can simplify things by having the app built when > KNI library itself is available. That saves us duplicating the same set > of restrictions on both librar

[dpdk-dev] [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-03 Thread Alejandro Lucero
A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if this function returns memsegs out of range. Anothe

[dpdk-dev] [PATCH v2 3/6] bus/pci: use IOVAs check when setting IOVA mode

2018-07-03 Thread Alejandro Lucero
Although VT-d emulation currently only supports 39 bits, it could be iovas being within that supported range. This patch allows IOVA mode in such a case. Indeed, memory initialization code can be modified for using lower virtual addresses than those used by the kernel for 64 bits processes by defa

[dpdk-dev] [PATCH v2 6/6] net/nfp: support IOVA VA mode

2018-07-03 Thread Alejandro Lucero
NFP can handle IOVA as VA. It requires to check those IOVAs being in the supported range what is done during initialization. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers

Re: [dpdk-dev] [PATCH v2 8/8] net/kni: fix check for meson build

2018-07-03 Thread Ferruh Yigit
On 7/3/2018 11:31 AM, Bruce Richardson wrote: > The configuration value indicating that KNI was build was incorrect, > causing the driver to never be built. > > Fixes: 3479586fe636 ("net/kni: add to meson build") > > Signed-off-by: Bruce Richardson > Series-acked-by: Hemant Agrawal Acked-by: F

Re: [dpdk-dev] [PATCH v1] examples/multi_process: fix build error

2018-07-03 Thread Shahaf Shuler
Monday, July 2, 2018 6:40 PM, Emma Kenny: > Subject: [PATCH v1] examples/multi_process: fix build error > > Fix bug with undeclared variable name and calling a variable that is not > member of struct. > > CC main.o > l2fwd_fork/main.c: In function ‘main’: l2fwd_fork/main.c:1043:33: > error: ‘de

Re: [dpdk-dev] [PATCH V4 7/9] igb_uio: fix uio release issue when hot unplug

2018-07-03 Thread Ferruh Yigit
On 6/29/2018 11:30 AM, Jeff Guo wrote: > When hot unplug device, the kernel will release the device resource in the > kernel side, such as the fd sys file will disappear, and the irq will be > released. At this time, if igb uio driver still try to release this > resource, it will cause kernel crash

Re: [dpdk-dev] [PATCH v2 5/5] ethdev: remove old offload API

2018-07-03 Thread Shahaf Shuler
Tuesday, July 3, 2018 12:28 AM, Thomas Monjalon: > Subject: [PATCH v2 5/5] ethdev: remove old offload API > > From: Ferruh Yigit > > In DPDK 17.11, the ethdev offloads API has changed: > commit cba7f53b717d ("ethdev: introduce Tx queue offloads API") > commit ce17eddefc20 ("ethdev: i

Re: [dpdk-dev] [PATCH v2] crypto/virtio: fix iv physical address

2018-07-03 Thread Zhoujian (jay)
> -Original Message- > From: Fan Zhang [mailto:roy.fan.zh...@intel.com] > Sent: Tuesday, June 26, 2018 10:11 AM > To: dev@dpdk.org > Cc: pablo.de.lara.gua...@intel.com; Zhoujian (jay) ; > sta...@dpdk.org > Subject: [PATCH v2] crypto/virtio: fix iv physical address > > The physical address

Re: [dpdk-dev] [PATCH v2 0/6] use IOVAs check based on DMA mask

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: This patchset adds, mainly, a check for ensuring IOVAs are within a restricted range due to addressing limitations with some devices. There are two known cases: NFP and IOMMU VT-d emulation. With this check IOVAs out of range are detected and PMDs ca

Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on removal

2018-07-03 Thread Shahaf Shuler
Monday, July 2, 2018 9:58 PM, Yongseok Koh: > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: activate Verbs cleanup on > removal > > > > On Jul 1, 2018, at 10:13 PM, Matan Azrad wrote: > > > > Starting from rdma-core v19, Mellanox OFED 4.4, the Verbs resources > > cleanup is properly activated in plu

Re: [dpdk-dev] [PATCH v2 4/6] mem: use address hint for mapping hugepages

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: Linux kernel uses a really high address as starting address for serving mmaps calls. If there exists addressing limitations and IOVA mode is VA, this starting address is likely too high for those devices. However, it is possible to use a lower address

Re: [dpdk-dev] [PATCH v2 1/6] mem: add function for checking memsegs IOVAs addresses

2018-07-03 Thread Burakov, Anatoly
On 03-Jul-18 1:09 PM, Alejandro Lucero wrote: A device can suffer addressing limitations. This functions checks memsegs have iovas within the supported range based on dma mask. PMD should use this during initialization if supported devices suffer addressing limitations, returning an error if thi

[dpdk-dev] [PATCH] crypto/snow3g: add dynamic logging

2018-07-03 Thread Pablo de Lara
Registered new dynamic logtype for driver and replaced SNOW3G_LOG_ERR and CDEV_LOG_ERR with the new SNOW3G_LOG macro, which uses the new logtype. Signed-off-by: Pablo de Lara --- drivers/crypto/snow3g/rte_snow3g_pmd.c | 25 ++- drivers/crypto/snow3g/rte_snow3g_pmd_ops

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
Hi Thomas: <...> > > +enum eth_dev_req_type { > > + REQ_TYPE_ATTACH, > > + REQ_TYPE_PRE_DETACH, > > + REQ_TYPE_DETACH, > > + REQ_TYPE_ATTACH_ROLLBACK, > > +}; > > These constants are missing an ethdev prefix. OK, will fix. > > > + > > +struct eth_dev_mp_req { > > + enum eth_dev_req_t

[dpdk-dev] [PATCH] ethdev: change vtune profiling approach

2018-07-03 Thread ilia . kurakin
From: Ilia Kurakin The patch changes rx_burst profiling approach: 1. VTune's instrumentation is removed 2. empty hook callback for profiling is added This way all VTune-specific logic moves to the VTune side. Hook is enabled only when CONFIG_RTE_ETHDEV_PROFILE_WITH_VTUNE option is

Re: [dpdk-dev] [PATCH 01/20] eventdev: add files for eventmode helper

2018-07-03 Thread Joseph, Anoob
Hi Sunil, Please see inline. Thanks, Anoob On 03-07-2018 11:57, Sunil Kumar Kori wrote: External Email Hello Anoob, Regards Sunil Kumar -Original Message- From: Joseph, Anoob [mailto:anoob.jos...@caviumnetworks.com] Sent: Thursday, June 28, 2018 4:13 PM To: Sunil Kumar Kori ; Bru

Re: [dpdk-dev] [PATCH v1 00/15] preparing l2fwd for eventmode additions

2018-07-03 Thread Joseph, Anoob
Hi, Gentle reminder! Thanks, Anoob On 19-06-2018 19:37, Anoob Joseph wrote: External Email Hi Bruce, Thanks for the feedback. Please see inline. + Hemant, Nikhil, Sunil, Gage, Harry, Narender, Pavan, Thomas, Akhil On 19/06/18 15:39, Bruce Richardson wrote: On Tue, Jun 19, 2018 at 03:34

Re: [dpdk-dev] [RFC 0/3] ethdev: add IP address and TCP/UDP port rewrite actions to flow API

2018-07-03 Thread Rahul Lakkireddy
On Tuesday, July 07/03/18, 2018 at 07:57:55 +0530, Jack Min wrote: > Hey Rahul, > > Thank you, those two are the ways to achieve that. > > Personally I prefer the option 1 but with a little bit difference, something > like: > > struct rte_flow_action_of_set_nw_ipv4 { > uint32_t ipv

[dpdk-dev] [PATCH] crypto/aesni_mb: call buffer manager allocation

2018-07-03 Thread Pablo de Lara
Instead of having a static field for the buffer manager MB_MGR in the queue pair structure, use the provided API that allocates memory for it and store a pointer to it. Signed-off-by: Pablo de Lara --- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 10 +- drivers/crypto/aesni_mb/rt

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 14:59, Zhang, Qi Z: > > > +/** > > > + * this is a synchronous wrapper for secondary process send > > > + * request to primary process, this is invoked when an attach > > > + * or detach request issued from primary. > > > + */ > > > +int eth_dev_request_to_primary(struct eth_dev_mp_req *

Re: [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu ; > Ashish Gupta > > Subje

Re: [dpdk-dev] [PATCH v3 3/6] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Verma, Shally
HI Fiona Thanks for review. I was just about to send lib patch v4. So for now, I couldn't consider all input but some of them. But , in any case, this version is experimental so it is open for further feedback after 1st version go in. Rest, please see my feedback inline. >-Original Messag

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Trahe, Fiona
Hi Shally, > -Original Message- > From: Shally Verma [mailto:shally.ve...@caviumnetworks.com] > Sent: Wednesday, May 16, 2018 7:05 AM > To: De Lara Guarch, Pablo > Cc: Trahe, Fiona ; akhil.go...@nxp.com; dev@dpdk.org; > pathr...@caviumnetworks.com; Sunila Sahu ; > Ashish Gupta > > Subje

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 03 July 2018 20:21 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish ; Trahe, >Fiona >Subject: RE: [PATCH v3 5/6]

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 10:11 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 5:56 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Trahe, Fiona
> -Original Message- > From: Verma, Shally [mailto:shally.ve...@cavium.com] > Sent: Tuesday, July 3, 2018 4:00 PM > To: Trahe, Fiona ; De Lara Guarch, Pablo > > Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad > ; Sahu, Sunila ; > Gupta, Ashish > > Subject: RE: [PATCH

Re: [dpdk-dev] [PATCH v3 5/6] crypto/openssl: add asym crypto support

2018-07-03 Thread Verma, Shally
>-Original Message- >From: Trahe, Fiona [mailto:fiona.tr...@intel.com] >Sent: 03 July 2018 20:41 >To: Verma, Shally ; De Lara Guarch, Pablo > >Cc: akhil.go...@nxp.com; dev@dpdk.org; Athreya, Narayana Prasad >; Sahu, Sunila >; Gupta, Ashish >Subject: RE: [PATCH v3 5/6] crypto/openssl:

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Zhang, Qi Z
> -Original Message- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Tuesday, July 3, 2018 5:28 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Burakov, Anatoly ; Ananyev, > Konstantin ; Richardson, Bruce > ; Yigit, Ferruh ; Shelton, > Benjamin H ; Vangati, Narender > > Subject:

[dpdk-dev] [PATCH v4 0/4] crypto: add asym crypto support

2018-07-03 Thread Shally Verma
This patch series add support for asymmetric crypto in DPDK librte_cryptodev framework along with documentation updates. This patch series is divided in to following categories: 1. library patches with asymmetric API, xform and capability definitions 2. Programmer Guide updates with asymmetric

[dpdk-dev] [PATCH v4 1/4] lib/cryptodev: add asymmetric algos in cryptodev

2018-07-03 Thread Shally Verma
Add rte_crypto_asym.h with supported xfrms and associated op structures and APIs API currently supports: - RSA Encrypt, Decrypt, Sign and Verify - Modular Exponentiation and Inversion - DSA Sign and Verify - Deffie-hellman private key exchange - Deffie-hellman public key exchange - Deffie-hellman

[dpdk-dev] [PATCH v4 3/4] lib/cryptodev: add asymmetric crypto capability in cryptodev

2018-07-03 Thread Shally Verma
From: Ashish Gupta Extend cryptodev with asymmetric capability APIs and definitions. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- lib/librte_cryptodev/rte_cryptodev.c | 76 ++ lib/librte_cryptod

[dpdk-dev] [PATCH v4 4/4] doc: add asym crypto in cryptodev programmer guide

2018-07-03 Thread Shally Verma
From: Sunila Sahu Update cryptodev programmer guide with description of asymmetric crypto framework in lib cryptodev. Signed-off-by: Shally Verma Signed-off-by: Sunila Sahu Signed-off-by: Ashish Gupta Signed-off-by: Umesh Kartha --- doc/guides/prog_guide/cryptodev_lib.rst | 290

[dpdk-dev] [PATCH v4 2/4] cryptodev: support asymmetric operations

2018-07-03 Thread Shally Verma
From: Umesh Kartha Extend DPDK librte_cryptodev to: - define asym op type in rte_crypto_op_type and associated op pool create/alloc APIs - define asym session and associated session APIs If PMD shows in its feature flag that it supports both sym and asym then it must support those on all its q

[dpdk-dev] [PATCH v4] examples: fix RSS hash function configuration

2018-07-03 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

Re: [dpdk-dev] [PATCH] ethdev: document xstats API assumption

2018-07-03 Thread Van Haaren, Harry
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, June 28, 2018 3:16 PM > To: Thomas Monjalon > Cc: dev@dpdk.org; Yigit, Ferruh ; David Marchand > ; Olivier Matz ; Horton, > Remy > Subject: [dpdk-dev] [PATCH] ethdev: document xstats API assumption > > Document

[dpdk-dev] [PATCH v2] examples/multi_process: add l2fwd_fork to Makefile

2018-07-03 Thread Emma Kenny
l2fwd_fork is not complied by default, this will make it compile Fixes: 95e8005a56e8 ("examples/l2fwd_fork: new app") Signed-off-by: Emma Kenny --- examples/multi_process/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/multi_process/Makefile b/examples/multi_process/Makefi

[dpdk-dev] [PATCH] crypto/aesni_gcm: support IPsec Multi-buffer lib v0.50

2018-07-03 Thread Pablo de Lara
Adds support for the v0.50 of the IPsec Multi-buffer lib. The library now exposes its version, with the idea of maintaining backwards compatibility in the future, avoiding breaking the compilation of the PMD every time there is a new version available. Signed-off-by: Pablo de Lara --- doc/guides

[dpdk-dev] [PATCH] crypto/aesni_mb: support IPsec Multi-buffer lib v0.50

2018-07-03 Thread Pablo de Lara
Adds support for the v0.50 of the IPsec Multi-buffer lib. The library now exposes its version, with the idea of maintaining backwards compatibility in the future, avoiding breaking the compilation of the PMD every time there is a new version available. Signed-off-by: Pablo de Lara --- doc/guides

Re: [dpdk-dev] [PATCH v2 02/20] net/mlx5: handle drop queues are regular queues

2018-07-03 Thread Yongseok Koh
On Tue, Jul 03, 2018 at 09:17:56AM +0200, Nélio Laranjeiro wrote: > On Mon, Jul 02, 2018 at 06:07:03PM -0700, Yongseok Koh wrote: > > On Wed, Jun 27, 2018 at 05:07:34PM +0200, Nelio Laranjeiro wrote: [...] > flow_drop_queue is also confusing as it is a drop hash rx queue, it can > be used without a

[dpdk-dev] [PATCH v5] examples: fix RSS hash function configuration

2018-07-03 Thread Ferruh Yigit
ethdev layer introduced checks for application requested RSS hash functions and returns error for ones unsupported by hardware This check breaks some sample applications which blindly configures RSS hash functions without checking underlying hardware support. Updated examples to mask out unsuppor

[dpdk-dev] [PATCH] app/testpmd: set keep CRC offload flag

2018-07-03 Thread Ferruh Yigit
If "--disable-crc-strip" testpmd parameter issued, it removes the DEV_RX_OFFLOAD_CRC_STRIP flag. With introduction of new DEV_RX_OFFLOAD_KEEP_CRC offload flag, this flag also should be set when this parameter issued. Fixes: 3d12dceed2df ("ethdev: add new offload flag to keep CRC") Signed-off-by:

Re: [dpdk-dev] [PATCH v4] net/pcap: rx_iface_in stream type support

2018-07-03 Thread Ferruh Yigit
On 7/1/2018 12:05 PM, ido goshen wrote: > From: ido g > > Support rx of in direction packets only > Useful for apps that also tx to eth_pcap ports in order to not see them > echoed back in as rx when out direction is also captured > > Example: > In case using rx_iface and sending *single* packet

Re: [dpdk-dev] [PATCH v2 0/5] remove old ethdev offload API

2018-07-03 Thread Ferruh Yigit
On 7/2/2018 10:27 PM, Thomas Monjalon wrote: > A new offload API has been introduced in DPDK 17.11. > > This patchset resumes the work started by Ferruh (RFC) > to definitely drop the old offload API. > > There are: > - 3 patches to remove some useless code where the old API was found. > - 1 patc

[dpdk-dev] [PATCH] net/ark: use SPDX tags for Atomic Rules copyrighted files

2018-07-03 Thread Ed Czeck
Replace the BSD license header with the SPDX tag. Signed-off-by: Ed Czeck --- drivers/net/ark/Makefile| 32 ++-- drivers/net/ark/ark_ddm.c | 33 ++--- drivers/net/ark/ark_ddm.h | 33 ++--- dri

Re: [dpdk-dev] [PATCH v8 02/19] eal: enable multi process init callback

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:16, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > > Hi Qi, > > > > Sorry I do not understand neither the commit log, nor the doxygen. > > If it can help, consider your reader is in a bad mood and needs a pleasant > > description. > > OK, I think is not a g

Re: [dpdk-dev] [PATCH v8 03/19] ethdev: enable hotplug on multi-process

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:03, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 03/07/2018 14:59, Zhang, Qi Z: > > > > > +do_eth_dev_attach(const char *devargs, uint16_t *port_id); > > > > > > > > So you are duplicating rte_eth_dev_attach which is flawed in its > > > > design and should be

Re: [dpdk-dev] [PATCH v8 04/19] ethdev: introduce device lock

2018-07-03 Thread Thomas Monjalon
03/07/2018 17:08, Zhang, Qi Z: > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > 02/07/2018 07:44, Qi Zhang: > > > Introduce API rte_eth_dev_lock and rte_eth_dev_unlock to let > > > application lock or unlock on specific ethdev, a locked device can't > > > be detached, this help applicaiton

[dpdk-dev] [PATCH v9 00/27] Device querying

2018-07-03 Thread Gaetan Rivet
This patchset introduces a new EAL API for querying devices, filtered by arbitrary properties. The following elements are introduced to this end: * A new object, "rte_class", is used to describe the device class abstraction layer (eth, crypto, ...). * Both rte_bus and rte_class now offer a

[dpdk-dev] [PATCH v9 01/27] devargs: add non-variadic parsing function

2018-07-03 Thread Gaetan Rivet
rte_devargs_parse becomes non-variadic, rte_devargs_parsef becomes the variadic version, to be used to compose device strings. Signed-off-by: Gaetan Rivet --- drivers/net/failsafe/failsafe_args.c| 2 +- drivers/net/failsafe/failsafe_eal.c | 2 +- lib/librte_eal/common/eal_commo

[dpdk-dev] [PATCH v9 03/27] kvargs: build before EAL

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/Makefile | 3 +-- lib/librte_kvargs/Makefile | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/Makefile b/lib/Makefile index d82462ba2..e8e903c8f 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -4,6 +4,7 @@ include $(RTE_

[dpdk-dev] [PATCH v9 04/27] kvargs: introduce a more flexible parsing function

2018-07-03 Thread Gaetan Rivet
This function permits defining additional terminating characters, ending the parsing to arbitrary delimiters. Signed-off-by: Gaetan Rivet --- lib/Makefile | 1 + lib/librte_kvargs/rte_kvargs.c | 25 + lib/librte_kvargs/rte_kvargs.h

[dpdk-dev] [PATCH v9 02/27] kvargs: remove error logs

2018-07-03 Thread Gaetan Rivet
Error logs in kvargs parsing should be better handled in components calling the library. This library must be as lean as possible. Signed-off-by: Gaetan Rivet --- lib/librte_kvargs/rte_kvargs.c | 22 +- 1 file changed, 5 insertions(+), 17 deletions(-) diff --git a/lib/librt

[dpdk-dev] [PATCH v9 06/27] eal: introduce device class abstraction

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/bsdapp/eal/Makefile | 1 + lib/librte_eal/common/Makefile | 2 +- lib/librte_eal/common/eal_common_class.c | 62 +++ lib/librte_eal/common/include/rte_class.h | 121 + lib/librte_eal

[dpdk-dev] [PATCH v9 05/27] eal: introduce dtor macros

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_common.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/lib/librte_eal/common/include/rte_common.h b/lib/librte_eal/common/include/rte_common.h index 434adfd45..0dd832728 100644 --- a/lib/librte_eal/c

[dpdk-dev] [PATCH v9 07/27] eal/class: register destructor

2018-07-03 Thread Gaetan Rivet
Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/include/rte_class.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/librte_eal/common/include/rte_class.h b/lib/librte_eal/common/include/rte_class.h index b5e550a34..e8176f5e1 100644 --- a/lib/librte_eal/common/include/rte_class

[dpdk-dev] [PATCH v9 08/27] devargs: add function to parse device layers

2018-07-03 Thread Gaetan Rivet
This function is private to the EAL. It is used to parse each layers in a device description string, and store the result in an rte_devargs structure. Signed-off-by: Gaetan Rivet --- lib/librte_eal/common/eal_common_devargs.c | 144 lib/librte_eal/common/eal_private

  1   2   >