Re: [dpdk-dev] [PATCH] compress/qat: fixed data-plane return from QAT PMD

2019-04-09 Thread Jozwiak, TomaszX
> -Original Message- > From: Trahe, Fiona > Sent: Monday, April 8, 2019 6:16 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Jozwiak, TomaszX ; > Trahe, Fiona > Subject: [PATCH] compress/qat: fixed data-plane return from QAT PMD > > Fixes: 62ada2182a46 ("compress/qat: add dynamic sgl

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Friday, March 22, 2019 10:56 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string > parser f

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Zhao1, Wei > Sent: Tuesday, April 9, 2019 3:38 PM > To: Yigit, Ferruh ; dev@dpdk.org > Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > Subject: RE: [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string > parser fo

Re: [dpdk-dev] [PATCH v1 1/5] eal: add accessor functions for lcore_config

2019-04-09 Thread David Marchand
On Mon, Apr 8, 2019 at 8:25 PM Stephen Hemminger wrote: > The fields of the internal EAL core configuration are currently > laid bare as part of the API. This is not good practice and limits > fixing issues with layout and sizes. > > Make new accessor functions for the fields used by current driv

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Friday, March 22, 2019 10:56 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string > parser fo

Re: [dpdk-dev] [PATCH v1 2/5] bus: use lcore accessor functions

2019-04-09 Thread David Marchand
On Mon, Apr 8, 2019 at 8:25 PM Stephen Hemminger wrote: > Fix the bus logic in fslmc and dpaa drivers to use the new > accessor functions. > > Signed-off-by: Stephen Hemminger > --- > drivers/bus/dpaa/dpaa_bus.c | 6 -- > drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 4 +++- > 2 f

Re: [dpdk-dev] [PATCH v1 4/5] app/test: use lcore accessor functions

2019-04-09 Thread David Marchand
On Mon, Apr 8, 2019 at 8:26 PM Stephen Hemminger wrote: > Use the new accessor functions. Don't refer to lcore_config directly. > > Signed-off-by: Stephen Hemminger > --- > app/test/test_cryptodev.c | 2 +- > app/test/test_hash_readwrite_lf.c | 14 +++--- > app/test/test_ring_

Re: [dpdk-dev] [PATCH v1 3/5] examples/bond: use lcore accessor

2019-04-09 Thread David Marchand
On Mon, Apr 8, 2019 at 8:25 PM Stephen Hemminger wrote: > Use the accessor function to look at lcore state. > > Signed-off-by: Stephen Hemminger > --- > examples/bond/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/examples/bond/main.c b/examples/bond/main.c

[dpdk-dev] [PATCH] net/af_xdp: free mbuf when allocate Tx queue fails

2019-04-09 Thread Xiaolong Ye
When we fail to allocate enough slots in tx queue for transmitting packets, we need to free the corresponding mbufs. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 8 ++-- 1 file changed, 6 insertions(+), 2 delet

Re: [dpdk-dev] [PATCH] net/af_xdp: free mbuf when allocate Tx queue fails

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 10:27 AM Xiaolong Ye wrote: > When we fail to allocate enough slots in tx queue for transmitting > packets, we need to free the corresponding mbufs. > You'd better let the application retry on its own... > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > > Sign

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
Hi Aaron, > > This makes the tests pass, and also ensures that on platforms where the > testing is supported, we can properly test the implementation specific > code. One edge case is when we run on x86_64 systems that don't support > AVX2, but where the compiler can generate such instructions.

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Ferruh Yigit
On 4/9/2019 8:38 AM, Zhao1, Wei wrote: > Hi, Ferruh > >> -Original Message- >> From: Yigit, Ferruh >> Sent: Friday, March 22, 2019 10:56 PM >> To: Zhao1, Wei ; dev@dpdk.org >> Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin >> >> Subject: Re: [dpdk-stable] [PATCH v3]

Re: [dpdk-dev] [PATCH v6 1/2] app/pdump: remove core restriction

2019-04-09 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, April 4, 2019 9:55 AM > To: dev@dpdk.org; Kovacevic, Marko ; Pattan, > Reshma ; david.march...@redhat.com > Cc: Wiles, Keith ; Mcnamara, John > ; Byrne, Stephen1 ; > Tamboli, Amit S ; Padubidri, Sanjay A > ; Patel, Amol ; Var

Re: [dpdk-dev] [PATCH v6 2/2] app/pdump: enhance to support multi-core capture

2019-04-09 Thread Pattan, Reshma
> -Original Message- > From: Varghese, Vipin > Sent: Thursday, April 4, 2019 9:55 AM > To: dev@dpdk.org; Kovacevic, Marko ; Pattan, > Reshma ; david.march...@redhat.com > Cc: Wiles, Keith ; Mcnamara, John > ; Byrne, Stephen1 ; > Tamboli, Amit S ; Padubidri, Sanjay A > ; Patel, Amol ; Var

[dpdk-dev] [PATCH v4] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Wei Zhao
There is need for users to set configuration of HEX number for RSS key. The key byte should be pass down as hex number not as char string. This patch enable cmdline flow parse HEX number, in order to not using string which pass ASIC number. Fixes: f4d623f96119 ("app/testpmd: fix missing RSS fields

Re: [dpdk-dev] [PATCH v2] usertools: replace unsafe input function

2019-04-09 Thread Burakov, Anatoly
On 08-Apr-19 2:40 PM, Andrius Sirvys wrote: LGTM static code analysis tool reports that the function 'input' is unsafe. Changed to use raw_input which then converts it using ast.literal_eval() which is safe. Fixes: d1b94da4a4e0 ("usertools: add client script for telemetry") Cc: ciara.po...@intel

Re: [dpdk-dev] [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string parser for flow API

2019-04-09 Thread Zhao1, Wei
Hi, Ferruh > -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 9, 2019 4:45 PM > To: Zhao1, Wei ; dev@dpdk.org > Cc: sta...@dpdk.org; step...@networkplumber.org; Ananyev, Konstantin > > Subject: Re: [dpdk-stable] [PATCH v3] app/testpmd: fix support of hex string > parser fo

[dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues

2019-04-09 Thread David Hunt
A previous change removed the limit of 64 cores by moving away from 64-bit masks to char arrays. However this left a buffer overrun issue, where the max channels was defined as 64, and max cores was defined as 256. These should all be consistently set to RTE_MAX_LCORE. The #defines being removed a

Re: [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-09 Thread Lin, Xueqin
Hi NIkhilesh, This patchset impacts some of 19.05 rc1 txonly/burst tests on Intel NIC. If set txonly fwd, IXIA or tester peer can't receive packets that sent from app generated. This is high issue, block some cases test. Detailed information as below, need you to check it soon. *DPDK version:

[dpdk-dev] [PATCH 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Bruce Richardson
Within EAL we had a series of if statements for selecting the EAL directory to use. Now that the directory names match those of the OS's they are for we can instead just use a generated subdirectory name, shortening the code. To avoid strange errors, we still need to check for unsupported OS's, but

[dpdk-dev] [PATCH 0/5] small cleanup and fixes

2019-04-09 Thread Bruce Richardson
Made some small changes to meson to shorten the code and increase readability. While testing, found a number of issues on FreeBSD builds, which are fixed in this set too. Bruce Richardson (5): build: simplify subdirectory detection for EAL build: increase readability via shortcut variables d

[dpdk-dev] [PATCH 3/5] distributor: skip building if power library not found

2019-04-09 Thread Bruce Richardson
The power library is not built on non-Linux systems, so skip the distributor sample if it's not found, as it's a mandatory dependency. Signed-off-by: Bruce Richardson --- examples/distributor/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/examples/distributor/meson.build b/ex

[dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Bruce Richardson
The definition of CPU_AND differs from Linux to BSD, so we need to use RTE_CPU_AND instead. Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS CAT and CDP") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- examples/l2fwd-cat/cat.c | 2 +- 1 file changed, 1 inserti

[dpdk-dev] [PATCH 2/5] build: increase readability via shortcut variables

2019-04-09 Thread Bruce Richardson
Define variables for "is_linux", "is_freebsd" and "is_windows" to make the code shorter for comparisons and more readable. Signed-off-by: Bruce Richardson --- app/meson.build | 2 +- buildtools/meson.build | 2 +- config/meson.build

[dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread Bruce Richardson
The pipefile option does not seem to exist on FreeBSD, giving an error when running the script. Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") Signed-off-by: Bruce Richardson --- devtools/test-meson-builds.sh | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

Re: [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-09 Thread Pavan Nikhilesh Bhagavatula
Hi Lin, Can you check if the following patch fixes the issue? http://patches.dpdk.org/patch/52395/ I wasn't able to catch this earlier. Regards, Pavan. >-Original Message- >From: Lin, Xueqin >Sent: Tuesday, April 9, 2019 2:58 PM >To: Pavan Nikhilesh Bhagavatula ; Yigit, Ferruh > >Cc: d

Re: [dpdk-dev] [PATCH 3/5] distributor: skip building if power library not found

2019-04-09 Thread Hunt, David
On 9/4/2019 10:29 AM, Bruce Richardson wrote: The power library is not built on non-Linux systems, so skip the distributor sample if it's not found, as it's a mandatory dependency. Signed-off-by: Bruce Richardson --- examples/distributor/meson.build | 3 +++ 1 file changed, 3 insertions(+)

Re: [dpdk-dev] [dpdk-techboard] DPDK ABI/API Stability

2019-04-09 Thread Ray Kinsella
On 08/04/2019 14:38, Burakov, Anatoly wrote: > On 08-Apr-19 2:00 PM, Ray Kinsella wrote: >> >> >> On 08/04/2019 11:15, Burakov, Anatoly wrote: >>> On 08-Apr-19 10:04 AM, Ray Kinsella wrote: On 07/04/2019 10:48, Thomas Monjalon wrote: > 04/04/2019 16:07, Burakov, Anatoly: >> On 04-Ap

[dpdk-dev] [PATCH v1] examples/power: fix vm power manager resource leak

2019-04-09 Thread David Hunt
Fixes: 99a968fac0cf ("examples/vm_power: add core list parameter") Coverity issue: 337674 Signed-off-by: David Hunt --- examples/vm_power_manager/main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/vm_power_manager/main.c b/examples/vm_power_manager/main.c index 893bf4cdd..dd

[dpdk-dev] [PATCH v2] app/testpmd: fix ether header size calculation

2019-04-09 Thread Pavan Nikhilesh Bhagavatula
From: Pavan Nikhilesh Fix ether header size calculation in Tx only mode. Coverity issue: 337684 Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") Signed-off-by: Pavan Nikhilesh --- v2 Changes: - Preserve relation between destination and destination size. (Bruce)

Re: [dpdk-dev] [PATCH 0/5] small cleanup and fixes

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 11:29 AM Bruce Richardson wrote: > Made some small changes to meson to shorten the code and increase > readability. While testing, found a number of issues on FreeBSD builds, > which are fixed in this set too. > > Bruce Richardson (5): > build: simplify subdirectory detec

[dpdk-dev] [PATCH] power: fix for policy dependency to MAC list

2019-04-09 Thread Lukasz Krakowiak
Removed dependency to mac_list from policies: * BRANCH_RATIO, * WORKLOAD, * TIME in function update_policy. Fixes: 1b897991473f ("power: update error handling") Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_monitor.c | 18 +- 1 file changed, 13 insertions

Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson wrote: > The definition of CPU_AND differs from Linux to BSD, so we need to use > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS > CAT and CDP") > Cc: sta...@dpdk.org This creates a dependency o

Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an error > when running the script. > > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") > > Signed-off-by: Bruce Richardson > --- > devtools/test-mes

Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 11:57:04AM +0200, David Marchand wrote: >On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. > Fixes: 5d9

Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: >On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > The definition of CPU_AND differs from Linux to BSD, so we need to > use > RTE_CPU_AND instead. > Fixes: f6baccb

Re: [dpdk-dev] [PATCH] app/test-crypto-perf: fix missing bounds check on socket id

2019-04-09 Thread Zhang, Roy Fan
Acked-by: Fan Zhang Respond through mobile, sorry for any funny formatting/font may exist in this email.

Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson wrote: > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > >On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > ><[1]bruce.richard...@intel.com> wrote: > > > > The definition of CPU_AND differs from Linux to BSD, so we n

Re: [dpdk-dev] [PATCH 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > Within EAL we had a series of if statements for selecting the EAL > directory > to use. Now that the directory names match those of the OS's they are > for > we can instead just use a generated subdirectory name, shortening the > code. >

Re: [dpdk-dev] [PATCH 2/5] build: increase readability via shortcut variables

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > Define variables for "is_linux", "is_freebsd" and "is_windows" > to make the code shorter for comparisons and more readable. > > Signed-off-by: Bruce Richardson < > bruce.richard...@intel.com > > > --- > app/meson.build

Re: [dpdk-dev] [PATCH 3/5] distributor: skip building if power library not found

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > The power library is not built on non-Linux systems, so skip the > distributor sample if it's not found, as it's a mandatory dependency. > > Signed-off-by: Bruce Richardson < > bruce.richard...@intel.com > > > --- > examples/distributor

Re: [dpdk-dev] [PATCH 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > The pipefile option does not seem to exist on FreeBSD, giving an > error > when running the script. > > Fixes: 5d9176673008 ("devtools: fix meson build test to exit on > failure") > > Signed-off-by: Bruce Richardson < > bruce.richard...

Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 12:34:06PM +0200, David Marchand wrote: >On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson ><[1]bruce.richard...@intel.com> wrote: > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > >On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson >

Re: [dpdk-dev] [dpdk-stable] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 12:34 +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson < > bruce.richard...@intel.com > > > wrote: > > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > >On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > ><[1] > >

Re: [dpdk-dev] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > The definition of CPU_AND differs from Linux to BSD, so we need to > use > RTE_CPU_AND instead. > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for > PQoS CAT and CDP") > Cc: > sta...@dpdk.org > > > Signed-off-by:

Re: [dpdk-dev] [PATCH 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 11:34:24AM +0100, Luca Boccassi wrote: > On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > > Within EAL we had a series of if statements for selecting the EAL > > directory to use. Now that the directory names match those of the OS's > > they are for we can instea

[dpdk-dev] [PATCH v2 2/5] build: increase readability via shortcut variables

2019-04-09 Thread Bruce Richardson
Define variables for "is_linux", "is_freebsd" and "is_windows" to make the code shorter for comparisons and more readable. Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Luca Boccassi --- app/meson.build | 2 +- buildtools/meson.build

[dpdk-dev] [PATCH v2 5/5] devtools/test-meson-builds: fix support for FreeBSD

2019-04-09 Thread Bruce Richardson
The pipefile option does not seem to exist on FreeBSD, giving an error when running the script. Fixes: 5d9176673008 ("devtools: fix meson build test to exit on failure") Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Luca Boccassi --- V2: change "==" to "=" in compariso

[dpdk-dev] [PATCH v2 0/5] small cleanup and fixes

2019-04-09 Thread Bruce Richardson
Made some small changes to meson to shorten the code and increase readability. While testing, found a number of issues on FreeBSD builds, which are fixed in this set too. Bruce Richardson (5): build: simplify subdirectory detection for EAL build: increase readability via shortcut variables d

[dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Bruce Richardson
Within EAL we had a series of if statements for selecting the EAL directory to use. Now that the directory names match those of the OS's they are for we can instead just use a generated subdirectory name, shortening the code. To avoid strange errors, we still need to check for unsupported OS's, but

[dpdk-dev] [PATCH v2 3/5] distributor: skip building if power library not found

2019-04-09 Thread Bruce Richardson
The power library is not built on non-Linux systems, so skip the distributor sample if it's not found, as it's a mandatory dependency. Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: David Hunt Acked-by: Luca Boccassi --- examples/distributor/meson.build | 3 +++ 1 file

[dpdk-dev] [PATCH v2 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread Bruce Richardson
The definition of CPU_AND differs from Linux to BSD, so we need to use RTE_CPU_AND instead. Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample application for PQoS CAT and CDP") Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson Reviewed-by: David Marchand Acked-by: Luca Boccassi --- Note

Re: [dpdk-dev] [PATCH 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 11:44 +0100, Bruce Richardson wrote: > On Tue, Apr 09, 2019 at 11:34:24AM +0100, Luca Boccassi wrote: > > On Tue, 2019-04-09 at 10:29 +0100, Bruce Richardson wrote: > > > Within EAL we had a series of if statements for selecting the EAL > > > directory to use. Now that the dir

Re: [dpdk-dev] [PATCH v2 1/5] build: simplify subdirectory detection for EAL

2019-04-09 Thread Luca Boccassi
On Tue, 2019-04-09 at 11:55 +0100, Bruce Richardson wrote: > Within EAL we had a series of if statements for selecting the EAL > directory > to use. Now that the directory names match those of the OS's they are > for > we can instead just use a generated subdirectory name, shortening the > code. >

Re: [dpdk-dev] [dpdk-stable] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 12:40 PM Luca Boccassi wrote: > On Tue, 2019-04-09 at 12:34 +0200, David Marchand wrote: > > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson < > > bruce.richard...@intel.com > > > > > wrote: > > > > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > > >

Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues

2019-04-09 Thread Burakov, Anatoly
On 09-Apr-19 10:22 AM, David Hunt wrote: A previous change removed the limit of 64 cores by moving away from 64-bit masks to char arrays. However this left a buffer overrun issue, where the max channels was defined as 64, and max cores was defined as 256. These should all be consistently set to R

Re: [dpdk-dev] i40e rte_eth_link_get_nowait() on X722 returns wrong link_speed value 20000 instead of 10000

2019-04-09 Thread Martin Weiser
Hi, just bumping this since there has been no reply at all for a long time. Would it be better if I opened a bug for this? Best, Martin Am 22.01.19 um 16:07 schrieb Martin Weiser: > Hi, > > We are using a Xeon D with an integrated X722 NIC that provides two > ports of 8086:37d2 and two ports of

[dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Ayuj Verma
Return -ENOTSUP for unsupported tests Signed-off-by: Ayuj Verma Signed-off-by: Shally Verma --- app/test/test_cryptodev_asym.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c index d2efce9..feed3a8

[dpdk-dev] [PATCH v2] fix return value for skipped tests

2019-04-09 Thread Ayuj Verma
Currently some tests return TEST_SKIPPED/-1 when tests or params are not supported for particular PMD because of which tests adds to FAILED test counter in place of Skipped/Unsupported counter. Since unsupported test is not a failure case, replace return value TEST_SKIPPED/-1 with -ENOTSUP Change

Re: [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-09 Thread Yao, Lei A
> -Original Message- > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] > Sent: Tuesday, April 9, 2019 5:33 PM > To: Lin, Xueqin ; Yigit, Ferruh > Cc: dev@dpdk.org; Xu, Qian Q ; Li, WenjieX A > ; Wang, FengqinX ; > Yao, Lei A ; Wang, Yinan ; > Jerin Jacob Kollanukkara

Re: [dpdk-dev] [PATCH v6 3/4] app/testpmd: move pkt prepare logic into a separate function

2019-04-09 Thread Ferruh Yigit
On 4/9/2019 1:24 PM, Yao, Lei A wrote: > > >> -Original Message- >> From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavat...@marvell.com] >> Sent: Tuesday, April 9, 2019 5:33 PM >> To: Lin, Xueqin ; Yigit, Ferruh >> >> Cc: dev@dpdk.org; Xu, Qian Q ; Li, WenjieX A >> ; Wang, FengqinX ; >>

[dpdk-dev] [PATCH v6 01/14] bus/ifpga: add AFU shared data

2019-04-09 Thread Rosen Xu
AFU can be implemented into many different acceleration devices, these devices need shared data to store private information when they are handled by users. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/rte_bus_ifpga.h | 7 +++ 1 file changed, 7 insertions(+) diff -

[dpdk-dev] [PATCH v6 00/14] Add patch set for IPN3KE

2019-04-09 Thread Rosen Xu
v6 updates: == - Fix v5 comments - Fix TM Shaper rate issue v5 updates: == - Fix EXPERIMENTAL symbol definition issue v4 updates: == - Fix coding style issues v3 updates: == - Fix v2 comments - Update MAC BAR of AFU index get ops - Remove OPAE share code de

[dpdk-dev] [PATCH v6 02/14] bus/ifpga: add function for AFU search by name

2019-04-09 Thread Rosen Xu
In many scenarios, AFU is needed searched by name, this function add the feature. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei --- drivers/bus/ifpga/ifpga_bus.c | 13 + drivers/bus/ifpga/rte_bus_ifpga.h | 9 + drivers/bus/ifpga/rte_bus_ifpga_versi

[dpdk-dev] [PATCH v6 05/14] net/ipn3ke: add IPN3KE TM of PMD driver

2019-04-09 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE TM of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |3 + drivers/net/ipn3ke/ipn3ke_ethdev.h |7 + drivers/net/

[dpdk-dev] [PATCH v6 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-09 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE ethdev PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- MAINTAINERS | 6 + config/common_base| 4 + doc/guides/nics/features/ipn3ke.ini | 55

[dpdk-dev] [PATCH v6 04/14] net/ipn3ke: add IPN3KE representor of PMD driver

2019-04-09 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE representor of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile | 2 + drivers/net/ipn3ke/ipn3ke_ethdev.c | 4 +- drivers/net/ipn3ke/ipn3ke_ethdev.h | 25 + drive

[dpdk-dev] [PATCH v6 07/14] raw/ifpga_rawdev: clean up code for ifpga share code

2019-04-09 Thread Rosen Xu
From: Tianfei zhang clean up code: 1. use opae_memcpy instead of memcpy 2. use opae_memset instead of memset 3. disable opae_adapter_dump by default Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_api.c | 2 +- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev

[dpdk-dev] [PATCH v6 09/14] raw/ifpga_rawdev: add SPI and MAX10 device driver

2019-04-09 Thread Rosen Xu
From: Tianfei zhang There is a SPI bus link between A10 FPGA and MAX10 FPGA. MAX10 is in charge of board management, like power management, sensors, flash devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile | 3 + drivers/raw/ifpga_rawdev/base/ifpga_d

[dpdk-dev] [PATCH v6 06/14] net/ipn3ke: add IPN3KE Flow of PMD driver

2019-04-09 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE Flow of PMD driver. Signed-off-by: Rosen Xu Signed-off-by: Andy Pei Signed-off-by: Dan Wei --- drivers/net/ipn3ke/Makefile |1 + drivers/net/ipn3ke/ipn3ke_ethdev.c |5 + drivers/net/ipn3ke/ipn3ke_ethdev.h |1 + drivers/ne

[dpdk-dev] [PATCH v6 08/14] raw/ifpga_rawdev: store private features in FME and Port

2019-04-09 Thread Rosen Xu
From: Tianfei zhang Get private features attrubite like size, id, address after enumeration, and insert into FEM or Port dedicate list. when initial the private feature driver, we just compare the private feature id between the list and feature drivers array to match the proper drivers. This pa

[dpdk-dev] [PATCH v6 10/14] raw/ifpga_rawdev: add I2C and at24 EEPROM driver

2019-04-09 Thread Rosen Xu
From: Tianfei zhang 1. Add Altera I2C master device driver 2. Add at24 eeprom driver which is i2c slave device 3. Introducing a new ops for opae_manager: opae_manager_networking_ops. This ops will include some networking operation by FPGA, like vBNG operation, MAC ROM operation and so on. Signed

[dpdk-dev] [PATCH v6 11/14] raw/ifpga_rawdev: add eth group driver

2019-04-09 Thread Rosen Xu
From: Tianfei zhang There is two eth group devices in PAC N3000 card, each eth group include PHY device and MAC device. Exposing APIs for DPDK PMD driver to access those devices. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/Makefile| 1 + drivers/raw/ifpga_rawde

[dpdk-dev] [PATCH v6 12/14] raw/ifpga_rawdev: add version description on README

2019-04-09 Thread Rosen Xu
From: Tianfei zhang add verion description on READ about ifpga base code. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/README | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/raw/ifpga_rawdev/base/README b/drivers/raw/ifpga_rawdev/base/README inde

[dpdk-dev] [PATCH v6 13/14] raw/ifpga_rawdev: using prefix name for feature and its ops

2019-04-09 Thread Rosen Xu
From: Tianfei zhang Using prefix name "ifpga_" for feature and feature_ops data struct on ifpga base code, which is suggested by Yigit, Ferruh. Signed-off-by: Tianfei Zhang --- drivers/raw/ifpga_rawdev/base/ifpga_enumerate.c | 8 +-- drivers/raw/ifpga_rawdev/base/ifpga_feature_dev.c | 4 +-

[dpdk-dev] [PATCH v6 14/14] raw/ifpga_rawdev: add IPN3KE support for IFPGA Rawdev

2019-04-09 Thread Rosen Xu
Add Intel FPGA Acceleration NIC IPN3KE support for IFPGA Rawdev. Signed-off-by: Rosen Xu Signed-off-by: Tianfei Zhang Signed-off-by: Andy Pei --- drivers/raw/ifpga_rawdev/Makefile | 1 + drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 248 +++- drivers/raw/ifpga_r

Re: [dpdk-dev] Secondary process crash in rte_eal_init

2019-04-09 Thread Mohamed Mahmoud (mmahmoud)
Hi Anatoly: For the secondary process all we are setting is the –proc-type set to secondary, maybe point me to your test that might give me some clues, also How I can generate detailed crash log ? When I checked the init code there are very few places that can cause the panic if (pipe(lcore_c

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Aaron Conole
"Ananyev, Konstantin" writes: > Hi Aaron, > >> >> This makes the tests pass, and also ensures that on platforms where the >> testing is supported, we can properly test the implementation specific >> code. One edge case is when we run on x86_64 systems that don't support >> AVX2, but where the c

[dpdk-dev] [dpdk-announce] DPDK 18.11.1 released

2019-04-09 Thread Kevin Traynor
Hi all, Here is a new stable release: https://fast.dpdk.org/rel/dpdk-18.11.1.tar.xz The git tree is at: https://dpdk.org/browse/dpdk-stable/?h=18.11 Information about validation of the stable release: http://doc.dpdk.org/guides-18.11/rel_notes/release_18_11.html#validatio

[dpdk-dev] [PATCH v3] app/testbbdev: fix sprintf with snprintf or strlcpy

2019-04-09 Thread Pallantla Poornima
sprintf function is not secure as it doesn't check the length of string. More secure function snprintf and strlcpy is used. Fixes: f714a18885 ("app/testbbdev: add test application for bbdev") Cc: sta...@dpdk.org Signed-off-by: Pallantla Poornima Acked-by: Amr Mokhtar --- v3: Added Ack. v2: Used

[dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-09 Thread Ilya Maximets
Application should be able to obtain information like 'ifname' from the 'vid' passed to 'destroy_connection' callback. Currently, all the API calls with passed 'vid' fails with 'device not found'. Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") Cc: sta...@dpdk.org Signed-o

Re: [dpdk-dev] [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case

2019-04-09 Thread Akhil Goyal
> -Original Message- > From: Gagandeep Singh > Sent: Monday, April 8, 2019 2:30 PM > To: dev@dpdk.org; Akhil Goyal > Cc: Gagandeep Singh > Subject: [PATCH 2/2] crypto/caam_jr: fix total length in AUTH only sg case > > CAAM return wrong digest value in AUTH only sg test case > because

Re: [dpdk-dev] [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness

2019-04-09 Thread Akhil Goyal
> -Original Message- > From: Gagandeep Singh > Sent: Monday, April 8, 2019 2:29 PM > To: dev@dpdk.org; Akhil Goyal > Cc: Gagandeep Singh > Subject: [PATCH 1/2] crypto/caam_jr: fix the shared desc endianness > > build a shared descriptor accordingly if core and > CAAM endianness is sam

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-09 Thread Jens Freimann
On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: Application should be able to obtain information like 'ifname' from the 'vid' passed to 'destroy_connection' callback. Currently, all the API calls with passed 'vid' fails with 'device not found'. Fixes: efba12a78ddf ("vhost: add use

Re: [dpdk-dev] [PATCH v1] lib/power: fix buffer overrun coverity issues

2019-04-09 Thread Hunt, David
On 9/4/2019 12:18 PM, Burakov, Anatoly wrote: On 09-Apr-19 10:22 AM, David Hunt wrote: A previous change removed the limit of 64 cores by moving away from 64-bit masks to char arrays. However this left a buffer overrun issue, where the max channels was defined as 64, and max cores was defined

[dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT

2019-04-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=248 Bug ID: 248 Summary: Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT Product: DPDK Version: 18.11 Hardware: All O

Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT

2019-04-09 Thread David Marchand
On Tue, Apr 9, 2019 at 4:45 PM wrote: > https://bugs.dpdk.org/show_bug.cgi?id=248 > > Bug ID: 248 >Summary: Bonding PMD: Invalid array dimension in TX burst for > 802.3ad mode with fast queue leads to SEGFAULT >Product: DPDK >Ver

Re: [dpdk-dev] [PATCH] net/af_xdp: free mbuf when allocate Tx queue fails

2019-04-09 Thread Ye Xiaolong
Hi, David On 04/09, David Marchand wrote: >On Tue, Apr 9, 2019 at 10:27 AM Xiaolong Ye wrote: > >> When we fail to allocate enough slots in tx queue for transmitting >> packets, we need to free the corresponding mbufs. >> > >You'd better let the application retry on its own... Make sense. > > >

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 05:03:39PM +0530, Ayuj Verma wrote: > Return -ENOTSUP for unsupported tests > I disagree with this, since TEST_SKIPPED is the correct return value for unsupported test conditions IMHO. If part of the current infrastructure doesn't support that return value, I think the infr

[dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-09 Thread Fiona Trahe
Fixed some typos and clarified which errors should be returned when and why on the enqueue and dequeue APIs. Fixes: a584d3bea902 ("doc: add compressdev library guide") cc: sta...@dpdk.org Signed-off-by: Fiona Trahe --- v2 changes: - changed "0 or undefined" to just "undefined" as 0 is superfluo

Re: [dpdk-dev] [PATCH v2] app/test: replace TEST_SKIPPED with -ENOTSUP

2019-04-09 Thread Trahe, Fiona
Hi Ayuj, > -Original Message- > From: Ayuj Verma [mailto:ayve...@marvell.com] > Sent: Tuesday, April 9, 2019 12:34 PM > To: akhil.go...@nxp.com; Trahe, Fiona ; Kusztal, > ArkadiuszX > ; De Lara Guarch, Pablo > > Cc: shal...@marvell.com; ss...@marvell.com; kkotamar...@marvell.com; > ade

Re: [dpdk-dev] [PATCH v6 03/14] net/ipn3ke: add IPN3KE ethdev PMD driver

2019-04-09 Thread Stephen Hemminger
Minor nits. > + > + (*rd_data) = rte_le_to_cpu_32(read_data); > + return 0; > +} Paren around *rd_data are unnecessary > + indirect_addrs = (volatile void *)(hw->eth_group_bar[eth_group_sel] + > + 0x10); cast is to void * is unnecesary + return ipn3ke_indirect_rea

[dpdk-dev] [PATCH] net/af_xdp: enqueue buf ring when allocate Tx queue fails

2019-04-09 Thread Xiaolong Ye
When it fails to allocate enough slots in Tx queue for transmitting packets, we need to return the dequeued addrs to buf ring. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Signed-off-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 1 + 1 file changed, 1 insertion(+) diff

[dpdk-dev] [PATCH] examples/vm_power_manager: fix string null termination

2019-04-09 Thread Reshma Pattan
After the read() the jason_data null termination is missing for the case "indent < 0", for "indent > 0" and "indent == 0" cases null termination is already handled. So add the missing case "indent < 0" to the existing "indent == 0" case to fix null termination. Coverity issue: 337680 Fixes: a6350

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
> > Hi Aaron, > > > >> > >> This makes the tests pass, and also ensures that on platforms where the > >> testing is supported, we can properly test the implementation specific > >> code. One edge case is when we run on x86_64 systems that don't support > >> AVX2, but where the compiler can gener

[dpdk-dev] [Bug 249] kni cause a kernel crash on avx512 supported platform with gcc 8.3.1

2019-04-09 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=249 Bug ID: 249 Summary: kni cause a kernel crash on avx512 supported platform with gcc 8.3.1 Product: DPDK Version: 18.11 Hardware: All OS: All Status: CONF

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
> > > > Hi Aaron, > > > > > >> > > >> This makes the tests pass, and also ensures that on platforms where the > > >> testing is supported, we can properly test the implementation specific > > >> code. One edge case is when we run on x86_64 systems that don't support > > >> AVX2, but where the

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Richardson, Bruce
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, April 9, 2019 5:03 PM > To: Aaron Conole > Cc: dev@dpdk.org; Jerin Jacob ; Gavin Hu > ; Richardson, Bruce ; > Michael Santana > Subject: RE: [PATCH 3/3] acl: adjust the tests > > > > > Hi Aaron, > > > > > >> > > >> Thi

Re: [dpdk-dev] [PATCH v4 2/3] examples/l3fwd: use reserved IPv4/IPv6 addresses

2019-04-09 Thread Stephen Hemminger
On Mon, 8 Apr 2019 13:07:33 + "Iremonger, Bernard" wrote: > Hi Stephen, > > > -Original Message- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, April 2, 2019 9:39 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subject: [dpdk-dev]

[dpdk-dev] [PATCH] doc: add guideines for initial PMD submission

2019-04-09 Thread Rami Rosen
This patch for DPDK Contributor's Guidelines indicates the repos against which a new PMD should be prepared; for new network ethernet PMDs it should be dpdk-next-net, and for new crypto PMDs it should be dpdk-next-crypto. Though this may seem obvious, it is not mentioned in DPDK documentation. Cc:

  1   2   >