Re: [dpdk-dev] [PATCH 2/4] net/bonding: fix LACP fast queue Rx handler

2019-04-18 Thread David Marchand
Hello Chas, On Fri, Apr 12, 2019 at 4:02 PM Chas Williams <3ch...@gmail.com> wrote: > I should have some time this weekend to run these patches through our > regression system. > Did you manage to run this series through your tests system ? > On 4/10/19 8:53 AM, David Marchand wrote: > > @@ -3

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 7:17 AM > To: bruce.richard...@intel.com; Jerin Jacob Kollanukkaran > ; Pavan Nikhilesh Bhagavatula > ; shah...@mellanox.com > Cc: dev@dpdk.org; tho...@monjalon.net; gavin...@arm.com; > honnappa.nagaraha...@arm.co

Re: [dpdk-dev] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support

2019-04-18 Thread Vivek Kumar Sharma
>> From: Vivek Sharma >> >> Enable missing support for QinQ strip rx offload >> in vlan offload set/get methods. >> >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") >> Cc: sta...@dpdk.org >Not sure it is a fix. >The commit mentioned above allows some kind of offload co

[dpdk-dev] [PATCH] doc: add description to release note

2019-04-18 Thread Tomasz Jozwiak
Added description about compression QAT PMD improvement Signed-off-by: Tomasz Jozwiak --- doc/guides/rel_notes/release_19_05.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index b0928a6..624625f 100644 -

Re: [dpdk-dev] [dpdk-stable] [EXT] Re: [PATCH v2] ethdev: fix QinQ strip offload support

2019-04-18 Thread Thomas Monjalon
18/04/2019 09:38, Vivek Kumar Sharma: > >> From: Vivek Sharma > >> > >> Enable missing support for QinQ strip rx offload > >> in vlan offload set/get methods. > >> > >> Fixes: cc9d0456b870 ("i40e: support double vlan stripping and insertion") > >> Cc: sta...@dpdk.org > > >Not sure it is a fix. >

Re: [dpdk-dev] [PATCH] net/iavf: fix queue interrupt for ICE

2019-04-18 Thread Zhang, Qi Z
> -Original Message- > From: Zhao1, Wei > Sent: Thursday, April 18, 2019 12:58 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Zhang, Qi Z ; Zhao1, Wei > > Subject: [PATCH] net/iavf: fix queue interrupt for ICE > > Enable CLEARPBA bit is required by ice NIC of A0/A1 version to enable Tx a

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] meson: change default cache line size for armv8

2019-04-18 Thread Hemant Agrawal
> -Original Message- > From: dev On Behalf Of Honnappa Nagarahalli > Sent: Thursday, April 18, 2019 10:31 AM > To: ys...@mellanox.com; bruce.richard...@intel.com; jer...@marvell.com; > pbhagavat...@marvell.com; shah...@mellanox.com > Cc: dev@dpdk.org; tho...@monjalon.net; Gavin Hu (Arm Tec

Re: [dpdk-dev] [PATCH v2] drivers/crypto: fix session destroy for dpaa and dpaa2

2019-04-18 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH] net/i40e: fix print of not supported admin queue msg

2019-04-18 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Thursday, April 18, 2019 1:52 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix print of not supported admin queue msg > > When launch testpmd with VF and quit testpmd, there'll be lots of message

[dpdk-dev] [PATCH v2] lib/bitratestats: fix unchecked return value

2019-04-18 Thread Andrius Sirvys
Checking the return value of rte_metrics_update_values, if failed returning that value. Coverity had picked up that that the return value wasn't being checked. Coverity issue: 336863 Fixes: 2ad7ba9a6567 ("bitrate: add bitrate statistics library") Cc: remy.hor...@intel.com Signed-off-by: Andrius S

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecked return value

2019-04-18 Thread Mcnamara, John
> -Original Message- > From: stable [mailto:stable-boun...@dpdk.org] On Behalf Of Andrius Sirvys > Sent: Thursday, April 18, 2019 9:52 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Sirvys, Andrius ; > remy.hor...@intel.com > Subject: [dpdk-stable] [PATCH v2] lib/bitratestats: fix unchecke

Re: [dpdk-dev] [EXT] [PATCH] eal: promote some experimental functions as stable

2019-04-18 Thread Hemant Agrawal
Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] [PATCH] ethdev: deprecate legacy filter API

2019-04-18 Thread Hemant Agrawal
> drivers/net/dpaa2/dpaa2_flow.c | 1 - > drivers/net/dpaa2/dpaa2_mux.c| 1 - Acked-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-18 Thread Luca Boccassi
On Mon, 2019-04-15 at 19:48 +, Yongseok Koh wrote: > Hi, > > > > Thanks, > Yongseok > > > On Apr 15, 2019, at 3:12 AM, Luca Boccassi < > > bl...@debian.org > > > wrote: > > > > On Fri, 2019-04-12 at 16:24 -0700, Yongseok Koh wrote: > > > If MLNX_OFED is installed, there's no .pc file insta

[dpdk-dev] [PATCH v3] build: mention machine=default and its use in documentation

2019-04-18 Thread luca . boccassi
From: Luca Boccassi Document the new value, as it's useful for distributions and users who need to use a stable baseline -march Signed-off-by: Luca Boccassi Reviewed-by: Christian Ehrhardt Reviewed-by: Jerin Jacob --- v2: fix typo, add commit body and reviewed-by v3: added one more reviewed-b

Re: [dpdk-dev] [PATCH v2] build: mention machine=default and its use in documentation

2019-04-18 Thread Luca Boccassi
On Wed, 2019-04-17 at 22:17 +0200, Thomas Monjalon wrote: > 14/01/2019 14:41, Luca Boccassi: > > Document the new value, as it's useful for distributions and users > > who need to use a stable baseline -march > > > > Signed-off-by: Luca Boccassi < > > bl...@debian.org > > > > > Reviewed-by: Christ

Re: [dpdk-dev] [Bug 248] Bonding PMD: Invalid array dimension in TX burst for 802.3ad mode with fast queue leads to SEGFAULT

2019-04-18 Thread Kevin Traynor
On 15/04/2019 10:50, Przemysław Ołtarzewski wrote: > Hello, > > Last week I attempted to migrate our system from DPDK 18.11.1 to current > master with David's patches applied. I haven't been able to make it work > correctly - probably due to other changes in master since 18.11.1 - so > unfortunate

[dpdk-dev] [PATCH v2] doc/crypto: add release notes and more detailed doc to qat

2019-04-18 Thread Arek Kusztal
This patch adds release notes to 19.05 release document, and more detailed description to Intel QuickAssist Technology driver documentation files for asymmmetric crypto PMD. Signed-off-by: Arek Kusztal --- Note: This patch superseeds "doc/crypto: add supported asymmetric crypto algorithms to qa

Re: [dpdk-dev] [PATCH] eal: promote some experimental functions as stable

2019-04-18 Thread Kevin Traynor
On 18/04/2019 01:30, Thomas Monjalon wrote: > The function rte_eal_cleanup() was introduced more than one year ago, > in DPDK 18.02. It is no longer experimental, allowing > pdump, proc-info and hotplug_mp apps to not need any experimental API. > > The function rte_ctrl_thread_create() was introdu

Re: [dpdk-dev] [PATCH 5/8] ipc: fix pdump memleak

2019-04-18 Thread Pattan, Reshma
> -Original Message- > From: Lipiec, Herakliusz > Sent: Wednesday, April 17, 2019 3:42 PM > To: Pattan, Reshma > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > jianfeng@intel.com; sta...@dpdk.org > Subject: [PATCH 5/8] ipc: fix pdump memleak > > When sending multiple requests, rte_mp_req

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-18 Thread Bruce Richardson
On Thu, Apr 18, 2019 at 10:25:19AM +0100, Luca Boccassi wrote: > On Mon, 2019-04-15 at 19:48 +, Yongseok Koh wrote: > > Hi, > > > > > > > > Thanks, > > Yongseok > > > > > On Apr 15, 2019, at 3:12 AM, Luca Boccassi < > > > bl...@debian.org > > > > wrote: > > > > > > On Fri, 2019-04-12 at 16

Re: [dpdk-dev] ABI and inline functions

2019-04-18 Thread Bruce Richardson
On Thu, Apr 18, 2019 at 04:34:53AM +, Honnappa Nagarahalli wrote: > > > > On Wed, Apr 17, 2019 at 05:12:43AM +, Honnappa Nagarahalli wrote: > > > Hello, > > > There was a conversation [1] in the context of RCU library. I thought > > > it needs participation from broader audience. Summary

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran > wrote: > > >> -Original Message- >> From: Yongseok Koh >> Sent: Thursday, April 18, 2019 7:17 AM >> To: bruce.richard...@intel.com; Jerin Jacob Kollanukkaran >> ; Pavan Nikhilesh Bhagavatula >> ; shah...@mellanox.com >> Cc:

[dpdk-dev] DPDK Release Status Meeting 18/4/2019

2019-04-18 Thread Ferruh Yigit
Minutes 18 April 2019 - Agenda: * Release Dates * RC1 status * Subtrees * OvS * Opens Participants: * Arm * Debian * Intel * Mellanox * RedHat Release Dates - * v19.05 dates, RC2 date pushed to Friday: * RC2: *Friday, 19 April* * RC3: Monday , 29 April *

[dpdk-dev] CALL to eth PMD maintainers: complete closing of port

2019-04-18 Thread Thomas Monjalon
Hi all, Since DPDK 18.11, the behaviour of the close operation is changed if RTE_ETH_DEV_CLOSE_REMOVE is enabled in the driver: port is released (i.e. totally freed and data erased) on close. This new behaviour is enabled per driver for a migration period. Looking at the code, you can see these c

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Thomas Monjalon
18/04/2019 12:41, Yongseok Koh: > > On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran > > wrote: > > From: Yongseok Koh > > Nit: > > [master] [dpdk.org] $ ./devtools/check-git-log.sh > > Wrong headline prefix: > >meson: disable octeontx for buggy compilers on arm64 > > I was aware

Re: [dpdk-dev] [EXT] [PATCH v2 1/4] meson: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 4:04 AM, Thomas Monjalon wrote: > > 18/04/2019 12:41, Yongseok Koh: >>> On Apr 18, 2019, at 12:21 AM, Jerin Jacob Kollanukkaran >>> wrote: >>> From: Yongseok Koh >>> Nit: >>> [master] [dpdk.org] $ ./devtools/check-git-log.sh >>> Wrong headline prefix: >>> meson: dis

Re: [dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 3:14 AM, Bruce Richardson > wrote: > > On Thu, Apr 18, 2019 at 10:25:19AM +0100, Luca Boccassi wrote: >> On Mon, 2019-04-15 at 19:48 +, Yongseok Koh wrote: >>> Hi, >>> >>> >>> >>> Thanks, >>> Yongseok >>> On Apr 15, 2019, at 3:12 AM, Luca Boccassi < bl...@

[dpdk-dev] [PATCH v2 3/9] net/mlx5: add Direct Rules E-Switch support

2019-04-18 Thread Ori Kam
This commit checks the for DR E-Switch support. The support is based on both Device and Kernel. This commit also enables the user to manualy disable this this feature. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/Makefile | 5 + drivers/net/mlx5/meson.bui

[dpdk-dev] [PATCH v2 0/9] net/mlx5: add Direct Verbs E-Switch support

2019-04-18 Thread Ori Kam
Currently MLX5 PMD supports 3 flow engines: Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while the TCF is for E-Switch steering. This series add E-Switch steering support also for the DV engine. In order to support the new capability there should be support from both th

[dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name

2019-04-18 Thread Ori Kam
Modify the translate vport function to match other translate items naming convestions. Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") Cc: viachesl...@mellanox.com Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5_flow_dv.c | 12 ++

[dpdk-dev] [PATCH v2 2/9] net/mlx5: fix meson build for Direct Rules

2019-04-18 Thread Ori Kam
The meson build was missing the define for Direct Rules. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Cc: or...@mellanox.com Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/me

[dpdk-dev] [PATCH v2 5/9] net/mlx5: add port ID item to Direct Verbs

2019-04-18 Thread Ori Kam
Adds the port ID item to the DV steering code. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5_flow_dv.c | 84 ++--- 1 file changed, 61 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/m

[dpdk-dev] [PATCH v2 6/9] net/mlx5: add transfer attribute to matcher

2019-04-18 Thread Ori Kam
In current implementation the DV steering supported only NIC steering. This commit adds the transfer attribute in order to create a matcher on the FDB tabels. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5_flow.c| 1 + drivers/net/mlx5/mlx5_flow.h| 2 ++

[dpdk-dev] [PATCH v2 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

2019-04-18 Thread Ori Kam
This commits adds matching on source port, using DV API. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.h| 12 drivers/net/mlx5/mlx5_flow_dv.c | 149 drivers/net/mlx5

[dpdk-dev] [PATCH v2 4/9] net/mlx5: add validation for Direct Rule E-Switch

2019-04-18 Thread Ori Kam
Add validation logic for E-Switch using Direct Rules. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_ethdev.c | 41 +++ drivers/net/mlx5/mlx5_flow.h| 5 + drivers/net/mlx5/mlx5_flow_dv.c | 243 +

[dpdk-dev] [PATCH v2 8/9] net/mlx5: add Forward Database table type

2019-04-18 Thread Ori Kam
Actions like encap/decap, modify header require setting the flow table type. Until now we supported only Nic RX and Nic TX, this commits adds the support for FDB table type for those actions. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5_flow_dv.c | 56 +

[dpdk-dev] [PATCH v2 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Ori Kam
This commit adds support for drop action when creating E-Switch flow using DV. Signed-off-by: Ori Kam --- v2: * Address ML comments. --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 23 --- drivers/n

Re: [dpdk-dev] [EXT] Re: [PATCH v2 2/4] meson: change default cache line size for armv8

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 1:23 AM, Hemant Agrawal wrote: > >> -Original Message- >> From: dev On Behalf Of Honnappa Nagarahalli >> Sent: Thursday, April 18, 2019 10:31 AM >> To: ys...@mellanox.com; bruce.richard...@intel.com; jer...@marvell.com; >> pbhagavat...@marvell.com; shah...@mellano

[dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

2019-04-18 Thread Igor Russkikh
This patchset implements MACSEC hardware offload configuration in Atlantic PMD via experimental PMD API. There is an agreement to work on 19.08 timeframe for the generic MACSEC API inside of rte_security. v3 changes after Ferruh's comments: - Fixed per-patch build by rearranging patch 2/4. - Adde

[dpdk-dev] [PATCH v3 2/6] net/atlantic: enable macsec configuration

2019-04-18 Thread Igor Russkikh
From: Pavel Belous These are driver macsec configuration routines. They fill in config structures and prepare these to be send to FW. Actual configuration will happen in link interrupt handler. We declare macsec offload bits in DPDK offload capabilities and provide external experimental macsec A

[dpdk-dev] [PATCH v3 1/6] net/atlantic: macsec hardware structures declaration

2019-04-18 Thread Igor Russkikh
From: Pavel Belous Here we define hardware and software configuration structures for macsec interface. MACSEC itself is implemented in Phy module, but its configuration is done via firmware interface Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_types.h

[dpdk-dev] [PATCH v3 4/6] net/atlantic: interrupt handling and macsec configuration

2019-04-18 Thread Igor Russkikh
From: Pavel Belous MACSEC should be configured only after link up event, thus we use link interrupt to file an alarm for configuration. FW also uses link interrupt line to indicate incoming events from MACSEC. These may include key expiration, packet counter wrap, etc. We pass these events to th

[dpdk-dev] [PATCH v3 3/6] net/atlantic: macsec firmware interface

2019-04-18 Thread Igor Russkikh
From: Pavel Belous Implementation of firmware interface for macsec configuration. Structure with config data is written into FW memory, then we trigger FW to execute the request and wait for result. Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_types.h

[dpdk-dev] [PATCH v3 5/6] net/atlantic: implement macsec statistics

2019-04-18 Thread Igor Russkikh
From: Pavel Belous We add extra xstat fields to include macsec counters and stats Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_ethdev.c | 82 +-- 1 file changed, 77 insertions(+), 5 deletions(-) diff --git a/drivers/net/atl

[dpdk-dev] [PATCH v3 6/6] net/atlantic: bump internal driver version

2019-04-18 Thread Igor Russkikh
Version is synced with internal Aquantia's driver versioning Signed-off-by: Pavel Belous Signed-off-by: Igor Russkikh --- drivers/net/atlantic/atl_common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/atlantic/atl_common.h b/drivers/net/atlantic/atl_common.h

Re: [dpdk-dev] [PATCH] doc: add description to release note

2019-04-18 Thread Trahe, Fiona
> -Original Message- > From: Jozwiak, TomaszX > Sent: Thursday, April 18, 2019 8:59 AM > To: dev@dpdk.org; Trahe, Fiona ; Jozwiak, TomaszX > > Subject: [PATCH] doc: add description to release note > > Added description about compression QAT PMD improvement > > Signed-off-by: Tomasz Jo

Re: [dpdk-dev] [PATCH v2] cryptodev: add an option to support both iv and J0 for GCM

2019-04-18 Thread Trahe, Fiona
> -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, April 17, 2019 4:58 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; De Lara > Guarch, Pablo > ; Kusztal, ArkadiuszX > > Subject: [PATCH v2] cryptodev: add an option to support both iv and J0 for GCM >

[dpdk-dev] [PATCH v3 2/4] meson: change default config for armv8

2019-04-18 Thread Yongseok Koh
Current default cache line size for armv8 CPUs having Implementor ID of 0x41 is 128 bytes, changing it to 64 bytes. Also, the max number of lcores is changed to 16 from 256. Signed-off-by: Yongseok Koh --- v3: * decrease RTE_MAX_LCORE to 16 from 256 * change title and commit log v2: * introduce

[dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build

2019-04-18 Thread Yongseok Koh
If MLNX_OFED is installed, there's no .pc file installed for libraries and dependency() can't find libraries by pkg-config. By adding fallback of using cc.find_library(), libraries are properly located. Fixes: e30b4e566f47 ("build: improve dependency handling") Cc: bl...@debian.org Cc: sta...@dpdk

[dpdk-dev] [PATCH v3 1/4] drivers/event: disable octeontx for buggy compilers on arm64

2019-04-18 Thread Yongseok Koh
Disable octeontx for gcc 4.8.5 as compiler is emitting "internal compiler error" for aarch64 Fixes: bd77f2d64c44 ("event/octeontx: build with meson") Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc:

[dpdk-dev] [PATCH v3 4/4] meson: add Mellanox BlueField cross-compile config

2019-04-18 Thread Yongseok Koh
Mellanox BlueField is armv8 CPU having cortex-a72. The implementor ID is 0x41 (arm) and the primary part number is 0xd08 (cortex-a72). Signed-off-by: Yongseok Koh Acked-by: Jerin Jacob --- config/arm/arm64_bluefield_linux_gcc | 16 1 file changed, 16 insertions(+) create mode

Re: [dpdk-dev] [PATCH 2/2] ethdev: promote function for port count as stable

2019-04-18 Thread Ferruh Yigit
On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > The function rte_eth_dev_count_total() was introduced one year ago > in the release 18.05. It can be declared non experimental in 19.05. > > Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

2019-04-18 Thread Ferruh Yigit
On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > Some port iterations are manually checking against RTE_ETH_DEV_UNUSED > instead of using the iterators based on rte_eth_find_next(). > > A new macro RTE_ETH_FOREACH_VALID_DEV() is introduced, but kept private > because there should be no need of iter

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

2019-04-18 Thread Ferruh Yigit
On 4/18/2019 12:39 PM, Igor Russkikh wrote: > This patchset implements MACSEC hardware offload configuration in > Atlantic PMD via experimental PMD API. > > There is an agreement to work on 19.08 timeframe for the generic > MACSEC API inside of rte_security. > > v3 changes after Ferruh's comments

Re: [dpdk-dev] [PATCH v3 3/4] net/mlx: fix library search in meson build

2019-04-18 Thread Luca Boccassi
On Thu, 2019-04-18 at 04:49 -0700, Yongseok Koh wrote: > If MLNX_OFED is installed, there's no .pc file installed for > libraries and > dependency() can't find libraries by pkg-config. By adding fallback > of > using cc.find_library(), libraries are properly located. > > Fixes: e30b4e566f47 ("buil

[dpdk-dev] [PATCH] eventdev: promote adapter functions as stable

2019-04-18 Thread jerinj
From: Jerin Jacob Promote the adapter functions and rte_event_port_unlinks_in_progress() as stable as it's been added for a while now and multiple drivers and test application like test-eventdev has been tested using the adapter APIs. Cc: nikhil@intel.com Cc: erik.g.carri...@intel.com Cc: ab

Re: [dpdk-dev] [PATCH v2 1/9] net/mlx5: fix translate vport function name

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:42AM +, Ori Kam wrote: > Modify the translate vport function to match other translate items > naming convestions. > > Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") > Cc: viachesl...@mellanox.com > > Signed-off-by: Ori Kam You wer

Re: [dpdk-dev] [PATCH v2 2/9] net/mlx5: fix meson build for Direct Rules

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:43AM +, Ori Kam wrote: > The meson build was missing the define for Direct Rules. > > Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") > Cc: or...@mellanox.com > > Signed-off-by: Ori Kam Acked-by: Yongseok Koh > --- > v2: > * Address ML comments. > ---

Re: [dpdk-dev] [PATCH v2 3/9] net/mlx5: add Direct Rules E-Switch support

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:44AM +, Ori Kam wrote: > This commit checks the for DR E-Switch support. > The support is based on both Device and Kernel. > This commit also enables the user to manualy disable this this feature. > > Signed-off-by: Ori Kam > --- Only one minor nit below. With

Re: [dpdk-dev] [PATCH v2] doc/compress: clarify error handling on data-plane

2019-04-18 Thread Shally Verma
Hi Fiona, > -Original Message- > From: Fiona Trahe > Sent: Tuesday, April 9, 2019 8:26 PM > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Ashish Gupta ; > lee.d...@intel.com; Sunila Sahu ; Shally Verma > ; Fiona Trahe ; > sta...@dpdk.org > Subject: [PATCH v2] doc/compress: clarify error ha

Re: [dpdk-dev] [PATCH v2 4/9] net/mlx5: add validation for Direct Rule E-Switch

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:45AM +, Ori Kam wrote: > Add validation logic for E-Switch using Direct Rules. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_ethdev.c | 41

Re: [dpdk-dev] [PATCH v2 5/9] net/mlx5: add port ID item to Direct Verbs

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:46AM +, Ori Kam wrote: > Adds the port ID item to the DV steering code. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 84 > ++--- > 1 file

Re: [dpdk-dev] [PATCH v2 6/9] net/mlx5: add transfer attribute to matcher

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:47AM +, Ori Kam wrote: > In current implementation the DV steering supported only NIC steering. > This commit adds the transfer attribute in order to create a matcher > on the FDB tabels. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Addres

Re: [dpdk-dev] [PATCH v2 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:48AM +, Ori Kam wrote: > This commits adds matching on source port, using DV API. > > Signed-off-by: Ori Kam > --- Acked-by: Yongseok Koh > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.h | 2 + > drivers/net/mlx5/mlx5_flow.h| 12 +

Re: [dpdk-dev] [PATCH v2 8/9] net/mlx5: add Forward Database table type

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:49AM +, Ori Kam wrote: > Actions like encap/decap, modify header require setting the flow table > type. Until now we supported only Nic RX and Nic TX, this commits adds > the support for FDB table type for those actions. > > Signed-off-by: Ori Kam > --- Acked-by

[dpdk-dev] [PATCH] net/atlantic: release note on macsec feature

2019-04-18 Thread Igor Russkikh
Signed-off-by: Igor Russkikh --- doc/guides/rel_notes/release_19_05.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_19_05.rst b/doc/guides/rel_notes/release_19_05.rst index dbdf07a0c05b..94d91bc5d311 100644 --- a/doc/guides/rel_notes/release_19_05.rst +++

Re: [dpdk-dev] [PATCH v2 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Yongseok Koh
On Thu, Apr 18, 2019 at 11:28:50AM +, Ori Kam wrote: > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > --- > v2: > * Address ML comments. > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h |

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

2019-04-18 Thread Igor Russkikh
Hello Ferruh, >> Pavel Belous (5): >> net/atlantic: macsec hardware structures declaration >> net/atlantic: enable macsec configuration >> net/atlantic: macsec firmware interface >> net/atlantic: interrupt handling and macsec configuration >> net/atlantic: implement macsec statistics >

Re: [dpdk-dev] [PATCH v4 1/3] ethdev: add actions to modify TCP header fields

2019-04-18 Thread Adrien Mazarguil
On Wed, Apr 10, 2019 at 02:50:41PM +0300, Dekel Peled wrote: > Add actions: > - INC_TCP_SEQ - Increase sequence number in the outermost TCP header. > - DEC_TCP_SEQ - Decrease sequence number in the outermost TCP header. > - INC_TCP_ACK - Increase acknowledgment number in the outermost TCP >

Re: [dpdk-dev] [PATCH 2/2] ethdev: promote function for port count as stable

2019-04-18 Thread Andrew Rybchenko
On 4/18/19 2:51 PM, Ferruh Yigit wrote: On 4/17/2019 11:59 PM, Thomas Monjalon wrote: The function rte_eth_dev_count_total() was introduced one year ago in the release 18.05. It can be declared non experimental in 19.05. Signed-off-by: Thomas Monjalon Acked-by: Ferruh Yigit Acked-by: Andre

Re: [dpdk-dev] [PATCH] ethdev: deprecate legacy filter API

2019-04-18 Thread Adrien Mazarguil
On Wed, Apr 17, 2019 at 02:36:27AM +0200, Thomas Monjalon wrote: > As stated in the deprecation notice from December 2016, > "the legacy filter API, including rte_eth_dev_filter_supported(), > rte_eth_dev_filter_ctrl() as well as filter types MACVLAN, ETHERTYPE, > FLEXIBLE, SYN, NTUPLE, TUNNEL, FDI

Re: [dpdk-dev] [PATCH v1] doc: fix spelling errors reported by aspell

2019-04-18 Thread Kevin Traynor
On 03/04/2019 14:26, John McNamara wrote: > Signed-off-by: John McNamara > --- > > Some notes on this. > > It is probably best not to apply this patch until just before the release > since it could potentially create a lot of conflicts. I'll resubmit a v2 > prior to the 19.05 release. > > The

Re: [dpdk-dev] [PATCH 1/2] ethdev: avoid explicit check of valid port state

2019-04-18 Thread Thomas Monjalon
18/04/2019 13:50, Ferruh Yigit: > On 4/17/2019 11:59 PM, Thomas Monjalon wrote: > > Some port iterations are manually checking against RTE_ETH_DEV_UNUSED > > instead of using the iterators based on rte_eth_find_next(). > > > > A new macro RTE_ETH_FOREACH_VALID_DEV() is introduced, but kept private

[dpdk-dev] [PATCH] net/mlx4: add support for multicast address list interface

2019-04-18 Thread Adrien Mazarguil
Since this driver does not distinguish unicast/multicast addresses, applications could always rely on the standard MAC add/remove/set interface to configure both types. As a result, the multicast address list interface never got implemented (rte_eth_dev_set_mc_addr_list()) however PMD-agnostic app

[dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Adrien Mazarguil
When passed to the application, Rx packets retain the port ID value originally set by slave devices. Unfortunately these IDs have no meaning to applications, which are typically unaware of their existence. This confuses those caring about the source port field in mbufs (m->port) which experience i

[dpdk-dev] [PATCH v3 4/9] net/mlx5: add validation for Direct Rule E-Switch

2019-04-18 Thread Ori Kam
Add validation logic for E-Switch using Direct Rules. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_ethdev.c | 41 +++ drivers/net/mlx5/mlx5_flow.h| 5 + drivers/net/mlx5/mlx5_flow_dv.c | 243 +++

[dpdk-dev] [PATCH v3 6/9] net/mlx5: add transfer attribute to matcher

2019-04-18 Thread Ori Kam
In current implementation the DV steering supported only NIC steering. This commit adds the transfer attribute in order to create a matcher on the FDB tabels. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow.c| 1 + drivers/net/mlx5/mlx5_flow.h| 2 ++ drive

[dpdk-dev] [PATCH v3 3/9] net/mlx5: add Direct Rules E-Switch support

2019-04-18 Thread Ori Kam
This commit checks the for DR E-Switch support. The support is based on both Device and Kernel. This commit also enables the user to manualy disable this this feature. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- v3: * Add comment to fdb_tbl --- drivers/net/mlx5/Makefile | 5 +

[dpdk-dev] [PATCH v3 1/9] net/mlx5: fix translate vport function name

2019-04-18 Thread Ori Kam
Modify the translate vport function to match other translate items naming convestions. Fixes: 0fe3f18f78d8 ("net/mlx5: add source vport match to the ingress rules") Cc: viachesl...@mellanox.com Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 12 ++--

[dpdk-dev] [PATCH v3 5/9] net/mlx5: add port ID item to Direct Verbs

2019-04-18 Thread Ori Kam
Adds the port ID item to the DV steering code. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 84 ++--- 1 file changed, 61 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/ml

[dpdk-dev] [PATCH v3 0/9] net/mlx5: add Direct Verbs E-Switch support

2019-04-18 Thread Ori Kam
Currently MLX5 PMD supports 3 flow engines: Verbs, Direct Verbs and TCF. The first two engines are for Nic steering while the TCF is for E-Switch steering. This series add E-Switch steering support also for the DV engine. In order to support the new capability there should be support from both th

[dpdk-dev] [PATCH v3 7/9] net/mlx5: add E-Switch port ID action to Direct Verbs

2019-04-18 Thread Ori Kam
This commits adds matching on source port, using DV API. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.h | 2 + drivers/net/mlx5/mlx5_flow.h| 12 drivers/net/mlx5/mlx5_flow_dv.c | 149 drivers/net/mlx5/mlx5_g

[dpdk-dev] [PATCH v3 8/9] net/mlx5: add Forward Database table type

2019-04-18 Thread Ori Kam
Actions like encap/decap, modify header require setting the flow table type. Until now we supported only Nic RX and Nic TX, this commits adds the support for FDB table type for those actions. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 56

[dpdk-dev] [PATCH v3 2/9] net/mlx5: fix meson build for Direct Rules

2019-04-18 Thread Ori Kam
The meson build was missing the define for Direct Rules. Fixes: 4f84a19779ca ("net/mlx5: add Direct Rules API") Cc: or...@mellanox.com Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/mlx5/meson.bu

[dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Ori Kam
This commit adds support for drop action when creating E-Switch flow using DV. Signed-off-by: Ori Kam Acked-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 9 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_dv.c | 22 ++ drivers/net/mlx5/

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Yongseok Koh
> On Apr 18, 2019, at 6:16 AM, Ori Kam wrote: > > This commit adds support for drop action when creating E-Switch flow > using DV. > > Signed-off-by: Ori Kam > Acked-by: Yongseok Koh > --- > drivers/net/mlx5/mlx5.c | 9 + > drivers/net/mlx5/mlx5.h | 1 + > drivers/net/m

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix modify header action position

2019-04-18 Thread Yongseok Koh
> On Apr 17, 2019, at 1:01 PM, Ori Kam wrote: > > According to RTE flow the action order should be the order that the > actions were given. > In the case of modify actions the position of the action was always > last. > > This commit solves this issue by saving the position of the first modify

Re: [dpdk-dev] [PATCH v3 9/9] net/mlx5: add drop action to Direct Verbs E-Switch

2019-04-18 Thread Ori Kam
Hi Shahaf, Can you please fix it when you take it? Thanks, Ori > -Original Message- > From: Yongseok Koh > Sent: Thursday, April 18, 2019 4:23 PM > To: Ori Kam > Cc: Shahaf Shuler ; Matan Azrad > ; Slava Ovsiienko ; Moti > Haimovsky ; dev@dpdk.org > Subject: Re: [PATCH v3 9/9] net/mlx5:

Re: [dpdk-dev] [PATCH v4 1/2] examples/ipsec-secgw: fix 1st packet dropped for inline crypto

2019-04-18 Thread Akhil Goyal
Hi Bernard, > - RTE_LOG_DP(DEBUG, IPSEC, "Create session for SA spi %u on cryptodev " > - "%u qp %u\n", sa->spi, > - ipsec_ctx->tbl[cdev_id_qp].id, > - ipsec_ctx->tbl[cdev_id_qp].qp); > + if ((sa == NULL) || (pool == NUL

Re: [dpdk-dev] [PATCH v3] build: mention machine=default and its use in documentation

2019-04-18 Thread Thomas Monjalon
18/04/2019 11:30, luca.bocca...@gmail.com: > From: Luca Boccassi > > Document the new value, as it's useful for distributions and users > who need to use a stable baseline -march > > Signed-off-by: Luca Boccassi > Reviewed-by: Christian Ehrhardt > Reviewed-by: Jerin Jacob > --- > v2: fix typo

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread David Marchand
Hey Adrien, On Thu, Apr 18, 2019 at 3:12 PM Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuse

Re: [dpdk-dev] [PATCH] net/failsafe: fix source port ID in Rx packets

2019-04-18 Thread Gaëtan Rivet
On Thu, Apr 18, 2019 at 03:11:26PM +0200, Adrien Mazarguil wrote: > When passed to the application, Rx packets retain the port ID value > originally set by slave devices. Unfortunately these IDs have no meaning to > applications, which are typically unaware of their existence. > > This confuses th

Re: [dpdk-dev] [PATCH] power: fix for policy dependency to MAC list

2019-04-18 Thread Hunt, David
Hi Lukasz, On 9/4/2019 10:54 AM, Lukasz Krakowiak wrote: Removed dependency to mac_list from policies: * BRANCH_RATIO, * WORKLOAD, * TIME in function update_policy. Fixes: 1b897991473f ("power: update error handling") Signed-off-by: Lukasz Krakowiak --- examples/vm_power_manager/channel_mon

[dpdk-dev] [pull-request] next-crypto 19.05 rc2

2019-04-18 Thread Akhil Goyal
The following changes since commit 380154406dc8ce6f46a1c3e4e9fced5ba67644a1: build: use default flags for default Arm machine (2019-04-17 22:28:39 +0200) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-crypto for you to fetch changes up to 44bf56300e3f3ed81b6ac2b

Re: [dpdk-dev] [pull-request] next-crypto 19.05 rc2

2019-04-18 Thread Akhil Goyal
Ipsec-secgw patches are breaking the lookaside cases. So pushing them for RC3. > > The following changes since commit > 380154406dc8ce6f46a1c3e4e9fced5ba67644a1: > > build: use default flags for default Arm machine (2019-04-17 22:28:39 +0200) > > are available in the Git repository at: > >

Re: [dpdk-dev] [PATCH v2] examples/vm_power: add conditional compilation for PMD specific code

2019-04-18 Thread Hunt, David
On 2/4/2019 7:46 PM, David Christensen wrote: Running the devtools/test-build.sh script on IBM Power systems fails because the IXGBE_PMD is explicity disabled for Power as an untested driver, but the examples/vm_power_manager application has a hard dependency on a function call in the IXGBE_PMD

Re: [dpdk-dev] [PATCH v3 2/4] meson: change default config for armv8

2019-04-18 Thread Honnappa Nagarahalli
> > Current default cache line size for armv8 CPUs having Implementor ID of > 0x41 is 128 bytes, changing it to 64 bytes. Also, the max number of lcores is > changed to 16 from 256. > > Signed-off-by: Yongseok Koh > --- > > v3: > * decrease RTE_MAX_LCORE to 16 from 256 > * change title and comm

Re: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor

2019-04-18 Thread Dekel Peled
PSB minor comments. > -Original Message- > From: dev On Behalf Of Viacheslav Ovsiienko > Sent: Tuesday, April 16, 2019 5:10 PM > To: dev@dpdk.org > Cc: Shahaf Shuler > Subject: [dpdk-dev] [PATCH v2] net/mlx5: add support for PF representor > > On BlueField platform we have the new entit

Re: [dpdk-dev] [PATCH v3 0/6] add MACSEC hw offload to atlantic PMD

2019-04-18 Thread Ferruh Yigit
On 4/18/2019 12:39 PM, Igor Russkikh wrote: > This patchset implements MACSEC hardware offload configuration in > Atlantic PMD via experimental PMD API. > > There is an agreement to work on 19.08 timeframe for the generic > MACSEC API inside of rte_security. > > v3 changes after Ferruh's comments

  1   2   >