Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-26 Thread David Marchand
Hello Michael, On Thu, Jul 25, 2019 at 11:31 PM Michael Santana wrote: > > This patch reduces the memory footprint of tables for the unit test. > Lower memory footprint means the test now passes when trying to allocate > the tables. This is mainly for tests in CI, might be worth mentionning in t

Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors

2019-07-26 Thread David Marchand
On Thu, Jul 25, 2019 at 9:07 PM David Marchand wrote: > > On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: > > > > On 7/25/2019 10:14 AM, David Marchand wrote: > > > err_pkts reflects the number of packets that the driver did not manage to > > > send. > > > This is a temporary situation, those

[dpdk-dev] [PATCH v2] net/ice: fix LLDP forward

2019-07-26 Thread Wang Ying A
The patch fix the issue that lldp packet can't be forwarded to host. Fixes: 59d151de6673 ("net/ice: stop LLDP by default") Cc: sta...@dpdk.org Signed-off-by: Wang Ying A --- --- V2: Remove redundant macro definiton and function argument; Modify the function name, variables and comments to av

Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for asymmetric crypto

2019-07-26 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Shally Verma [mailto:shal...@marvell.com] > Sent: Friday, July 26, 2019 7:29 AM > To: Kusztal, ArkadiuszX ; Nowak, DamianX > ; dev@dpdk.org > Cc: Trahe, Fiona ; Ayuj Verma > ; Sunila Sahu ; Kanaka Durga > Kotamarthy ; Anoob Joseph > ; Narayana Prasad Raju Ath

[dpdk-dev] [PATCH] app/testpmd: rename ambiguous VF variable

2019-07-26 Thread David Marchand
Caught while looking at the rx offloads code. rx_mode is a global variable for the default rx configuration. Rename the local rx_mode variable in cmd_set_vf_rxmode_parsed. Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-p

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread John Daley (johndale)
Actually, after talking to a couple internal folks, we'd like to get the patch in if possible- many of our customer issues are due to the wrong number of queues, etc, which are reported in the default logs. To ask them to add --log-level=enic,info would be a pain, esp. for apps like OVS, fd.io.

Re: [dpdk-dev] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-26 Thread Dybkowski, AdamX
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Fiona Trahe > Sent: Thursday, 25 July, 2019 19:04 > To: dev@dpdk.org > Cc: akhil.go...@nxp.com; Trahe, Fiona ; > shal...@marvell.com > Subject: [dpdk-dev] [PATCH] compressdev: clarify destination buffer size for > c

[dpdk-dev] [PATCH] doc: announce cpuflags check symbol removal

2019-07-26 Thread David Marchand
This symbol has been deprecated for quite some time. Let's drop it in the next release. Signed-off-by: David Marchand --- doc/guides/rel_notes/deprecation.rst | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index

Re: [dpdk-dev] [PATCH] doc: release note for the IPsec Security Gateway application

2019-07-26 Thread Ananyev, Konstantin
> -Original Message- > From: Iremonger, Bernard > Sent: Thursday, July 25, 2019 4:41 PM > To: dev@dpdk.org; Ananyev, Konstantin ; > akhil.go...@nxp.com; Mcnamara, John > > Cc: Iremonger, Bernard > Subject: [PATCH] doc: release note for the IPsec Security Gateway application > > Updat

Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

2019-07-26 Thread Trahe, Fiona
Hi Adam, > -Original Message- > From: Dybkowski, AdamX > Sent: Thursday, July 25, 2019 3:23 PM > To: Trahe, Fiona ; dev@dpdk.org; akhil.go...@nxp.com > Subject: RE: [PATCH] test/compress: fix coverity warnings > > Hi Fiona. > > > -Original Message- > > From: Trahe, Fiona > > Sent

[dpdk-dev] [PATCH] net/octeontx2: add gre key parsing support

2019-07-26 Thread kirankumark
From: Kiran Kumar K Adding support to parse GRE KEY for octeontx2 Flow. Matching on GRE Key will only work, if checksum and routing bits in the GRE header are equal to 0. Signed-off-by: Kiran Kumar K --- doc/guides/nics/octeontx2.rst | 96 + drivers/net/octeon

[dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
Hi all, While investigating this bug: https://bugs.dpdk.org/show_bug.cgi?id=284 I came across a realization that, when primary process dies, very little actually works. There are some documented issues that are already present when secondary processes keep running, like memory map becoming s

[dpdk-dev] [PATCH v1 01/11] net/ixgbe: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- drivers/net/ixgbe/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/ixgbe/base/README b/drivers/net/ixgbe/base/README index 431be0260..b6b420e2f 100644 --- a/drivers/net/ixgbe/base/README

[dpdk-dev] [PATCH v1 00/11] add SPDX tags to files with Intel copyright

2019-07-26 Thread Xiaolong Ye
This patchset replaces full BSD-3 license header with spdx tag for the remaining files that have Intel copyright. Xiaolong Ye (11): net/ixgbe: replace license text with SPDX tag net/i40e: replace license text with SPDX tag net/e1000: replace license text with SPDX tag net/vmxnet3: replace

[dpdk-dev] [PATCH v1 03/11] net/e1000: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- drivers/net/e1000/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index de1ae4cf7..56738d001 100644 --- a/drivers/net/e1000/base/README

[dpdk-dev] [PATCH v1 02/11] net/i40e: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- drivers/net/i40e/base/README | 34 +++--- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/i40e/base/README b/drivers/net/i40e/base/README index 84f191fad..8a5339cff 100644 --- a/drivers/net/i40e/base/README +++

[dpdk-dev] [PATCH v1 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- drivers/net/vmxnet3/base/README | 34 +++-- 1 file changed, 3 insertions(+), 31 deletions(-) diff --git a/drivers/net/vmxnet3/base/README b/drivers/net/vmxnet3/base/README index 599a3661e..87bcc2216 100644 --- a/drivers/net/vmxnet3/base/

[dpdk-dev] [PATCH v1 05/11] examples/qos_sched: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- examples/qos_sched/profile.cfg| 30 +- examples/qos_sched/profile_ov.cfg | 30 +- 2 files changed, 2 insertions(+), 58 deletions(-) diff --git a/examples/qos_sched/profile.cfg b/examples/qos_sched/profile.

[dpdk-dev] [PATCH v1 06/11] app/test-eventdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- app/test-eventdev/parser.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/app/test-eventdev/parser.c b/app/test-eventdev/parser.c index 9de41bf4a..28e25312b 100644 --- a/app/test-eventdev/parser.c +++ b/app/t

[dpdk-dev] [PATCH v1 10/11] hash: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- lib/librte_hash/rte_jhash.h | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/lib/librte_hash/rte_jhash.h b/lib/librte_hash/rte_jhash.h index 42c45685b..bfb2bc196 100644 --- a/lib/librte_hash/rte_jhash.h +++ b/lib

[dpdk-dev] [PATCH v1 07/11] ethdev: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- lib/librte_ethdev/rte_mtr.h | 36 lib/librte_ethdev/rte_tm.h | 37 - 2 files changed, 8 insertions(+), 65 deletions(-) diff --git a/lib/librte_ethdev/rte_mtr.h b/lib/librte_ethdev/rte_mtr.h i

[dpdk-dev] [PATCH v1 08/11] lpm: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- lib/librte_lpm/rte_lpm_neon.h | 39 +++ 1 file changed, 3 insertions(+), 36 deletions(-) diff --git a/lib/librte_lpm/rte_lpm_neon.h b/lib/librte_lpm/rte_lpm_neon.h index 28c815902..7d2f76323 100644 --- a/lib/librte_lpm/rte_lpm_neon.h

[dpdk-dev] [PATCH v1 11/11] eal: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- .../common/include/arch/x86/rte_atomic_32.h | 33 ++- .../common/include/arch/x86/rte_atomic_64.h | 33 ++- lib/librte_eal/common/include/rte_keepalive.h | 32 ++ lib/librte_eal/freebsd/BSDmakefile.meson | 31

[dpdk-dev] [PATCH v1 09/11] port: replace license text with SPDX tag

2019-07-26 Thread Xiaolong Ye
Signed-off-by: Xiaolong Ye --- lib/librte_port/rte_port_kni.c | 35 +++--- lib/librte_port/rte_port_kni.h | 35 +++--- 2 files changed, 6 insertions(+), 64 deletions(-) diff --git a/lib/librte_port/rte_port_kni.c b/lib/librte_port/rte_port_

Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-26 Thread Dumitrescu, Cristian
> -Original Message- > From: Michael Santana [mailto:msant...@redhat.com] > Sent: Thursday, July 25, 2019 10:32 PM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Michael Santana > Francisco > Subject: [PATCH] test/table_autotest: Decrease memory requirement > > This patch reduces the

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Bruce Richardson
On Fri, Jul 26, 2019 at 10:05:02AM +0100, Burakov, Anatoly wrote: > Hi all, > > While investigating this bug: > > https://bugs.dpdk.org/show_bug.cgi?id=284 > > I came across a realization that, when primary process dies, very little > actually works. There are some documented issues that are alr

Re: [dpdk-dev] [PATCH v1 00/11] add SPDX tags to files with Intel copyright

2019-07-26 Thread Bruce Richardson
On Fri, Jul 26, 2019 at 05:29:30PM +0800, Xiaolong Ye wrote: > This patchset replaces full BSD-3 license header with spdx tag for the > remaining files that have Intel copyright. > > Xiaolong Ye (11): > net/ixgbe: replace license text with SPDX tag > net/i40e: replace license text with SPDX ta

Re: [dpdk-dev] [PATCH] app/testpmd: rename ambiguous VF variable

2019-07-26 Thread Iremonger, Bernard
> -Original Message- > From: David Marchand [mailto:david.march...@redhat.com] > Sent: Friday, July 26, 2019 9:00 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > ; Iremonger, Bernard > > Subject: [PATCH] app/testpmd: rename ambiguous VF variable > > Caught while

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Friday, July 26, 2019 10:40 AM > To: Burakov, Anatoly > Cc: dev@dpdk.org; Thomas Monjalon > Subject: Re: [dpdk-dev] Should we disallow running secondaries after primary > has died? >

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 5:21 AM, Hyong Youb Kim (hyonkim) wrote: >> -Original Message- >> From: John Daley (johndale) >> Sent: Friday, July 26, 2019 5:26 AM >> To: Ferruh Yigit >> Cc: dev@dpdk.org; Hyong Youb Kim (hyonkim) >> Subject: RE: [PATCH] net/enic: retain previous message logging >> >> Ok, l

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 10:50 AM, Ananyev, Konstantin wrote: -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson Sent: Friday, July 26, 2019 10:40 AM To: Burakov, Anatoly Cc: dev@dpdk.org; Thomas Monjalon Subject: Re: [dpdk-dev] Should we disallow running se

Re: [dpdk-dev] [PATCH] net/enic: retain previous message logging

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 9:17 AM, John Daley (johndale) wrote: > Actually, after talking to a couple internal folks, we'd like to get the > patch in if possible- many of our customer issues are due to the wrong number > of queues, etc, which are reported in the default logs. To ask them to add > --log-level

Re: [dpdk-dev] [PATCH v1 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 10:29 AM, Xiaolong Ye wrote: > Signed-off-by: Xiaolong Ye > --- > drivers/net/vmxnet3/base/README | 34 +++-- > 1 file changed, 3 insertions(+), 31 deletions(-) > > diff --git a/drivers/net/vmxnet3/base/README b/drivers/net/vmxnet3/base/README > index 599

Re: [dpdk-dev] [PATCH v1] examples/power: fix oob frequency oscillations

2019-07-26 Thread Burakov, Anatoly
On 24-Jul-19 2:18 PM, David Hunt wrote: The branch ratio algorithm in the vm_power_manager sample application can be very sensitive at patricular loads in a workload, causing oscillations between min and max frequency. For example, if a workload is at 50%, scaling up may change the ratio enough t

Re: [dpdk-dev] [PATCH v1 11/11] eal: replace license text with SPDX tag

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 10:29 AM, Xiaolong Ye wrote: > Signed-off-by: Xiaolong Ye <...> > @@ -1,33 +1,5 @@ > -/*- > - * BSD LICENSE > - * > - * Copyright 2015-2016 Intel Shannon Ltd. All rights reserved. > - * > - * Redistribution and use in source and binary forms, with or without > - * modificati

Re: [dpdk-dev] [PATCH v1 11/11] eal: replace license text with SPDX tag

2019-07-26 Thread Bruce Richardson
On Fri, Jul 26, 2019 at 11:15:00AM +0100, Ferruh Yigit wrote: > On 7/26/2019 10:29 AM, Xiaolong Ye wrote: > > Signed-off-by: Xiaolong Ye > > <...> > > > @@ -1,33 +1,5 @@ > > -/*- > > - * BSD LICENSE > > - * > > - * Copyright 2015-2016 Intel Shannon Ltd. All rights reserved. > > - * > > - *

Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 8:24 AM, David Marchand wrote: > On Thu, Jul 25, 2019 at 9:07 PM David Marchand > wrote: >> >> On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: >>> >>> On 7/25/2019 10:14 AM, David Marchand wrote: err_pkts reflects the number of packets that the driver did not manage to

[dpdk-dev] [PATCH v2 3/9] net/null: remove unused Tx error counter

2019-07-26 Thread David Marchand
This Tx counter has never been used. Fixes: c743e50c475f ("null: new poll mode driver") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/null/

Re: [dpdk-dev] [RFC,v2] ethdev: extend RSS offload types

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 1:35 AM, simei wrote: > From: Simei Su > > This RFC reserves several bits as input set selection from bottom > of the 64 bits. The flow type is combined with input set to > represent rss types. > > Correct the input set mask to align with the definition in rte_ethdev.h. > for exampl

[dpdk-dev] [PATCH v2 1/9] net/af_packet: remove unused Rx counter

2019-07-26 Thread David Marchand
This Rx counter has never been used. Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Ferruh Yigit --- drivers/net/af_packet/rte_eth_af_packet.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[dpdk-dev] [PATCH v2 4/9] net/virtio: remove unused Tx error counter

2019-07-26 Thread David Marchand
This Tx counter has never been used. Fixes: 9658d17da27b ("virtio: maintain stats per queue") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-by: Tiwei Bie --- drivers/net/virtio/virtio_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c

[dpdk-dev] [PATCH v2 2/9] net/af_xdp: remove unused Tx counter

2019-07-26 Thread David Marchand
This Tx counter is now unused. Fixes: 10edf857fde4 ("net/af_xdp: make reserve/submit peek/release consistent") Signed-off-by: David Marchand Reviewed-by: Xiaolong Ye --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c

[dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds

2019-07-26 Thread David Marchand
I did a pass on the pmds about oerrors some time ago, but still did not find the motivation to finish yet. For now, here is a series of cleanups on the virtual pmds. The former patches are just about removing counters that adds nothing to the stats. The latter patches make sure that unsent packet

[dpdk-dev] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter

2019-07-26 Thread David Marchand
The delta between what the application asked to receive and what was indeed received, can not be called an error counter. This counter is not reported anywhere, remove it. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/kni/rte_eth_

[dpdk-dev] [PATCH v2 8/9] net/ring: do not count unsent packets as errors

2019-07-26 Thread David Marchand
err_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: e1e4017751f1 ("ring: add new driver") Cc: sta...@

[dpdk-dev] [PATCH v2 6/9] net/kni: do not count unsent packets as errors

2019-07-26 Thread David Marchand
err_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") Cc: sta...@

[dpdk-dev] [PATCH v2 9/9] net/vhost: do not count unsent packets as errors

2019-07-26 Thread David Marchand
missed_pkts reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 5f05e95cd5d9 ("net/vhost: fix Tx error countin

[dpdk-dev] [PATCH v2 7/9] net/memif: do not count unsent packets as errors

2019-07-26 Thread David Marchand
n_err reflects the number of packets that the driver did not manage to send. This is a temporary situation, those packets are not freed and the application can still retry to send them later. Hence, we can't count them as transmit failed. Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-26 Thread Akhil Goyal
Hi Bernard, > > Update release notes for changes to the IPsec library. > > Signed-off-by: Bernard Iremonger > --- > changes in v3: > revised content > > doc/guides/rel_notes/release_19_08.rst | 8 > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/release_19_08.

Re: [dpdk-dev] [PATCH v3] doc: release note for the IPsec library

2019-07-26 Thread Iremonger, Bernard
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 26, 2019 11:27 AM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; Mcnamara, John > > Subject: RE: [PATCH v3] doc: release note for the IPsec library > > Hi Bernard, > >

Re: [dpdk-dev] [EXT] Re: [PATCH v2] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: David Christensen > Sent: Friday, July 26, 2019 3:36 AM > To: Jerin Jacob Kollanukkaran ; Bruce Richardson > ; hgovindh > > Cc: Remy Horton ; Marko Kovacevic > ; Ori Kam ; Pablo de > Lara ; Radu Nicolau > ; Akhil Goyal ; Tomasz > Kantecki ; dev@dpdk.org; > m

[dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Bernard Iremonger
Update release notes for changes to the IPsec library. Update release notes for changes to the IPsec Security Gateway application Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_19_08.rst | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/doc

Re: [dpdk-dev] [PATCH BUG 335 3/3] net/virtio: fix compilation error with 0 headroom

2019-07-26 Thread Olivier Matz
Hi, On Thu, Jul 25, 2019 at 04:36:45PM +0530, Hemant Agrawal wrote: > When using RTE_PKTMBUF_HEADROOM as 0, virito ethdev driver throws > compilation error > virtio_ethdev.c:1851:2: note: in expansion of macro ‘RTE_BUILD_BUG_ON’ > RTE_BUILD_BUG_ON(RTE_PKTMBUF_HEADROOM > < sizeof(struct virti

Re: [dpdk-dev] [PATCH] app/crypto-perf: disable asymmetric crypto

2019-07-26 Thread Akhil Goyal
> > > > Asymmetric crypto is not required for test-crypto-perf application. > > Disabling the feature using 'ff_disable' field. > > > > Signed-off-by: Anoob Joseph > Acked-by: Fiona Trahe Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH] test/compress: fix coverity warnings

2019-07-26 Thread Akhil Goyal
> > > > > > > > CID 340857: Null pointer dereferences (NULL_RETURNS) > > > > > > > > CID 340856: (CONSTANT_EXPRESSION_RESULT) > > > > > > > > Fixes: 3be12ea52ad8 ("test/compress: improve debug trace setup") > > > > > > > > Signed-off-by: Adam Dybkowski > > > > --- > > > > app/test/test_compressde

Re: [dpdk-dev] [PATCH v7 1/1] app/test-compress-perf: provide more detailed report

2019-07-26 Thread Akhil Goyal
> > > > From: Artur Trybula > > > > This patch adds extra features to the compress performance > > test. Some important parameters (memory allocation, > > number of ops, number of segments) are calculated and > > printed out. > > Information about threads, cores, devices and queue-pairs > > is als

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > Update release notes for changes to the IPsec library. > Update release notes for changes to the IPsec Security Gateway application Description and the release note updates use redundant words which can be avoided. It could be something like "Update release notes for recently supported fe

Re: [dpdk-dev] [PATCH] compressdev: clarify destination buffer size for corner case

2019-07-26 Thread Akhil Goyal
Hi Shally, > > > > Clarify the corner case with incompressible data whereby the output can > > actually be greater than the uncompressed data. > > > > Signed-off-by: Fiona Trahe > > --- > > Acked-by: Adam Dybkowski Are you Ok with this change at this point in lib? Normally no change is accept

Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow

2019-07-26 Thread Trahe, Fiona
> -Original Message- > From: Dybkowski, AdamX > Sent: Tuesday, July 23, 2019 10:53 AM > To: dev@dpdk.org; Trahe, Fiona ; akhil.go...@nxp.com > Cc: Dybkowski, AdamX > Subject: [PATCH] app/compress-perf: prevent output buffer overflow > > This patch fixes the issue of memory overwrite af

Re: [dpdk-dev] [PATCH v4] doc: release note for the IPsec library and application

2019-07-26 Thread Iremonger, Bernard
Hi Akhil, > -Original Message- > From: Akhil Goyal [mailto:akhil.go...@nxp.com] > Sent: Friday, July 26, 2019 1:36 PM > To: Iremonger, Bernard ; dev@dpdk.org; > Ananyev, Konstantin ; Mcnamara, John > ; Zhang, Roy Fan > Subject: RE: [PATCH v4] doc: release note for the IPsec library and >

Re: [dpdk-dev] [PATCH v2 5/9] net/kni: remove unused Rx "error" counter

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > The delta between what the application asked to receive and what was > indeed received, can not be called an error counter. > This counter is not reported anywhere, remove it. > > Fixes: 75e2bc54c018 ("net/kni: add KNI PMD") > Cc: sta...@dpdk.org > >

Re: [dpdk-dev] [PATCH v2 6/9] net/kni: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. >

Re: [dpdk-dev] [PATCH v2 7/9] net/memif: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > n_err reflects the number of packets that the driver did not manage to > send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. > >

Re: [dpdk-dev] [PATCH v2 8/9] net/ring: do not count unsent packets as errors

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > err_pkts reflects the number of packets that the driver did not manage > to send. > This is a temporary situation, those packets are not freed and the > application can still retry to send them later. > Hence, we can't count them as transmit failed. >

[dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [PATCH v2 0/9] oerrors stats fixes for virtual pmds

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 11:21 AM, David Marchand wrote: > I did a pass on the pmds about oerrors some time ago, but still did not > find the motivation to finish yet. > For now, here is a series of cleanups on the virtual pmds. > > The former patches are just about removing counters that adds nothing to > th

Re: [dpdk-dev] [PATCH v1 04/11] net/vmxnet3: replace license text with SPDX tag

2019-07-26 Thread Ye Xiaolong
On 07/26, Ferruh Yigit wrote: >On 7/26/2019 10:29 AM, Xiaolong Ye wrote: >> Signed-off-by: Xiaolong Ye >> --- >> drivers/net/vmxnet3/base/README | 34 +++-- >> 1 file changed, 3 insertions(+), 31 deletions(-) >> >> diff --git a/drivers/net/vmxnet3/base/README >> b/dr

Re: [dpdk-dev] [PATCH v3] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 2:27 PM, hgovindh wrote: Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: s

Re: [dpdk-dev] [PATCH v3 1/1] app/test: fix --socket-mem option in eal flag autotest

2019-07-26 Thread David Marchand
Hello, On Fri, Jul 12, 2019 at 8:43 AM wrote: > > From: Vamsi Attunuru > > eal flag autotest fails when multiple mem size flags are passed > to --socket-mem option irrespective of RTE_MAX_NUMA_NODES. > > Patch fixes --socket-mem option by setting enough numbers > of numa node mem flags based on

Re: [dpdk-dev] [PATCH] examples: modify error message for ip pipeline

2019-07-26 Thread Babu Radhakrishnan, AgalyaX
Hi, > -Original Message- > From: Dumitrescu, Cristian > Sent: Tuesday, July 9, 2019 3:01 PM > To: Babu Radhakrishnan, AgalyaX ; > dev@dpdk.org > Cc: Pattan, Reshma > Subject: RE: [PATCH] examples: modify error message for ip pipeline > > > > > -Original Message- > > From: Babu

[dpdk-dev] [PATCH] cryptodev: fix typo

2019-07-26 Thread Ferruh Yigit
Remove extra ';' which is probably added unintentionally, reported by ./devtools/check-includes.sh script. Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- lib/librte_cryptodev/rte_crypto_asym.h | 2 +- 1 file changed

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > Update release notes for recently supported features in IPsec library and > IPsec Security Gateway application. > > Signed-off-by: Bernard Iremonger > --- > doc/guides/rel_notes/release_19_08.rst | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > Acked-by: Akhil Goya

Re: [dpdk-dev] [PATCH] doc: announce cpuflags check symbol removal

2019-07-26 Thread Aaron Conole
David Marchand writes: > This symbol has been deprecated for quite some time. > Let's drop it in the next release. > > Signed-off-by: David Marchand > --- I don't know how many out-of-tree users there are. OVS doesn't use this symbol - and a brief look at github (first 25 pages of results) sho

[dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Bernard Iremonger
Update release notes for recently supported features in IPsec library and IPsec Security Gateway application. Signed-off-by: Bernard Iremonger --- doc/guides/rel_notes/release_19_08.rst | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/doc/guides/rel_notes/release

Re: [dpdk-dev] [PATCH] eal: resort symbols in EXPERIMENTAL section

2019-07-26 Thread David Marchand
On Thu, Jun 20, 2019 at 7:23 PM David Marchand wrote: > > > > On Fri, Jun 14, 2019 at 5:32 PM Ferruh Yigit wrote: >> >> On 6/14/2019 8:44 AM, David Marchand wrote: >> > On Fri, Jun 14, 2019 at 9:39 AM Thomas Monjalon >> > wrote: >> > >> >> 06/04/2019 05:30, Stephen Hemminger: >> >>> The symbols

[dpdk-dev] [PATCH] eal: order experimental symbols per release

2019-07-26 Thread David Marchand
Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- lib/librte_eal/rte_eal_version.map | 110 + 1 file changed, 62 insertions(+), 48 deletions(-) diff --git a/lib/librte_eal

Re: [dpdk-dev] [PATCH v5] doc: release note for the IPsec library and application

2019-07-26 Thread Akhil Goyal
> > > > Update release notes for recently supported features in IPsec library and > > IPsec Security Gateway application. > > > > Signed-off-by: Bernard Iremonger > > --- > > doc/guides/rel_notes/release_19_08.rst | 13 + > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > Ack

Re: [dpdk-dev] [PATCH v1] test/crypto: improve asymmetric crypto testsuite setup

2019-07-26 Thread Akhil Goyal
> > Improve logic: > * to get list of valid devices based on driver id so that to > eliminate unnecessary if check for driver id match in device loop > * loop till 1st device supporting asymmetric feature is found unlike > previous logic which breaks on 1st device > > Signed-off-by:

Re: [dpdk-dev] [PATCH] compress/zlib: fix coverity warning

2019-07-26 Thread Akhil Goyal
> Add missing return after setting the error status in case of > invalid flush_flag in the operation. > The issue was found by the coverity scan as the fin_flush variable, > not initialized in such case, was used later in the flow. > > CID 340859: Uninitialized variables (UNINIT) > > Fixes: c

[dpdk-dev] [PATCH v4] examples/l3fwd: fix unaligned memory access

2019-07-26 Thread hgovindh
Fix unaligned memory access when reading IPv6 header which leads to segmentation fault by changing aligned memory read to unaligned memory read. Bugzilla ID: 279 Fixes: 64d3955de1de ("examples/l3fwd: fix ARM build") Cc: maciej.cze...@caviumnetworks.com Cc: sta...@dpdk.org Signed-off-by: hgovindh

Re: [dpdk-dev] [PATCH] app/compress-perf: prevent output buffer overflow

2019-07-26 Thread Akhil Goyal
> > > > This patch fixes the issue of memory overwrite after the end of > > the output buffer by calculating its size as the number of all > > segments multipled by the output segment size. > > Additionally buffer overflow errors returned by PMD driver are > > detected and shown, ending the test.

Re: [dpdk-dev] [PATCH] eal: order experimental symbols per release

2019-07-26 Thread David Marchand
On Fri, Jul 26, 2019 at 3:52 PM David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Rebase damage... v2 in progress, sorry. -- David Marchand

Re: [dpdk-dev] [PATCH] cryptodev: fix typo

2019-07-26 Thread Akhil Goyal
> > Remove extra ';' which is probably added unintentionally, reported by > ./devtools/check-includes.sh script. > > Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > lib/librte_cryptodev/rte_crypto_asym.h

[dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread David Marchand
Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- Changelog since v1: - rte_service symbols who got promoted to stable got reintroduced in experimental when rebasing this patch on master --- lib/librte_eal

Re: [dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-26 Thread Akhil Goyal
Hi Anoob, Could you please Ack this patch if there is no issue? Thanks, Akhil > +Anoob, Jerin > > > > > All the functionality of the legacy code path in now available in > > the librte_ipsec library. It is planned to deprecate the legacy > > code path in the 19.11 release and remove the legacy

[dpdk-dev] [PATCH] security: remove duplicated symbols from map file

2019-07-26 Thread Ferruh Yigit
Fixes: f63ffee26f9c ("security: restore experimental tag for unimplemented APIs") Cc: sta...@dpdk.org Signed-off-by: Ferruh Yigit --- lib/librte_security/rte_security_version.map | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/librte_security/rte_security_version.map b/lib/librte_sec

Re: [dpdk-dev] [PATCH] security: remove duplicated symbols from map file

2019-07-26 Thread Akhil Goyal
> > Fixes: f63ffee26f9c ("security: restore experimental tag for unimplemented > APIs") > Cc: sta...@dpdk.org > > Signed-off-by: Ferruh Yigit > --- > lib/librte_security/rte_security_version.map | 3 --- > 1 file changed, 3 deletions(-) > Good fix, Not sure how it went unnoticed. Acked-by:

Re: [dpdk-dev] [EXT] [PATCH] doc: deprecate legacy code path in ipsec-secgw

2019-07-26 Thread Anoob Joseph
> -Original Message- > From: dev On Behalf Of Bernard Iremonger > Sent: Wednesday, July 24, 2019 3:43 PM > To: dev@dpdk.org; konstantin.anan...@intel.com; akhil.go...@nxp.com > Cc: Bernard Iremonger > Subject: [EXT] [dpdk-dev] [PATCH] doc: deprecate legacy code path in ipsec- > secgw > >

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread David Marchand
Thomas, On Fri, Jul 26, 2019 at 4:06 PM David Marchand wrote: > > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand > --- > Changelog since v1: > - rte_service symbols who got promoted to stable got reintro

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Stephen Hemminger
On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: > > > > NP to disallow it. > > In fact, I think it would be easier for everyone just to drop current DPDK > > MP model, > > and keep just standalone DPDK instances. > > That's the dream, but i don't think it'll ever come to fruitio

Re: [dpdk-dev] [PATCH v3] eal: pick IOVA as PA if IOMMU is not available

2019-07-26 Thread Jerin Jacob Kollanukkaran
> -Original Message- > From: Anatoly Burakov > Sent: Thursday, July 25, 2019 4:36 PM > To: dev@dpdk.org > Cc: John McNamara ; Marko Kovacevic > ; dariusz.stojac...@intel.com; > tho...@monjalon.net; david.march...@redhat.com; Jerin Jacob > Kollanukkaran > Subject: [EXT] [PATCH v3] eal: pic

Re: [dpdk-dev] [PATCH] test/table_autotest: Decrease memory requirement

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 3:09 AM, David Marchand wrote: Hello Michael, On Thu, Jul 25, 2019 at 11:31 PM Michael Santana wrote: This patch reduces the memory footprint of tables for the unit test. Lower memory footprint means the test now passes when trying to allocate the tables. This is mainly for tests i

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread Ferruh Yigit
On 7/26/2019 3:06 PM, David Marchand wrote: > Sort the experimental symbols per release to make it easier/quicker to > check for how long we have them. > > Signed-off-by: David Marchand Acked-by: Ferruh Yigit

[dpdk-dev] [PATCH v4] eal: pick IOVA as PA if IOMMU is not available

2019-07-26 Thread Anatoly Burakov
When IOMMU is not available, /sys/kernel/iommu_groups will not be populated. This is happening since at least 3.6 when VFIO support was added. If the directory is empty, EAL should not pick IOVA as VA as the default IOVA mode. Signed-off-by: Anatoly Burakov Tested-by: Darek Stojaczyk Tested-by:

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: NP to disallow it. In fact, I think it would be easier for everyone just to drop current DPDK MP model, and keep just standalone DPDK instances. That's the dream, but i don't think i

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Lipiec, Herakliusz
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly > On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: > > On Fri, 26 Jul 2019 10:53:58 +0100 > > "Burakov, Anatoly" wrote: > > > >>> > >>> NP to disallow it. > >>> In fact, I think it would be easier for everyone just to drop > >

Re: [dpdk-dev] Should we disallow running secondaries after primary has died?

2019-07-26 Thread Burakov, Anatoly
On 26-Jul-19 4:56 PM, Lipiec, Herakliusz wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Burakov, Anatoly On 26-Jul-19 4:01 PM, Stephen Hemminger wrote: On Fri, 26 Jul 2019 10:53:58 +0100 "Burakov, Anatoly" wrote: NP to disallow it. In fact, I think it would be easier for ever

Re: [dpdk-dev] [PATCH v2] eal: sort experimental symbols per release

2019-07-26 Thread Michael Santana Francisco
On 7/26/19 10:06 AM, David Marchand wrote: Sort the experimental symbols per release to make it easier/quicker to check for how long we have them. Signed-off-by: David Marchand --- Changelog since v1: - rte_service symbols who got promoted to stable got reintroduced in experimental when reba

[dpdk-dev] [PATCH] net/kni: remove resources when port is closed

2019-07-26 Thread Ferruh Yigit
Add .dev_close to clean resources on device close, also set RTE_ETH_DEV_CLOSE_REMOVE device flag to cause all ethdev resources removed on 'rte_eth_dev_close()' call. Signed-off-by: Ferruh Yigit --- drivers/net/kni/rte_eth_kni.c | 38 +++ 1 file changed, 25 inserti

[dpdk-dev] [PATCH v2 0/2] mk: fix build with shared library

2019-07-26 Thread Stephen Hemminger
If RTE_BUILD_SHARED_LIB is enabled, infrastruture libraries that use registration API's need to always be included. v2 - fix typo in Cc: for second patch Stephen Hemminger (2): bus: fix missing pci bus with shared library build mk: fix missing mempool driver registration mk/rte.app.mk | 9 +

  1   2   >