Re: [dpdk-dev] [PATCH] net/mlx5: add GTP item support

2020-01-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Thursday, January 16, 2020 8:36 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: Raslan Darawsheh ; Ori Kam > ; dev@dpdk.org > Subject: [PATCH] net/mlx5: add GTP item support > > This patch adds to MLX5 PMD support of matching on GTP it

[dpdk-dev] [PATCH] tap: fix memory leak when unregister intr handler

2020-01-20 Thread Yunjian Wang
The return check of function tap_lsc_intr_handle_set() is wrong, it should be 0 or a positive number if success. So the intr_handle->intr_vec was not been freed when tap_lsc_intr_handle_set() returned a positive number. Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt") Cc: sta...@dpdk.org Sig

[dpdk-dev] [PATCH] net/tap: fix memory leak when unregister intr handler

2020-01-20 Thread Yunjian Wang
The return check of function tap_lsc_intr_handle_set() is wrong, it should be 0 or a positive number if success. So the intr_handle->intr_vec was not been freed when tap_lsc_intr_handle_set() returned a positive number. Fixes: 4870a8cdd968 ("net/tap: support Rx interrupt") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH v5 0/6] OCTEON TX2 End Point Driver

2020-01-20 Thread Thomas Monjalon
13/01/2020 07:00, Mahipal Challa: > This patchset adds support for OCTEON TX2 end point mode of operation. > The driver implementation uses DPDK rawdevice sub-system. > > v2: > * Updated memory barrier API's as per Gavin Hu suggestion. > > v3: > * Fixed memory leak possibility issues. > > v4: >

Re: [dpdk-dev] [dpdk-stable] [PATCH] usertools: add telemetry python3 compatibility

2020-01-20 Thread Robin Jarry
16/01/2020 18:24, Ciara Power: > The client script for use with the telemetry library did not support > python3, as the data being sent over the socket was in string format. > Python3 requires the data be explicitly converted to bytes before being > sent. Similarily, the received bytes need to be

Re: [dpdk-dev] [PATCH] raw/ntb: fix write memory barrier issue

2020-01-20 Thread Thomas Monjalon
26/12/2019 02:46, Wu, Jingjing: > From: Li, Xiaoyun > > All buffers and ring info should be written before tail register update. > > This patch relocates the write memory barrier before updating tail register > > to avoid potential issues. > > > > Fixes: 11b5c7daf019 ("raw/ntb: add enqueue and de

Re: [dpdk-dev] [PATCH] doc: fix a typo in ntb guide

2020-01-20 Thread Thomas Monjalon
23/12/2019 03:39, Wu, Jingjing: > From: Li, Xiaoyun > > In prerequisites of ntb guide, the correct flag when loading igb_uio > > module should be `wc_activate=1`, not `wc_active=1`. > > > > Fixes: 11b5c7daf019 ("raw/ntb: add enqueue and dequeue functions") > > Cc: sta...@dpdk.org > > > > Signed-

Re: [dpdk-dev] [dpdk-stable] [PATCH] examples/ntb: fix mempool ops setting issue

2020-01-20 Thread Thomas Monjalon
25/12/2019 10:09, Xiaoyun Li: > Mempool ops may register in different order when compiling. The default > ops index is always zero but the wanted ops is ring_mp_mc. This patch > sets best mempool ops before generating mbuf pool to fix this issue. > > Fixes: 5194299d6ef5 ("examples/ntb: support mor

[dpdk-dev] [PATCH v3] net/mlx5: fix modify actions support limitation

2020-01-20 Thread Bing Zhao
In the root table, there is some limitation of total number of header modify actions, 16 or 8 for each. But in other tables, there is no such strict limitation. In an IPv6 case, the IP fields modifying will occupy more actions than that in IPv4, so the total support number should be increased in or

Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to use one rte flow

2020-01-20 Thread Thomas Monjalon
10/12/2019 21:47, Ori Kam: > > > -Original Message- > > Subject: Re: [dpdk-dev] [PATCH] ethdev: allow multiple security sessions to > > use one rte flow > > > > On Sun, Dec 8, 2019 at 4:19 PM Anoob Joseph wrote: > > > > > > The rte_security API which enables inline protocol/crypto featur

Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

2020-01-20 Thread Rao, Nikhil
> -Original Message- > From: Thomas Monjalon > Sent: Monday, January 20, 2020 3:20 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Rao, Nikhil ; Chas Williams > ; Richardson, Bruce ; > Stephen Hemminger ; Pattan, Reshma > > Subject: Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring

Re: [dpdk-dev] [PATCH v6 0/3] Refactor crypto unit tests.

2020-01-20 Thread Akhil Goyal
Hi Adam, > > This patch set is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit te

Re: [dpdk-dev] [PATCH] mempool: fix anonymous populate

2020-01-20 Thread Thomas Monjalon
17/01/2020 15:34, Olivier Matz: > The documentation says that a negative errno is returned on error, but > in most places that's not the case. > > Fix the documentation and the exceptions in code. The second one > (return from populate_virt) also fixes a memory leak. > > Note that testpmd was usi

Re: [dpdk-dev] [PATCH v2] mempool: fix slow allocation of large mempools

2020-01-20 Thread Thomas Monjalon
17/01/2020 11:09, Andrew Rybchenko: > On 1/17/20 1:01 PM, Olivier Matz wrote: > > On Fri, Jan 17, 2020 at 10:51:49AM +0100, Olivier Matz wrote: > >> When allocating a mempool which is larger than the largest > >> available area, it can take a lot of time: > >> > >> a- the mempool calculate the requ

Re: [dpdk-dev] [PATCH v4] net/axgbe: add a HW quirk for register definitions

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 12:41 PM, Selwin Sebastian wrote: > V1000/R1000 processors are using the same PCI ids for the network > device as SNOWYOWL processor but has altered register definitions > for determining the window settings for the indirect PCS access. > Add support to check for this hardware and if f

Re: [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 11:05 AM, Thomas Monjalon wrote: > The version of the PMD should not be overwritten with LIBABIVER. > All internal libs must have the same version. > > Moreover, specifying LIBABIVER in the driver causes a symbolic link loop: > librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx

[dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library

2020-01-20 Thread Thomas Monjalon
The version of the PMD should not be overwritten with LIBABIVER. All internal libs must have the same version. Moreover, specifying LIBABIVER in the driver causes a symbolic link loop: librte_rawdev_octeontx2_ep.so.1 -> librte_rawdev_octeontx2_ep.so.1 Fixes: 56d46d13f736 ("raw/octeontx2_ep: add b

[dpdk-dev] [PATCH v5] net/axgbe: add a HW quirk for register definitions

2020-01-20 Thread Selwin Sebastian
V1000/R1000 processors are using the same PCI ids for the network device as SNOWYOWL processor but has altered register definitions for determining the window settings for the indirect PCS access. Add support to check for this hardware and if found use the new register values. Signed-off-by: Selwi

Re: [dpdk-dev] [PATCH] raw/octeontx2_ep: fix shared library

2020-01-20 Thread Thomas Monjalon
20/01/2020 12:06, Ferruh Yigit: > On 1/20/2020 11:05 AM, Thomas Monjalon wrote: > > The version of the PMD should not be overwritten with LIBABIVER. > > All internal libs must have the same version. > > > > Moreover, specifying LIBABIVER in the driver causes a symbolic link loop: > > librte_rawdev

[dpdk-dev] [PATCH v4 0/3] Use Intel IPSec MB library in Wireless PMDs

2020-01-20 Thread Pablo de Lara
The three Intel SW Crypto PMDs supporting SNOW3G, ZUC and KASUMI link against libSSO libraries. The Intel IPSec Multi-buffer library recently integrated the code from these libraries, in version v0.53. This library can be downloaded from https://github.com/intel/intel-ipsec-mb. KASUMI, SNOW3G an

[dpdk-dev] [PATCH v4 1/3] crypto/zuc: use IPSec library

2020-01-20 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for ZUC-EEA3 and ZUC-EIA3 from version v0.53, moving from libSSO ZUC library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 ++-- doc/guides/cryptodevs/zuc.rst | 52 ++--

[dpdk-dev] [PATCH v4 3/3] crypto/snow3g: use IPSec library

2020-01-20 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for SNOW3G-UEA2 and SNOW3G-UIA2 from version v0.53, moving from libSSO SNOW3G library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 4 +- doc/guides/cryptodevs/snow3g.rst | 58 +

[dpdk-dev] [PATCH v4 2/3] crypto/kasumi: use IPSec library

2020-01-20 Thread Pablo de Lara
Link against Intel IPSec Multi-buffer library, which added support for KASUMI-F8 and KASUMI-F9 from version v0.53, moving from libSSO KASUMI library. Signed-off-by: Pablo de Lara --- devtools/test-build.sh | 6 +-- doc/guides/cryptodevs/kasumi.rst | 62

Re: [dpdk-dev] [PATCH v5] net/axgbe: add a HW quirk for register definitions

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 4:42 PM, Selwin Sebastian wrote: > V1000/R1000 processors are using the same PCI ids for the network > device as SNOWYOWL processor but has altered register definitions > for determining the window settings for the indirect PCS access. > Add support to check for this hardware and if fo

Re: [dpdk-dev] [PATCH v2 0/3] mempool: fix mempool virt populate with small chunks

2020-01-20 Thread Thomas Monjalon
17/01/2020 15:57, Olivier Matz: > rte_mempool_populate_virt() sometimes fail, when it calls > rte_mempool_populate_iova() with an area which is too small to store one > object. This should not be an error. > > I prepared a v2 which implements an ABI compatibility through symbol > versioning, as su

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-20 Thread Ray Kinsella
+1 - thanks Dave On 20/01/2020 04:48, Jerin Jacob Kollanukkaran wrote: >> -Original Message- >> From: d...@barachs.net >> Sent: Saturday, January 18, 2020 8:45 PM >> To: 'Ray Kinsella' ; Jerin Jacob Kollanukkaran >> ; 'dpdk-dev' >> Subject: [EXT] RE: [RFC] [dpdk-dev] DPDK Trace support >

Re: [dpdk-dev] [PATCH v5 15/17] net/ionic: add stats

2020-01-20 Thread Ferruh Yigit
On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > Add basic, per queue and extended statistics for > RX and TX, both from the adapter and the driver. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon Nelson <...> > @@ -84,6 +84,153 @@ ionic_lif_reset(struct ionic_lif *lif) >

Re: [dpdk-dev] [PATCH v4 1/5] mbuf: introduce routine to get private mbuf pool flags

2020-01-20 Thread Olivier Matz
On Thu, Jan 16, 2020 at 01:04:25PM +, Viacheslav Ovsiienko wrote: > The routine rte_pktmbuf_priv_flags is introduced to fetch > the flags from the mbuf memory pool private structure > in unified fashion. > > Signed-off-by: Viacheslav Ovsiienko Acked-by: Olivier Matz

Re: [dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86

2020-01-20 Thread Olivier Matz
On Thu, Jan 16, 2020 at 06:40:23PM +0530, Jerin Jacob wrote: > On Wed, Jan 15, 2020 at 2:35 AM wrote: > > > > From: Jerin Jacob > > > > The existing optimize_object_size() function address the memory object > > alignment constraint on x86 for better performance. > > > > Different (micro) architec

[dpdk-dev] [PATCH] app/test: fix dependency on file in /sys

2020-01-20 Thread Bruce Richardson
Meson versions 0.52 and 0.53 are being overly smart and detecting the path "/sys/devices/system/cpu/present" in the call to cat in app/test/meson.build and then adding it as a dependency to the build configuration. This causes issues on systems where the timestamp of that file always returns the cu

Re: [dpdk-dev] [PATCH v4] mempool: remove memory wastage on non x86

2020-01-20 Thread Thomas Monjalon
20/01/2020 13:24, Olivier Matz: > On Thu, Jan 16, 2020 at 06:40:23PM +0530, Jerin Jacob wrote: > > On Wed, Jan 15, 2020 at 2:35 AM wrote: > > > > > > From: Jerin Jacob > > > > > > The existing optimize_object_size() function address the memory object > > > alignment constraint on x86 for better p

Re: [dpdk-dev] [PATCH] mbuf: document how to set length when attaching ext buffer

2020-01-20 Thread Thomas Monjalon
28/12/2019 10:40, Jörg Thalheim: > > Looks good to me! > > Olivier Matz writes: > > > From: Jörg Thalheim > > > > Enhance API documentation of rte_pktmbuf_attach_extbuf() to > > explain that the attached mbuf is initialized with length = 0. > > > > Link: https://bugs.dpdk.org/show_bug.cgi?id=3

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/tap: fix memory leak when unregister intr handler

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 8:30 AM, Yunjian Wang wrote: > The return check of function tap_lsc_intr_handle_set() is wrong, it should > be 0 or a positive number if success. So the intr_handle->intr_vec was not > been freed when tap_lsc_intr_handle_set() returned a positive number. > > Fixes: 4870a8cdd968 ("net/

Re: [dpdk-dev] [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-20 Thread Anoob Joseph
Hi Vladimir, Akhil, Marvell is also observing 10-15% drop with the SAD change. I agree with Akhil's opinion and we are not in favor of making this change. Thanks, Anoob From: Akhil Goyal Sent: Monday, January 20, 2020 12:14 PM To: Medvedkin, Vladimir ; dev@dpdk.org Cc: konstantin.anan...@inte

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modify actions support limitation

2020-01-20 Thread Ori Kam
> -Original Message- > From: Bing Zhao > Sent: Monday, January 20, 2020 11:43 AM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh ; > Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix modify actions support limitation > > In the root table, there

Re: [dpdk-dev] [PATCH v5 00/17] Introduces net/ionic PMD

2020-01-20 Thread Ferruh Yigit
On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > The patch series provides an initial version of a > poll mode driver for Pensando network adapters. > The driver name is ionic. > > v5 Changes: > -- > - Fixed commits headlines > - Fixed doc syntax > - Fixed unused parameters errors > - Fi

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modify actions support limitation

2020-01-20 Thread Slava Ovsiienko
> -Original Message- > From: Ori Kam > Sent: Monday, January 20, 2020 15:03 > To: Bing Zhao ; Slava Ovsiienko > ; Raslan Darawsheh ; > Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3] net/mlx5: fix modify actions support limitation > > > > > -Original Messa

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect pointer operation in meter

2020-01-20 Thread Slava Ovsiienko
> -Original Message- > From: Suanming Mou > Sent: Wednesday, January 8, 2020 12:41 > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; xiangxia.m@gmail.com; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix incorrect pointer operation in me

[dpdk-dev] [PATCH v7 0/3] Refactor crypto unit tests.

2020-01-20 Thread Adam Dybkowski
This patch set is a first step to refactor the overly complex symmetric crypto unit tests. It merges many separate arrays of the tests for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, sw_kasumi, sw_zuc into one big array that's then used when running unit tests on these PMDs. In

[dpdk-dev] [PATCH v7 1/3] test/crypto: refactor unit tests

2020-01-20 Thread Adam Dybkowski
This patch gets rid of individual functions that all call test_blockcipher_all_tests separately for every PMD and instead provides just one set universal for all PMDs that's basing on the driver id from the global variable gbl_driver_id. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.

[dpdk-dev] [PATCH v7 2/3] test/crypto: add capability checks

2020-01-20 Thread Adam Dybkowski
This patch adds capability checks to many tests meant to be run in the future on various PMDs. This way the code is prepared for more thorough refactoring in order to create one big central unit tests array. Signed-off-by: Adam Dybkowski --- app/test/test_cryptodev.c | 637 ++

[dpdk-dev] [PATCH v7 3/3] test/crypto: refactor unit tests into one combined array

2020-01-20 Thread Adam Dybkowski
This patch refactors most of unit tests to be contained in one combined array, and run depending on the PMD capabilities instead of providing multiple array with tests for individual PMDs. Only a subset of unit tests was merged into one array - it combines all tests originally meant to be run on th

Re: [dpdk-dev] [PATCH v7 0/3] Refactor crypto unit tests.

2020-01-20 Thread Akhil Goyal
> > This patch set is a first step to refactor the overly complex symmetric > crypto unit tests. It merges many separate arrays of the tests > for these PMDs: null, aesni_mb, aesni_gcm, openssl, qat, sw_snow3g, > sw_kasumi, sw_zuc into one big array that's then used when running > unit tests on

Re: [dpdk-dev] [PATCH v5 00/17] Introduces net/ionic PMD

2020-01-20 Thread Thomas Monjalon
20/01/2020 14:05, Ferruh Yigit: > On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > > The patch series provides an initial version of a > > poll mode driver for Pensando network adapters. > > The driver name is ionic. > > > > v5 Changes: > > -- > > - Fixed commits headlines > > - Fixed do

[dpdk-dev] [PATCH v2 00/12] add eventmode to ipsec-secgw

2020-01-20 Thread Anoob Joseph
This series introduces event-mode additions to ipsec-secgw. This effort is parallel to the similar changes in l2fwd (l2fwd-event app) & l3fwd. With this series, ipsec-secgw would be able to run in eventmode. The worker thread (executing loop) would be receiving events and would be submitting it ba

[dpdk-dev] [PATCH v2 01/12] examples/ipsec-secgw: add default rte_flow for inline Rx

2020-01-20 Thread Anoob Joseph
From: Ankur Dwivedi The default flow created would enable security processing on all ESP packets. If the default flow is created, SA based rte_flow creation would be skipped. Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- examples/ipsec-secgw/ipsec-secgw.c | 61 +

[dpdk-dev] [PATCH v2 02/12] examples/ipsec-secgw: add framework for eventmode helper

2020-01-20 Thread Anoob Joseph
Add framework for eventmode helper. Event mode involves initialization of multiple devices like eventdev, ethdev and etc. Add routines to initialize and uninitialize event device. Generate a default config for event device if it is not specified in the configuration. Currently event helper supports

[dpdk-dev] [PATCH v2 03/12] examples/ipsec-secgw: add eventdev port-lcore link

2020-01-20 Thread Anoob Joseph
Add event device port-lcore link and specify which event queues should be connected to the event port. Generate a default config for event port-lcore links if it is not specified in the configuration. This routine will check the number of available ports and then create links according to the numbe

[dpdk-dev] [PATCH v2 04/12] examples/ipsec-secgw: add Rx adapter support

2020-01-20 Thread Anoob Joseph
Add Rx adapter support. The event helper init routine will initialize the Rx adapter according to the configuration. If Rx adapter config is not present it will generate a default config. If there are enough event queues available it will map eth ports and event queues 1:1 (one eth port will be con

[dpdk-dev] [PATCH v2 05/12] examples/ipsec-secgw: add Tx adapter support

2020-01-20 Thread Anoob Joseph
Add Tx adapter support. The event helper init routine will initialize the Tx adapter according to the configuration. If Tx adapter config is not present it will generate a default config. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 313 ++

[dpdk-dev] [PATCH v2 06/12] examples/ipsec-secgw: add routines to display config

2020-01-20 Thread Anoob Joseph
Add routines to display the eventmode configuration and provide an overview of the devices used. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 207 examples/ipsec-secgw/event_helper.h | 14 +++ 2 files

[dpdk-dev] [PATCH v2 07/12] examples/ipsec-secgw: add routines to launch workers

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik In eventmode workers can be drafted differently according to the capabilities of the underlying event device. The added functions will receive an array of such workers and probe the eventmode properties to choose the worker. Signed-off-by: Anoob Joseph Signed-off-by: Lukas

[dpdk-dev] [PATCH v2 10/12] examples/ipsec-secgw: add driver mode worker

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik Add driver inbound and outbound worker thread for ipsec-secgw. In driver mode application does as little as possible. It simply forwards packets back to port from which traffic was received instructing HW to apply inline security processing using first outbound SA configured

[dpdk-dev] [PATCH v2 11/12] examples/ipsec-secgw: add app mode worker

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik Add application inbound/outbound worker thread and IPsec application processing code for event mode. Exampple ipsec-secgw command in app mode: ipsec-secgw -w 0002:02:00.0,ipsec_in_max_spi=128 -w 0002:03:00.0,ipsec_in_max_spi=128 -w 0002:0e:00.0 -w 0002:10:00.1 --log-level=8

[dpdk-dev] [PATCH v2 09/12] examples/ipsec-secgw: add eventmode to ipsec-secgw

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik Add eventmode support to ipsec-secgw. With the aid of event helper configure and use the eventmode capabilities. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/event_helper.c | 4 +- examples/ipsec-secgw/event_helper.h | 14 ++ exa

[dpdk-dev] [PATCH v2 08/12] examples/ipsec-secgw: add support for internal ports

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik Add support for Rx and Tx internal ports. When internal ports are available then a packet can be received from eth port and forwarded to event queue by HW without any software intervention. The same applies to Tx side where a packet sent to an event queue can by forwarded by

[dpdk-dev] [PATCH v2 12/12] examples/ipsec-secgw: add cmd line option for bufs

2020-01-20 Thread Anoob Joseph
From: Lukasz Bartosik Add command line option -s which can be used to configure number of buffers in a pool. Default number of buffers is 8192. Signed-off-by: Anoob Joseph Signed-off-by: Lukasz Bartosik --- examples/ipsec-secgw/ipsec-secgw.c | 23 +++ 1 file changed, 19 in

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

2020-01-20 Thread Mcnamara, John
> -Original Message- > From: stable On Behalf Of Thomas Monjalon > Sent: Friday, January 17, 2020 9:52 PM > To: Trahe, Fiona ; Trybula, ArturX > > Cc: dev@dpdk.org; sta...@dpdk.org; shal...@marvell.com; Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Akhil Goyal > Subject: Re: [dpdk-stab

Re: [dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Olivier Matz
Hi Slava, Some comments inline. On Thu, Jan 16, 2020 at 01:04:26PM +, Viacheslav Ovsiienko wrote: > Update detach routine to check the mbuf pool type. > Introduce the special internal version of detach routine to handle > the special case of pinned external bufferon mbuf freeing. > > Signed-

Re: [dpdk-dev] [PATCH v4 3/5] mbuf: create packet pool with external memory buffers

2020-01-20 Thread Olivier Matz
On Thu, Jan 16, 2020 at 01:04:27PM +, Viacheslav Ovsiienko wrote: > The dedicated routine rte_pktmbuf_pool_create_extbuf() is > provided to create mbuf pool with data buffers located in > the pinned external memory. The application provides the > external memory description and routine initiali

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect pointer operation in meter

2020-01-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Wednesday, January 8, 2020 12:41 PM > To: Matan Azrad ; Shahaf Shuler > ; Slava Ovsiienko > Cc: dev@dpdk.org; xiangxia.m@gmail.com; Raslan Darawsheh > ; sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix incorrect pointer operati

Re: [dpdk-dev] [PATCH v3] net/mlx5: fix modify actions support limitation

2020-01-20 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, January 20, 2020 11:43 AM > To: Ori Kam ; Slava Ovsiienko > ; Raslan Darawsheh ; > Matan Azrad > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v3] net/mlx5: fix modify actions support limitation > > In the root table, there

Re: [dpdk-dev] [PATCH v4 4/5] app/testpmd: add mempool with external data buffers

2020-01-20 Thread Olivier Matz
On Thu, Jan 16, 2020 at 01:04:28PM +, Viacheslav Ovsiienko wrote: > The new mbuf pool type is added to testpmd. To engage the > mbuf pool with externally attached data buffers the parameter > "--mp-alloc=xbuf" should be specified in testpmd command line. > > The objective of this patch is just

[dpdk-dev] net/virtio: add link speed devarg

2020-01-20 Thread Ivan Dyukov
This is rework of "[PATCH v2] net/virtio: add link speed tuning" which I sent month ago. Compile time link_speed is reworked to devarg. Best regards, Ivan

[dpdk-dev] [PATCH 1/2] net/virtio: refactor devargs parsing

2020-01-20 Thread Ivan Dyukov
refactor vdpa specific devargs parsing to more generic way Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 32 +- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.

[dpdk-dev] [PATCH 2/2] net/virtio: add link speed devarg

2020-01-20 Thread Ivan Dyukov
Some applications like pktgen use link_speed to calculate transmit rate. It limits outcome traffic to hardcoded 10G. This patch adds link_speed devarg which allows to configure link_speed of virtio device. Signed-off-by: Ivan Dyukov --- drivers/net/virtio/virtio_ethdev.c | 99 ++

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

2020-01-20 Thread Thomas Monjalon
20/01/2020 14:54, Mcnamara, John: > From: stable On Behalf Of Thomas Monjalon > > 15/01/2020 16:54, Akhil Goyal: > > > > > > > > > > This patch replaces existing test vector with a new one containing > > > > > C code to fix license issue. > > > > > > > > > > Signed-off-by: Artur Trybula > > > > A

[dpdk-dev] FW: [PATCH v4 0/5] integrate librte_ipsec SAD into ipsec-secgw

2020-01-20 Thread Ananyev, Konstantin
Hi Akhil, > Hi Vladimir, > The SA lookup logic and management is purely requirement based for the > application. >The application may only cater to <128 SAs which can > be handled based on the current logic. Not always, current implementation can handle < 128 SA, whose SPI%128 never match (le

Re: [dpdk-dev] [dpdk-stable] [PATCH] test/compress: replace test vector

2020-01-20 Thread Trahe, Fiona
Hi Thomas > -Original Message- > From: Thomas Monjalon > Sent: Monday, January 20, 2020 2:33 PM > To: Trahe, Fiona ; Trybula, ArturX > ; Mcnamara, > John > Cc: dev@dpdk.org; sta...@dpdk.org; shal...@marvell.com; Dybkowski, AdamX > ; Danilewicz, MarcinX > ; Akhil Goyal > > Subject: Re:

[dpdk-dev] [PATCH 0/2] l3fwd-power fixes

2020-01-20 Thread Xiao Wang
The second patch will apply failed without the first patch applied, so make them a series. The first patch is just a typo fix. The second patch fixes the issue that the interrupts are turned off only on the Rx queues that has traffic arrived, rather than all the Rx queues a core has taken. Xiao Wa

[dpdk-dev] [PATCH 1/2] l3fwd-power: fix a typo

2020-01-20 Thread Xiao Wang
Fixes: aee3bc79cc34 ("examples/l3fwd-power: enable one-shot Rx interrupt and polling switch") Cc: sta...@dpdk.org Signed-off-by: Xiao Wang --- examples/l3fwd-power/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.

[dpdk-dev] [PATCH 2/2] l3fwd-power: fix interrupt disable

2020-01-20 Thread Xiao Wang
Since all related queues' interrupts are turned on before epoll, we need to turn off all the interrupts after wakeup. This patch fixes the issue of only turning off the interrupted queues. Fixes: b736d64787fc ("examples/l3fwd-power: disable Rx interrupt when waking up") Cc: sta...@dpdk.org Signe

Re: [dpdk-dev] [PATCH] meter: move RFC4115 trTCM APIs as none experimental

2020-01-20 Thread Thomas Monjalon
17/12/2019 14:52, Dumitrescu, Cristian: > From: Eelco Chaudron > > Moved RFC4115 APIs to none experimental as they have been there > > since 19.02. Also, these APIs are the same as the none RFC4115 APIs. > > > > Signed-off-by: Eelco Chaudron > > Acked-by: Cristian Dumitrescu Applied, thanks

[dpdk-dev] [PATCH] event/dsw: use custom element size ring for control

2020-01-20 Thread Mattias Rönnblom
Replace DSW's use of regular DPDK rings (and code for packing/unpacking control messages into void pointers) with custom size rings. In addition to cleaner code, this change allows DSW to support up to the eventdev API's maximum of 255 ports by tweaking DSW_MAX_PORTS. Signed-off-by: Mattias Rönnb

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/test: fix dependency on file in /sys

2020-01-20 Thread Thomas Monjalon
20/01/2020 13:22, Bruce Richardson: > Meson versions 0.52 and 0.53 are being overly smart and detecting the path > "/sys/devices/system/cpu/present" in the call to cat in > app/test/meson.build and then adding it as a dependency to the build > configuration. This causes issues on systems where the

Re: [dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Slava Ovsiienko
Hi, Olivier Thanks a lot for the thorough review. There are some answers to comments, please, see below. > > > > /** > > + * @internal version of rte_pktmbuf_detach() to be used on mbuf freeing. > > -version > +Version > > > + * For indirect and regular (not pinned) external mbufs the standard

Re: [dpdk-dev] [PATCH] doc: update testpmd guide for flow dump command

2020-01-20 Thread Ferruh Yigit
On 1/20/2020 4:01 AM, Xiaoyu Min wrote: > Explanation of flow dump command is added into testpmd functions. > > Signed-off-by: Xiaoyu Min Reviewed-by: Ferruh Yigit Applied to dpdk-next-net/master, thanks.

Re: [dpdk-dev] [PATCH v4 2/5] mbuf: detach mbuf with pinned external buffer

2020-01-20 Thread Olivier Matz
Hi, On Mon, Jan 20, 2020 at 03:41:10PM +, Slava Ovsiienko wrote: > Hi, Olivier > > Thanks a lot for the thorough review. > There are some answers to comments, please, see below. > > > > > > > /** > > > + * @internal version of rte_pktmbuf_detach() to be used on mbuf freeing. > > > > -versi

Re: [dpdk-dev] [PATCH 0/2] Fix build with FreeBSD 13-CURRENT

2020-01-20 Thread Thomas Monjalon
03/01/2020 12:52, Bruce Richardson: > The FreeBSD CI system is reporting errors with DPDK on the current head > of the FreeBSD development branch for FreeBSD 13. Ahead of BSD 13's > release, we need to apply fixes to ensure DPDK continues to compile > on the various versions. > > Bruce Richardson

Re: [dpdk-dev] [RFC] DPDK Trace support

2020-01-20 Thread Stephen Hemminger
On Sat, 18 Jan 2020 10:14:31 -0500 wrote: > It would be well worth considering one of the vpp techniques to minimize > trace impact: > > static inline ring_handler_inline (..., int is_traced) > { > for (i = 0; i < vector_size; i++) > { > if (is_traced) > { > do_trace_w

Re: [dpdk-dev] [PATCH v5 11/17] net/ionic: add Rx filters support

2020-01-20 Thread Ferruh Yigit
On 1/19/2020 3:53 PM, Alfredo Cardigliano wrote: > Add support for managing RX filters based on MAC and VLAN. > Hardware cannot provide the list of filters, thus we keep > a local list. > Add support for promisc and allmulticast modes. > > Signed-off-by: Alfredo Cardigliano > Reviewed-by: Shannon

[dpdk-dev] [PATCH v1 08/38] vdpa/mlx5: support queues number operation

2020-01-20 Thread Matan Azrad
Support get_queue_num operation to get the maximum number of queues supported by the device. This number comes from the DevX capabilities. Signed-off-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdpa.c | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(

[dpdk-dev] [PATCH v1 03/38] mlx5: share the mlx5 glue reference

2020-01-20 Thread Matan Azrad
A new Mellanox vdpa PMD will be added to support vdpa operations by Mellanox adapters. Both, the mlx5 PMD and the vdpa mlx5 PMD should initialize the glue. The glue initialization should be only one per process, so all the mlx5 PMDs using the glue should share the same glue object. Move the glue

[dpdk-dev] [PATCH v1 05/38] mlx5: share mlx5 devices information

2020-01-20 Thread Matan Azrad
Move the vendor information, vendor ID and device IDs from mlx5 PMD to the common mlx5 file. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 21 + drivers/net/mlx5/mlx5.h | 21 - drivers/net/mlx5/mlx5_txq.c | 1 + 3 file

[dpdk-dev] [PATCH v1 06/38] drivers: introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
Add a new driver to support vDPA operations by Mellanox devices. The first Mellanox devices which support vDPA operations are ConnectX6DX and Bluefield1 HCA for their PF ports and VF ports. This driver is depending on rdma-core like the mlx5 PMD, also it is going to use mlx5 DevX to create HW obj

[dpdk-dev] [PATCH v1 01/38] net/mlx5: separate DevX commands interface

2020-01-20 Thread Matan Azrad
The DevX commands interfaces is included in the mlx5.h file with a lot of other PMD interfaces. As an arrangement to make the DevX commands shared with different PMDs, this patch moves the DevX interface to a new file called mlx5_devx_cmds.h. Also remove shared device structure dependency from De

[dpdk-dev] [PATCH v1 07/38] common/mlx5: expose vDPA DevX capabilities

2020-01-20 Thread Matan Azrad
Add the DevX capabilities for vDPA configuration and information of Mellanox devices. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 90 drivers/common/mlx5/mlx5_devx_cmds.h | 24 ++ drivers/common/mlx5/mlx5_prm.h | 45 +++

[dpdk-dev] [PATCH v1 04/38] mlx5: share mlx5 PCI device detection

2020-01-20 Thread Matan Azrad
Move PCI detection by IB device from mlx5 PMD to the common code. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 2 +- drivers/common/mlx5/mlx5_common.c | 55 + drivers/common/mlx5/mlx5_common.h | 4 ++ drive

[dpdk-dev] [PATCH v1 09/38] vdpa/mlx5: support features get operations

2020-01-20 Thread Matan Azrad
Add support for get_features and get_protocol_features operations. Part of the features are reported by the DevX capabilities. Signed-off-by: Matan Azrad --- doc/guides/vdpadevs/features/mlx5.ini | 7 drivers/vdpa/mlx5/mlx5_vdpa.c | 66 +-- 2 files

[dpdk-dev] [PATCH v1 00/38] Introduce mlx5 vDPA driver

2020-01-20 Thread Matan Azrad
Steps: - Prepare net/mlx5 for code sharing. - Introduce new common lib for mlx5 devices. - Share code from net/mlx5 to common/mlx5. - Introduce vDPA driver for Mellanox devices. Matan Azrad (38): net/mlx5: separate DevX commands interface mlx5: prepare common library mlx5: share the mlx5 gl

[dpdk-dev] [PATCH v1 10/38] common/mlx5: glue null memory region allocation

2020-01-20 Thread Matan Azrad
Add support for rdma-core API to allocate NULL MR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 13 + drivers/common/mlx5/mlx5_glue.h | 1 + 2 files changed, 14 insertions(+) diff --git a/drivers/common/mlx5/mlx5_glue.c b/drivers/common/mlx5/mlx5_glue.c index d5

[dpdk-dev] [PATCH v1 11/38] common/mlx5: support DevX indirect mkey creation

2020-01-20 Thread Matan Azrad
Add option to create an indirect mkey by the current mlx5_devx_cmd_mkey_create command. Align the net/mlx5 driver usage in the above command. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 43 ++-- drivers/common/mlx5/mlx5_devx_cmds.h | 12

[dpdk-dev] [PATCH v1 12/38] common/mlx5: glue event queue query

2020-01-20 Thread Matan Azrad
The event queue is managed only by the kernel. Add the rdma-core command in glue to query the kernel event queue details. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_glue.c | 15 +++ drivers/common/mlx5/mlx5_glue.h | 2 ++ 2 files changed, 17 insertions(+) diff --git a

[dpdk-dev] [PATCH v1 19/38] mlx5: share CQ entry check

2020-01-20 Thread Matan Azrad
The CQE has owner bit to indicate if it is in SW control or HW. Share a CQE check for all the mlx5 drivers. Signed-off-by: Matan Azrad --- drivers/common/mlx5/mlx5_common.h | 41 +++ drivers/net/mlx5/mlx5_rxtx.h | 39 +

[dpdk-dev] [PATCH v1 13/38] common/mlx5: glue event interrupt commands

2020-01-20 Thread Matan Azrad
Add the next commands to glue in order to support interrupt event channel operations associated to events in the EQ: devx_create_event_channel, devx_destroy_event_channel, devx_subscribe_devx_event, devx_subscribe_devx_event_fd, devx_get_event. Signed-off-by

[dpdk-dev] [PATCH v1 14/38] common/mlx5: glue UAR allocation

2020-01-20 Thread Matan Azrad
The isolated, protected and independent direct access to the HW by multiple processes is implemented via User Access Region (UAR) mechanism. The UAR is part of PCI address space that is mapped for direct access to the HW from the CPU. UAR is comprised of multiple pages, each page containing registe

[dpdk-dev] [PATCH v1 16/38] common/mlx5: glue VAR allocation

2020-01-20 Thread Matan Azrad
Virtio access region(VAR) is the UAR that allocated for virtio emulation access. Add rdma-core operations to allocate and free VAR. Signed-off-by: Matan Azrad --- drivers/common/mlx5/Makefile| 5 + drivers/common/mlx5/meson.build | 1 + drivers/common/mlx5/mlx5_glue.c | 26 +++

[dpdk-dev] [PATCH v1 17/38] common/mlx5: add DevX virtio emulation commands

2020-01-20 Thread Matan Azrad
Virtio emulation offload allows SW to offload the I/O operations of a virtio virtqueue, using the device, allowing an improved performance for its users. While supplying all the relevant Virtqueue information (type, size, memory location, doorbell information, etc.). The device can then offload the

[dpdk-dev] [PATCH v1 21/38] vdpa/mlx5: handle completions

2020-01-20 Thread Matan Azrad
In order to free resources in the CQ and to allow to the HW to send packets from the guest, the CQ should be polled. In order to poll the CQ we need to trigger an interrupt for each new CQE posted by the HW. Register interrupt handler to poll and arm a CQ when completion event was raised by the H

[dpdk-dev] [PATCH v1 20/38] vdpa/mlx5: prepare completion queues

2020-01-20 Thread Matan Azrad
As an arrangement to the vitrio queues creation, a CQ should be created for the virtio queue. The design is to trigger an event for the guest and for the vdpa driver when a new CQE is posted by the HW after the packet transition. This patch add the basic operations to create and destroy CQs and t

  1   2   >