Re: [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code

2020-02-05 Thread David Marchand
On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli wrote: > > The test case target 'hash_readwrite_autotest' is covered by > 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. > Hence, it is removed along with its test code. > > Signed-off-by: Honnappa Nagarahalli > --- > app/te

Re: [dpdk-dev] [PATCH] eal: fix to set the rte_device ptr's device args before hotplug

2020-02-05 Thread Somnath Kotur
Hello Gaetan, On Tue, Feb 4, 2020 at 3:19 PM Gaetan Rivet wrote: > > On 04/02/2020 10:15, Somnath Kotur wrote: > > As per the comments in this code section, "since there is a matching device, > > it is now its responsibility to manage the devargs we've just inserted." > > But the matching device

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread David Marchand
On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli wrote: > > Add lock-free reader writer concurrency functional tests. > These tests will provide the same coverage that non lock-free > APIs have. > > Signed-off-by: Honnappa Nagarahalli > --- > app/test/test_hash_readwrite.c | 58 ++

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Maxime Coquelin
On 2/4/20 3:47 PM, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the linux kernel

Re: [dpdk-dev] [PATCH] eal: fix to set the rte_device ptr's device args before hotplug

2020-02-05 Thread Gaetan Rivet
On 05/02/2020 09:52, Somnath Kotur wrote: Hello Gaetan, On Tue, Feb 4, 2020 at 3:19 PM Gaetan Rivet wrote: On 04/02/2020 10:15, Somnath Kotur wrote: As per the comments in this code section, "since there is a matching device, it is now its responsibility to manage the devargs we've just ins

Re: [dpdk-dev] [PATCH] vhost/crypto: fix incorrect fetch size

2020-02-05 Thread Maxime Coquelin
On 1/29/20 11:24 AM, Fan Zhang wrote: > Coverity issue: 343401 > > This patch fixes the incorrect rte_vhost_crypto_fetch_requests > return value. > > Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") > Cc: roy.fan.zh...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Fan Zhang > -

[dpdk-dev] [PATCH] net/thunderx: add link up and down ops

2020-02-05 Thread Harman Kalra
Add support for .set_link_up/down() eth ops to bring link up and down. Signed-off-by: Harman Kalra --- drivers/net/thunderx/base/nicvf_mbox.c | 10 drivers/net/thunderx/base/nicvf_mbox.h | 10 drivers/net/thunderx/nicvf_ethdev.c| 33 ++ 3 files chang

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 6:43 AM Dmitry Kozlyuk wrote: > > Hi Narcisa, > > > I'm having some trouble with cross-compilation: > > > > python3 meson.py -Dexamples=helloworld ../../dpdk/build ../../dpdk > > --cross-file ../../dpdk/meson_mingw.txt > > The Meson build system > > Version: 0.53.1 > > Sour

Re: [dpdk-dev] [PATCH 00/14] cleanup resources on shutdown

2020-02-05 Thread David Marchand
Hello Stephen, On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger wrote: > > Recently started using valgrind with DPDK, and the results > are not clean. > > The DPDK has a function that applications can use to tell it > to cleanup resources on shutdown (rte_eal_cleanup). But the > current coverage

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix reported hash key size in device info

2020-02-05 Thread Ferruh Yigit
On 2/4/2020 3:10 PM, Raslan Darawsheh wrote: > Hash key size is missing from reported device info. > This fills the hash key size in device info. > > Fixes: 4586be37 ("net/failsafe: fix reported device info") > Cc: sta...@dpdk.org > > Signed-off-by: Raslan Darawsheh Reviewed-by: Ferruh Yigit

Re: [dpdk-dev] [PATCH v2] net/mlx5: fix memory regions release deadlock

2020-02-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Michael Baum > Sent: Tuesday, February 4, 2020 3:36 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/mlx5: fix memory regions release > deadlock > > The mpx5 PMD maintains

Re: [dpdk-dev] [PATCH] net/virtio-user: do not reset virtqueues for split ring

2020-02-05 Thread Maxime Coquelin
On 2/5/20 3:11 AM, Tiwei Bie wrote: > Add missing braces to avoid resetting virtqueues unconditionally > during reconnection. > > Fixes: 6ebbf4109f35 ("net/virtio-user: fix packed ring server mode") > > Signed-off-by: Tiwei Bie > --- > Cc: Xuan Ding > > drivers/net/virtio/virtio_user_ethde

Re: [dpdk-dev] [PATCH] vhost:fix crash on port deletion and VM shutdown at same time

2020-02-05 Thread Maxime Coquelin
On 1/16/20 3:07 AM, Zhike Wang wrote: > The vhost_user_read_cb() and rte_vhost_driver_unregister() can be > called at the same time by 2 threads. Eg thread1 calls vhost_user_read_cb() > and removes the vsocket from conn_list, then thread2 calls > rte_vhost_driver_unregister() and frees the vsock

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Maxime Coquelin
On 2/4/20 3:47 PM, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the linux kernel

Re: [dpdk-dev] [PATCH] rte_vhost: do not treat empty socket message as error

2020-02-05 Thread Maxime Coquelin
On 1/30/20 9:05 AM, Vitaliy Mysak wrote: > According to recvmsg() specification, 0 is a valid > return code when client is disconnecting. > Therefore, it should not be reported as error, unless there > are other dependencies that require message to not be empty. > But there are none, since the n

Re: [dpdk-dev] [PATCH] vhost/crypto: fix incorrect fetch size

2020-02-05 Thread Maxime Coquelin
On 1/29/20 11:24 AM, Fan Zhang wrote: > Coverity issue: 343401 > > This patch fixes the incorrect rte_vhost_crypto_fetch_requests > return value. > > Fixes: 3bb595ecd682 ("vhost/crypto: add request handler") > Cc: roy.fan.zh...@intel.com > Cc: sta...@dpdk.org > > Signed-off-by: Fan Zhang > -

Re: [dpdk-dev] [PATCH] vhost: add event areas to vq_is_ready()

2020-02-05 Thread Maxime Coquelin
On 1/25/20 9:52 AM, Adrian Moreno wrote: > Consider a virtqueue ready when, apart from the the descriptor area, > both event supression areas have been mapped. > > Fixes: 2d1541e2b6b3 ("vhost: add vring address setup for packed queues") > Cc: y...@fridaylinux.org > Cc: sta...@dpdk.org > > Sign

Re: [dpdk-dev] [PATCH] vhost: catch overflow causing mmap of size 0

2020-02-05 Thread Maxime Coquelin
On 1/16/20 11:44 AM, Maxime Coquelin wrote: > This patch catches an overflow that could happen if an > invalid region size or page alignement is provided by the > guest via the VHOST_USER_SET_MEM_TABLE request. > > If the sum of the size to mmap and the alignment overflows > uint64_t, then RTE_

Re: [dpdk-dev] [PATCH] net/mlx5: fix use of uninitialized array

2020-02-05 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dekel Peled > Sent: Wednesday, February 5, 2020 8:42 AM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh > Cc: dev@dpdk.org; Bing Zhao > Subject: [PATCH] net/mlx5: fix use of uninitialized array > > Previous patch changed the format of struct >

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-05 Thread Luca Boccassi
On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: > > But if we can do the versioning in the master, LTS can backport it > > and can have > > mature version of that API in LTS without breaking the existing > > users. > > > > But why bother? The only thing you've changed is the version > tagg

Re: [dpdk-dev] [PATCH v3 1/3] app: use RTE_DIM to calculate array size

2020-02-05 Thread David Marchand
On Fri, Jan 24, 2020 at 5:56 AM wrote: > > From: Pavan Nikhilesh > > Use RTE_DIM macro to calculate array size > > Suggested-by: David Marchand > Signed-off-by: Pavan Nikhilesh I caught some integer type issue with bypass feature in test-pmd. Will fix when applying. For the series, Acked-by:

[dpdk-dev] [PATCH] eal: store control thread CPU affinity in TLS

2020-02-05 Thread jerinj
From: Jerin Jacob _cpuset TLS variable stores the CPU affinity of eal thread. Populate the _cpuset TLS variable for control thread to 1) Make rte_thread_get_affinity() and eal_thread_dump_affinity functional with control thread. 2) Quick access to cpu affinity. Signed-off-by: Jerin Jacob ---

Re: [dpdk-dev] [PATCH v5] app/testpmd: add portlist option to the testpmd

2020-02-05 Thread Ferruh Yigit
On 2/4/2020 4:48 PM, Hariprasad Govindharajan wrote: > In current version, we are setting the ports > using portmask. With portmask, we can use only > upto 64 ports. This portlist option enables the user > to use more than 64 ports. > Now we can specify the ports in 2 different

Re: [dpdk-dev] [PATCH] examples/ioat: fix unchecked return value

2020-02-05 Thread David Marchand
On Tue, Feb 4, 2020 at 5:13 PM Ciara Power wrote: > > The function call to get the device info can return negative values on > failure, which was previously unchecked. This return value is now > checked and the function exits on failure. > > Coverity issue: 350361 > Fixes: c8e6ceecebc1 ("examples/

Re: [dpdk-dev] [PATCH v2 4/4] add ABI checks

2020-02-05 Thread Ray Kinsella
On 04/02/2020 09:51, David Marchand wrote: > On Mon, Feb 3, 2020 at 7:56 PM Ray Kinsella wrote: >> On 03/02/2020 17:34, Thomas Monjalon wrote: >>> 03/02/2020 18:09, Thomas Monjalon: 03/02/2020 10:30, Ferruh Yigit: > On 2/2/2020 2:41 PM, Ananyev, Konstantin wrote: >> 02/02/2020 14:0

Re: [dpdk-dev] [RFC] meter: fix ABI break due to experimental tag removal

2020-02-05 Thread Neil Horman
On Wed, Feb 05, 2020 at 11:04:29AM +0100, Luca Boccassi wrote: > On Tue, 2020-02-04 at 07:02 -0500, Neil Horman wrote: > > > But if we can do the versioning in the master, LTS can backport it > > > and can have > > > mature version of that API in LTS without breaking the existing > > > users. > > >

Re: [dpdk-dev] [PATCH 00/14] cleanup resources on shutdown

2020-02-05 Thread Stephen Hemminger
On Wed, 5 Feb 2020 10:32:49 +0100 David Marchand wrote: > Hello Stephen, > > On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger > wrote: > > > > Recently started using valgrind with DPDK, and the results > > are not clean. > > > > The DPDK has a function that applications can use to tell it > > t

Re: [dpdk-dev] [PATCH v2 1/2] crypto/ccp: sha3 support enabling in ccp

2020-02-05 Thread Akhil Goyal
> For series, > Acked-by: Ravi Kumar > > > > >From: Sardar Shamsher Singh > > > >sha3 support enabled in AMD-CCP crypto controller > > > >Signed-off-by: Sardar Shamsher Singh > >--- Change patch title and description as below cryptodev: fix missing SHA3 algo strings SHA3 support was ad

Re: [dpdk-dev] [PATCH] examples/fips_validation: add AES XTS support

2020-02-05 Thread Akhil Goyal
> > Hi Marko, > > > > > From: Sucharitha Sarananaga > > > > AES XTS support is added to fips application. Parse test-vectors > > from input files, populate AES XTS tests and prepare AES XTS > > operations for fips validation. > > > > Signed-off-by: Abed Kamaluddin > > Signed-off-by: Archana M

Re: [dpdk-dev] [PATCH] examples/fips_validation: fix parsing of cipher length for AES-GCM

2020-02-05 Thread Akhil Goyal
> > > > From: Sucharitha Sarananaga > > > > Cipher length need to be updated in case of AES-GCM decryption. > > > > Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing") > > > > Signed-off-by: Archana Muniganti > > Signed-off-by: Sucharitha Sarananaga > > Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH 00/14] cleanup resources on shutdown

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 1:07 PM Stephen Hemminger wrote: > > On Wed, 5 Feb 2020 10:32:49 +0100 > David Marchand wrote: > > > Hello Stephen, > > > > On Sat, Jan 4, 2020 at 2:34 AM Stephen Hemminger > > wrote: > > > > > > Recently started using valgrind with DPDK, and the results > > > are not clea

Re: [dpdk-dev] [PATCH] drivers/crypto: fix set_sym_session_private_data error in sessionless mode

2020-02-05 Thread Akhil Goyal
Hi Pablo, > When OpenSSL or AESNI-MB cryptodev is being used in sessionless mode > for symmetric crypto operation (e.g. SHA256 hash), the driver prints > error message: > > CRYPTODEV: set_sym_session_private_data() line 489: >Set private data for driver 0 not allowed > > Then

[dpdk-dev] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") Cc: ano...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- drive

[dpdk-dev] [PATCH 0/3] fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. I didn't put -fcommon to CFLAGS since: Compiling with -fno-common is use

[dpdk-dev] [PATCH 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Red

[dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 08e0c7581468 ("test/fib: add performance autotests") Cc: vladimir.medved...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli

Re: [dpdk-dev] [EXT] [PATCH 1/3] crypto/octeontx2: fix building with GCC 10

2020-02-05 Thread Anoob Joseph
> -- > GCC 10 defaults to -fno-common, this means a linker error will now be reported > if the same global variable is defined in more than one compilation unit. > > Fixes: 2f8a1b963eb7 ("crypto/octeontx2: add PMD skeleton") > C

[dpdk-dev] [PATCH 0/6] code improvements for OCTEON TX crypto PMDs

2020-02-05 Thread Anoob Joseph
This series has code improvements, bug fixes and capabilities changes supported with new firmware for OCTEON TX crypto PMDs. Anoob Joseph (1): common/cpt: remove redundant bitswaps Archana Muniganti (3): crypto/octeontx2: add AES-GCM capabilities supported with new firmware common/cpt: fix

[dpdk-dev] [PATCH 3/6] common/cpt: support variable key size for HMAC

2020-02-05 Thread Anoob Joseph
From: Sucharitha Sarananaga HMAC algorithms supports key lengths from 1 to 1024 bytes. Signed-off-by: Archana Muniganti Signed-off-by: Sucharitha Sarananaga Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_mcode_defines.h | 2 +- drivers/common/cpt/cpt_ucode.h

[dpdk-dev] [PATCH 1/6] common/cpt: remove redundant bitswaps

2020-02-05 Thread Anoob Joseph
The structures can be written for direct h/w usage to avoid multiple bitswaps. Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_mcode_defines.h | 45 +++--- drivers/common/cpt/cpt_ucode.h | 34 + 2 files changed, 20 insertions(+),

[dpdk-dev] [PATCH 2/6] crypto/octeontx2: add AES-GCM capabilities supported with new firmware

2020-02-05 Thread Anoob Joseph
From: Archana Muniganti OCTEON TX2 crypto PMD supports digest lengths from 4 to 16 bytes with new firmware. Signed-off-by: Archana Muniganti Signed-off-by: Anoob Joseph --- drivers/crypto/octeontx2/otx2_cryptodev_capabilities.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[dpdk-dev] [PATCH 4/6] common/cpt: fix error path when cipher and auth key are not set

2020-02-05 Thread Anoob Joseph
From: Archana Muniganti Returning error when cipher and auth key are not getting set Fixes: 6cc54096520d ("crypto/octeontx: add supported sessions") Signed-off-by: Archana Muniganti Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_ucode.h | 32 +--- 1 file c

[dpdk-dev] [PATCH 6/6] common/cpt: removes self assignment code

2020-02-05 Thread Anoob Joseph
From: Sunila Sahu This fixes coverity issue of self assignment. Coverity issue: 353635 Signed-off-by: Sunila Sahu Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_ucode_asym.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/cpt/cpt_ucode_asym.h b/drivers/common/cpt/c

[dpdk-dev] [PATCH 5/6] common/cpt: fix fill_sg_comp api for zero datalen

2020-02-05 Thread Anoob Joseph
From: Archana Muniganti fill_sg_comp_from_iov() prepares gather components for i/p IOV buffers and extra buf. This API is failing to create a gather component for extra_buf when IOV buf len is zero. Though there is enough space to accommodate extra_buf, because of pre-decrementing of extra_buf le

Re: [dpdk-dev] [PATCH 0/6] code improvements for OCTEON TX crypto PMDs

2020-02-05 Thread Anoob Joseph
Hi Akhil, This series is ready for merge, if you don't have any comments. Thanks, Anoob > -Original Message- > From: Anoob Joseph > Sent: Wednesday, February 5, 2020 6:46 PM > To: Akhil Goyal > Cc: Anoob Joseph ; dev@dpdk.org > Subject: [PATCH 0/6] code improvements for OCTEON TX cryp

Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 1:51 PM Timothy Redaelli wrote: > > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") > Cc: cristia

[dpdk-dev] [pull-request] next-net 20.02 rc2

2020-02-05 Thread Ferruh Yigit
The following changes since commit 55499896d91a4fb01e743b71df639dc1c18314d8: doc: add event mode to l3fwd guide (2020-01-28 10:05:25 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-net for-main-repo for you to fetch changes up to 8e7fda18080de1b32597e5d

Re: [dpdk-dev] [PATCH v3 1/3] app: use RTE_DIM to calculate array size

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 11:22 AM David Marchand wrote: > > On Fri, Jan 24, 2020 at 5:56 AM wrote: > > > > From: Pavan Nikhilesh > > > > Use RTE_DIM macro to calculate array size > > > > Suggested-by: David Marchand > > Signed-off-by: Pavan Nikhilesh > > I caught some integer type issue with byp

Re: [dpdk-dev] [PATCH 2/3] app/test: fix building with GCC 10

2020-02-05 Thread Medvedkin, Vladimir
On 05/02/2020 12:50, Timothy Redaelli wrote: GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 08e0c7581468 ("test/fib: add performance autotests") Cc: vladimir.medved...@intel.com Cc: s

Re: [dpdk-dev] [PATCH v3 13/13] examples/ipsec-secgw: make number of buffers dynamic

2020-02-05 Thread Ananyev, Konstantin
Hi Lukasz, > Make number of buffers in a pool nb_mbuf_in_pool dependent on number > of ports, cores and crypto queues. Add command line option -s which > when used overrides dynamic calculation of number of buffers in a pool. > > Signed-off-by: Anoob Joseph > Signed-off-by: Lukasz Bartosik >

Re: [dpdk-dev] [PATCH] ether: mark ethernet addresses as being 2-byte aligned

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 01:21:54AM +0100, Martins Eglitis wrote: > Dear Bruce and Kevin, > > I tried building an application (NFF-GO) which has DPDK as a dependency. > I am still getting the same warnings you and Kevin were discussing. My > current DPDK version is 19.11-1. > > Do you know if this

[dpdk-dev] [PATCH 0/3] examples: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. See https://gcc.gnu.org/gcc-10/porting_to.html for more informations. I didn't put -fcommon to CFLAGS since: Compiling with -fno-common is use

[dpdk-dev] [PATCH 1/3] examples/vhost_blk: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") Cc: jin...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redael

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, February 5, 2020 7:18 AM > To: k...@vger.kernel.org > Subject: Re: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > Promised example QEMU test case... > > commit 3557c63bcb286c71f3f7242cad632edd9e297d26 > Author: Alex Williamson > Date: Tue Feb 4 13:4

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Liu, Yi L
Hi Alex, Silly questions on the background: > From: Alex Williamson > Sent: Wednesday, February 5, 2020 7:06 AM > Subject: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > There seems to be an ongoing desire to use userspace, vfio-based > drivers for both SR-IOV PF and VF devices. Is this series

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Christoph Hellwig
On Tue, Feb 04, 2020 at 04:05:34PM -0700, Alex Williamson wrote: > We address this in a few ways in this series. First, we can use a bus > notifier and the driver_override facility to make sure VFs are bound > to the vfio-pci driver by default. This should eliminate the chance > that a VF is acci

Re: [dpdk-dev] [EXTERNAL] [PATCH 0/6] MinGW-w64 support

2020-02-05 Thread Narcisa Ana Maria Vasile
Hi Dmitry, Thanks for the patches! I was able to compile and run natively, after applying the Meson patch that you mentioned. I'm having some trouble with cross-compilation: python3 meson.py -Dexamples=helloworld ../../dpdk/build ../../dpdk --cross-file ../../dpdk/meson_mingw.txt The Meson bu

Re: [dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-05 Thread Liu, Yi L
> From: Alex Williamson > Sent: Wednesday, February 5, 2020 7:06 AM > To: k...@vger.kernel.org > Subject: [RFC PATCH 3/7] vfio/pci: Introduce VF token > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > fully isolated from the PF. The PF can always cause a denial of > ser

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Tue, 4 Feb 2020 23:01:09 -0800 Christoph Hellwig wrote: > On Tue, Feb 04, 2020 at 04:05:34PM -0700, Alex Williamson wrote: > > We address this in a few ways in this series. First, we can use a bus > > notifier and the driver_override facility to make sure VFs are bound > > to the vfio-pci dri

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:21 + "Liu, Yi L" wrote: > Hi Alex, > > Silly questions on the background: > > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > Subject: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > > There seems to be an ongoing desire to use userspace,

[dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: 48f31ca50cc4 ("app/pipeline: packet framework benchmark") Cc: cristian.dumitre...@intel.com Cc: sta...@dpdk.org Signed-off-by: Timothy Red

Re: [dpdk-dev] [PATCH] vhost: check vhost message header size read

2020-02-05 Thread Maxime Coquelin
On 1/17/20 8:54 AM, Tiwei Bie wrote: > On Thu, Jan 16, 2020 at 11:44:44AM +0100, Maxime Coquelin wrote: >> This patch adds a check to ensure the read size of >> the Vhost-user message header is not smaller than >> the expected size. >> >> Fixes: 8f972312b8f4 ("vhost: support vhost-user") >> Cc:

Re: [dpdk-dev] [PATCH v4 0/3] add ABI checks

2020-02-05 Thread Thomas Monjalon
02/02/2020 22:08, David Marchand: > Here is the current state of the ABI checks. > > libabigail has some issues when mixing dump and so files compiled with > clang [1], so for now, all checks are done on dumps only. > libabigail 1.0-rc3 in Xenial reported issues that disappear with the > version 1

Re: [dpdk-dev] [RFC PATCH 3/7] vfio/pci: Introduce VF token

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:29 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:06 AM > > To: k...@vger.kernel.org > > Subject: [RFC PATCH 3/7] vfio/pci: Introduce VF token > > > > If we enable SR-IOV on a vfio-pci owned PF, the resulting VFs are not > > f

Re: [dpdk-dev] [RFC PATCH 0/7] vfio/pci: SR-IOV support

2020-02-05 Thread Alex Williamson
On Wed, 5 Feb 2020 07:57:36 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, February 5, 2020 7:18 AM > > To: k...@vger.kernel.org > > Subject: Re: [RFC PATCH 0/7] vfio/pci: SR-IOV support > > > > > > Promised example QEMU test case... > > > > commit 3557c63bcb286c71f3f

Re: [dpdk-dev] [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10

2020-02-05 Thread Dumitrescu, Cristian
> -Original Message- > From: Timothy Redaelli > Sent: Wednesday, February 5, 2020 2:12 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; david.march...@redhat.com; Dumitrescu, Cristian > > Subject: [PATCH v2 3/3] app/test-pipeline: fix building with GCC 10 > > GCC 10 defaults to -fno-commo

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Thomas Monjalon
15/01/2020 16:53, Akhil Goyal: > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > > > Signed-off-by: Arek Kusztal > > > Acked-by: Fiona Trahe > > > > Acked-by: Anoob Joseph > > > Acked-by: Akhil Goyal > > Applied to dpdk-next-crypto As discussed in other email thre

Re: [dpdk-dev] [PATCH 4/6] build: MinGW-w64 support for Meson

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 01:41:24AM +0100, Thomas Monjalon wrote: > 05/02/2020 00:21, Dmitry Kozlyuk: > > > I really like this patch. > > > So both GCC (with MinGW) and native clang are supported? > > > > Thanks. Yes, I tested both toolchains. > > > > > [...] > > > > +# MS linker requires special

Re: [dpdk-dev] [EXT] Re: [PATCH v2 4/4] add ABI checks

2020-02-05 Thread Trahe, Fiona
Hi Anoob, > -Original Message- > From: Anoob Joseph > Sent: Wednesday, February 5, 2020 6:16 AM > To: Neil Horman ; Akhil Goyal ; > Trahe, Fiona > > Cc: Thomas Monjalon ; Yigit, Ferruh > ; Ananyev, > Konstantin ; Trahe, Fiona > ; dev@dpdk.org; > David Marchand ; Kusztal, ArkadiuszX >

[dpdk-dev] Travis warning about job configs

2020-02-05 Thread David Marchand
While monitoring the newly pushed ABI check in Travis, I noticed that Travis has now a feature to validate the configuration we pass. You can notice a new "Build config validation" box in https://travis-ci.com/DPDK/dpdk/builds/147554312/config Not sure those warnings are a real issue, but it coul

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Trahe, Fiona
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Wednesday, February 5, 2020 2:29 PM > To: Anoob Joseph ; Kusztal, ArkadiuszX > ; Trahe, > Fiona ; Akhil Goyal > Cc: dev@dpdk.org; Narayana Prasad Raju Athreya ; > Tejasree Kondoj > ; Jerin Jacob Kollanukkaran ; > bl...@de

Re: [dpdk-dev] [PATCH 0/6] code improvements for OCTEON TX crypto PMDs

2020-02-05 Thread Akhil Goyal
> > Hi Akhil, > > This series is ready for merge, if you don't have any comments. > Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v6 1/8] cryptodev: introduce cpu crypto support API

2020-02-05 Thread Akhil Goyal
> > Add new API allowing to process crypto operations in a synchronous > manner. Operations are performed on a set of SG arrays. > > Cryptodevs which allows CPU crypto operation mode have to > use RTE_CRYPTODEV_FF_SYM_CPU_CRYPTO capability. > > Add a helper method to easily convert mbufs to a SG

Re: [dpdk-dev] [PATCH v6 3/8] security: add cpu crypto action type

2020-02-05 Thread Akhil Goyal
> Introduce CPU crypto action type allowing to differentiate between > regular async 'none security' and synchronous, CPU crypto accelerated > sessions. > > This mode is similar to ACTION_TYPE_NONE but crypto processing is > performed synchronously on a CPU. > > Signed-off-by: Marcin Smoczynski

Re: [dpdk-dev] [PATCH v6 4/8] test/crypto: add cpu crypto mode to tests

2020-02-05 Thread Akhil Goyal
> > This patch adds ability to run unit tests in cpu crypto mode and > provides test for aesni_gcm's cpu crypto implementation. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > --- > app/test/test_cryptodev.c | 161 +++--- > 1 file chan

Re: [dpdk-dev] [PATCH v6 5/8] ipsec: introduce support for cpu crypto mode

2020-02-05 Thread Akhil Goyal
> > Update library to handle CPU cypto security mode which utilizes > cryptodev's synchronous, CPU accelerated crypto operations. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > Acked-by: Fan Zhang > Tested-by: Konstantin Ananyev > --- Acked-by: Akhil Goyal

Re: [dpdk-dev] [PATCH v6 6/8] examples/ipsec-secgw: cpu crypto support

2020-02-05 Thread Akhil Goyal
> > Add support for CPU accelerated crypto. 'cpu-crypto' SA type has > been introduced in configuration allowing to use abovementioned > acceleration. > > Legacy mode is not currently supported. > > Signed-off-by: Konstantin Ananyev > Signed-off-by: Marcin Smoczynski > Acked-by: Fan Zhang > -

Re: [dpdk-dev] [PATCH v6 0/8] Introduce CPU crypto mode

2020-02-05 Thread Akhil Goyal
> Originally both SW and HW crypto PMDs use rte_crypot_op based API to > process the crypto workload asynchronously. This way provides uniformity > to both PMD types, but also introduce unnecessary performance penalty to > SW PMDs that have to "simulate" HW async behavior (crypto-ops > enqueue/d

[dpdk-dev] [PATCH v2] vhost: check vhost message header size read

2020-02-05 Thread Maxime Coquelin
This patch adds a check to ensure the read size of the Vhost-user message header is not smaller than the expected size. In case of unexpected read size, report an error and close file descriptors passed with the message, if any. Fixes: 8f972312b8f4 ("vhost: support vhost-user") Cc: sta...@dpdk.or

Re: [dpdk-dev] [PATCH 1/3] examples/vhost_blk: fix building with GCC 10

2020-02-05 Thread Maxime Coquelin
On 2/5/20 2:47 PM, Timothy Redaelli wrote: > GCC 10 defaults to -fno-common, this means a linker error will now be > reported if the same global variable is defined in more than one > compilation unit. > > Fixes: c19beb3f38cd ("examples/vhost_blk: introduce vhost storage sample") > Cc: jin...@i

[dpdk-dev] [PATCH] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [RFC 0/6] replace telemetry with process_info

2020-02-05 Thread David Marchand
Hello Ciara, Bruce, On Thu, Dec 5, 2019 at 6:34 PM Ciara Power wrote: > > From: Bruce Richardson > > This patchset proposes a new library, called "process-info" for now, to > replace the existing telemetry library in DPDK. (Name subject to change > if someone can propose a better one). > > The e

Re: [dpdk-dev] [PATCH v3] cryptodev: add chacha20-poly1305 aead algorithm

2020-02-05 Thread Thomas Monjalon
05/02/2020 15:41, Trahe, Fiona: > From: Thomas Monjalon > > 15/01/2020 16:53, Akhil Goyal: > > > > > This patch adds Chacha20-Poly1305 AEAD algorithm to Cryptodev. > > > > > > > > > > Signed-off-by: Arek Kusztal > > > > > Acked-by: Fiona Trahe > > > > > > > > Acked-by: Anoob Joseph > > > > > >

[dpdk-dev] [PATCH v2] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

[dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Július Milan
With this patch it is possible to connect 2 DPDK memifs into loopback, i.e. when they have the same id and different roles, as for example: "--vdev=net_memif0,role=master,id=0" "--vdev=net_memif1,role=slave,id=0" Fixes: 09c7e63a71 ("net/memif: introduce memory interface PMD") Signed-off-by: Júl

[dpdk-dev] [PATCH v3] doc: alias to experimental tag for stable apis

2020-02-05 Thread Ray Kinsella
When a maintainer is promoting an API to become part of the next major ABI version by removing the experimental tag, possibly a few releases in advance of the declaration of the next ABI version. The maintainer may choose to offer an alias to the experimental tag, as removing the tag before the dec

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Eugenio Perez Martin
Thanks! On Wed, Feb 5, 2020 at 10:48 AM Maxime Coquelin wrote: > > > On 2/4/20 3:47 PM, Eugenio Pérez wrote: > > The current implementation of vhost_net in packed vring tries to fill > > the shadow vector before send any actual changes to the guest. While > > this can be beneficial for the throu

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Ferruh Yigit
On 2/5/2020 3:41 PM, Július Milan wrote: > With this patch it is possible to connect 2 DPDK memifs into loopback, > i.e. when they have the same id and different roles, as for example: > "--vdev=net_memif0,role=master,id=0" > "--vdev=net_memif1,role=slave,id=0" Overall looks good idea but this c

Re: [dpdk-dev] [EXT] RE: [PATCH v3 13/13] examples/ipsec-secgw: make number of buffers dynamic

2020-02-05 Thread Lukas Bartosik
Hi Konstantin, Please see inline. Thanks, Lukasz On 05.02.2020 14:42, Ananyev, Konstantin wrote: > External Email > > -- > > Hi Lukasz, > >> Make number of buffers in a pool nb_mbuf_in_pool dependent on number >> of ports, c

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread Honnappa Nagarahalli
> > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > wrote: > > > > Add lock-free reader writer concurrency functional tests. > > These tests will provide the same coverage that non lock-free APIs > > have. > > > > Signed-off-by: Honnappa Nagarahalli > > --- > > app/test/test_hash_readwrit

Re: [dpdk-dev] [PATCH v2 3/5] test/hash: add lock free reader writer functional tests

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 5:22 PM Honnappa Nagarahalli wrote: > > > > > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > > wrote: > > > > > > Add lock-free reader writer concurrency functional tests. > > > These tests will provide the same coverage that non lock-free APIs > > > have. > > > > >

Re: [dpdk-dev] [PATCH v2 2/5] test/hash: remove duplicated test code

2020-02-05 Thread David Marchand
On Wed, Feb 5, 2020 at 9:48 AM David Marchand wrote: > > On Mon, Feb 3, 2020 at 8:49 PM Honnappa Nagarahalli > wrote: > > > > The test case target 'hash_readwrite_autotest' is covered by > > 'hash_readwrite_func_autotest' and 'hash_readwrite_perf_autotest'. > > Hence, it is removed along with its

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Július Milan
On Wed, Feb 05, 2020 at 04:00:19PM +, Ferruh Yigit wrote: > On 2/5/2020 3:41 PM, Július Milan wrote: >> With this patch it is possible to connect 2 DPDK memifs into loopback, >> i.e. when they have the same id and different roles, as for example: >> "--vdev=net_memif0,role=master,id=0" >> "--

Re: [dpdk-dev] [PATCH] net/memif: enable loopback

2020-02-05 Thread Ferruh Yigit
On 2/5/2020 4:44 PM, Július Milan wrote: > On Wed, Feb 05, 2020 at 04:00:19PM +, Ferruh Yigit wrote: >> On 2/5/2020 3:41 PM, Július Milan wrote: >>> With this patch it is possible to connect 2 DPDK memifs into loopback, >>> i.e. when they have the same id and different roles, as for example: >>

[dpdk-dev] [PATCH 2/3] examples/eventdev_pipeline: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
Fixes: 3d1b33e44ae2 ("examples/eventdev: move common data into pipeline common") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Timothy Redaelli --- examples/eventdev_pipeline/main.c| 2 ++ examples/eventdev_pipeline/pipeline_common.h | 4 ++-- 2 files changed, 4 inse

[dpdk-dev] [PATCH 3/3] examples/qos_sched: fix building with GCC 10

2020-02-05 Thread Timothy Redaelli
GCC 10 defaults to -fno-common, this means a linker error will now be reported if the same global variable is defined in more than one compilation unit. Fixes: be1e533238c0 ("examples/qos_sched: add TC and queue config flexibility") Cc: jasvinder.si...@intel.com Cc: sta...@dpdk.org Signed-off-by:

[dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo

2020-02-05 Thread Thomas Monjalon
If a driver has no info generated by pmdinfogen, and if this driver is compiled as pedantic, then an failure would occur: drivers/rte_common_mlx5.pmd.c:1: error: ISO C forbids an empty translation unit [-Werror=pedantic] Such error is triggered with the new mlx5 common directory. I

Re: [dpdk-dev] [RFC 0/6] replace telemetry with process_info

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 04:21:16PM +0100, David Marchand wrote: > Hello Ciara, Bruce, > > On Thu, Dec 5, 2019 at 6:34 PM Ciara Power wrote: > > > > From: Bruce Richardson > > > > This patchset proposes a new library, called "process-info" for now, to > > replace the existing telemetry library in

Re: [dpdk-dev] [PATCH] buildtools: allow pedantic empty pmdinfo

2020-02-05 Thread Bruce Richardson
On Wed, Feb 05, 2020 at 06:07:23PM +0100, Thomas Monjalon wrote: > If a driver has no info generated by pmdinfogen, > and if this driver is compiled as pedantic, > then an failure would occur: > drivers/rte_common_mlx5.pmd.c:1: error: > ISO C forbids an empty translation unit [-Werror=p

Re: [dpdk-dev] Offloading L4 checksum to crypto device

2020-02-05 Thread Trahe, Fiona
Hi Heng, This may be of interest for your use-case. https://patches.dpdk.org/patch/65559/ Fiona > -Original Message- > From: dev On Behalf Of Heng Wang > Sent: Monday, December 23, 2019 2:28 PM > To: Doherty, Declan > Cc: Filip Pudak ; dev@dpdk.org > Subject: [dpdk-dev] Offloading L4 che

  1   2   >