Re: [dpdk-dev] [PATCH v3 00/12] generic rte atomic APIs deprecate proposal

2020-04-03 Thread Mattias Rönnblom
On 2020-03-17 02:17, Phil Yang wrote: > DPDK provides generic rte_atomic APIs to do several atomic operations. > These APIs are using the deprecated __sync built-ins and enforce full > memory barriers on aarch64. However, full barriers are not necessary > in many use cases. In order to address such

Re: [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread David Marchand
Hello Jerin, Pavan, Thanks for the patch. On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob wrote: > > From: Pavan Nikhilesh > > Meson make allow_experimental_api global across lib, drivers and apps. - The title seems odd to me. - The documentation should be updated. - You can still find traces in

Re: [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread David Marchand
On Fri, Apr 3, 2020 at 9:23 AM David Marchand wrote: > On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob wrote: > - You can still find traces in meson files. > $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE > '^((app|drivers|lib)/meson.build|examples/)' > app/test/meson.build > drive

[dpdk-dev] [RFC] malloc: add malloc and free log function

2020-04-03 Thread Xueming Li
DPDK uses second level memory allocation management, this makes regular memory profiler tool not applicant. This patch trys to provide a lightweight malloc and free logging, then show leaked memory entries based on logs. This tool only target to malloc and free tracking, for memzone used by ring a

[dpdk-dev] [RFC] malloc: add malloc and free log function

2020-04-03 Thread Xueming Li
This patch introduces new feature to track rte_malloc leakage by logging malloc and free function. Signed-off-by: Xueming Li --- app/test-pmd/cmdline.c | 61 ++- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 15 +++ lib/librte_eal/common/eal_memcfg.h | 18

[dpdk-dev] [RFC] malloc: add malloc and free log function

2020-04-03 Thread Xueming Li
DPDK uses second level memory allocation management, this makes regular memory profiler tool not applicant. This patch trys to provide a lightweight malloc and free logging, then show leaked memory entries based on logs. This tool only target to malloc and free tracking, for memzone used by ring a

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Pavan Nikhilesh Bhagavatula
> wrote: >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob >wrote: >> - You can still find traces in meson files. >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE >> '^((app|drivers|lib)/meson.build|examples/)' >> app/test/meson.build >> drivers/net/e1000/base/meson.build >> drive

Re: [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernetdevices

2020-04-03 Thread Ivan Dyukov
02.04.2020 23:58, Thomas Monjalon пишет: > 02/04/2020 22:41, Ivan Dyukov: >> 02.04.2020 16:50, Morten Brørup пишет: >> Yes, if speed is unknown, it should be reported as 0. >>> Could the DPDK vNIC PMDs be updated accordingly? At least the virtio >>> driver... >> Current version of dpdk code on

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread David Marchand
On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula wrote: > > > wrote: > >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob > >wrote: > >> - You can still find traces in meson files. > >> $ git grep -il allow.experimental.api |grep meson.build$ |grep -vE > >> '^((app|drivers|lib)/meson.build|

Re: [dpdk-dev] [PATCH v2 2/2] vhost: cache gpa to hpa translation

2020-04-03 Thread Ma, LihongX
Tested-by: ma,lihong Regards, Ma,lihong -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Liu, Yong Sent: Wednesday, April 1, 2020 9:01 PM To: Gavin Hu ; maxime.coque...@redhat.com; Ye, Xiaolong ; Wang, Zhihong Cc: dev@dpdk.org; nd Subject: Re: [dpdk-dev] [PATCH

Re: [dpdk-dev] [PATCH v2 1/2] vhost: utilize dpdk dynamic memory allocator

2020-04-03 Thread Ma, LihongX
Tested-by: ma,lihong Regards, Ma,lihong -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Marvin Liu Sent: Wednesday, April 1, 2020 10:50 PM To: maxime.coque...@redhat.com; Ye, Xiaolong ; Wang, Zhihong Cc: dev@dpdk.org; Liu, Yong Subject: [dpdk-dev] [PATCH v2 1/2

[dpdk-dev] [PATCH v3 01/11] net/octeontx2: setup link config based on BP level

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Configure NIX_AF_TL3_TL2X_LINKX_CFG using schq at level based on NIX_AF_PSE_CHANNEL_LEVEL[BP_LEVEL]. Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_tm.c | 16 +++- 2 files changed, 16 insertion

[dpdk-dev] [PATCH v3 00/11] net/octeontx2: add traffic manager support

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Add support to traffic management api in OCTEON TX2 PMD. This support applies to CN96xx of C0 silicon version. This series depends on http://patchwork.dpdk.org/patch/66344/ Depends-on:series-8815 v3: * Fix x86_32 print string issue v2: * Update release notes of 20.05 *

[dpdk-dev] [PATCH v3 03/11] net/octeontx2: add dynamic topology update support

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Modify resource allocation and freeing logic to support dynamic topology commit while to traffic is flowing. This patch also modifies SQ flush to timeout based on minimum shaper rate configured. SQ flush is further split to pre/post functions to adhere to HW spec of 96XX C

[dpdk-dev] [PATCH v3 02/11] net/octeontx2: restructure tm helper functions

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Restructure traffic manager helper function by splitting to multiple sets of register configurations like shaping, scheduling and topology config. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 689

[dpdk-dev] [PATCH v3 04/11] net/octeontx2: add tm node add and delete cb

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Adds support to Traffic Management callbacks "node_add" and "node_delete". These callbacks doesn't support dynamic node addition or deletion post hierarchy commit. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 271

[dpdk-dev] [PATCH v3 06/11] net/octeontx2: add tm hierarchy commit callback

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Add TM hierarchy commit callback to support enabling newly created topology. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 173 1 file changed, 173 insertions(+) diff --gi

[dpdk-dev] [PATCH v3 05/11] net/octeontx2: add tm node suspend and resume cb

2020-04-03 Thread Nithin Dabilpuram
From: Krzysztof Kanas Add TM support to suspend and resume nodes post hierarchy commit. Signed-off-by: Krzysztof Kanas Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_tm.c | 81 + 1 file changed, 81 insertions(+) diff --git a/drivers/ne

[dpdk-dev] [PATCH v3 08/11] net/octeontx2: add tm dynamic topology update cb

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Add dynamic parent and shaper update callbacks that can be used to change RR Quantum or PIR/CIR rate dynamically post hierarchy commit. Dynamic parent update callback only supports updating RR quantum of a given child with respect to its parent. There is no support yet to

[dpdk-dev] [PATCH v3 07/11] net/octeontx2: add tm stats and shaper profile cbs

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Add TM support for stats read and private shaper profile addition or deletion. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_tm.c | 272 drivers/net/octeontx2/otx2_tm.h | 4 + 2

[dpdk-dev] [PATCH v3 10/11] net/octeontx2: add Tx queue ratelimit callback

2020-04-03 Thread Nithin Dabilpuram
From: Krzysztof Kanas Add Tx queue ratelimiting support. This support is mutually exclusive with TM support i.e when TM is configured, tx queue ratelimiting config is no more valid. Signed-off-by: Krzysztof Kanas Signed-off-by: Nithin Dabilpuram --- drivers/net/octeontx2/otx2_ethdev.c | 1 +

[dpdk-dev] [PATCH v3 11/11] net/octeontx2: add tm capability callbacks

2020-04-03 Thread Nithin Dabilpuram
From: Krzysztof Kanas Add Traffic Management capability callbacks to provide global, level and node capabilities. This patch also adds documentation on Traffic Management Support. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- doc/guides/nics/features/octeontx2.ini | 1

[dpdk-dev] [PATCH v3 09/11] net/octeontx2: add tm debug support

2020-04-03 Thread Nithin Dabilpuram
From: Nithin Dabilpuram Add debug support to TM to dump configured topology and registers. Also enable debug dump when sq flush fails. Signed-off-by: Nithin Dabilpuram Signed-off-by: Krzysztof Kanas --- drivers/net/octeontx2/otx2_ethdev.h | 1 + drivers/net/octeontx2/otx2_ethdev_debug

Re: [dpdk-dev] Using rte_lpm as standalone library w/o mempools or dpdk infra

2020-04-03 Thread Burakov, Anatoly
On 02-Apr-20 1:51 PM, Venumadhav Josyula wrote: Hi All, Idea is following - create lpm in one process where only rte_lpm and bare minimum is acessible. Addition into this table will also happen in this process context. - Now in the packet processing context based ip of packet the lookup

Re: [dpdk-dev] [PATCH v2 1/2] virtio: one way barrier for split vring used idx

2020-04-03 Thread Gavin Hu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, April 2, 2020 11:48 PM > To: Joyce Kong > Cc: maxime.coque...@redhat.com; tiwei@intel.com; > zhihong.w...@intel.com; tho...@monjalon.net; jer...@marvell.com; > yinan.w...@intel.com; Honnappa Nagarahalli > ;

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Bruce Richardson
On Fri, Apr 03, 2020 at 10:18:02AM +0200, David Marchand wrote: > On Fri, Apr 3, 2020 at 10:06 AM Pavan Nikhilesh Bhagavatula > wrote: > > > > > wrote: > > >> On Thu, Apr 2, 2020 at 8:33 PM Jerin Jacob > > >wrote: > > >> - You can still find traces in meson files. > > >> $ git grep -il allow.expe

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread David Marchand
On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson wrote: > > diff --git a/drivers/meson.build b/drivers/meson.build > > index 987e616ae7..4d8f842ab8 100644 > > --- a/drivers/meson.build > > +++ b/drivers/meson.build > > @@ -20,7 +20,7 @@ dpdk_driver_classes = ['common', > > disabled_drivers = run_

Re: [dpdk-dev] [PATCH] crypto/nitrox: add 3DES-CBC support

2020-04-03 Thread Nagadheeraj Rottela
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 1, 2020 7:38 PM > To: Nagadheeraj Rottela > Cc: dev@dpdk.org; Srikanth Jampala > Subject: [EXT] RE: [PATCH] crypto/nitrox: add 3DES-CBC support > > External Email > > -

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-03 Thread Wang, Xiao W
Hi Jerin, Found small typos on this patch. Please check comments inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Thomas Monjalon ; Richardson, Bruce > ; Mcnamara, John ; > Kovacevic, Marko ; Jerin

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Bruce Richardson
On Fri, Apr 03, 2020 at 11:14:03AM +0200, David Marchand wrote: > On Fri, Apr 3, 2020 at 11:10 AM Bruce Richardson > wrote: > > > diff --git a/drivers/meson.build b/drivers/meson.build > > > index 987e616ae7..4d8f842ab8 100644 > > > --- a/drivers/meson.build > > > +++ b/drivers/meson.build > > > @

Re: [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernetdevices

2020-04-03 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov > Sent: Friday, April 3, 2020 10:06 AM > > 02.04.2020 23:58, Thomas Monjalon пишет: > > 02/04/2020 22:41, Ivan Dyukov: > >> 02.04.2020 16:50, Morten Brørup пишет: > >> Yes, if speed is unknown, it should be reported as 0. > >>>

Re: [dpdk-dev] [RFC] malloc: add malloc and free log function

2020-04-03 Thread Burakov, Anatoly
On 03-Apr-20 8:54 AM, Xueming Li wrote: This patch introduces new feature to track rte_malloc leakage by logging malloc and free function. Hi, Thanks for the patch. A general comment - i would avoid mixing testpmd code with adding a new API to malloc. I understand this is an RFC so it's OK f

Re: [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Hemant Agrawal (OSS)
> Subject: [dpdk-dev] [PATCH v2 1/2] build: meson make experimental tag as > global > > From: Pavan Nikhilesh > > Meson make allow_experimental_api global across lib, drivers and apps. > > Signed-off-by: Pavan Nikhilesh > --- Acked-by: Hemant Agrawal

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-03 Thread Shetty, Praveen
-Original Message- From: Akhil Goyal Sent: Friday, April 3, 2020 11:22 AM To: Anoob Joseph ; Shetty, Praveen ; dev@dpdk.org; Doherty, Declan Cc: Iremonger, Bernard ; Ananyev, Konstantin Subject: RE: [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature > > > diff

Re: [dpdk-dev] [EXT] [PATCH v3] examples/ipsec-secgw: support flow director feature

2020-04-03 Thread Anoob Joseph
Hi Akhil, Praveen, Please see inline. Thanks, Anoob > -Original Message- > From: Shetty, Praveen > Sent: Friday, April 3, 2020 3:51 PM > To: Akhil Goyal ; Anoob Joseph ; > dev@dpdk.org; Doherty, Declan > Cc: Iremonger, Bernard ; Ananyev, Konstantin > > Subject: RE: [EXT] [PATCH v3] ex

Re: [dpdk-dev] [PATCH v3 02/29] graph: implement node registration

2020-04-03 Thread Wang, Xiao W
Hi, Comments inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb...@e

Re: [dpdk-dev] [PATCH v3 03/29] graph: implement node operations

2020-04-03 Thread Wang, Xiao W
Hi Jerin, Comment inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Jerin Jacob ; Kiran Kumar K > > Cc: dev@dpdk.org; tho...@monjalon.net; david.march...@redhat.com; > m...@ashroe.eu; mattias.ronnb

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Thomas Monjalon
03/04/2020 10:05, Pavan Nikhilesh Bhagavatula: > Let me know if anything else need to be added to the list. I think you can squash the patches in a single one.

Re: [dpdk-dev] [RFC] ethdev: use special speed for virtual Ethernetdevices

2020-04-03 Thread Thomas Monjalon
03/04/2020 11:45, Morten Brørup: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ivan Dyukov > > Sent: Friday, April 3, 2020 10:06 AM > > > > 02.04.2020 23:58, Thomas Monjalon пишет: > > > 02/04/2020 22:41, Ivan Dyukov: > > >> 02.04.2020 16:50, Morten Brørup пишет: > > >> Yes, if spee

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] build: meson make experimental tag as global

2020-04-03 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Thomas Monjalon >Sent: Friday, April 3, 2020 4:26 PM >To: Pavan Nikhilesh Bhagavatula >Cc: David Marchand ; Jerin Jacob >; Ferruh Yigit ; Bruce >Richardson ; dev ; Neil >Horman >Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v2 1/2] build: meson make >experimental

Re: [dpdk-dev] [PATCH v2 04/29] net/ena/base: set default hash key

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 14:36 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > The RSS hash key was present in the device, but it wasn't exposed to > > the user. The other key still cannot be set, but now it can be accessed > > if one needs to do that. > > What is 'the other

Re: [dpdk-dev] [PATCH v2 07/29] net/ena/base: add accelerated LLQ mode

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 14:41 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > In order to use the accelerated LLQ, the driver must limit the Tx burst > > I would be nice to show LLQ means "Low-latency Queue" > Ok - will do that in v3. > > and be aware that the device has

Re: [dpdk-dev] [PATCH v2 10/29] net/ena/base: add error logs when preparing Tx

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 14:53 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > To make the debugging easier, the error logs were added in the Tx path. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Reviewed-by: Guy Tzalik > > --- > > drivers/ne

[dpdk-dev] [PATCH] test: add reassembly perf test

2020-04-03 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly perf autotest for both ipv4 and ipv6 reassembly. Each test is performed with vairable number of fragments per flow, either ordered or unorderd fragments and interleaved flows. Signed-off-by: Pavan Nikhilesh --- app/test/meson.build| 2 + app/t

Re: [dpdk-dev] [PATCH v3 08/12] service: remove redundant code

2020-04-03 Thread Van Haaren, Harry
> From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@nxp.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH v3 07/12] service: remove rte prefix from static functions

2020-04-03 Thread Van Haaren, Harry
> From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@nxp.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH v3 09/12] service: avoid race condition for MT unsafe service

2020-04-03 Thread Van Haaren, Harry
> From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@nxp.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH v3 10/12] service: identify service running on another core correctly

2020-04-03 Thread Van Haaren, Harry
> From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@nxp.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH v3 11/12] service: optimize with c11 one-way barrier

2020-04-03 Thread Van Haaren, Harry
> -Original Message- > From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@n

Re: [dpdk-dev] [PATCH v3 12/12] service: relax barriers with C11 atomic operations

2020-04-03 Thread Van Haaren, Harry
> From: Phil Yang > Sent: Tuesday, March 17, 2020 1:18 AM > To: tho...@monjalon.net; Van Haaren, Harry ; > Ananyev, Konstantin ; > step...@networkplumber.org; maxime.coque...@redhat.com; dev@dpdk.org > Cc: david.march...@redhat.com; jer...@marvell.com; hemant.agra...@nxp.com; > honnappa.nagaraha..

Re: [dpdk-dev] [PATCH v2 11/29] net/ena/base: use 48-bit memory addresses in ena_com

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 14:55 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > ENA device is using 48-bit memory for IO. because of that, the upper > > limit had to be updated. > > What is the impact of this change, and what is the reason of the change? Can > you > please e

Re: [dpdk-dev] [PATCH v2 17/29] net/ena: add support for large LLQ headers

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 15:02 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > If the device supports larger LLQ (Low Latency Queue) headers, the user > > can activate them by enabling CONFIG_RTE_LIBRTE_ENA_LARGE_LLQ_HEADERS > > flag in the configuration file. > > > > If the

Re: [dpdk-dev] [PATCH v2 01/14] net/igc: add igc PMD

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Implement device detection and loading. > Add igc driver guid docs. > > Signed-off-by: Alvin Zhang > > v2: Update release note. Modify codes according to comments <...> > @@ -0,0 +1,39 @@ > +.. SPDX-License-Identifi

Re: [dpdk-dev] [PATCH v2 02/14] net/igc: support device initialization

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Update base share codes, add readme. > Add OS specific functions and definitions. > Add device initialization codes. > > Signed-off-by: Alvin Zhang <...> > # > +# Add extra flags for base driver files (also known as

Re: [dpdk-dev] [PATCH v2 03/14] net/igc: implement device base ops

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Bellow ops are implemented: > dev_configure > dev_start > dev_stop > dev_close > dev_reset > dev_set_link_up > dev_set_link_down > link_update > fw_version_get > dev_led_on > dev_led_off > > Signed-off-by: Alvin Zhang >

Re: [dpdk-dev] [PATCH v2 05/14] net/igc: implement status API

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Implement base status, extend status and per queue status API. Status API? This patch enables statistics, right? > > Below ops are added: > stats_get > xstats_get > xstats_get_by_id > xstats_get_names_by_id > xstats_ge

Re: [dpdk-dev] [PATCH v2 10/14] net/igc: implement ether-type filter

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Update feature list too. > > Signed-off-by: Alvin Zhang > --- > doc/guides/nics/features/igc.ini | 1 + > drivers/net/igc/Makefile | 1 + > drivers/net/igc/igc_ethdev.c | 5 + > drivers/net/igc/igc_et

Re: [dpdk-dev] [PATCH v2 14/14] net/igc: implement flow API

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Below type of flows are supported: > ether-type filter, > 2-tuple filter, > SYN filter, > RSS > > Signed-off-by: Alvin Zhang <...> > @@ -852,6 +854,11 @@ > case RTE_ETH_FILTER_HASH: > ret = igc_has

Re: [dpdk-dev] [PATCH v2 04/14] net/igc: support reception and transmission of packets

2020-04-03 Thread Ferruh Yigit
On 3/20/2020 2:46 AM, alvinx.zh...@intel.com wrote: > From: Alvin Zhang > > Below ops are added too: > mac_addr_add > mac_addr_remove > mac_addr_set > set_mc_addr_list > mtu_set > promiscuous_enable > promiscuous_disable > allmulticast_enable > allmulticast_disable > rx_queue_setup > rx_queue_rel

Re: [dpdk-dev] [PATCH v2 19/29] net/ena: add Tx drops statistic

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 15:05 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > ENA device can report in the AENQ handler amount of Tx packets that were > > dropped and not sent. > > > > This statistic is showing global value for the device and because > > rte_eth_stats is mi

Re: [dpdk-dev] [PATCH v2 28/29] net/ena: update copyright date

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 17:51 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > The v2.1.0 making changes in the ena_ethdev files were done this year, > > so the copyright notice should be updated. > > > > Signed-off-by: Michal Krawczyk > > Reviewed-by: Igor Chauskin > > Re

Re: [dpdk-dev] [PATCH v2 29/29] net/ena: update version of the driver to v2.1.0

2020-04-03 Thread Michał Krawczyk
czw., 2 kwi 2020 o 17:53 Ferruh Yigit napisał(a): > > On 4/1/2020 3:21 PM, Michal Krawczyk wrote: > > The v2.1.0 is refactoring Tx and Rx paths, including few bug fixes and > > is also adding a new features which are going to be available with the > > newest hardware: > > * Accelerated LLQ mode >

[dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread juraj . linkes
From: "juraj.linkes" libjansson4 is not enough to build telemetry. Replace it with libjansson-dev. Signed-off-by: Juraj Linkeš --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index fd4f79cfc..2d2292ff6 100644 --- a/.travis.yml +++ b

Re: [dpdk-dev] [PATCH] [v1 1/1] examples/l2fwd: add cmdline option for forwarding port info

2020-04-03 Thread Andrzej Ostruszka [C]
On 4/3/20 5:30 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Current l2fwd application configures adjacent ports as destination > ports for forwarding the traffic which is a kind of static mapping > that can not be altered by the command line options. > > Patch adds a config option

Re: [dpdk-dev] [PATCH v2] net/axgbe: vlan support enabling in axgbe

2020-04-03 Thread Ferruh Yigit
On 4/3/2020 7:20 AM, ssar...@amd.com wrote: > From: Sardar Shamsher Singh > > adding below APIs for axgbe > - axgbe_enable_rx_vlan_stripping: to enable vlan header stipping > - axgbe_disable_rx_vlan_stripping: to disable vlan header stipping > - axgbe_enable_rx_vlan_filtering: to enable vlan filt

Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command

2020-04-03 Thread Ferruh Yigit
On 4/3/2020 7:53 AM, Xueming Li wrote: > Introduce new command to dump memory statistics of each socket, > summary, also show changes since last call. > > Usage: > dump_socket > > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline.c | 52 > +

Re: [dpdk-dev] [PATCH] [v1 1/1] net/octeontx2: add routines to set/clear interrupt enable registers

2020-04-03 Thread Andrzej Ostruszka [C]
On 4/3/20 4:20 AM, vattun...@marvell.com wrote: > From: Vamsi Attunuru > > Patch adds routines to set/clear nix lf error & ras interrupt enable > registers. These nix lf error interrupts get triggered if there are > any failures during nix lf configuration. This interrupts are enabled > before an

[dpdk-dev] [PATCH v3] build: enable allow experimental API flag globally

2020-04-03 Thread pbhagavatula
From: Pavan Nikhilesh Remove setting ALLOW_EXPERIMENTAL_API individually for each Makefile and meson.build in app, lib and drivers instead enable ALLOW_EXPERIMENTAL_API flag globally. This changes reduces the clutter across the project while still maintaining the functionality of ALLOW_EXPERIMENT

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread Aaron Conole
juraj.lin...@pantheon.tech writes: > From: "juraj.linkes" > > libjansson4 is not enough to build telemetry. Replace it with > libjansson-dev. > > Signed-off-by: Juraj Linkeš > --- I see that earlier builds would print: = Content Skipped = libs:

Re: [dpdk-dev] [PATCH 1/2] bitmap: add create bitmap with all bits set

2020-04-03 Thread Andrzej Ostruszka
Hello Suanming Please find my comments below. However please note that so far I have never used DPDK bitmaps so I might not be the best person to comment - this patch needs some attention so I spent some time on it. Overall I'm fine with the changes however since this is a performance enhancemen

Re: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis

2020-04-03 Thread Ruifeng Wang
> -Original Message- > From: dev On Behalf Of > juraj.lin...@pantheon.tech > Sent: Friday, April 3, 2020 8:46 PM > To: acon...@redhat.com; maicolgabr...@hotmail.com > Cc: dev@dpdk.org; juraj.linkes > Subject: [dpdk-dev] [PATCH] ci: fix telemetry dependency in Travis > > From: "juraj.lin

[dpdk-dev] [PATCH v4 00/33] DPDK Trace support

2020-04-03 Thread jerinj
From: Jerin Jacob v4: ~~ This patch depends on http://patches.dpdk.org/patch/67758/ Depends-on:series-9191 1) Rebased to master. 2) Adapted to latest EAL directory structure change. 3) Fix possible build issue with out of tree application wherein it does not define -DALLOW_EXPERIMENTAL_API.

[dpdk-dev] [PATCH v4 04/33] eal/trace: implement trace register API

2020-04-03 Thread jerinj
From: Jerin Jacob The consumers of trace API defines the tracepoint and registers to eal. Internally these tracepoints will be stored in STAILQ for future use. This patch implements the tracepoint registration function. Signed-off-by: Jerin Jacob --- MAINTAINERS

[dpdk-dev] [PATCH v4 02/33] eal: introduce API for getting thread name

2020-04-03 Thread jerinj
From: Jerin Jacob Introduce rte_thread_getname() API to get the thread name and implement it for Linux and FreeBSD. FreeBSD does not support getting the thread name. One of the consumers of this API will be the trace subsystem where it used as an informative purpose. Signed-off-by: Jerin Jacob

[dpdk-dev] [PATCH v4 03/33] eal/trace: define the public API for trace support

2020-04-03 Thread jerinj
From: Jerin Jacob Define the public API for trace support. This patch also adds support for the build infrastructure and update the MAINTAINERS file for the trace subsystem. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- MAINTAINERS | 6 + confi

[dpdk-dev] [PATCH v4 01/33] meson: add libatomic as a global dependency for i686 clang

2020-04-03 Thread jerinj
From: Pavan Nikhilesh Add libatomic as a global dependency when compiling for 32-bit using clang. As we need libatomic for 64-bit atomic ops. Cc: bruce.richard...@intel.com Signed-off-by: Pavan Nikhilesh Acked-by: Bruce Richardson --- config/meson.build | 8 drivers

[dpdk-dev] [PATCH v4 05/33] eal/trace: implement trace operation APIs

2020-04-03 Thread jerinj
From: Jerin Jacob This patch implements the following public trace APIs. - rte_trace_global_is_enabled() - rte_trace_global_is_disabled() - rte_trace_is_id_invalid() - rte_trace_global_level_set() - rte_trace_global_level_get() - rte_trace_global_mode_set() - rte_trace_global_mode_get() - rte_tr

[dpdk-dev] [PATCH v4 06/33] eal/trace: add internal trace init and fini interface

2020-04-03 Thread jerinj
From: Jerin Jacob Define eal_trace_init() and eal_trace_fini() EAL interface functions that rte_eal_init() and rte_eal_cleanup() function can be use to initialize and finalize the trace subsystem. eal_trace_init() function will add the following functionality if trace is enabled through EAL comma

[dpdk-dev] [PATCH v4 07/33] eal/trace: get bootup timestamp for trace

2020-04-03 Thread jerinj
From: Jerin Jacob Find epoch_sec, epoch_nsec and uptime_ticks time information on eal_trace_init()/bootup to derive the time in the trace. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace.c | 3 +++ .../common/eal_common_trace_utils.c | 22 +

[dpdk-dev] [PATCH v4 08/33] eal/trace: create CTF TDSL metadata in memory

2020-04-03 Thread jerinj
From: Jerin Jacob Common trace format(CTF) defines the metadata[1][2] for trace events, This patch creates the metadata for the DPDK events in memory and latter this will be saved to trace directory on rte_trace_save() invocation. [1] https://diamon.org/ctf/#specification [2] https://diamon.org/

[dpdk-dev] [PATCH v4 09/33] eal/trace: handle CTF keyword collision

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Some of the keyword like align, event, "." and "->" etc will be used in CTF metadata syntax. This patch support for handling those keywords with DPDK events name. Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_common_trace_ctf.c | 119 +++

[dpdk-dev] [PATCH v4 10/33] eal/trace: implement trace memory allocation

2020-04-03 Thread jerinj
From: Jerin Jacob Trace memory will be allocated per thread to enable lockless trace events updates to the memory. The allocator will first attempt to allocate from hugepage, if not available from hugepage then fallback to malloc memory. Later in the patches series, This API will be hooked to DP

[dpdk-dev] [PATCH v4 11/33] eal/trace: implement debug dump function

2020-04-03 Thread jerinj
From: Jerin Jacob Implement rte_trace_metadata_dump() and rte_trace_dump() functions. Former one used to dump the CTF metadata file and the latter one to dump all the registered events and its status. Signed-off-by: Jerin Jacob Signed-off-by: Sunil Kumar Kori --- lib/librte_eal/common/eal_com

[dpdk-dev] [PATCH v4 12/33] eal/trace: implement trace save

2020-04-03 Thread jerinj
From: Jerin Jacob Implement rte_trace_save(), which will save the metadata file and trace memory snapshot to the trace directory. Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_utils.c | 80 +++ lib/librte_eal/rte_eal_version.map| 1 + 2 files

[dpdk-dev] [PATCH v4 13/33] eal/trace: implement registration payload

2020-04-03 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace memory emitters. When it used as registration payload, it will do the following to fulfill the registration jo

[dpdk-dev] [PATCH v4 18/33] eal/trace: add alarm tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add following alarm related trace points. rte_trace_lib_eal_alarm_set() rte_trace_lib_eal_alarm_cancel() Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c | 9 + lib/librte_eal/freebsd/eal_alarm.c | 3 +++ lib/librte_eal/incl

[dpdk-dev] [PATCH v4 16/33] eal/trace: hook internal trace APIs to FreeBSD

2020-04-03 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to FreeBSD EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/freebsd/eal.c| 10 ++ lib/librte_eal/freebsd/eal_thread.c | 3 +++ 2 files changed, 13 insertions(+) diff --git a/lib/librte_eal/freebsd/eal.c b/lib/librte

[dpdk-dev] [PATCH v4 14/33] eal/trace: implement provider payload

2020-04-03 Thread jerinj
From: Jerin Jacob The trace function payloads such as rte_trace_ctf_* have dual functions. The first to emit the payload for the registration function and the second one to act as trace mem emitters aka provider payload. When it used as provider payload, those function copy the trace field to tr

[dpdk-dev] [PATCH v4 17/33] eal/trace: add generic tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob This patch creates the following generic tracepoint for generic tracing when there is no dedicated tracepoint is available. rte_trace_lib_eal_generic_void() rte_trace_lib_eal_generic_u64() rte_trace_lib_eal_generic_u32() rte_trace_lib_eal_generic_u16() rte_trace_lib_eal_generic

[dpdk-dev] [PATCH v4 15/33] eal/trace: hook internal trace APIs to Linux

2020-04-03 Thread jerinj
From: Jerin Jacob Connect the internal trace interface API to Linux EAL. Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_thread.c | 3 ++- lib/librte_eal/linux/eal.c| 9 + lib/librte_eal/linux/eal_thread.c | 3 +++ 3 files changed, 14 insertions(

[dpdk-dev] [PATCH v4 21/33] eal/trace: add thread tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following thread related tracepoints. rte_trace_lib_eal_thread_remote_launch; rte_trace_lib_eal_thread_lcore_ready; Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_trace_points.c | 9 + lib/librte_eal/freebsd/eal_interrupts.c | 2 +-

[dpdk-dev] [PATCH v4 23/33] eal/trace: add trace level configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-level EAL parameter to configure global and trace point specific level. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 19 lib/librte_eal/common/eal_common_options.c| 19 +++- lib/librte_eal/co

[dpdk-dev] [PATCH v4 20/33] eal/trace: add memzone tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following memzone related tracepoints. rte_trace_lib_eal_memzone_reserve rte_trace_lib_eal_memzone_lookup rte_trace_lib_eal_memzone_free Signed-off-by: Jerin Jacob --- lib/librte_eal/common/eal_common_memzone.c| 9 +++ .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v4 22/33] eal/trace: add interrupt tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following interrupt related tracepoints. rte_trace_lib_eal_intr_callback_register; rte_trace_lib_eal_intr_callback_unregister; rte_trace_lib_eal_intr_enable; rte_trace_lib_eal_intr_disable; Signed-off-by: Jerin Jacob --- .../common/eal_common_trace_points.c

[dpdk-dev] [PATCH v4 19/33] eal/trace: add memory tracepoints

2020-04-03 Thread jerinj
From: Jerin Jacob Add the following memory-related tracepoints. rte_trace_lib_eal_mem_zmalloc; rte_trace_lib_eal_mem_malloc; rte_trace_lib_eal_mem_realloc; rte_trace_lib_eal_mem_free; rte_malloc() and rte_free() has been used in the trace implementation, in order to avoid tracing implementation

[dpdk-dev] [PATCH v4 24/33] eal/trace: add trace dir configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-dir EAL parameter to configure directory where traces will be generated. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 11 lib/librte_eal/common/eal_common_options.c| 15 ++ .../common/eal_c

[dpdk-dev] [PATCH v4 27/33] eal/trace: add unit test cases

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Example commands to run UT and check the traces with babeltrace viewer. - Delete the existing /root/dpdk-traces/ directory if needed. > sudo rm -rf /root/dpdk-traces/ - Start the dpdk-test > sudo ./build/app/test/dpdk-test -c 0x3 - --trace-level=8 - Run trace_autotest >

[dpdk-dev] [PATCH v4 26/33] eal/trace: add trace mode configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-mode eal parameter to configure event record mode when ring buffers are full. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 12 ++ lib/librte_eal/common/eal_common_options.c| 17 .../com

[dpdk-dev] [PATCH v4 25/33] eal/trace: add trace bufsize configuration parameter

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Trace library exposes --trace-bufsz EAL parameter to configure maximum size of ring buffer where events are to be stored. Signed-off-by: Sunil Kumar Kori --- doc/guides/linux_gsg/eal_args.include.rst | 13 lib/librte_eal/common/eal_common_options.c| 17 +

[dpdk-dev] [PATCH v4 30/33] eventdev: add tracepoints

2020-04-03 Thread jerinj
From: Sunil Kumar Kori Add tracepoints at important and mandatory APIs for tracing support. Signed-off-by: Sunil Kumar Kori --- lib/librte_eventdev/Makefile | 3 + lib/librte_eventdev/eventdev_trace_points.c | 173 +++ lib/librte_eventdev/meson.build

  1   2   >