[dpdk-dev] [PATCH v3 0/4] aarch32 compilation

2020-06-24 Thread Ruifeng Wang
Build aarch32 binary on aarch64 platform hit issues with l3fwd [1] and ixgbe PMD [2]. This patch set is to fix these. When building with make, please refer to guide: http://patches.dpdk.org/patch/62820/ When building with meson, requires series: http://patches.dpdk.org/cover/69536/ [1] https://m

[dpdk-dev] [PATCH v3 1/4] arch/arm: add vcopyq intrinsic for aarch32

2020-06-24 Thread Ruifeng Wang
vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic. This fixes build of examples/l3fwd for armv7. Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Ferruh Yigit --- lib/librte_eal/arm

[dpdk-dev] [PATCH v3 2/4] net/ixgbe: add support for aarch32

2020-06-24 Thread Ruifeng Wang
Expand vector PMD support to aarch32. Enable ixgbe PMD by default for armv7 make build. Signed-off-by: Ruifeng Wang --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 - drivers/net/ixgbe/Makefile | 2 +- drivers/net/ixgbe/ixgbe_rxtx.h | 4 ++-- 3 files changed, 3 insertion

[dpdk-dev] [PATCH v3 4/4] net/i40e: add support for aarch32

2020-06-24 Thread Ruifeng Wang
Expand vector PMD support to aarch32. Enable i40e PMD by default for armv7 make build. Signed-off-by: Ruifeng Wang --- config/defconfig_arm-armv7a-linuxapp-gcc | 1 - drivers/net/i40e/Makefile| 2 +- drivers/net/i40e/i40e_rxtx_vec_neon.c| 2 +- 3 files changed, 2 insertions(+

[dpdk-dev] [PATCH v3 3/4] net/ixgbe: fix include of vector header file

2020-06-24 Thread Ruifeng Wang
The include of 'arm_neon.h' causes issues to old gcc and aarch32. Including 'rte_vect.h' instead fixes these issues. Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM") Cc: sta...@dpdk.org Signed-off-by: Ruifeng Wang --- drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +-- 1 file cha

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Maxime Coquelin
Good morning Matan, On 6/24/20 7:54 AM, Matan Azrad wrote: > Ho Maxime > > Good morning > > From: Maxime Coquelin: >> On 6/23/20 4:52 PM, Matan Azrad wrote: >>> >>> -Original Message- From: Maxime Coquelin Sent: Tuesday, June 23, 2020 4:56 PM To: Matan Azrad ; Xiao W

Re: [dpdk-dev] [PATCH] ethdev: verify reserved HW ring

2020-06-24 Thread Ferruh Yigit
On 6/23/2020 5:58 PM, Andrew Rybchenko wrote: > On 6/23/20 7:41 PM, Ferruh Yigit wrote: >> Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based >> on name match, but other requested attributes are discarded. >> This may cause driver using a memzone with wrong size or alignment. >

Re: [dpdk-dev] [PATCH v4] net/ice: initialize and update RSS based on user request

2020-06-24 Thread Zhang, Qi Z
> -Original Message- > From: Jiang, JunyuX > Sent: Wednesday, June 24, 2020 10:10 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; Su, Simei ; Jiang, JunyuX > > Subject: [PATCH v4] net/ice: initialize and update RSS based on user request > > Initialize and update RSS configu

Re: [dpdk-dev] [PATCH v2] eal: fix epoll fd list rebuild

2020-06-24 Thread Thomas Monjalon
19/06/2020 15:59, Harman Kalra: > An issue has been observed where epoll file descriptor > list rebuilds every time an interrupt/alarm event is > received. > > eal_intr_process_interrupts() should notify pipe fd only > if any source is removed from the source list i.e (rv > 0) > > Fixes: 0c7ce182

[dpdk-dev] [PATCH v2 00/42] update e1000 base code

2020-06-24 Thread Guinan Sun
update e1000 base code. --- v2: * Remove codes about i225. Guinan Sun (42): net/e1000/base: resolve flash presence for i210 devices net/e1000/base: i210 slow system clock update net/e1000/base: add ICL device id's net/e1000/base: remove shadowing variable declarations net/e1000/base: int

[dpdk-dev] [PATCH v2 01/42] net/e1000/base: resolve flash presence for i210 devices

2020-06-24 Thread Guinan Sun
There is a conflict with legacy i210. This patch is for compatibility with i211. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_nvm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_nvm.c b/drivers/ne

[dpdk-dev] [PATCH v2 02/42] net/e1000/base: i210 slow system clock update

2020-06-24 Thread Guinan Sun
This code is required for the update for system clock. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e10

[dpdk-dev] [PATCH v2 06/42] net/e1000/base: modify MAC initialization for i211

2020-06-24 Thread Guinan Sun
Introduce SF/FW syncronization, acquire and release for i211 devices. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/bas

[dpdk-dev] [PATCH v2 04/42] net/e1000/base: remove shadowing variable declarations

2020-06-24 Thread Guinan Sun
The variable phy_reg is already declared at the top of e1000_check_for_copper_link_ich8lan() and we don't need to re-declare it in the inner if{} scope. Remove the unnecessary extra declarations which fixes the sparse warning generated by shadowed variable names. Signed-off-by: Jacob Keller Signe

[dpdk-dev] [PATCH v2 03/42] net/e1000/base: add ICL device id's

2020-06-24 Thread Guinan Sun
This patch contains a preliminary support for new LAN device ID's. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 4 drivers/net/e1000/base/e1000_hw.h | 4 2 files changed, 8 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c

[dpdk-dev] [PATCH v2 05/42] net/e1000/base: introduce flags

2020-06-24 Thread Guinan Sun
Introduce E1000_TARC0_CB_MULTIQ_2_REQ flag to make flexible adjusting number of outstanding requests. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e

[dpdk-dev] [PATCH v2 07/42] net/e1000/base: modify parens to match other MAC checks

2020-06-24 Thread Guinan Sun
Fix parens to match the rest of the MAC checks. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c in

[dpdk-dev] [PATCH v2 10/42] net/e1000/base: add function parameter descriptions

2020-06-24 Thread Guinan Sun
Add function parameter descriptions to address gcc 7 warnings. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 11 +-- drivers/net/e1000/base/e1000_mac.c | 8 drivers/net/e1000/base/e1000_mbx.c | 4 drivers/net/e1000/

[dpdk-dev] [PATCH v2 08/42] net/e1000/base: expose xmdio methods

2020-06-24 Thread Guinan Sun
move read and write xmdio methods to e1000_phy. Signed-off-by: Neftin Sasha Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 71 drivers/net/e1000/base/e1000_i210.h | 4 -- drivers/net/e1000/base/e1000_phy.c | 72 + d

[dpdk-dev] [PATCH v2 09/42] net/e1000/base: fall through explicitly

2020-06-24 Thread Guinan Sun
This patch adds/changes fall through comments to address new warnings produced by gcc 7. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 2 +- drivers/net/e1000/base/e1000_mbx.c | 1 + drivers/net/e1000/base/e1000_phy.c | 1 + 3 files change

[dpdk-dev] [PATCH v2 11/42] net/e1000/base: modify fall through code comments

2020-06-24 Thread Guinan Sun
Found some inconsistent code comments when it came to when we "fall through", so made them more consistent and non-repetitive. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/e1

[dpdk-dev] [PATCH v2 12/42] net/e1000/base: modify klocwork errors

2020-06-24 Thread Guinan Sun
This patch fixes klocwork scans errors relating to operands in bitwise operations having different sizes. Signed-off-by: Robert Konklewski Signed-off-by: Doug Dziggel Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 2 +- drivers/net/e1000/base/e1000_i210.c | 2 +- drivers

[dpdk-dev] [PATCH v2 13/42] net/e1000/base: modify klockwork about unused return values

2020-06-24 Thread Guinan Sun
Klockwork found unreachable code since *clock_in_i2c_* always return success. Don't return unused s32 and don't check for constants. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletio

[dpdk-dev] [PATCH v2 15/42] net/e1000/base: modify HW level time sync mechanisms

2020-06-24 Thread Guinan Sun
Add additinal configuration space access to allow HW level time sync mechanism. Signed-off-by: Efimov Evgeny Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 18 ++ drivers/net/e1000/base/e1000_ich8lan.h | 1 + 2 files changed, 19 insertions(+) diff --git

[dpdk-dev] [PATCH v2 16/42] net/e1000/base: modify description

2020-06-24 Thread Guinan Sun
Wrong description was found in the mentioned file, so fix them. Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_80003es2lan.c | 1 - drivers/net/e1000/base/e1000_ich8lan.c | 4 +++- drivers/net/e1000/base/e1000_phy.c | 3 +++ 3 files changed

[dpdk-dev] [PATCH v2 14/42] net/e1000/base: improve coding style

2020-06-24 Thread Guinan Sun
fix typo in piece of code of NVM access for SPT. And cleans up the remaining instances in the shared code where it was not adhering to the Linux code standard. Signed-off-by: Jeff Kirsher Signed-off-by: Neftin Sasha Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c| 8 +++-

[dpdk-dev] [PATCH v2 17/42] net/e1000/base: remove duplicated codes from 82575

2020-06-24 Thread Guinan Sun
These files will improve e1000_82575 codes. Remove the code duplication from e1000_82575 files. Remove the licenses. Clean family specific functions from base. Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/Makefile | 1 +

[dpdk-dev] [PATCH v2 19/42] net/e1000/base: cleanup duplicate declaration

2020-06-24 Thread Guinan Sun
Fix up a stray and duplicate function declaration. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/e1000/base/e1000_api.h b/drivers/net/e1000/base/e1000_api.h index 3054d5b9d..d719b691a

[dpdk-dev] [PATCH v2 18/42] net/e1000/base: add definitions for ETQF register bit

2020-06-24 Thread Guinan Sun
Add definitions for ETQF register bit and modify some comments. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drive

[dpdk-dev] [PATCH v2 21/42] net/e1000/base: move definitions from 82575 to defines file

2020-06-24 Thread Guinan Sun
Move definitions from 82575 to e1000_defines.h file. The patch is for refactoring the codes. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 8 drivers/net/e1000/base/e1000_defines.h | 11 +++ 2 files changed, 11 insertions(+), 8 deletions(-) diff --git

[dpdk-dev] [PATCH v2 20/42] net/e1000/base: expose MAC functions

2020-06-24 Thread Guinan Sun
Now the functions are being accessed outside of the file, we need to properly expose them for silicon families to use. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_mac.c | 3 +-- drivers/net/e1000/base/e1000_mac.h | 1 + 2 files changed, 2 insertions(+)

[dpdk-dev] [PATCH v2 22/42] net/e1000/base: add define to PCIm function state

2020-06-24 Thread Guinan Sun
Added define to pcim function state. Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h b/drivers/net/e1000/base/e1000_defines.h index 12747918c..b73a67f3

[dpdk-dev] [PATCH v2 24/42] net/e1000/base: move the device reset definition

2020-06-24 Thread Guinan Sun
Move the device reset definition from _82575.h file to _defines.h file. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 1 - drivers/net/e1000/base/e1000_defines.h | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/

[dpdk-dev] [PATCH v2 26/42] net/e1000/base: add missing device ID

2020-06-24 Thread Guinan Sun
Adding Intel(R) I210 Gigabit Network Connection 15F6 device ID for SGMII flashless automotive device. Signed-off-by: Kamil Bednarczyk Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + 2 files changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v2 23/42] net/e1000/base: add missing register defines

2020-06-24 Thread Guinan Sun
Added defines for the EEC, SHADOWINF and FLFWUPDATE registers needed for the nvmupd_validate_offset function to correctly validate the NVM update offset. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 5 + 1 file changed, 5 insertions(+) dif

[dpdk-dev] [PATCH v2 25/42] net/e1000/base: increased timeout for ME ULP exit

2020-06-24 Thread Guinan Sun
Due timing issues in WHL and since recovery by host is not always supported, increased timeout for ME to finish ULP exit flow for Nahum before timer expiration. Signed-off-by: Efrati Nir Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 +-- 1 file changed, 5 insertio

[dpdk-dev] [PATCH v2 27/42] net/e1000/base: expose more future extended NVM

2020-06-24 Thread Guinan Sun
Future extended NVM 5 (five) required for a Dynamic Power Gating control in the MAC. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1

[dpdk-dev] [PATCH v2 28/42] net/e1000/base: add definition of EEE 2.5G setup register

2020-06-24 Thread Guinan Sun
This is a new register which holds the minimum time in microseconds for 2500BASE-T operation. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000

[dpdk-dev] [PATCH v2 31/42] net/e1000/base: add missed define for VFTA

2020-06-24 Thread Guinan Sun
VLAN filtering using the VFTA (VLAN Filter Table Array) and should be initialized prior to setting rx mode. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h

[dpdk-dev] [PATCH v2 29/42] net/e1000/base: remove definitions

2020-06-24 Thread Guinan Sun
Remove defines from 82575.h. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/net/e1000/base/e1000_82575.h b/drivers/net/e1000/base/e1000_82575.h index e572fe0e1..41ead

[dpdk-dev] [PATCH v2 30/42] net/e1000/base: remove useless statement

2020-06-24 Thread Guinan Sun
As it stands now, this fix will not change the current functionality of the code. In addition, we remove the comment that seemed to be a copy/paste from a separate implementation. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 --- 1 file

[dpdk-dev] [PATCH v2 32/42] net/e1000/base: modify flow control setup

2020-06-24 Thread Guinan Sun
Customers had a problem with large pings after connected standby. This is due to the requirement of maintaining link after CS - the driver blocks resets during "AdapterStart" and skips flow control setup. Added condition in e1000_setup_link_ich8lan.c function that always setup flow control, and set

[dpdk-dev] [PATCH v2 34/42] net/e1000/base: expose new FEXTNVM registers and masks

2020-06-24 Thread Guinan Sun
Adding defines for FEXTNVM8 and FEXTNVM12 registers with new masks for future use. Signed-off-by: Nir Efrati Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 3 ++- drivers/net/e1000/base/e1000_regs.h| 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH v2 36/42] net/e1000/base: add support for Nahum10

2020-06-24 Thread Guinan Sun
Add support to a new MAC type (for Nahum10). Signed-off-by: Roman Fridlyand Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_hw.h | 1 + drivers/net/e1000/base/e1000_ich8lan.c | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e10

[dpdk-dev] [PATCH v2 33/42] net/e1000/base: led blinking fix for i210

2020-06-24 Thread Guinan Sun
Added initialization of identification LED. Signed-off-by: Maciej Hefczyc Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c index 553803261..d32b0f

[dpdk-dev] [PATCH v2 35/42] net/e1000/base: cleanup duplicate defines

2020-06-24 Thread Guinan Sun
Now that more than one silicon family uses the filter defines for ETQF, move the defines out of the 82575 silicon family header, into the general register/defines location. This will reduce the duplicate defines for drivers that support all the silicon families in one driver. Signed-off-by: Jeff

Re: [dpdk-dev] [PATCH v8 8/9] bus/pci: support Windows with bifurcated drivers

2020-06-24 Thread Tal Shnaiderman
> Subject: Re: [PATCH v8 8/9] bus/pci: support Windows with bifurcated > drivers > > [snip] > > + /* kernel driver type is unsupported */ > > + RTE_LOG(DEBUG, EAL, > > + "kernel driver type for PCI device " PCI_PRI_FMT "," > > + " is unsuppor

[dpdk-dev] [PATCH v2 37/42] net/e1000/base: add fall-through comments for switch cases

2020-06-24 Thread Guinan Sun
Add fall-through comments to cases without break statements. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_vf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/e1000/base/e1000_vf.c b/drivers/net/e1000/base/e1000_vf.c index 543fa7741..8d

[dpdk-dev] [PATCH v2 39/42] net/e1000/base: introduce DPGFR register

2020-06-24 Thread Guinan Sun
Defined DPGFR, Dynamic Power Gate Force Control Register. Signed-off-by: Vitaly Lifshits Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1000_regs.h index b867ba6

[dpdk-dev] [PATCH v2 41/42] net/e1000/base: modify copyright

2020-06-24 Thread Guinan Sun
Modify the copyright of the file header. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_80003es2lan.c | 2 +- drivers/net/e1000/base/e1000_80003es2lan.h | 2 +- drivers/net/e1000/base/e1000_82540.c | 2 +- drivers/net/e1000/base/e1000_82541.c | 2 +- drivers/net/e1000/bas

[dpdk-dev] [PATCH v2 38/42] net/e1000/base: modify typo in Alder Lake brand name

2020-06-24 Thread Guinan Sun
Fix typo in brand name. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 7 +++ drivers/net/e1000/base/e1000_hw.h | 4 2 files changed, 11 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c b/drivers/net/e1000/base/e1000_api.c

[dpdk-dev] [PATCH v2 40/42] net/e1000/base: remove conditional compilation wrapper

2020-06-24 Thread Guinan Sun
Remove conditional compilation statements. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 2 +- drivers/net/e1000/base/e1000_82575.h | 2 -- drivers/net/e1000/base/e1000_defines.h | 9 + drivers/net/e1000/base/e1000_hw.h | 4 drivers/net/e1000/base

[dpdk-dev] [PATCH v2 42/42] net/e1000/base: update version

2020-06-24 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index 56738d001..b84ee5ad6 100644 --- a/drivers/net/e1000/base/REA

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix macros to align value

2020-06-24 Thread Thomas Monjalon
09/06/2020 21:17, Harman Kalra: > Found an issue while using RTE_ALIGN_MUL_NEAR with an > expression, like as passed in estimate_tsc_freq(). > RTE_ALIGN_MUL_FLOOR resulted in unexpected value in the > above function as division has more precedence over > substraction. The only change I see is addi

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] eal: fix macros to align value

2020-06-24 Thread Harman Kalra
On Wed, Jun 24, 2020 at 10:13:18AM +0200, Thomas Monjalon wrote: > External Email > > -- > 09/06/2020 21:17, Harman Kalra: > > Found an issue while using RTE_ALIGN_MUL_NEAR with an > > expression, like as passed in estimate_tsc_fr

[dpdk-dev] [PATCH v9 03/10] pci: use OS generic memory mapping functions

2020-06-24 Thread talshn
From: Tal Shnaiderman Changing all of PCIs Unix memory mapping to the new memory allocation API wrapper. Change all of PCI mapping function usage in bus/pci to support the new API. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/bsd/pci.c | 2 +- drivers/bus/pci/linux/pci_uio.c

[dpdk-dev] [PATCH v9 00/10] Windows bus/pci support

2020-06-24 Thread talshn
From: Tal Shnaiderman This patchset implements the EAL and PCI functions needed for probing PMDs using RTE_KDRV_NONE on Windows. --- v9: * Split the patch of common OS file to config and options patches (ThomasM). * Remove rte_ prefixes from new functions as they are eal intern

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] eal: fix macros to align value

2020-06-24 Thread Thomas Monjalon
24/06/2020 10:24, Harman Kalra: > On Wed, Jun 24, 2020 at 10:13:18AM +0200, Thomas Monjalon wrote: > > 09/06/2020 21:17, Harman Kalra: > > > Found an issue while using RTE_ALIGN_MUL_NEAR with an > > > expression, like as passed in estimate_tsc_freq(). > > > RTE_ALIGN_MUL_FLOOR resulted in unexpecte

[dpdk-dev] [PATCH v9 10/10] build: generate version.map file for MinGW on Windows

2020-06-24 Thread talshn
From: Tal Shnaiderman The MinGW build for Windows has special cases where exported function contain additional prefix: __emutls_v.per_lcore__* To avoid adding those prefixed functions to the version.map file the map_to_def.py script was modified to create a map file for MinGW with the needed ch

[dpdk-dev] [PATCH v9 09/10] bus/pci: support Windows with bifurcated drivers

2020-06-24 Thread talshn
From: Tal Shnaiderman Uses SetupAPI.h functions to scan PCI tree. Uses DEVPKEY_Device_Numa_Node to get the PCI NUMA node. Uses SPDRP_BUSNUMBER and SPDRP_BUSNUMBER to get the BDF. scanning currently supports types RTE_KDRV_NONE. Signed-off-by: Tal Shnaiderman --- drivers/bus/pci/windows/pci.c

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 24, 2020 10:22 AM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > Good morning Matan, > > On 6/24/20 7:54 AM, Matan Azrad wrote: > > Ho Maxi

[dpdk-dev] [PATCH v1] net/virtio: simplify variable name

2020-06-24 Thread Joyce Kong
Virtio_hw *hw has been pointed to vq->hw, it is better to use hw instead of vq->hw in later code. Signed-off-by: Joyce Kong --- drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/dri

Re: [dpdk-dev] [RFC] ethdev: add a field for rte_eth_rxq_info

2020-06-24 Thread Ferruh Yigit
On 6/24/2020 4:48 AM, Chengchang Tang wrote: > > On 2020/6/23 17:30, Andrew Rybchenko wrote: >> On 6/23/20 9:48 AM, Chengchang Tang wrote: >>> In common practice, PMD configure the rx_buf_size according to the data >>> room size of the object in mempool. But in fact the final value is related >>>

Re: [dpdk-dev] [PATCH] bus/pci: optimize bus scan

2020-06-24 Thread Jerin Jacob
On Wed, Jun 17, 2020 at 3:09 AM Thomas Monjalon wrote: > > 10/06/2020 13:50, jer...@marvell.com: > > From: Jerin Jacob > > > > In order to optimize the PCI management, RTE_KDRV_NONE based > > device driver probing removed by not adding them to list in > > the scan phase. > > > > The legacy virtio

Re: [dpdk-dev] [PATCH] net/octeontx2: add cn98xx support

2020-06-24 Thread Jerin Jacob
On Wed, Jun 17, 2020 at 8:36 PM Harman Kalra wrote: > > New cn98xx SOC comes up with two NIX blocks wrt > cn96xx, cn93xx, to achieve higher performance. > > Adding support for cn98xx where need a logic to > detect if the LF is attached to NIX0 or NIX1 and > then accordingly use the respective NIX

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Maxime Coquelin
On 6/24/20 10:38 AM, Matan Azrad wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, June 24, 2020 10:22 AM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> Good morning Matan,

Re: [dpdk-dev] [PATCH v3 0/2] Support EAL debug functions on Windows

2020-06-24 Thread Thomas Monjalon
24/06/2020 00:48, Dmitry Kozlyuk: > On Tue, 23 Jun 2020 23:57:19 +0300, tal...@mellanox.com wrote: > > > From: Tal Shnaiderman > > > > This patchset adds support for the EAL debug function on Windows by > > implementing backtracing in rte_dump_stack and cleanup calls in > > rte_eal_cleanup. >

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread David Marchand
On Tue, Jun 23, 2020 at 3:16 PM Ananyev, Konstantin wrote: > > Even before this series, MP has no protection on lcore placing between > > primary and secondary processes. > > Agree, it is not a new problem, it has been there for a while. > Though making lcore assignment dynamic will make it more n

[dpdk-dev] [PATCH v2] ethdev: verify reserved HW ring

2020-06-24 Thread Ferruh Yigit
Function 'rte_eth_dma_zone_reserve()' returns an existing memzone based on name match, but other requested attributes are discarded. This may cause driver using a memzone with wrong size or alignment. Verify size, alignment and socket_id for matched memzone, and do not use memzone if any one of th

[dpdk-dev] [PATCH 20.11] eal: simplify exit functions

2020-06-24 Thread Thomas Monjalon
The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, and not customizable with meson. It is completely removed. The function rte_dump_registers is a trace of the bare metal support era, and was not supported in userland. It is completely removed. Signed-off-by: Thomas Monjalon --- Becaus

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread Bruce Richardson
On Wed, Jun 24, 2020 at 11:23:55AM +0200, David Marchand wrote: > On Tue, Jun 23, 2020 at 3:16 PM Ananyev, Konstantin > wrote: > > > Even before this series, MP has no protection on lcore placing between > > > primary and secondary processes. > > > > Agree, it is not a new problem, it has been the

Re: [dpdk-dev] [PATCH v2] app/test/test_distributor.c: prevent memory leakages from the pool

2020-06-24 Thread Sarosh Arif
Some tests are failing on this patch but I don't think the reason behind the failure is this patch. Is there a certain way to know that the problem is in the patch or somewhere else? On Wed, Jun 24, 2020 at 2:04 PM Sarosh Arif wrote: > > Some tests are failing on this patch but I don't think the

Re: [dpdk-dev] [EXT] Re: [dpdk-stable] [PATCH] eal: fix macros to align value

2020-06-24 Thread Harman Kalra
On Wed, Jun 24, 2020 at 10:30:18AM +0200, Thomas Monjalon wrote: > 24/06/2020 10:24, Harman Kalra: > > On Wed, Jun 24, 2020 at 10:13:18AM +0200, Thomas Monjalon wrote: > > > 09/06/2020 21:17, Harman Kalra: > > > > Found an issue while using RTE_ALIGN_MUL_NEAR with an > > > > expression, like as pas

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread Thomas Monjalon
24/06/2020 11:56, Bruce Richardson: > On Wed, Jun 24, 2020 at 11:23:55AM +0200, David Marchand wrote: > > On Tue, Jun 23, 2020 at 3:16 PM Ananyev, Konstantin > > wrote: > > > > Even before this series, MP has no protection on lcore placing between > > > > primary and secondary processes. > > > > >

[dpdk-dev] [PATCH v9 07/10] drivers: fix incorrect meson import folder for Windows

2020-06-24 Thread talshn
From: Tal Shnaiderman import library (/IMPLIB) in meson.build should use the 'drivers' and not 'libs' folder. The error is: fatal error LNK1149: output filename matches input filename. The fix uses the correct folder. Fixes: 5ed3766981 ("drivers: process shared link dependencies as for libs")

[dpdk-dev] [PATCH v9 08/10] bus/pci: introduce Windows support with stubs

2020-06-24 Thread talshn
From: Tal Shnaiderman Addition of stub eal and bus/pci functions to compile bus/pci for Windows. Signed-off-by: Tal Shnaiderman --- drivers/baseband/meson.build | 4 + drivers/bus/ifpga/meson.build | 6 ++ drivers/bus/pci/meson.build| 14 ++- drivers/bus/pci/pci_common.

[dpdk-dev] [PATCH v9 06/10] drivers: ignore pmdinfogen generation for Windows

2020-06-24 Thread talshn
From: Tal Shnaiderman pmdinfogen generation is currently unsupported for Windows. The relevant part in meson.build is skipped. Signed-off-by: Tal Shnaiderman --- drivers/meson.build | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/meson.

[dpdk-dev] [PATCH v9 04/10] pci: build on Windows

2020-06-24 Thread talshn
From: Tal Shnaiderman Added in rte_pci header file to include off_t type since it is missing for Windows. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/rte_eal_exports.def | 1 + lib/librte_pci/rte_pci.h | 1 + lib/meson.build| 5 - 3 files changed, 6 ins

[dpdk-dev] [PATCH v9 05/10] pci: fix format warning on Windows

2020-06-24 Thread talshn
From: Tal Shnaiderman the struct rte_pci_addr defines domain as uint32_t variable however the PCI_PRI_FMT macro used for logging the struct sets the format of domain to uint16_t. The mismatch causes the following warning messages in Windows clang build: format specifies type 'unsigned short' bu

[dpdk-dev] [PATCH v9 02/10] eal: move OS common options functions

2020-06-24 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_options.c. Those functions are getter functions for rte_application_usage_hook. Signed-off-by: Tal Shnaiderman --- lib/librte_eal/common/eal_common_options.c | 23 +++ lib/librte_eal/common/

[dpdk-dev] [PATCH v9 01/10] eal: move OS common config objects

2020-06-24 Thread talshn
From: Tal Shnaiderman Move common functions between Unix and Windows to eal_common_config.c. Those functions are getter functions for IOVA, configuration, Multi-process. Move rte_config, internal_config, early_mem_config and runtime_dir to be defined in the common file with getter functions. R

[dpdk-dev] [PATCH v2] eal: fix macros to align value

2020-06-24 Thread Harman Kalra
Found an issue while using RTE_ALIGN_MUL_NEAR with an expression, like as passed in estimate_tsc_freq(). RTE_ALIGN_MUL_FLOOR resulted in unexpected value as parathesis are required to evaluate an expression. Fixes: 5120203d753f ("eal: add macros to align value to multiple") Cc: sta...@dpdk.org Si

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread Ananyev, Konstantin
> -Original Message- > From: David Marchand > Sent: Wednesday, June 24, 2020 10:24 AM > To: Ananyev, Konstantin > Cc: dev@dpdk.org; jerinjac...@gmail.com; Richardson, Bruce > ; m...@ashroe.eu; ktray...@redhat.com; > Stokes, Ian ; i.maxim...@ovn.org; Thomas Monjalon > ; Mcnamara, John

Re: [dpdk-dev] [PATCH] drivers/net/bonding: fix bug for lacp negotiation failed

2020-06-24 Thread Thomas Monjalon
Any review please? 19/05/2020 13:18, luyicai: > When two host is connected directly without any devices like switch, > and also enable dedicated tx/rx queues on bonding devices slaves, > rx_machine_update would recieving partner lacp negotiation packets, > which partner's port mac filled with zero

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread Ananyev, Konstantin
> > 24/06/2020 11:56, Bruce Richardson: > > On Wed, Jun 24, 2020 at 11:23:55AM +0200, David Marchand wrote: > > > On Tue, Jun 23, 2020 at 3:16 PM Ananyev, Konstantin > > > wrote: > > > > > Even before this series, MP has no protection on lcore placing between > > > > > primary and secondary proce

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread David Marchand
On Wed, Jun 24, 2020 at 12:40 PM Ananyev, Konstantin wrote: > > Supporting lcore allocation in MP requires exchanges between > > primary/secondary processes like what we have for memory allocations. > > It will be quite a beast to get to work fine, while not even knowing > > if people actually wan

[dpdk-dev] [PATCH 3/7] net/mlx5: fix iterator type in Rx queue management

2020-06-24 Thread Michael Baum
The mlx5_check_vec_rx_support function in the mlx5_rxtx_vec.c file passes the RX queues array in the loop. Similarly, the mlx5_mprq_enabled function in the mlx5_rxq.c file passes the RX queues array in the loop. In both cases, the iterator of the loop is called i and the variable representing the

[dpdk-dev] [PATCH 4/7] net/mlx4: use anonymous DV allocator argument

2020-06-24 Thread Michael Baum
The mlx4_pci_probe function defines an struct mlx4dv_ctx_allocators type variable several hundred rows after it starts, with the only use it being passed as a parameter to the mlx4_glue->dv_set_context_attr function. However, according to DPDK Coding Style Guidelines, variables should be declared a

[dpdk-dev] [PATCH 5/7] net/mlx4: remove useless assignment

2020-06-24 Thread Michael Baum
The mlx4_ibv_device_to_pci_addr function defines a variable called ret inside a loop and uses it. During the loop, the function assigns a value within the variable and breaks from the loop, so that this assigning has done nothing and is actually unnecessary. Remove the unnecessary assigning. Sig

[dpdk-dev] [PATCH 6/7] common/mlx5: remove useless assignment

2020-06-24 Thread Michael Baum
The mlx5_dev_to_pci_addr function defines a variable called ret inside a loop and uses it. During the loop, the function assigns a value within the variable and breaks from the loop, so that this assigning has done nothing and is actually unnecessary. Remove the unnecessary assigning. Signed-off

[dpdk-dev] [PATCH v2] bus/pci: optimize bus scan

2020-06-24 Thread jerinj
From: Jerin Jacob In order to optimize the PCI management, RTE_KDRV_NONE based device driver probing removed by not adding them to list in the scan phase. The legacy virtio is the only consumer of RTE_KDRV_NONE based device driver probe scheme. The legacy virtio support will be available through

Re: [dpdk-dev] [PATCH] lib/librte_net: fix bug for ipv4 checksum calculating

2020-06-24 Thread Thomas Monjalon
26/05/2020 12:08, guohongzhi: > From: Hongzhi Guo > > 0x is invalid for IPv4 checksum(RFC1624) > > Fixes: 6006818cfb26 ("net: new checksum functions") > Cc: sta...@dpdk.org > > Reviewed-By: Morten Brørup > Acked-by: Olivier Matz > > Signed-off-by: Hongzhi Guo The Signed-off should be i

Re: [dpdk-dev] [PATCH v3 6/9] eal: register non-EAL threads as lcores

2020-06-24 Thread Ananyev, Konstantin
> > On Wed, Jun 24, 2020 at 12:40 PM Ananyev, Konstantin > wrote: > > > Supporting lcore allocation in MP requires exchanges between > > > primary/secondary processes like what we have for memory allocations. > > > It will be quite a beast to get to work fine, while not even knowing > > > if peo

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-06-24 Thread Thomas Monjalon
27/05/2020 15:40, guohongzhi: > From: Hongzhi Guo > > __rte_raw_cksum should consider Big Endian. We need to explain the logic in the commit log. > Signed-off-by: Hongzhi Guo > --- > +#if (RTE_BYTE_ORDER == RTE_BIG_ENDIAN) > + sum += *((const uint8_t *)u16_buf) << 8; > +#else >

[dpdk-dev] [PATCH v2 03/14] vhost: introduce vDPA devices class

2020-06-24 Thread Maxime Coquelin
This patch introduces vDPA device class. It will enable application to iterate over the vDPA devices. Signed-off-by: Maxime Coquelin --- lib/librte_vhost/vdpa.c | 115 +--- 1 file changed, 97 insertions(+), 18 deletions(-) diff --git a/lib/librte_vhost/vdpa.c

[dpdk-dev] [PATCH v2 00/14] vDPA API and framework rework

2020-06-24 Thread Maxime Coquelin
This series aims to rework the vDPA framework and its API to better fit into the DPDK device model and also be more easily consumable by applications. Main changes are creating a device class for vDPA, which enables applications to iterate vDPA devices in a generic way: RTE_DEV_FOREACH(dev, "clas

[dpdk-dev] [PATCH v2 05/14] vhost: replace device ID in vDPA ops

2020-06-24 Thread Maxime Coquelin
This patch is a preliminary step to get rid of the vDPA device ID. It makes vDPA callbacks to use the vDPA device struct as a reference instead of the ID. Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 79 ++-- drivers/vdpa/mlx5/mlx5_vdpa.c | 134

[dpdk-dev] [PATCH v2 04/14] vhost: make vDPA framework bus agnostic

2020-06-24 Thread Maxime Coquelin
This patch makes the vDPA framework to no more support only PCI devices, but any devices by relying on the generic device name as identifier. Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 +-- drivers/vdpa/mlx5/mlx5_vdpa.c | 8 +-- drivers/vdpa/mlx5/mlx

[dpdk-dev] [PATCH v2 01/14] bus/dpaa: fix null pointer dereference

2020-06-24 Thread Maxime Coquelin
This patches fixes a null pointer derefencing that happens when the device string passed to the iterator is NULL. This situation can happen when iterating on a class type. For example: RTE_DEV_FOREACH(dev, "class=eth", &dev_iter) { ... } Fixes: e79df833d3f6 ("bus/dpaa: support hotplug ops") C

[dpdk-dev] [PATCH v2 06/14] vhost: replace vDPA device ID in Vhost

2020-06-24 Thread Maxime Coquelin
This removes the notion of device ID in Vhost library as a preliminary step to get rid of the vDPA device ID. Signed-off-by: Maxime Coquelin --- drivers/vdpa/ifc/ifcvf_vdpa.c | 12 drivers/vdpa/mlx5/mlx5_vdpa.c | 18 --- examples/vdpa/main.c |

  1   2   3   >