Re: [dpdk-dev] [PATCH 1/8] ethdev: introduce sample action for rte flow

2020-07-02 Thread Ori Kam
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, July 2, 2020 3:18 AM > To: Jiawei(Jonny) Wang > Cc: Jerin Jacob ; Thomas Monjalon > ; Ori Kam ; Slava Ovsiienko > ; Matan Azrad ; dpdk- > dev ; Raslan Darawsheh ; > ian.sto...@intel.com; f...@redhat.com; Ferruh

Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-07-02 Thread Ori Kam
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Thursday, July 2, 2020 3:24 AM > To: Andrey Vesnovaty > Cc: Thomas Monjalon ; Ferruh Yigit > ; Andrew Rybchenko ; > Ori Kam ; dev@dpdk.org; Andrey Vesnovaty > > Subject: Re: [dpdk-dev] [RFC v2 1/1] add flow shared action

[dpdk-dev] [PATCH v3 0/2] net/virtio: add vhost-user protocol features support

2020-07-02 Thread Adrian Moreno
This series adds Vhost-user protocol features support to Virtio-user PMD's Vhost-user backend. The first patch introduces protocol features negotiation, and the second one reply-ack feature. --- Changes since v2: - Added the new vhost-user messages to vhost_msg_strings[] Changes since v1: - Reba

[dpdk-dev] [PATCH v3 1/2] net/virtio: add vhost-user protocol features support

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support for Vhost-user protocol features. It is required to support protocol features that were not in initial Vhost-user specification, such as reply-ack, MTU... Also, this patch prevents Virtio multiqueue feature negotiation if the slave does not support M

[dpdk-dev] [PATCH v3 2/2] net/virtio: add reply-ack support to Virtio-user

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support reply-ack vhost-user protocol feature, which is for now only used to ensure VHOST_USER_SET_MEM_TABLE requests are handled by the slave, but later will be used for VHOST_USER_SET_STATUS. Signed-off-by: Maxime Coquelin --- drivers/net/virtio/virtio_u

[dpdk-dev] [PATCH v4 0/4] add RegEx class

2020-07-02 Thread Ori Kam
This patch set adds the RegEx class, which enables RegEx pattern matching, both on HW/SW PMDs. Example for applications that will benefit from this class: * Next Generation Firewalls (NGFW) * Deep Packet and Flow Inspection (DPI) * Intrusion Prevention Systems (IPS) * DDoS Mitigation * Network Mon

[dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem

2020-07-02 Thread Ori Kam
From: Jerin Jacob As RegEx usage become more used by DPDK applications, for example: * Next Generation Firewalls (NGFW) * Deep Packet and Flow Inspection (DPI) * Intrusion Prevention Systems (IPS) * DDoS Mitigation * Network Monitoring * Data Loss Prevention (DLP) * Smart NICs * Grammar based con

[dpdk-dev] [PATCH v4 2/4] regexdev: add regex core h file

2020-07-02 Thread Ori Kam
This commit introduce the rte_regexdev_core.h file. This file holds internal structures and API that are used by the regexdev. Signed-off-by: Ori Kam Acked-by: Guy Kaneti --- v4: * No changes. v3: * Align internal function pointers API to the RTE level API. v2: * Move private data to rte_rege

[dpdk-dev] [PATCH v4 4/4] regexdev: implement regex rte level functions

2020-07-02 Thread Ori Kam
This commit implements all the RegEx public API. Signed-off-by: Ori Kam Acked-by: Guy Kaneti --- v4: * Fix error check. v3: * Fix validation conditions. v2: * Changes based on changes in previous patch. * Add check to configuration function. * Replace checks with macros. * Move enqueue and deq

[dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions

2020-07-02 Thread Ori Kam
This commit introduce the API that is needed by the RegEx devices in order to work with the RegEX lib. During the probe of a RegEx device, the device should configure itself, and allocate the resources it requires. On completion of the device init, it should call the rte_regex_dev_register in orde

Re: [dpdk-dev] [PATCH 2/2] doc: add aarch32 build guidance

2020-07-02 Thread Jerin Jacob
On Thu, Jul 2, 2020 at 11:07 AM Phil Yang wrote: > > Hi Jerin, > > Your insight would be much appreciated. > > Thanks, > Phil > > > -Original Message- > > From: Ruifeng Wang > > Sent: Wednesday, May 27, 2020 4:29 PM > > To: Phil Yang ; dev@dpdk.org > > Cc: tho...@monjalon.net; david.march

Re: [dpdk-dev] [PATCH v2] rte_flow: add eCPRI key fields to flow API

2020-07-02 Thread Ori Kam
Hi Bing, Can you add also testpmd patch? Thanks, Ori > -Original Message- > From: Bing Zhao > Sent: Thursday, July 2, 2020 9:46 AM > To: Ori Kam ; john.mcnam...@intel.com; > marko.kovace...@intel.com; Thomas Monjalon ; > ferruh.yi...@intel.com; arybche...@solarflare.com; olivier.m...@6w

Re: [dpdk-dev] [RFC v2 1/1] add flow shared action API

2020-07-02 Thread Andrey Vesnovaty
On Thu, Jul 2, 2020 at 10:20 AM Ori Kam wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, July 2, 2020 3:24 AM > > To: Andrey Vesnovaty > > Cc: Thomas Monjalon ; Ferruh Yigit > > ; Andrew Rybchenko ; > > Ori Kam ; dev@dpdk.org; Andrey Vesnovat

Re: [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue

2020-07-02 Thread Zhou, JunX W
Tested-by: junx.w.z...@intel.com -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ting Xu Sent: Wednesday, June 17, 2020 1:44 PM To: dev@dpdk.org Cc: Dumitrescu, Cristian ; sta...@dpdk.org Subject: [dpdk-dev] [PATCH v2] lib/table: fix cache alignment issue When crea

Re: [dpdk-dev] [PATCH v2] app/testpmd: fix missing set for current forward engine

2020-07-02 Thread Wisam Monther
Hi, >-Original Message- >From: dev On Behalf Of Lijun Ou >Sent: Wednesday, July 1, 2020 10:43 AM >To: wenzhuo...@intel.com; beilei.x...@intel.com; >bernard.iremon...@intel.com; ferruh.yi...@intel.com >Cc: dev@dpdk.org; linux...@huawei.com >Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix

[dpdk-dev] [PATCH v3 03/51] net/bnxt: get IDs for VF-Rep endpoint

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Use 'first_vf_id' and the 'vf_id' that is input as part of adding a representor to obtain the PCI function ID(FID) of the VF(VFR endpoint). Use the FID as an input to FUNC_QCFG HWRM cmd to obtain the default vnic ID of the VF. Along with getting the default vNIC ID by supplyin

[dpdk-dev] [PATCH v3 02/51] net/bnxt: add support for VF-reps data path

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Added code to support Tx/Rx from a VF representor port. The VF-reps use the RX/TX rings of the Trusted VF/PF. For each VF-rep, the Trusted VF/PF driver issues a VFR_ALLOC FW cmd that returns "cfa_code" and "cfa_action" values. The FW sets up the filter tables in such a way tha

[dpdk-dev] [PATCH v3 00/51] add features for host-based flow management

2020-07-02 Thread Ajit Khaparde
v1->v2: - update commit message - rebase patches against latest changes in the tree - fix signed-off-by tags - update release notes v2->v3: - fix compilation issues Ajit Khaparde (1): doc: update release notes Jay Ding (5): net/bnxt: implement support for TCAM access net/bnxt: support

[dpdk-dev] [PATCH v3 01/51] net/bnxt: add basic infrastructure for VF reps

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Defines data structures and code to init/uninit VF representors during pci_probe and pci_remove respectively. Most of the dev_ops for the VF representor are just stubs for now and will be will be filled out in next patch. To create a representor using testpmd: testpmd -c 0xff

[dpdk-dev] [PATCH v3 05/51] net/bnxt: modify port db dev interface

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Modify ulp_port_db_dev_port_intf_update prototype to take "struct rte_eth_dev *" as the second parameter. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 4

[dpdk-dev] [PATCH v3 06/51] net/bnxt: get port and function info

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru add helper functions to get port & function related information like parif, physical port id & vport id. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v3 04/51] net/bnxt: initialize parent PF information

2020-07-02 Thread Ajit Khaparde
From: Lance Richardson Add support to query parent PF information (MAC address, function ID, port ID and default VNIC) from firmware. Current firmware returns zero for parent default vnic, a temporary Wh+-specific workaround is included until that can be fixed. Signed-off-by: Lance Richardson

[dpdk-dev] [PATCH v3 10/51] net/bnxt: modify EM insert and delete to use HWRM direct

2020-07-02 Thread Ajit Khaparde
From: Peter Spreadborough Modify Exact Match insert and delete to use the HWRM messages directly. Remove tunneled EM insert and delete message types. Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v3 07/51] net/bnxt: add support for hwrm port phy qcaps

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_PHY_QCAPS to the firmware to get the physical port count of the device. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 +

[dpdk-dev] [PATCH v3 11/51] net/bnxt: add multi device support

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt Introduce new modules for Device, Resource Manager, Identifier, Table Types, and TCAM for multi device support. Signed-off-by: Michael Wildt Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/meson.build

[dpdk-dev] [PATCH v3 08/51] net/bnxt: modify port db to handle more info

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Apart from func_svif, func_id & vnic, port_db now stores and retrieves func_spif, func_parif, phy_port_id, port_svif, port_spif, port_parif, port_vport. New helper functions have been added to support the same. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Revie

[dpdk-dev] [PATCH v3 12/51] net/bnxt: support bulk table get and mirror

2020-07-02 Thread Ajit Khaparde
From: Shahaji Bhosle - Add new bulk table type get using FW to DMA the data back to host. - Add flag to allow records to be cleared if possible - Set mirror using tf_alloc_tbl_entry Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/

[dpdk-dev] [PATCH v3 15/51] net/bnxt: add HCAPI interface support

2020-07-02 Thread Ajit Khaparde
From: Peter Spreadborough Add new hardware shim APIs to support multiple device generations Signed-off-by: Peter Spreadborough Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/Makefile | 10 + drivers/net/bnxt/hcapi/h

[dpdk-dev] [PATCH v3 14/51] net/bnxt: support two-level priority for TCAMs

2020-07-02 Thread Ajit Khaparde
From: Shahaji Bhosle Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Shahaji Bhosle Signed-off-by: Venkat Duvvuru

[dpdk-dev] [PATCH v3 13/51] net/bnxt: update multi device design support

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt - Implement the modules RM, Device (WH+), Identifier. - Update Session module. - Implement new HWRMs for RM direct messaging. - Add new parameter check macro's and clean up the header includes for i.e. tfp such that bnxt.h is not directly included in the new modules. - Add c

[dpdk-dev] [PATCH v3 17/51] net/bnxt: implement support for TCAM access

2020-07-02 Thread Ajit Khaparde
From: Jay Ding Implement TCAM alloc, free, bind, and unbind functions Update tf_core, tf_msg, etc. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_core.c | 258 ++--- drivers/ne

[dpdk-dev] [PATCH v3 16/51] net/bnxt: add core changes for EM and EEM lookups

2020-07-02 Thread Ajit Khaparde
From: Randy Schacher - Move External Exact and Exact Match to device module using HCAPI to add and delete entries - Make EM active through the device interface. Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Shahaji Bhosle Reviewed-by: Ajit Khaparde --- drivers/n

[dpdk-dev] [PATCH v3 20/51] net/bnxt: update RM with residual checker

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt - Add residual checker to the TF Host RM as well as new RM APIs. On close it will scan the DB and check of any remaining elements. If found they will be logged and FW msg sent for FW to scrub that specific type of resources. - Update the module bind to be aware of the mo

[dpdk-dev] [PATCH v3 19/51] net/bnxt: update identifier with remap support

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt - Add Identifier L2 CTXT Remap to the P4 device and updated the cfa_resource_types.h to get the type support. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_typ

[dpdk-dev] [PATCH v3 18/51] net/bnxt: multiple device implementation

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt Implement the Identifier, Table Type and the Resource Manager modules. Integrate Resource Manager with HCAPI. Update open/close session. Move to direct msgs for qcaps and resv messages. Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher

[dpdk-dev] [PATCH v3 21/51] net/bnxt: support two level priority for TCAMs

2020-07-02 Thread Ajit Khaparde
From: Jay Ding Allow TCAM indexes to be allocated from top or bottom. If the priority is set to 0, allocate from the lowest tcam indexes i.e. from top. Any other value, allocate it from the highest tcam indexes i.e. from bottom. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by

[dpdk-dev] [PATCH v3 24/51] net/bnxt: update RM to support HCAPI only

2020-07-02 Thread Ajit Khaparde
From: Peter Spreadborough - For the EM Module there is a need to only allocate the EM Records in HCAPI RM but the storage control is requested to be outside of the RM DB. - Add TF_RM_ELEM_CFG_HCAPI_BA. - Return error when the number of reserved entries for wc tcam is odd number in tf_tcam_bin

[dpdk-dev] [PATCH v3 25/51] net/bnxt: remove table scope from session

2020-07-02 Thread Ajit Khaparde
From: Peter Spreadborough - Remove table scope data from session. Added to EEM. - Complete move to RM of table scope base and range. - Fix some err messaging strings. - Fix the tcam logging message. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru R

[dpdk-dev] [PATCH v3 26/51] net/bnxt: add external action alloc and free

2020-07-02 Thread Ajit Khaparde
From: Jay Ding - Link external action alloc and free to new hcapi interface - Add parameter range checking - Fix issues with index allocation check Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/tf_co

[dpdk-dev] [PATCH v3 32/51] net/bnxt: integrate with the latest tf core changes

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha ULP changes to integrate with the latest session open interface in tf_core Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 46 +++

[dpdk-dev] [PATCH v3 28/51] net/bnxt: implement IF tables set and get

2020-07-02 Thread Ajit Khaparde
From: Jay Ding - Implement set/get for PROF_SPIF_CTXT, LKUP_PF_DFLT_ARP, PROF_PF_ERR_ARP with tunneled HWRM messages - Add IF table for PROF_PARIF_DFLT_ARP - Fix page size offset in the HCAPI code - Fix Entry offset calculation Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvuru Reviewed-b

[dpdk-dev] [PATCH v3 29/51] net/bnxt: add TF register and unregister

2020-07-02 Thread Ajit Khaparde
From: Michael Wildt - Add TF register/unregister support. Session got session clients to keep track of the ctrl-channels/function. - Add support code to tfp layer Signed-off-by: Michael Wildt Signed-off-by: Venkat Duvvuru Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/

[dpdk-dev] [PATCH v3 27/51] net/bnxt: align CFA resources with RM

2020-07-02 Thread Ajit Khaparde
From: Randy Schacher - HCAPI resources need to align for Resource Manager - Clean up unnecessary debug messages Signed-off-by: Randy Schacher Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/cfa_resource_types.h | 250 +- drivers/net/bnxt/

[dpdk-dev] [PATCH v3 35/51] net/bnxt: disable Tx vector mode if truflow is enabled

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha The vector mode in the tx handler is disabled when truflow is enabled since truflow now requires bd action record support. Signed-off-by: Kishore Padmanabha Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bn

[dpdk-dev] [PATCH v3 30/51] net/bnxt: add global config set and get APIs

2020-07-02 Thread Ajit Khaparde
From: Jay Ding - Add support to update global configuration for ACT_TECT and ACT_ABCR. - Add support to allow Tunnel and Action global configuration. - Remove register read and write operations. - Remove the register read and write support. Signed-off-by: Jay Ding Signed-off-by: Venkat Duvvur

[dpdk-dev] [PATCH v3 33/51] net/bnxt: add support for internal encap records

2020-07-02 Thread Ajit Khaparde
From: Mike Baucom Modifications to allow internal encap records to be supported: - Modified the mapper index table processing to handle encap without an action record - Modified the session open code to reserve some 64 Byte internal encap records on tx - Modified the blob encap swap to suppor

[dpdk-dev] [PATCH v3 39/51] net/bnxt: add conditional execution of mapper tables

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for conditional execution of the mapper tables so that actions like count will have table processed only if action count is configured. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v3 37/51] net/bnxt: add support for global resource templates

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the global resource templates, so that they can be reused by the other regular templates. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c

[dpdk-dev] [PATCH v3 31/51] net/bnxt: add support for EEM System memory

2020-07-02 Thread Ajit Khaparde
From: Peter Spreadborough - Select EEM Host or System memory via config parameter - Add EEM system memory support for kernel memory - Dependent on DPDK changes that add support for the HWRM_OEM_CMD. Signed-off-by: Peter Spreadborough Reviewed-by: Randy Schacher Signed-off-by: Venkat Duvvuru -

[dpdk-dev] [PATCH v3 36/51] net/bnxt: add index opcode and operand to mapper table

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha Extended the regfile and computed field operations to a common index opcode operation and added globlal resource operations are also part of the index opcode operation. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed

[dpdk-dev] [PATCH v3 40/51] net/bnxt: enable port MAC qcfg for trusted VF

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Issue HWRM_PORT_MAC_QCFG command on trusted vf to fetch the port count. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/ne

[dpdk-dev] [PATCH v3 42/51] net/bnxt: manage VF to VFR conduit

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru When VF-VFR conduits are created, a mark is added to the mark database. mark_flag indicates whether the mark is valid and has VFR information (VFR_ID bit in mark_flag). Rx path was checking for this VFR_ID bit. However, while adding the mark to the mark database, VFR_ID bit i

[dpdk-dev] [PATCH v3 38/51] net/bnxt: add support for internal exact match entries

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for the internal exact match entries. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp.c| 38 +++ drivers/net/bnxt/tf_

[dpdk-dev] [PATCH v3 47/51] net/bnxt: add port default rules for ingress and egress

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru ingress & egress port default rules are needed to send the packet from port_to_dpdk & dpdk_to_port respectively. Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 76 +-

[dpdk-dev] [PATCH v3 43/51] net/bnxt: parse reps along with other dev-args

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Representor dev-args need to be parsed during pci probe as they determine subsequent probe of VF representor ports as well. Signed-off-by: Venkat Duvvuru Signed-off-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 2 ++ 1 file changed, 2 i

[dpdk-dev] [PATCH v3 44/51] net/bnxt: fill mapper parameters with default rules

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Default rules are needed for the packets to be punted between the following entities in the non-offloaded path 1. Device PORT to DPDK App 2. DPDK App to Device PORT 3. VF Representor to VF 4. VF to VF Representor This patch fills all the relevant information in the computed

[dpdk-dev] [PATCH v3 41/51] net/bnxt: enhancements for port db

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru 1. Add "enum bnxt_ulp_intf_type” as the second parameter for the port & func helper functions 2. Return vfrep related port & func information in the helper functions 3. Allocate phy_port_list dynamically based on port count 4. Introduce ulp_func_id_tbl array for book keepi

[dpdk-dev] [PATCH v3 46/51] net/bnxt: create default flow rules for the VF-rep

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Invoked 3 new APIs for the default flow create/destroy and to get the action ptr for a default flow. Changed ulp_intf_update() to accept rte_eth_dev as input and invoke the same from the VF rep start function. ULP Mark Manager will indicate if the cfa_code returned in the Rx c

[dpdk-dev] [PATCH v3 51/51] doc: update release notes

2020-07-02 Thread Ajit Khaparde
Update release notes with enhancements in Broadcom PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_20_08.rst | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst index 5

[dpdk-dev] [PATCH v3 48/51] net/bnxt: fill cfa action in the Tx descriptor

2020-07-02 Thread Ajit Khaparde
From: Venkat Duvvuru Currently, only vfrep transmit requires cfa_action to be filled in the tx buffer descriptor. However with truflow, dpdk(non vfrep) to port also requires cfa_action to be filled in the tx buffer descriptor. This patch uses the correct cfa_action pointer while transmitting the

[dpdk-dev] [PATCH v3 49/51] net/bnxt: add ULP Flow counter Manager

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur The Flow counter manager allocates memory to hold the software view of the counters where the on-chip counter data will be accumulated along with another memory block that will be shadowing the on-chip counter data i.e where the raw counter data will be DMAed into from the chi

[dpdk-dev] [PATCH v3 34/51] net/bnxt: add support for if table processing

2020-07-02 Thread Ajit Khaparde
From: Kishore Padmanabha Added support for if table processing in the ulp mapper layer. This enables support for the default partition action record pointer interface table. Signed-off-by: Kishore Padmanabha Signed-off-by: Venkat Duvvuru Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde

[dpdk-dev] [PATCH v3 50/51] net/bnxt: add support for count action in flow query

2020-07-02 Thread Ajit Khaparde
From: Somnath Kotur Use the flow counter manager to fetch the accumulated stats for a flow. Signed-off-by: Somnath Kotur Signed-off-by: Venkat Duvvuru Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_flow.c | 45 +++- drivers/net/bnxt/tf_ulp/ulp_fc_mgr.c| 141

[dpdk-dev] [PATCH v2 1/8] vhost: fix virtio ready flag check

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin Before checking whether the device is ready is done a check on whether the RUNNING flag is set. Then the READY flag is set if virtio_is_ready() returns true. While it seems to not cause any issue, it makes more sense to check whether the READY flag is set and not the RUNNIN

[dpdk-dev] [PATCH v2 5/8] vhost: add support for virtio status

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch adds support to the new Virtio device status Vhost-user protocol feature. Getting such information in the backend helps to know when the driver is done with the device configuration and so makes the initialization phase more robust. Signed-off-by: Maxime Coqueli

[dpdk-dev] [PATCH v2 2/8] vhost: refactor Virtio ready check

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch is a small refactoring, as preliminary work for adding support to Virtio status support. No functionnal change here. Signed-off-by: Maxime Coquelin Signed-off-by: Adrian Moreno --- lib/librte_vhost/vhost.c | 1 + lib/librte_vhost/vhost_user.c | 33 +

[dpdk-dev] [PATCH v2 4/8] vhost: check vDPA configuration succeed

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch checks whether vDPA device configuration succeed and does not set the CONFIGURED flag if it didn't. Signed-off-by: Maxime Coquelin Signed-off-by: Adrian Moreno --- lib/librte_vhost/vhost_user.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff

[dpdk-dev] [PATCH v2 3/8] vhost: make some vDPA callbacks mandatory

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin Some of the vDPA callbacks have to be implemented for vDPA to work properly. This patch marks them as mandatory in the API doc and simplify code calling these ops with removing unnecessary checks that are now done at registration time. Signed-off-by: Maxime Coquelin Signe

[dpdk-dev] [PATCH (v20.08) v2 0/8] vhost: improve Vhost/vDPA device init

2020-07-02 Thread Adrian Moreno
The goal of this series is to make the Vhost/vDPA device init more robust by adding support to a new protocol feature and two new messages. VHOST_USER_SET_STATUS is received by the backend when the driver updates the virtio device status register. For now this series only deals with the DRIVER_OK

[dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-02 Thread Adrian Moreno
This patch adds support to the new Virtio device get status Vhost-user message. The driver can send this new message to read the device status. One of the uses of this message is to ensure the feature negotiation has succeded. According to the virtio spec, after completing the feature negotiatio

[dpdk-dev] [PATCH v2 8/8] vdpa/mlx5: enable status protocol feature

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch advertises VHOST_USER_PROTOCOL_F_STATUS support in the MLX5 driver so that that the protocol feature is negotiated. Signed-off-by: Maxime Coquelin Signed-off-by: Adrian Moreno --- drivers/vdpa/mlx5/mlx5_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deleti

[dpdk-dev] [PATCH v2 7/8] vdpa/ifc: enable status protocol feature

2020-07-02 Thread Adrian Moreno
From: Maxime Coquelin This patch advertises VHOST_USER_PROTOCOL_F_STATUS support in the IFC driver so that that the protocol feature is negotiated. Signed-off-by: Maxime Coquelin Signed-off-by: Adrian Moreno --- drivers/vdpa/ifc/ifcvf_vdpa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [dpdk-dev] [PATCH] app/test: fix rpath for drivers in meson build

2020-07-02 Thread Bruce Richardson
On Wed, Jul 01, 2020 at 07:16:38PM +0200, Timothy Redaelli wrote: > This commit fixes the setting of relative rpath on dpdk-test for > drivers ($libdir/dpdk/pmd-$abiver) to the correct absolute rpath > ($prefix$libdir/dpdk/pmd-$abiver) > > Fixes: b5dc795a8a55 ("test: build app with meson as dpdk-t

Re: [dpdk-dev] [PATCH] build: remove special handling for node library

2020-07-02 Thread Bruce Richardson
On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote: > What is the point of adding librte_node a second time separately? > > Signed-off-by: Thomas Monjalon > --- I suspect that this is a hangover from when we did not explicitly link_whole all DPDK libs.

Re: [dpdk-dev] [PATCH 3/3] eal: return error code when failure

2020-07-02 Thread Jeff Guo
hi, yunjian On 6/3/2020 8:55 PM, wangyunjian wrote: From: Yunjian Wang Fix return value, using -EAGAIN instead of 0 when the callback is busy and using -ENOENT instead of 0 when the callback is not found. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Sig

Re: [dpdk-dev] [PATCH] cfgfile: avoid stack buffer underflow

2020-07-02 Thread Bruce Richardson
On Wed, Jul 01, 2020 at 08:05:58PM -0700, Stephen Hemminger wrote: > If cfgfile is give a line with comment character at the start > of the line, it will dereference outside of the buffer. > > Detected with address sanitizer: > > SUMMARY: AddressSanitizer: stack-buffer-underflow > lib/librte_cfg

[dpdk-dev] [PATCH v4 1/2] eal: add WC store functions

2020-07-02 Thread Radu Nicolau
Add rte_write32_wc and rte_write32_wc_relaxed functions that implement 32bit stores using write combining memory protocol. Provided generic stubs and x86 implementation. Signed-off-by: Radu Nicolau Acked-by: Bruce Richardson --- v4: address feedback and include ack lib/librte_eal/include/gener

[dpdk-dev] [PATCH v4 0/2] eal: add WC store functions

2020-07-02 Thread Radu Nicolau
Implement 2 new functions that will enable write combining stores depending on architecture. The functions are provided as a generic stub and a x86 specific implementation. The reason to implement these functions is to improve performance by reducing the overhead associated with regular mmio write

[dpdk-dev] [PATCH v4 2/2] net/i40e: use WC store to update queue tail registers

2020-07-02 Thread Radu Nicolau
Performance improvement: use a write combining store instead of a regular mmio write to update queue tail registers. Signed-off-by: Radu Nicolau Acked-by: Bruce Richardson --- v4: include ack drivers/net/i40e/base/i40e_osdep.h| 6 ++ drivers/net/i40e/i40e_rxtx.c | 8

Re: [dpdk-dev] [PATCH v2] eal: fix memory leak when removing event_cb

2020-07-02 Thread Jeff Guo
hi, yunjian On 6/30/2020 7:56 PM, wangyunjian wrote: From: Yunjian Wang The event_cb->dev_name is not freed when freeing event_cb, and this causes a memory leak. Fixes: a753e53d517b ("eal: add device event monitor framework") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- lib/librte

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > -Original Message- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:17 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 2/

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Akhil Goyal
> > > +#include "otx2_ipsec_po.h" > > Why is it named like this? What is 'po' ? > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for inline > and one for lookaside. The one for inline is FP and the one for lookaside is > PO > (Protocol Offload). > Isn't it better to write "inli

Re: [dpdk-dev] [PATCH v6] net/octeontx2: add devargs to lock Rx/Tx ctx

2020-07-02 Thread Jerin Jacob
On Mon, Jun 29, 2020 at 3:48 AM wrote: > > From: Pavan Nikhilesh > > Add device arguments to lock Rx/Tx contexts. > Application can either choose to lock Rx or Tx contexts by using > 'lock_rx_ctx' or 'lock_tx_ctx' respectively per each port. > > Example: > -w 0002:02:00.0,lock_rx_ctx=1 -w

Re: [dpdk-dev] [PATCH] build: remove special handling for node library

2020-07-02 Thread Jerin Jacob
On Thu, Jul 2, 2020 at 2:48 PM Bruce Richardson wrote: > > On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote: > > What is the point of adding librte_node a second time separately? > > > > Signed-off-by: Thomas Monjalon > > --- > > I suspect that this is a hangover from when we did n

Re: [dpdk-dev] [PATCH 2/8] crypto/octeontx2: add lookaside SA context definitions

2020-07-02 Thread Anoob Joseph
Hi Akhil, > > -- > > > > +#include "otx2_ipsec_po.h" > > > Why is it named like this? What is 'po' ? > > > > [Anoob] OCTEON TX2 firmware supports two opcodes. One specific for > > inline and one for lookaside. The one for inline

Re: [dpdk-dev] [PATCH] build: remove special handling for node library

2020-07-02 Thread Thomas Monjalon
02/07/2020 11:53, Jerin Jacob: > On Thu, Jul 2, 2020 at 2:48 PM Bruce Richardson > wrote: > > > > On Wed, Jul 01, 2020 at 08:05:06PM +0200, Thomas Monjalon wrote: > > > What is the point of adding librte_node a second time separately? > > > > > > Signed-off-by: Thomas Monjalon > > > --- > > > > I

[dpdk-dev] [PATCH v3 0/4] net/bnxt: vector mode enhancements

2020-07-02 Thread Ajit Khaparde
- Switch to non-vector receive function when "mark" action is requested. - Add support for rx_burst_mode_get()/tx_burst_mode_get() to return currently active receive/transmit mode. - Add vector mode support for ARM64. v2->v3: - update bnxt doc - update 20.08 release notes Ajit Khaparde (1):

[dpdk-dev] [PATCH v3 1/2] telemetry: support array values in data objects

2020-07-02 Thread Ciara Power
Arrays of type uint64_t/int/string can now be included within an array or dict. One level of embedded containers is supported. This is necessary to allow for instances such as the ethdev queue stats to be reported as a list of uint64_t values, rather than having multiple dict entries with one uint6

[dpdk-dev] [PATCH v3 0/2] add basic ethdev stats with data object recursion

2020-07-02 Thread Ciara Power
This patchset adds support for basic ethdev statistics in Telemetry. To do this, recursive data object support is needed to report the queue statistics in a list. With this patch, an array or dictionary supports uint64_t, int or string array type values, which is used for the ethdev queue stats. C

[dpdk-dev] [PATCH v3 1/4] net/bnxt: disable vector receive for mark action

2020-07-02 Thread Ajit Khaparde
From: Lance Richardson The bnxt vector mode receive handler does not support the rte_flow 'mark' action. Since we cannot know in advance whether this action will be required, add support for dynamically switching from vector to non-vector receive when the first flow create request with a mark act

[dpdk-dev] [PATCH v3 2/2] ethdev: add common stats for telemetry

2020-07-02 Thread Ciara Power
The ethdev library now registers a telemetry command for common ethdev statistics. An example usage is shown below: Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2 {"version": "DPDK 20.08.0-rc0", "pid": 14119, "max_output_len": 16384} --> /ethdev/stats,0 {"/ethdev/stats": {"ipackets": 0, "opack

[dpdk-dev] [PATCH v3 4/4] doc: update release notes

2020-07-02 Thread Ajit Khaparde
Update release notes indicating vector mode support for ARM CPUs in Broadcom bnxt PMD. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_20_08.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/guides/rel_notes/release_20_08.rst b/doc/guides/rel_notes/release_20_08.rst in

[dpdk-dev] [PATCH v3 2/4] net/bnxt: support Rx/Tx burst mode info

2020-07-02 Thread Ajit Khaparde
From: Lance Richardson Retrieve burst mode options according to the selected Rx/Tx burst function name. Signed-off-by: Lance Richardson Reviewed-by: Somnath Kotur Reviewed-by: Ajit Khaparde --- doc/guides/nics/features/bnxt.ini | 1 + drivers/net/bnxt/bnxt_ethdev.c| 46 +

[dpdk-dev] [PATCH v3 3/4] net/bnxt: add ARM64 vector support

2020-07-02 Thread Ajit Khaparde
From: Lance Richardson Add bnxt vector PMD support using NEON SIMD instructions. Signed-off-by: Lance Richardson Reviewed-by: Ajit Khaparde Reviewed-by: Ruifeng Wang --- doc/guides/nics/bnxt.rst| 6 +- drivers/net/bnxt/Makefile | 3 + drivers/net/bnxt/bnxt_e

Re: [dpdk-dev] [PATCH 0/8] add OCTEON TX2 lookaside IPsec support

2020-07-02 Thread Tejasree Kondoj
Hi Akhil, Please see inline Thanks, Tejasree > -Original Message- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:24 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH

Re: [dpdk-dev] [PATCH v3 3/4] eal: export needed functions for mempool

2020-07-02 Thread Fady Bader
Ok, I'll send a new version today. > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 30, 2020 2:29 AM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.

Re: [dpdk-dev] [PATCH v3 1/4] eal: disable function versioning on Windows

2020-07-02 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, June 30, 2020 2:26 AM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka...@intel.com; ran

Re: [dpdk-dev] [PATCH 3/8] crypto/octeontx2: add cryptodev sec registration

2020-07-02 Thread Tejasree Kondoj
> -Original Message- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:29 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH 3/8] crypto/octeontx2: add cryptodev sec > re

Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

2020-07-02 Thread Tejasree Kondoj
Hi Akhil, Please see inline. Thanks Tejasree > -Original Message- > From: Akhil Goyal > Sent: Thursday, July 2, 2020 2:37 AM > To: Tejasree Kondoj ; Radu Nicolau > > Cc: Narayana Prasad Raju Athreya ; Anoob Joseph > ; Vamsi Krishna Attunuru ; > dev@dpdk.org > Subject: [EXT] RE: [PATCH

Re: [dpdk-dev] [PATCH 4/8] crypto/octeontx2: add cryptodev sec capabilities

2020-07-02 Thread Akhil Goyal
> > > +static const struct rte_cryptodev_capabilities * > > > +otx2_cpt_sec_caps_get(union cpt_eng_caps *hw_caps) { > > > + SEC_CAPS_ADD(hw_caps, aes); > > > + > > > + sec_caps_add(caps_end, RTE_DIM(caps_end)); > > > + > > > + return otx2_cpt_sec_caps; > > > +} > > SEC_CAPS_ADD should be called ear

  1   2   3   >