Re: [dpdk-dev] [PATCH v4 1/4] regexdev: introduce regexdev subsystem

2020-07-06 Thread Ori Kam
Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Monday, July 6, 2020 12:19 AM > To: jer...@marvell.com; Ori Kam > Cc: xiang.w.w...@intel.com; dev@dpdk.org; g...@marvell.com; > pbhagavat...@marvell.com; Shahaf Shuler ; > hemant.agra...@nxp.com; Opher Reviv ; Alex > Rosenba

Re: [dpdk-dev] [PATCH v6 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Fady Bader
> -Original Message- > From: Thomas Monjalon > Sent: Sunday, July 5, 2020 11:24 PM > To: Fady Bader > Cc: dev@dpdk.org; Tasnim Bashar ; Tal Shnaiderman > ; Yohad Tor ; > dmitry.kozl...@gmail.com; harini.ramakrish...@microsoft.com; > ocard...@microsoft.com; pallavi.ka...@intel.com; ranj

Re: [dpdk-dev] [PATCH v4 0/4] add RegEx class

2020-07-06 Thread Ori Kam
Hi Thomas > -Original Message- > From: Thomas Monjalon > Subject: Re: [dpdk-dev] [PATCH v4 0/4] add RegEx class > > 02/07/2020 09:45, Ori Kam: > > config/common_base |8 + > > config/meson.build |1 + > > doc/api/doxy-api-index

Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions

2020-07-06 Thread Thomas Monjalon
06/07/2020 08:07, Ori Kam: > From: Thomas Monjalon > > 02/07/2020 09:46, Ori Kam: > > > --- a/meson_options.txt > > > +++ b/meson_options.txt > > > @@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128, > > > description: 'maximum number of cores/threads supported by EAL') > > > op

[dpdk-dev] [PATCH v6 2/2] ethdev: fix VLAN offloads set if no relative capabilities

2020-07-06 Thread Wei Hu (Xavier)
Currently, there is a potential problem that calling the API function rte_eth_dev_set_vlan_offload to start VLAN hardware offloads which the driver does not support. If the PMD driver does not support certain VLAN hardware offloads and does not check for it, the hardware setting will not change, bu

[dpdk-dev] [PATCH v6 1/2] ethdev: fix data room size verification in Rx queue setup

2020-07-06 Thread Wei Hu (Xavier)
In the rte_eth_rx_queue_setup API function, the local variable named mbp_buf_size, which is the data room size of the input parameter mp, is checked to guarantee that each memory chunck used for net device in the mbuf is bigger than the min_rx_bufsize. But if mbp_buf_size is less than RTE_PKTMBUF_H

[dpdk-dev] [PATCH v6 0/2] ethdev: minor bugfixes

2020-07-06 Thread Wei Hu (Xavier)
This series are minor bugfixes for rte_ethdev.c. Wei Hu (Xavier) (2): ethdev: fix data room size verification in Rx queue setup ethdev: fix VLAN offloads set if no relative capabilities drivers/net/dpaa2/dpaa2_ethdev.c | 12 +++- drivers/net/enic/enic_ethdev.c |

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-07-06 Thread Olivier Matz
Hi Hongzhi, I suggest the following title instead: net: fix checksum on big endian CPUs On Wed, Jun 24, 2020 at 05:11:19PM +0200, Morten Brørup wrote: > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > Sent: Wednesday, June 24, 2020 5:04 PM > > > > 24/06/2020 15:00,

Re: [dpdk-dev] [dpdk-stable] [PATCH] bugfix: rte_raw_checksum

2020-07-06 Thread Olivier Matz
On Mon, Jul 06, 2020 at 09:36:25AM +0200, Olivier Matz wrote: > Hi Hongzhi, > > I suggest the following title instead: > > net: fix checksum on big endian CPUs > > On Wed, Jun 24, 2020 at 05:11:19PM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas M

[dpdk-dev] [PATCH v2 1/6] lib/eal: add a common wrapper for restricted pointers

2020-07-06 Thread Joyce Kong
The 'restrict' keyword is recognized in C99, while type qulifier '__restrict' compiles ok in C with all language levels. This patch is to add a wrapper defining '__rte_restrict' with 'restrict' and '__restrict' to be supported by all compilers. Signed-off-by: Joyce Kong --- lib/librte_eal/includ

[dpdk-dev] [PATCH v2 2/6] net/virtio: restrict pointer aliasing for NEON vpmd

2020-07-06 Thread Joyce Kong
Restrict pointer aliasing to allow the compiler to vectorize loops more aggressively. With this patch, a 9.6% improvement is observed in throughput for the virtio-net PVP case, and a 2.4% perf improvement in throughput for the virtio-user PVP case. All performance data are measured under the 0.001

[dpdk-dev] [PATCH v2 3/6] lib/vhost: restrict pointer aliasing for packed vpmd

2020-07-06 Thread Joyce Kong
Restrict pointer aliasing to allow the compiler to vectorize loop more aggressively. With this patch, a 9.6% improvement is observed in throughput for the packed virtio-net PVP case, and a 2.8% improvement in throughput for the packed virtio-user PVP case. All performance data are measured under 0

[dpdk-dev] [PATCH v2 0/6] Restrict pointer aliasing with a common wrapper

2020-07-06 Thread Joyce Kong
As the 'restrict' keyword is recognized in C99, this patchset is to add a wrapper defining '__rte_restrict' which can be supported by all compilers. Then replace the existing 'restrict' and '__restrict' in different vpmds, and optimize vhost/virtio with restricted pointer aliasing for more aggressi

[dpdk-dev] [PATCH v2 5/6] examples/performance-thread: replace restrict with wrapper

2020-07-06 Thread Joyce Kong
'__rte_restrict' is a common wrapper for restricted pointers which can be supported by all compilers. Use '__rte_restrict' instead of '__restrict' for code consistency. Signed-off-by: Joyce Kong --- .../performance-thread/pthread_shim/pthread_shim.c | 12 ++-- 1 file changed, 6 inserti

[dpdk-dev] [PATCH v2 4/6] net/i40e: replace restrict with rte restrict

2020-07-06 Thread Joyce Kong
'__rte_restrict' is a common wrapper for restricted pointers which can be supported by all compilers. Use '__rte_restrict' instead of '__restrict' for code consistency. Signed-off-by: Joyce Kong --- drivers/net/i40e/i40e_rxtx_vec_neon.c | 17 + 1 file changed, 9 insertions(+), 8

[dpdk-dev] [PATCH v2 6/6] net/mlx5: replace restrict keyword with rte restrict

2020-07-06 Thread Joyce Kong
The 'restrict' keyword is recognized in C99, which might have some issues with old compilers. It is better to use the wrapper '__rte_restrict' which can be supported by all compilers for restricted pointers. Signed-off-by: Joyce Kong --- drivers/net/mlx5/mlx5_rxtx.c | 208 +--

[dpdk-dev] [PATCH v2] app/flow-perf: fix condition of hairpin queues setup

2020-07-06 Thread Wisam Jaddo
The hairpin queue is the one that start from normal rxq, and will be less than nr_queues where nr_queues is the sum of normal and hairpin Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo Reviewed-by: Asaf Penso --- v2: * A

Re: [dpdk-dev] [PATCH] bugfix: udptcp_checksum should tread tcp and udp differently

2020-07-06 Thread Olivier Matz
Hi, Here is a suggestion for the title: net: fix uneeded replacement of 0 by for TCP checksum The commit log looks good to me, but you can add: Fixes: 6006818cfb26 ("net: new checksum functions") Cc: sta...@dpdk.org On Wed, May 27, 2020 at 05:36:59PM +0200, Morten Brørup wrote: > >

[dpdk-dev] [PATCH] app/flow-perf: fix typo in usage

2020-07-06 Thread Wisam Jaddo
>From hairping-rss into hairpin-rss Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo --- app/test-flow-perf/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-flow-perf/main.c b/app/test-flo

Re: [dpdk-dev] [PATCH v4 3/4] regexdev: add regexdev core functions

2020-07-06 Thread Bruce Richardson
On Mon, Jul 06, 2020 at 09:03:49AM +0200, Thomas Monjalon wrote: > 06/07/2020 08:07, Ori Kam: > > From: Thomas Monjalon > > > 02/07/2020 09:46, Ori Kam: > > > > --- a/meson_options.txt > > > > +++ b/meson_options.txt > > > > @@ -30,6 +30,8 @@ option('max_lcores', type: 'integer', value: 128, > > >

[dpdk-dev] [PATCH 1/2] devtools: fix filename in forbidden token check

2020-07-06 Thread David Marchand
Fix displayed filename by adjusting the extraction from the patch. Before: Warning in /lib/librte_eal/linux/eal.c: After: Warning in lib/librte_eal/linux/eal.c: Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from libs") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- devtool

[dpdk-dev] [PATCH 2/2] devtools: fix forbidden token

2020-07-06 Thread David Marchand
An expression with a space is split by the awk script resulting in false positive for any patch matching any of the two part of the expression. Fix this by using [[:space:]]. Fixes: 43e73483a4b8 ("devtools: forbid variable declaration inside for") Signed-off-by: David Marchand --- devtools/chec

Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues setup

2020-07-06 Thread Wisam Monther
Hi, >-Original Message- >From: Thomas Monjalon >Sent: Sunday, July 5, 2020 11:40 PM >To: Wisam Monther >Cc: Jack Min ; david.march...@redhat.com; >dev@dpdk.org; Asaf Penso ; >arybche...@solarflare.com >Subject: Re: [dpdk-dev] [PATCH] app/flow-perf: fix condition of hairpin queues >setup

Re: [dpdk-dev] [dpdk-stable] [PATCH] doc: fix references to /dev/huge

2020-07-06 Thread Sarosh Arif
On Mon, Jul 6, 2020 at 1:44 AM Thomas Monjalon wrote: > 23/06/2020 07:55, Sarosh Arif: > > change /dev/huge to /dev/hugepages > > > > Bugzilla ID: 492 > > Signed-off-by: Sarosh Arif > > Please could you explain why /dev/hugepages must be used, > in the commit log for the record? > The path /de

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/3] Experimental/internal libraries cleanup

2020-07-06 Thread Bruce Richardson
On Sun, Jul 05, 2020 at 09:55:41PM +0200, Thomas Monjalon wrote: > +Cc maintainers of the problematic libraries: > - librte_fib > - librte_rib > - librte_gro > - librte_member > - librte_rawdev > > 26/06/2020 10:16, David Marchand: > > Following discussions on the mai

Re: [dpdk-dev] [PATCH] mbuf: use c11 atomics for refcnt operations

2020-07-06 Thread Phil Yang
> -Original Message- > From: David Marchand > Sent: Friday, July 3, 2020 11:39 PM > To: Phil Yang > Cc: dev ; Olivier Matz ; David > Christensen ; Honnappa Nagarahalli > ; Ruifeng Wang > ; nd > Subject: Re: [dpdk-dev] [PATCH] mbuf: use c11 atomics for refcnt operations > > On Thu, Jun 1

Re: [dpdk-dev] [dpdk-techboard] [PATCH v3 0/3] Experimental/internal libraries cleanup

2020-07-06 Thread Thomas Monjalon
06/07/2020 10:02, Bruce Richardson: > On Sun, Jul 05, 2020 at 09:55:41PM +0200, Thomas Monjalon wrote: > > +Cc maintainers of the problematic libraries: > > - librte_fib > > - librte_rib > > - librte_gro > > - librte_member > > - librte_rawdev > > > > 26/06/2020 10:16, David Ma

Re: [dpdk-dev] [PATCH v2] app/flow-perf: fix condition of hairpin queues setup

2020-07-06 Thread Thomas Monjalon
06/07/2020 09:53, Wisam Jaddo: > The hairpin queue is the one that start from normal rxq, > and will be less than nr_queues where nr_queues is the > sum of normal and hairpin > > Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") > Cc: wis...@mellanox.com > > Signed-off-by: Wis

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-06 Thread Adrian Moreno
On 7/5/20 3:15 PM, Xia, Chenbo wrote: > Hi Adrian, > >> -Original Message- >> From: dev On Behalf Of Adrian Moreno >> Sent: Thursday, July 2, 2020 4:33 PM >> To: dev@dpdk.org; Ye, Xiaolong ; >> shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; >> Wang, Xiao W ; viac

Re: [dpdk-dev] [PATCH v5 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Bruce Richardson
On Sun, Jul 05, 2020 at 02:46:27PM +0300, Fady Bader wrote: > Function versioning implementation is not supported by Windows. > Function versioning was disabled on Windows. > > Signed-off-by: Fady Bader > --- > lib/librte_eal/include/rte_function_versioning.h | 2 +- > lib/meson.build

[dpdk-dev] [PATCH v3 00/27] update e1000 base code

2020-07-06 Thread Guinan Sun
update e1000 base code. source code of e1000 driver: cid-gigabit.2020.06.05.tar.gz released by the team which develop basic drivers for any e1000 NIC. changelog in ND share repo: >From 99bddf09773a ("e1000_shared: Remove #ifdef CLARKVILLE_HW") To 64edeeac42a7 ("e1000-shared: Fix LTR algorithm for

[dpdk-dev] [PATCH v3 01/27] net/e1000/base: i210 slow system clock update

2020-07-06 Thread Guinan Sun
This code is required for the update for system clock. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e10

[dpdk-dev] [PATCH v3 03/27] net/e1000/base: introduce flags

2020-07-06 Thread Guinan Sun
Introduce flags to make flexible adjusting number of outstanding requests. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e1000_ich8lan.h b/drivers/n

[dpdk-dev] [PATCH v3 02/27] net/e1000/base: add ICL device ID

2020-07-06 Thread Guinan Sun
This patch contains a preliminary support for new LAN device ID. Signed-off-by: Lotem Leder Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 4 drivers/net/e1000/base/e1000_hw.h | 4 2 files changed, 8 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c

[dpdk-dev] [PATCH v3 04/27] net/e1000/base: add support for i211

2020-07-06 Thread Guinan Sun
Add support SF/FW syncronization. Add support to print PBA when using flashless. Signed-off-by: Todd Fujinaka Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 4 ++-- drivers/net/e1000/base/e1000_nvm.c | 5 +++-- 2 files changed, 5 insertions(+

[dpdk-dev] [PATCH v3 06/27] net/e1000/base: fall through explicitly

2020-07-06 Thread Guinan Sun
Found some inconsistent code comments when it came to when we "fall through", so made them more consistent and non-repetitive. This patch adds/changes fall through comments to address new warnings produced by gcc 7. Signed-off-by: Jeff Kirsher Signed-off-by: Todd Fujinaka Signed-off-by: Guinan

[dpdk-dev] [PATCH v3 05/27] net/e1000/base: expose xmdio methods

2020-07-06 Thread Guinan Sun
move read and write xmdio methods to e1000_phy. Signed-off-by: Neftin Sasha Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 71 drivers/net/e1000/base/e1000_i210.h | 4 -- drivers/net/e1000/base/e1000_phy.c | 72 + d

[dpdk-dev] [PATCH v3 07/27] net/e1000/base: add function parameter descriptions

2020-07-06 Thread Guinan Sun
Add function parameter descriptions to address gcc 7 warnings. Signed-off-by: Todd Fujinaka Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.c | 11 +-- drivers/net/e1000/base/e1000_mac.c | 8 drivers/net/e1000/base/e1000_mbx.c | 4 drivers/net/e1000/

Re: [dpdk-dev] [PATCH] maintainers: update for netcope sze/nfb

2020-07-06 Thread Ferruh Yigit
On 6/18/2020 3:29 PM, Martin Špinler wrote: > Acked-by: Martin Spinler >> Setting Martin Spinler as new and only maintainer for Netcope >> libsze2/nfb drivers >> >> Signed-off-by: Jakub Neruda > Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v3 09/27] net/e1000/base: modify HW level time sync mechanisms

2020-07-06 Thread Guinan Sun
Add additinal configuration space access to allow HW level time sync mechanism. Signed-off-by: Efimov Evgeny Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 18 ++ drivers/net/e1000/base/e1000_ich8lan.h | 1 + 2 files changed, 19 insertions(+) diff --git

[dpdk-dev] [PATCH v3 10/27] net/e1000/base: remove duplicated codes

2020-07-06 Thread Guinan Sun
Add two files base.c and base.h to reduce the redundancy in the silicon family code. Remove the code duplication from e1000_82575 files. Clean family specific functions from base. Fix up a stray and duplicate function declaration. Signed-off-by: Jeff Kirsher Signed-off-by: Sasha Neftin Signed-of

[dpdk-dev] [PATCH v3 11/27] net/e1000/base: expose MAC functions

2020-07-06 Thread Guinan Sun
Now the functions are being accessed outside of the file, we need to properly expose them for silicon families to use. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_mac.c | 3 +-- drivers/net/e1000/base/e1000_mac.h | 1 + 2 files changed, 2 insertions(+)

[dpdk-dev] [PATCH v3 12/27] net/e1000/base: add define to PCIm function state

2020-07-06 Thread Guinan Sun
Added define to pcim function state. Signed-off-by: Lifshits Vitaly Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h b/drivers/net/e1000/base/e1000_defines.h index 06759cc3b..41a2b5c3

[dpdk-dev] [PATCH v3 14/27] net/e1000/base: increased timeout for ME ULP exit

2020-07-06 Thread Guinan Sun
Due timing issues in WHL and since recovery by host is not always supported, increased timeout for Manageability Engine(ME) to finish Ultra Low Power(ULP) exit flow for Nahum before timer expiration. Signed-off-by: Efrati Nir Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c

[dpdk-dev] [PATCH v3 08/27] net/e1000/base: improve code style and fix klocwork errors

2020-07-06 Thread Guinan Sun
This patch fixes coding style and klocwork errors. Fix typo in piece of code of NVM access for SPT. And cleans up the remaining instances in the shared code where it was not adhering to the Linux code standard. Wrong description was found in the mentioned file, so fix them. Remove shadowing variab

[dpdk-dev] [PATCH v3 18/27] net/e1000/base: add missed define for VFTA

2020-07-06 Thread Guinan Sun
VLAN filtering using the VFTA (VLAN Filter Table Array) and should be initialized prior to setting rx mode. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_defines.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_defines.h

[dpdk-dev] [PATCH v3 17/27] net/e1000/base: remove useless statement

2020-07-06 Thread Guinan Sun
As it stands now, this fix will not change the current functionality of the code. In addition, we remove the comment that seemed to be a copy/paste from a separate implementation. Signed-off-by: Jeb Cramer Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.c | 7 --- 1 file

[dpdk-dev] [PATCH v3 15/27] net/e1000/base: add missing device ID

2020-07-06 Thread Guinan Sun
Adding Intel(R) I210 Gigabit Network Connection 15F6 device ID for SGMII flashless automotive device. Signed-off-by: Kamil Bednarczyk Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 1 + drivers/net/e1000/base/e1000_hw.h | 1 + 2 files changed, 2 insertions(+) diff --git a/

[dpdk-dev] [PATCH v3 16/27] net/e1000/base: expose more future extended NVM

2020-07-06 Thread Guinan Sun
Future extended NVM 5 (five) required for a Dynamic Power Gating control in the MAC. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1

[dpdk-dev] [PATCH v3 13/27] net/e1000/base: add missing register defines

2020-07-06 Thread Guinan Sun
Added defines for the EEC, SHADOWINF and FLFWUPDATE registers needed for the nvmupd_validate_offset function to correctly validate the NVM update offset. Signed-off-by: Jeff Kirsher Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 5 + 1 file changed, 5 insertions(+) dif

[dpdk-dev] [PATCH v3 20/27] net/e1000/base: led blinking fix for i210

2020-07-06 Thread Guinan Sun
Added initialization of identification LED. Signed-off-by: Maciej Hefczyc Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_i210.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net/e1000/base/e1000_i210.c b/drivers/net/e1000/base/e1000_i210.c index 553803261..d32b0f

[dpdk-dev] [PATCH v3 19/27] net/e1000/base: modify flow control setup

2020-07-06 Thread Guinan Sun
Customers had a problem with large pings after connected standby. This is due to the requirement of maintaining link after CS - the driver blocks resets during "AdapterStart" and skips flow control setup. Added condition in e1000_setup_link_ich8lan.c function that always setup flow control, and set

[dpdk-dev] [PATCH v3 22/27] net/e1000/base: add support for Nahum10

2020-07-06 Thread Guinan Sun
Add support to a new MAC type (for Nahum10). Signed-off-by: Roman Fridlyand Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_hw.h | 1 + drivers/net/e1000/base/e1000_ich8lan.c | 9 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/e10

[dpdk-dev] [PATCH v3 21/27] net/e1000/base: expose new FEXTNVM registers and masks

2020-07-06 Thread Guinan Sun
Adding defines for FEXTNVM8 and FEXTNVM12 registers with new masks for future use. Signed-off-by: Nir Efrati Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_ich8lan.h | 3 ++- drivers/net/e1000/base/e1000_regs.h| 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a

[dpdk-dev] [PATCH v3 24/27] net/e1000/base: introduce DPGFR register

2020-07-06 Thread Guinan Sun
Defined DPGFR, Dynamic Power Gate Force Control Register. Signed-off-by: Vitaly Lifshits Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_regs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/e1000/base/e1000_regs.h b/drivers/net/e1000/base/e1000_regs.h index 8ee1c76

[dpdk-dev] [PATCH v3 23/27] net/e1000/base: add ADL device ID

2020-07-06 Thread Guinan Sun
Add new device ID for Alder Lake brand. Signed-off-by: Sasha Neftin Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_api.c | 7 +++ drivers/net/e1000/base/e1000_hw.h | 4 2 files changed, 11 insertions(+) diff --git a/drivers/net/e1000/base/e1000_api.c b/drivers/net/e1000/

[dpdk-dev] [PATCH v3 25/27] net/e1000/base: cleanup pre-processor tags

2020-07-06 Thread Guinan Sun
The codes has been exposed correctly, so remove pre-processor tags. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_82575.h | 2 -- drivers/net/e1000/base/e1000_defines.h | 9 + drivers/net/e1000/base/e1000_hw.h | 4 drivers/net/e1000/base/e1000_ich8lan.c | 19 -

[dpdk-dev] [PATCH v3 27/27] net/e1000/base: update version

2020-07-06 Thread Guinan Sun
Update base code version in readme. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/README | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/e1000/base/README b/drivers/net/e1000/base/README index 56738d001..b84ee5ad6 100644 --- a/drivers/net/e1000/base/REA

Re: [dpdk-dev] Epoll installation in FreeBSD

2020-07-06 Thread Bruce Richardson
On Sun, Jul 05, 2020 at 03:27:30PM +0500, Ibtisam Tariq wrote: > Hey. > > I've tried to install a new copy of FreeBSD. But it can't find the > sys/epoll.h header file. > I have searched and sys/epoll.h is not available on FreeBSD. > > The output of meson builds on FreeBSD. > -

[dpdk-dev] [PATCH v3 26/27] net/e1000/base: modify copyright

2020-07-06 Thread Guinan Sun
Modify the copyright of the file header. Signed-off-by: Guinan Sun --- drivers/net/e1000/base/e1000_80003es2lan.c | 2 +- drivers/net/e1000/base/e1000_80003es2lan.h | 2 +- drivers/net/e1000/base/e1000_82540.c | 2 +- drivers/net/e1000/base/e1000_82541.c | 2 +- drivers/net/e1000/bas

Re: [dpdk-dev] [PATCH] maintainers: update for netvsc

2020-07-06 Thread Ferruh Yigit
On 6/30/2020 4:04 PM, Haiyang Zhang wrote: > > >> -Original Message- >> From: lon...@linuxonhyperv.com >> Sent: Thursday, June 25, 2020 4:30 PM >> To: KY Srinivasan ; Haiyang Zhang >> ; Stephen Hemminger >> Cc: dev@dpdk.org; Long Li >> Subject: [PATCH] maintainers: update for netvsc >>

Re: [dpdk-dev] [PATCH] maintainers: update for vmbus

2020-07-06 Thread Ferruh Yigit
On 7/2/2020 1:04 AM, Stephen Hemminger wrote: > On Thu, 25 Jun 2020 16:52:16 -0700 > Long Li wrote: > >> From: Long Li >> >> Add Long Li as additional maintainer. >> >> Signed-off-by: Long Li > > Acked-by: Stephen Hemminger > Applied to dpdk-next-net/master, thanks.

[dpdk-dev] [PATCH v5 1/4] build: disable vhost NUMA for arm32

2020-07-06 Thread Juraj Linkeš
config/defconfig_arm-armv7a-linux-gcc specifies that RTE_LIBRTE_VHOST_NUMA is not supported on arm32, so disable it in meson. Signed-off-by: Juraj Linkeš --- lib/librte_vhost/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/meson.build b/lib/librte

[dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags

2020-07-06 Thread Juraj Linkeš
Base the flags on config/defconfig_arm-armv7a-linuxapp-gcc. Omit driver flags which can be built on arm32. Signed-off-by: Juraj Linkeš --- config/arm/meson.build | 135 ++--- 1 file changed, 74 insertions(+), 61 deletions(-) diff --git a/config/arm/meson.buil

[dpdk-dev] [PATCH v5 0/4] aarch64 -> arm32 cross compilation support

2020-07-06 Thread Juraj Linkeš
Add support for arm32 cross build in meson and add aarch64 -> arm32 cross build to Travis. The patchset makes use of existing options in config/defconfig_arm-armv7a-linux-gcc a ports those to the meson build system. The aarch64 -> arm32 build currently fails in l3fwd example and ixgbe driver with

[dpdk-dev] [PATCH v5 4/4] ci: add aarch64 -> arm32 cross compiling jobs

2020-07-06 Thread Juraj Linkeš
Add two jobs (static and shared libs), both building on aarch64 and producing 32 bit arm binaries. Do not run tests in these jobs. Signed-off-by: Juraj Linkeš --- .ci/linux-build.sh | 7 ++- .travis.yml| 19 +++ 2 files changed, 25 insertions(+), 1 deletion(-) diff

[dpdk-dev] [PATCH v5 3/4] build: add arm32 meson cross file

2020-07-06 Thread Juraj Linkeš
Use arm-linux-gnueabihf- toolset which comes with standard packages on most used systems, such as Ubuntu and CentOS. Signed-off-by: Juraj Linkeš --- config/arm/arm_armv7a_linux_gcc | 17 + 1 file changed, 17 insertions(+) create mode 100644 config/arm/arm_armv7a_linux_gcc diff

[dpdk-dev] [PATCH v3] app/flow-perf: fix condition of hairpin queues setup

2020-07-06 Thread Wisam Jaddo
The hairpin queue is the one that start from normal rxq, and will be less than nr_queues where nr_queues is the sum of normal and hairpin Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Cc: wis...@mellanox.com Signed-off-by: Wisam Jaddo Reviewed-by: Asaf Penso --- v3: * A

Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow

2020-07-06 Thread Jerin Jacob
On Sun, Jul 5, 2020 at 10:22 AM Matan Azrad wrote: > > > > From: Jerin Jacob: > > On Sun, Jul 5, 2020 at 12:56 AM Matan Azrad wrote: > > > > > > Hi all > > > > > > From: Jerin Jacob: > > > > On Fri, Jul 3, 2020 at 8:57 PM Thomas Monjalon > > > > wrote: > > > > > > > > > > 03/07/2020 17:08, Jerin

Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows

2020-07-06 Thread Fady Bader
Hi Microsoft team, Can you please check Thomas's comment below regarding header licensing (of ip.h and in.h) and verify that it can be used in the dpdk project or do I need to change anything? Headers are taken from: Ip.h: https://code.woboq.org/qt5/include/netinet/ip.h.html In.h: https://code

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-06 Thread Adrian Moreno
On 7/6/20 5:22 AM, Xia, Chenbo wrote: > Hi Adrian, > >> -Original Message- >> From: dev On Behalf Of Adrian Moreno >> Sent: Thursday, July 2, 2020 4:33 PM >> To: dev@dpdk.org; Ye, Xiaolong ; >> shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; >> Wang, Xiao W ; viac

Re: [dpdk-dev] [PATCH 2/2] devtools: fix forbidden token

2020-07-06 Thread Thomas Monjalon
06/07/2020 10:00, David Marchand: > An expression with a space is split by the awk script resulting in > false positive for any patch matching any of the two part of the > expression. > Fix this by using [[:space:]]. > > Fixes: 43e73483a4b8 ("devtools: forbid variable declaration inside for") > >

Re: [dpdk-dev] [PATCH v5 1/4] build: disable vhost NUMA for arm32

2020-07-06 Thread David Marchand
On Mon, Jul 6, 2020 at 10:29 AM Juraj Linkeš wrote: > > config/defconfig_arm-armv7a-linux-gcc specifies that > RTE_LIBRTE_VHOST_NUMA is not supported on arm32, so disable it in meson. > > Signed-off-by: Juraj Linkeš > --- > lib/librte_vhost/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [dpdk-dev] [PATCH] add flow shared action API

2020-07-06 Thread Jerin Jacob
On Sun, Jul 5, 2020 at 3:56 PM Ori Kam wrote: > > Hi Jerin, > PSB, > > Thanks, > Ori > > > -Original Message- > > From: Jerin Jacob > > Sent: Saturday, July 4, 2020 3:33 PM > > dpdk-dev > > Subject: Re: [dpdk-dev] [PATCH] add flow shared action API > > > > On Sat, Jul 4, 2020 at 3:40 PM

Re: [dpdk-dev] [PATCH v4 1/2] vhost: introduce async enqueue registration API

2020-07-06 Thread Fu, Patrick
Hi, > -Original Message- > From: Liu, Yong > Sent: Monday, July 6, 2020 11:06 AM > To: Fu, Patrick ; dev@dpdk.org; > maxime.coque...@redhat.com; Xia, Chenbo ; Wang, > Zhihong > Cc: Fu, Patrick ; Wang, Yinan > ; Jiang, Cheng1 ; Liang, > Cunming > Subject: RE: [dpdk-dev] [PATCH v4 1/2] vh

Re: [dpdk-dev] [PATCH v3 3/5] app/testpmd: re-implement commands by using private API

2020-07-06 Thread Yang, Qiming
> -Original Message- > From: Di, ChenxuX > Sent: Wednesday, July 1, 2020 16:25 > To: dev@dpdk.org > Cc: Yang, Qiming ; Guo, Jia ; Di, > ChenxuX > Subject: [PATCH v3 3/5] app/testpmd: re-implement commands by using > private API > > The legacy filter API will be superseded. This patch

Re: [dpdk-dev] [PATCH v5 2/4] build: add arm32 meson build flags

2020-07-06 Thread Jerin Jacob
On Mon, Jul 6, 2020 at 1:59 PM Juraj Linkeš wrote: > > Base the flags on config/defconfig_arm-armv7a-linuxapp-gcc. > Omit driver flags which can be built on arm32. > > Signed-off-by: Juraj Linkeš Hi Juraj, Not strictly specific to this patch. Just to understand, How armv7 support has been used?

Re: [dpdk-dev] [PATCH v5 4/4] ci: add aarch64 -> arm32 cross compiling jobs

2020-07-06 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Monday, July 6, 2020 10:28 AM > To: bruce.richard...@intel.com; acon...@redhat.com; > maicolgabr...@hotmail.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v5 4/4] ci: add aarch64 -> arm32 cross compiling jobs > > Add two jobs (s

Re: [dpdk-dev] [PATCH v4 1/2] eal: add WC store functions

2020-07-06 Thread Nicolau, Radu
Hi David, thanks for reviewing! Some comments inline. On 7/3/2020 4:19 PM, David Marchand wrote: On Thu, Jul 2, 2020 at 11:24 AM Radu Nicolau wrote: +static inline void +rte_write32_wc(uint32_t value, volatile void *addr); This is a new API, and even if inlined, it should be marked experime

Re: [dpdk-dev] [PATCH v5 00/13] rte_log registration usage improvement

2020-07-06 Thread Jerin Jacob
On Fri, Jul 3, 2020 at 7:26 PM David Marchand wrote: > > On Wed, Jul 1, 2020 at 2:34 PM wrote: > > > > From: Jerin Jacob > > > > This patch series improves the rte_log registration code snippet by > > avoiding duplication of the code around registration by > > introducing RTE_LOG_REGISTER macro.

Re: [dpdk-dev] [PATCH 1/2] devtools: fix filename in forbidden token check

2020-07-06 Thread Arnon Warshavsky
On Mon, Jul 6, 2020 at 11:00 AM David Marchand wrote: > Fix displayed filename by adjusting the extraction from the patch. > > Before: > Warning in /lib/librte_eal/linux/eal.c: > > After: > Warning in lib/librte_eal/linux/eal.c: > > Fixes: 7413e7f2aeb3 ("devtools: alert on new calls to exit from

Re: [dpdk-dev] [pull-request] next-eventdev 20.08 RC1

2020-07-06 Thread Thomas Monjalon
05/07/2020 05:41, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev > > > Harman Kalra (1): > event/octeontx: fix memory corruption > > Harry van Haaren (1): > examples/eventdev_pipeline: fix 32-

[dpdk-dev] [PATCH] net/ice: fix incorrect error log in generic flow

2020-07-06 Thread Shougang Wang
When create a rss rule with void action, the error log is "Invalid input set". This patch fix the issue by adding check for the type of first actions item. Fixes: 7615a6895009 ("net/ice: rework for generic flow enabling") Cc: sta...@dpdk.org Signed-off-by: Shougang Wang --- drivers/net/ice/ice_

Re: [dpdk-dev] [dpdk-dev v4 1/4] cryptodev: add symmetric crypto data-path APIs

2020-07-06 Thread Zhang, Roy Fan
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Saturday, July 4, 2020 7:16 PM > To: Zhang, Roy Fan ; dev@dpdk.org; > ano...@marvell.com; asoma...@amd.com; ruifeng.w...@arm.com; > Nagadheeraj Rottela ; Michael Shamis > ; Ankur Dwivedi ; Jay > Zhou ; De Lara Guarch, Pablo > > C

Re: [dpdk-dev] [PATCH v2 4/4] eventdev: relax smp barriers with c11 atomics

2020-07-06 Thread Thomas Monjalon
02/07/2020 07:26, Phil Yang: > The implementation-specific opaque data is shared between arm and cancel > operations. The state flag acts as a guard variable to make sure the > update of opaque data is synchronized. This patch uses c11 atomics with > explicit one way memory barrier instead of full

Re: [dpdk-dev] [PATCH v5 01/51] net/bnxt: add basic infrastructure for VF reps

2020-07-06 Thread Ferruh Yigit
On 7/3/2020 10:01 PM, Ajit Khaparde wrote: > From: Somnath Kotur > > Defines data structures and code to init/uninit > VF representors during pci_probe and pci_remove > respectively. > Most of the dev_ops for the VF representor are just > stubs for now and will be will be filled out in next patch

Re: [dpdk-dev] [PATCH v5 00/51] net/bnxt: add features for host-based flow management

2020-07-06 Thread Ferruh Yigit
On 7/3/2020 10:01 PM, Ajit Khaparde wrote: > v1->v2: > - update commit message > - rebase patches against latest changes in the tree > - fix signed-off-by tags > - update release notes > > v2->v3: > - fix compilation issues > > v3->v4: > - rebase against latest dpdk-next-net > > v4->v5: >

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-06 Thread Xia, Chenbo
Hi Adrian, > -Original Message- > From: Adrian Moreno > Sent: Monday, July 6, 2020 4:49 PM > To: Xia, Chenbo ; dev@dpdk.org; > shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; > Wang, Xiao W ; viachesl...@mellanox.com > Cc: jasow...@redhat.com; l...@redhat.com > Subje

Re: [dpdk-dev] [PATCH v5 1/3] eal: disable function versioning on Windows

2020-07-06 Thread Fady Bader
> -Original Message- > From: Bruce Richardson > Sent: Monday, July 6, 2020 11:20 AM > To: Fady Bader > Cc: dev@dpdk.org; Thomas Monjalon ; Tasnim Bashar > ; Tal Shnaiderman ; Yohad Tor > ; dmitry.kozl...@gmail.com; > harini.ramakrish...@microsoft.com; ocard...@microsoft.com; > pallavi.

[dpdk-dev] [PATCH 0/3] Minor rawdev fixes and enhancements

2020-07-06 Thread Bruce Richardson
Improve the rawdev info_get function to return the numa socket id value to the user, and to allow querying basic info of an unknown device by allowing generic info to be returned without having to know the device type. Also add in the missing dump function to the map file. Bruce Richardson (3):

[dpdk-dev] [PATCH 3/3] rawdev: fix missing dump function in map file

2020-07-06 Thread Bruce Richardson
The rte_rawdev_dump function was missing from the map file, meaning it was unavailable for use when linking dynamically. Fixes: c88b3f2558ed ("rawdev: introduce raw device library") Cc: shreyansh.j...@nxp.com Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rawdev/rte_rawdev_v

[dpdk-dev] [PATCH 1/3] rawdev: allow calling info function for unknown rawdevs

2020-07-06 Thread Bruce Richardson
To call the rte_rawdev_info_get() function, the user currently has to know the underlying type of the device in order to pass an appropriate structure or buffer as the dev_private pointer in the info structure. By allowing a NULL value for this field, we can skip getting the device-specific info an

[dpdk-dev] [PATCH 2/3] rawdev: return NUMA socket id to the user

2020-07-06 Thread Bruce Richardson
The rawdev info struct has a socket_id field which was not filled in. We can also omit the checks for the parameter struct being null, since that is previously checked in the function. Cc: sta...@dpdk.org Signed-off-by: Bruce Richardson --- lib/librte_rawdev/rte_rawdev.c | 8 +++- 1 file ch

Re: [dpdk-dev] [PATCH v2 6/8] vhost: add support for virtio get status message

2020-07-06 Thread Adrian Moreno
On 7/6/20 12:29 PM, Xia, Chenbo wrote: > Hi Adrian, > >> -Original Message- >> From: Adrian Moreno >> Sent: Monday, July 6, 2020 4:49 PM >> To: Xia, Chenbo ; dev@dpdk.org; >> shah...@mellanox.com; ma...@mellanox.com; maxime.coque...@redhat.com; >> Wang, Xiao W ; viachesl...@mellanox.co

Re: [dpdk-dev] [PATCH v4 01/10] eal: introduce macros for getting valuefor bit

2020-07-06 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Parav Pandit > Sent: Friday, July 3, 2020 3:47 PM > > There are several drivers which duplicate bit generation macro. > Introduce a generic bit macros so that such drivers avoid redefining > same in multiple drivers. > > Signed-off-by: Parav

[dpdk-dev] 答复: Questions about rte_flow_create APIs

2020-07-06 Thread oulijun
Ok, thanks. I have adjusted. 发件人: Ori Kam [mailto:or...@mellanox.com] 发送时间: 2020年7月5日 19:58 收件人: oulijun ; ferruh.yi...@intel.com 抄送: dev@dpdk.org; us...@dpdk.org 主题: RE: Questions about rte_flow_create APIs Hi Oulijun, First small comment, I think you sent the mail in HTML format, please next

[dpdk-dev] [PATCH v2 2/2] test/service: add test for service active on two lcores

2020-07-06 Thread Andrew Rybchenko
From: Igor Romanov The test checks that the service may be active API works when there are two cores: a non-service lcore and a service one. The API notes to take care when checking the status of a running service, but the test setup allows for a safe usage in that case. Signed-off-by: Igor Rom

[dpdk-dev] [PATCH v2 1/2] service: fix wrong lcore indices

2020-07-06 Thread Andrew Rybchenko
From: Igor Romanov The service core list is populated, but not used. Incorrect lcore states are examined for a service. Use the populated list to iterate over service cores. Fixes: e30dd31847d2 ("service: add mechanism for quiescing") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off

Re: [dpdk-dev] [PATCH] service: fix wrong lcore indexes

2020-07-06 Thread Andrew Rybchenko
On 7/4/20 6:10 PM, David Marchand wrote: > On Sat, Jul 4, 2020 at 5:07 PM Honnappa Nagarahalli > wrote: >> >> Hi Andrew/Igor, >> A effective test case is missing for this, can you please add a test >> case? Otherwise it looks good. > > +1, I was about to reply this. Done in v2

[dpdk-dev] [PATCH v3 1/8] vhost: fix virtio ready flag check

2020-07-06 Thread Adrian Moreno
From: Maxime Coquelin Before checking whether the device is ready is done a check on whether the RUNNING flag is set. Then the READY flag is set if virtio_is_ready() returns true. While it seems to not cause any issue, it makes more sense to check whether the READY flag is set and not the RUNNIN

  1   2   3   4   >