Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 4:02 AM Jiang, Cheng1 wrote: > > - This series breaks external compilation, as the external Makefile was not > > updated. > > > > I'm not sure I understand what you mean by external Makefile, because as far > as I know, makefile has been deprecated. make support is droppe

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 7:10 AM Ibtisam Tariq wrote: > IMHO, it cannot be moved to read_uint16 parser. > If we do, we can't verify that the user input value is greater than > UINT16 MAX or not on the overflow data. > > > + if (data_room_size == 0 || > > > +

Re: [dpdk-dev] [PATCH v4] net/i40e: fix incorrect FDIR flex configuration

2020-11-10 Thread Zhang, Qi Z
> -Original Message- > From: Chenxu Di > Sent: Tuesday, November 10, 2020 3:08 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Di, ChenxuX ; > sta...@dpdk.org > Subject: [PATCH v4] net/i40e: fix incorrect FDIR flex configuration > > The configuration of FDIR flex mask and flex pit should not

Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context

2020-11-10 Thread Ori Kam
Hi, Ferruh and Matan, > -Original Message- > From: Ferruh Yigit > Sent: Monday, November 9, 2020 1:13 PM > To: Matan Azrad ; Wenzhuo Lu ; > Beilei Xing ; Bernard Iremonger > ; Ori Kam > Cc: dev@dpdk.org > Subject: Re: [PATCH v2] app/testpmd: support age shared action context > > On 11/9

Re: [dpdk-dev] [PATCH v8 10/14] build: optional NUMA and cpu counts detection

2020-11-10 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, November 9, 2020 11:53 PM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Ruifeng Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde > (ajit.khapa.

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing

2020-11-10 Thread Suanming Mou
> -Original Message- > From: Xueming Li > Sent: Tuesday, November 3, 2020 7:02 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Suanming Mou ; > sta...@dpdk.org > Subject: [PATCH v1] net/mlx5: fix meter packet missing > > For transfer fl

[dpdk-dev] [PATCH] net/ice: fix mismatched hash flds with hdrs

2020-11-10 Thread Junfeng Guo
Previous code in ice_rss_hash_set has mismatched hash fields and headers for UDP and TCP. Fixes: 16187528a923 ("net/ice/base: refactor RSS configure API") Signed-off-by: Junfeng Guo --- drivers/net/ice/ice_ethdev.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

[dpdk-dev] [RFC] net/i40e: change the timing of FDIR input set configuration

2020-11-10 Thread Chenxu Di
The configuration of FDIR input set should not be set during flow validate. It should be set when flow create. Signed-off-by: Chenxu Di --- drivers/net/i40e/i40e_ethdev.h | 1 + drivers/net/i40e/i40e_fdir.c | 89 +++ drivers/net/i40e/i40e_flow.c | 95 +++-

Re: [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing

2020-11-10 Thread Matan Azrad
From: Xueming Li > For transfer flow with meter, packet was passed without applying flow action. > The group level was multipled by 10 for group level 65531. > > This patch fixes this issue by correcting suffix table group level > calculation. > > Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter tab

Re: [dpdk-dev] [PATCH v8 12/14] build: disable Arm drivers

2020-11-10 Thread Juraj Linkeš
> -Original Message- > From: Honnappa Nagarahalli > Sent: Tuesday, November 10, 2020 12:27 AM > To: Juraj Linkeš ; bruce.richard...@intel.com; > Ruifeng Wang ; Phil Yang ; > vcchu...@amazon.com; Dharmik Thakkar ; > jerinjac...@gmail.com; hemant.agra...@nxp.com; Ajit Khaparde > (ajit.khap

Re: [dpdk-dev] [PATCH 1/8] examples/fips_validation: enhance getopt_long usage

2020-11-10 Thread Ibtisam Tariq
Thanks for explaining. I got it. I will submit the patches with new updates. On Tue, Nov 10, 2020 at 1:23 PM David Marchand wrote: > > On Tue, Nov 10, 2020 at 7:10 AM Ibtisam Tariq > wrote: > > IMHO, it cannot be moved to read_uint16 parser. > > If we do, we can't verify that the user input val

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix string split error handling issue

2020-11-10 Thread Maxime Coquelin
On 11/6/20 4:23 AM, Cheng Jiang wrote: > Add checking return value of string split function to fix the > coverity issue. > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > Coverity issue: 363739 > > Signed-off-by: Cheng Jiang > --- > examples/vhost/ioat.c | 11 +++

Re: [dpdk-dev] [PATCH v1] examples/vhost: fix missing args length check

2020-11-10 Thread Maxime Coquelin
On 11/6/20 4:24 AM, Cheng Jiang wrote: > Add args length check before copying to fix the coverity issue. > > Fixes: 3a04ecb21420 ("examples/vhost: add async vhost args parsing") > Coverity issue: 363741 > > Signed-off-by: Cheng Jiang > --- > examples/vhost/main.c | 6 ++ > 1 file changed

Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context

2020-11-10 Thread Ferruh Yigit
On 11/10/2020 8:30 AM, Ori Kam wrote: Hi, Ferruh and Matan, -Original Message- From: Ferruh Yigit Sent: Monday, November 9, 2020 1:13 PM To: Matan Azrad ; Wenzhuo Lu ; Beilei Xing ; Bernard Iremonger ; Ori Kam Cc: dev@dpdk.org Subject: Re: [PATCH v2] app/testpmd: support age shared ac

Re: [dpdk-dev] [PATCH 1/2] common/sfc_efx/base: apply MCDI version/boot clarity fixes

2020-11-10 Thread Ferruh Yigit
On 11/9/2020 11:49 AM, Andrew Rybchenko wrote: On 11/9/20 2:46 PM, Ivan Malov wrote: Improve the clarity of the code. Fixes: 833cfcd590e2 ("common/sfc_efx/base: add API for querying board info") Fixes: 312191e86eb0 ("common/sfc_efx/base: refactor version / boot info get helper") Signed-off-by

Re: [dpdk-dev] [PATCH v1] app/test: zcd needs to be initialised to fix gcc compile error

2020-11-10 Thread Walsh, Conor
> From: Honnappa Nagarahalli > Sent: Monday 9 November 2020 22:44 > To: Walsh, Conor ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Chen, LingliX ; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [PATCH v1] app/test: zcd needs to be initialised to fix gcc > compile > error > > > > > > > > > >

Re: [dpdk-dev] [PATCH] net/ice: fix missed pointer check

2020-11-10 Thread Ananyev, Konstantin
> -Original Message- > From: dev On Behalf Of Wenzhuo Lu > Sent: Tuesday, November 10, 2020 6:46 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/ice: fix missed pointer check > > The return value of rte_mempool_default_cache should be > checked as it can be N

Re: [dpdk-dev] [PATCH] net/iavf: fix missed pointer check

2020-11-10 Thread Ananyev, Konstantin
> The return value of rte_mempool_default_cache should be > checked as it can be NULL. > > Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") > > Reported-by: Konstantin Ananyev > Signed-off-by: Wenzhuo Lu > --- > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 8 +++- > 1 file changed, 7

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-10 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, November 9, 2020 10:30 PM > > According to the Technical Board decision > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > the mempool pointer in the mbuf struct is moved > from the second to the first half. > It

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > 09/11/2020 19:02, Bruce Richardson: > > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > > 27/10/2020 18:38, Bruce Richardson: > > > > To test the installation process of DPDK using "ninja install" > > > > test-m

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Bruce Richardson
On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > PKG_CONFIG_PATH is specific to each target, so it must be empty > before configuring each build from the file according to DPDK_TARGET. > Inheriting a default PKG_CONFIG_PATH for all targets does not make sense > and is prone to con

Re: [dpdk-dev] [PATCH] net/iavf: fix missed pointer check

2020-11-10 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, November 10, 2020 6:06 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH] net/iavf: fix missed pointer check > > > > > The return value of rte_mempool_default_cach

Re: [dpdk-dev] [PATCH] net/ice: fix missed pointer check

2020-11-10 Thread Zhang, Qi Z
> -Original Message- > From: dev On Behalf Of Ananyev, Konstantin > Sent: Tuesday, November 10, 2020 6:05 PM > To: Lu, Wenzhuo ; dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: Re: [dpdk-dev] [PATCH] net/ice: fix missed pointer check > > > > > -Original Message- > > From: dev On

Re: [dpdk-dev] [PATCH V3 0/6] bugfix and cleanups for hns3

2020-11-10 Thread Ferruh Yigit
On 11/9/2020 2:28 PM, Lijun Ou wrote: Here series include four coverity tool warnings fixes and a bug fixes. V2->V3: 1. fix some checkpatch warnings for patch[3] 2. split patch[3/6] into two independent patchse[3/6] and patch[6/6] according to Ferruh Yigit's advice 3. rewrite commit log for

Re: [dpdk-dev] [PATCH] net/ice: fix mismatched hash flds with hdrs

2020-11-10 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Tuesday, November 10, 2020 4:45 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Guo, Junfeng > Subject: [PATCH] net/ice: fix mismatched hash flds with hdrs > > Previous code in ice_rss_hash_set has mismatched

Re: [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half

2020-11-10 Thread Thomas Monjalon
10/11/2020 11:05, Morten Brørup: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Monday, November 9, 2020 10:30 PM > > > > According to the Technical Board decision > > (http://mails.dpdk.org/archives/dev/2020-November/191859.html), > > the mempool pointer in the mbuf struct is mo

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Thomas Monjalon
10/11/2020 11:14, Bruce Richardson: > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > before configuring each build from the file according to DPDK_TARGET. > > Inheriting a default PKG_CONFIG_PATH for all targe

Re: [dpdk-dev] [PATCH v2] app/testpmd: support age shared action context

2020-11-10 Thread Matan Azrad
From: Ferruh Yigit > On 11/10/2020 8:30 AM, Ori Kam wrote: > > Hi, > > Ferruh and Matan, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Sent: Monday, November 9, 2020 1:13 PM > >> To: Matan Azrad ; Wenzhuo Lu > >> ; Beilei Xing ; Bernard > >> Iremonger ; Ori Kam > >> Cc: dev@d

[dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error

2020-11-10 Thread Conor Walsh
When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc sees zcd in test_ring.h as possibly being uninitialised. To correct this error if statements from _st_ring_dequeue_bulk and _st_ring_enqueue_bulk were corrected within test_ring_mt_peek_stress_zc.c Signed-off-by: Conor Wal

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 09:17:36AM +0100, David Marchand wrote: > On Tue, Nov 10, 2020 at 4:02 AM Jiang, Cheng1 wrote: > > > - This series breaks external compilation, as the external Makefile was > > > not > > > updated. > > > > > > > I'm not sure I understand what you mean by external Makefile,

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote: > 10/11/2020 11:14, Bruce Richardson: > > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > > > PKG_CONFIG_PATH is specific to each target, so it must be empty > > > before configuring each build from the file accordi

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Thomas Monjalon
10/11/2020 11:08, Bruce Richardson: > On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > > 09/11/2020 19:02, Bruce Richardson: > > > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > > > 27/10/2020 18:38, Bruce Richardson: > > > > > To test the installation proces

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > 10/11/2020 11:08, Bruce Richardson: > > On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > > > 09/11/2020 19:02, Bruce Richardson: > > > > On Mon, Nov 09, 2020 at 06:09:51PM +0100, Thomas Monjalon wrote: > > > > > 27

Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing

2020-11-10 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Xueming Li > Sent: Tuesday, November 3, 2020 1:02 PM > To: Matan Azrad ; Slava Ovsiienko > > Cc: dev@dpdk.org; Xueming(Steven) Li ; Asaf Penso > ; Suanming Mou ; > sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packe

[dpdk-dev] [PATCH] net/mlx5: fix validate MPLSoGRE with GRE key

2020-11-10 Thread Xiaoyu Min
From: Xiaoyu Min Currently PMD only accept flow which item_mpls directly follow item_gre, means to match the GRE header without GRE optional field key in MPLSoGRE encapsulation. However, for the MPLSoGRE, the GRE header could have the optional field (i.e, key) according to the RFC. So PMD need t

Re: [dpdk-dev] [PATCH v9 1/6] eal: replace usage of blacklist/whitelist in enum

2020-11-10 Thread Luca Boccassi
On Thu, 2020-11-05 at 14:35 -0800, Stephen Hemminger wrote: > This patch renames the enum values in the EAL include files. > As a backward compatible temporary migration tool, define > a replacement mapping for old values. > > The old names relating to blacklist and whitelist are replaced > by blo

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-10 Thread 谢华伟(此时此刻)
Hi David: I see that you are assigned the reviewer of this patch, and Ferruh have helped reviewed it. I rebased this patch based on his comments. Previously there are different ways to get port address based on different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is actually not ne

Re: [dpdk-dev] [PATCH v5 0/3] support both PIO and MMIO BAR for virtio PMD

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 1:35 PM 谢华伟(此时此刻) wrote: > Previously there are different ways to get port address based on > different DPDK uio driver(IGB_UIO/UIO_PCI_GENERIC/VFIO), which is > actually not necessary. > > This patch makes IO/MMIO port map/RW API more generic, which also > supports MMIO.

Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using extern "C". Library headers work directly in cpp code. Linking errors thrown due to the absence of this change in i40e pmd header does not h

2020-11-10 Thread Ferruh Yigit
On 11/9/2020 5:44 PM, Ferruh Yigit wrote: On 11/9/2020 9:49 AM, Zhang, Qi Z wrote: -Original Message- From: dev On Behalf Of Guo, Jia Sent: Monday, November 9, 2020 2:24 PM To: Prateek Agarwal Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] Made i40 header CPP compatible using exte

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-10 Thread David Marchand
On Sun, Nov 1, 2020 at 10:26 PM McDaniel, Timothy wrote: > > + I did not look too much at the PCI code in this file, but I suspect > > we could factor some of it with librte_pci. > > > > Can we look at possibly doing that post rc2 merge? Any update? -- David Marchand

Re: [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

2020-11-10 Thread David Marchand
On Tue, Nov 3, 2020 at 11:07 AM Kinsella, Ray wrote: > Came across an issue with this. > > Essentially what is happening is that an ABI dump file generated with a newer > versions of libabigail > is not guaranteed to be 100% compatible with a older versions. > > That then adds a wrinkle that we n

Re: [dpdk-dev] [PATCH v9 5/6] doc: change references to blacklist and whitelist

2020-11-10 Thread Luca Boccassi
On Thu, 5 Nov 2020 at 22:36, Stephen Hemminger wrote: > > There are two areas where documentation needed update. > The first was use of whitelist when describing address > filtering. > > The other is the legacy -w whitelist option for PCI > which is used in many examples > > Signed-off-by: Stephen

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Thomas Monjalon
10/11/2020 12:34, Bruce Richardson: > On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > > 10/11/2020 11:08, Bruce Richardson: > > > On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > > > > 09/11/2020 19:02, Bruce Richardson: > > > > > On Mon, Nov 09, 2020 at 06:09:5

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 02:04:21PM +0100, Thomas Monjalon wrote: > 10/11/2020 12:34, Bruce Richardson: > > On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > > > 10/11/2020 11:08, Bruce Richardson: > > > > On Mon, Nov 09, 2020 at 08:26:10PM +0100, Thomas Monjalon wrote: > > > > > 09

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-10 Thread Thomas Monjalon
10/11/2020 12:19, Bruce Richardson: > On Tue, Nov 10, 2020 at 09:17:36AM +0100, David Marchand wrote: > > On Tue, Nov 10, 2020 at 4:02 AM Jiang, Cheng1 > > wrote: > > > > - This series breaks external compilation, as the external Makefile was > > > > not > > > > updated. > > > > > > > > > > I'm

[dpdk-dev] [PATCH] net/i40e: fix build for log format specifier

2020-11-10 Thread Ferruh Yigit
build error: i40e_common.c: In function "i40e_parse_discover_capabilities": ../drivers/net/i40e/base/../i40e_logs.h:43:50: error: format "%llX" expects argument of type "long long unsigned int", but argument 7 has type "u64" {aka "long unsigned int" [-Werror=format=] 43

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Thomas Monjalon
10/11/2020 14:19, Bruce Richardson: > On Tue, Nov 10, 2020 at 02:04:21PM +0100, Thomas Monjalon wrote: > > 10/11/2020 12:34, Bruce Richardson: > > > On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > > > > 10/11/2020 11:08, Bruce Richardson: > > > > > On Mon, Nov 09, 2020 at 08:26:1

Re: [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

2020-11-10 Thread Kinsella, Ray
On 10/11/2020 12:53, David Marchand wrote: > On Tue, Nov 3, 2020 at 11:07 AM Kinsella, Ray wrote: >> Came across an issue with this. >> >> Essentially what is happening is that an ABI dump file generated with a >> newer versions of libabigail >> is not guaranteed to be 100% compatible with a o

Re: [dpdk-dev] [PATCH v9 0/6] replace blacklist/whitelist with allow/block

2020-11-10 Thread Luca Boccassi
On Thu, 2020-11-05 at 14:35 -0800, Stephen Hemminger wrote: > This patch series changes the use of the terms blacklist and whitelist > and instead uses block and allow. The change is most visible > in the options passed to DPDK programs for marking which devices > to use. > > The options are also

Re: [dpdk-dev] [PATCH v7 0/4] devtools: abi breakage checks

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 2:54 PM Kinsella, Ray wrote: > > The Travis script flushes the ABI cache on a libabigail version change. > > Why would the libabigail version change in Travis - due do an OS update or > the like? Because in Travis, we compiled our own version of libabigail, the one in ubu

Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-10 Thread Burakov, Anatoly
On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already

Re: [dpdk-dev] [PATCH 1/1] devtools: fix build test config inheritance from env

2020-11-10 Thread Jerin Jacob
On Tue, Nov 10, 2020 at 4:51 PM Bruce Richardson wrote: > > On Tue, Nov 10, 2020 at 11:45:52AM +0100, Thomas Monjalon wrote: > > 10/11/2020 11:14, Bruce Richardson: > > > On Mon, Nov 09, 2020 at 10:00:08PM +0100, Thomas Monjalon wrote: > > > > PKG_CONFIG_PATH is specific to each target, so it must

[dpdk-dev] [PATCH 0/4] net/mlx5: fixes for rx queue count calculation

2020-11-10 Thread Maxime Leroy
This patchset provides several bug fixes for rx queue count calculation for mlx5 driver. Didier Pallard (1): net/mlx5: fix Rx descriptor status returned value Maxime Leroy (3): Revert "net/mlx5: fix Rx queue count calculation" net/mlx5: fixed used initialization in rx_queue_count mlx5: r

[dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-10 Thread Maxime Leroy
This reverts commit d2d57605522d4a43be17e22e649e54033f6d8835. This fix is uncorrect for at least two reasons. First issue, when there are more than 8 CQEs to uncompress, the computation done in this commit cannot work. Because the zip-ai variable describes the current index inside the CQE8 array

[dpdk-dev] [PATCH 4/4] mlx5: re-add support of rx_queue_count for mlx5_rx_burst_mprq

2020-11-10 Thread Maxime Leroy
The commit 014a6936008b ("Revert "net/mlx5: fix Rx queue count calculation"")' has removed the support of rx_queue_count for mlx5_rx_burst_mprq. This commit has been revert because the fixes done on rx_queue_count computation was wrong. Anyway, it's still true that the Rx queue count calculation i

[dpdk-dev] [PATCH 3/4] net/mlx5: fix Rx descriptor status returned value

2020-11-10 Thread Maxime Leroy
From: Didier Pallard Two bugs in rx_queue_count function: - One entry may contain several segments, so 'used' must be multiplied by number of segments per entry to properly reflect the queue usage. - rx_queue_count returns the number of entries used in queue, so it ranges from 0 to max number

[dpdk-dev] [PATCH 2/4] net/mlx5: fixed used initialization in rx_queue_count

2020-11-10 Thread Maxime Leroy
Mini (compressed) completion queue entries (CQEs) are returned by the NIC when PCI back pressure is detected, in which case the first CQE64 contains common packet information followed by a number of CQE8 providing the rest, followed by a matching number of empty CQE64 entries to be used by software

Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-10 Thread Burakov, Anatoly
On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return error. For IOVA as PA, DMA mapping is already

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 02:53:03PM +0100, Thomas Monjalon wrote: > 10/11/2020 14:19, Bruce Richardson: > > On Tue, Nov 10, 2020 at 02:04:21PM +0100, Thomas Monjalon wrote: > > > 10/11/2020 12:34, Bruce Richardson: > > > > On Tue, Nov 10, 2020 at 12:25:13PM +0100, Thomas Monjalon wrote: > > > > > 10

Re: [dpdk-dev] [PATCH v2 2/3] vfio: fix DMA mapping granularity for type1 iova as va

2020-11-10 Thread Burakov, Anatoly
On 10-Nov-20 2:04 PM, Burakov, Anatoly wrote: On 05-Nov-20 9:04 AM, Nithin Dabilpuram wrote: Partial unmapping is not supported for VFIO IOMMU type1 by kernel. Though kernel gives return as zero, the unmapped size returned will not be same as expected. So check for returned unmap size and return

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 02:37:02PM +0100, Thomas Monjalon wrote: > 10/11/2020 12:19, Bruce Richardson: > > On Tue, Nov 10, 2020 at 09:17:36AM +0100, David Marchand wrote: > > > On Tue, Nov 10, 2020 at 4:02 AM Jiang, Cheng1 > > > wrote: > > > > > - This series breaks external compilation, as the e

Re: [dpdk-dev] [PATCH] devtools/test-meson-builds: allow custom set of examples

2020-11-10 Thread Thomas Monjalon
10/11/2020 15:19, Bruce Richardson: > On Tue, Nov 10, 2020 at 02:53:03PM +0100, Thomas Monjalon wrote: > > 10/11/2020 14:19, Bruce Richardson: > > > On Tue, Nov 10, 2020 at 02:04:21PM +0100, Thomas Monjalon wrote: > > > > 10/11/2020 12:34, Bruce Richardson: > > > > > On Tue, Nov 10, 2020 at 12:25:1

Re: [dpdk-dev] [PATCH v10 0/4] add async data path in vhost sample

2020-11-10 Thread Thomas Monjalon
10/11/2020 15:34, Bruce Richardson: > On Tue, Nov 10, 2020 at 02:37:02PM +0100, Thomas Monjalon wrote: > > 10/11/2020 12:19, Bruce Richardson: > > > On Tue, Nov 10, 2020 at 09:17:36AM +0100, David Marchand wrote: > > > > On Tue, Nov 10, 2020 at 4:02 AM Jiang, Cheng1 > > > > wrote: > > > > > > - T

Re: [dpdk-dev] [PATCH v4 4/8] bus/dpaa: use warn instead of error to improve portability

2020-11-10 Thread Fabrizio D'Angelo
I ran into this error and fixed it by removing the include directive for error.h: /drivers/common/dpaax/compat.h:37:10: fatal error: error.h: No such file or directory Not sure if this change was missing or if there is some other way the build should be configured.

[dpdk-dev] [Bug 574] get_num_hugepages_on_node() doesn't mention which node doesn't have free hugepages

2020-11-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=574 Bug ID: 574 Summary: get_num_hugepages_on_node() doesn't mention which node doesn't have free hugepages Product: DPDK Version: 20.11 Hardware: All OS: All

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Ferruh Yigit
On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- dri

Re: [dpdk-dev] [PATCH v2] app/test: fix to prevent zcd gcc compile error

2020-11-10 Thread Honnappa Nagarahalli
> > When DPDK is compiled with gcc < 9 with the optimization level set to 1 gcc > sees zcd in test_ring.h as possibly being uninitialised. To correct this > error if > statements from _st_ring_dequeue_bulk and _st_ring_enqueue_bulk were > corrected within test_ring_mt_peek_stress_zc.c > > Sign

[dpdk-dev] [Bug 575] Hugepages backing file map0 is not being unlinked

2020-11-10 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=575 Bug ID: 575 Summary: Hugepages backing file map0 is not being unlinked Product: DPDK Version: 20.11 Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement

[dpdk-dev] [PATCH 01/10] examples/fips_validation: fix build with pkg-config

2020-11-10 Thread David Marchand
When this example started using rte_cryptodev_sym_session_pool_create, the part for pkg-config builds was not updated. Fixes: 261bbff75e34 ("examples: use separate crypto session mempools") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- examples/fips_validation/Makefile | 2 ++ 1 file ch

[dpdk-dev] [PATCH 00/10] Examples compilation fixes

2020-11-10 Thread David Marchand
I stepped right into Bruce trap [1] and tested all possible examples. The result is this series. 1: https://patchwork.dpdk.org/patch/82361/ -- David Marchand David Marchand (10): examples/fips_validation: fix build with pkg-config examples/ipsec-gw: fix build with pkg-config examples/kni:

[dpdk-dev] [PATCH 02/10] examples/ipsec-gw: fix build with pkg-config

2020-11-10 Thread David Marchand
flow.c: In function ‘parse_flow_tokens’: flow.c:153:23: error: taking address of packed member of ‘struct rte_ipv4_hdr’ may result in an unaligned pointer value [-Werror=address-of-packed-member] 153 | if (ipv4_addr_cpy(&rule->ipv4.spec.hdr.src_addr, | ^~~~

[dpdk-dev] [PATCH 03/10] examples/kni: fix build with pkg-config

2020-11-10 Thread David Marchand
rm -f build/kni build/kni-static build/kni-shared test -d build && rmdir -p build || true [...] /usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol 'pthread_join@@GLIBC_2.2.5' This example explicitly call pthread API and should be linked against the pthread library. Fixes: 724beb913b44 ("

[dpdk-dev] [PATCH 05/10] examples/l3fwd-graph: fix static build

2020-11-10 Thread David Marchand
This example missed the rework from commit 8549295db07b ("build/pkg-config: improve static linking flags"). Fixes: 08bd1a174461 ("examples/l3fwd-graph: add graph-based l3fwd skeleton") Signed-off-by: David Marchand --- examples/l3fwd-graph/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 dele

[dpdk-dev] [PATCH 04/10] examples/l2fwd-crypto: fix build with pkg-config

2020-11-10 Thread David Marchand
Two issues fixed here. First add the experimental flag. Then fix a link issue with the crypto scheduler driver: /usr/bin/ld: /tmp/cchr7aHA.o: in function `main': main.c:(.text.startup+0x1673): undefined reference to `rte_cryptodev_scheduler_workers_get' collect2: error: ld returned 1 exit status

[dpdk-dev] [PATCH 06/10] examples/ntb: fix clean target

2020-11-10 Thread David Marchand
When introducing this example, the cleanup from commit 7e9562a107f1 ("examples: fix make clean when using pkg-config") was missed. Fixes: c5eebf85badc ("examples/ntb: add example for NTB") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- examples/ntb/Makefile | 2 +- 1 file changed, 1 inse

[dpdk-dev] [PATCH 08/10] examples/rxtx_callbacks: fix build with pkg-config

2020-11-10 Thread David Marchand
This example is missing the experimental flag since it uses an experimental API. Fixes: cd1dadeb9b2a ("examples/rxtx_callbacks: support HW timestamp") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- examples/rxtx_callbacks/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/exa

[dpdk-dev] [PATCH 07/10] examples/vhost_blk: fix build with pkg-config

2020-11-10 Thread David Marchand
vhost_blk.c: In function ‘ctrlr_worker’: vhost_blk.c:543:2: warning: implicit declaration of function ‘CPU_ZERO’ [-Wimplicit-function-declaration] 543 | CPU_ZERO(&cpuset); | ^~~~ vhost_blk.c:544:2: warning: implicit declaration of function ‘CPU_SET’ [-Wimplicit-function-declaration]

[dpdk-dev] [PATCH 09/10] devtools: compile all examples with pkg-config

2020-11-10 Thread David Marchand
Compiling examples out of meson must be tested so that those examples Makefile work. This is based on Bruce patch [1], waiting for it (or an equivalent) to be merged. 1: https://patchwork.dpdk.org/patch/82361/ Signed-off-by: David Marchand --- devtools/test-meson-builds.sh | 28

[dpdk-dev] [PATCH 10/10] examples: restore trace point

2020-11-10 Thread David Marchand
Before make removal, those examples were built with experimental flag for tracepoints to be compiled in but the pkg-config part of those makefiles were missed. Fixes: 78d44153de8f ("ethdev: add tracepoints") Signed-off-by: David Marchand --- examples/cmdline/Makefile

Re: [dpdk-dev] [PATCH v8 12/14] build: disable Arm drivers

2020-11-10 Thread Honnappa Nagarahalli
> > > > > > > > > > A few options that disabled drivers in the old makefiles were > > > > > improperly ported to the meson build system. Fix this by adding > > > > > a to the list of disabled > > > > The fixes need to be separated into a different commit as they > > > > need to be backported. > >

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-10 Thread McDaniel, Timothy
I'm not seeing where we can use librte_pci here. We are already using the dpdk low level rte_pci_read_config(..) APIs. Am I missing something? Thanks, Tim > -Original Message- > From: David Marchand > Sent: Tuesday, November 10, 2020 6:52 AM > To: McDaniel, Timothy > Cc: dev ; Carril

[dpdk-dev] DPDK AF_XDP test results.

2020-11-10 Thread Dey, Souvik
Hi All, There is a test plan for the performance tests of different scenarios with AF_XDP in the dpdk docs https://doc.dpdk.org/dts/test_plans/af_xdp_test_plan.html , but I am not able to find the test results of the same. Can anyone please help in sharing the results link for t

Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

2020-11-10 Thread Jerin Jacob
On Fri, Nov 6, 2020 at 2:51 AM Timothy McDaniel wrote: > > Fix memory corruption bug caused by passing address of a 16b value, > instead of address of a 32b value. > > Fixes: 1998008 ("event/dlb: add eventdev probe") > Coverity issue: 363715 > Cc: sta...@dpdk.org > > Signed-off-by: Timothy McDanie

[dpdk-dev] [PATCH] devtools: fix directory filter in forbidden token check

2020-11-10 Thread David Marchand
checkpatches.sh current complains on a patch [1] adding ALLOW_EXPERIMENTAL_API in an example while this check is for app, lib and drivers directories: Warning in examples/ethtool/ethtool-app/Makefile: Using experimental build flag for in-tree compilation The regexp on entering files concerned by

[dpdk-dev] [PATCH 21.02] eal/linux: improve no hugepages logging

2020-11-10 Thread Anatoly Burakov
When no hugepages are found, we log a message about it, but we never specify on which node. We also implicitly declare the page size based on the directory name, but that's not very user friendly. Fix both by changing the text of the message to note the NUMA node (if applicable) and explicitly men

[dpdk-dev] [pull-request] next-eventdev 20.11 RC3

2020-11-10 Thread Jerin Jacob Kollanukkaran
The following changes since commit a8adac0bc098dad9ca7f7977b6204b29669244e8: doc: add instructions for building 32-bit DPDK (2020-11-06 18:49:57 +0100) are available in the Git repository at: http://dpdk.org/git/next/dpdk-next-eventdev for you to fetch changes up to f71399fe63ff57f1d739e7

Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

2020-11-10 Thread McDaniel, Timothy
> -Original Message- > From: Jerin Jacob > Sent: Tuesday, November 10, 2020 9:36 AM > To: McDaniel, Timothy > Cc: Eads, Gage ; dpdk-dev ; Carrillo, > Erik G ; Van Haaren, Harry > ; Jerin Jacob ; > john.mcnam...@dpdk.org; dpdk stable > Subject: Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-10 Thread David Marchand
On Tue, Nov 10, 2020 at 4:29 PM McDaniel, Timothy wrote: > > I'm not seeing where we can use librte_pci here. We are already using the > dpdk low level rte_pci_read_config(..) APIs. > Am I missing something? dlb_pci_find_ext_capability is a copy of rte_pci_find_ext_capability from the pci bus.

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Ferruh Yigit
On 11/10/2020 2:46 PM, Ferruh Yigit wrote: On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap.

Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD

2020-11-10 Thread McDaniel, Timothy
> -Original Message- > From: David Marchand > Sent: Tuesday, November 10, 2020 9:51 AM > To: McDaniel, Timothy > Cc: dev ; Carrillo, Erik G ; Eads, > Gage ; Van Haaren, Harry > ; Jerin Jacob Kollanukkaran > ; Thomas Monjalon ; Gaetan > Rivet > Subject: Re: [dpdk-dev] [PATCH v15 00/23]

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Ferruh Yigit
On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: Unlike TCP, UDP checksums are optional and may be zero to indicate "not set" [RFC 768] (except for IPv6, where this prohibited [RFC 8200]). Add this special case to the checksum offload emulation in net/tap. Signed-off-by: Michael Pfeiffer --- dri

Re: [dpdk-dev] [PATCH] net/tap: Allow all-zero checksum for UDP over IPv4

2020-11-10 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, November 10, 2020 3:47 PM > > On 11/9/2020 2:22 PM, Michael Pfeiffer wrote: > > Unlike TCP, UDP checksums are optional and may be zero to indicate "not > > set" [RFC 768] (except for IPv6, where this prohibited [R

Re: [dpdk-dev] [PATCH 09/10] devtools: compile all examples with pkg-config

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 04:12:18PM +0100, David Marchand wrote: > Compiling examples out of meson must be tested so that those examples > Makefile work. > This is based on Bruce patch [1], waiting for it (or an equivalent) to be > merged. > > 1: https://patchwork.dpdk.org/patch/82361/ > > Signed-

[dpdk-dev] [PATCH 2/4] regex/mlx5: fix UAR allocation

2020-11-10 Thread Viacheslav Ovsiienko
This patch provides the UAR allocation workaround for the hosts where UAR allocation with Write-Combining memory mapping type fails. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/regex/mlx5/mlx

[dpdk-dev] [PATCH 1/4] common/mlx5: share UAR allocation routine

2020-11-10 Thread Viacheslav Ovsiienko
This patch introduces the routine to allocate the UAR (User Access Region) with various memory mapping types. The origin patch being fixed provided the UAR allocation workaround for the mlx5 net PMD only. As it was found the other mlx5 based drivers - vdpa and regex are affected by the issue as wel

[dpdk-dev] [PATCH 4/4] net/mlx5: fix UAR used by ASO queues

2020-11-10 Thread Viacheslav Ovsiienko
The dedicated UAR was allocated for the ASO queues. The shared UAR created for Tx queues can be used instead. Fixes: f935ed4b645a ("net/mlx5: support flow hit action for aging") Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 1 - drivers/net/m

[dpdk-dev] [PATCH 3/4] vdpa/mlx5: fix UAR allocation

2020-11-10 Thread Viacheslav Ovsiienko
This patch provides the UAR allocation workaround for the hosts where UAR allocation with Write-Combining memory mapping type fails. Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko Acked-by: Matan Azrad --- drivers/vdpa/mlx5/mlx5_vdp

Re: [dpdk-dev] [PATCH 00/10] Examples compilation fixes

2020-11-10 Thread Bruce Richardson
On Tue, Nov 10, 2020 at 04:12:09PM +0100, David Marchand wrote: > I stepped right into Bruce trap [1] and tested all possible examples. > The result is this series. > > 1: https://patchwork.dpdk.org/patch/82361/ > > -- > David Marchand > > David Marchand (10): > examples/fips_validation: fix

Re: [dpdk-dev] [PATCH v9 5/6] doc: change references to blacklist and whitelist

2020-11-10 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 02:36:01PM -0800, Stephen Hemminger wrote: > There are two areas where documentation needed update. > The first was use of whitelist when describing address > filtering. > > The other is the legacy -w whitelist option for PCI > which is used in many examples > > Signed-off

Re: [dpdk-dev] [PATCH v9 6/6] doc: update release notes now for block allow changes

2020-11-10 Thread Bruce Richardson
On Thu, Nov 05, 2020 at 02:36:02PM -0800, Stephen Hemminger wrote: > Remove the deprecation notice and add description to the release notes. > > Signed-off-by: Stephen Hemminger > --- > doc/guides/rel_notes/deprecation.rst | 23 --- > doc/guides/rel_notes/release_20_11.rst

  1   2   3   >