On 2021/1/26 20:35, Maxime Coquelin wrote:
On 1/26/21 1:30 PM, 谢华伟(此时此刻） wrote:
On 2021/1/22 15:25, chris wrote:
On 2021/1/21 23:38, Maxime Coquelin wrote:
Do you mean we apply or abandon patch 3? I am both OK. The first
priority to me is to enable MMIO bar support.
OK, so yes, I think we
On Tue, Jan 26, 2021 at 02:24:02PM +, Bruce Richardson wrote:
> On Tue, Jan 26, 2021 at 03:04:25PM +0100, David Marchand wrote:
> > On Tue, Jan 26, 2021 at 12:15 PM Bruce Richardson
> > wrote:
> > >
> > > On Mon, Jan 25, 2021 at 04:51:19PM +0100, David Marchand wrote:
> > > > On Mon, Jan 25, 2
On Tue, Jan 26, 2021 at 2:23 PM Kinsella, Ray wrote:
> >> diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
> >> index 1dc84fa74b..170304c876 100644
> >> --- a/devtools/libabigail.abignore
> >> +++ b/devtools/libabigail.abignore
> >> @@ -11,6 +11,8 @@
> >> ; Explicit ignore
When removing the label "arm_cross_build_getting_the_prerequisite_library"
in the rework of cross_build_dpdk_for_arm64.rst,
the reference to this section got broken.
It went unnoticed because "ninja -C doc" does not regenerate the file
which is referencing the changed file.
Fixes: eb0e12c0c299 ("d
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.
Signed-off-by: Nalla Pradeep
<...>
@@ -0,0 +1,8 @@
+;
+; Supported features of the 'octeontx_ep' network poll mode driver.
+;
+; R
IPv6 DSCP field ID is missing from the original list of Field IDs
for MODIFY_FIELD action. Add it to support IPv6 header fully.
Add ipv6_dscp option for the corresponding header field in testpmd.
Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
Signed-off-by: Alexander Kozyrev
IPv6 DSCP field ID is missing from the original list of Field IDs
for MODIFY_FIELD action. Add it to support IPv6 header fully.
Add ipv6_dscp option for the corresponding header field in testpmd.
Fixes: 73b68f4c54a ("ethdev: introduce generic modify flow action")
Signed-off-by: Alexander Kozyrev
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Add basic init and uninit function which includes
initializing fields of ethdev private structure.
Signed-off-by: Nalla Pradeep
<...>
ep/otx_ep_common.h
+++ b/drivers/net/octeontx_ep/otx_ep_common.h
@@ -4,11 +4,28 @@
#ifndef _OTX_EP_COMMON_H_
#
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
add basic PCIe ethdev probe and remove.
Signed-off-by: Nalla Pradeep
<...>
@@ -136,7 +136,10 @@ extern int otx2_logtype_ree;
#define PCI_DEVID_OCTEONTX2_RVU_CPT_VF0xA0FE
#define PCI_DEVID_OCTEONTX2_RVU_AF_VF 0xA0f8
#de
On 26/01/2021 14:40, David Marchand wrote:
> On Tue, Jan 26, 2021 at 2:23 PM Kinsella, Ray wrote:
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 1dc84fa74b..170304c876 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignor
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Functions to setup device, basic IQ and OQ registers are added.
As the patch title can you please start with lowercase after module, and do not
use the final '.',
if you run './devtools/check-git-log.sh' script it will highlight these kind of
issues
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Add device information get and device configure operations.
Signed-off-by: Nalla Pradeep
<...>
+static int
+otx_ep_dev_info_get(struct rte_eth_dev *eth_dev,
+ struct rte_eth_dev_info *devinfo)
+{
+ struct otx_ep_device *otx_
26/01/2021 15:39, Bruce Richardson:
> Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed
> throw up the errors with clang - but not gcc, which is strange. The
> offending headers seem to be (initially):
>
> * rte_ethdev_vdev.h
> * rte_ethdev_pci.h
>
> Are these public hea
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Configuring hardware registers with command queue(iq) and droq(oq)
parameters.
Can you please elaborate what functionalit is configured, registers setup is not
clear on its own?
Signed-off-by: Nalla Pradeep
<...>
+static void
+otx2_vf_setup_o
On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> When removing the label "arm_cross_build_getting_the_prerequisite_library"
> in the rework of cross_build_dpdk_for_arm64.rst,
> the reference to this section got broken.
> It went unnoticed because "ninja -C doc" does not regenerate
On Tue, Jan 26, 2021 at 4:08 PM Thomas Monjalon wrote:
>
> When removing the label "arm_cross_build_getting_the_prerequisite_library"
> in the rework of cross_build_dpdk_for_arm64.rst,
> the reference to this section got broken.
> It went unnoticed because "ninja -C doc" does not regenerate the fi
On 1/18/2021 9:36 AM, Nalla Pradeep wrote:
Dev start and stop operations are added. To accomplish this internal
functions to enable or disable io queues are incorporated.
Signed-off-by: Nalla Pradeep
<...>
+static int
+otx_ep_dev_start(struct rte_eth_dev *eth_dev)
+{
+ struct otx_ep_d
On 1/18/2021 9:36 AM, Nalla Pradeep wrote:
Function to deliver packets from DROQ to application is added. It also
fills DROQ with receive buffers timely such that device can fill them
with incoming packets.
Signed-off-by: Nalla Pradeep
<...>
@@ -327,7 +333,8 @@ otx_ep_init_droq(struct otx_e
26/01/2021 16:32, Bruce Richardson:
> On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > in the rework of cross_build_dpdk_for_arm64.rst,
> > the reference to this section got broken.
> > It went unnoti
On 1/18/2021 9:36 AM, Nalla Pradeep wrote:
1. Packet transmit function for both otx and otx2 are added.
2. Flushing transmit(command) queue when pending commands are more than
maximum allowed value (currently 16).
3. Scatter gather support if the packet spans multiple buffers.
Signed-off-by:
If the count action was presented in sample actions list, MLX5 PMD
created the counter resource and saved the index of counter in the
sample resource only, the counter index of flow was not updated.
This patch removes the counter index in the sampler resource and
saves it into the flow, and adds t
On 1/18/2021 9:35 AM, Nalla Pradeep wrote:
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.
Signed-off-by: Nalla Pradeep
For the series,
First of all sorry for the late review, I put some comments on some patches.
Overall
26/01/2021 16:32, David Marchand:
> On Tue, Jan 26, 2021 at 4:08 PM Thomas Monjalon wrote:
> >
> > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > in the rework of cross_build_dpdk_for_arm64.rst,
> > the reference to this section got broken.
> > It went unnoticed bec
On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote:
> 26/01/2021 15:39, Bruce Richardson:
> > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does indeed
> > throw up the errors with clang - but not gcc, which is strange. The
> > offending headers seem to be (initially)
> -Original Message-
> From: Alexander Kozyrev
> Sent: Monday, January 25, 2021 19:01
> To: dev@dpdk.org
> Cc: Raslan Darawsheh ; Slava Ovsiienko
> ; Matan Azrad
> Subject: [PATCH] common/mlx5: add GTP TEID modification field ID
>
> Define hardware ID for GTP TEID modification. This valu
26/01/2021 16:42, Bruce Richardson:
> On Tue, Jan 26, 2021 at 04:31:36PM +0100, Thomas Monjalon wrote:
> > 26/01/2021 15:39, Bruce Richardson:
> > > Removing the ALLOW_INTERNAL_API is probably a good idea, but it does
> > > indeed
> > > throw up the errors with clang - but not gcc, which is strang
On Mon, Jan 25, 2021 at 11:19 PM Pavan Nikhilesh Bhagavatula
wrote:
>
> >For the wmb in order_process_stage_1 and
> >order_process_stage_invalid in
> >the order test, they can be removed. This is because when the test
> >results
> >are wrong, the worker core writes 'true' to t->err. Then other wor
On Tue, Jan 26, 2021 at 04:35:16PM +0100, Thomas Monjalon wrote:
> 26/01/2021 16:32, Bruce Richardson:
> > On Tue, Jan 26, 2021 at 04:07:22PM +0100, Thomas Monjalon wrote:
> > > When removing the label "arm_cross_build_getting_the_prerequisite_library"
> > > in the rework of cross_build_dpdk_for_ar
Disable i40e avx512 code path for windows build to
avoid the mingw build error.
Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
Signed-off-by: Leyi Rong
---
config/x86/cross-mingw | 3 +++
drivers/net/i40e/meson.build | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff
> -Original Message-
> From: David Marchand
> Sent: Monday, January 25, 2021 10:35 PM
> To: Kadam, Pallavi
> Cc: Yigit, Ferruh ; Ali Alnubani ;
> NBU-Contact-Thomas Monjalon ; Richardson, Bruce
> ; Tal Shnaiderman ; Odi Assli
> ; Rong, Leyi ; Zhang, Qi Z
> ; Lu, Wenzhuo ; Xing, Beilei
>
On 1/26/2021 7:38 AM, Leyi Rong wrote:
Disable i40e avx512 code path for windows build to
avoid the mingw build error.
Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
Signed-off-by: Leyi Rong
---
Tested-by: Pallavi Kadam
Verified on Windows using MinGW and clang compiler.
26/01/2021 17:17, Rong, Leyi:
> > > On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
> > >
> > > And for the mingw, I have same result with Ali, I can reproduce with
> > > (Fedora
> > MinGW 9.2.1-6.fc32).
> > >
> > > But different from the CI, I am getting the error [1] for all following
> > > files:
>
On 1/26/2021 4:22 PM, Thomas Monjalon wrote:
26/01/2021 17:17, Rong, Leyi:
On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
And for the mingw, I have same result with Ali, I can reproduce with (Fedora
MinGW 9.2.1-6.fc32).
But different from the CI, I am getting the error [1] for all following file
26/01/2021 17:39, Ferruh Yigit:
> On 1/26/2021 4:22 PM, Thomas Monjalon wrote:
> > 26/01/2021 17:17, Rong, Leyi:
> On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
>
> And for the mingw, I have same result with Ali, I can reproduce with
> (Fedora
> >>> MinGW 9.2.1-6.fc32).
>
> >
On 1/26/2021 4:48 PM, Thomas Monjalon wrote:
26/01/2021 17:39, Ferruh Yigit:
On 1/26/2021 4:22 PM, Thomas Monjalon wrote:
26/01/2021 17:17, Rong, Leyi:
On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
And for the mingw, I have same result with Ali, I can reproduce with (Fedora
MinGW 9.2.1-6.fc32).
On 1/25/2021 6:00 PM, Jerin Jacob wrote:
On Sat, Jan 23, 2021 at 12:49 AM wrote:
From: Liron Himi
This patch series align the mainline driver with all changes since 19.11
some of the patches are fixes which should be pushed to stable
v2:
- fix commit msg styling
- Addressed various review c
On 1/22/2021 7:18 PM, lir...@marvell.com wrote:
From: Yuri Chipchev
4B of CRC was not included in the bytes statistics
Fixes: bdffe0c70 ("net/mrvl: support basic stats")
Cc: sta...@dpdk.org
Signed-off-by: Yuri Chipchev
Reviewed-by: Liron Himi
---
drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
> Subject: [dpdk-dev] [PATCH] net/i40e: fix mingw build error
>
> External email: Use caution opening links or attachments
>
>
> Disable i40e avx512 code path for windows build to avoid the mingw build
> error.
>
> Fixes: e6a6a138919f ("net/i40e: add AVX512 vector path")
>
> Signed-off-by: Ley
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 19:03
To: Liron Himi ; Jerin Jacob Kollanukkaran
Cc: dev@dpdk.org; Yuri Chipchev ; sta...@dpdk.org; Andrew
Rybchenko
Subject: [EXT] Re: [dpdk-stable] [PATCH v2 03/37] net/mvpp2: fix Rx/Tx bytes
statistics
Externa
On 1/26/2021 5:25 PM, Liron Himi wrote:
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 19:03
To: Liron Himi ; Jerin Jacob Kollanukkaran
Cc: dev@dpdk.org; Yuri Chipchev ; sta...@dpdk.org; Andrew
Rybchenko
Subject: [EXT] Re: [dpdk-stable] [PATCH v2 03/37] net/mv
19/01/2021 04:39, Dong Zhou:
> This patch introduces new parameter "--meter" to generate flows with meter
> action in test-flow-perf application.
>
> V2:
> Divide this patch to 2 patches, one includes the split calculation and output
> used cpu time for all insertion items, another includes the su
> Subject: [PATCH] bus/pci: nvme on Windows requires class id and bus
>
> External email: Use caution opening links or attachments
>
>
> Attaching to an NVMe disk on Windows using SPDK requires the PCI class ID
> and device.bus fields. Decode the class ID from the PCI device info strings
> if i
On 1/22/2021 7:18 PM, lir...@marvell.com wrote:
From: Yuri Chipchev
In kernel-4.14 the pp2 kernel occupied 4 RSS tables
as opposed to 1 RSS table in older version.
Signed-off-by: Yuri Chipchev
Reviewed-by: Liron Himi
---
drivers/net/mvpp2/mrvl_ethdev.c | 2 +-
1 file changed, 1 insertion(
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 20:02
To: Liron Himi ; Jerin Jacob Kollanukkaran
Cc: dev@dpdk.org; Yuri Chipchev
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 07/37] net/mvpp2: update RSS tables
reservation
External Email
-
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 18:59
To: Jerin Jacob ; Liron Himi
Cc: Jerin Jacob Kollanukkaran ; dpdk-dev ;
Michael Shamis
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates
External Email
---
Hi Tal,
Thanks for the comments.
+ /* Try and find PCI class ID */
+ for (cp = buf; !(cp[0] == 0 && cp[1] == 0); cp++)
How about
for (cp = buf; cp[0] || cp[1]; cp++)
That would be my preferred idiom, but the DPDK coding style (1.9.1) says
'do not use ! for tests unless it is a boo
From: Maxime Coquelin
> On 1/26/21 11:45 AM, Matan Azrad wrote:
> >
> >
> > From: Maxime Coquelin
> >>> From: Maxime Coquelin
> On 1/14/21 4:23 PM, Matan Azrad wrote:
> >
> >
> > From: Maxime Coquelin
> >> On 1/14/21 2:09 PM, Matan Azrad wrote:
> >>>
> >>>
> >>> F
On 1/22/2021 7:18 PM, lir...@marvell.com wrote:
From: Yuri Chipchev
Add xstats_by_id callbacks
Signed-off-by: Yuri Chipchev
Reviewed-by: Liron Himi
---
drivers/net/mvpp2/mrvl_ethdev.c | 98 -
1 file changed, 95 insertions(+), 3 deletions(-)
diff --git a/dr
Hi,
this patchset contains few bug fixes for the ENA PMD and the version
upgrade to v2.2.1. Besides that, the validation of the Rx req ID was
optimized.
Best regards,
Michal
---
v2:
* Add patch preventing double doorbell on Tx.
Amit Bernstein (1):
net/ena: Tx doorbell statistics fix
Ido Se
From: Ido Segev
As the refill called as part of ena_start(), we end up the refill
progress with stuck buffers at the caller core cache.
Calling to flush the cache results with invalidate this cache and free
those stuck buffers.
Fixes: 1173fca25af9 ("ena: add polling-mode driver")
Cc: sta...@dpd
From: Amit Bernstein
Increment Tx doorbell statistics on tx_pkt_burst
after writing to doorbell and in case max burst size achieved
Fixes: c7519ea5eb8d ("net/ena: call additional doorbells if needed")
Cc: sta...@dpdk.org
Signed-off-by: Amit Bernstein
Reviewed-by: Michal Krawczyk
Reviewed-by:
Instead of veryfing the Rx descriptor each time it's being used in the
driver code, now the verification happens on the HAL side.
This simplifies code a lot as instead of doing 2 validations, only
single one is needed. The driver have to check the rc value returned
by the ena_com upon reading the
From: Igor Chauskin
Before starting transmission of Tx burst, the driver checked the
available space in the sq and limited the number of packets for
transmission accordingly.
The calculation was incorrect for fragmented packets and potentially had
significantly limited the length of Tx bursts.
T
From: Igor Chauskin
Add per-tx-ring flag for packets that were pushed to HW but await
doorbell. That is to prevent a situation when a doorbell is sent due to
reaching Tx burst threshold and next send fails (e.g., due to queue
full). In such case we shouldn't send another doorbell because there ar
On Tue, Jan 19, 2021 at 12:43 PM Gujjar, Abhinandan S
wrote:
>
> Acked-by: abhinandan.guj...@intel.com
Applied to dpdk-next-eventdev/for-main. Thanks.
>
> Thanks & Regards
> Abhinandan
>
> > -Original Message-
> > From: Ankur Dwivedi
> > Sent: Monday, January 18, 2021 9:50 PM
> > To:
The following changes since commit 7be7dc6dea927da7d458cb4172d70338f9eea164:
build: force pkg-config for dependency detection (2021-01-26 00:43:59 +0100)
are available in the Git repository at:
http://dpdk.org/git/next/dpdk-next-eventdev
for you to fetch changes up to 77c4f861b5f72afdfa5922
Use C11-style GCC built-in functions for atomic operations.
Signed-off-by: Mattias Rönnblom
---
drivers/event/dsw/dsw_evdev.c | 5 +
drivers/event/dsw/dsw_evdev.h | 6 +++---
drivers/event/dsw/dsw_event.c | 37 --
drivers/event/dsw/dsw_xstats.c | 4 ++--
add basic PCIe ethdev probe and remove.
Signed-off-by: Nalla Pradeep
---
drivers/common/octeontx2/otx2_common.h| 5 +-
drivers/net/octeontx_ep/meson.build | 2 +
drivers/net/octeontx_ep/otx_ep_common.h | 14 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 62 +
Add device information get and device configure operations.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 15 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 89 -
drivers/net/octeontx_ep/otx_ep_rxtx.h | 10 +++
3 files changed, 111 insertio
Functions to setup device, basic IQ and OQ registers are added.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/meson.build | 2 +
drivers/net/octeontx_ep/otx2_ep_vf.c| 133 +
drivers/net/octeontx_ep/otx2_ep_vf.h| 11 ++
drivers/net/octeontx_ep/otx_ep_
Add basic init and uninit function which includes
initializing fields of ethdev private structure.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 22 ++-
drivers/net/octeontx_ep/otx_ep_ethdev.c | 88 +++--
2 files changed, 104 insertions(+), 6
Configuring hardware registers with command queue(iq) and droq(oq)
parameters.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx2_ep_vf.c| 120 +++
drivers/net/octeontx_ep/otx_ep_common.h | 65 +
drivers/net/octeontx_ep/otx_ep_vf.c | 121 ++
Transmit queue setup involves allocating memory for the command queue
considering tx descriptor count and initializing data structure
representing the queue. Transmit queue release function frees the
command queue.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 89 ++
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.
Signed-off-by: Nalla Pradeep
---
MAINTAINERS | 9 +
doc/guides/nics/features/octeontx_ep.ini | 8
doc/guides/nics/index.rst
1. Packet transmit function for both otx and otx2 are added.
2. Flushing transmit(command) queue when pending commands are more than
maximum allowed value (currently 16).
3. Scatter gather support if the packet spans multiple buffers.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/o
Receive queue setup involves allocating memory for the queue,
initializing data structure representing the queue and filling queue
with receive buffers of rx descriptor count. Receive queues are referred
as droq. Hardware fills the receive buffers in queue with the packet.
In receive queue release
Dev start and stop operations are added. To accomplish this internal
functions to enable or disable io queues are incorporated.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx2_ep_vf.c| 107
drivers/net/octeontx_ep/otx_ep_common.h | 10 ++
drivers/net/octeo
Function to deliver packets from DROQ to application is added. It also
fills DROQ with receive buffers timely such that device can fill them
with incoming packets.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 2 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 +
d
As a general principle, each header file should include any other
headers it needs to provide data type definitions or macros. For
example, any header using the uintX_t types in structures or function
prototypes should include "stdint.h" to provide those type definitions.
In practice, while many,
Include 'rte_branch_prediction.h' to get the likely/unlikely macro
definitions.
Fixes: 2173fb61 ("mcslock: add MCS queued lock implementation")
Cc: sta...@dpdk.org
Signed-off-by: Bruce Richardson
---
lib/librte_eal/include/generic/rte_mcslock.h | 1 +
1 file changed, 1 insertion(+)
diff --
Clang does not have an "error" attribute for functions, so for marking
internal functions we need to check for the error attribute, and provide
a fallback if it is not present. For clang, we can use "diagnose_if"
attribute, similarly checking for its presence before use.
Fixes: fba5af82adc8 ("eal:
The rte_ethdev_driver.h, rte_ethdev_vdev.h and rte_ethdev_pci.h files are
for drivers only and should be a private to DPDK and not installed.
Signed-off-by: Bruce Richardson
---
app/test/test_link_bonding.c | 2 +-
app/test/test_pdump.c
The rte_rib6 header was using RTE_MIN macro from rte_common.h but not
including the header file.
Fixes: f7e861e21c46 ("rib: support IPv6")
Cc: vladimir.medved...@intel.com
Signed-off-by: Bruce Richardson
---
lib/librte_rib/rte_rib6.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/librt
For some libraries, there may be some header files which are not for direct
inclusion, but rather are to be included via other header files. To allow
later checking of these files for missing includes, we separate out the
indirect include files from the direct ones.
Signed-off-by: Bruce Richardson
To verify that all DPDK headers are ok for inclusion directly in a C file,
and are not missing any other pre-requisite headers, we can auto-generate
for each header an empty C file that includes that header. Compiling these
files will throw errors if any header has unmet dependencies.
To ensure on
The check-includes script allowed checking header files in a given
directory to ensure that each header compiled alone without requiring
any other header inclusions.
With header checking now being done by the chkincs app in the build
system this script can be removed.
Signed-off-by: Bruce Richard
For CI builds, turn on the checking of includes.
Signed-off-by: Bruce Richardson
---
.ci/linux-build.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
index afa3689a09..fdbeb5a616 100755
--- a/.ci/linux-build.sh
+++ b/.ci/linux-build.sh
@@ -57,6 +57,7
add basic PCIe ethdev probe and remove.
Signed-off-by: Nalla Pradeep
---
drivers/common/octeontx2/otx2_common.h| 5 +-
drivers/net/octeontx_ep/meson.build | 2 +
drivers/net/octeontx_ep/otx_ep_common.h | 14 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 62 +
Add basic init and uninit function which includes
initializing fields of ethdev private structure.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 22 ++-
drivers/net/octeontx_ep/otx_ep_ethdev.c | 88 +++--
2 files changed, 104 insertions(+), 6
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.
Signed-off-by: Nalla Pradeep
---
MAINTAINERS | 9 +
doc/guides/nics/features/octeontx_ep.ini | 8
doc/guides/nics/index.rst
Receive queue setup involves allocating memory for the queue,
initializing data structure representing the queue and filling queue
with receive buffers of rx descriptor count. Receive queues are referred
as droq. Hardware fills the receive buffers in queue with the packet.
In receive queue release
Functions to setup device, basic IQ and OQ registers are added.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/meson.build | 2 +
drivers/net/octeontx_ep/otx2_ep_vf.c| 133 +
drivers/net/octeontx_ep/otx2_ep_vf.h| 11 ++
drivers/net/octeontx_ep/otx_ep_
Add device information get and device configure operations.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 15 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 89 -
drivers/net/octeontx_ep/otx_ep_rxtx.h | 10 +++
3 files changed, 111 insertio
Function to deliver packets from DROQ to application is added. It also
fills DROQ with receive buffers timely such that device can fill them
with incoming packets.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 2 +
drivers/net/octeontx_ep/otx_ep_ethdev.c | 3 +
d
Transmit queue setup involves allocating memory for the command queue
considering tx descriptor count and initializing data structure
representing the queue. Transmit queue release function frees the
command queue.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx_ep_common.h | 89 ++
Configuring hardware registers with command queue(iq) and droq(oq)
parameters.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx2_ep_vf.c| 120 +++
drivers/net/octeontx_ep/otx_ep_common.h | 65 +
drivers/net/octeontx_ep/otx_ep_vf.c | 121 ++
1. Packet transmit function for both otx and otx2 are added.
2. Flushing transmit(command) queue when pending commands are more than
maximum allowed value (currently 16).
3. Scatter gather support if the packet spans multiple buffers.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/o
Dev start and stop operations are added. To accomplish this internal
functions to enable or disable io queues are incorporated.
Signed-off-by: Nalla Pradeep
---
drivers/net/octeontx_ep/otx2_ep_vf.c| 107
drivers/net/octeontx_ep/otx_ep_common.h | 10 ++
drivers/net/octeo
26/01/2021 19:18, Nick Connolly:
> Hi Tal,
>
> Thanks for the comments.
>
> >> + /* Try and find PCI class ID */
> >> + for (cp = buf; !(cp[0] == 0 && cp[1] == 0); cp++)
> > How about
> > for (cp = buf; cp[0] || cp[1]; cp++)
> That would be my preferred idiom, but the DPDK coding styl
On 1/22/2021 7:18 PM, lir...@marvell.com wrote:
From: Yuri Chipchev
Save configuration that was done prior 'start' as
only then the ppio is being configured.
Can you please give more details on what is saved and why?
Signed-off-by: Yuri Chipchev
Reviewed-by: Liron Himi
---
drivers/net/
Add documentation to support i40e PMD on Windows.
Update the release notes and features list for the same.
v2 changes:
- updated doc/guides/nics/features/i40e.ini file
- Replaced the name UIO with NetUIO
Signed-off-by: Pallavi Kadam
Reviewed-by: Ranjit Menon
---
doc/guides/nics
On 1/26/2021 6:07 PM, Liron Himi wrote:
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 18:59
To: Jerin Jacob ; Liron Himi
Cc: Jerin Jacob Kollanukkaran ; dpdk-dev ; Michael
Shamis
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 00/37] net/mvpp2: misc updates
External E
On 1/22/2021 7:19 PM, lir...@marvell.com wrote:
From: Liron Himi
mbuf->port can be override and used for eventdev
so saving the port-id information in another field
that can be queried by application
Signed-off-by: Liron Himi
---
drivers/net/mvpp2/mrvl_ethdev.c | 1 +
1 file changed, 1 ins
On 1/22/2021 7:19 PM, lir...@marvell.com wrote:
From: Liron Himi
Currently the HW is configured with only one pool which its
buffer size may be larger than the rx-fifo-size.
In that situation, frame size larger than the fifo-size
is gets dropped due to fifo overrun.
this is cause because the HW
On 1/22/2021 7:19 PM, lir...@marvell.com wrote:
From: Liron Himi
Extend the config file with 'start-hdr' field.
currently 'eth' (default) and 'dsa' headers are supported.
Signed-off-by: Liron Himi
<...>
@@ -575,13 +607,15 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char
*path,
On 1/22/2021 7:19 PM, lir...@marvell.com wrote:
From: Liron Himi
Extend the config file with 'start-hdr' field.
currently 'eth' (default) and 'dsa' headers are supported.
Signed-off-by: Liron Himi
There are multiple update to the config file in this series, but the
documentation is not upd
On 1/26/2021 6:05 PM, Liron Himi wrote:
-Original Message-
From: Ferruh Yigit
Sent: Tuesday, 26 January 2021 20:02
To: Liron Himi ; Jerin Jacob Kollanukkaran
Cc: dev@dpdk.org; Yuri Chipchev
Subject: [EXT] Re: [dpdk-dev] [PATCH v2 07/37] net/mvpp2: update RSS tables
reservation
Exte
On 1/25/2021 6:00 PM, Jerin Jacob wrote:
On Sat, Jan 23, 2021 at 12:49 AM wrote:
From: Liron Himi
This patch series align the mainline driver with all changes since 19.11
some of the patches are fixes which should be pushed to stable
v2:
- fix commit msg styling
- Addressed various review c
On 1/26/2021 9:30 PM, Nalla Pradeep wrote:
Adding bare minimum PMD library and doc build infrastructure
and claim the maintainership for octeontx end point PMD.
Signed-off-by: Nalla Pradeep
Hi Nalla,
As I quickly checked many comments not addressed, can you please add a change
log to the co
> -Original Message-
> From: dapengx...@intel.com
> Sent: Tuesday, January 26, 2021 5:52 PM
> To: Xing, Beilei ; Guo, Jia
> Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org
> Subject: [PATCH] net/i40e: fix register setting for hash enable
>
> From: Dapeng Yu
>
> The original code cau
101 - 200 of 212 matches
Mail list logo
