[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-20 Thread Feifei Wang
Hi, Slava Another question suddenly occurred to me, in order to keep the order that rebuilding global cache before updating ”dev_gen“, the wmb should be before updating "dev_gen" rather than after it. Otherwise, in the out-of-order platforms, current order cannot be kept. Thus, we should change

[dpdk-dev] [PATCH V2 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-20 Thread Huisong Li
After DCB mode is configured, if we decrease the number of RX and TX queues, fwd_config_setup() will be called to setup the DCB forwarding configuration. And forwarding streams are updated based on new queue numbers in fwd_config_setup(), but the mapping between the TC and queues obtained by rte_et

[dpdk-dev] [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-20 Thread Huisong Li
Currently, 'nb_fwd_lcores' value are both adjusted based on 'nb_fwd_streams' in rss/simple/icmp_echo_fwd_config_setup. But the operation is missing in dcb_fwd_config_setup, which may lead to a bad behavior in which multiple polling threads operate on the same queue. In this case, the device sends a

[dpdk-dev] [PATCH V2 0/7] modifications about DCB forwarding configuration

2021-04-20 Thread Huisong Li
This patchset modifies some codes about DCB forwarding configuration. It mainly includes: - fix forward lcores number when dcb test - remove dcb_test - fix a segment fault when dcb test - add check for support of reporting dcb info - move position of verifying DCB test - add forwarding config in st

[dpdk-dev] [PATCH V2 7/7] app/testpmd: remove redundant fwd streams initialization

2021-04-20 Thread Huisong Li
The fwd_config_setup() is called after init_fwd_streams(). The fwd_config_setup() will reinitialize forwarding streams. This patch removes init_fwd_streams() from init_config(). Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions(-)

[dpdk-dev] [PATCH V2 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-20 Thread Huisong Li
After DCB mode is configured, the operations of port stop and port start change the value of the global variable "dcb_test", As a result, the forwarding configuration from DCB to RSS mode, namely, “dcb_fwd_config_setup()” to "rss_fwd_config_setup()". Currently, the 'dcb_flag' field in struct 'rte_

[dpdk-dev] [PATCH V2 5/7] app/testpmd: move position of verifying DCB test

2021-04-20 Thread Huisong Li
Currently, the check for doing DCB test is assigned to start_packet_forwarding(), which will be called when run "start" cmd. But fwd_config_setup() is used in many scenarios, such as, "port config all rxq". This patch moves the check from start_packet_forwarding() to fwd_config_setup(). Fixes: 77

[dpdk-dev] [PATCH V2 4/7] app/testpmd: add check for support of reporting DCB info

2021-04-20 Thread Huisong Li
Currently, '.get_dcb_info' must be supported for the port doing DCB test, or all information in 'rte_eth_dcb_info' are zero. It should be prevented when user run cmd "port config 0 dcb vt off 4 pfc off". This patch adds the check for support of reporting dcb info. Signed-off-by: Huisong Li Signe

[dpdk-dev] [PATCH V2 6/7] app/testpmd: add forwarding config in start port

2021-04-20 Thread Huisong Li
Most operations in testpmd that need to update the forwarding streams in testpmd call fwd_config_setup(). In some scenarios, eg, dev_configure is called again, the forwarding streams may not be updated. As a result, the actual forwarding streams cannot be queried by "show config fwd" cmd. The proc

Re: [dpdk-dev] [PATCH 0/3] Fixes for testpmd

2021-04-20 Thread Huisong Li
Hi, Ferruh and Xiaoyun, Lijun has other arrangements, I will be responsible for closing this patchset. V2 has been sent. Please review. Thanks! 在 2021/3/5 18:22, Lijun Ou 写道: This series add two test bug fixes and a print style. Hongbo Zheng (1): app/testpmd: use of Rx/Tx in testpmd Huis

Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-20 Thread Thomas Monjalon
20/04/2021 04:17, Liu, Lingyu: > Hi Olivier, > > This new packet type will be used by iavf driver to map ECPRI hardware packet. > This is the patch which will use this new hardware packet type. > http://patchwork.dpdk.org/project/dpdk/patch/20210420083817.10741-3-lingyu@intel.com/ I think it

Re: [dpdk-dev] [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-20 Thread Slava Ovsiienko
Hi, Feifei In my opinion, there should be 2 barriers: - after global cache update/before altering dev_gen, to ensure the correct order - after altering dev_gen to make this change visible for other agents and to trigger local cache update With best regards, Slava > -Original Message-

Re: [dpdk-dev] [PATCH v3] net/i40e: add Tx preparation for simple Tx data path

2021-04-20 Thread Ananyev, Konstantin
> Introduce i40e_simple_prep_pkts() as the preparation function for > simple Tx data path, as it's for sanity check for simple Tx. > > Suggested-by: Konstantin Ananyev > Signed-off-by: Leyi Rong > --- > drivers/net/i40e/i40e_rxtx.c | 39 +++- > drivers/net/i40e

[dpdk-dev] [PATCH v5] build: use platform option for generic and native

2021-04-20 Thread Juraj Linkeš
The current meson option 'machine' should only specify the ISA, which is not sufficient for Arm, where setting ISA implies other setting as well. Use the existing 'platform' meson option to differentiate the type of the build (native/generic) and set machine accordingly, unless the user chooses to

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value

2021-04-20 Thread Ferruh Yigit
On 3/25/2021 8:46 AM, Zhang, Qi Z wrote: -Original Message- From: dev On Behalf Of Xiaozhen Ban Sent: Friday, March 19, 2021 12:08 PM To: Guo, Jia ; Wang, Haiyue Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix filter control return value -Origin

Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381

2021-04-20 Thread Ferruh Yigit
On 4/1/2021 1:17 PM, Zhang, Qi Z wrote: -Original Message- From: Huang, Wei Sent: Wednesday, March 17, 2021 4:24 PM To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z Cc: sta...@dpdk.org; Zhang, Tianfei ; Huang, Wei Subject: [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Below co

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-20 Thread Yu, DapengX
> -Original Message- > From: Yigit, Ferruh > Sent: Monday, April 19, 2021 11:46 PM > To: Yu, DapengX ; Li, Xiaoyun > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload > reconfig cmd > > On 4/15/2021 7:04 AM,

Re: [dpdk-dev] [PATCH v5] build: use platform option for generic and native

2021-04-20 Thread Juraj Linkeš
> -Original Message- > From: Juraj Linkeš > Sent: Tuesday, April 20, 2021 10:08 AM > To: tho...@monjalon.net; david.march...@redhat.com; > bruce.richard...@intel.com; honnappa.nagaraha...@arm.com; > ruifeng.w...@arm.com > Cc: dev@dpdk.org; Juraj Linkeš > Subject: [PATCH v5] build: use p

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-20 Thread Ferruh Yigit
On 4/20/2021 9:12 AM, Yu, DapengX wrote: -Original Message- From: Yigit, Ferruh Sent: Monday, April 19, 2021 11:46 PM To: Yu, DapengX ; Li, Xiaoyun ; Zhang, Qi Z Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

Re: [dpdk-dev] [RFC 0/2] add Tx prepare support for bonding device

2021-04-20 Thread Ananyev, Konstantin
Hi everyone, > > On 2021/4/20 9:26, Ferruh Yigit wrote: > > On 4/16/2021 12:04 PM, Chengchang Tang wrote: > >> This patch add Tx prepare for bonding device. > >> > >> Currently, the bonding driver has not implemented the callback of > >> rte_eth_tx_prepare function. Therefore, the TX prepare func

[dpdk-dev] net/mlx5: no TX in multi-process setup (testpmd working)

2021-04-20 Thread RajeshKumar Kalidass
Hi, DPDK: 19.11 OS: Ubuntu 18.04 (Kernel: 5.4.0-1043-azure) Iface: Mellanox Technologies MT27710 Family [ConnectX-4 Lx Virtual Function] We are bringing-up our dpdk based app on azure cloud, its multi-process setup (primary does dev_configure & dev_start ) - however no packet are getting transm

Re: [dpdk-dev] [PATCH v5] build: use platform option for generic and native

2021-04-20 Thread Thomas Monjalon
20/04/2021 10:16, Juraj Linkeš: > > option('platform', type: 'string', value: '', > > - description: 'use configuration for a particular platform (such as a > > SoC).') > > +option('platform', type: 'string', value: 'generic', > > + description: 'Platform to build, either "native", "generic" o

Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload reconfig cmd

2021-04-20 Thread Yu, DapengX
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 20, 2021 4:22 PM > To: Yu, DapengX ; Li, Xiaoyun > ; Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [PATCH] app/testpmd: fix queue Rx and Tx offload > reconfig cmd > > On 4/20/2021 9:12 AM,

[dpdk-dev] 回复: [PATCH v1 3/4] net/mlx5: fix rebuild bug for Memory Region cache

2021-04-20 Thread Feifei Wang
Hi, Slava I think the second wmb can be removed. As I know, wmb is just a barrier to keep the order between write and write. and it cannot tell the CPU when it should commit the changes. It is usually used before guard variable to keep the order that updating guard variable after some changes,

[dpdk-dev] [PATCH 1/2] net/af_xdp: fix trigger for syscall on tx

2021-04-20 Thread Ciara Loftus
The send() syscall on the tx path is not concerned with busy polling and as such its invocation should not depend on whether or not it is configured. Fix this by distinguishing the conditions necessary for syscalls on the rx and tx paths individually. Fixes: 055a393626ed ("net/af_xdp: prefer busy

[dpdk-dev] [PATCH 2/2] net/af_xdp: only use recvfrom if busy polling is enabled

2021-04-20 Thread Ciara Loftus
The recvfrom() syscall is only supported by AF_XDP sockets since kernel 5.11. Only use it if busy polling is configured. We can assume a kernel >= 5.11 is in use if busy polling is configured so we can safely call recvfrom() in that case. Fixes: 63e8989fe5a4 ("net/af_xdp: use recvfrom instead of p

[dpdk-dev] [PATCH 3/5] net/hns3: fix unchecked function call

2021-04-20 Thread Min Hu (Connor)
In hns3 PMD, as the handler always return 0, the return value of a function 'rte_kvargs_process' no need to be checked. But the API definition has return value, so 'void' could be used to ignore that. Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function") Signed-off-by:

[dpdk-dev] [PATCH 2/5] net/hns3: fix enum variable used as boolean

2021-04-20 Thread Min Hu (Connor)
params->leaf.cman has enum type which is not isomorphic with boolean type, however it is used as a boolean expression. This patch fixed it. Fixes: c09c7847d892 ("net/hns3: support traffic management") Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_tm.c | 2 +- 1 file changed, 1 inser

[dpdk-dev] [PATCH 0/5] fixes for hns3 PMD

2021-04-20 Thread Min Hu (Connor)
This patch contains three coding fixes and two doc fixes. Min Hu (Connor) (5): net/hns3: delete unused macro net/hns3: fix enum variable used as boolean net/hns3: fix unchecked function call doc: update hns3 feature list doc: fix Rx burst function doc doc/guides/nics/features/hns3.ini

[dpdk-dev] [PATCH 1/5] net/hns3: delete unused macro

2021-04-20 Thread Min Hu (Connor)
'HNS3_RXD_LKBK_B' was defined in previous versions but no used. This patch deleted it. Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations") Cc: sta...@dpdk.org Signed-off-by: Min Hu (Connor) --- drivers/net/hns3/hns3_rxtx.h | 1 - 1 file changed, 1 deletion(-) diff --git a/dr

[dpdk-dev] [PATCH 4/5] doc: update hns3 feature list

2021-04-20 Thread Min Hu (Connor)
Hns3 PMD has supported SR-IOV in 19.11 version. This patch added feature description in hns3.ini. Signed-off-by: Min Hu (Connor) --- doc/guides/nics/features/hns3.ini | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini index

[dpdk-dev] [PATCH 5/5] doc: fix Rx burst function doc

2021-04-20 Thread Min Hu (Connor)
The patch 'net/hns3: rename Rx burst function' changed `simple' Rx function name from 'scalar' to 'scalar simple', but doc ignored that. This patch fixed it. Fixes: aa5baf47e1a3 ("net/hns3: rename Rx burst function") Signed-off-by: Min Hu (Connor) --- doc/guides/nics/hns3.rst | 2 +- 1 file ch

[dpdk-dev] [PATCH V3 0/7] modifications about DCB forwarding configuration

2021-04-20 Thread Huisong Li
This patchset modifies some codes about DCB forwarding configuration. It mainly includes: - fix forward lcores number when dcb test - remove dcb_test - fix a segment fault when dcb test - add check for support of reporting dcb info - move position of verifying DCB test - add forwarding config in st

[dpdk-dev] [PATCH V3 6/7] app/testpmd: add forwarding config in start port

2021-04-20 Thread Huisong Li
Most operations in testpmd that need to update the forwarding streams in testpmd call fwd_config_setup(). In some scenarios, eg, dev_configure is called again, the forwarding streams may not be updated. As a result, the actual forwarding streams cannot be queried by "show config fwd" cmd. The proc

[dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-20 Thread Huisong Li
After DCB mode is configured, if we decrease the number of RX and TX queues, fwd_config_setup() will be called to setup the DCB forwarding configuration. And forwarding streams are updated based on new queue numbers in fwd_config_setup(), but the mapping between the TC and queues obtained by rte_et

[dpdk-dev] [PATCH V3 7/7] app/testpmd: remove redundant fwd streams initialization

2021-04-20 Thread Huisong Li
The fwd_config_setup() is called after init_fwd_streams(). The fwd_config_setup() will reinitialize forwarding streams. This patch removes init_fwd_streams() from init_config(). Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions(-)

[dpdk-dev] [PATCH V3 4/7] app/testpmd: add check for support of reporting DCB info

2021-04-20 Thread Huisong Li
Currently, '.get_dcb_info' must be supported for the port doing DCB test, or all information in 'rte_eth_dcb_info' are zero. It should be prevented when user run cmd "port config 0 dcb vt off 4 pfc off". This patch adds the check for support of reporting dcb info. Signed-off-by: Huisong Li Signe

[dpdk-dev] [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-20 Thread Huisong Li
Currently, 'nb_fwd_lcores' value are both adjusted based on 'nb_fwd_streams' in rss/simple/icmp_echo_fwd_config_setup. But the operation is missing in dcb_fwd_config_setup, which may lead to a bad behavior in which multiple polling threads operate on the same queue. In this case, the device sends a

[dpdk-dev] [PATCH V3 5/7] app/testpmd: move position of verifying DCB test

2021-04-20 Thread Huisong Li
Currently, the check for doing DCB test is assigned to start_packet_forwarding(), which will be called when run "start" cmd. But fwd_config_setup() is used in many scenarios, such as, "port config all rxq". This patch moves the check from start_packet_forwarding() to fwd_config_setup(). Fixes: 77

[dpdk-dev] [PATCH V3 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-20 Thread Huisong Li
After DCB mode is configured, the operations of port stop and port start change the value of the global variable "dcb_test", As a result, the forwarding configuration from DCB to RSS mode, namely, “dcb_fwd_config_setup()” to "rss_fwd_config_setup()". Currently, the 'dcb_flag' field in struct 'rte_

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id

2021-04-20 Thread Min Hu (Connor)
在 2021/4/20 8:57, Thomas Monjalon 写道: 08/04/2021 12:14, Min Hu (Connor): From: Chengwen Feng The ethtool use the socket_id which get from rte_eth_dev_socket_id API in the init stage, but use the rte_socket_id API to get socket_id when setting ringparam. This patch make sure it call rte_eth

Re: [dpdk-dev] [PATCH v6 05/10] app/testpmd: add clock_gettime_monotonic

2021-04-20 Thread Ananyev, Konstantin
> > Add clock_gettime_monotonic for testpmd on Windows > > Signed-off-by: Jie Zhou > Signed-off-by: Jie Zhou > --- > app/test-pmd/config.c | 33 - > 1 file changed, 32 insertions(+), 1 deletion(-) > > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.

Re: [dpdk-dev] [PATCH 2/2] examples/ethtool: add closing port operation

2021-04-20 Thread Min Hu (Connor)
在 2021/4/20 8:59, Thomas Monjalon 写道: 08/04/2021 12:14, Min Hu (Connor): From: Huisong Li Currently, ethtool directly ends the process after 'quit' cmd. In this case, software resources are not released and hardware resources of the device are not uninstalled. This patch adds closing port

Re: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error

2021-04-20 Thread Chen, LingliX
> -Original Message- > From: dev On Behalf Of Alvin Zhang > Sent: Tuesday, April 20, 2021 10:05 AM > To: Wang, Haiyue ; Guo, Jia > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/igc: fix Rx packet size error > > When DEV_RX_OFFLOAD_KEEP_CRC is en

Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381

2021-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 20, 2021 4:10 PM > To: Zhang, Qi Z ; Huang, Wei ; > dev@dpdk.org; Xu, Rosen > Cc: sta...@dpdk.org; Zhang, Tianfei > Subject: Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in > DPDK-26381 > > On 4/1/2021 1:1

Re: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381

2021-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Tuesday, April 20, 2021 5:13 PM > To: Yigit, Ferruh ; Huang, Wei > ; dev@dpdk.org; Xu, Rosen > Cc: sta...@dpdk.org; Zhang, Tianfei > Subject: RE: [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in > DPDK-26381 > > > > > -Ori

Re: [dpdk-dev] [PATCH v3 4/4] doc: update async vhost register/unregister

2021-04-20 Thread Maxime Coquelin
On 4/20/21 10:57 AM, Jiayu Hu wrote: > This patch is to update programmer guide for register/unregister > copy devices in vhost. > > Signed-off-by: Jiayu Hu > --- > doc/guides/prog_guide/vhost_lib.rst | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > > diff --git a/do

Re: [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm

2021-04-20 Thread Ajit Khaparde
On Mon, Apr 19, 2021 at 8:46 PM Kalesh A P wrote: > > From: Kalesh AP > > Driver cancels the health check alarm only if error recovery is enabled > in the FW. This can cause an issue. There is a small window where the > driver receives the async event from fw and port close is invoked > immediate

Re: [dpdk-dev] [PATCH 02/10] common/sfc_efx/base: delete redundant handling

2021-04-20 Thread Andrew Rybchenko
On 4/19/21 4:34 PM, Min Hu (Connor) wrote: > the default case in 'rhead_nic_get_bar_region' is unreachable. Why? May be it is true right now, but default case is required to handle future changes in enum and missing update here. > > This patch fixed that. > > Fixes: 3c1c5cc4a786 ("common/sfc_ef

Re: [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling

2021-04-20 Thread Andrew Rybchenko
On 4/19/21 4:34 PM, Min Hu (Connor) wrote: > 'bm_mc_init' only return 0, but the function whicl calls int > check the negative ret, and this is redundant. > > This patch fixed it by not checking the return value. > > Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") > Cc: sta...@dpdk

Re: [dpdk-dev] [PATCH 06/10] lib/librte_pipeline: fix the use of unsafe strcpy

2021-04-20 Thread Andrew Rybchenko
On 4/19/21 4:34 PM, Min Hu (Connor) wrote: > From: HongBo Zheng > > 'strcpy' is called in rte_swx_ctl_table_info_get, this function > is unsafe, use 'strncpy' instead. > > Fixes: 393b96e2aa2a ("pipeline: add SWX pipeline query API") > Cc: sta...@dpdk.org > > Signed-off-by: HongBo Zheng > Signe

Re: [dpdk-dev] [PATCH 1/2] examples/ethtool: fix Rx/Tx queue setup with rte socket id

2021-04-20 Thread Thomas Monjalon
20/04/2021 11:05, Min Hu (Connor): > 在 2021/4/20 8:57, Thomas Monjalon 写道: > > 08/04/2021 12:14, Min Hu (Connor): > >> From: Chengwen Feng > >> > >> The ethtool use the socket_id which get from rte_eth_dev_socket_id API > >> in the init stage, but use the rte_socket_id API to get socket_id when >

Re: [dpdk-dev] [PATCH 2/2] examples/ethtool: add closing port operation

2021-04-20 Thread Thomas Monjalon
20/04/2021 11:10, Min Hu (Connor): > > 在 2021/4/20 8:59, Thomas Monjalon 写道: > > 08/04/2021 12:14, Min Hu (Connor): > >> From: Huisong Li > >> > >> Currently, ethtool directly ends the process after 'quit' cmd. In this > >> case, software resources are not released and hardware resources of the >

Re: [dpdk-dev] [PATCH v3 3/4] vhost: fix unnecessary vring_state_changed call

2021-04-20 Thread Maxime Coquelin
On 4/20/21 10:57 AM, Jiayu Hu wrote: > When VHOST_USER_F_PROTOCOL_FEATURES is not negotiated, > there is no need for vhost_user_set_vring_kick() to > notify the application of vring enabled, as > vhost_user_msg_handler() also notifies the application. > > This patch is to remove unnecessary vri

Re: [dpdk-dev] [PATCH 1/3] examples/flow_classify: fix check of port and core

2021-04-20 Thread Thomas Monjalon
20/04/2021 04:26, Min Hu (Connor): > 2021/4/20 9:08, Thomas Monjalon: > > 27/03/2021 08:40, Min Hu (Connor): > >> fix check of port and core in flow_classify example. > >> > >> Fixes: bab16ddaf2c1 ("examples/flow_classify: add sample application") > >> Cc: sta...@dpdk.org > >> > >> Signed-off-by: M

Re: [dpdk-dev] [PATCH 02/10] common/sfc_efx/base: delete redundant handling

2021-04-20 Thread Min Hu (Connor)
在 2021/4/20 17:33, Andrew Rybchenko 写道: On 4/19/21 4:34 PM, Min Hu (Connor) wrote: the default case in 'rhead_nic_get_bar_region' is unreachable. Why? May be it is true right now, but default case is required to handle future changes in enum and missing update here. Well, agreed, this pat

[dpdk-dev] [PATCH v3] net/iavf: fix hash configuration on i40e VF

2021-04-20 Thread Alvin Zhang
In i40evf PMD, the VF directly accesses the hash enable registers to enable or disable hashing on ingress packets. When binding i40e VF to iavf, because the PF doesn't support VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF capability. Therefore, the VF hashing cannot be enabled. This patch adds support of hash co

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/e1000: fix filter control return value

2021-04-20 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, April 20, 2021 4:09 PM > To: Zhang, Qi Z ; Xiaozhen Ban > ; Guo, Jia ; Wang, Haiyue > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/e1000: fix filter control > return value > > On 3/25

Re: [dpdk-dev] [PATCH 03/10] bus/dpaa: fix management command init calling

2021-04-20 Thread Min Hu (Connor)
在 2021/4/20 17:35, Andrew Rybchenko 写道: On 4/19/21 4:34 PM, Min Hu (Connor) wrote: 'bm_mc_init' only return 0, but the function whicl calls int check the negative ret, and this is redundant. This patch fixed it by not checking the return value. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardw

Re: [dpdk-dev] [PATCH V3 1/2] mbuf: support eCPRI hardware packet type

2021-04-20 Thread Andrew Rybchenko
On 4/20/21 11:38 AM, Lingyu Liu wrote: > Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE. > > Signed-off-by: Lingyu Liu > Acked-by: Hemant Agrawal > --- > app/test-pmd/util.c | 25 - > lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ > lib/librte_mbuf/rte_m

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 1:48 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > 12/04/2021 01:23, Cristian Dumitrescu: > > Each table entry is

Re: [dpdk-dev] [PATCH v8] ethdev: add sanity checks in control APIs

2021-04-20 Thread Thomas Monjalon
Thanks for the work. Few last comments below. 17/04/2021 09:39, Min Hu (Connor): > @@ -293,6 +303,11 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, > const char *devargs_str) > uint16_t > rte_eth_iterator_next(struct rte_dev_iterator *iter) > { > + if (iter == NULL) { > +

Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type

2021-04-20 Thread Andrew Rybchenko
On 4/20/21 10:51 AM, Thomas Monjalon wrote: > 20/04/2021 04:17, Liu, Lingyu: >> Hi Olivier, >> >> This new packet type will be used by iavf driver to map ECPRI hardware >> packet. >> This is the patch which will use this new hardware packet type. >> http://patchwork.dpdk.org/project/dpdk/patch/202

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Thomas Monjalon
20/04/2021 12:04, Dumitrescu, Cristian: > From: Thomas Monjalon > > 12/04/2021 01:23, Cristian Dumitrescu: > > > Each table entry is made up of match fields and action data, with the > > > latter made up of the action ID and the action arguments. The approach > > > of having the user specify expli

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-04-20 Thread Thomas Monjalon
Ping 23/03/2021 17:02, Thomas Monjalon: > 09/03/2021 17:10, Savinay Dharmappa: > > tc ov watermark is initialized with computed value of > > max tc ov watermark. > > Sorry I don't understand what the change is doing. > Was there an issue? > > In the title, please avoid "tc ov" which is meaningle

Re: [dpdk-dev] [PATCH 1/2] net/af_xdp: fix trigger for syscall on tx

2021-04-20 Thread Ferruh Yigit
On 4/20/2021 9:44 AM, Ciara Loftus wrote: The send() syscall on the tx path is not concerned with busy polling and as such its invocation should not depend on whether or not it is configured. Fix this by distinguishing the conditions necessary for syscalls on the rx and tx paths individually. Fi

Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args

2021-04-20 Thread Dumitrescu, Cristian
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 11:07 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args > > 20/04/2021 12:04, Dumitrescu, Cristian: > > From: Thomas Monja

[dpdk-dev] [PATCH v2 00/16] Build file updates

2021-04-20 Thread Bruce Richardson
This set contains 5 changes/updates to the DPDK build and build files. The changes in this set are: 1. Use "continue" keyword, new in 0.49 to shorten and reduce indentation levels in the foreach loops when building library or driver components. 2. For libraries, drop support for header-only lib

[dpdk-dev] [PATCH v2 02/16] build: tidy up list of libraries to build

2021-04-20 Thread Bruce Richardson
With the lib/meson.build file changed from C-style indentation to python-style indentation, we need to correct the indentation of the lists of libraries, since these libs were not modified in the previous patches. For ease of management of the list and working with patches for adding to the list, p

[dpdk-dev] [PATCH v2 01/16] build: simplify library build file

2021-04-20 Thread Bruce Richardson
Two simplifications can be made to the build file which reduce indentation levels and make it easier to read: 1. When meson build support was first added, the compat library existed in DPDK as a single header file. Since that header has been merged into EAL, we no longer need to support header-onl

[dpdk-dev] [PATCH v2 03/16] build: simplify the driver build configuration file

2021-04-20 Thread Bruce Richardson
As with the library meson.build file, we can use the "continue" keyword to reduce the level of indentation used for the majority of the build file. Since we are changing the whitespace indentation level, we also update the body of the foreach loop to use the meson standard, 4-space indentation. Si

[dpdk-dev] [PATCH v2 04/16] build: clean up driver lists

2021-04-20 Thread Bruce Richardson
Ensure all lists of drivers are standardized: * one driver per line * lists double-indented with spaces (as they are line continuations) * elements in alphabetical order * opening and closing list brackets "[" & "]" on own lines * last element has trailing comma Any code snippets in the list files

[dpdk-dev] [PATCH v2 05/16] build: reduce indentation in app build spec

2021-04-20 Thread Bruce Richardson
As with the lib and drivers directories, we can use "continue" keyword to reduce the indentation level of the majority of the foreach block. At the same time, we can also replace tab indentation with spaces. Signed-off-by: Bruce Richardson --- app/meson.build | 101 --

[dpdk-dev] [PATCH v2 06/16] build: reduce indentation in examples build spec

2021-04-20 Thread Bruce Richardson
As with the lib and drivers directories, we can use "continue" keyword to reduce the indentation level of the majority of the foreach block. At the same time, we can also replace tab indentation with spaces. Signed-off-by: Bruce Richardson --- examples/meson.build | 177 -

[dpdk-dev] [PATCH v2 07/16] build: change infrastructure file tabs to spaces

2021-04-20 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation, for the basic infrastructure and tooling files, as well as doc and kernel directories. Signed-off-by: Bruce Richardson --- buildtools/chkincs/meson.build| 24 +- buildtools/meson.build| 34 +- buildtools/pkg-config

[dpdk-dev] [PATCH v2 08/16] lib: cleanup whitespace in meson build files

2021-04-20 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Perform other formating cleanups such as ensure that long lists of files are one per line, and terminating with a final comma before the closing brace to make addition/removals easier. In some cases, reorder lists of items where they w

[dpdk-dev] [PATCH v2 10/16] examples: change meson file tabs to spaces

2021-04-20 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Signed-off-by: Bruce Richardson --- examples/bbdev_app/meson.build| 2 +- examples/bond/meson.build | 2 +- examples/cmdline/meson.build | 4 ++- examples/distributor/meson.bui

[dpdk-dev] [PATCH v2 12/16] editorconfig: add entry for meson files

2021-04-20 Thread Bruce Richardson
Meson style guide recommends four-space indents, like for python, so add to editorconfig file. Signed-off-by: Bruce Richardson --- .editorconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/.editorconfig b/.editorconfig index d705825574..5101630c8c 100644 --- a/.editorconfig +++ b/.e

[dpdk-dev] [PATCH v2 11/16] app: change meson file tabs to spaces

2021-04-20 Thread Bruce Richardson
Switch from using tabs to 4 spaces for meson.build indentation. Signed-off-by: Bruce Richardson --- app/test-bbdev/meson.build | 16 +- app/test-compress-perf/meson.build | 14 +- app/test-crypto-perf/meson.build | 24 +- app/test-eventdev/meson.build | 28 +- app/test-flow-pe

[dpdk-dev] [PATCH v2 13/16] doc: add meson coding style section to contributors guide

2021-04-20 Thread Bruce Richardson
To help with consistency across all files, add a section to the contributors guide on meson coding style. Although short, this covers the basics for now, and can be extended in future as we see the need. Signed-off-by: Bruce Richardson --- doc/guides/contributing/coding_style.rst | 46 ++

[dpdk-dev] [PATCH v2 15/16] devtools: add script to ease backport of renamed files

2021-04-20 Thread Bruce Richardson
With all the library folders renamed to remove the "librte_" prefix, we need to fixup patches for easier backport, i.e. add back in the prefix for any references to those renamed files. In the script itself we use a general approach to allow other functions to be added in future for other modifica

[dpdk-dev] [PATCH v2 16/16] lib: allow disabling optional libraries

2021-04-20 Thread Bruce Richardson
Add support for the disable_libs option, to allow disabling the build of particular libraries. As part of this, maintain a list of what libraries can safely be disabled, without breaking the build - for now this list is solely those libraries which are not built on FreeBSD, kni, power and vhost. Th

Re: [dpdk-dev] [PATCH v5 00/14] Add ASO meter support in MLX5 PMD

2021-04-20 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 5:59 AM > To: Li Zhang ; Ferruh Yigit > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; dev@dpdk.org; Raslan Darawsheh > ; Asaf Penso ; Jiawei(Jonny) > Wang > Subject: Re: [dpdk-dev] [PATCH v5 00/14] Add AS

Re: [dpdk-dev] [PATCH 4/5] doc: update hns3 feature list

2021-04-20 Thread Ferruh Yigit
On 4/20/2021 9:59 AM, Min Hu (Connor) wrote: Hns3 PMD has supported SR-IOV in 19.11 version. This patch added feature description in hns3.ini. Can you please add the commit id of the patch that adds the actual support? It can be added as fixes tag. Signed-off-by: Min Hu (Connor) --- doc/g

Re: [dpdk-dev] [PATCH v5 11/14] net/mlx5: aso flow meter send WQE and CQE handle

2021-04-20 Thread Jiawei(Jonny) Wang
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 6:02 AM > To: Li Zhang ; Ferruh Yigit ; Asaf > Penso > Cc: Ori Kam ; Slava Ovsiienko ; > Matan Azrad ; dev@dpdk.org; Raslan Darawsheh > ; Jiawei(Jonny) Wang > Subject: Re: [dpdk-dev] [PATCH v5 11/14] net/ml

Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark.

2021-04-20 Thread Singh, Jasvinder
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 11:14 AM > To: Dharmappa, Savinay ; Singh, Jasvinder > ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] sched : Initialize tc ov watermark. > > Ping > > 23/03/20

[dpdk-dev] [PATCH v6 05/15] net/mlx5: use mask for meter register setting

2021-04-20 Thread Jiawei Wang
From: Shun Hao ASO (Advanced Steering Operation) meter feature may require to locate the flow context tag action after the ASO action. When color register is shared by meter_id/flow_id, it's like: Bits[0-7] A meter color value set by the HW. Bits[8-31] A flow id and meter id set by SW. Currently

[dpdk-dev] [PATCH v6 00/15] Add ASO meter support in MLX5 PMD

2021-04-20 Thread Jiawei Wang
To support more meters and better performance, MLX HW provides ASO (Advanced Steering Operation) flow meter. It can expose millions of ASO flow meter context's in HW. This ASO object can allocate the large bulk meter objects. This patch set implement the ASO flow meter for mlx5 driver. MLX5 PMD dri

[dpdk-dev] [PATCH v6 01/15] net/mlx5: support three level table walk

2021-04-20 Thread Jiawei Wang
From: Suanming Mou This commit adds table entry walk for the three level table. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_utils.h | 90 +++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/mlx5/mlx5_utils.h b/

[dpdk-dev] [PATCH v6 06/15] common/mlx5: add definitions for ASO flow meter

2021-04-20 Thread Jiawei Wang
From: Li Zhang This patch adds different PRM definitions, related to ASO (Advanced Steering Operation) flow meter feature, in MLX5 PMD code. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 75 +++--- 1 file changed, 71 ins

[dpdk-dev] [PATCH v6 02/15] common/mlx5: add color register idle bits definition

2021-04-20 Thread Jiawei Wang
From: Shun Hao 8 bits are used for meter color in meter register. When the meter register can be shared, the rest 24 bits can be used by others. This adds the definination for the 24 bits that can be shared. Signed-off-by: Shun Hao Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6

[dpdk-dev] [PATCH v6 07/15] common/mlx5: add read ASO flow meter HCA capability

2021-04-20 Thread Jiawei Wang
From: Li Zhang Read and store the device capability of FLOW_METER_ASO general object, using the DevX API. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 14 ++ drivers/common/mlx5/mlx5_devx_cmds.h | 8 2 files changed, 22 inserti

[dpdk-dev] [PATCH v6 08/15] common/mlx5: add DevX API to create ASO flow meter object

2021-04-20 Thread Jiawei Wang
From: Li Zhang Add DevX API to create ASO flow meter object. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 54 drivers/common/mlx5/mlx5_devx_cmds.h | 18 +++- drivers/common/mlx5/version.map | 1 + 3

[dpdk-dev] [PATCH v6 03/15] net/mlx5: fix meter statistics

2021-04-20 Thread Jiawei Wang
From: Shun Hao Currently, packets after meter will be steered to a global policer table, which includes green/red color rules for every meter, so as to have counter statistics of each color in every meter. There's a bug that all the rules in global policer table are matching only color criteria,

[dpdk-dev] [PATCH v6 09/15] net/mlx5: flow meter pool to manage meter object

2021-04-20 Thread Jiawei Wang
From: Li Zhang Add ASO flow meter pool to manage meter object Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.c| 2 +- drivers/net/mlx5/mlx5.h| 207 - drivers/net/mlx5/mlx5_flow.c | 70 -- drivers/net/mlx5/mlx5_flow.

[dpdk-dev] [PATCH v6 13/15] net/mlx5: make ASO meter queue thread-safe

2021-04-20 Thread Jiawei Wang
From: Li Zhang Synchronize ASO meter queue accesses from different threads using a spinlock. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_aso.c | 16 +--- 2 files changed, 14 insertions(+), 3 deletions(-) di

[dpdk-dev] [PATCH v6 14/15] net/mlx5: allow multiple flow tables on the same level

2021-04-20 Thread Jiawei Wang
From: Li Zhang The driver devices support creation of multiple flow tables. Jump action can be used in order to move the packet steering to different flow table. Table 0 is always the root table for packet steering. Jumping between tables may cause endless loops in steering mechanism, that's why

[dpdk-dev] [PATCH v6 11/15] net/mlx5: add meter ASO queue management

2021-04-20 Thread Jiawei Wang
From: Li Zhang This patch adds the ASO queue management for flow meter, includes send WQE and CQE handle functions. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5.h| 4 + drivers/net/mlx5/mlx5_flow_aso.c | 183 - dri

[dpdk-dev] [PATCH v6 10/15] net/mlx5: initialize the flow meter ASO SQ

2021-04-20 Thread Jiawei Wang
From: Li Zhang Initialize the flow meter ASO SQ WQEs with all the constant data that should not be updated per enqueue operation. Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 16 + drivers/net/mlx5/meson.build | 2 +- drivers/net/mlx5/mlx5.c

[dpdk-dev] [PATCH v6 12/15] net/mlx5: add support of ASO meter action

2021-04-20 Thread Jiawei Wang
From: Li Zhang When ASO action is available, use it as the meter action Signed-off-by: Shun Hao Signed-off-by: Li Zhang Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 4 +- drivers/net/mlx5/mlx5.c| 12 + drivers/net/mlx5/mlx5.h| 7 +-- drivers/ne

  1   2   3   >