Re: [dpdk-dev] [PATCH] doc: clarify implicit filtering in transfer rules

2021-09-02 Thread Andrew Rybchenko
Hi Ori, sorry, long answer below. Andrew. On 9/1/21 7:28 PM, Ori Kam wrote: > Hi Andrew, > > PSB > > Thanks, > Ori > >> -Original Message- >> From: dev On Behalf Of Andrew Rybchenko >> Sent: Wednesday, September 1, 2021 6:11 PM >> >> As per existing documentation, attribute "transfer

[dpdk-dev] [PATCH 2/2] event/cnxk: use common XAQ pool APIs

2021-09-02 Thread pbhagavatula
From: Pavan Nikhilesh Use the common APIs to create and fre XAQ pool. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 4 +- drivers/event/cnxk/cn9k_eventdev.c | 6 +- drivers/event/cnxk/cnxk_eventdev.c | 127 drivers/event/cnxk/cnxk_e

[dpdk-dev] [PATCH 1/2] common/cnxk: add SSO XAQ pool create and free

2021-09-02 Thread pbhagavatula
From: Pavan Nikhilesh Add common API to create and free SSO XAQ pool. Signed-off-by: Pavan Nikhilesh --- Depends-on: series-18612 ("net/cnxk: support for inline ipsec") drivers/common/cnxk/roc_sso.c | 122 + drivers/common/cnxk/roc_sso.h | 14 driv

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Jerin Jacob
On Wed, Sep 1, 2021 at 10:02 PM Bruce Richardson wrote: > > For each dmadev instance, perform some basic copy tests to validate that > functionality. > > Signed-off-by: Bruce Richardson > --- > app/test/test_dmadev.c | 174 + > 1 file changed, 174 insertio

[dpdk-dev] [PATCH] net/ice: add 1PPS support for E810

2021-09-02 Thread Simei Su
The E810 supports four single-ended GPIO signals (SDP[20:23]). The 1PPS signal outputs via SDP[20:23], which is measured by an oscilloscope. This feature can be turned by a devargs which can select GPIO pin index flexibly. Pin index 0 means SDP20, pin index 1 means SDP21 and so on. The example for

[dpdk-dev] [PATCH] common/cnxk: add telemetry endpoints to sso

2021-09-02 Thread pbhagavatula
From: Pavan Nikhilesh Add telemetry endpoints for sso Signed-off-by: Pavan Nikhilesh --- Depends-on: series-18491 ("cnxk: enable npa and mempool telemetry") drivers/common/cnxk/cnxk_telemetry_sso.c | 50 drivers/common/cnxk/meson.build | 3 +- drivers/commo

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 01:14:38PM +0530, Jerin Jacob wrote: > On Wed, Sep 1, 2021 at 10:02 PM Bruce Richardson > wrote: > > > > For each dmadev instance, perform some basic copy tests to validate that > > functionality. > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/test_dmadev.c

Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

2021-09-02 Thread Bruce Richardson
On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > This fixes most of the warnings from the Flake8 style checker. > The ones remaing are long lines (we allow > 79 characters) > and a line break warning. The line break style changed in later > versions of PEP 8 and the tool is not

[dpdk-dev] [PATCH] ethdev: promote set ptypes API to stable

2021-09-02 Thread pbhagavatula
From: Pavan Nikhilesh Remove experimental tag from rte_eth_dev_set_ptypes(). Signed-off-by: Pavan Nikhilesh --- lib/ethdev/rte_ethdev.h | 4 lib/ethdev/version.map | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h inde

[dpdk-dev] [PATCH] app/testpmd: fix random number of Tx segments

2021-09-02 Thread Alvin Zhang
When random number of segments in Tx packets is enabled, the total data space length of all segments must be greater or equal than the size of an Eth/IP/UDP/timestamp packet, that's total 14 + 20 + 8 + 16 bytes. Otherwise the Tx engine may cause the application to crash. Bugzilla ID: 797 Fixes: 79

Re: [dpdk-dev] [PATCH] ethdev: promote set ptypes API to stable

2021-09-02 Thread Andrew Rybchenko
On 9/2/21 11:17 AM, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Remove experimental tag from rte_eth_dev_set_ptypes(). > > Signed-off-by: Pavan Nikhilesh Acked-by: Andrew Rybchenko

Re: [dpdk-dev] [PATCH v2 0/8] add lookaside IPsec additional features

2021-09-02 Thread Akhil Goyal
> This series adds cn10k lookaside IPsec AES-CBC-HMAC-SHA1, UDP > encapsulation > and transport mode support along with common cnxk pmd changes. > The functionality has been tested with ipsec-secgw application running in > lookaside protocol offload mode. > > v2: > * Fixed release notes > > Archa

[dpdk-dev] [PATCH] net/ice: fix representor port segmentation fault

2021-09-02 Thread dapengx . yu
From: Dapeng Yu If DCF representor port is closed after DCF port is closed, there will be segmentation fault because representor accesses the released resource of DCF port. This patch makes DCF representor port is always closed before DCF port is closed. Fixes: 5674465a32c8 ("net/ice: add DCF V

Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping

2021-09-02 Thread Ferruh Yigit
On 9/1/2021 2:25 PM, Burakov, Anatoly wrote: > On 01-Sep-21 12:42 PM, Ferruh Yigit wrote: >> On 9/1/2021 12:01 PM, Burakov, Anatoly wrote: >>> On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: On 9/1/2021 2:41 AM, Ding, Xuan wrote: > Hi Ferruh, > >> -Original Message- >> From:

Re: [dpdk-dev] 19.11.10 patches review and test

2021-09-02 Thread Pei Zhang
Hello Christian, The testing with dpdk 19.11.10-rc1 from Red Hat looks good. We tested below 16 scenarios and all got PASS on RHEL8: (1)Guest with device assignment(PF) throughput testing(1G hugepage size): PASS (2)Guest with device assignment(PF) throughput testing(2M hugepage size) : PASS (3)Gu

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-02 Thread Ferruh Yigit
On 9/1/2021 10:14 AM, Bruce Richardson wrote: > On Wed, Sep 01, 2021 at 11:48:21AM +0530, Aman Singh wrote: >> From the logs it is difficult to get the DPDK version >> that was used. So added a debug log to print the same. >> The log has been added in eal_init so it gets printed >> at startup for a

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-02 Thread Ferruh Yigit
On 9/1/2021 6:12 PM, Stephen Hemminger wrote: > On Wed, 1 Sep 2021 11:48:21 +0530 > Aman Singh wrote: > >> From the logs it is difficult to get the DPDK version >> that was used. So added a debug log to print the same. >> The log has been added in eal_init so it gets printed >> at startup for an

Re: [dpdk-dev] [EXT] [PATCH] crypto/mlx5: support timestamp format

2021-09-02 Thread Akhil Goyal
> This patch adds support for the timestamp format settings for > the receive and send queues. If the firmware version x.30.1000 > or above is installed and the NIC timestamps are configured > with the real-time format, the default zero values for newly > added fields cause the queue creation to fa

Re: [dpdk-dev] [PATCH] compress/mlx5: fix QP setup error flow

2021-09-02 Thread Akhil Goyal
> > The QP setup function allocates buffer for its opaque MR and register it > into > > MR structure. > > > > After buffer alloction and before MR registration, it tries allocate MR > > Btree. > > When the MR Btree allocation fails, the buffer was not freed what caused a > > memory leak. > > > > A

Re: [dpdk-dev] [PATCH] eal: add log to print dpdk version at start

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 11:11:39AM +0100, Ferruh Yigit wrote: > On 9/1/2021 6:12 PM, Stephen Hemminger wrote: > > On Wed, 1 Sep 2021 11:48:21 +0530 > > Aman Singh wrote: > > > >> From the logs it is difficult to get the DPDK version > >> that was used. So added a debug log to print the same. > >

Re: [dpdk-dev] [PATCH v2 2/6] app/test: add basic dmadev instance tests

2021-09-02 Thread Bruce Richardson
On Wed, Sep 01, 2021 at 09:24:12PM +0200, Mattias Rönnblom wrote: > On 2021-09-01 18:32, Bruce Richardson wrote: > > Run basic sanity tests for configuring, starting and stopping a dmadev > > instance to help validate drivers. This also provides the framework for > > future tests for data-path oper

Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style

2021-09-02 Thread Burakov, Anatoly
On 01-Sep-21 10:27 PM, Stephen Hemminger wrote: This fixes most of the warnings from the Flake8 style checker. The ones remaing are long lines (we allow > 79 characters) and a line break warning. The line break style changed in later versions of PEP 8 and the tool is not updated. https://www.fl

Re: [dpdk-dev] [PATCH] net/af_packet: try to reinsert the stripped vlan tag

2021-09-02 Thread Ferruh Yigit
On 9/1/2021 10:34 PM, Stephen Hemminger wrote: > On Wed, 1 Sep 2021 22:07:22 +0300 > Tudor Cornea wrote: > >> Indeed, the vlan insertion could be a costly operation. We should probably >> do it only if the user specifically asks to have the vlan tag in the packet. >> Otherwise, af_packet PMD user

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Jerin Jacob
On Thu, Sep 2, 2021 at 1:36 PM Bruce Richardson wrote: > > On Thu, Sep 02, 2021 at 01:14:38PM +0530, Jerin Jacob wrote: > > On Wed, Sep 1, 2021 at 10:02 PM Bruce Richardson > > wrote: > > > > > > For each dmadev instance, perform some basic copy tests to validate that > > > functionality. > > > >

[dpdk-dev] [PATCH v18 0/8] support dmadev

2021-09-02 Thread Chengwen Feng
This patch set contains eight patch for new add dmadev. Chengwen Feng (8): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DM

[dpdk-dev] [PATCH v18 3/8] dmadev: introduce DMA device library PMD header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v18 2/8] dmadev: introduce DMA device library internal header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v18 6/8] dma/skeleton: introduce skeleton dmadev driver

2021-09-02 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng --- drivers/dma/

[dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-02 Thread Chengwen Feng
This patch add myself as dmadev's maintainer and update release notes. Signed-off-by: Chengwen Feng --- MAINTAINERS| 7 +++ doc/guides/rel_notes/release_21_11.rst | 5 + 2 files changed, 12 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7be9658..1

[dpdk-dev] [PATCH v18 4/8] dmadev: introduce DMA device library implementation

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v18 1/8] dmadev: introduce DMA device library public APIs

2021-09-02 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Jerin Jacob -

[dpdk-dev] [PATCH v18 5/8] doc: add DMA device library guide

2021-09-02 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng Acked-by: Conor Walsh --- doc/guides/prog_guide/dmadev.rst | 125 doc/guides/prog_guide/img/dmadev.svg | 283 +++ doc/guides/prog_guide/index.rst | 1 + 3 files changed

[dpdk-dev] [PATCH v18 7/8] app/test: add dmadev API test

2021-09-02 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson --- app/test/meson.build | 4 + app/test/test_dmadev.c | 45 app/

Re: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5

2021-09-02 Thread Ferruh Yigit
On 9/2/2021 10:58 AM, Shahaf Shuler wrote: > Monday, August 23, 2021 5:51 PM, Viacheslav Ovsiienko: >> Subject: [dpdk-dev] [PATCH v2] maintainers: update for net mlx4/mlx5 >> >> For net/mlx4: >> - removing Shahaf Shuler >> - adding Viacheslav Ovsiienko >> >> For net/mlx5: >> - removing

Re: [dpdk-dev] [PATCH] crypto/octeontx2: fix unaligned access to device memory

2021-09-02 Thread Akhil Goyal
> Use otx2_mbox_memcpy() instead of memcpy() to prevent unaligned access. > > Fixes: a0645ed0d6ef ("crypto/octeontx2: discover capabilities") > Cc: ktejas...@marvell.com Cc: sta...@dpdk.org > > Signed-off-by: Danny Patel > Signed-off-by: Anoob Joseph > --- Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [EXT] [PATCH 2/5] security: add pdcp short MAC-I support

2021-09-02 Thread Akhil Goyal
> From: Hemant Agrawal > Title should be "security: support PDCP short MAC-I" > This patch add support to handle PDCP short MAC-I domain > along with standard control and data domains as it has to > be treaty as special case with PDCP protocol offload support. Spell check treated. > > ShortMA

Re: [dpdk-dev] [EXT] [PATCH 1/5] common/dpaax: fix IV value for shortMAC-I for SNOW algo

2021-09-02 Thread Akhil Goyal
> The logic was incorecly doing conditional swap. It need to > be bit swap always. Spell check " incorrectly" > > Fixes: 73a24060cd70 ("crypto/dpaa2_sec: add sample PDCP descriptor APIs") > Cc: sta...@dpdk.org > > Signed-off-by: Gagandeep Singh > --- Move this patch as 3rd patch of your series.

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 04:24:18PM +0530, Jerin Jacob wrote: > > I think 25us will not be enough, e.s.p If is PCI-Dev to PCI-Dev kind > of test cases. > Since it is the functional test case, I think, we can keep it a very > higher range to > support all cases. Maybe 50ms is a good target. > Sure

Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 06:54:17PM +0800, Chengwen Feng wrote: > This patch add myself as dmadev's maintainer and update release notes. > > Signed-off-by: Chengwen Feng --- Just in case you are doing any further revisions of this patchset, the maintainers entry, and RN entry, generally is added

[dpdk-dev] [PATCH] test/crypto: refactor scheduler test worker PMDs

2021-09-02 Thread Rebecca Troy
Previously, the scheduler unit test only created and attached 1 or 2 AESNI-MB cryptodev PMDs as workers if less than 2 AESNI-MB PMDs had already been initialized. This commit changes this to always create and attach 2 new AESNI-MB cryptodev PMDs, regardless of previously initialized AESNI-MB PMDs.

[dpdk-dev] [PATCH v2 0/8] Crypto adapter support for Marvell CNXK driver

2021-09-02 Thread Shijith Thotton
First three patches are to support crypto adapter implementation and the remaining patches add event crypto adapter OP_FORWARD mode support on Marvell CN9K and CN10K SOC. v2: * Fixed checkpatch errors. Shijith Thotton (8): net/cnxk: add flag to show CPT can enqueue events event/cnxk: add macr

[dpdk-dev] [PATCH v2 1/8] net/cnxk: add flag to show CPT can enqueue events

2021-09-02 Thread Shijith Thotton
CPT can be told to submit events to SSO upon completion. Crypto adapter uses this feature and the new flag can be used to optimize receive path in those cases. Signed-off-by: Shijith Thotton --- drivers/net/cnxk/cn10k_rx.h | 5 +++-- drivers/net/cnxk/cn9k_rx.h | 3 ++- 2 files changed, 5 insert

[dpdk-dev] [PATCH v2 2/8] event/cnxk: add macro to set eventdev ops

2021-09-02 Thread Shijith Thotton
Added a common macro to set eventdev enqueue and dequeue operations to reduce code. Signed-off-by: Shijith Thotton Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 139 +- drivers/event/cnxk/cn9k_eventdev.c | 273 +++- 2 files chang

[dpdk-dev] [PATCH v2 3/8] common/cnxk: add API to check CPT IQ is full

2021-09-02 Thread Shijith Thotton
Added flow control based check to determine CPT IQ is full. Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_cpt.c | 6 -- drivers/common/cnxk/roc_cpt.h | 11 +++ drivers/common/cnxk/roc_cpt_priv.h | 6 -- 3 files changed, 15 insertions(+), 8 deletions(-) d

[dpdk-dev] [PATCH v2 4/8] drivers: add cnxk crypto adapter eventdev ops

2021-09-02 Thread Shijith Thotton
Added eventdev ops required to initialize crypto adapter. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 9 +++ drivers/event/cnxk/cn10k_eventdev.c | 46 drivers/event/cnxk/cn9k_eventdev.c | 45 drivers/event/cnxk/cnxk_eventdev

[dpdk-dev] [PATCH v2 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 --- drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + drivers/crypto/cnxk/cnxk_cryp

[dpdk-dev] [PATCH v2 6/8] event/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn9k_eventdev.c | 94 +++- drivers/event/cnxk/cn9k_worker.c | 22 + drivers/event/cnxk/cn9k_worker.h | 41 - drivers/eve

[dpdk-dev] [PATCH v2 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 +++ drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ drivers/crypto/cnxk/version

[dpdk-dev] [PATCH v2 8/8] event/cnxk: add cn10k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/release_21_11.rst | 3 ++ drivers/event/cnxk/cn10k_eventdev.c | 45 +++- drivers/event/cnxk/cn10k_worker.c| 11 drivers/event/cnxk/cn10k_worker.h

[dpdk-dev] [PATCH 0/7] Improvements and fixes in crypto/cnxk PMDs

2021-09-02 Thread Anoob Joseph
Improvements and fixes to crypto_cn9k & crypto_cn10k PMDs. - Updated IPsec completion codes to match latest firmware - Updated ZUC API to match latest firmware - Added dual submission in crypto_cn9k PMD Depends on: http://patches.dpdk.org/project/dpdk/list/?series=18627 Anoob Joseph (5): common

[dpdk-dev] [PATCH 1/7] common/cnxk: update to v1.13 ZUC API

2021-09-02 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for ZUC API change in ucode 1.13 Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_se.c| 150 drivers/common/cnxk/roc_se.h| 37 +- drivers/common/cnxk/ver

[dpdk-dev] [PATCH 2/7] common/cnxk: update to v1.16 ucc codes

2021-09-02 Thread Anoob Joseph
Update to v1.16 microcode completion codes. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_ie_ot.h | 65 + 1 file changed, 34 insertions(+), 31 deletions(-) diff --git a/drivers/common/cnxk/roc_ie_ot.h b/drivers/common/cnxk/roc_ie_ot.h index 3987

[dpdk-dev] [PATCH 3/7] crypto/cnxk: remove redundant snow3g dec

2021-09-02 Thread Anoob Joseph
The opcode for encryption & decryption is the same and single routine would be able to handle both encryption and decryption operations. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 232 -- 1 file changed, 17 insertions(+), 215 deletions

[dpdk-dev] [PATCH 4/7] crypto/cnxk: remove redundant memcpy of IV for ZUC

2021-09-02 Thread Anoob Joseph
Swap is not required for ZUC. Update IV updation sequence to remove the redundant swap in case of ZUC. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 55 +++ 1 file changed, 30 insertions(+), 25 deletions(-) diff --git a/drivers/crypto/cn

[dpdk-dev] [PATCH 5/7] crypto/cnxk: remove redundant assignment

2021-09-02 Thread Anoob Joseph
The assignment to -1 is not required. Remove the same. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_cryptodev_ops.c b/d

[dpdk-dev] [PATCH 6/7] crypto/cnxk: support for ucode API change

2021-09-02 Thread Anoob Joseph
From: Vidya Sagar Velumuri Add support for API changes in ucode 1.13 Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cnxk_se.h | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/cnxk/cnxk_se.h b/drivers/crypto/cnxk/cnxk_se.h index bbad289

[dpdk-dev] [PATCH 7/7] crypto/cnxk: add dual submission in crypto_cn9k

2021-09-02 Thread Anoob Joseph
Submit two instructions with one LMTST operation. Also updated dequeue path to have local var for constants. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 155 +-- 1 file changed, 127 insertions(+), 28 deletions(-) diff --git a/drivers/cr

Re: [dpdk-dev] [EXT] [PATCH v2 01/11] crypto/dpaa2_sec: fix to check next null for auth only case

2021-09-02 Thread Akhil Goyal
> This patch fixes the issue to check for next pointer as > null in the integrity only case in pdcp-security context. > > Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") > Cc: sta...@dpdk.org This patch is not a fix and need not be backported, because integrity only case is not a v

Re: [dpdk-dev] [PATCH v2 1/6] dmadev: add device idle check for testing use

2021-09-02 Thread fengchengwen
When some hardware is faulty, the error code cannot be set, and it just stops working. In addition, interrupts are generally not enabled. Therefore, for such hardware, the framework needs to have a mechanism to transmit the status so that applications can sense the status. So how about extend v

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Jerin Jacob
On Thu, Sep 2, 2021 at 5:13 PM Bruce Richardson wrote: > > On Thu, Sep 02, 2021 at 04:24:18PM +0530, Jerin Jacob wrote: > > > > I think 25us will not be enough, e.s.p If is PCI-Dev to PCI-Dev kind > > of test cases. > > Since it is the functional test case, I think, we can keep it a very > > highe

Re: [dpdk-dev] [RFC PATCH v2 0/7] heterogeneous computing library

2021-09-02 Thread Jerin Jacob
On Wed, Sep 1, 2021 at 9:05 PM Elena Agostini wrote: > > > > -Original Message- > > From: Wang, Haiyue > > Sent: Sunday, August 29, 2021 7:33 AM > > To: Jerin Jacob ; NBU-Contact-Thomas Monjalon > > > > Cc: Jerin Jacob ; dpdk-dev ; Stephen > > Hemminger ; David Marchand > > ; Andrew Rybc

Re: [dpdk-dev] [PATCH] doc: clarify implicit filtering in transfer rules

2021-09-02 Thread Ori Kam
Hi, Thanks you for your answer it looks to me we are on the same page but I'm not sure, also I think the result of this discusstion should be part of the commit log and documentation. Since I think this issue is not clear to many people. PSB some questions. (sorry for the long mail but I want t

[dpdk-dev] [PATCH v19 0/7] support dmadev

2021-09-02 Thread Chengwen Feng
This patch set contains seven patch for new add dmadev. Chengwen Feng (7): dmadev: introduce DMA device library public APIs dmadev: introduce DMA device library internal header dmadev: introduce DMA device library PMD header dmadev: introduce DMA device library implementation doc: add DM

[dpdk-dev] [PATCH v19 3/7] dmadev: introduce DMA device library PMD header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library PMD header which was driver facing APIs for a DMA device. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmadev.h | 2 ++ lib/dmadev/rte_dmadev_pmd.h | 72 ++

[dpdk-dev] [PATCH v19 2/7] dmadev: introduce DMA device library internal header

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library internal header, which contains internal data types that are used by the DMA devices in order to expose their ops to the class. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- lib/dmadev/meson.build | 1 + lib/

[dpdk-dev] [PATCH v19 4/7] dmadev: introduce DMA device library implementation

2021-09-02 Thread Chengwen Feng
This patch introduce DMA device library implementation which includes configuration and I/O with the DMA devices. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardson Acked-by: Morten Brørup --- config/rte_config.h | 3 + lib/dmadev/meson.build | 1 + lib/dmadev/rte_dmade

[dpdk-dev] [PATCH v19 1/7] dmadev: introduce DMA device library public APIs

2021-09-02 Thread Chengwen Feng
The 'dmadevice' is a generic type of DMA device. This patch introduce the 'dmadevice' public APIs which expose generic operations that can enable configuration and I/O with the DMA devices. Maintainers update is also included in this patch. Signed-off-by: Chengwen Feng Acked-by: Bruce Richardso

[dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread Chengwen Feng
This patch add dmadev API test which based on 'dma_skeleton' vdev. The test cases could be executed using 'dmadev_autotest' command in test framework. Signed-off-by: Chengwen Feng Signed-off-by: Bruce Richardson --- MAINTAINERS| 1 + app/test/meson.build | 4 + app/tes

[dpdk-dev] [PATCH v19 5/7] doc: add DMA device library guide

2021-09-02 Thread Chengwen Feng
This patch adds dmadev library guide. Signed-off-by: Chengwen Feng Acked-by: Conor Walsh --- MAINTAINERS | 1 + doc/guides/prog_guide/dmadev.rst | 125 doc/guides/prog_guide/img/dmadev.svg | 283 +++ doc/guides/prog

[dpdk-dev] [PATCH v19 6/7] dma/skeleton: introduce skeleton dmadev driver

2021-09-02 Thread Chengwen Feng
Skeleton dmadevice driver, on the lines of rawdev skeleton, is for showcasing of the dmadev library. Design of skeleton involves a virtual device which is plugged into VDEV bus on initialization. Also, enable compilation of dmadev skeleton drivers. Signed-off-by: Chengwen Feng --- MAINTAINERS

Re: [dpdk-dev] [PATCH v18 8/8] maintainers: add for dmadev

2021-09-02 Thread fengchengwen
Fix in v19 I think there many patches wait for dmadev framework upstream, so could you help review unreviewd patches (like dma/skeleton and app/test)? Also, we have developed the dma driver for hisilicon, and corresponding test app (like examples/vhost and testpmd) is being developed. examples/v

[dpdk-dev] [PATCH 0/8] add cn9k lookaside IPsec support

2021-09-02 Thread Archana Muniganti
This series adds lookaside IPsec support in crypto_cn9k PMD. Depends on: http://patches.dpdk.org/project/dpdk/list/?series=18628 Archana Muniganti (8): crypto/cnxk: add cn9k security ctx common/cnxk: add cn9k IPsec microcode defines crypto/cnxk: add cn9k IPsec session related functions cr

[dpdk-dev] [PATCH 1/8] crypto/cnxk: add cn9k security ctx

2021-09-02 Thread Archana Muniganti
Add security ctx in cn9k crypto PMD. Signed-off-by: Archana Muniganti Signed-off-by: Vamsi Attunuru Signed-off-by: Tejasree Kondoj --- drivers/crypto/cnxk/cn9k_cryptodev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/crypto/cnxk/cn9k_cryptodev.c b/drivers/crypto/cnxk/c

[dpdk-dev] [PATCH 2/8] common/cnxk: add cn9k IPsec microcode defines

2021-09-02 Thread Archana Muniganti
Microcode IE opcodes support IPsec operations. Add defines and structs defined by microcode. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/common/cnxk/roc_cpt.h | 1 + drivers/common/cnxk/roc_ie_on.h

[dpdk-dev] [PATCH 3/8] crypto/cnxk: add cn9k IPsec session related functions

2021-09-02 Thread Archana Muniganti
Add helper functions useful in implementing IPsec outbound and inbound session create apis. Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev.c | 2 + drivers/crypto/cnxk/cn9k_ipsec.c | 425 +++

[dpdk-dev] [PATCH 4/8] crypto/cnxk: add cn9k IPsec outbound session create function

2021-09-02 Thread Archana Muniganti
Adding logic for IPsec outbound session creation. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_ipsec.c | 143 +-- drivers/crypto/cnxk/cn9k_ipsec.h | 17

[dpdk-dev] [PATCH 5/8] crypto/cnxk: add cn9k IPsec inbound session create function

2021-09-02 Thread Archana Muniganti
Adding logic for IPsec inbound session creation. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_ipsec.c | 64 +--- 1 file changed, 59 insertions(+), 5 deletions

[dpdk-dev] [PATCH 6/8] crypto/cnxk: add cn9k lookaside IPsec datapath

2021-09-02 Thread Archana Muniganti
Adds support for cn9k lookaside enqueue and dequeue operations. Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 78 +++- drivers/crypto/cnxk/cn9k_ipsec_la_ops.h | 90 ++

[dpdk-dev] [PATCH 7/8] crypto/cnxk: update tailroom requirement

2021-09-02 Thread Archana Muniganti
Update min tailroom to reflect IPsec additions. PMD crypto_cn9k & crypto_cn10k would have packet grow into tailroom post IPsec processing. Signed-off-by: Archana Muniganti --- drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 2 +- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 1 + 2 files changed, 2 inse

[dpdk-dev] [PATCH 8/8] crypto/cnxk: update feature flag for cn9k lookaside IPsec

2021-09-02 Thread Archana Muniganti
Update device feature flag to support lookaside IPsec for cn9k. Signed-off-by: Ankur Dwivedi Signed-off-by: Archana Muniganti Signed-off-by: Tejasree Kondoj Signed-off-by: Vamsi Attunuru --- doc/guides/cryptodevs/cnxk.rst | 14 -- doc/guides/cryptodevs/features/cn9k.ini |

Re: [dpdk-dev] [EXT] [PATCH v2 05/11] crypto/dpaa_sec: add support for AES CMAC integrity check

2021-09-02 Thread Akhil Goyal
> From: Gagandeep Singh > > This patch adds support for AES_CMAC integrity in non-security mode. > This patch modifies the camm flib to handles the AES CMAC > without conflicting the proto ALG operations. i.e. by creating > another ALG operation routine. Description do not match with the patch.

Re: [dpdk-dev] [EXT] [PATCH v2 01/11] crypto/dpaa2_sec: fix to check next null for auth only case

2021-09-02 Thread Hemant Agrawal
On 9/2/2021 6:16 PM, Akhil Goyal wrote: This patch fixes the issue to check for next pointer as null in the integrity only case in pdcp-security context. Fixes: bef594ec5cc8 ("crypto/dpaa2_sec: support PDCP offload") Cc: sta...@dpdk.org This patch is not a fix and need not be backported, beca

Re: [dpdk-dev] [PATCH v19 7/7] app/test: add dmadev API test

2021-09-02 Thread Walsh, Conor
Hi Chengwen, The output from the API tests is not very straightforward to interpret if you are not familiar with these tests. Could we change the log level of the dmadev library before and after the API tests using something similar to The code I have included inline below? > +static int > +te

Re: [dpdk-dev] [PATCH v2 1/6] dmadev: add device idle check for testing use

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 08:54:11PM +0800, fengchengwen wrote: > When some hardware is faulty, the error code cannot be set, and it just stops > working. > In addition, interrupts are generally not enabled. Therefore, for such > hardware, the > framework needs to have a mechanism to transmit the s

Re: [dpdk-dev] [PATCH v2 3/6] app/test: add basic dmadev copy tests

2021-09-02 Thread Bruce Richardson
On Thu, Sep 02, 2021 at 06:35:07PM +0530, Jerin Jacob wrote: > On Thu, Sep 2, 2021 at 5:13 PM Bruce Richardson > wrote: > > > > On Thu, Sep 02, 2021 at 04:24:18PM +0530, Jerin Jacob wrote: > > > > > > I think 25us will not be enough, e.s.p If is PCI-Dev to PCI-Dev kind > > > of test cases. > > > S

[dpdk-dev] [PATCH 0/5] A means to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Back in 2019, commit c5b2e78d1172 ("doc: announce ethdev API changes in offload flags") announced changes in DEV_RX_OFFLOAD namespace intending to add new flags, RSS_HASH and FLOW_MARK. Since then, only the former has been added. Currently, there's no way for the application to configure the eth

[dpdk-dev] [PATCH 1/5] ethdev: add API to negotiate support for Rx meta information

2021-09-02 Thread Ivan Malov
Per-packet meta information (flag, mark and the likes) might be expensive to deliver in terms of small packet performance. If the features are not enabled by default, enabling them at short notice (for example, when a flow rule with action MARK gets created) without traffic disruption may not be po

[dpdk-dev] [PATCH 2/5] net/sfc: provide API to negotiate supported Rx meta features

2021-09-02 Thread Ivan Malov
This is a preparation step. Later patches will make features FLAG and MARK on EF100 native Rx datapath available to users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc.h| 2 ++ drivers/net/sfc/sfc_ethdev.c | 34 ++ driv

[dpdk-dev] [PATCH 3/5] net/sfc: allow to use EF100 native datapath Rx mark in flows

2021-09-02 Thread Ivan Malov
As of now, reading out mark on EF100 native datapath is used only by MAE counter support for delivery of generation count values. Make the feature available to flow action MARK users. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 1 + drivers/net/s

[dpdk-dev] [PATCH 4/5] common/sfc_efx/base: add RxQ flag to use Rx prefix user flag

2021-09-02 Thread Ivan Malov
Add an RxQ flag to request support for user flag field of Rx prefix. The feature is supported only on EF100 and EF10 ESSB. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/common/sfc_efx/base/ef10_rx.c | 54 -- drivers/common/sfc_efx/base/efx.h |

[dpdk-dev] [PATCH 5/5] net/sfc: allow to discern user flag on EF100 native datapath

2021-09-02 Thread Ivan Malov
Read out user flag from Rx prefix and indicate it to callers. Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ef100_rx.c | 18 ++ drivers/net/sfc/sfc_rx.c | 3 +++ 2 files changed, 21 insertions(+) diff --git a/drivers/net/sfc/sfc_ef100_rx

[dpdk-dev] [PATCH] net/virtio: fix device configure without jumbo Rx offload

2021-09-02 Thread Andrew Rybchenko
From: Ivan Ilchenko Use max-pkt-len only if jumbo frames offload is requested since otherwise this field isn't valid. Fixes: 8b90e4358112 ("net/virtio: set offload flag for jumbo frames") Fixes: 4e8169eb0d2d ("net/virtio: fix Rx scatter offload") Cc: sta...@dpdk.org Signed-off-by: Ivan Ilchenko

[dpdk-dev] [PATCH v3 0/8] Crypto adapter support for Marvell CNXK driver

2021-09-02 Thread Shijith Thotton
First three patches are to support crypto adapter implementation and the remaining patches add event crypto adapter OP_FORWARD mode support on Marvell CN9K and CN10K SOC. v3: * Fixed checkpatch errors. v2: * Fixed checkpatch errors. Shijith Thotton (8): net/cnxk: add flag to show CPT can enque

[dpdk-dev] [PATCH v3 1/8] net/cnxk: add flag to show CPT can enqueue events

2021-09-02 Thread Shijith Thotton
CPT can be told to submit events to SSO upon completion. Crypto adapter uses this feature and the new flag can be used to optimize receive path in those cases. Signed-off-by: Shijith Thotton --- drivers/net/cnxk/cn10k_rx.h | 5 +++-- drivers/net/cnxk/cn9k_rx.h | 3 ++- 2 files changed, 5 insert

[dpdk-dev] [PATCH v3 2/8] event/cnxk: add macro to set eventdev ops

2021-09-02 Thread Shijith Thotton
Added a common macro to set eventdev enqueue and dequeue operations to reduce code. Signed-off-by: Shijith Thotton Signed-off-by: Nithin Dabilpuram --- drivers/event/cnxk/cn10k_eventdev.c | 134 +- drivers/event/cnxk/cn9k_eventdev.c | 268 +++- 2 files chang

[dpdk-dev] [PATCH v3 3/8] common/cnxk: add API to check CPT IQ is full

2021-09-02 Thread Shijith Thotton
Added flow control based check to determine CPT IQ is full. Signed-off-by: Shijith Thotton --- drivers/common/cnxk/roc_cpt.c | 6 -- drivers/common/cnxk/roc_cpt.h | 11 +++ drivers/common/cnxk/roc_cpt_priv.h | 6 -- 3 files changed, 15 insertions(+), 8 deletions(-) d

[dpdk-dev] [PATCH v3 4/8] drivers: add cnxk crypto adapter eventdev ops

2021-09-02 Thread Shijith Thotton
Added eventdev ops required to initialize crypto adapter. Signed-off-by: Shijith Thotton --- drivers/crypto/cnxk/cnxk_cryptodev_ops.h | 9 +++ drivers/event/cnxk/cn10k_eventdev.c | 46 drivers/event/cnxk/cn9k_eventdev.c | 45 drivers/event/cnxk/cnxk_eventdev

[dpdk-dev] [PATCH v3 5/8] crypto/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn9k_cryptodev_ops.c | 235 --- drivers/crypto/cnxk/cn9k_cryptodev_ops.h | 6 + drivers/crypto/cnxk/cnxk_cryp

[dpdk-dev] [PATCH v3 6/8] event/cnxk: add cn9k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Set crypto adapter enqueue and dequeue operations for CN9K. Signed-off-by: Shijith Thotton --- drivers/event/cnxk/cn9k_eventdev.c | 94 +++- drivers/event/cnxk/cn9k_worker.c | 22 + drivers/event/cnxk/cn9k_worker.h | 41 - drivers/eve

[dpdk-dev] [PATCH v3 7/8] crypto/cnxk: add cn10k crypto adapter fast path ops

2021-09-02 Thread Shijith Thotton
Added crypto adapter enqueue and dequeue operations for CN10K. Signed-off-by: Shijith Thotton Acked-by: Ray Kinsella Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_cryptodev_ops.c | 95 +++ drivers/crypto/cnxk/cn10k_cryptodev_ops.h | 6 ++ drivers/crypto/cnxk/version

  1   2   >