Re: [dpdk-dev] [EXT] Re: [v5] telemetry: fix json output buffer size

2021-10-07 Thread Thomas Monjalon
07/10/2021 06:58, Gowrishankar Muthukrishnan: > From: Thomas Monjalon > > 29/09/2021 06:18, Gowrishankar Muthukrishnan: > > > Fix json output buffer size for an actual data length. > > > > > > Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating > > > JSON") > > > > Please could yo

[dpdk-dev] [PATCH 1/3] net/bnxt: create aggregration rings when needed

2021-10-07 Thread Ajit Khaparde
Aggregration rings are needed when PMD needs to support jumbo frames, LRO. Currently we are creating the aggregration rings whether jumbo frames or LRO has been enabled or disabled. This causes unnecessary allocation of mbufs needing larger mbuf pool which is not used at all. This patch modifies t

[dpdk-dev] [PATCH 0/3] patchset for bnxt PMD

2021-10-07 Thread Ajit Khaparde
Apart from fixing an issue with Rx queue state at startup, this patchset enhances support for RSS action and optimizes the mbuf requirement at startup by creating the aggregation rings only when needed (rx_scatter is enabled). Please apply! Ajit Khaparde (3): net/bnxt: create aggregration rings

[dpdk-dev] [PATCH 3/3] net/bnxt: enhance support for RSS action

2021-10-07 Thread Ajit Khaparde
Enhance support for RSS action in the non-TruFlow path. This will allow the user or application to update the RSS settings using RTE_FLOW API. Signed-off-by: Ajit Khaparde Reviewed-by: Lance Richardson Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_filter.h | 1 + drivers/net/bnxt/bnxt_flo

[dpdk-dev] [PATCH 2/3] net/bnxt: fix Rx queue state on start

2021-10-07 Thread Ajit Khaparde
Fix Rx queue state on device start. The state of Rx queues could be incorrect in some cases because instead of updating the state for all the Rx queues, we are updating it for queues in a VNIC. Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") Cc: sta...@dpdk.org Signed-off-by: Ajit K

Re: [dpdk-dev] [PATCH v3 00/10] NXP DPAAx Bus and PMD changes

2021-10-07 Thread Thomas Monjalon
06/10/2021 19:01, nipun.gu...@nxp.com: > From: Nipun Gupta > > This series adds new functionality related to flow redirection, > generating HW hash key etc. > It also updates the MC firmware version and includes a fix in > dpaxx library. > > Changes in v1: > - Fix checkpatch errors > Changes in

Re: [dpdk-dev] [PATCH v5 2/4] security: build on Windows

2021-10-07 Thread Thomas Monjalon
07/10/2021 00:35, William Tu: > From: Tal Shnaiderman > > Build the security library on Windows. > > Remove unneeded export from version file. To be more precise, it is unneeded because they are inline functions. > --- a/lib/security/version.map > +++ b/lib/security/version.map > @@ -1,13 +1,1

Re: [dpdk-dev] [PATCH v5 4/4] net/ixgbe: build on Windows

2021-10-07 Thread Thomas Monjalon
07/10/2021 00:35, William Tu: > +- Follow the DPDK `Getting Started Guide for Windows > `_ to setup the basic > DPDK environment. Don't use web link for internal reference. It should be :doc: for this one. > + > +- Identify the Intel® Ethernet

Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep indirect actions on restart

2021-10-07 Thread Dmitry Kozlyuk
> -Original Message- > From: Ajit Khaparde > Sent: 6 октября 2021 г. 20:13 > To: Dmitry Kozlyuk > Cc: dpdk-dev ; Matan Azrad ; Ori Kam > ; NBU-Contact-Thomas Monjalon > ; Ferruh Yigit ; Andrew > Rybchenko > Subject: Re: [dpdk-dev] [RFC PATCH 2/2] ethdev: add capability to keep > indirec

Re: [dpdk-dev] [EXT] Re: [v5] telemetry: fix json output buffer size

2021-10-07 Thread Gowrishankar Muthukrishnan
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 7, 2021 12:52 PM > To: Gowrishankar Muthukrishnan > Cc: dev@dpdk.org; bruce.richard...@intel.com; ciara.po...@intel.com; Jerin > Jacob Kollanukkaran > Subject: Re: [EXT] Re: [dpdk-dev] [v5] telemetry: fix json output

Re: [dpdk-dev] [PATCH v3 1/5] eventdev/rx_adapter: add event buffer size configurability

2021-10-07 Thread Jerin Jacob
On Wed, Sep 22, 2021 at 8:44 PM Naga Harish K S V wrote: > > Currently event buffer is static array with a default size defined > internally. > > To configure event buffer size from application, > ``rte_event_eth_rx_adapter_create_with_params`` api is added which > takes ``struct rte_event_eth_rx_

Re: [dpdk-dev] [PATCH v8 5/5] test/event: add unit test for Rx adapter

2021-10-07 Thread Jerin Jacob
On Wed, Oct 6, 2021 at 1:27 PM Naga Harish K S V wrote: > > this patch adds unit tests for checking per rx queue event buffer > feature using rte_event_eth_rx_adapter_queue_add api. > > Signed-off-by: Naga Harish K S V > Acked-by: Jay Jayatheerthan Series applied to dpdk-next-eventdev/for-main.

Re: [dpdk-dev] [v2] telemetry: fix json output buffer size

2021-10-07 Thread Power, Ciara
Hi Gowrishankar, >-Original Message- >From: Gowrishankar Muthukrishnan >Sent: Thursday 30 September 2021 10:01 >To: Power, Ciara ; dev@dpdk.org >Cc: Richardson, Bruce >Subject: RE: [v2] telemetry: fix json output buffer size > >> >Also, I propose if we can have platform defined upper lim

[dpdk-dev] [PATCH v9 0/8] baseband: add NXP LA12xx driver

2021-10-07 Thread nipun . gupta
From: Nipun Gupta This series introduces the BBDEV LA12xx poll mode driver (PMD) to support an implementation for offloading High Phy processing functions like LDPC Encode / Decode 5GNR wireless acceleration function, using PCI based LA12xx Software defined radio. Please check the documentation

[dpdk-dev] [PATCH v9 1/8] bbdev: add device info related to data endianness assumption

2021-10-07 Thread nipun . gupta
From: Nicolas Chautru Adding device information to capture explicitly the assumption of the input/output data byte endianness being processed. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/baseband/acc100/rte_acc100_pmd.c | 1 +

[dpdk-dev] [PATCH v9 2/8] baseband: introduce NXP LA12xx driver

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal This patch introduce the baseband device drivers for NXP's LA1200 series software defined baseband modem. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS | 9 ++ drivers/baseband/la12xx/bbdev_la12xx.c| 1

[dpdk-dev] [PATCH v9 3/8] baseband/la12xx: add devargs for max queues

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal This patch adds dev args to take max queues as input Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 73 +- 1 file changed, 71 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/la12x

[dpdk-dev] [PATCH v9 4/8] baseband/la12xx: add support for multiple modems

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal This patch add support for multiple modems by assigning a modem id as dev args in vdev creation. Signed-off-by: Hemant Agrawal --- drivers/baseband/la12xx/bbdev_la12xx.c | 64 +++--- drivers/baseband/la12xx/bbdev_la12xx.h | 56 +++ d

[dpdk-dev] [PATCH v9 5/8] baseband/la12xx: add queue and modem config support

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal This patch add support for connecting with modem and creating the ipc channel as queues with modem for the exchange of data. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- MAINTAINERS| 1 + doc/guides/bbdevs/index.rst

[dpdk-dev] [PATCH v9 6/8] baseband/la12xx: add enqueue and dequeue support

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal Add support for enqueue and dequeue the LDPC enc/dec from the modem device. Signed-off-by: Nipun Gupta Signed-off-by: Hemant Agrawal --- doc/guides/bbdevs/features/la12xx.ini | 13 + doc/guides/bbdevs/la12xx.rst | 44 +++ drivers/baseband/la12xx/bbdev

[dpdk-dev] [PATCH v9 7/8] app/bbdev: enable la12xx for bbdev

2021-10-07 Thread nipun . gupta
From: Hemant Agrawal this patch adds la12xx driver in test bbdev Signed-off-by: Hemant Agrawal --- app/test-bbdev/meson.build | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build index edb9deef84..a726a5b3fa 100644 --- a/app/test-bbdev/

[dpdk-dev] [PATCH v9 8/8] app/bbdev: handle endianness of test data

2021-10-07 Thread nipun . gupta
From: Nipun Gupta With data input, output and harq also supported in big endian format, this patch updates the testbbdev application to handle the endianness conversion as directed by the the driver being used. The test vectors assumes the data in the little endian order, and thus if the driver

Re: [dpdk-dev] [PATCH v3 00/10] NXP DPAAx Bus and PMD changes

2021-10-07 Thread Thomas Monjalon
07/10/2021 09:37, Thomas Monjalon: > 06/10/2021 19:01, nipun.gu...@nxp.com: > > From: Nipun Gupta > > > > This series adds new functionality related to flow redirection, > > generating HW hash key etc. > > It also updates the MC firmware version and includes a fix in > > dpaxx library. > > > > C

Re: [dpdk-dev] [PATCH v3 00/10] NXP DPAAx Bus and PMD changes

2021-10-07 Thread Nipun Gupta
Sure Thomas, Thanks!! > -Original Message- > From: Thomas Monjalon > Sent: Thursday, October 7, 2021 3:08 PM > To: Nipun Gupta ; Hemant Agrawal > > Cc: dev@dpdk.org; ferruh.yi...@intel.com; Sachin Saxena > > Subject: Re: [dpdk-dev] [PATCH v3 00/10] NXP DPAAx Bus and PMD changes > > 07/

Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros

2021-10-07 Thread Andrew Rybchenko
On 9/23/21 12:39 PM, Thomas Monjalon wrote: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is usi

[dpdk-dev] [PATCH] cryptodev: add telemetry callbacks

2021-10-07 Thread Rebecca Troy
The cryptodev library now registers commands with telemetry, and implements the corresponding callback functions. These commands allow a list of cryptodevs to be queried, as well as info and stats for the corresponding cryptodev. An example usage can be seen below: Connecting to /var/run/dpdk/rte

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-10-07 Thread Andrew Rybchenko
On 10/6/21 12:56 AM, Thomas Monjalon wrote: > 13/09/2021 13:26, Andrew Rybchenko: >> From: Viacheslav Galaktionov >> >> Getting a list of representors from a representor does not make sense. >> Instead, a parent device should be used. > > I don't understand which issue it is fixing. > This functi

Re: [dpdk-dev] [PATCH] net/nfp: cancel delayed LSC work in port close logic

2021-10-07 Thread Ferruh Yigit
On 10/6/2021 7:44 AM, heinrich.k...@corigine.com wrote: From: Heinrich Kuhn The link state change interrupt handler of the NFP PMD will delay the actual LSC work for a short period to ensure the link is stable. If the link of the port changes state and the port is closed immediately after the l

[dpdk-dev] [PATCH v3 1/5] devtools: script to remove unused headers includes

2021-10-07 Thread Sean Morrissey
This script can be used for removing headers flagged for removal by the include-what-you-use (IWYU) tool. The script has the ability to remove headers from specified sub-directories or dpdk as a whole and tests the build after each removal by calling meson compile. example usages: Remove headers

[dpdk-dev] [PATCH v3 3/5] lib/ring: remove unneeded header includes

2021-10-07 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/ring/rte_ring.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c index f17bd966be..bb95962b0c 100644 --- a/lib/ring/rte_ring.c +++ b/lib/

[dpdk-dev] [PATCH v3 0/5] introduce IWYU

2021-10-07 Thread Sean Morrissey
This patchset introduces the include-what-you-use script which removes unused header includes. IWYU GitHub: https://github.com/include-what-you-use/include-what-you-use Along with the script there are some patches which make a start on removing unneeded headers. Sean Morrissey (5): devtools: s

[dpdk-dev] [PATCH v3 4/5] lib/kvargs: remove unneeded header includes

2021-10-07 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey --- lib/kvargs/rte_kvargs.c | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c index 38e9d5c1ca..4cce8e953b 100644 --- a/lib/kvargs/rte_kvargs.c +

[dpdk-dev] [PATCH v3 2/5] lib/telemetry: remove unneeded header includes

2021-10-07 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Acked-by: Ciara Power --- lib/telemetry/telemetry.c | 1 - lib/telemetry/telemetry_data.h | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/tele

[dpdk-dev] [PATCH v3 5/5] lib/eal: remove unneeded header includes

2021-10-07 Thread Sean Morrissey
These header includes have been flagged by the iwyu_tool and removed. Signed-off-by: Sean Morrissey Reviewed-by: Harry van Haaren Reviewed-by: Mattias Rönnblom Reviewed-by: David Christensen --- lib/eal/common/eal_common_dev.c| 5 - lib/eal/common/eal_common_devargs.c| 1

Re: [dpdk-dev] [EXT] Re: [RFC 0/7] make rte_intr_handle internal

2021-10-07 Thread Harman Kalra
Hi Stephen Thanks for your suggestion on RTE_ETH_DEV_INTR_RXQ . Please see my comments inline. > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, October 5, 2021 9:38 PM > To: Harman Kalra > Cc: dev@dpdk.org > Subject: [EXT] Re: [dpdk-dev] [RFC 0/7] make rte_intr_handle int

Re: [dpdk-dev] [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info

2021-10-07 Thread Harman Kalra
> -Original Message- > From: Bruce Richardson > Sent: Monday, September 27, 2021 10:08 PM > To: Harman Kalra > Cc: dev@dpdk.org; ciara.po...@intel.com; Anatoly Burakov > > Subject: Re: [EXT] Re: [PATCH] eal: add telemetry callbacks for memory info > > On Tue, Sep 21, 2021 at 09:05:29

Re: [dpdk-dev] [PATCH v2] ethdev: remove legacy mirroring API

2021-10-07 Thread Ferruh Yigit
On 9/30/2021 6:54 AM, Wang, Haiyue wrote: -Original Message- From: Andrew Rybchenko Sent: Wednesday, September 29, 2021 16:40 To: Li, Xiaoyun ; Yigit, Ferruh ; Xing, Beilei ; Xu, Rosen ; Wang, Haiyue ; Ray Kinsella ; Jiawen Wu ; Jian Wang ; Thomas Monjalon Cc: dev@dpdk.org Subject: [

Re: [dpdk-dev] [PATCH 0/2] raw/cnxk_bphy: sync with upstream

2021-10-07 Thread Jerin Jacob
On Sat, Oct 2, 2021 at 1:50 AM Tomasz Duszynski wrote: > > This series add some wrappers that simplify using > existing BPHY APIs. > > Jakub Palider (1): > raw/cnxk_bphy: use roc calls for max irq > > Tomasz Duszynski (1): > raw/cnxk_bphy: add wrappers for available message types Series Acke

Re: [dpdk-dev] [PATCH v2] ethdev: replace bit shifts with macros

2021-10-07 Thread Ferruh Yigit
On 9/23/2021 10:39 AM, Thomas Monjalon wrote: The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums

[dpdk-dev] [PATCH v5 0/7] hide eth dev related structures

2021-10-07 Thread Konstantin Ananyev
v5 changes: - Fix spelling (Thomas/David) - Rename internal helper functions (David) - Reorder patches and update commit messages (Thomas) - Update comments (Thomas) - Changed layout in rte_eth_fp_ops, to group functions and related data based on their functionality: first 64B line for Rx, se

[dpdk-dev] [PATCH v5 1/7] ethdev: remove legacy Rx descriptor done API

2021-10-07 Thread Konstantin Ananyev
From: Andrew Rybchenko rte_eth_rx_descriptor_status() should be used as a replacement. Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit Acked-by: Thomas Monjalon Acked-by: Konstantin Ananyev --- doc/guides/nics/features.rst| 6 +- doc/guides/rel_notes/deprecation.r

[dpdk-dev] [PATCH v5 2/7] ethdev: allocate max space for internal queue array

2021-10-07 Thread Konstantin Ananyev
At queue configure stage always allocate space for maximum possible number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer pointer to internal queue data without extra checking of current number of configured queues. That would help

[dpdk-dev] [PATCH v5 3/7] ethdev: change input parameters for rx_queue_count

2021-10-07 Thread Konstantin Ananyev
Currently majority of fast-path ethdev ops take pointers to internal queue data structures as an input parameter. While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue index. For future work to hide rte_eth_devices[] and friends it would be plausible to unify parameters list of all fa

[dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-07 Thread Konstantin Ananyev
Copy public function pointers (rx_pkt_burst(), etc.) and related pointers to internal data from rte_eth_dev structure into a separate flat array. That array will remain in a public header. The intention here is to make rte_eth_dev and related structures internal. That should allow future possible c

[dpdk-dev] [PATCH v5 6/7] ethdev: add API to retrieve multiple ethernet addresses

2021-10-07 Thread Konstantin Ananyev
Introduce rte_eth_macaddrs_get() to allow user to retrieve all ethernet addresses assigned to given port. Change testpmd to use this new function and avoid referencing directly rte_eth_devices[]. Signed-off-by: Konstantin Ananyev --- app/test-pmd/config.c | 23 +++---

[dpdk-dev] [PATCH v5 5/7] ethdev: make fast-path functions to use new flat array

2021-10-07 Thread Konstantin Ananyev
Rework fast-path ethdev functions to use rte_eth_fp_ops[]. While it is an API/ABI breakage, this change is intended to be transparent for both users (no changes in user app is required) and PMD developers (no changes in PMD is required). One extra thing to note - RX/TX callback invocation will caus

[dpdk-dev] [PATCH v5 7/7] ethdev: hide eth dev related structures

2021-10-07 Thread Konstantin Ananyev
Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related data into private header (ethdev_driver.h). Few minor changes to keep DPDK building after that. Signed-off-by: Konstantin Ananyev --- doc/guides/rel_notes/release_21_11.rst| 6 + drivers/common/octeontx2/otx2_sec_ide

Re: [dpdk-dev] [PATCH v3 0/4] fixes for intel drivers

2021-10-07 Thread Ferruh Yigit
On 9/22/2021 2:27 PM, Yunjian Wang wrote: This series for fixing memzone leak when re-configure the RX/TX queues for igb, ixgbe, i40e, ice & em drivers. --- v3: * 1. Update commit log * 2. And ice fdir rxq/txq memzones are freed v2: * Update commit log Yunjian Wang (4): net/e1000

Re: [dpdk-dev] [PATCH v4 0/4] net/ixgbe: build on Windows

2021-10-07 Thread Thomas Monjalon
07/10/2021 00:35, William Tu: > This patch enables building the ixgbe driver for Windows. > It also enables its dependencies on security and cryptodev. > I tested on AWS using ixgbe VF device, using dpdk-testpmd. > > Tal Shnaiderman (3): > security: use the net library for IP structs > securit

Re: [dpdk-dev] [PATCH v2 6/6] test/ring: use relaxed barriers for ring stress test

2021-10-07 Thread Ananyev, Konstantin
> wrk_cmd variable is used to signal the worker thread to start > or stop the stress test loop. Relaxed barriers are used > to achieve the same. > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ola Liljedahl > Reviewed-by: Feifei Wang > --- > app/test/test_ring_stress_impl.h | 18 ++

Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-10-07 Thread Thomas Monjalon
Hi, What is the conclusion for this patch? 26/09/2021 05:22, William Tu: > On Sat, Sep 25, 2021 at 9:22 AM Dmitry Kozlyuk > wrote: > > > > 2021-09-24 18:08 (UTC+), William Tu: > > > Windows does not support linker option '/-no-whole-archive' > > > or '/whole-archive'. The patch removes them

Re: [dpdk-dev] [PATCH 0/2] Bugfix for hns3 MAC

2021-10-07 Thread Ferruh Yigit
On 9/22/2021 4:41 AM, Min Hu (Connor) wrote: Two bugfixes for hns3 MAC. Huisong Li (2): net/hns3: fix residual old MAC after setting default MAC net/hns3: fix input parameters of MAC related functions Series applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Tom Rix
On 10/6/21 1:58 PM, Nicolas Chautru wrote: Adding device information to capture explicitly the assumption of the input/output data byte endianness being processed. Signed-off-by: Nicolas Chautru --- doc/guides/rel_notes/release_21_11.rst | 1 + drivers/baseband/acc100/rte_acc10

Re: [dpdk-dev] [PATCH v1] build/pkg-config: Fix warning for Windows

2021-10-07 Thread William Tu
Please don't apply this patch. I think we're waiting for meson to fix it. https://github.com/mesonbuild/meson/issues/9296 In the meantime, at OVS's meson build script, I'm adding /WHOLEARCHIVE and /FORCE:MULTIPLE when linking dpdk. So no need to fix it here. Thanks William On Thu, Oct 7, 2021 a

Re: [dpdk-dev] [PATCH v3 3/5] lib/ring: remove unneeded header includes

2021-10-07 Thread Ananyev, Konstantin
> > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey > --- > lib/ring/rte_ring.c | 7 --- > 1 file changed, 7 deletions(-) > > diff --git a/lib/ring/rte_ring.c b/lib/ring/rte_ring.c > index f17bd966be..bb95962b0c 100644 > --- a/lib/r

Re: [dpdk-dev] [PATCH v2 06/18] bpf: fix spelling in comments

2021-10-07 Thread Ananyev, Konstantin
> > Found by running codespell on the bpf implementation. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Konstantin Ananyev > -- > 2.30.2

[dpdk-dev] [PATCH] doc: remove web references to internal guides

2021-10-07 Thread Thomas Monjalon
The guides should be referenced locally with RST syntax :doc: (beginning of page) or :ref: (specific chapter). The links to doc.dpdk.org/guides/ are removed. The links to the doc.dpdk.org/api/ are acceptable, but should not point to a specific version, so one is fixed. Signed-off-by: Thomas Monja

Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name

2021-10-07 Thread Thomas Monjalon
07/10/2021 12:20, Andrew Rybchenko: > On 10/6/21 12:56 AM, Thomas Monjalon wrote: > > 13/09/2021 13:26, Andrew Rybchenko: > >> From: Viacheslav Galaktionov > >> > >> Getting a list of representors from a representor does not make sense. > >> Instead, a parent device should be used. > > > > I don'

Re: [dpdk-dev] [PATCH] doc/guides: update dev list with Marvell crypto PMDs

2021-10-07 Thread Akhil Goyal
> Update list with following PMDs, > - crypto_cn9k > - crypto_cn10k > - crypto_octeontx > - crypto_octeontx2 > > Also made the list alphabetical. > > Signed-off-by: Anoob Joseph The patch does not apply. Fixed while merging, description and title also updated Acked-by: Akhil Goyal Applied to

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net: fix checksum API documentation

2021-10-07 Thread Ferruh Yigit
On 9/27/2021 5:14 PM, Olivier Matz wrote: On Wed, Sep 22, 2021 at 10:16:09AM +0100, Ferruh Yigit wrote: On 9/21/2021 3:59 PM, Lance Richardson wrote: Minor corrections and improvements to documentation for checksum APIs. Fixes: 6006818cfb26 ("net: new checksum functions") Fixes: 45a08ef55e44 (

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Akhil Goyal
> Update the calculation of the max length needed when converting mbuf to > data vec in partial digest test case. This update make sure the enough > vec buffers are allocated for the appended digest in sgl op for QAT raw > datapath api. > > Fixes: 4868f6591c6f ("test/crypto: add cases for raw data

[dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Ganapati Kundapura
Added telemetry callbacks to get Rx adapter stats, reset stats and to get rx queue config information. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 9ac976c..fa7191c 100644 --- a/lib/eventdev/rte_event_eth_

Re: [dpdk-dev] [PATCH v6 1/5] eal: limit telemetry to primary processes

2021-10-07 Thread Power, Ciara
Hi Bruce, >-Original Message- >From: Richardson, Bruce >Sent: Tuesday 5 October 2021 14:59 >To: dev@dpdk.org >Cc: Power, Ciara ; David Marchand >; Burakov, Anatoly >; Kevin Traynor ; >Richardson, Bruce >Subject: [PATCH v6 1/5] eal: limit telemetry to primary processes > >Telemetry interf

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Akhil Goyal
> Subject: [EXT] [PATCH v9] bbdev: add device info related to data endianness > assumption > Title is too long. bbdev: add dev info for data endianness > Adding device information to capture explicitly the assumption > of the input/output data byte endianness being processed. > > Signed-off-by:

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa

2021-10-07 Thread Akhil Goyal
> Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single > sa > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are > delivered to application unlike inline crypto or lookaside. > Hence fix the application to not drop them when working in > single SA mode. > >

Re: [dpdk-dev] [PATCH] crypto/cnxk: use IE engine group for IPsec

2021-10-07 Thread Akhil Goyal
> > Use IE engine group for cn9k IPsec. > > > > Signed-off-by: Archana Muniganti > > --- > > drivers/crypto/cnxk/cn9k_ipsec.c | 9 ++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > Acked-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

[dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, RTE_BI

Re: [dpdk-dev] [PATCH v6 3/5] telemetry: use unique socket paths for in-memory mode

2021-10-07 Thread Power, Ciara
>-Original Message- >From: Kevin Traynor >Sent: Tuesday 5 October 2021 16:15 >To: Richardson, Bruce >Cc: dev@dpdk.org; Power, Ciara ; David Marchand >; Burakov, Anatoly >Subject: Re: [PATCH v6 3/5] telemetry: use unique socket paths for in-memory >mode > >On 05/10/2021 15:52, Bruce Rich

Re: [dpdk-dev] [PATCH v4 0/3] add SA config option for inner pkt csum

2021-10-07 Thread Akhil Goyal
> Add inner packet IPv4 hdr and L4 checksum enable options > in conf. These will be used in case of protocol offload. > Per SA, application could specify whether the > checksum(compute/verify) can be offloaded to security device. > > Changes in v4: > - Rebased to ToT > - Added documentation for pe

[dpdk-dev] [PATCH v2] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Ganapati Kundapura
Added telemetry callbacks to get Rx adapter stats, reset stats and to get rx queue config information. Signed-off-by: Ganapati Kundapura --- v2: Fixed checkpatch warning --- diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 9ac976c..c2fb54a 100

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Hi Akhil and Hemant, This is a generic problem to raw_api applies either with dst_buf added or not. The idea is for SGL test when Wireless algo digest encrypted case is tested and RTE_MAX(cipher_off + cipher len, auth_off + auth_len) is smaller than RTE_MAX(cipher_off + cipher len, auth_off + au

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Akhil Goyal
Hi Fan, > Hi Akhil and Hemant, > > This is a generic problem to raw_api applies either with dst_buf added or > not. > > The idea is for SGL test when Wireless algo digest encrypted case is tested > and > RTE_MAX(cipher_off + cipher len, auth_off + auth_len) is smaller than > RTE_MAX(cipher_off +

[dpdk-dev] [PATCH v3] cryptodev: add telemetry callbacks

2021-10-07 Thread Rebecca Troy
The cryptodev library now registers commands with telemetry, and implements the corresponding callback functions. These commands allow a list of cryptodevs to be queried, as well as info and stats for the corresponding cryptodev. An example usage can be seen below: Connecting to /var/run/dpdk/rte

Re: [dpdk-dev] [PATCH v3] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
07/10/2021 15:26, Thomas Monjalon: > The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. > The macro UINT64C is also used to replace remaining occurrences of ULL. > > Only bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. > > The API of rte_mtr and rte_tm is using enums

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Hi Akhil, Sorry didn't catch you are mentioning this part - yes we have been preparing for adding oop support into qat for a while :-). Rebecca has already tested and acked the patchset. We are waiting for you merging them before rebasing. Regards, Fan > -Original Message- > From: Akhil

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Ivan Malov
Hi Ori, On 07/10/2021 16:00, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API Hi all, I apologise for sending more mail. In fact, yet another option comes to mind. In order to move away from confusion

Re: [dpdk-dev] [dpdk-stable] [PATCH] net/sfc: relax SW packets/bytes atomic ops memory ordering

2021-10-07 Thread Ferruh Yigit
On 9/17/2021 12:15 PM, Andrew Rybchenko wrote: No barriers are required when stats are incremented or read. Fixes: 96fd2bd69b58 ("net/sfc: support flow action count in transfer rules") Cc: sta...@dpdk.org Signed-off-by: Andrew Rybchenko Applied to dpdk-next-net/main, thanks.

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-07 Thread Ji, Kai
Hi Ahkill, The addition chacha20-poly test was added for a more robust test case to cover oop sgl test scenario. Regards Kai > > Any specific reason to add new vectors for chacha poly? > Are the ones already present not enough? > > > +static uint8_t chacha_aad_2[] = { > > +

Re: [dpdk-dev] [PATCH v2 01/14] ethdev: introduce configurable flexible item

2021-10-07 Thread Ori Kam
Hi Slava, > -Original Message- > From: Slava Ovsiienko > Sent: Friday, October 1, 2021 10:34 PM > Subject: [PATCH v2 01/14] ethdev: introduce configurable flexible item > > 1. Introduction and Retrospective > > Nowadays the networks are evolving fast and wide, the network structures are

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Akhil Goyal
> Sorry didn't catch you are mentioning this part - yes we have been preparing > for adding oop support into qat for a while :-). Rebecca has already tested > and > acked the patchset. We are waiting for you merging them before rebasing. > I am expecting a new patchset from Hemant to handle Konsta

Re: [dpdk-dev] [EXT] [PATCH v3 09/10] crypto/ipsec_mb: add chacha20-poly1305 PMD to framework

2021-10-07 Thread Akhil Goyal
> > The addition chacha20-poly test was added for a more robust test case to > cover oop sgl test scenario. > Ok. Split the test app changes in a separate patch. Please avoid top posting comments and delete irrelevant stuff while replying.

Re: [dpdk-dev] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Thursday, October 7, 2021 5:01 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; nipun.gu...@nxp.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; hemant.agra...@nxp.com; > david.march...@redhat.com > Subje

Re: [dpdk-dev] [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single sa

2021-10-07 Thread Ananyev, Konstantin
> > Subject: [PATCH v2] examples/ipsec-secgw: accept inline proto pkts in single > > sa > > > > In inline protocol inbound SA's, plain ipv4 and ipv6 packets are > > delivered to application unlike inline crypto or lookaside. > > Hence fix the application to not drop them when working in > > sing

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 7, 2021 6:14 AM > To: Chautru, Nicolas ; dev@dpdk.org; > nipun.gu...@nxp.com; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; hemant.agra...@nxp.com; > david.march...@redhat.com > S

Re: [dpdk-dev] [EXT] [dpdk-dev v1] test/crypto: maxlen calculation update

2021-10-07 Thread Zhang, Roy Fan
Thanks Akhil - again anything we can help please let us know. Regards, Fan > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 7, 2021 4:20 PM > To: Zhang, Roy Fan ; Ji, Kai ; > dev@dpdk.org > Cc: hemant.agra...@nxp.com; g.si...@nxp.com > Subject: RE: [EXT] [dpdk-dev] [dpd

Re: [dpdk-dev] [PATCH] usertools/telemetry: add listing of available file prefixes

2021-10-07 Thread Power, Ciara
Hi Conor, >-Original Message- >From: Walsh, Conor >Sent: Tuesday 5 October 2021 16:00 >To: Power, Ciara ; Richardson, Bruce > >Cc: dev@dpdk.org; Walsh, Conor >Subject: [PATCH] usertools/telemetry: add listing of available file prefixes > >This patch adds the option --list (-l) to dpdk-te

[dpdk-dev] [PATCH v4] ethdev: replace bit shifts with macros

2021-10-07 Thread Thomas Monjalon
The macros RTE_BIT32 and RTE_BIT64 are used to replace bit shifts. The macro UINT64C is also used to replace remaining occurrences of ULL. The bit shifts of ETH_RSS_LEVEL_* are kept for aesthetic reason. The API of rte_mtr and rte_tm is using enums for 64-bit variables. As they are enums, unsigne

Re: [dpdk-dev] [RFC PATCH v3 4/5] lib/bpf: use wait event scheme for Rx/Tx iteration

2021-10-07 Thread Ananyev, Konstantin
> > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/bpf/bpf_pkt.c | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c > index 6e8248f0d6..3af15ae97b 100644 > --- a/lib/bpf/bpf_pkt.c > +++ b/lib/bpf/bpf_pk

Re: [dpdk-dev] [EXT] [PATCH v2] eventdev/rx-adapter: add telemetry callbacks

2021-10-07 Thread Gowrishankar Muthukrishnan
Just few minor corrections as below. > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index 9ac976c..c2fb54a 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -23,6 +23,7 @@ > #include

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Andrew Rybchenko
Hi Ori, Ivan, On 10/7/21 5:35 PM, Ivan Malov wrote: Hi Ori, On 07/10/2021 16:00, Ori Kam wrote: Hi Ivan, -Original Message- From: Ivan Malov Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API Hi all, I apologise for sending more mail. In fact, yet another opti

Re: [dpdk-dev] [RFC PATCH v3 1/5] eal: add new definitions for wait scheme

2021-10-07 Thread Ananyev, Konstantin
> Introduce macros as generic interface for address monitoring. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/eal/arm/include/rte_pause_64.h | 151 ++-- > lib/eal/include/generic/rte_pause.h | 78 ++ > 2 files changed, 175 inserti

Re: [dpdk-dev] [PATCH] net: promote ip6 external headers skip API as stable

2021-10-07 Thread Kinsella, Ray
On 02/10/2021 10:40, David Marchand wrote: > On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz wrote: >> >> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6 >> header extensions skip function") (2018), and is used by vmxnet3 driver. >> Promote it as stable. >> >> Signed-off-by: O

Re: [dpdk-dev] [PATCH v2 07/18] acl: fix spelling errors

2021-10-07 Thread Ananyev, Konstantin
> > Lots of little typos in comments > > Signed-off-by: Stephen Hemminger > --- > lib/acl/acl.h | 4 ++-- > lib/acl/acl_bld.c | 2 +- > lib/acl/acl_run_avx2.h | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/lib/acl/acl.h b/lib/acl/acl.h > index 4089a

Re: [dpdk-dev] [PATCH v2 16/18] ip_frag: fix typos

2021-10-07 Thread Ananyev, Konstantin
> Minor typos in comment. > > Signed-off-by: Stephen Hemminger > --- > lib/ip_frag/rte_ipv4_reassembly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/ip_frag/rte_ipv4_reassembly.c > b/lib/ip_frag/rte_ipv4_reassembly.c > index 69666c8b8271..4a89a5f5365a 100644

Re: [dpdk-dev] [EXT] [PATCH v9] bbdev: add device info related to data endianness assumption

2021-10-07 Thread Nipun Gupta
> -Original Message- > From: Chautru, Nicolas > Sent: Thursday, October 7, 2021 9:12 PM > To: Akhil Goyal ; dev@dpdk.org; Nipun Gupta > ; t...@redhat.com > Cc: tho...@monjalon.net; Zhang, Mingshan ; > Joshi, Arun ; Hemant Agrawal > ; david.march...@redhat.com > Subject: RE: [EXT] [PATCH

[dpdk-dev] [PATCH v5 3/6] ethdev: move check to library for MTU set

2021-10-07 Thread Ferruh Yigit
Move requested MTU value check to the API to prevent the duplicated code. Signed-off-by: Ferruh Yigit Reviewed-by: Andrew Rybchenko Reviewed-by: Rosen Xu Acked-by: Somnath Kotur --- drivers/net/axgbe/axgbe_ethdev.c| 15 --- drivers/net/bnxt/bnxt_ethdev.c | 2 +-

[dpdk-dev] [PATCH v5 4/6] ethdev: remove jumbo offload flag

2021-10-07 Thread Ferruh Yigit
Removing 'DEV_RX_OFFLOAD_JUMBO_FRAME' offload flag. Instead of drivers announce this capability, application can deduct the capability by checking reported 'dev_info.max_mtu' or 'dev_info.max_rx_pktlen'. And instead of application setting this flag explicitly to enable jumbo frames, this can be d

[dpdk-dev] [PATCH v5 5/6] ethdev: unify MTU checks

2021-10-07 Thread Ferruh Yigit
Both 'rte_eth_dev_configure()' & 'rte_eth_dev_set_mtu()' sets MTU but have slightly different checks. Like one checks min MTU against RTE_ETHER_MIN_MTU and other RTE_ETHER_MIN_LEN. Checks moved into common function to unify the checks. Also this has benefit to have common error logs. Suggested-by

[dpdk-dev] [PATCH v5 6/6] examples/ip_reassembly: remove unused parameter

2021-10-07 Thread Ferruh Yigit
Remove 'max-pkt-len' parameter. Signed-off-by: Ferruh Yigit --- examples/ip_reassembly/main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index af67db49f7fb..2ff5ea3e7bc5 100644 --- a/examples/ip_reassembly/main.c +++ b/examp

Re: [dpdk-dev] [PATCH v1 02/12] ethdev: add eswitch port item to flow API

2021-10-07 Thread Ori Kam
Hi Ivan, > -Original Message- > From: Ivan Malov > Subject: Re: [PATCH v1 02/12] ethdev: add eswitch port item to flow API > > Hi all, > > I apologise for sending more mail. In fact, yet another option comes to mind. > In > order to move away from confusion with "port mirroring" but pr

  1   2   >