[Bug 879] compiling failed for Graviton2

2021-11-11 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=879 c@163.com changed: What|Removed |Added Resolution|--- |INVALID Status|UNCONFIRMED

RE: [PATCH v1 09/12] app/compress: use compiler atomic builtins for display sync

2021-11-11 Thread Joyce Kong
> > > > > > + exp = 0; > > /* R E P O R T processing */ > > - if (rte_atomic16_test_and_set(&display_once)) { > > + if (__atomic_compare_exchange_n(&display_once, &exp, 1, 0, > > + __ATOMIC_RELAXED, __ATOMIC_RELAXED)) { > I think we can re-organize the current code whi

RE: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc2

2021-11-11 Thread Jiang, YuX
> -Original Message- > From: dev On Behalf Of Thomas Monjalon > Sent: Tuesday, November 9, 2021 8:45 AM > To: annou...@dpdk.org > Subject: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc2 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id

Re: Question about RSS offload types

2021-11-11 Thread lihuisong (C)
Hi, PMD maintainers How do you understand and implement these values? Looking forward to your reply. Thanks. 在 2021/11/3 16:04, Thomas Monjalon 写道: 03/11/2021 02:35, lihuisong (C): Below macros are defined for RSS offload types in rte_ethdev.h. #define *ETH_RSS_IPV4 * (1ULL <<

[PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread Viacheslav Ovsiienko
The patch just refines the code and replaces the pairs of MLX5_ASSERT() and RTE_SET_USED() with equivalent claim_zero(). Cc: sta...@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_txpp.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-

[PATCH] failsafe: Bug fix for the secondary process to support RX and TX

2021-11-11 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/

RE: [PATCH v1 10/12] app/testpmd: use compiler atomic builtins for port sync

2021-11-11 Thread Joyce Kong
> + Ferruh > > > > Hi Joyce/Ferruh, > I do not think the port_status changes need to be handled atomically. The > changes to port_status do not seem to be happening from multiple threads. > It seems to be getting modified during initialization or through the test pmd > prompt. > > Do we re

Re: [dpdk-dev] [dpdk-announce] release candidate 21.11-rc2

2021-11-11 Thread David Marchand
On Thu, Nov 11, 2021 at 9:26 AM Jiang, YuX wrote: > Update the test status for Intel part. Till now dpdk21.11-rc2 test execution > rate is 85%. No critical issue is found. > But has some about missing '_mm512_set_epi8' support build issues. Intel has > already sent a fix: > Patch Link: > https:

RE: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread Slava Ovsiienko
Hi, Ferruh I've also inspected the mlx5 PMD code for RTE_SET_USED() for the similar issues related to the MLX5_ASSERT(). The patch http://patches.dpdk.org/project/dpdk/patch/2021084751.26721-1-viachesl...@nvidia.com/ should refine the few found ones. I do not mind about squashing with "net

Re: [PATCH v2] net/szedata2: remove driver

2021-11-11 Thread Martin Spinler
On Wed, 2021-11-10 at 16:08 +, Ferruh Yigit wrote: > On 11/10/2021 3:39 PM, Martin Spinler wrote: > > Remove the szedata2 device driver as the platform is no longer > > supported. > > > > Signed-off-by: Martin Spinler > > Thanks Martin for the update. > > It would be better to announce the r

Re: [PATCH v2] net/szedata2: remove driver

2021-11-11 Thread Ferruh Yigit
On 11/11/2021 9:08 AM, Martin Spinler wrote: On Wed, 2021-11-10 at 16:08 +, Ferruh Yigit wrote: On 11/10/2021 3:39 PM, Martin Spinler wrote: Remove the szedata2 device driver as the platform is no longer supported. Signed-off-by: Martin Spinler Thanks Martin for the update. It would be

[PATCH] failsafe: Bug fix for the secondary process to support RX-TX

2021-11-11 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/

[PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-11 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/

RE: [dpdk-stable] [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-11-11 Thread Ruifeng Wang
Hi Ferruh, > > > -Original Message- > > > From: Yigit, Ferruh > > > Sent: Tuesday, October 12, 2021 12:27 AM > > > To: Honnappa Nagarahalli ; Ruifeng > > Wang > > > ; dev@dpdk.org; Min Hu (Connor) > > > ; Yisen Zhuang ; > > Lijun Ou > > > > > > Cc: Xing, Beilei ; Zhang, Qi Z > > > ; Rich

[PATCH] test/crypto: fix unnecessary stats retrieval

2021-11-11 Thread Ciara Power
The device stats are retrieved in the testcase teardown function, but are not being used afterwards. Remove this unnecessary call. The stats retrieval for the device is being tested already by a dedicated stats testcase. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Cc

RE: [EXT] [PATCH] test/crypto: fix unnecessary stats retrieval

2021-11-11 Thread Anoob Joseph
> The device stats are retrieved in the testcase teardown function, but are not > being used afterwards. Remove this unnecessary call. > The stats retrieval for the device is being tested already by a dedicated > stats > testcase. > > Fixes: 202d375c60bc ("app/test: add cryptodev unit and perfo

Re: [PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-11 Thread Gaëtan Rivet
On Thu, Nov 11, 2021, at 11:06, Kumara Parameshwaran wrote: > Remove the vdev args check for secondary process which prevents the > secondary from attaching > to the device created by the primary process via the hotplug framework. > This check was removed > for other vdevs but was missed for fail

RE: [PATCH v2] test/crypto: skip plain text compare for null cipher

2021-11-11 Thread Akhil Goyal
> > > > Acked-by: Ciara Power > > Wonder if this patch needs to CC stable, as it's fixing a commit from 2019? > > Apart from this: > Acked-by: Pablo de Lara Applied to dpdk-next-crypto Cc: sta...@dpdk.org

RE: [EXT] [dpdk-dev] [PATCH V4] crypto/mlx5: support BF2 and ConnectX6-DX devices

2021-11-11 Thread Akhil Goyal
> Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6- > DX > adapters support crypto operations. > > Add them to the supported PCI devices list. > > Signed-off-by: Raja Zidane > Acked-by: Matan Azrad > --- > V2: fixed checkpatch warning. > V3: fixed doc. > V4: fixed comm

RE: [EXT] [dpdk-dev] [dpdk-dev v3] test/cryptodev: fix incomplete data length

2021-11-11 Thread Akhil Goyal
> This patch fixes incorrect data lengths computation in cryptodev > unit test. Previously some data lengths were incorrectly set, which > was insensitive for crypto op unit tets but is critical for raw data > path API unit tests. The patch addressed the issue by setting the > correct data lengths

RE: [EXT] [PATCH] examples/ipsec-secgw: fix memory leaks

2021-11-11 Thread Akhil Goyal
> Free telemetry structures when memory allocation > or input parameter errors occur. > Fixes: 3e7b7dd88021 ("examples/ipsec-secgw: support telemetry") > > Signed-off-by: Radu Nicolau > --- Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

Re: [dpdk-dev] [PATCH v5] net/mlx5: fix mutex unlock in txpp cleanup

2021-11-11 Thread Ferruh Yigit
On 11/11/2021 7:06 AM, Slava Ovsiienko wrote: Hi, Ferruh -Original Message- From: Ferruh Yigit Sent: Wednesday, November 10, 2021 18:57 To: Chengfeng Ye ; david.march...@redhat.com; Slava Ovsiienko ; Shahaf Shuler ; Matan Azrad Cc: dev@dpdk.org; sta...@dpdk.org Subject: Re: [dpdk-dev]

RE: [PATCH] test/crypto: fix missing return checks

2021-11-11 Thread Akhil Goyal
> The API could return errors. Add error checking for the same. > > Fixes: b3bbd9e5f265 ("cryptodev: support device independent sessions") > Cc: slawomirx.mrozow...@intel.com > > Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal Applied to dpdk-next-crypto Thanks.

RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

2021-11-11 Thread Akhil Goyal
> The testsuite_setup function in the compressdev_autotest test case, > the rte_compressdev_count() return 0 due to the lack of device init. > It is considered that there is no equitment to skip execution. > So add rte_vdev_init init compress_zlib device. Why? Devices can be added as command line

RE: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

2021-11-11 Thread Akhil Goyal
> > The testsuite_setup function in the compressdev_autotest test case, > > the rte_compressdev_count() return 0 due to the lack of device init. > > It is considered that there is no equitment to skip execution. > > So add rte_vdev_init init compress_zlib device. > > Why? Devices can be added a

Re: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-11 Thread Jerin Jacob
On Tue, Nov 2, 2021 at 9:35 PM Ananyev, Konstantin wrote: > > Minutes of Technical Board Meeting, 2021-Oct-27 > > Members Attending > --- > -Aaron > -Ferruh > -Hemant > -Honnappa > -Jerin > -Kevin > -Konstantin (Chair) > -Maxime > -Stephen > -Thomas > > NOTE: The technical

[PATCH] crypto/cnxk: fix kasumi input len calculation

2021-11-11 Thread Anoob Joseph
Fix kasumi input len calculation to consider encr_offset. Fixes: 546dff20a034 ("crypto/cnxk: add KASUMI decryption") Cc: ktejas...@marvell.com Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cnxk_se.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/cnxk/cn

[PATCH] common/cpt: fix kasumi input len calculation

2021-11-11 Thread Anoob Joseph
Fix kasumi input len calculation to consider encr_offset. Fixes: da39e3eccd3d ("common/cpt: support KASUMI") Cc: ssriniva...@caviumnetworks.com Signed-off-by: Anoob Joseph --- drivers/common/cpt/cpt_ucode.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cpt/c

[PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-11 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/fa

Re: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use

2021-11-11 Thread Thomas Monjalon
11/11/2021 05:15, Tyler Retzlaff: > On Tue, Oct 26, 2021 at 09:45:20AM +0200, Morten Brørup wrote: > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas Monjalon > > > Sent: Monday, 25 October 2021 21.14 > > > > > > 15/03/2021 20:34, Tyler Retzlaff: > > > > The proposal has resulted fr

RE: [PATCH] crypto/cnxk: fix kasumi input len calculation

2021-11-11 Thread Akhil Goyal
> Fix kasumi input len calculation to consider encr_offset. > > Fixes: 546dff20a034 ("crypto/cnxk: add KASUMI decryption") > Cc: ktejas...@marvell.com Cc: sta...@dpdk.org > > Signed-off-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

RE: [PATCH] common/cpt: fix kasumi input len calculation

2021-11-11 Thread Akhil Goyal
> Fix kasumi input len calculation to consider encr_offset. > > Fixes: da39e3eccd3d ("common/cpt: support KASUMI") > Cc: ssriniva...@caviumnetworks.com Cc: sta...@dpdk.org > > Signed-off-by: Anoob Joseph Applied to dpdk-next-crypto Thanks.

RE: [EXT] [PATCH] test/crypto: fix unnecessary stats retrieval

2021-11-11 Thread Akhil Goyal
> > The device stats are retrieved in the testcase teardown function, but are > not > > being used afterwards. Remove this unnecessary call. > > The stats retrieval for the device is being tested already by a dedicated > > stats > > testcase. > > > > Fixes: 202d375c60bc ("app/test: add cryptodev u

Re: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread Ferruh Yigit
On 11/11/2021 8:59 AM, Slava Ovsiienko wrote: Hi, Ferruh I've also inspected the mlx5 PMD code for RTE_SET_USED() for the similar issues related to the MLX5_ASSERT(). The patch http://patches.dpdk.org/project/dpdk/patch/2021084751.26721-1-viachesl...@nvidia.com/ should refine the few found

RE: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread Slava Ovsiienko
Hi, Ferruh > -Original Message- > From: Ferruh Yigit > Sent: Thursday, November 11, 2021 14:08 > To: Slava Ovsiienko ; dev@dpdk.org > Cc: Raslan Darawsheh ; Matan Azrad > ; sta...@dpdk.org; Chengfeng Ye > > Subject: Re: [PATCH] net/mlx5: remove redundant "set used" > > On 11/11/2021 8:5

RE: [PATCH v2 2/2] net/i40e: fix risk in Rx descriptor read in scalar path

2021-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Ruifeng Wang > Sent: Wednesday, September 15, 2021 4:34 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Richardson, Bruce ; jer...@marvell.com; > hemant.agra...@nxp.com; d...@linux.vnet.ibm.com; > honnappa.nagaraha...@arm.com; sta...@dpdk.org; n..

RE: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-11 Thread Ananyev, Konstantin
Hi Jerin, > > Minutes of Technical Board Meeting, 2021-Oct-27 > > > > Members Attending > > --- > > -Aaron > > -Ferruh > > -Hemant > > -Honnappa > > -Jerin > > -Kevin > > -Konstantin (Chair) > > -Maxime > > -Stephen > > -Thomas > > > > NOTE: The technical board meetings e

RE: [dpdk-dev] [PATCH v2] doc: propose correction rte_{bsf, fls} inline functions type use

2021-11-11 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 11 November 2021 12.55 > > 11/11/2021 05:15, Tyler Retzlaff: > > On Tue, Oct 26, 2021 at 09:45:20AM +0200, Morten Brørup wrote: > > > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Thomas > Monjalon > > > > Sent: Monday

[PATCH] failsafe: Bug fix for the secondary process RX-TX support

2021-11-11 Thread Kumara Parameshwaran
Remove the vdev args check for secondary process which prevents the secondary from attaching to the device created by the primary process via the hotplug framework. This check was removed for other vdevs but was missed for failsafe. Fixes: 4852aa8f6e21 ("drivers/net: enable hotplug on secondary pr

RE: [PATCH] net/iavf: fix xstats reset

2021-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, November 9, 2021 6:33 PM > To: Wu, Jingjing ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Nicolau, Radu > > Subject: [PATCH] net/iavf: fix xstats reset > > Wrong offset used to clear the extended stats section resulting i

[PATCH] app/flow-perf: report invalid parameters

2021-11-11 Thread Raslan Darawsheh
Currently, there is no check if an invalid parameter is passed to the application. for example: ./dpdk-test-flow-perf -a 01:00.0 -- --invalid This validate that all strings are part of the known options. Fixes: 3344cf2e3001 ("app/flow-perf: add flow performance skeleton") Cc: wis...@nvidi

RE: [PATCH v2] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2021-11-11 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Friday, November 5, 2021 10:59 AM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; Ori Kam > ; Yongseok Koh > Cc: dev@dpdk.org; Raslan Darawsheh ; > sta...@dpdk.org > Subject: [PATCH v2] net/mlx5: fix the NIC egress flow mismat

[PATCH V2] app/testpmd: fix parameters order when calling rte_ether_addr_copy()

2021-11-11 Thread Xu, Wei1
Running in 'csum' mode, the 'from' and 'to' parameters are not in the correct order when calling rte_ether_addr_copy() which means the 'src/dst' mac addresses in the mbuf will be overwriten. As a result, the packets will not be recognized and received by the receiver(s). Test CLI: ./app/dpdk-test

Re: [EXT] [dpdk-dev] [v2] [PATCH] test_compressdev:fix test case skipping due to missing device init

2021-11-11 Thread wuchangsheng (C)
> >> The testsuite_setup function in the compressdev_autotest test case, >> the rte_compressdev_count() return 0 due to the lack of device init. >> It is considered that there is no equitment to skip execution. >> So add rte_vdev_init init compress_zlib device. > >Why? Devices can be added as comm

RE: [PATCH v2] net/iavf: fix pointer of meter data

2021-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, AlvinX > Sent: Thursday, November 11, 2021 2:32 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Zhang, AlvinX ; sta...@dpdk.org > Subject: [PATCH v2] net/iavf: fix pointer of meter data s/meter/meta > > This patch fixes coverity issue by directly passing

RE: [PATCH v2] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2021-11-11 Thread Jiawei(Jonny) Wang
Hello Raslan, I need send the new V3 patch for this change, Sorry for the late update. Thanks. B.R. Jonny > -Original Message- > From: Raslan Darawsheh > Sent: Thursday, November 11, 2021 9:00 PM > To: Jiawei(Jonny) Wang ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > ; Ori Kam ; Yongseo

RE: [PATCH v2] net/mlx5: fix the NIC egress flow mismatch in switchdev mode

2021-11-11 Thread Raslan Darawsheh
> -Original Message- > From: Jiawei(Jonny) Wang > Sent: Thursday, November 11, 2021 3:18 PM > To: Raslan Darawsheh ; Slava Ovsiienko > ; Matan Azrad ; Ori Kam > ; Ori Kam ; Yongseok Koh > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] net/mlx5: fix the NIC egress flow mis

[PATCH v2 0/1] app/testpmd: add GPU memory option in iofwd engine

2021-11-11 Thread eagostini
From: Elena Agostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine. Changelog: - Updated to lates

[PATCH v2 1/1] app/testpmd: add GPU memory option in iofwd engine

2021-11-11 Thread eagostini
From: eagostini This patch introduces GPU memory in testpmd through the gpudev library. Testpmd can be used for network benchmarks when using GPU memory instead of regular CPU memory to send and receive packets. This option is currently limited to iofwd engine. Signed-off-by: Elena Agostini De

[PATCH 0/2] performance optimized for hns3 PMD

2021-11-11 Thread Min Hu (Connor)
This patch set contains two ways to optimized Tx performance. Chengwen Feng (2): net/hns3: optimized Tx performance by mbuf fast free net/hns3: optimized Tx performance drivers/net/hns3/hns3_rxtx.c | 129 --- drivers/net/hns3/hns3_rxtx.h | 2 + drivers/n

[PATCH 2/2] net/hns3: optimized Tx performance

2021-11-11 Thread Min Hu (Connor)
From: Chengwen Feng The PMD should check whether the descriptor is done by hardware before free the corresponding mbuf. Currently the common xmit algorithm will free mbuf every time when it's invoked. Because hardware may not have finished sending, this may lead to many invalid queries which are

[PATCH 1/2] net/hns3: optimized Tx performance by mbuf fast free

2021-11-11 Thread Min Hu (Connor)
From: Chengwen Feng Currently the vector and simple xmit algorithm don't support multi_segs, so if Tx offload support MBUF_FAST_FREE, driver could invoke rte_mempool_put_bulk() to free Tx mbufs in this situation. In the testpmd single core MAC forwarding scenario, the performance is improved by

[PATCH V5] crypto/mlx5: support BF2 and ConnectX6-DX devices

2021-11-11 Thread Raja Zidane
Starting from FW version xx.32.0108. version, the BlueField2 and ConnextX6-DX adapters support crypto operations. Add them to the supported PCI devices list. Signed-off-by: Raja Zidane Acked-by: Matan Azrad Acked-by: Tal Shnaiderman --- V2: fixed checkpatch warning. V3: fixed doc. V4: fixed co

RE: [dpdk-dev] [EXT] Re: compilation time of cnxk event driver

2021-11-11 Thread Nipun Gupta
Hi Pavan, Compilation of cnxk (both net and event) is also broken on top of the tree with aarch64-linux-gnu-gcc(gcc version 7.5.0 (Linaro GCC 7.5-> 2019.12)). Below are the error logs which are observed: FAILED: drivers/libtmp_rte_event_cnxk.a.p/event_cnxk_cn10k_worker_deq.c.o aarch64-linux-gnu

RE: [dpdk-dev] [EXT] Re: compilation time of cnxk event driver

2021-11-11 Thread Pavan Nikhilesh Bhagavatula
> >Hi Pavan, > >Compilation of cnxk (both net and event) is also broken on top of the >tree with aarch64-linux-gnu-gcc(gcc version 7.5.0 (Linaro GCC 7.5-> >2019.12)). Buggy compiler. See, https://bugs.dpdk.org/show_bug.cgi?id=697 > >Below are the error logs which are observed: > >FAILED: >drivers

[PATCH v9 0/5] add meter policy support in flow-perf

2021-11-11 Thread Rongwei Liu
Add meter policy support and provide options to specify green/yellow/red colored actions and cir/cbs/ebs values. v9: split into more commits. v8: clean log. v7: rebase on top of dpdk.org/main and fix existed styles. v6: rebase on top of main. v5: fix intermediate werror. v4: rebase on top of maste

[PATCH v9 1/5] app/flow-perf: define flow-options as global

2021-11-11 Thread Rongwei Liu
With flow-options defined as global struct, it's possible to use sub-functions to handle run-time options. It's helpful to avoid too many tabs warnings. Signed-off-by: Rongwei Liu --- app/test-flow-perf/main.c | 662 +++--- 1 file changed, 331 insertions(+), 331

[PATCH v9 2/5] app/flow-perf: support meter policy API

2021-11-11 Thread Rongwei Liu
Add option "policy-mtr" to indicate if meter creation will include policy or not. Meter creation will keep unchanged without it. With "policy-mtr", the policy is introduced. API create_meter_policy is to create a policy. API create_meter_rule will use it to create a meter. The value of it is used

[PATCH v9 3/5] app/flow-perf: support dynamic values for meter profile

2021-11-11 Thread Rongwei Liu
Change meter-cir option to meter-profile to cover user input for CIR, CBS & EBS values. The usage is as below: --meter-profile=N1,N2,N3 default value is 125 156250 0. Signed-off-by: Rongwei Liu --- app/test-flow-perf/main.c | 24 +--- doc/guides/tools/flow-perf.rst

[PATCH v9 4/5] app/flow-perf: add packet metering mode

2021-11-11 Thread Rongwei Liu
The flow perf application uses the srtcm_rfc2697 as meter profile while doing the meter testing. This patch adds new configuration parameter '--packet-mode' to generate the meter flows with packet cir instead of byte cir. Signed-off-by: Rongwei Liu --- app/test-flow-perf/main.c | 6 ++

[PATCH v9 5/5] app/flow-perf: fix previous wrong indentation

2021-11-11 Thread Rongwei Liu
--meter section used wrong indentation previously. Fixes: 6a2cf58a045f ("app/flow-perf: support meter action") Cc: dongz...@nvidia.com Cc: sta...@dpdk.org Signed-off-by: Rongwei Liu --- doc/guides/tools/flow-perf.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/

RE: [dpdk-dev] [EXT] Re: compilation time of cnxk event driver

2021-11-11 Thread Nipun Gupta
Thanks for the info !! We can manually disable the drivers if compiling with this version Regards, Nipun > -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Thursday, November 11, 2021 7:51 PM > To: Nipun Gupta ; Ferruh Yigit ; > Thomas Monjalon ; Shijith Thotton > > Cc: Je

Re: [dpdk-dev] [PATCH] common/cnxk: fix pointer argument with gcc 12

2021-11-11 Thread Jerin Jacob
On Mon, Nov 8, 2021 at 2:50 PM Ankur Dwivedi wrote: > > The pointer passed to the rq_ctx and sq_ctx functions was the address > of qctx. Instead of that qctx should be passed. This patch fixes this. > > This patch also resolves warning observed with gcc 12 compiler. > > log: >../drivers/common

Re: [dpdk-dev] [PATCH] common/cnxk: fix memory leak

2021-11-11 Thread Jerin Jacob
On Wed, Nov 10, 2021 at 9:39 AM Anoob Joseph wrote: > > The memory allocated for temporarily keeping DPTR need to be freed after > operation. > > Also, dptr need to be aligned to 8B. > > Fixes: e0bf49f7622b ("common/cnxk: add code to write CPT CTX through > microcode op") > Cc: scha...@marvell.co

Re: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread YE Chengfeng
No problem, I will send the new patch. But what about the commit message and title, should I use the previous one? net/mlx5: fix mutex unlock in txpp cleanup 获取 Outlook for iOS 发件人: Slava Ovsiienko 发送时间: Thursday, November 11, 2021 8:27:3

[PATCH] net/mlx5: fix integrity conversion scheme

2021-11-11 Thread Gregory Etelson
RTE flow integrity API provides top-level packet validations. RTE integrity bits are not always translated one-to-one to hardware integrity bits. For example RTE l3_ok and l4_ok integrity bits require 2 hardware integrity bits each. The patch fixes RTE l3_ok and l4_ok bits translation to match Con

[PATCH] net/mlx5: fix flex item macro collision

2021-11-11 Thread Gregory Etelson
Flex item macro definition values duplicated existing connection tracking values. The patch provides new values for flex item macros. Fixes: a23e9b6e3ee9 ("net/mlx5: handle flex item in flows") Signed-off-by: Gregory Etelson Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.h | 6

RE: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread Slava Ovsiienko
From: YE Chengfeng Sent: Thursday, November 11, 2021 18:08 To: Slava Ovsiienko ; Ferruh Yigit ; dev@dpdk.org Cc: Raslan Darawsheh ; Matan Azrad ; sta...@dpdk.org Subject: Re: [PATCH] net/mlx5: remove redundant "set used" No problem, I will send the new patch. [SO] Thank you. But what about the

RE: [PATCH] net/mlx5: fix integrity conversion scheme

2021-11-11 Thread Slava Ovsiienko
> -Original Message- > From: Gregory Etelson > Sent: Thursday, November 11, 2021 18:16 > To: dev@dpdk.org; Gregory Etelson ; Slava Ovsiienko > > Cc: sta...@dpdk.org; Matan Azrad > Subject: [PATCH] net/mlx5: fix integrity conversion scheme > > RTE flow integrity API provides top-level pa

Re: [PATCH v2] net/iavf: fix pointer of meter data

2021-11-11 Thread Ferruh Yigit
On 11/11/2021 6:31 AM, Alvin Zhang wrote: This patch fixes coverity issue by directly passing the address of the meter data to lower function. Coverity issue: 373867 Fixes: 91f27b2e39ab ("net/iavf: refactor RSS") As far as I can see fixed commit is: Fixes: 7be10c3004be ("net/iavf: add RSS con

Re: [dpdk-stable] [PATCH v2] net/i40e: fix forward outer IPv6 VXLAN packets

2021-11-11 Thread Ferruh Yigit
On 11/5/2021 3:48 AM, Xing, Beilei wrote: -Original Message- From: Wang, Jie1X Sent: Friday, November 5, 2021 11:37 AM To: dev@dpdk.org Cc: Zhang, Yuying ; Li, Xiaoyun ; Yang, SteveX ; Xing, Beilei ; Zhang, Qi Z ; Wang, Jie1X ; sta...@dpdk.org Subject: [PATCH v2] net/i40e: fix forward

Re: [PATCH] net/mlx5: remove redundant "set used"

2021-11-11 Thread YE Chengfeng
Got it. 获取 Outlook for iOS 发件人: Slava Ovsiienko 发送时间: Friday, November 12, 2021 12:47:04 AM 收件人: YE Chengfeng ; Ferruh Yigit ; dev@dpdk.org 抄送: Raslan Darawsheh ; Matan Azrad ; sta...@dpdk.org 主题: RE: [PATCH] net/mlx5: remove redundant "

RE: [PATCH v2] net/iavf: fix pointer of meter data

2021-11-11 Thread Zhang, Qi Z
> -Original Message- > From: Yigit, Ferruh > Sent: Friday, November 12, 2021 1:21 AM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH v2] net/iavf: fix pointer of meter data > > On 11/11/2021 6:31 AM, Alvin Zhang wrote: > > This patch fixes

[PATCH v4 01/18] node: fix docbook typos

2021-11-11 Thread Stephen Hemminger
Spelling errors in comments including doxygen Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx_priv.h | 2 +- lib/node/ethdev_tx_priv.h | 2 +- lib/node/ip4_rewrite_priv.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx_priv.h b/lib/node/ethde

[PATCH v4 00/18] fix docbook and spelling errors

2021-11-11 Thread Stephen Hemminger
After finding a few typos in BPF, decided to cast a wider net and fix lots more places. These are all contained to typos in strings or comments. v4 - rebase and resend

[PATCH v4 02/18] ipsec: fix spelling errors

2021-11-11 Thread Stephen Hemminger
Lots of typos in comments found by codespell Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ipsec/esp_inb.c | 4 ++-- lib/ipsec/esp_outb.c | 2 +- lib/ipsec/ipsec_sad.c | 2 +- lib/ipsec/sa.c| 2 +- lib/ipsec/sa.h| 2 +- 5 files changed, 6 insertions(+)

[PATCH v4 03/18] eventdev: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Typo in comment found by codespell Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_timer_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index e5572e2add6d..9dad170b5a72 100

[PATCH v4 05/18] rcu: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Another codespell find. Signed-off-by: Stephen Hemminger --- lib/rcu/rte_rcu_qsbr.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index 18811c1cc106..62a420a785fc 100644 --- a/lib/rcu/rte_rcu_qsbr.h +++ b/lib/rcu/rte_rcu_qsbr.

[PATCH v4 04/18] power: fix typo in comment

2021-11-11 Thread Stephen Hemminger
More spelling errors caught by codespell Signed-off-by: Stephen Hemminger --- lib/power/power_acpi_cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 1e8aeb84037c..402ed8c99b42 100644 --- a/lib/power

[PATCH v4 06/18] bpf: fix spelling in comments

2021-11-11 Thread Stephen Hemminger
Found by running codespell on the bpf implementation. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_jit_x86.c | 2 +- lib/bpf/bpf_load_elf.c | 2 +- lib/bpf/bpf_pkt.c | 2 +- lib/bpf/bpf_validate.c | 8 4 files changed, 7 insertions(+), 7 deletions

[PATCH v4 07/18] acl: fix spelling errors

2021-11-11 Thread Stephen Hemminger
Lots of little typos in comments Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/acl/acl.h | 4 ++-- lib/acl/acl_bld.c | 2 +- lib/acl/acl_run_avx2.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/acl/acl.h b/lib/acl/acl.h index 40

[PATCH v4 08/18] eal: fix typos in comments

2021-11-11 Thread Stephen Hemminger
Minor spelling errors. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_function_versioning.h | 2 +- lib/eal/windows/include/fnmatch.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/include/rte_function_versioning.h b/lib/eal/include/rte_function

[PATCH v4 09/18] net: fix spelling error in gtp comment

2021-11-11 Thread Stephen Hemminger
More codespell finds. Signed-off-by: Stephen Hemminger --- lib/net/rte_gtp.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/net/rte_gtp.h b/lib/net/rte_gtp.h index 9f6deb9c7ef3..dca940c2c5ab 100644 --- a/lib/net/rte_gtp.h +++ b/lib/net/rte_gtp.h @@ -142,9 +142,9 @@

[PATCH v4 10/18] bbdev: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/bbdev/rte_bbdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c index b86c5fdcc0cb..7f353d4f7e7d 100644 --- a/lib/bbdev/rte_bbdev.c +++ b/li

[PATCH v4 11/18] pipeline: fix spellin error in comment

2021-11-11 Thread Stephen Hemminger
Minor typo Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline.h b/lib/pipeline/rte_swx_pipeline.h index 9c3d08199ce8..77141bd3415b 100644 --- a/lib/pipeline/rte_swx_pipeline.h +++

[PATCH v4 12/18] hash: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/hash/rte_thash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c index 394e1328c531..6847e36f4b10 100644 --- a/lib/hash/rte_thash.c +++ b/lib/ha

[PATCH v4 13/18] rib: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c index b00c7fbf5ab0..70405113b419 100644 --- a/lib/rib/rte_rib6.c +++ b/lib/rib/rte_ri

[PATCH v4 14/18] sched: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 2fe32bbd33d5..ed44808f7b38 100644 --- a/lib/sched/rte_sched.c +++ b/li

[PATCH v4 15/18] vhost: fix typo in comment

2021-11-11 Thread Stephen Hemminger
Yet another spelling error found by codespell. Signed-off-by: Stephen Hemminger --- lib/vhost/rte_vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h index af0afbcf60e0..b454c05868e1 100644 --- a/lib/vhost/rte_vhost.h +++

[PATCH v4 16/18] ip_frag: fix typos

2021-11-11 Thread Stephen Hemminger
Minor typos in comment. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 69666c8b8271..4a89a5f5365a

[PATCH v4 17/18] test-pmd: fix spelling errors in comments

2021-11-11 Thread Stephen Hemminger
More typos Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 +- app/test-pmd/config.c | 4 ++-- app/test-pmd/icmpecho.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 4f51b259fed1..fb5433fd5b2b 100644

[PATCH v4 18/18] test: fix spelling errors in comments

2021-11-11 Thread Stephen Hemminger
Lots of little typos. Signed-off-by: Stephen Hemminger --- app/test/test_atomic.c | 2 +- app/test/test_barrier.c | 2 +- app/test/test_bpf.c | 2 +- app/test/test_compressdev.c | 2 +- app/test/test_func_reentrancy.c | 6 +++--- app/test/test_ipsec.c

RE: [PATCH v4 05/18] rcu: fix typo in comment

2021-11-11 Thread Honnappa Nagarahalli
> > Another codespell find. > > Signed-off-by: Stephen Hemminger Thanks Stephen Reviewed-by: Honnappa Nagarahalli > --- > lib/rcu/rte_rcu_qsbr.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/rcu/rte_rcu_qsbr.h b/lib/rcu/rte_rcu_qsbr.h index > 18811c1cc106..62

RE: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-11 Thread Honnappa Nagarahalli
> > > > Hi Jerin, > > > > Minutes of Technical Board Meeting, 2021-Oct-27 > > > > > > Members Attending > > > --- > > > -Aaron > > > -Ferruh > > > -Hemant > > > -Honnappa > > > -Jerin > > > -Kevin > > > -Konstantin (Chair) > > > -Maxime > > > -Stephen > > > -Thomas > >

RE: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-11 Thread Ananyev, Konstantin
> > > > > > > > > Hi Jerin, > > > > > > Minutes of Technical Board Meeting, 2021-Oct-27 > > > > > > > > Members Attending > > > > --- > > > > -Aaron > > > > -Ferruh > > > > -Hemant > > > > -Honnappa > > > > -Jerin > > > > -Kevin > > > > -Konstantin (Chair) > > > > -Maxime

RE: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-27

2021-11-11 Thread Honnappa Nagarahalli
> > > > 1) Go ahead with both approaches as experimental lib/drivers inside > > DPDK > > Now that there is approval from TB. > > I would like to ask, Is anyone planning to review the specification header > file > [1]? I plan to, but need some time. With the holiday approaching, things are busy

RE: [PATCH] net: add macro for VLAN header length

2021-11-11 Thread Xu, Rosen
Hi, > -Original Message- > From: Yigit, Ferruh > Sent: Thursday, November 11, 2021 1:40 > To: Rasesh Mody ; Shahed Shaikh > ; Rahul Lakkireddy ; > Zhang, Qi Z ; Wang, Xiao W > ; Ziyang Xuan ; > Xiaoyun Wang ; Guoyang Zhou > ; Xing, Beilei ; Wu, > Jingjing ; Yang, Qiming ; Xu, > Rosen ; Wa

[PATCH v2] examples/l3fwd: fix jumbo packet drop issue

2021-11-11 Thread rohit . raj
From: Rohit Raj l3fwd uses mbufs with 2KB data size. If we enable jumbo packets, it is not able to store packets with size greater than 2KB, hence these packets are dropped. This patch fixes this issue by enabling scatter for jumbo packet, if it is supported by NIC. If scatter is not supported

[PATCH] net/ice: fix pointer of the meta data

2021-11-11 Thread Alvin Zhang
This patch fixes coverity issue by directly passing the address of the meter data to lower function. Coverity issue: 373867 Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_hash.c | 5 ++--- 1 file changed, 2 insertions

[PATCH v2] net/ice: fix pointer of the meta data

2021-11-11 Thread Alvin Zhang
This patch fixes coverity issue by directly passing the address of the meta data to subfunction. Coverity issue: 373867 Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Cc: sta...@dpdk.org Signed-off-by: Alvin Zhang --- drivers/net/ice/ice_hash.c | 5 ++--- 1 file changed, 2 insertions(+),

  1   2   >