RE: [PATCH v3] raw/ifpga: fix pthread cannot join

2022-01-21 Thread Zhang, Tianfei
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, January 20, 2022 11:47 PM > To: Huang, Wei > Cc: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > ; sta...@dpdk.org; Zhang, Tianfei > ; Yigit, Ferruh > Subject: Re: [PATCH v3] raw/ifpga: fix pthread cannot join > > On Thu, 20 Ja

[RFC] mempool: cache preparation

2022-01-21 Thread Morten Brørup
Some drivers bypass the mbuf/mempool library functions, to manipulate the mempool cache directly for improved performance. Specifically, the AVX512 implementation of some of the Intel PMDs copy an array of objects from the cache to a field in an array of some structure, i.e. it is not a 1:1 mem

Re: [PATCH v2 1/1] mempool: implement index-based per core cache

2022-01-21 Thread Bruce Richardson
On Fri, Jan 21, 2022 at 06:01:23AM +, Honnappa Nagarahalli wrote: > > > > > +CC Beilei as i40e maintainer > > > > > From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] Sent: > > > Thursday, 13 January 2022 06.37 > > > > > > Current mempool per core cache implementation stores pointers to

RE: [EXT] Re: [PATCH v3 21/29] crypto/cnxk: add more info on command timeout

2022-01-21 Thread Akhil Goyal
> 17/12/2021 10:20, Anoob Joseph: > > Print more info when command timeout happens. Print software and > > hardware queue information. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Tejasree Kondoj > > --- > > +void > > +cnxk_cpt_dump_on_err(struct cnxk_cpt_qp *qp) > > +{ > > + struct

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 16:56:52 + Ferruh Yigit wrote: > On 12/30/2021 6:08 AM, Yanling Song wrote: > > The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC > > cards into DPDK 22.03. Ramaxel Memory Technology is a company which > > supply a lot of electric products: storage, commu

Re: [PATCH v6 02/26] net/spnic: initialize the HW interface

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 17:05:14 + Ferruh Yigit wrote: > On 12/30/2021 6:08 AM, Yanling Song wrote: > > Add HW interface registers and initialize the HW > > interface. > > > > Signed-off-by: Yanling Song > > <...> > > > diff --git a/drivers/net/spnic/base/spnic_hwdev.h > > b/drivers/net/spn

Re: [PATCH v6 05/26] net/spnic: add mgmt module

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 17:22:51 + Ferruh Yigit wrote: > On 12/30/2021 6:08 AM, Yanling Song wrote: > > Mgmt module manage the message gerenated from the hardware. > > This patch implements mgmt module initialization, related event > > processing and message command definition. > > > > Signed-of

Re: [PATCH v6 09/26] net/spnic: support MAC and link event handling

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 17:26:47 + Ferruh Yigit wrote: > On 12/30/2021 6:08 AM, Yanling Song wrote: > > This commit adds interfaces to add/remove MAC addresses > > and registers related ops to struct eth_dev_ops. Furthermore, > > this commit adds callback to handle link events. > > > > The pa

Re: [PATCH] config/cn10k: align mempool elements to 128 bytes

2022-01-21 Thread Jerin Jacob
On Thu, Jan 20, 2022 at 3:21 PM Jerin Jacob wrote: > > On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang wrote: > > > > > -Original Message- > > > From: pbhagavat...@marvell.com > > > Sent: Monday, December 13, 2021 7:06 PM > > > To: jer...@marvell.com; Jan Viktorin ; Ruifeng > > > Wang ; Bru

Re: [PATCH v6 25/26] net/spnic: add doc infrastructure

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 17:27:56 + Ferruh Yigit wrote: > On 12/30/2021 6:09 AM, Yanling Song wrote: > > This patch adds doc infrastructure for spnic PMD driver. > > > > Signed-off-by: Yanling Song > > <...> > > > diff --git a/doc/guides/nics/spnic.rst b/doc/guides/nics/spnic.rst > > new fil

Re: [PATCH v6 26/26] net/spnic: fixes unsafe C style code

2022-01-21 Thread Yanling Song
On Wed, 19 Jan 2022 17:28:11 + Ferruh Yigit wrote: > On 12/30/2021 6:09 AM, Yanling Song wrote: > > Use the hardware structure instead of void* as parameter of > > function to keep the type information > > Hi Yanling, > > This is a new driver and first patchset for it. Instead of fixing i

RE: [RFC] mempool: cache preparation

2022-01-21 Thread Ananyev, Konstantin
> > Some drivers bypass the mbuf/mempool library functions, to manipulate the > mempool cache directly for improved performance. > > Specifically, the AVX512 implementation of some of the Intel PMDs copy an > array of objects from the cache to a field in an array of some > structure, i.e. it

Re: [PATCH 3/8] common/cnxk: change order of frag sizes and infos

2022-01-21 Thread Ferruh Yigit
On 12/9/2021 9:13 AM, Nithin Dabilpuram wrote: Change the order of frag sizes and infos to match HW implementation. Signed-off-by: Nithin Dabilpuram Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/hw/cpt.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

Re: [PATCH 6/8] common/cnxk: handle issues from static analysis

2022-01-21 Thread Ferruh Yigit
On 12/9/2021 9:13 AM, Nithin Dabilpuram wrote: From: Gowrishankar Muthukrishnan Handle issues reported by static analysis tool such as null pointer dereferences, variable initialization, etc. Signed-off-by: Gowrishankar Muthukrishnan Signed-off-by: Nithin Dabilpuram Hi Gowrishankar, Nithin,

Re: [PATCH 7/8] net/cnxk: improve inbound inline error handling for cn9k

2022-01-21 Thread Ferruh Yigit
On 12/9/2021 9:13 AM, Nithin Dabilpuram wrote: Improve inbound inline error handling for CN9K in terms of packet delivered to application for different kinds of errors. Also update udp ports to be used for UDP encapsulation support. This second change seems very unrelated with first change (u

Re: [PATCH 1/8] common/cnxk: fix shift offset for tl3 length disable

2022-01-21 Thread Ferruh Yigit
On 1/19/2022 4:15 PM, Jerin Jacob wrote: On Thu, Dec 9, 2021 at 2:43 PM Nithin Dabilpuram wrote: Fix shift offset for length disable flag in NIXX_AF_TL3X_SHAPE register to be 24 instead of zero similar to other level SHAPE registers. Also mask unused bits in adjust value. Fixes: 0885429c3028

Re: [PATCH v5 1/2] event/cnxk: update min interval calculation

2022-01-21 Thread Jerin Jacob
On Mon, Dec 13, 2021 at 4:44 PM wrote: > > From: Pavan Nikhilesh > > Minimum supported interval should now be retrieved from > mailbox based on the clock source and clock frequency. > > Signed-off-by: Pavan Nikhilesh > --- > v5: > - Rebase on master. Applied to dpdk-next-net-eventdev/for-main.

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2022-01-21 Thread Ferruh Yigit
On 1/21/2022 9:27 AM, Yanling Song wrote: On Wed, 19 Jan 2022 16:56:52 + Ferruh Yigit wrote: On 12/30/2021 6:08 AM, Yanling Song wrote: The patchsets introduce SPNIC driver for Ramaxel's SPNxx serial NIC cards into DPDK 22.03. Ramaxel Memory Technology is a company which supply a lot of e

Re: [PATCH 1/8] common/cnxk: fix shift offset for tl3 length disable

2022-01-21 Thread Nithin Kumar Dabilpuram
On 1/21/22 3:38 PM, Ferruh Yigit wrote: On 1/19/2022 4:15 PM, Jerin Jacob wrote: On Thu, Dec 9, 2021 at 2:43 PM Nithin Dabilpuram wrote: Fix shift offset for length disable flag in NIXX_AF_TL3X_SHAPE register to be 24 instead of zero similar to other level SHAPE registers. Also mask unused

Re: [PATCH] eventdev/rx_adapter: add event port get api

2022-01-21 Thread Jerin Jacob
On Wed, Dec 22, 2021 at 11:43 AM Naga Harish K S V wrote: > > This patch introduces new api for retrieving event port id > of eth rx adapter. > > Signed-off-by: Naga Harish K S V > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 20 > lib/eventdev/rte_event_eth_rx_adapter.h

[PATCH v2 00/15] add packet generator library and example app

2022-01-21 Thread Ronan Randles
V2 - Add UDP protocol support - Add VXLAN protocol support - Removed gen/packet telemetry function as it was unimplemented - Fixed IPv4 endianness issue As I am coming to the end of my internship I will now longer be working on this project. As discussed on the thread [1] this patchset wil

[PATCH v2 01/15] net: add string to IPv4 parse function

2022-01-21 Thread Ronan Randles
Added function that accepts ip string as a parameter and returns an ip address represented by a uint32_t. Relevant unit test for this function is also included. Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- app/test/meson.build | 2 ++ app/test/test_net.c | 61 +

[PATCH v2 02/15] net: add function to pretty print IPv4

2022-01-21 Thread Ronan Randles
This function accepts an uint32_t representation of an IP address and produces a string representation stored in a char * buffer. Realavent unit tests also included. Signed-off-by: Ronan Randles --- app/test/test_net.c | 26 ++ lib/net/rte_ip.c| 15 +++ li

[PATCH v2 03/15] gen: add files for initial traffic generation library

2022-01-21 Thread Ronan Randles
From: Harry van Haaren This commit adds empty files to the DPDK build for a traffic generation library, including the bare create and destroy functions. Unit testing infrastructure is added for the create function. Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- app/test/meso

[PATCH v2 04/15] gen: add basic Rx and Tx routines and tests

2022-01-21 Thread Ronan Randles
From: Harry van Haaren This commit introduces functions for basic mbuf rx and tx. This commit also contains a unit test that calls rte_gen_rx_burst and rte_gen_tx_burst to send bursts of 32 packets repeatedly in order to verify their functionality Signed-off-by: Harry van Haaren Signed-off-by:

[PATCH v2 05/15] gen: add raw packet data API and tests

2022-01-21 Thread Ronan Randles
From: Harry van Haaren This commit adds a new API to gen, allowing the caller to set raw packet data with a size. Tests are added to test the new API with randomized packet data. Signed-off-by: Harry van Haaren --- app/test/test_gen.c | 33 lib/gen/rte_gen.c | 62 +++

[PATCH v2 06/15] gen: add parsing infrastructure and Ether protocol

2022-01-21 Thread Ronan Randles
From: Harry van Haaren This commit adds parsing infrastructure and support for Ether parsing. Appropriate unit tests are also added Signed-off-by: Harry van Haaren --- app/test/test_gen.c | 29 + lib/gen/meson.build | 2 +- lib/gen/rte_gen.c | 299 +

[PATCH v2 07/15] gen: add gen IP parsing

2022-01-21 Thread Ronan Randles
From: Harry van Haaren This commit adds support for the parsing of "IP(src=...,dst=...)" strings. Parse string API improvement for app RCU. Appropriate unit tests also added. Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- app/test/test_gen.c | 29 +++-- lib/gen/rte_gen.

[PATCH v2 08/15] examples/generator: import code from basicfwd.c

2022-01-21 Thread Ronan Randles
From: Harry van Haaren Import files from basicfwd.c to act as starting point for gen library sample app Signed-off-by: Harry van Haaren Signed-off-by: Ronan Randles --- examples/generator/main.c | 226 + examples/generator/meson.build | 12 ++ 2 files cha

[PATCH v2 09/15] examples/generator: enable gen library for traffic gen

2022-01-21 Thread Ronan Randles
This commit shows the steps necessary to enable traffic generation using the gen library Signed-off-by: Ronan Randles --- examples/generator/main.c | 175 ++--- examples/generator/meson.build | 1 + examples/meson.build | 1 + 3 files changed, 120 i

[PATCH v2 10/15] examples/generator: telemetry support

2022-01-21 Thread Ronan Randles
This commit adds telemetry introducing the callback functions and returning measured values Signed-off-by: Ronan Randles --- examples/generator/main.c | 142 +++--- 1 file changed, 118 insertions(+), 24 deletions(-) diff --git a/examples/generator/main.c b/exampl

[PATCH v2 11/15] examples/generator: link status check added

2022-01-21 Thread Ronan Randles
This commit brings in a link status check so that the generator will only start sending packets once there is something on the other end of the link. Signed-off-by: Ronan Randles --- examples/generator/main.c | 68 ++- 1 file changed, 67 insertions(+), 1 delet

[PATCH v2 12/15] examples/generator: line rate limiting

2022-01-21 Thread Ronan Randles
This commit introduces line rate limiting using a token passing method. The target traffic rate default is currently hard coded, this can be set using telemetry. Signed-off-by: Ronan Randles --- examples/generator/main.c | 79 +-- 1 file changed, 51 insertions

[PATCH v2 13/15] gen: add UDP support

2022-01-21 Thread Ronan Randles
This commit adds UDP parsing and logging. Unit tested by the adition of "UDP()" string to 'test_gen_packet_parse_string()' Signed-off-by: Ronan Randles --- app/test/test_gen.c | 1 + lib/gen/rte_gen.c | 66 + 2 files changed, 67 insertions(+) diff

[PATCH v2 14/15] net/vxlan: instance flag endianness refactored

2022-01-21 Thread Ronan Randles
This patch improves the setting of the instance flag in the rte_vxlan_hdr struct, by using a byte to represent vx_flag_bits. Previously it was exposed to the user via a rte_be32_t value, which required handling endianness at the application level. The code uses a union to ensure that existing code

[PATCH v2 15/15] gen: add VXLAN support

2022-01-21 Thread Ronan Randles
This commit adds VXLAN parsing and logging functionality. Unit test with additional test case to test_gen_packet_parse_string. Signed-off-by: Ronan Randles --- app/test/test_gen.c | 1 + lib/gen/rte_gen.c | 50 + 2 files changed, 51 insertions(+) d

Re: [PATCH v2 1/3] gpudev: mem alloc aligned memory

2022-01-21 Thread Thomas Monjalon
08/01/2022 01:20, eagost...@nvidia.com: > From: Elena Agostini > > Similarly to rte_malloc, rte_gpu_mem_alloc accept as > input the memory alignment size. > > GPU driver should return GPU memory address aligned > with the input value. > > Changelog: > - rte_gpu_mem_alloc parameters order > > S

[dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path

2022-01-21 Thread Kai Ji
This patch fix the cipher params configuration in AEAD job if QAT GEN4 unified cipher slice(UCS) enabled. Fixes: 328d690d2f60 ("crypto/qat: update raw data path") Cc: roy.fan.zh...@intel.com Signed-off-by: Kai Ji --- drivers/crypto/qat/qat_sym_hw_dp.c | 16 ++-- 1 file changed, 14 i

RE: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path

2022-01-21 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Friday, January 21, 2022 10:39 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Ji, Kai ; Zhang, Roy Fan > > Subject: [dpdk-dev v1] crypto/qat: fix QAT GEN4 AEAD job in raw data path > > This patch fix the cipher params configuration in AEAD job i

Re: [EXT] Re: [PATCH v3 21/29] crypto/cnxk: add more info on command timeout

2022-01-21 Thread Thomas Monjalon
21/01/2022 10:16, Akhil Goyal: > > Note: this mistake is warned by the script devtools/checkpatches.sh > > Warning in drivers/crypto/cnxk/cnxk_cryptodev_ops.c: > > Using %l format, prefer %PRI*64 if type is [u]int64_t > I believe there is something wrong in the reporting; > it said 1 warning wh

RE: [PATCH 05/12] gen: add raw packet data API and tests

2022-01-21 Thread Van Haaren, Harry
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, January 20, 2022 10:21 AM > To: 'Thomas Monjalon' ; Randles, Ronan > > Cc: dev@dpdk.org; Jerin Jacob ; dev@dpdk.org; > Richardson, Bruce > Subject: RE: [PATCH 05/12] gen: add raw packet data API and tests > But to summari

RE: [PATCH v2 00/13] Add new cases to lookaside IPsec tests

2022-01-21 Thread Akhil Goyal
> Add new tests to lookaside IPsec tests. > > * Support for chained operations. > * AES-CBC 128 NULL auth known vector tests. > * AES-CBC 128 HMAC-SHA256 known vector tests. > * AES-CBC 128 HMAC-SHA384 known vector tests. > * AES-CBC 128 HMAC-SHA512 known vector tests. > * NULL cipher AES-XCBC kno

RE: [EXT] [PATCH v2 8/8] crypto/dpaa_sec: add debug framework

2022-01-21 Thread Akhil Goyal
> Adding useful debug prints in DPAA driver for > easy debugging. > > Signed-off-by: Gagandeep Singh > --- > doc/guides/cryptodevs/dpaa_sec.rst | 10 ++ > drivers/bus/dpaa/dpaa_bus.c| 16 ++- > drivers/crypto/dpaa_sec/dpaa_sec.c | 192 - > 3 files changed, 2

RE: [EXT] [PATCH v2 5/8] crypto/dpaa2_sec: change digest size for AES_CMAC

2022-01-21 Thread Akhil Goyal
> From: Hemant Agrawal > > Change the digest size to supported value by the HW engine. > > Signed-off-by: Hemant Agrawal > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h > b

RE: [PATCH 1/1] mempool: implement index-based per core cache

2022-01-21 Thread Ananyev, Konstantin
Hi Dharmik, > > > >>> > Current mempool per core cache implementation stores pointers to mbufs > On 64b architectures, each pointer consumes 8B > This patch replaces it with index-based implementation, > where in each buffer is addressed by (pool base address + index) > I

RE: [EXT] [PATCH v2 4/8] crypto/dpaa2_sec: support AES-GMAC

2022-01-21 Thread Akhil Goyal
> From: Akhil Goyal > > This patch supports AES_GMAC algorithm for DPAA2 > driver. > > Signed-off-by: Akhil Goyal > Signed-off-by: Gagandeep Singh > --- > doc/guides/cryptodevs/features/dpaa2_sec.ini | 1 + > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 14 - > drivers/crypto/dpaa2

RE: [EXT] [PATCH v2 3/8] crypto/dpaa2_sec: ordered queue support

2022-01-21 Thread Akhil Goyal
> From: Nipun Gupta > > This patch supports ordered queue for DPAA2 platform. > > Signed-off-by: Nipun Gupta > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 255 +++- > drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h | 8 +- > drivers/crypto/dpaa2_sec/mc/fsl_dpseci.h|

RE: [PATCH 1/1] mempool: implement index-based per core cache

2022-01-21 Thread Ananyev, Konstantin
> > > Hi Dharmik, > > > > > >>> > > Current mempool per core cache implementation stores pointers to mbufs > > On 64b architectures, each pointer consumes 8B > > This patch replaces it with index-based implementation, > > where in each buffer is addressed by (pool base addre

Re: [EXT] [PATCH] examples/l3fwd: fix Rx burst size for event mode

2022-01-21 Thread Jerin Jacob
On Tue, Jan 18, 2022 at 4:08 PM Sunil Kumar Kori wrote: > > > > Regards > Sunil Kumar Kori > > >-Original Message- > >From: nipun.gu...@nxp.com > >Sent: Tuesday, January 11, 2022 10:36 AM > >To: dev@dpdk.org > >Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > >; tho...@monjalon.net; hem

[PATCH v2 01/10] common/cnxk: fix shift offset for TL3 length disable

2022-01-21 Thread Nithin Dabilpuram
Fix shift offset for length disable flag in NIXX_AF_TL3X_SHAPE register to be 24 instead of zero similar to other level SHAPE registers. Also mask unused bits in adjust value. Fixes: 0885429c3028 ("common/cnxk: add NIX TM hierarchy enable/disable") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilp

[PATCH v2 02/10] common/cnxk: use for loop in shaper profiles cleanup

2022-01-21 Thread Nithin Dabilpuram
From: Gowrishankar Muthukrishnan In shaper profiles cleanup, Klockwork static analyzer tool reports infinite loop although existing loop condition is alright. False positive may be due to tqh_first not checked in loop, hence switching to FOREACH_SAFE to make Klockwork happy. Signed-off-by: Gowri

[PATCH v2 03/10] common/cnxk: fix byte order of frag sizes and infos

2022-01-21 Thread Nithin Dabilpuram
Change the byte order of frag sizes and infos to match HW implementation. Fixes: 64a73ebd87bd ("common/cnxk: add CPT hardware definitions") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/hw/cpt.h | 14 -- 1 file chan

[PATCH v2 04/10] common/cnxk: reset stale values on error debug registers

2022-01-21 Thread Nithin Dabilpuram
From: Harman Kalra LF's error debug registers like NIX_LF_SQ_OP_ERR_DBG, NIX_LF_MNQ_ERR_DBG, NIX_LF_SEND_ERR_DBG captures debug info for an error detected during LMT operation or meta enqueue or after meta enqueue granted respectively. HW sets a valid bit when info is captured and SW is expected

[PATCH v2 05/10] common/cnxk: always use single interrupt ID with NIX

2022-01-21 Thread Nithin Dabilpuram
From: Harman Kalra An errata exists whereby, in certain cases NIX may use an incorrect QINT_IDX for SQ interrupts. As a result, the interrupt may not be delivered to software, or may not be associated with the correct SQ. When NIX uses an incorrect QINT_IDX : 1. NIX_LF_QINT(0..63)_CNT[COUNT] will

[PATCH v2 06/10] common/cnxk: fix null pointer dereferences

2022-01-21 Thread Nithin Dabilpuram
Fix null pointer dereference issues reported by klockwork(static analysis tool). Fixes: c045d2e5cbbc ("common/cnxk: add CPT configuration") Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Fixes: 665ff1ccc2c4 ("common/cnxk: add base device class") Fixes: da57d4589a6f ("comm

[PATCH v2 07/10] common/cnxk: fix uninitialized variable issues

2022-01-21 Thread Nithin Dabilpuram
Fix uninitialized variable issues reported by klockwork(static analysis tool). Fixes: ed135040f0ab ("common/cnxk: add CPT LF configuration") Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames") Cc: sta

[PATCH v2 08/10] net/cnxk: improve inbound inline error handling for cn9k

2022-01-21 Thread Nithin Dabilpuram
Improve inbound inline error handling for CN9K in terms of packet delivered to application for different kinds of errors. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_ie_on.h | 16 - drivers/net/cnxk/cn9k_rx.h | 50 +++-- 2 fil

[PATCH v2 09/10] common/cnxk: set UDP ports for IPsec UDP encapsulation

2022-01-21 Thread Nithin Dabilpuram
Set UDP ports for IPsec UDP encapsulation feature in outbound inline. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/cnxk_security.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/common/cnxk/cnxk_security.c b/drivers/common/cnxk/cnxk_security.c index 30562b4..8b4dd

[PATCH v2 10/10] net/cnxk: synchronize inline session create and destroy

2022-01-21 Thread Nithin Dabilpuram
Synchronize inline session create and destroy using spinlock. Also move security related error prints outside the spinlock. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c | 35 --- drivers/net/cnxk/cn9k_ethdev_sec.c | 32

Re: [PATCH v3] app/eventdev: add crypto producer mode

2022-01-21 Thread Jerin Jacob
On Tue, Jan 4, 2022 at 4:04 PM Shijith Thotton wrote: > > In crypto producer mode, producer core enqueues cryptodev with software > generated crypto ops and worker core dequeues crypto completion events > from the eventdev. Event crypto metadata used for above processing is > pre-populated in each

Re: [PATCH v2 0/6] allow more DPDK libs to be disabled on build

2022-01-21 Thread David Marchand
On Wed, Jan 19, 2022 at 7:31 PM Bruce Richardson wrote: > > *A common request on-list has been to allow more of the DPDK build to be > disabled by those who are > doing their own builds and only use a subset of the libraries. To this end, > this patchset makes some > infrastructure changes [firs

Re: [dpdk-ci] [RFC] Proposal for allowing rerun of tests

2022-01-21 Thread Kevin Traynor
On 13/04/2021 14:50, Aaron Conole wrote: Greetings, During the various CI pipelines, sometimes a test setup or lab will have an internal failure unrelated to the specific patch. Perhaps 'master' branch (or the associated -next branch) is broken and we cannot get a successful run anyway. Perhap

Re: [PATCH 05/12] gen: add raw packet data API and tests

2022-01-21 Thread Xueming(Steven) Li
On Mon, 2021-12-20 at 18:51 +0530, Jerin Jacob wrote: > On Fri, Dec 17, 2021 at 5:10 PM Van Haaren, Harry > wrote: > > > > +CC Thomas; > > > > > -Original Message- > > > From: Jerin Jacob > > > Sent: Wednesday, December 15, 2021 12:41 PM > > > To: Randles, Ronan > > > Cc: dpdk-dev ; Va

Re: [PATCH] eal: log hugepage create errors with filename

2022-01-21 Thread Thomas Monjalon
07/01/2022 12:53, Bruce Richardson: > On Thu, Dec 23, 2021 at 11:21:58AM -0800, Stephen Hemminger wrote: > > While debugging running DPDK service in a container, it is > > useful to see which file creation failed. Don't hide this > > failure with DEBUG. > > > > Signed-off-by: Stephen Hemminger >

Re: [PATCH] build: remove custom dependency checks in drivers

2022-01-21 Thread Thomas Monjalon
> > > Some drivers currently have their own checks and give some non > > > consistent reasons when an internal dependency is unavailable. > > > > > > drivers/meson.build also checks for internal dependencies via 'deps'. > > > Let's rely on it for consistency, and smaller code. > > > > > > Signed-of

Re: [PATCH 2/2] net/nfp: remove useless range checks

2022-01-21 Thread Ferruh Yigit
On 1/11/2022 2:54 PM, Kevin Traynor wrote: On 05/01/2022 10:32, Maxime Gouin wrote: reported by code analysis tool C++test (version 10.4): Hi Maxime, Can you please give some information on this tool? Thanks, ferruh /build/dpdk-20.11/drivers/net/nfp/nfpcore/nfp_target.h 375   Condition "i

Re: [PATCH 00/12] add packet generator library and example app

2022-01-21 Thread Xueming(Steven) Li
On Tue, 2021-12-14 at 14:12 +, Ronan Randles wrote: > This patchset introduces a Gen library for DPDK. This library provides an easy > way to generate traffic in order to test software based network components. > > This library enables the basic functionality required in the traffic > generat

Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments

2022-01-21 Thread Ferruh Yigit
On 1/6/2022 4:03 PM, Xiaoyun Li wrote: In csum forwarding mode, software UDP/TCP csum calculation only takes the first segment into account while using the whole packet length so the calculation will read invalid memory region with multi-segments packets and will get wrong value. This patch fixes

Re: [PATCH v5 1/2] net: add functions to calculate UDP/TCP cksum in mbuf

2022-01-21 Thread Ferruh Yigit
On 1/6/2022 4:03 PM, Xiaoyun Li wrote: Add functions to call rte_raw_cksum_mbuf() to calculate IPv4/6 UDP/TCP checksum in mbuf which can be over multi-segments. Signed-off-by: Xiaoyun Li Acked-by: Aman Singh Tested-by: Sunil Pai G Thanks Xiaoyun, patch looks good to me: Acked-by: Ferruh Yi

RE: [PATCH 00/12] add packet generator library and example app

2022-01-21 Thread Van Haaren, Harry
> -Original Message- > From: Xueming(Steven) Li > Sent: Friday, January 21, 2022 2:45 PM > To: dev@dpdk.org; Randles, Ronan > Cc: Van Haaren, Harry > Subject: Re: [PATCH 00/12] add packet generator library and example app > > On Tue, 2021-12-14 at 14:12 +, Ronan Randles wrote: > > T

[PATCH] build: fix meson warning about using compiler warning flags

2022-01-21 Thread Bruce Richardson
Each build, meson would issue a warning reporting that the "warning_level" setting should be used in place of adding -Wextra directly to our build commands. Testing with meson 0.61 shows that the only difference for gcc and clang builds between warning levels 1 and 2 is the addition of -Wextra, so

[PATCH v2] build: fix meson warning about using compiler warning flags

2022-01-21 Thread Bruce Richardson
Each build, meson would issue a warning reporting that the "warning_level" setting should be used in place of adding -Wextra directly to our build commands. Testing with meson 0.61 shows that the only difference for gcc and clang builds between warning levels 1 and 2 is the addition of -Wextra, so

Re: [PATCH v5] raw/ifpga: fix pthread cannot join

2022-01-21 Thread Stephen Hemminger
On Thu, 20 Jan 2022 22:32:46 -0500 Wei Huang wrote: > @@ -497,7 +497,7 @@ static int set_surprise_link_check_aer( > int gsd_enable, ret; > #define MS 1000 > > - while (1) { > + while (rte_atomic32_read(&ifpga_monitor_start)) { Better, but rte_atomic is deprecated in favor of usi

Re: [PATCH v2 02/15] net: add function to pretty print IPv4

2022-01-21 Thread Stephen Hemminger
On Fri, 21 Jan 2022 10:31:09 + Ronan Randles wrote: > +int32_t > +rte_ip_print_addr(uint32_t ip_addr, char *buffer, uint32_t buffer_size) > +{ > + if (buffer == NULL) > + return -1; > + > + snprintf(buffer, buffer_size, "%u.%u.%u.%u", > + (ip_addr >> 24), > +

Re: [PATCH] build: fix meson warning about using compiler warning flags

2022-01-21 Thread Luca Boccassi
On Fri, 2022-01-21 at 15:53 +, Bruce Richardson wrote: > Each build, meson would issue a warning reporting that the > "warning_level" setting should be used in place of adding -Wextra > directly to our build commands. Testing with meson 0.61 shows that the > only difference for gcc and clang bu

Re: [PATCH v5 2/2] testpmd: fix l4 sw csum over multi segments

2022-01-21 Thread Kevin Traynor
On 06/01/2022 16:03, Xiaoyun Li wrote: In csum forwarding mode, software UDP/TCP csum calculation only takes the first segment into account while using the whole packet length so the calculation will read invalid memory region with multi-segments packets and will get wrong value. This patch fixes

Re: [PATCH v2 05/10] common/cnxk: always use single interrupt ID with NIX

2022-01-21 Thread Kevin Traynor
On 21/01/2022 12:04, Nithin Dabilpuram wrote: From: Harman Kalra An errata exists whereby, in certain cases NIX may use an incorrect QINT_IDX for SQ interrupts. As a result, the interrupt may not be delivered to software, or may not be associated with the correct SQ. When NIX uses an incorrect Q

Re: [PATCH 00/15] fix and feature for hns3 PMD

2022-01-21 Thread Ferruh Yigit
On 1/7/2022 10:15 AM, Min Hu (Connor) wrote: This patch contains 15 patches, which include fixing codecheck warning ,code refactor and indirect counter action support. Chengwen Feng (4): net/hns3: remove invalid encapsulation function net/hns3: delete strerror invoke net/hns3: rename f

Re: [dpdklab] Re: [dpdk-ci] [RFC] Proposal for allowing rerun of tests

2022-01-21 Thread Lincoln Lavoie
Hi Kevin, I'll add some notes around this to the 2022 planning doc. The retests requests for the periodic tests are tricky from the discussed patchworks / mailing list approach, because there isn't an associated patch or patch ID. So, we just need to document or agree on how to "flag" what the r

[PATCH] sched: Cleanup qos scheduler defines from rte_config

2022-01-21 Thread Megha Ajmera
Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h | 7 --- lib/sched/rte_sched.c | 4 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/config/rte_config.h b/config/rte_conf

Re: [PATCH] common/cnxk: fix incorrect error checking

2022-01-21 Thread Tomasz Duszynski
On Tue, Dec 21, 2021 at 04:02:20PM +0800, Weiguo Li wrote: > Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler") > > Signed-off-by: Weiguo Li > --- > drivers/common/cnxk/roc_bphy_irq.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/common/cnxk/roc_bphy_

[PATCH v6] raw/ifpga: fix pthread cannot join

2022-01-21 Thread Wei Huang
From: Tianfei Zhang When we want to close a thread, we should set a flag to notify thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- v2: update commit log --- v3: set thread id to 0 after pthread_join --- v4:

[PATCH v2] common/cnxk: fix incorrect error checking

2022-01-21 Thread Weiguo Li
Fixes: 804c108b039a ("common/cnxk: set BPHY IRQ handler") Signed-off-by: Weiguo Li --- drivers/common/cnxk/roc_bphy_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c index f4e9b341af..f4954d2a28 1006

Re: [PATCH 1/8] ethdev: introduce IP reassembly offload

2022-01-21 Thread Andrew Rybchenko
On 1/3/22 18:08, Akhil Goyal wrote: IP Reassembly is a costly operation if it is done in software. The operation becomes even more costlier if IP fragmants are encrypted. However, if it is offloaded to HW, it can considerably save application cycles. Hence, a new offload RTE_ETH_RX_OFFLOAD_IP_RE