Re: [PATCH v2 1/3] lib: skip congestion management configuration

2023-01-25 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 1:03 PM Rakesh Kudurumalla wrote: > > Skip the congestion management configuration applied using > rte_eth_cman_config_set() API on the given ethdev Rx queue. 1) Add more comments. Also starts with ethdev: example, ethdev: introduce flow action to skip congestion manageme

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Hanumanth Reddy Pothula
++ Ivan Malov and Andrew Rybchenko > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 24, 2023 11:34 PM > To: Hanumanth Reddy Pothula ; Aman Singh > ; Yuying Zhang > Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; > viachesl...@nvidia.com; Jerin Jacob Kollanukkaran ; > N

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-25 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Wednesday, January 25, 2023 9:42 AM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/

RE: [PATCH v2 1/2] mailmap: add contributor to list

2023-01-25 Thread Mohammad Iqbal Ahmad
Hi, Please provide comment for this patch. Regards, Mohammad Iqbal Ahmad -Original Message- From: Mohammad Iqbal Ahmad Sent: Monday, December 19, 2022 2:04 PM To: dev@dpdk.org; Thomas Monjalon Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori ; Satha Koteswara Rao Kottidi ; Pavan Nik

Re: TCP stack support on DPDK

2023-01-25 Thread Sam Kirubakaran
Hi Liang, Thank you so much for your response. I would like to convert our in-house tool into a high performance traffic generator and it is written in Python. Is it possible to use any of the user space TCP stack by compiling into shared libraries and access it via Python using ctypes? Could you

[PATCH v3 1/1] app/test-flow-perf: fix division or module by zero

2023-01-25 Thread Mohammad Iqbal Ahmad
Fix division or module by zero reported by coverity scan. Updated .mailmap Coverity issue: 373870 Fixes: bf3688f1e816 ("app/flow-perf: add insertion rate calculation") Signed-off-by: Mohammad Iqbal Ahmad --- .mailmap | 1 + app/test-flow-perf/main.c | 7 ++- 2 files changed

DPDK Tech Board Meeting - Tomorrow 1/25/23 @ 7am PT/10am ET/1600h CET

2023-01-25 Thread Nathan Southern
Dear DPDK Community, Our biweekly tech board meeting will be held tomorrow, January 25, 2023 - 7am PT/10am ET/1600h CET. The agenda with discussion items will be posted here: https://annuel.framapad.org/p/r.0c3cc4d1e011214183872a98f6b5c7db To join the meeting follow this link: https://meet.jit

RE: dev Digest, Vol 440, Issue 47

2023-01-25 Thread Benoit Ganne (bganne)
> I would like to convert our in-house tool into a high performance traffic > generator and it is written in Python. > Is it possible to use any of the user space TCP stack by compiling into > shared libraries and access it via Python using ctypes? > Could you please let me know any viable solution

[PATCH 2/2] bus: add platform bus

2023-01-25 Thread Tomasz Duszynski
Platform bus is a software bus under Linux that manages devices which generally do not have built-in discovery mechanisms. Linux normally learns about platform devices directly from device-tree during boot-up phase. Up to this point, whenever some userspace app needed control over platform device

[PATCH 0/2] add platform bus

2023-01-25 Thread Tomasz Duszynski
Platform bus is a bus under Linux which manages devices that do not have any discovery-mechanism built in. Linux learns about platform devices directly from device-tree during boot-up phase. Afterwards if userspace wants to use some particular device driver being usually a mixture of vdev/rawdev g

[PATCH 1/2] lib: add helper to read strings from sysfs files

2023-01-25 Thread Tomasz Duszynski
Reading strings from sysfs files is a re-occurring pattern hence add helper for doing that. Signed-off-by: Tomasz Duszynski --- app/test/test_eal_fs.c | 108 lib/eal/common/eal_filesystem.h | 6 ++ lib/eal/unix/eal_filesystem.c | 24 --- lib/eal

[PATCH 1/2] lib: add helper to read strings from sysfs files

2023-01-25 Thread Tomasz Duszynski
Reading strings from sysfs files is a re-occurring pattern hence add helper for doing that. Signed-off-by: Tomasz Duszynski --- app/test/test_eal_fs.c | 108 lib/eal/common/eal_filesystem.h | 6 ++ lib/eal/unix/eal_filesystem.c | 24 --- lib/eal

[PATCH 0/2] add platform bus

2023-01-25 Thread Tomasz Duszynski
Platform bus is a bus under Linux which manages devices that do not have any discovery-mechanism built in. Linux learns about platform devices directly from device-tree during boot-up phase. Afterwards if userspace wants to use some particular device driver being usually a mixture of vdev/rawdev g

[PATCH 2/2] bus: add platform bus

2023-01-25 Thread Tomasz Duszynski
Platform bus is a software bus under Linux that manages devices which generally do not have built-in discovery mechanisms. Linux normally learns about platform devices directly from device-tree during boot-up phase. Up to this point, whenever some userspace app needed control over platform device

Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-25 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 3:22 PM Naga Harish K, S V wrote: > > Hi Jerin, > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, January 25, 2023 9:42 AM > > To: Naga Harish K, S V > > Cc: jer...@marvell.com; Carrillo, Erik G ; > > Gujjar, > > Abhinandan S ; dev@dpdk.org; > >

Re: [PATCH 1/2] lib: add helper to read strings from sysfs files

2023-01-25 Thread Thomas Monjalon
25/01/2023 11:33, Tomasz Duszynski: > Reading strings from sysfs files is a re-occurring pattern > hence add helper for doing that. In general it would be to nice to clean sysfs parsing in libs and drivers, so they all use some functions from EAL.

RE: [PATCH 0/2] add platform bus

2023-01-25 Thread Tomasz Duszynski
This was mistakenly appended to this thread - ignore it. I've just sent the series again. >-Original Message- >From: Tomasz Duszynski >Sent: Wednesday, January 25, 2023 11:33 AM >To: dev@dpdk.org >Cc: tho...@monjalon.net; Jerin Jacob Kollanukkaran ; >step...@networkplumber.org; chenbo..

[PATCH v3 1/4] common/cnxk: restructure for cn10k datapath

2023-01-25 Thread Rahul Bhansali
Restructure for separate datapath functionality to reduce recompilation time. New *_dp.h are created to have macros, functions as required for datapath. Signed-off-by: Rahul Bhansali --- Changes in v3: No change. Changes in v2: Rebased to next-net-mrvl, No code changes. drivers/common/cnxk/roc

[PATCH v3 2/4] crypto/cnxk: restructure for cn10k datapath

2023-01-25 Thread Rahul Bhansali
From: Anoob Joseph Inclusion of roc_api.h in all files would mean any change in RoC API would result in recompilation of all cnxk drivers. Address this issue in crypto_cnxk drivers by including only the headers that are required. Signed-off-by: Anoob Joseph --- Changes in v3: Reorder patch in s

[PATCH v3 3/4] net/cnxk: restructure for cn10k datapath

2023-01-25 Thread Rahul Bhansali
Restructure for separate cn10k datapath functionality to reduce recompilation time in case of any changes in control path. New cnxk_ethdev_dp.h and cn10k_rxtx.h files are created to have macros, functions as required for datapath with minimal dependency on roc changes. Signed-off-by: Rahul Bhansa

[PATCH v3 4/4] event/cnxk: restructure for cn10k datapath

2023-01-25 Thread Rahul Bhansali
Restructure for separate cn10k datapath functionality to reduce recompilation time in case of any changes in control path. New *_dp.h files are created to have macros, functions as required for datapath with minimal dependency on roc changes. Separates Tx and Rx datapath files to save recompilati

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Thomas Monjalon
19/01/2023 11:33, Hanumanth Reddy Pothula: > From: Thomas Monjalon > > 21/12/2022 03:07, Hanumanth Pothula: > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > performance drop as processing for the same in Rx path takes extra > > > cycles. > > > > > > Hence, add new testpmd

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Thomas Monjalon
25/01/2023 10:30, Hanumanth Reddy Pothula: > ++ Ivan Malov and Andrew Rybchenko > > From: Ferruh Yigit > > On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > performance drop as processing for the same in Rx path takes extra

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Ferruh Yigit
On 1/25/2023 9:30 AM, Hanumanth Reddy Pothula wrote: > ++ Ivan Malov and Andrew Rybchenko > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, January 24, 2023 11:34 PM >> To: Hanumanth Reddy Pothula ; Aman Singh >> ; Yuying Zhang >> Cc: dev@dpdk.org; andrew.rybche...@oktetlab

Re: [PATCH v3 0/4] implementation of ML common code

2023-01-25 Thread Thomas Monjalon
20/12/2022 18:52, Srikanth Yalavarthi: > Machine Learning common code > > > This patch series implements the common ML code that can be used by > ML drivers. Common code include functions to convert ML IO type to > string, IO format type to string, function get size of

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Ferruh Yigit
On 1/25/2023 1:17 PM, Ferruh Yigit wrote: > On 1/25/2023 9:30 AM, Hanumanth Reddy Pothula wrote: >> ++ Ivan Malov and Andrew Rybchenko >> >>> -Original Message- >>> From: Ferruh Yigit >>> Sent: Tuesday, January 24, 2023 11:34 PM >>> To: Hanumanth Reddy Pothula ; Aman Singh >>> ; Yuying Zha

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Ferruh Yigit
On 1/25/2023 9:30 AM, Hanumanth Reddy Pothula wrote: > ++ Ivan Malov and Andrew Rybchenko > >> -Original Message- >> From: Ferruh Yigit >> Sent: Tuesday, January 24, 2023 11:34 PM >> To: Hanumanth Reddy Pothula ; Aman Singh >> ; Yuying Zhang >> Cc: dev@dpdk.org; andrew.rybche...@oktetlab

RE: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-25 Thread Srikanth Yalavarthi
Hi, > -Original Message- > From: Thomas Monjalon > Sent: 25 January 2023 18:48 > To: Shivah Shankar Shankar Narayan Rao > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anup > Prabhu ; Srikanth Yalavarthi > ; ferruh.yi...@amd.com; > bruce.richard...@intel.com; david.march...@redhat.com >

RE: [RFC 0/8] gve PMD enhancement

2023-01-25 Thread Li, Xiaoyun
Where is tx queue setup? And I believe that's also why patchwork is complaining code can't be applied. > -Original Message- > From: Guo, Junfeng > Sent: Wednesday, January 18, 2023 2:54 AM > To: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yi...@amd.com; Xing, Beilei > > Cc: dev@dpdk.org; Li, X

Re: [dpdk-dev] [RFC PATCH 0/1] mldev: introduce machine learning device library

2023-01-25 Thread Thomas Monjalon
17/08/2022 08:58, Morten Brørup: > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > Sent: Wednesday, 17 August 2022 07.37 > > > > On Tue, Aug 16, 2022 at 9:15 PM Morten Brørup > > wrote: > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > Sent: Tuesday, 16 August 2022 15.

Re: [dpdk-dev] [RFC PATCH 0/1] mldev: introduce machine learning device library

2023-01-25 Thread Thomas Monjalon
17/08/2022 16:53, Jerin Jacob: > On Tue, Aug 16, 2022 at 10:04 PM Honnappa Nagarahalli > wrote: > > > > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > Sent: Tuesday, 16 August 2022 15.13 > > > > > > > > On Wed, Aug 3, 2022 at 8:49 PM Stephen Hemminger > > > > wrote: > > > >

Re: [PATCH 0/6] Testpmd code cleanup

2023-01-25 Thread Robin Jarry
David Marchand, Jan 24, 2023 at 11:47: Here is a series to reduce code duplication in testpmd. This work started from looking at Robin series on reporting lcore busy cycles in telemetry, which is then added in testpmd [1]. While looking at the forward engines code, I saw way too much duplicate

Re: [dpdk-dev] [RFC PATCH 0/1] mldev: introduce machine learning device library

2023-01-25 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 7:17 PM Thomas Monjalon wrote: > > 17/08/2022 16:53, Jerin Jacob: > > On Tue, Aug 16, 2022 at 10:04 PM Honnappa Nagarahalli > > wrote: > > > > > > > > > > > > > > From: Jerin Jacob [mailto:jerinjac...@gmail.com] > > > > > Sent: Tuesday, 16 August 2022 15.13 > > > > > > >

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-25 Thread Thomas Monjalon
25/01/2023 14:25, Srikanth Yalavarthi: > From: Thomas Monjalon > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > This patch series implements the common ML code that can be used by ML > > > drivers. Common code include functions to convert ML IO type to > > > string, IO format type to string, funct

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Ferruh Yigit
On 1/25/2023 12:55 PM, Thomas Monjalon wrote: > 25/01/2023 10:30, Hanumanth Reddy Pothula: >> ++ Ivan Malov and Andrew Rybchenko >> >> From: Ferruh Yigit >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: Presently, Rx metadata is sent to PMD by default, leading to a performance drop as

DTS WG roadmap for 23.02

2023-01-25 Thread Honnappa Nagarahalli
Hello, The following patches have been submitted for 23.02 release. 1) Add docker file for creating DTS dev environment and for CI http://patches.dpdk.org/project/dpdk/patch/20221103134633.446646-1-juraj.lin...@pantheon.tech/ 2) Add code needed to run the HelloWorld testcase http://patche

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Thomas Monjalon
25/01/2023 14:55, Ferruh Yigit: > On 1/25/2023 12:55 PM, Thomas Monjalon wrote: > > 25/01/2023 10:30, Hanumanth Reddy Pothula: > >> ++ Ivan Malov and Andrew Rybchenko > >> > >> From: Ferruh Yigit > >>> On 12/21/2022 2:07 AM, Hanumanth Pothula wrote: > Presently, Rx metadata is sent to PMD by

Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-01-25 Thread Thomas Monjalon
14/11/2022 13:02, jer...@marvell.com: > From: Jerin Jacob > > Machine learning inference library > == > > Definition of machine learning inference > > Inference in machine learning is the process of making an output predict

DTS WG MoM 2023 link

2023-01-25 Thread Honnappa Nagarahalli
Hello, The DTS WG MoM for 2023 are captured at [1]. Thank you, Honnappa [1] https://docs.google.com/document/d/1Ej1QyqSPH3ae2nPwG4oZ5Bteb26uH61RmrsZSAECXLU/edit?usp=sharing

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-25 Thread Nithin Kumar Dabilpuram
> >Will it work to enable them all by default and add capability to disable > >it in testpmd, which helps to run performance tests also to verify the > > impact of the API? The spirit of the negotiating features/Rx/Tx offloads upfront is to have it disabled by default and enable the feature only

Re: [PATCH] eventdev/timer: fix overflow issue

2023-01-25 Thread Stephen Hemminger
On Wed, 25 Jan 2023 10:37:16 +0530 Jerin Jacob wrote: > Looks like Stephan replied to v1 hence comment is not showing up here > https://patches.dpdk.org/project/dpdk/patch/20230124204555.3022361-1-erik.g.carri...@intel.com/ > @Erik Gabriel Carrillo Can be following moved to slow path ? > + cycles

RE: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-25 Thread Srikanth Yalavarthi
> -Original Message- > From: Thomas Monjalon > Sent: 25 January 2023 19:25 > To: Shivah Shankar Shankar Narayan Rao ; > Srikanth Yalavarthi > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Anup > Prabhu ; ferruh.yi...@amd.com; > bruce.richard...@intel.com; david.march...@redhat.com; Srikan

RE: [EXT] Re: [PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-25 Thread Ankur Dwivedi
>-Original Message- >From: Ferruh Yigit >Sent: Monday, January 23, 2023 10:58 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: tho...@monjalon.net; david.march...@redhat.com; m...@ashroe.eu; >or...@nvidia.com; ch...@att.com; humi...@huawei.com; >linvi...@tuxdriver.com; ciara.lof...@intel.com; qi

Re: [EXT] Re: [PATCH v6 1/6] eal: trace: add trace point emit for blob

2023-01-25 Thread Ferruh Yigit
On 1/25/2023 3:02 PM, Ankur Dwivedi wrote: > >> >> -- >> On 1/20/2023 8:40 AM, Ankur Dwivedi wrote: >>> Adds a trace point emit function for capturing a blob. The blob >>> captures the length passed by the application followed by

Re: [PATCH 1/2] lib: add helper to read strings from sysfs files

2023-01-25 Thread Tyler Retzlaff
On Wed, Jan 25, 2023 at 11:39:30AM +0100, Thomas Monjalon wrote: > 25/01/2023 11:33, Tomasz Duszynski: > > Reading strings from sysfs files is a re-occurring pattern > > hence add helper for doing that. > > In general it would be to nice to clean sysfs parsing in libs and drivers, > so they all us

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-01-25 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Wednesday, January 25, 2023 4:08 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

Re: [PATCH v2] net/af_xdp: AF_XDP PMD CNI Integration

2023-01-25 Thread Burakov, Anatoly
On 12/14/2022 3:41 PM, Shibin Koikkara Reeny wrote: Integrate support for the AF_XDP CNI and device plugin [1] so that the DPDK AF_XDP PMD can work in an unprivileged container environment. Part of the AF_XDP PMD initialization process involves loading an eBPF program onto the given netdev. This

RE: [PATCH 1/4] net/mlx5/hws: definitions for Hash Split/Linear Lookup tbls

2023-01-25 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Yevgeny Kliteynik > Sent: Thursday, January 12, 2023 3:49 PM > To: Yevgeny Kliteynik ; Slava Ovsiienko > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Suanming Mou ; > Matan Azrad > Cc: dev@dpdk.org; Ori Kam > Subject: [PATCH 1/4] net/mlx5/hws: definition

[PATCH v9] testpmd: cleanup cleanly from signal

2023-01-25 Thread Stephen Hemminger
Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes the problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine leading to locking problems. An added benefit is it gets rid o

Re: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-25 Thread Ferruh Yigit
On 1/23/2023 3:01 PM, Singh, Aman Deep wrote: > > On 12/15/2022 7:11 AM, Chengwen Feng wrote: >> This patch adds "--disable-flow-flush" parameter, which could used to >> disable port flow flush when stop port. It allows testing keep flow >> rules or shared flow objects across restart. >> >> Signed

Re: [PATCH 2/2] app/testpmd: add disable-flow-flush parameter

2023-01-25 Thread Ferruh Yigit
On 12/15/2022 1:41 AM, Chengwen Feng wrote: > This patch adds "--disable-flow-flush" parameter, which could used to > disable port flow flush when stop port. It allows testing keep flow > rules or shared flow objects across restart. > > Signed-off-by: Chengwen Feng +cc Ori I am for proceeding w

Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-01-25 Thread Jerin Jacob
On Wed, Jan 25, 2023 at 7:50 PM Thomas Monjalon wrote: > > 14/11/2022 13:02, jer...@marvell.com: > > From: Jerin Jacob > > > > Machine learning inference library > > == > > > > Definition of machine learning inference > > >

[PATCH 0/3] unblock the use of the MSVC compiler

2023-01-25 Thread Tyler Retzlaff
Introduce minimum changes to the build system to allow use of the MSVC compiler. This change is intended to enable a phased approach to allowing DPDK to built with MSVC. Building with MSVC removes barriers to enterprise customers use of DPDK who have constraints around security policy, compliance

[PATCH 3/3] build: limit what is built when using MSVC compiler

2023-01-25 Thread Tyler Retzlaff
Build only kvargs and telemetry when is_ms_compiler. Signed-off-by: Tyler Retzlaff --- lib/meson.build | 7 +++ meson.build | 13 + 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/lib/meson.build b/lib/meson.build index 82e4666..8e99e21 100644 --- a/lib/meson

[PATCH 2/3] build: determine execution environment at config time

2023-01-25 Thread Tyler Retzlaff
Move execution environment determination and definitions to config. The RTE_EXEC_ENV macros are actually used by libraries built before EAL. Currently it does not matter that this is determined in lib/eal since the definitions are consumed before anything is built including libs built before lib/e

[PATCH 1/3] build: unblock the use of the MSVC compiler

2023-01-25 Thread Tyler Retzlaff
Detect when MSVC toolset is available and tweak toolchain arguments where the meson build system offers no abstraction. Signed-off-by: Tyler Retzlaff --- buildtools/meson.build | 10 +++--- config/meson.build | 21 ++--- config/x86/meson.build | 8 +--- lib/meson.bui

deprecation notice process / clarification

2023-01-25 Thread Tyler Retzlaff
hi, i'm looking for some guidance when cleaning up / removing the remaining shim functions for pthread in windows and i'm not sure how our deprecation notice / policies apply. windows has been providing lib/eal/windows/include/pthread.h shim that allowed applications to use e.g. pthread_xxx funct

[PATCH] app/testpmd: expand noisy neighbour forward mode support

2023-01-25 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded into all forwarding modes except for ieee1588, where it isn't relevant; and iofwd, which wou

Re: [PATCH] app/testpmd: expand noisy neighbour forward mode support

2023-01-25 Thread Stephen Hemminger
On Wed, 25 Jan 2023 17:45:31 -0500 Mike Pattrick wrote: > + if (unlikely(nb_rx == 0)) { > + // May still need to flush some packet DPDK style is to only use C style comments

Re: [PATCH] app/testpmd: expand noisy neighbour forward mode support

2023-01-25 Thread Stephen Hemminger
On Wed, 25 Jan 2023 17:45:31 -0500 Mike Pattrick wrote: > + > +static uint64_t rnd(void) > +{ > + RTE_PER_LCORE(seed) = 1103515245U * RTE_PER_LCORE(seed) + 12345U; > + > + return RTE_PER_LCORE(seed); > +} > + Strong NAK don't add another random generator.

[PATCH v2] app/testpmd: expand noisy neighbour forward mode support

2023-01-25 Thread Mike Pattrick
Previously the noisy neighbour vnf simulation would only operate in io mode, forwarding packets as is. However, this limited the usefulness of noisy neighbour simulation. This feature has now been expanded into all forwarding modes except for ieee1588, where it isn't relevant; and iofwd, which wou

[Bug 1158] Mac address configuration on bonded device in 8023ad mode is not propagated to slave devices

2023-01-25 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1158 Bug ID: 1158 Summary: Mac address configuration on bonded device in 8023ad mode is not propagated to slave devices Product: DPDK Version: 22.11 Hardware: x86 OS: Li