[PATCH v3 0/3] support match icmpv6 ID and sequence

2023-02-05 Thread Leo Xu
Currently, rte_flow API does not support matching ID and sequence fields of icmp6 echo packets. This patchset is used to support match icmpv6 ID and sequence in rte_flow. It adds needed API in rte_flow, and gives corresponding implementation for mlx5 pmd. --- v2: * rebase 23.03 --- v3: * Merge

[PATCH v3 1/3] ethdev: add ICMPv6 ID and sequence

2023-02-05 Thread Leo Xu
This patch adds API support for ICMPv6 ID and sequence. 1: Add two new pattern item types for ICMPv6 echo request and reply: RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY 2: Add new structures for ICMP packet definitions. struct rte_icmp_base_hdr; # For basic head

[PATCH v3 2/3] net/mlx5: add ICMPv6 ID and sequence match support

2023-02-05 Thread Leo Xu
This patch adds ICMPv6 ID and sequence match support. Since type and code of ICMPv6 echo is already specified by ITEM type: RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY mlx5 pmd will set appropriate type and code automatically: Echo request: type(128), code(0) E

[PATCH v3 3/3] net/mlx5/hws: add ICMPv6 ID and sequence match support

2023-02-05 Thread Leo Xu
This patch adds ICMPv6 ID and sequence match support for HWS. Since type and code of ICMPv6 echo is already specified by ITEM type: RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REQUEST RTE_FLOW_ITEM_TYPE_ICMP6_ECHO_REPLY mlx5 pmd will set appropriate type and code automatically: Echo request: type(128), cod

[PATCH 1/2] Added Cliff Burdick to mailmap

2023-02-05 Thread cburdick
From: Cliff Burdick Signed-off-by: Cliff Burdick --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index 6a91c11be4..2cb0d9e41b 100644 --- a/.mailmap +++ b/.mailmap @@ -230,6 +230,7 @@ Cian Ferriter Ciara Loftus Ciara Power Claire Murphy +Cliff Burdick

[PATCH 2/2] config: added support for NVIDIA ARM implementer ID

2023-02-05 Thread cburdick
From: Cliff Burdick Signed-off-by: Cliff Burdick --- config/arm/meson.build | 21 + 1 file changed, 21 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 6442ec9596..6c3de22f16 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@

[PATCH] net/mlx5: fix ESP item validation in Verbs interface

2023-02-05 Thread Maayan Kashani
while added ESP item support in Verbs interface, mlx5_flow_os_validate_item_esp routine in windows/mlx5_flow_os.c was changed. all changes should be in mlx5_flow_verbs.c only. If ESP is not supported in verbs, return default "Item not supported error" during item validation stage. Also, updated ml

Re: [PATCH V6 00/11] pipeline: add IPsec support

2023-02-05 Thread Thomas Monjalon
26/01/2023 15:12, Cristian Dumitrescu: > This patch set introduces a companion block for the SWX pipeline for > IPsec support. > > The IPsec block is external to the pipeline, hence it needs to be > explicitly instantiated by the user and connected to a pipeline > instance through the pipeline I/O

Re: [PATCH] acl: fix trie splitting

2023-02-05 Thread Konstantin Ananyev
It is not really clear to me what is the actual problem and what are you trying to fix here... When using a large number of ACL rules, the trie is supposed to split when there are over 2048 nodes. What do you mean by 'there'? As I remember, it decided to split set of rules, when trie start

BUG: AddressSanitizer reports a buffer-overflow on rte_hash_lookup

2023-02-05 Thread Isaac Boukris
Hi, I managed to reproduce it by modifying the helloworld app (see attached). The report seem correct, as in case of 10 byte key the code tries to look at the key as uint32 array and access k[2] which is two bytes over, see: https://github.com/DPDK/dpdk/blob/0bf583971a0154c9150d4a7a4b82ecbc9dd

RE: [EXT] [PATCH] cryptodev: fix sym session mempool creation description

2023-02-05 Thread Akhil Goyal
> After the session mempool creation API is changed, some > description is no longer valid. This patch fixes the > descriptions in both API comment and the programmer's guide. > > Fixes: bdce2564dbf7 ("cryptodev: rework session framework") > Cc: gak...@marvell.com > > Signed-off-by: Fan Zhang Ac

RE: [EXT] [PATCH v2 1/4] compressdev: add LZ4 algorithm support

2023-02-05 Thread Akhil Goyal
> Add support for LZ4 algorithm: > - Add Lz4 param structure to XFORM structures. > - Add capabilities flags for LZ4 params. > - Add xxHash-32 checksum and capabilities flag. > > Signed-off-by: Michael Baum > --- Please review the series, or else it will be merged in RC1.

RE: [EXT] [PATCH v2 0/2] compressdev: fix end of list enums conflict

2023-02-05 Thread Akhil Goyal
> Handle the conflict about which enum value is used as end of list. > > v2: add patch to remove useless list end enums. > > Michael Baum (2): > compressdev: fix end of comp PMD list macro conflict > compressdev: remove useless list end enums > > drivers/compress/mlx5/mlx5_compress.c

RE: [EXT] [dpdk-dev] [PATCH v2 1/1] compress/octeontx: support scatter gather mode

2023-02-05 Thread Akhil Goyal
> Scatter gather mode feature support is added to compress or decompress > the larger data in a single compression or decompression operation. > > Signed-off-by: Mahipal Challa > > --- > v2: > - Checkpatch warning is resolved. > - PMD debug logs are used for debug prints. > - Documentation is

RE: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length

2023-02-05 Thread Akhil Goyal
> > > > The AESNI_MB PMD supports 8 and 16 byte tag lengths for ZUC256 when > > intel-ipsec-mb version is 1.3 or newer. > > The conditional check to enable these tag lengths had the incorrect > > operator, > > which enabled 8 and 16 byte tag lengths for versions below 1.2, which is not > > support

RE: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length

2023-02-05 Thread Akhil Goyal
> Subject: RE: [PATCH] crypto/ipsec_mb: fix zuc256 maximum tag length > > > > > > > The AESNI_MB PMD supports 8 and 16 byte tag lengths for ZUC256 when > > > intel-ipsec-mb version is 1.3 or newer. > > > The conditional check to enable these tag lengths had the incorrect > operator, > > > which en

Re: [[PATCH] ] linux/igb_uio: fix build with Linux 5.18

2023-02-05 Thread Thomas Monjalon
30/01/2023 08:27, jiangheng (G): > Since commit 7968778914 (PCI: Remove the deprecated "pci-dma-compat.h" API) > in 5.18, pci_set_dma_mask() and pci_set_consistent_dma_mask() no longer exist > switch those api to dma_set_mask_and_coherent. > --- > linux/igb_uio/igb_uio.c | 8 > 1 file cha

Re: [PATCH dpdk-kmods] linux/igb_uio: Adjust functions to the current kernel API

2023-02-05 Thread Thomas Monjalon
20/10/2022 15:00, Leonid Bloch: > After commit 7968778914e53788a01c2dee2692cab157de9ac0 in the upstream > kernel (v5.18+) The functions pci_set_dma_mask() and > pci_set_consistent_dma_mask() are deprecated. Replacing them with the > new substitute (to avoid a compilation error). > > Signed-off-by:

Re: [PATCH dpdk-kmod] linux/igb_uio: fix build with kernel 5.18

2023-02-05 Thread Thomas Monjalon
16/12/2022 12:57, Ferruh Yigit: > In Linux kernel v5.18, "pci-dma-compat.h" wrapper file is removed [1]. > > Some APIs in that wrapper file were used by igb_uio kernel module and > kernel module build fails after mentioned commit. > > Fixed build for v5.18 by replacing APIs in igb_uio. > > Repla

Re: [PATCH v2] linux/igb_uio: fix build with kernel 5.18+

2023-02-05 Thread Thomas Monjalon
06/10/2022 20:51, Georg Müller: > pci_set_dma_mask() and pci_set_consistent_dma_mask() were removed with > kernel 5.18. They both were just wrappers for dma_set_mask() and > dma_set_coherent_mask(). > > Instead, use dma_set_mask_and_coherent(), which is a combination of > dma_set_mask() and dma_se

Re: [kmods PATCH] linux/igb_uio: allow modules install

2023-02-05 Thread Thomas Monjalon
14/06/2022 12:25, Ferruh Yigit: > On 4/12/2022 2:14 PM, Bruce Richardson wrote: > > CAUTION: This message has originated from an External Source. Please use > > proper judgment and caution when opening attachments, clicking links, or > > responding to this email. > > > > > > For those still usi

[kmods PATCH v3] linux/igb_uio: add build instructions

2023-02-05 Thread Thomas Monjalon
From: Anatoly Burakov Currently, compilation instructions for igb_uio are missing. Add them, as well as referring users to per-OS subdirectories. Signed-off-by: Anatoly Burakov Reviewed-by: Ferruh Yigit Reviewed-by: Ajit Khaparde Signed-off-by: Thomas Monjalon --- v3: improvements suggested

[PATCH v2] bus: add platform bus

2023-02-05 Thread Tomasz Duszynski
Platform bus is a software bus under Linux that manages devices which generally do not have built-in discovery mechanisms. Linux normally learns about platform devices directly from device-tree during boot-up phase. Up to this point, whenever some userspace app needed control over platform device

Re: BUG: AddressSanitizer reports a buffer-overflow on rte_hash_lookup

2023-02-05 Thread Stephen Hemminger
On Sun, 5 Feb 2023 18:54:20 +0200 Isaac Boukris wrote: > Hi, > > I managed to reproduce it by modifying the helloworld app (see > attached). The report seem correct, as in case of 10 byte key the code > tries to look at the key as uint32 array and access k[2] which is two > bytes over, see: > ht

Re: BUG: AddressSanitizer reports a buffer-overflow on rte_hash_lookup

2023-02-05 Thread Isaac Boukris
On Sun, Feb 5, 2023 at 9:49 PM Stephen Hemminger wrote: > > On Sun, 5 Feb 2023 18:54:20 +0200 > Isaac Boukris wrote: > > > Hi, > > > > I managed to reproduce it by modifying the helloworld app (see > > attached). The report seem correct, as in case of 10 byte key the code > > tries to look at the

Re: [PATCH V8 0/8] telemetry: fix data truncation and conversion error and add hex integer API

2023-02-05 Thread Thomas Monjalon
> Huisong Li (8): > telemetry: move to header to controllable range > ethdev: fix possible data truncation and conversion error > mempool: fix possible data truncation and conversion error > cryptodev: fix possible data conversion error > mem: possible data truncation and conversion error

Re: BUG: AddressSanitizer reports a buffer-overflow on rte_hash_lookup

2023-02-05 Thread Stephen Hemminger
On Sun, 5 Feb 2023 22:14:28 +0200 Isaac Boukris wrote: > > > > This code is using the common optimization of doing a full 32 bit access > > and masking the result. This will read past the end of the passed input > > but ignore the extra bytes. It won't be a problem unless the application > > goes

Re: [PATCH v3 9/9] telemetry: change public API to use 64-bit signed values

2023-02-05 Thread Thomas Monjalon
12/01/2023 18:41, Bruce Richardson: > While the unsigned values added to telemetry dicts/arrays were up to > 64-bits in size, the sized values were only up to 32-bits. We can sized -> signed > standardize the API by having both int and uint functions take 64-bit > values. For ABI compatibility, w

Re: [PATCH v8 0/5] lcore telemetry improvements

2023-02-05 Thread Thomas Monjalon
> Robin Jarry (5): > eal: add lcore info in telemetry > eal: report applications lcore usage > app/testpmd: add dump command for lcores > app/testpmd: report lcore usage > eal: add lcore usage telemetry endpoint It needs to be rebased on top of the series renaming u64 functions to uint.

Re: [PATCH v3 0/9] Standardize telemetry int types

2023-02-05 Thread Thomas Monjalon
13/01/2023 17:39, Power, Ciara: > > Bruce Richardson (9): > > telemetry: remove RTE prefix from internal enum values > > telemetry: make array initialization more robust > > telemetry: rename unsigned 64-bit enum value to uint > > telemetry: add uint type as alias for u64 > > global: rena

Re: [PATCH] mempool: add object usage counts for the telemetry api

2023-02-05 Thread Thomas Monjalon
15/11/2022 17:28, Morten Brørup: > +CC mempool maintainers > > > From: Robin Jarry [mailto:rja...@redhat.com] > > Sent: Tuesday, 15 November 2022 16.36 > > > > rte_mempool_dump() already returns the number of objects available and > > in the cache. This information is missing from the telemetry A

Re: [dpdk-dev] [PATCH v1 01/12] mldev: introduce machine learning device library

2023-02-05 Thread Stephen Hemminger
On Fri, 03 Feb 2023 21:49:02 +0100 Thomas Monjalon wrote: > > > > > Good catch. > > > > > By the way, we should remove unused RTE_LOGTYPE_*. > > > > > > > > Yes, for 23.11 would like to work down the list. > > > > > > Do we need to wait 23.11? > > > It is not an ABI breakage. > > > And

RE: [PATCH v5 1/9] eal: annotate spinlock, rwlock and seqlock

2023-02-05 Thread Tu, Lijuan
> -Original Message- > From: David Marchand > Sent: Wednesday, February 1, 2023 8:33 PM > To: Chen, Zhaoyan ; Tu, Lijuan > ; sys_stv > Cc: dev@dpdk.org; Coquelin, Maxime ; > step...@networkplumber.org; Xia, Chenbo ; Hu, Jiayu > ; Wang, YuanX ; Ding, Xuan > ; m...@smartsharesystems.com; Bu

Re: [PATCH v2] vhost: exclude VM hugepages from coredumps

2023-02-05 Thread Mike Pattrick
On Fri, Feb 3, 2023 at 12:45 PM Stephen Hemminger wrote: > > On Tue, 6 Dec 2022 10:05:09 -0500 > Mike Pattrick wrote: > > > + > > +static __rte_always_inline void > > +mem_set_dump(__rte_unused void *ptr, __rte_unused size_t size, > > __rte_unused bool enable) > > +{ > > +#ifdef MADV_DONTDUMP >

Re: [PATCH v11 1/3] cmdline: make rdline status not private

2023-02-05 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/4 3:14, Stephen Hemminger wrote: > The function cmdline_poll() returns values from rdline_status enum > but that was moved to being defined only in cmdline_private.h. > > For proper use of the API the return value needs to be visible > to callers. This was not a

Re: [PATCH v7 0/7] start cleanup of rte_flow_item_*

2023-02-05 Thread fengchengwen
LGTM, Series-acked-by: Chengwen Feng On 2023/2/4 0:48, Ferruh Yigit wrote: > There was a plan to have structures from lib/net/ at the beginning > of corresponding flow item structures. > Unfortunately this plan has not been followed up so far. > This series is a step to make the most used items,

RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle

2023-02-05 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, February 3, 2023 5:43 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Zhang, Qi Z ; Xing, Beilei > > Subject: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > From: Beilei Xing > > Refactor idpf pmd by introducing idpf c

[PATCH v8 0/1] Add support AVX512 split queue datapath

2023-02-05 Thread Wenjun Wu
This patchset enables AVX512 data path for split queue model. It is based on the below pathset 1. https://patches.dpdk.org/project/dpdk/list/?series=26786 v3: fix logical error. v4: rebase to the new baseline. v5: fix compilation error. v6: remove unexpected changes. v7: rebase to the new baseli

[PATCH v8 1/1] common/idpf: add AVX512 data path for split queue model

2023-02-05 Thread Wenjun Wu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 21 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797

Re: [PATCH v8 5/5] eal: add lcore usage telemetry endpoint

2023-02-05 Thread fengchengwen
Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Allow fetching CPU cycles usage for all lcores with a single request. > This endpoint is intended for repeated and frequent invocations by > external monitoring systems and therefore returns condensed data. > > It consists of a single dictionary w

Re: [PATCH v8 4/5] app/testpmd: report lcore usage

2023-02-05 Thread fengchengwen
Suggest add field "busy ratio" to reduce hand-computing and improve readability. With above add, Acked-by: Chengwen Feng On 2023/2/2 21:43, Robin Jarry wrote: > Reuse the --record-core-cycles option to account for busy cycles. One > turn of packet_fwd_t is considered "busy" if there was at least

Re: [PATCH 1/3] lib: dpdk spec to skip red for ingress policer

2023-02-05 Thread Jerin Jacob
On Thu, Feb 2, 2023 at 1:01 PM Ori Kam wrote: > > > > > -Original Message- > > From: Jerin Jacob > > Sent: Wednesday, 1 February 2023 20:37 > > > > On Wed, Feb 1, 2023 at 11:19 PM Ori Kam wrote: > > > > > > > > > > > > > -Original Message- > > > > From: Jerin Jacob > > > > Sent:

[PATCH v9 0/1] Add support AVX512 split queue datapath

2023-02-05 Thread Wenjun Wu
This patchset enables AVX512 data path for split queue model. It is based on the below pathset 1. https://patches.dpdk.org/project/dpdk/cover/20230117080622.105657-1-beilei.x...@intel.com/ v3: fix logical error. v4: rebase to the new baseline. v5: fix compilation error. v6: remove unexpected ch

[PATCH v9 1/1] common/idpf: add AVX512 data path for split queue model

2023-02-05 Thread Wenjun Wu
Add support of AVX512 data path for split queue model. Signed-off-by: Wenjun Wu Reviewed-by: Wenjing Qiao Acked-by: Wenzhuo Lu --- drivers/common/idpf/idpf_common_rxtx.c| 22 +- drivers/common/idpf/idpf_common_rxtx.h| 21 +- drivers/common/idpf/idpf_common_rxtx_avx512.c | 797

Re: [PATCH v8 3/5] app/testpmd: add dump command for lcores

2023-02-05 Thread fengchengwen
Acked-by: Chengwen Feng On 2023/2/2 21:43, Robin Jarry wrote: > Add a simple command that calls rte_lcore_dump(). > > Signed-off-by: Robin Jarry > Acked-by: Morten Brørup > Acked-by: Konstantin Ananyev > Reviewed-by: Kevin Laatz > --- > ...

[PATCH v4 0/4] add flex item support

2023-02-05 Thread Rongwei Liu
Support flex item matching and modify field in async flow. Syntax follows sync flow exactly. v4: split ethdev part. v3: enhance format, add flex_handle document. Rongwei Liu (4): ethdev: add flex item modify field support app/testpmd: pass flex handle into matching mask app/testpmd: raw enc

[PATCH v4 1/4] ethdev: add flex item modify field support

2023-02-05 Thread Rongwei Liu
Add flex item as modify field destination. Add "struct rte_flow_item_flex_handle *flex_handle" into "struct rte_flow_action_modify_data" as union with existed "level" member. This new member is dedicated for modifying flex item. Add flex item modify field cmdline support. Now user can use testpmd

[PATCH v4 2/4] app/testpmd: pass flex handle into matching mask

2023-02-05 Thread Rongwei Liu
In async flow create API, there is only mask information when creating flow table but flex item handle is required to parse the HW sample information. Pass the flex item handle instead of UINT64/32_MAX to mask. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 8 ++

[PATCH v4 3/4] app/testpmd: raw encap with flex item support

2023-02-05 Thread Rongwei Liu
Application should retrieve raw_encap buffer from spec->pattern if it is flex item. Signed-off-by: Rongwei Liu Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test

[PATCH v4 4/4] app/testpmd: adjust cleanup sequence when quitting

2023-02-05 Thread Rongwei Liu
If flex item is referenced in async flow either by pattern template or action template, currently testpmd complains "flex item has flow references". Flex items should be flushed after async flow resources cleanup. Signed-off-by: Rongwei Liu Acked-by: Ori Kam Acked-by: Aman Singh --- app/test-p

Re: [PATCH v8 1/5] eal: add lcore info in telemetry

2023-02-05 Thread fengchengwen
Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Report the same information than rte_lcore_dump() in the telemetry > API into /eal/lcore/list and /eal/lcore/info,ID. > > Example: > > --> /eal/lcore/info,3 > { > "/eal/lcore/info": { > "lcore_id": 3, > "socket": 0, > "r

Re: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-05 Thread fengchengwen
Hi Robin, On 2023/2/2 21:43, Robin Jarry wrote: > Allow applications to register a callback that will be invoked in > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > The callback is expected to return the number of TSC cycles that have > passed since application start an

[PATCH v7 00/19] net/idpf: introduce idpf common modle

2023-02-05 Thread beilei . xing
From: Beilei Xing Refactor idpf pmd by introducing idpf common module, which will be also consumed by a new PMD - CPFL (Control Plane Function Library) PMD. v2 changes: - Refine irq map/unmap functions. - Fix cross compile issue. v3 changes: - Embed vport_info field into the vport structure.

[PATCH v7 01/19] common/idpf: add adapter structure

2023-02-05 Thread beilei . xing
From: Beilei Xing Add structure idpf_adapter in common module, the structure includes some basic fields. Introduce structure idpf_adapter_ext in PMD, this structure includes extra fields except idpf_adapter. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_comm

[PATCH v7 02/19] common/idpf: add vport structure

2023-02-05 Thread beilei . xing
From: Beilei Xing Move idpf_vport structure to common module, remove ethdev dependency. Also remove unused functions. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 59 ++ drivers/net/idpf/idpf_ethdev.c | 10 +- drivers/net/i

[PATCH v7 03/19] common/idpf: add virtual channel functions

2023-02-05 Thread beilei . xing
From: Beilei Xing Move most of the virtual channel functions to idpf common module. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/base/idpf_controlq_api.h | 4 - drivers/common/idpf/base/meson.build | 2 +- drivers/common/idpf/idpf_common_device.c

[PATCH v7 04/19] common/idpf: introduce adapter init and deinit

2023-02-05 Thread beilei . xing
From: Beilei Xing Introduce idpf_adapter_init and idpf_adapter_deinit functions in common module. And also introduce idpf_adapter_ext_init and idpf_adapter_ext_deinit functions. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/base/idpf_controlq_api.h | 2 - drive

[PATCH v7 05/19] common/idpf: add vport init/deinit

2023-02-05 Thread beilei . xing
From: Beilei Xing Introduce idpf_vport_init and idpf_vport_deinit functions in common module. Signed-off-by: Wenjun Wu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 115 + drivers/common/idpf/idpf_common_device.h | 13 +- drivers/common/idpf/id

[PATCH v7 06/19] common/idpf: add config RSS

2023-02-05 Thread beilei . xing
From: Beilei Xing Move configure RSS to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 25 +++ drivers/common/idpf/idpf_common_device.h | 2 ++ drivers/common/idpf/version.map | 1 + drivers/net/idpf/idpf_ethdev.c

[PATCH v7 07/19] common/idpf: add irq map/unmap

2023-02-05 Thread beilei . xing
From: Beilei Xing Introduce idpf_config_irq_map/idpf_config_irq_unmap functions in common module, and refine config rxq irqs function. Refine device start function with some irq error handling. Besides, vport->stopped should be initialized at the end of the function. Signed-off-by: Jingjing Wu

[PATCH v7 08/19] common/idpf: support get packet type

2023-02-05 Thread beilei . xing
From: Beilei Xing Move ptype_tbl field to idpf_adapter structure. Move get_pkt_type to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 216 +++ drivers/common/idpf/idpf_common_device.h | 7 + drivers/common/idpf/meson.build

[PATCH v7 09/19] common/idpf: add vport info initialization

2023-02-05 Thread beilei . xing
From: Beilei Xing Move queue module fields from idpf_adapter_ext structure to idpf_adapter structure. Refine some parameter and function name, and move function idpf_create_vport_info_init to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 36 ++

[PATCH v7 10/19] common/idpf: add vector flags in vport

2023-02-05 Thread beilei . xing
From: Beilei Xing Move vector flags from idpf_adapter_ext structure to idpf_vport structure. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/net/idpf/idpf_ethdev.h | 5 - drivers/net/idpf/idpf_rxtx.c | 22 ++

[PATCH v7 11/19] common/idpf: add rxq and txq struct

2023-02-05 Thread beilei . xing
From: Beilei Xing Add idpf_rxq and idpf_txq structure in common module. Move idpf_vc_config_rxq and idpf_vc_config_txq functions to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 2 + drivers/common/idpf/idpf_common_rxtx.h | 112 +

[PATCH v7 12/19] common/idpf: add help functions for queue setup and release

2023-02-05 Thread beilei . xing
From: Beilei Xing Refine rxq setup and txq setup. Move some help functions of queue setup and queue release to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c | 414 + drivers/common/idpf/idpf_common_rxtx.h | 57 ++ drivers/common/idpf/meson.bu

[PATCH v7 14/19] common/idpf: add vec queue setup

2023-02-05 Thread beilei . xing
From: Beilei Xing Move vector queue setup for single queue model to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c | 57 ++ drivers/common/idpf/idpf_common_rxtx.h | 2 + drivers/common/idpf/version.map| 1 + drivers/net/id

[PATCH v7 13/19] common/idpf: add Rx and Tx data path

2023-02-05 Thread beilei . xing
From: Beilei Xing Add timestamp filed to idpf_adapter structure. Move scalar Rx/Tx data path for both single queue and split queue to common module. Signed-off-by: Mingxia Liu Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.h | 5 + drivers/common/idpf/idpf_common_logs

[PATCH v7 15/19] common/idpf: add avx512 for single queue model

2023-02-05 Thread beilei . xing
From: Beilei Xing Move avx512 vector path for single queue to common module. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.h| 20 ++ .../idpf/idpf_common_rxtx_avx512.c} | 6 ++--- drivers/common/idpf/meson.build | 27 ++

[PATCH v7 16/19] common/idpf: refine API name for vport functions

2023-02-05 Thread beilei . xing
From: Beilei Xing This patch refines API name for all vport related functions. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 8 drivers/common/idpf/idpf_common_device.h | 10 +- drivers/common/idpf/version.map | 14 -- drivers/

[PATCH v7 17/19] common/idpf: refine API name for queue config module

2023-02-05 Thread beilei . xing
From: Beilei Xing This patch refines API name for queue config functions. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c| 42 drivers/common/idpf/idpf_common_rxtx.h| 38 +++--- drivers/common/idpf/idpf_common_rxtx_avx512.c | 2 +-

[PATCH v7 18/19] common/idpf: refine API name for data path module

2023-02-05 Thread beilei . xing
From: Beilei Xing Refine API name for all data path functions. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_rxtx.c| 20 ++-- drivers/common/idpf/idpf_common_rxtx.h| 32 +-- drivers/common/idpf/idpf_common_rxtx_avx512.c | 8 ++--- drive

[PATCH v7 19/19] common/idpf: refine API name for virtual channel functions

2023-02-05 Thread beilei . xing
From: Beilei Xing This patch refines API name for all virtual channel functions. Signed-off-by: Beilei Xing --- drivers/common/idpf/idpf_common_device.c | 24 drivers/common/idpf/idpf_common_virtchnl.c | 70 +++--- drivers/common/idpf/idpf_common_virtchnl.h | 36

RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle

2023-02-05 Thread Xing, Beilei
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, February 6, 2023 10:59 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org > Subject: RE: [PATCH v6 00/19] net/idpf: introduce idpf common modle > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Friday

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-05 Thread Naga Harish K, S V
Hi Jerin, > -Original Message- > From: Jerin Jacob > Sent: Friday, February 3, 2023 3:15 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get

[PATCH] net/ice: fix get link status timeout

2023-02-05 Thread Mingjin Ye
When hw is just started, it will immediately obtain the link status, and the longest attempt is 1 second. Some NICs are slow to initialize, which make it fails to obtain the link status. The patch fixes this issue by modifying the longest attempt to 5 seconds. Fixes: cf911d90e366 ("net/ice: suppo

[PATCH 0/3] cleanup the PMD

2023-02-05 Thread Chaoyong He
This patch series aims to better align the PMD with the preferred DPDK coding style. - Remove the usage of 'printf()' - Remove the unneeded header file includes - Explicitly compare pointer with NULL - Explicitly compare integer with 0 James Hershaw (3): net/nfp: remove usage of print statements

[PATCH 1/3] net/nfp: remove usage of print statements

2023-02-05 Thread Chaoyong He
From: James Hershaw Removal of the usage of printf() statements from the nfp PMD in favour of appropriate RTE logging functions in compliance with the standard. Debug messages are now logged using the appropriate RTE_LOG functions so it is no longer necessary to print specific statements when co

[PATCH 2/3] net/nfp: remove unnecessary include

2023-02-05 Thread Chaoyong He
From: James Hershaw Remove inclusion of rte_string_fns.h as the utility functions provided are no longer used in the PMD. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_common.c | 1 - drivers/net/nfp/nfpcore/nfp_cpp_

[PATCH 3/3] net/nfp: explicitly compare to null and 0

2023-02-05 Thread Chaoyong He
From: James Hershaw Removal of the '!' character when comparing variables in favour of explicitly comparing the variable to either 'NULL' or '0', in compliance with the standard. Signed-off-by: James Hershaw Reviewed-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/nfp_commo

Re: [PATCH] net/ice: fix get link status timeout

2023-02-05 Thread Thomas Monjalon
06/02/2023 07:22, Mingjin Ye: > When hw is just started, it will immediately obtain the link status, and > the longest attempt is 1 second. Some NICs are slow to initialize, which > make it fails to obtain the link status. > > The patch fixes this issue by modifying the longest attempt to 5 second

Re: [PATCH v2 2/2] lib/net: added push MPLS header API

2023-02-05 Thread Thomas Monjalon
18/12/2022 00:31, Tanzeel-inline: > The mpls hdr can't be const because the bs bit is updated by checking ether > type. > > v2: > * marked experimental > * trailing blanks removed > * space after /* and before */ > * updated to bracket cuddle style > * changed rte_memcpy to memcpy This patch is

RE: [PATCH v8 2/5] eal: report applications lcore usage

2023-02-05 Thread Morten Brørup
> From: fengchengwen [mailto:fengcheng...@huawei.com] > Sent: Monday, 6 February 2023 05.00 > > Hi Robin, > > On 2023/2/2 21:43, Robin Jarry wrote: > > Allow applications to register a callback that will be invoked in > > rte_lcore_dump() and when requesting lcore info in the telemetry API. > > >

Re: [PATCH] sched: fix for demo failure in debug mode

2023-02-05 Thread Thomas Monjalon
> > This issue is happening due to non-initialization of some > > fields in “rte_eth_rxconf” structure in our application. > > Doing a memset to zero before initialization in HQoS application. > > > > Signed-off-by: Megha Ajmera > > --- > > examples/qos_sched/init.c | 2 ++ > > 1 file changed, 2

Re: [PATCH] sched: fix for tc_ov_enable flag position in subport structure.

2023-02-05 Thread Thomas Monjalon
10/01/2023 12:27, David Marchand: > On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera wrote: > > > > Current position of "tv_ov_enable" variable in > > tc_ov_enabled* > > > > rte_sched_subport structure makes the "memory" variable unused. > > I did not enter the beast... but my understanding is that

Re: [PATCH] usertools: fix python warnings

2023-02-05 Thread Thomas Monjalon
09/01/2023 18:07, Stephen Hemminger: > This fixes most of the flake8 style warnings on the telemetry > script. > > Signed-off-by: Stephen Hemminger Applied, thanks.

Re: [PATCH] net/ice: fix get link status timeout

2023-02-05 Thread 韩爽
> -Original Message- > From: Thomas Monjalon > Sent: Monday, February 06, 2023 3:23 PM > To: Mingjin Ye > Cc: dev@dpdk.org; sta...@dpdk.org; yidingx.z...@intel.com; Qiming Yang > ; Qi Zhang ; Mingjin Ye > ; david.march...@redhat.com; > ferruh.yi...@amd.com > Subject: Re: [PATCH] net/ice