phir for merging both v3's.
Ferruh, v4 supersedes all prior revisions (Moti's v1, Matan's v2, my own v3
and Ophir's v3-bis, I can't update patchwork for all of them).
For the entire series:
Acked-by: Adrien Mazarguil
--
Adrien Mazarguil
6WIND
On Fri, Oct 06, 2017 at 02:13:14AM +0100, Ferruh Yigit wrote:
> On 10/5/2017 10:49 AM, Adrien Mazarguil wrote:
> > This series brings enhancements to various rte_flow helpers:
> >
> > - Allow applications to use rte_flow_error_set() by making it part of the
> > publi
As for the testpmd flow command which uses uint16_t since the beginning by
chance, switch to portid_t for consistency.
Fixes: 14ab03825b1d ("ethdev: increase port id range")
Cc: Zhiyong Yang
Signed-off-by: Adrien Mazarguil
---
app/test-pmd/cmdline_flow.c | 6 +++---
lib/li
tion for the time being is to not describe what happens when
several MTR actions are provided. We'll keep this for the next overhaul of
rte_flow (some other changes are already planned).
[1] http://dpdk.org/doc/guides/prog_guide/rte_flow.html#actions
--
Adrien Mazarguil
6WIND
+ .next = NEXT(action_meter, NEXT_ENTRY(UNSIGNED)),
> + .args = ARGS(ARGS_ENTRY(struct rte_flow_action_meter, mtr_id)),
> + .call = parse_vc_conf,
> + },
> };
Acked-by: Adrien Mazarguil
One remaining minor comment:
> diff --git a/app/test-pmd/cmdline_mtr.h b/app/test-pmd/cmdline_mtr.h
> +#endif /* _CMDLINE_MTR_H_ */
> \ No newline at end of file
Make sure to add this missing new line for the next iteration.
--
Adrien Mazarguil
6WIND
doc mention on multiple MTR objects for same flow.
Acked-by: Adrien Mazarguil
--
Adrien Mazarguil
6WIND
3
> - Later this patchset on top of it
> - Later Raslan's on top of yours
>
> With multiple developers working on same drivers, mlx drivers become
> hard to manage/trace.
>
> next-net-mlx sound like good idea :) Any comment on this?
Sounds good to me too, particularly so
On Tue, Oct 10, 2017 at 07:05:30PM +0100, Ferruh Yigit wrote:
> On 10/6/2017 9:05 AM, Adrien Mazarguil wrote:
> > On Fri, Oct 06, 2017 at 02:13:14AM +0100, Ferruh Yigit wrote:
> >> On 10/5/2017 10:49 AM, Adrien Mazarguil wrote:
> >>> This series brings enhancemen
On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote:
> 05/10/2017 11:49, Adrien Mazarguil:
> > rte_flow_error_set() is a convenient helper to initialize error objects.
> >
> > Since there is no fundamental reason to prevent applications from using it,
> > e
footprint.
Note that it should be applied directly before the following series:
"new mlx4 datapath bypassing ibverbs"
For which a new version based on top of this one will be submitted soon.
Adrien Mazarguil (29):
ethdev: expose flow API error helper
net/mlx4: replace bit-f
public interface.
Documentation is updated accordingly.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/prog_guide/rte_flow.rst | 23 +++--
drivers/net/mlx4/mlx4_flow.c| 6 ++--
drivers/net/tap/tap_flow.c | 2 +-
lib
Make clear it's 32-bit wide.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
index 9bd2acc..71cbced 100644
--- a/drivers/net
There is no benefit in having this as a separate function.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 59
1 file changed, 18 insertions(+), 41 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_rxq.c b
Add missing comments and fix those not Doxygen-friendly.
Since the private structure definition is modified, use this opportunity to
add one remaining missing include required by one of its fields
(sys/queue.h for LIST_HEAD()).
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
This PMD supports up to 4096 flow rule priority levels (0 to 4095).
Applications were not allowed to use them until now due to overlaps with
the default flows (e.g. MAC address, promiscuous mode).
This is not an issue in isolated mode when such flows do not exist.
Signed-off-by: Adrien
commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 171 ++
drivers/net/mlx4/mlx4_flow.h | 2 +-
2 files changed, 81 insertions(+), 92 deletions(-)
diff --git a/drive
on action configuration structure.
This commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 115 ++
1 file changed, 53 insertions(+), 62 deletions(-)
diff --git a/drivers
yet.
This commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 102 --
1 file changed, 42 insertions(+), 60 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers
= ptr_a;
a->b = ptr_b;
a->c = ptr_c;
a->b->d = ptr_d;
...
rte_free(a);
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
lib/librte_eal/bsdapp/eal/rte_eal_version.map | 9 ++
lib/librte_eal/common/include/rte_malloc.h | 85 ++
lib/li
other properties, making it more versatile
without increasing its size (at least on 64-bit platforms).
This commit also gets rid of a few unnecessary debugging messages.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 300
affected ones drop-like, i.e. rules targeting
nonexistent queues drop packets instead.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/net/mlx4
.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c | 20 ++---
drivers/net/mlx4/mlx4.h | 1 -
drivers/net/mlx4/mlx4_flow.c | 155 +++---
drivers/net/mlx4/mlx4_flow.h | 6 ++
drivers/net/mlx4/mlx4_rxq.c | 117
ot;).
As a reminder, the outcome of overlapping rules for a given priority level
was, and still is, undefined territory according to API documentation.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 34 ++
1 file chan
reporting
as the inability to start the device due to a problem with a flow rule
otherwise results in a nondescript error code.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c | 25 -
drivers/net/mlx4/mlx4_flow.c | 76
st be matched exactly, as matching all VLAN traffic while
excluding non-VLAN traffic is not supported.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 576 +++---
drivers/net/mlx4/mlx4_flow.h | 1 +
2 files change
-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4.c | 7 ++-
drivers/net/mlx4/mlx4.h | 10 +++-
drivers/net/mlx4/mlx4_ethdev.c| 87 +++-
drivers/net/mlx4/mlx4_flow.c | 90
filters though.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4.c | 1 +
drivers/net/mlx4/mlx4.h | 1 +
drivers/net/mlx4/mlx4_ethdev.c| 42 +
drivers/net/mlx4/mlx4_flow.c
Give users the ability to create flow rules that match all multicast
traffic. Like promiscuous flow rules, they come with restrictions such as
not allowing additional matching criteria.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1
Implement promiscuous and all multicast through internal flow rules
automatically generated according to the configured mode.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 2 +
drivers/net/mlx4/mlx4.c | 4 ++
drivers/net/mlx4
nge is not necessary as bringing the
netdevice down is normally enough to prevent traffic from flowing in.
Fixes: a4951cb98fdf ("net/mlx4: drop scatter/gather support")
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c| 11 ---
drive
Tx queue elements allocation function sets rte_errno properly and returns
its negative version. Reassigning this value to rte_errno is thus both
invalid and unnecessary.
Fixes: c3e1f93cdf88 ("net/mlx4: standardize on negative errno values")
Signed-off-by: Adrien Mazarguil
Acked
Since live Tx and Rx queues cannot be reused anymore without being
destroyed first, mbuf ring sizes are fixed and known from the start.
This allows a single allocation for queue data structures and mbuf ring
together, saving space and bringing them closer in memory.
Signed-off-by: Adrien
simplifies the code as allocation and setup steps
and checks can be merged.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 281 ++
drivers/net/mlx4/mlx4_rxtx.h | 2 -
drivers/net/mlx4/mlx4_txq.c | 239
ks for RSS support brought
by subsequent commits, as a single "hash" QP can manage several WQs through
an indirection table according to a hash algorithm and other parameters.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 3 ++
drivers/net/m
Device operation callbacks are not supposed to handle a missing private
data structure.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4
When part of the RSS hash calculation, UDP packets are discarded (not
received on any queue) likely due to an issue with the kernel
implementation.
Temporarily disable UDP RSS support until this issue is resolved.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4
: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/Makefile | 2 +-
drivers/net/mlx4/mlx4.c | 13 ++
drivers/net/mlx4/mlx4.h | 2 +
drivers/net/mlx4/mlx4_ethdev.c| 1 +
drivers/net/mlx4/mlx4_flow.c
configured queues is rounded down to its previous
power of two; extra queues are silently discarded. This does not prevent
dedicated flow rules from targeting them.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 24
1 file
.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 3 +-
drivers/net/mlx4/mlx4_flow.c | 138 --
2 files changed, 74 insertions(+), 67 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
index
Hopefully the last iteration for this series.
v5 (Ophir & Adrien):
- Merged Rx scatter/Tx gather code back into individual Rx/Tx commits
for consistency due to a couple of issues with gather-less Tx.
- Rebased on top of the latest mlx4 control path changes (RSS support).
v4 (Ophir):
- Split "ne
when setting the report-completion flag of the chip.
Signed-off-by: Moti Haimovsky
Signed-off-by: Ophir Munk
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_prm.h | 120
drivers/net/mlx4/mlx4_rxtx.c | 398 --
drivers/net/mlx4/mlx4_rxtx.h
Philipov
Signed-off-by: Moti Haimovsky
Signed-off-by: Ophir Munk
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_rxq.c | 151 +
drivers/net/mlx4/mlx4_rxtx.c | 226 +-
drivers/net/mlx4/mlx4_rxtx.h | 19 ++--
3 files changed, 241
From: Moti Haimovsky
This patch adds hardware offloading support for IPv4, UDP and TCP checksum
calculation, including inner/outer checksums on supported tunnel types.
Signed-off-by: Moti Haimovsky
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4.c| 11 +++
drivers/net
From: Moti Haimovsky
This patch adds loopback functionality used when the chip is a VF in order
to enable packet transmission between VFs and PF.
Signed-off-by: Moti Haimovsky
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_rxtx.c | 33 +
drivers/net/mlx4
: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_ethdev.c | 6 +-
drivers/net/mlx4/mlx4_prm.h| 29 +
drivers/net/mlx4/mlx4_rxq.c| 5 ++
drivers/net/mlx4/mlx4_rxtx.c | 118 +++-
drivers/net/mlx4/mlx4_rxtx.h | 2 +
5 files changed, 157 insertions
On Wed, Oct 11, 2017 at 10:58:45PM +0100, Ferruh Yigit wrote:
> On 10/11/2017 3:35 PM, Adrien Mazarguil wrote:
> > These wrappers implement the ability to allocate room for several disparate
> > objects as a single contiguous allocation while complying with their
> >
public interface.
Documentation is updated accordingly.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/prog_guide/rte_flow.rst | 23 +++--
drivers/net/mlx4/mlx4_flow.c| 6 ++--
drivers/net/tap/tap_flow.c | 2 +-
lib
latest dpdk-next-net.
Adrien Mazarguil (29):
ethdev: expose flow API error helper
net/mlx4: replace bit-field type
net/mlx4: remove Rx QP initializer function
net/mlx4: enhance header files comments
net/mlx4: expose support for flow rule priorities
net/mlx4: clarify flow objects nami
Make clear it's 32-bit wide.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
index 9bd2acc..71cbced 100644
--- a/drivers/net
There is no benefit in having this as a separate function.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 59
1 file changed, 18 insertions(+), 41 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_rxq.c b
Add missing comments and fix those not Doxygen-friendly.
Since the private structure definition is modified, use this opportunity to
add one remaining missing include required by one of its fields
(sys/queue.h for LIST_HEAD()).
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
This PMD supports up to 4096 flow rule priority levels (0 to 4095).
Applications were not allowed to use them until now due to overlaps with
the default flows (e.g. MAC address, promiscuous mode).
This is not an issue in isolated mode when such flows do not exist.
Signed-off-by: Adrien
commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 171 ++
drivers/net/mlx4/mlx4_flow.h | 2 +-
2 files changed, 81 insertions(+), 92 deletions(-)
diff --git a/drive
on action configuration structure.
This commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 115 ++
1 file changed, 53 insertions(+), 62 deletions(-)
diff --git a/drivers
yet.
This commit does not cause any functional change.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 102 --
1 file changed, 42 insertions(+), 60 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers
= ptr_a;
a->b = ptr_b;
a->c = ptr_c;
a->b->d = ptr_d;
...
rte_free(a);
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_utils.c | 151 +
drivers/net/mlx4/mlx4_utils.h | 15
2 files changed, 166 inserti
other properties, making it more versatile
without increasing its size (at least on 64-bit platforms).
This commit also gets rid of a few unnecessary debugging messages.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 300
.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 3 +-
drivers/net/mlx4/mlx4_flow.c | 138 --
2 files changed, 74 insertions(+), 67 deletions(-)
diff --git a/drivers/net/mlx4/mlx4.h b/drivers/net/mlx4/mlx4.h
index
affected ones drop-like, i.e. rules targeting
nonexistent queues drop packets instead.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/drivers/net/mlx4
ot;).
As a reminder, the outcome of overlapping rules for a given priority level
was, and still is, undefined territory according to API documentation.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 34 ++
1 file chan
.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c | 20 ++---
drivers/net/mlx4/mlx4.h | 1 -
drivers/net/mlx4/mlx4_flow.c | 155 +++---
drivers/net/mlx4/mlx4_flow.h | 6 ++
drivers/net/mlx4/mlx4_rxq.c | 117
reporting
as the inability to start the device due to a problem with a flow rule
otherwise results in a nondescript error code.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c | 25 -
drivers/net/mlx4/mlx4_flow.c | 76
-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4.c | 7 ++-
drivers/net/mlx4/mlx4.h | 10 +++-
drivers/net/mlx4/mlx4_ethdev.c| 87 +++-
drivers/net/mlx4/mlx4_flow.c | 90
filters though.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4.c | 1 +
drivers/net/mlx4/mlx4.h | 1 +
drivers/net/mlx4/mlx4_ethdev.c| 42 +
drivers/net/mlx4/mlx4_flow.c
st be matched exactly, as matching all VLAN traffic while
excluding non-VLAN traffic is not supported.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 576 +++---
drivers/net/mlx4/mlx4_flow.h | 1 +
2 files change
Give users the ability to create flow rules that match all multicast
traffic. Like promiscuous flow rules, they come with restrictions such as
not allowing additional matching criteria.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1
Implement promiscuous and all multicast through internal flow rules
automatically generated according to the configured mode.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 2 +
drivers/net/mlx4/mlx4.c | 4 ++
drivers/net/mlx4
nge is not necessary as bringing the
netdevice down is normally enough to prevent traffic from flowing in.
Fixes: a4951cb98fdf ("net/mlx4: drop scatter/gather support")
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c| 11 ---
drive
Tx queue elements allocation function sets rte_errno properly and returns
its negative version. Reassigning this value to rte_errno is thus both
invalid and unnecessary.
Fixes: c3e1f93cdf88 ("net/mlx4: standardize on negative errno values")
Signed-off-by: Adrien Mazarguil
Acked
simplifies the code as allocation and setup steps
and checks can be merged.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 281 ++
drivers/net/mlx4/mlx4_rxtx.h | 2 -
drivers/net/mlx4/mlx4_txq.c | 239
Since live Tx and Rx queues cannot be reused anymore without being
destroyed first, mbuf ring sizes are fixed and known from the start.
This allows a single allocation for queue data structures and mbuf ring
together, saving space and bringing them closer in memory.
Signed-off-by: Adrien
Device operation callbacks are not supposed to handle a missing private
data structure.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_ethdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_ethdev.c b/drivers/net/mlx4
ks for RSS support brought
by subsequent commits, as a single "hash" QP can manage several WQs through
an indirection table according to a hash algorithm and other parameters.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.h | 3 ++
drivers/net/m
: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/Makefile | 2 +-
drivers/net/mlx4/mlx4.c | 13 ++
drivers/net/mlx4/mlx4.h | 2 +
drivers/net/mlx4/mlx4_ethdev.c| 1 +
drivers/net/mlx4/mlx4_flow.c
When part of the RSS hash calculation, UDP packets are discarded (not
received on any queue) likely due to an issue with the kernel
implementation.
Temporarily disable UDP RSS support until this issue is resolved.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4
configured queues is rounded down to its previous
power of two; extra queues are silently discarded. This does not prevent
dedicated flow rules from targeting them.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 24
1 file
when setting the report-completion flag of the chip.
Signed-off-by: Moti Haimovsky
Signed-off-by: Ophir Munk
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_prm.h | 120
drivers/net/mlx4/mlx4_rxtx.c | 398 --
drivers/net/mlx4/mlx4_rxtx.h
Philipov
Signed-off-by: Moti Haimovsky
Signed-off-by: Ophir Munk
Acked-by: Adrien Mazarguil
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4_rxq.c | 151 +++---
drivers/net/mlx4/mlx4_rxtx.c | 226 +++--
drivers/net/mlx4
From: Moti Haimovsky
This patch adds hardware offloading support for IPv4, UDP and TCP checksum
calculation, including inner/outer checksums on supported tunnel types.
Signed-off-by: Moti Haimovsky
Acked-by: Adrien Mazarguil
---
doc/guides/nics/features/mlx4.ini | 4
drivers/net/mlx4
Hopefully the last iteration for this series.
v6 (Adrien):
- Updated features documentation (mlx4.ini) in the relevant patches.
- Rebased on the latest changes brought by RSS support v2 series.
v5 (Ophir & Adrien):
- Merged Rx scatter/Tx gather code back into individual Rx/Tx commits
for consis
From: Moti Haimovsky
This patch adds loopback functionality used when the chip is a VF in order
to enable packet transmission between VFs and PF.
Signed-off-by: Moti Haimovsky
Acked-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_rxtx.c | 33 +
drivers/net/mlx4
: Adrien Mazarguil
---
doc/guides/nics/features/mlx4.ini | 1 +
drivers/net/mlx4/mlx4_ethdev.c| 6 +-
drivers/net/mlx4/mlx4_prm.h | 29
drivers/net/mlx4/mlx4_rxq.c | 5 ++
drivers/net/mlx4/mlx4_rxtx.c | 118 -
drivers/net/mlx4
On Wed, Oct 11, 2017 at 07:07:29PM +0100, Ferruh Yigit wrote:
> On 10/11/2017 10:57 AM, Adrien Mazarguil wrote:
> > On Tue, Oct 10, 2017 at 07:05:30PM +0100, Ferruh Yigit wrote:
> >> After above said, API changes one week before integration deadline, a
> >> new
On Wed, Oct 11, 2017 at 03:05:47PM -0400, Aaron Conole wrote:
> Adrien Mazarguil writes:
>
> > On Wed, Oct 11, 2017 at 11:23:12AM +0200, Thomas Monjalon wrote:
> >> 05/10/2017 11:49, Adrien Mazarguil:
> >> > rte_flow_error_set() is a convenient h
urious about
the reasons that made it hard to implement as a RTE_FLOW_ITEM_RAW thing?
(e.g. a rule with a pattern that only contains one or several such items)
Please have a look at the rte_flow_item_raw structure in rte_flow.h, tell me
what's missing in there and I'll take it into account during the next
overhaul. Thanks in advance for your feedback.
--
Adrien Mazarguil
6WIND
ld-initializers]
[...]/mlx4_txq.c: In function `mlx4_tx_queue_setup':
[...]/mlx4_txq.c:265:3: error: missing initializer for field `opackets' of
`struct mlx4_txq_stats' [-Werror=missing-field-initializers]
Fixes: 79770826499b ("net/mlx4: drop live queue reconfiguration support")
On Thu, Oct 12, 2017 at 05:37:41PM +0100, Ferruh Yigit wrote:
> On 10/12/2017 1:53 PM, Adrien Mazarguil wrote:
> > On Wed, Oct 11, 2017 at 07:07:29PM +0100, Ferruh Yigit wrote:
> >> On 10/11/2017 10:57 AM, Adrien Mazarguil wrote:
> >>> On Tue, Oct 10, 2017 at 07:05:
This series enforces WQ creation order to make sure WQNs are assigned
sequentially to Rx queues and fixes a few minor issues related to
initialization code.
This addresses l3fwd-power startup issues.
Adrien Mazarguil (4):
net/mlx4: use dedicated list iterator
net/mlx4: fix useless flow rules
Dumb unconditional iteration on flow rules should be performed using the
dedicated macro.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_flow.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers
ned-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_rxq.c b/drivers/net/mlx4/mlx4_rxq.c
index 6fa48bc..65cf123 100644
--- a/drivers/net/mlx4/mlx4_r
ssing.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support")
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4_rxq.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_rxq.c b/d
configured in order to address this issue.
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
drivers/net/mlx4/mlx4.c | 23 +--
drivers/net/mlx4/mlx4_rxq.c | 357 +-
drivers/net/mlx4/mlx4_rxtx.h | 5 +
3 files changed, 288 insertions(+), 97
code")
Signed-off-by: Adrien Mazarguil
---
drivers/net/mlx4/mlx4_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 5af6efb..a0f431b 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/driver
't be statically initialized.
Both can be overcome by relying on compiler extensions, however their use
should be restricted to a minimum in public APIs for portability reasons.
[1] http://dpdk.org/ml/archives/dev/2018-April/095307.html
--
Adrien Mazarguil
6WIND
build", handled by prior commit
d9736a248785 ("ethdev: fix library version in meson build").
v2 changes:
- mlx5 fix (patch #3).
- bnxt fix (patch #4).
- sfc fix (patch #6).
- Missing include (patch #13).
Adrien Mazarguil (11):
net/mlx4: fix RSS resource leak in case of error
When memory cannot be allocated for a flow rule, its RSS context reference
is not dropped.
Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Shahaf Shuler
---
drivers/net/mlx4/mlx4_flow.c | 5 -
1 file
d RSS flow rule action support")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Shahaf Shuler
---
drivers/net/mlx4/mlx4_flow.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index a3b4480b4.
The number of queues provided by the application is not checked against
parser's supported maximum.
Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule")
Cc: sta...@dpdk.org
Cc: Nelio Laranjeiro
Signed-off-by: Adrien Mazarguil
Acked-by: Nelio Laranjeiro
---
d
Some values are interpreted without endian conversion and/or without
taking the proper mask into account.
Fixes: 5ef3b79fdfe6 ("net/bnxt: support flow filter ops")
Cc: sta...@dpdk.org
Cc: Ajit Khaparde
Signed-off-by: Adrien Mazarguil
---
drivers/net/bnxt/bnxt_filter.c | 14 +++
The lack of a working completion for RSS queues was overlooked during
development; until now only "end" was displayed as a valid token.
Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command")
Cc: sta...@dpdk.org
Signed-off-by: Adrien Mazarguil
Cc: Wenzhuo
401 - 500 of 1364 matches
Mail list logo
