[PATCH] net/bonding: fix bond4 drop valid MAC packets

2022-10-18 Thread Huisong Li
Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 33 +++--- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 27005c747c..e2326883de 1006

[PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

2022-10-20 Thread Huisong Li
ts this behavior. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) --- v5: - merge the second patch into the first patch. - add error log when rollback failed. v4: - fix broken in the patchwork

[PATCH] net/bonding: fix slave device Rx/Tx offload configuration

2022-10-27 Thread Huisong Li
within the offload configurations of bond interface. Fixes: 57b156540f51 ("net/bonding: fix offloading configuration") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bonding/rte_eth_bond_pmd.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) di

[PATCH] app/testpmd: update bond port configurations when add slave

2022-10-27 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- app/test-pmd/test

[PATCH V2] app/testpmd: update bond port configurations when add slave

2022-10-27 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- - v2: fix a spelling

[PATCH V3] app/testpmd: update bond port configurations when add slave

2022-10-28 Thread Huisong Li
cause failure when re-initialize bonding device. So port configurations of bonding device also need to be updated because of the added and removed capabilities. In addition, this also helps to ensure consistency between testpmd and bonding device. Signed-off-by: Huisong Li --- - v3: fix code co

[PATCH V5 0/5] app/testpmd: support multiple process attach and detach port

2023-01-30 Thread Huisong Li
for other bus type. #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers/bus: restore driver assignment at front of probing ethdev: fix skip valid port in probing ca

[PATCH V5 2/5] ethdev: fix skip valid port in probing callback

2023-01-30 Thread Huisong Li
be8cd210379a ("ethdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_driver.h | 12

[PATCH V5 1/5] drivers/bus: restore driver assignment at front of probing

2023-01-30 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH V5 3/5] app/testpmd: check the validity of the port

2023-01-30 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[PATCH V5 4/5] app/testpmd: add attach and detach port for multiple process

2023-01-30 Thread Huisong Li
state is changed from 'ATTACHED' to 'UNUSED' only after the event callback finished. But the remove_invalid_ports() function removes invalid port only if ethdev state is 'UNUSED'. If we don't add alarm callback, this detached port information can not be removed. Sig

[PATCH V5 5/5] app/testpmd: stop forwarding in new or destroy event

2023-01-30 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff

[PATCH V6] ethdev: fix one address occupies two entries in MAC addrs

2023-01-30 Thread Huisong Li
default address is removed from the rest of the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v6: fix commit log and some code comments.

[PATCH V7] ethdev: fix one address occupies two entries in MAC addrs

2023-02-01 Thread Huisong Li
default address is removed from the rest of the list if the address was already in the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v7: add announcement in the release notes and docum

[PATCH V8] ethdev: fix one address occupies two entries in MAC addrs

2023-02-02 Thread Huisong Li
the new default address is removed from the rest of the list if the address was already in the list. Fixes: 854d8ad4ef68 ("ethdev: add default mac address modifier") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- v8: fix some comments. v7: add announcemen

[dpdk-dev] [PATCH V2 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-20 Thread Huisong Li
port stop all port config 0 dcb vt off 4 pfc on port start all port stop all port config all rxq 8 port config all txq 8 Fixes: 900550de04a7 ("app/testpmd: add dcb support") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/con

[dpdk-dev] [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-20 Thread Huisong Li
b support") Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/config.c b/

[dpdk-dev] [PATCH V2 0/7] modifications about DCB forwarding configuration

2021-04-20 Thread Huisong Li
start port - remove redundant fwd streams initialization --- V1->V2 - remove patch "app/testpmd: use of Rx/Tx in testpmd" - fix patch title - remove dcb_test - add some new adjustments --- Huisong Li (7): app/testpmd: fix forward lcores number when DCB test app/testpmd: fix D

[dpdk-dev] [PATCH V2 7/7] app/testpmd: remove redundant fwd streams initialization

2021-04-20 Thread Huisong Li
The fwd_config_setup() is called after init_fwd_streams(). The fwd_config_setup() will reinitialize forwarding streams. This patch removes init_fwd_streams() from init_config(). Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions

[dpdk-dev] [PATCH V2 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-20 Thread Huisong Li
st set to 1 first in init_port_dcb_config(), but the function may fail. So it should be moved to the end. Fixes: 900550de04a7 ("app/testpmd: add dcb support") Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and

[dpdk-dev] [PATCH V2 5/7] app/testpmd: move position of verifying DCB test

2021-04-20 Thread Huisong Li
nfig_setup(). Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 23 +-- app/test-pmd/testpmd.c | 19 --- 2 files changed, 21 insertions(+), 21 deletions(-) diff -

[dpdk-dev] [PATCH V2 4/7] app/testpmd: add check for support of reporting DCB info

2021-04-20 Thread Huisong Li
Currently, '.get_dcb_info' must be supported for the port doing DCB test, or all information in 'rte_eth_dcb_info' are zero. It should be prevented when user run cmd "port config 0 dcb vt off 4 pfc off". This patch adds the check for support of reporting dcb in

[dpdk-dev] [PATCH V2 6/7] app/testpmd: add forwarding config in start port

2021-04-20 Thread Huisong Li
cmd. The procedure is as follows: set nbcore 4 port stop all port config 0 dcb vt off 4 pfc on port start all show config fwd Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd

Re: [dpdk-dev] [PATCH 0/3] Fixes for testpmd

2021-04-20 Thread Huisong Li
Huisong Li (2): app/testpmd: fix forwarding configuration when DCB test app/testpmd: remove forwarding config from parsing Rx and Tx app/test-pmd/cmdline.c | 106 app/test-pmd/config.c | 147 + app/test-pmd

[dpdk-dev] [PATCH V3 0/7] modifications about DCB forwarding configuration

2021-04-20 Thread Huisong Li
start port - remove redundant fwd streams initialization --- V2->V3 - fix abnormal print information V1->V2 - remove patch "app/testpmd: use of Rx/Tx in testpmd" - fix patch title - remove dcb_test - add some new adjustments --- Huisong Li (7): app/testpmd: fix forward lc

[dpdk-dev] [PATCH V3 6/7] app/testpmd: add forwarding config in start port

2021-04-20 Thread Huisong Li
cmd. The procedure is as follows: set nbcore 4 port stop all port config 0 dcb vt off 4 pfc on port start all show config fwd Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd

[dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-20 Thread Huisong Li
port stop all port config 0 dcb vt off 4 pfc on port start all port stop all port config all rxq 8 port config all txq 8 Fixes: 900550de04a7 ("app/testpmd: add dcb support") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/con

[dpdk-dev] [PATCH V3 7/7] app/testpmd: remove redundant fwd streams initialization

2021-04-20 Thread Huisong Li
The fwd_config_setup() is called after init_fwd_streams(). The fwd_config_setup() will reinitialize forwarding streams. This patch removes init_fwd_streams() from init_config(). Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions

[dpdk-dev] [PATCH V3 4/7] app/testpmd: add check for support of reporting DCB info

2021-04-20 Thread Huisong Li
Currently, '.get_dcb_info' must be supported for the port doing DCB test, or all information in 'rte_eth_dcb_info' are zero. It should be prevented when user run cmd "port config 0 dcb vt off 4 pfc off". This patch adds the check for support of reporting dcb in

[dpdk-dev] [PATCH V3 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-20 Thread Huisong Li
b support") Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/config.c b/

[dpdk-dev] [PATCH V3 5/7] app/testpmd: move position of verifying DCB test

2021-04-20 Thread Huisong Li
nfig_setup(). Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 23 +-- app/test-pmd/testpmd.c | 19 --- 2 files changed, 21 insertions(+), 21 deletions(-) diff -

[dpdk-dev] [PATCH V3 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-20 Thread Huisong Li
st set to 1 first in init_port_dcb_config(), but the function may fail. So it should be moved to the end. Fixes: 900550de04a7 ("app/testpmd: add dcb support") Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and

Re: [dpdk-dev] [PATCH] app/testpmd: support the query of link flow ctrl info

2021-04-20 Thread Huisong Li
: Huisong Li This patch supports the query of the link flow control parameter on a port. The command format is as follows: show port flow_ctrl Signed-off-by: Huisong Li Signed-off-by: Min Hu (Connor) Hi Connor, Just a few minor comments, thanks, Kevin. --- app/test-pmd/cmdline.c

Re: [dpdk-dev] [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-27 Thread Huisong Li
在 2021/4/27 17:20, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, April 20, 2021 15:32 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun ; linux...@openeuler.org; lihuis...@huawei.com Subject: [PATCH V2 1/7] app/testpmd: fix forward lcores number when DCB test

Re: [dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-27 Thread Huisong Li
在 2021/4/27 19:19, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, April 20, 2021 17:01 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun ; linux...@openeuler.org; lihuis...@huawei.com Subject: [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test After

Re: [dpdk-dev] [PATCH V3 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-27 Thread Huisong Li
在 2021/4/27 18:59, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, April 20, 2021 17:01 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun ; linux...@openeuler.org; lihuis...@huawei.com Subject: [PATCH V3 2/7] app/testpmd: fix DCB forwarding configuration After DCB

Re: [dpdk-dev] [PATCH V3 6/7] app/testpmd: add forwarding config in start port

2021-04-27 Thread Huisong Li
在 2021/4/27 19:43, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, April 20, 2021 17:01 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun ; linux...@openeuler.org; lihuis...@huawei.com Subject: [PATCH V3 6/7] app/testpmd: add forwarding config in start port Most

Re: [dpdk-dev] [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-27 Thread Huisong Li
在 2021/4/28 10:02, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, April 27, 2021 22:11 To: Li, Xiaoyun ; dev@dpdk.org Cc: Yigit, Ferruh Subject: Re: [PATCH V3 3/7] app/testpmd: fix a segment fault when DCB test 在 2021/4/27 19:19, Li, Xiaoyun 写道: -Original

[dpdk-dev] [PATCH V4 7/7] app/testpmd: remove redundant fwd streams initialization

2021-04-27 Thread Huisong Li
The fwd_config_setup() is called after init_fwd_streams(). The fwd_config_setup() will reinitialize forwarding streams. This patch removes init_fwd_streams() from init_config(). Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/testpmd.c | 4 1 file changed, 4 deletions

[dpdk-dev] [PATCH V4 4/7] app/testpmd: add check for support of reporting DCB info

2021-04-27 Thread Huisong Li
Currently, '.get_dcb_info' must be supported for the port doing DCB test, or all information in 'rte_eth_dcb_info' are zero. It should be prevented when user run cmd "port config 0 dcb vt off 4 pfc off". This patch adds the check for support of reporting dcb in

[dpdk-dev] [PATCH V4 0/7] modifications about DCB forwarding configuration

2021-04-27 Thread Huisong Li
/Tx in testpmd" - fix patch title - remove dcb_test - add some new adjustments --- Huisong Li (7): app/testpmd: fix forward lcores number when DCB test app/testpmd: fix DCB forwarding configuration app/testpmd: fix a segment fault when DCB test app/testpmd: add check for support of

[dpdk-dev] [PATCH V4 6/7] app/testpmd: add forwarding configuration when config DCB

2021-04-27 Thread Huisong Li
This patch adds fwd_config_setup() at the end of cmd_config_dcb_parsed() to update "cur_fwd_config", so that the actual forwarding streams can be queried by the "show config fwd" cmd. Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/cmdline.c | 4 ++-

[dpdk-dev] [PATCH V4 5/7] app/testpmd: move position of verifying DCB test

2021-04-27 Thread Huisong Li
nfig_setup(). Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 23 +-- app/test-pmd/testpmd.c | 19 --- 2 files changed, 21 insertions(+), 21 deletions(-) diff -

[dpdk-dev] [PATCH V4 3/7] app/testpmd: fix a segment fault when DCB test

2021-04-27 Thread Huisong Li
port stop all port config 0 dcb vt off 4 pfc on port start all port stop all port config all rxq 8 port config all txq 8 Fixes: 900550de04a7 ("app/testpmd: add dcb support") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/con

[dpdk-dev] [PATCH V4 2/7] app/testpmd: fix DCB forwarding configuration

2021-04-27 Thread Huisong Li
the end of init_port_dcb_config() in case that ports fail to enter DCB mode. Fixes: 900550de04a7 ("app/testpmd: add dcb support") Fixes: ce8d561418d4 ("app/testpmd: add port configuration settings") Fixes: 7741e4cf16c0 ("app/testpmd: VMDq and DCB updates") Cc: s

[dpdk-dev] [PATCH V4 1/7] app/testpmd: fix forward lcores number when DCB test

2021-04-27 Thread Huisong Li
Cc: sta...@dpdk.org Signed-off-by: Huisong Li Signed-off-by: Lijun Ou --- app/test-pmd/config.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index a4445a7..39c0b80 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-04-29 Thread Huisong Li
在 2021/4/30 11:19, Li, Xiaoyun 写道: -Original Message- From: Min Hu (Connor) Sent: Wednesday, April 28, 2021 16:37 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH v2 1/2] app/testpmd: add link speed check before port start From: Huisong Li Currently, to check

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-05-03 Thread Huisong Li
在 2021/4/30 12:46, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Friday, April 30, 2021 12:04 To: Li, Xiaoyun Cc: Yigit, Ferruh ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start 在 2021/4/30 11:19, Li, Xiaoyun 写道

Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start

2021-05-05 Thread Huisong Li
在 2021/5/6 10:36, Li, Xiaoyun 写道: -Original Message- From: Huisong Li Sent: Tuesday, May 4, 2021 09:46 To: Li, Xiaoyun Cc: Yigit, Ferruh ; dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/2] app/testpmd: add link speed check before port start 在 2021/4/30 12:46, Li, Xiaoyun 写道

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-06-28 Thread Huisong Li
在 2021/6/14 23:37, Andrew Rybchenko 写道: Summary should start from "ethdev: " Don't forget to include all maintainers in Cc the next time. Just use --cc-cmd or --to-cmd options. ok, thanks! Adding Thomas. On 5/8/21 11:00 AM, Huisong Li wrote: Currently, if dev_configure is

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-03 Thread Huisong Li
v_data are initialized firstly in the probe phase. Do you mean to add clear this flag at the beginning of dev_configure()? That way SP can also figure out that device is not configured yet, etc. Thanks, Andrew. On 6/29/21 5:27 AM, Huisong Li wrote: 在 2021/6/14 23:37, Andrew Rybchenko 写道

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
dification fails in the dev_configure(). And it is set to 1 when dev_configure() is configured successfully. Please check the rollback. Thanks😁 That way SP can also figure out that device is not configured yet, etc. Thanks, Andrew. On 6/29/21 5:27 AM, Huisong Li wrote: 在 2021/6/14 23:

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-04 Thread Huisong Li
在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start successfully. This patch adds a "dev_configured" flag in "rte_eth_dev_data" to control whether dev_

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 19:22, Ananyev, Konstantin 写道: On 7/5/21 6:03 AM, Huisong Li wrote: 在 2021/7/3 19:04, Ananyev, Konstantin 写道: 在 2021/7/2 21:23, Ananyev, Konstantin 写道: On 7/2/2021 12:08 PM, Andrew Rybchenko wrote: @Thomas, @Ferruh, I tend to accept it (with minor style fixes), but I need your

Re: [dpdk-dev] [RFC] lib/ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
在 2021/7/5 17:50, Andrew Rybchenko 写道: Hi Huisong, On 7/5/21 9:07 AM, Thomas Monjalon wrote: 05/07/2021 05:18, Huisong Li: 在 2021/7/5 4:05, Thomas Monjalon 写道: 08/05/2021 10:00, Huisong Li: Currently, if dev_configure is not invoked or fails to be invoked, users can still invoke dev_start

[dpdk-dev] [PATCH V1] ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
nd does not call dev_configure(). These are done by the primary process and can be obtained or used by the secondary process. So this patch adds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started". Signed-off-by: Huisong Li --- lib/ethdev/rte_ethdev.c

[dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-05 Thread Huisong Li
nd does not call dev_configure(). These are done by the primary process and can be obtained or used by the secondary process. So this patch adds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started". Signed-off-by: Huisong Li --- v1 -> v2: - adjusting th

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-06 Thread Huisong Li
在 2021/7/6 16:36, Andrew Rybchenko 写道: @David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which is backward compatible with DPDK_21? On 7/6/21 7:10 AM, Huisong Li wrote

Re: [dpdk-dev] [PATCH V2] ethdev: add dev configured flag

2021-07-07 Thread Huisong Li
在 2021/7/7 16:25, Andrew Rybchenko 写道: On 7/7/21 5:55 AM, Huisong Li wrote: 在 2021/7/6 16:36, Andrew Rybchenko 写道: @David, could you take a look at the ABI breakage warnings for the patch. May we ignore it since ABI looks backward compatible? Or should be marked as a minor change ABI which

[dpdk-dev] [PATCH V3] ethdev: add dev configured flag

2021-07-07 Thread Huisong Li
nd does not call dev_configure(). These are done by the primary process and can be obtained or used by the secondary process. So this patch adds a "dev_configured" flag in "rte_eth_dev_data", like "dev_started". Signed-off-by: Huisong Li Reviewed-by: Andrew Rybchenko Ac

[PATCH v9 2/2] examples/l3fwd-power: add PM QoS configuration

2024-08-09 Thread Huisong Li
Add PM QoS configuration to declease the delay after sleep in case of entering deeper idle state. Signed-off-by: Huisong Li Acked-by: Morten Brørup --- examples/l3fwd-power/main.c | 24 1 file changed, 24 insertions(+) diff --git a/examples/l3fwd-power/main.c b

[PATCH v9 0/2] power: introduce PM QoS interface

2024-08-09 Thread Huisong Li
on CPU wide to replace the one on system wide Huisong Li (2): power: introduce PM QoS API on CPU wide examples/l3fwd-power: add PM QoS configuration doc/guides/prog_guide/power_man.rst| 24 ++ doc/guides/rel_notes/release_24_11.rst | 5 ++ examples/l3fwd-power/main.c|

[PATCH v9 1/2] power: introduce PM QoS API on CPU wide

2024-08-09 Thread Huisong Li
shallowest idle state to low the delay after sleep by setting strict resume latency (zero value). Signed-off-by: Huisong Li Acked-by: Morten Brørup --- doc/guides/prog_guide/power_man.rst| 24 ++ doc/guides/rel_notes/release_24_11.rst | 5 ++ lib/power/meson.build |

[dpdk-dev] [PATCH V2] ethdev: fix eth device released repeatedly

2021-10-12 Thread Huisong Li
USED after calling rte_eth_dev_close(). Use this state to avoid this problem. Signed-off-by: Huisong Li --- v1 -> v2: * fix the c

[dpdk-dev] [PATCH V3] ethdev: fix eth device released repeatedly

2021-10-14 Thread Huisong Li
released repeatedly. The state of the eth device is modified to RTE_ETH_DEV_UNUSED after rte_eth_dev_close(). So this state can be used to avoid this problem. Signed-off-by: Huisong Li --- v2 -> v3: * fix the commit log description and the comment inside the cod

[dpdk-dev] [PATCH V4] ethdev: fix eth device released repeatedly

2021-10-20 Thread Huisong Li
released repeatedly. The state of the eth device is modified to RTE_ETH_DEV_UNUSED after rte_eth_dev_close(). So this state can be used to avoid this problem. Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- v4: * add fixes line and stab

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-16 Thread Huisong Li
Hi, Thomas The new comments are as follows, and look forward to your reply. Thanks! 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling rte_eth_dev_close() will release resources of eth device and

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-16 Thread Huisong Li
在 2021/9/16 18:36, Thomas Monjalon 写道: 16/09/2021 10:01, Huisong Li: 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling rte_eth_dev_close() will release resources of eth device and close it. But

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-17 Thread Huisong Li
在 2021/9/17 20:50, Thomas Monjalon 写道: 17/09/2021 04:13, Huisong Li: 在 2021/9/16 18:36, Thomas Monjalon 写道: 16/09/2021 10:01, Huisong Li: 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7 16:53, Thomas Monjalon 写道: 07/09/2021 05:41, Huisong Li: Calling

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-17 Thread Huisong Li
Hi, All Can you take a look at this problem? Thanks. 在 2021/8/25 17:53, Huisong Li 写道: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 AM, Huisong Li wrote: 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-09-21 Thread Huisong Li
在 2021/9/20 22:07, Ferruh Yigit 写道: On 8/25/2021 10:53 AM, Huisong Li wrote: 在 2021/8/24 22:42, Ferruh Yigit 写道: On 8/19/2021 4:45 AM, Huisong Li wrote: 在 2021/8/18 19:24, Ferruh Yigit 写道: On 8/13/2021 9:16 AM, Huisong Li wrote: 在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/2021 04:11

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-09-22 Thread Huisong Li
在 2021/9/22 14:39, Andrew Rybchenko 写道: On 9/22/21 6:36 AM, Min Hu (Connor) wrote: From: Huisong Li Use the testpmd to perform the following operations: 1) mac_addr add 0 00:18:2D:00:00:90 2) mac_addr add 0 00:18:2D:00:00:91 3) mac_addr add 0 00:18:2D:00:00:92 4) mac_addr set 0 00:18:2D:00

Re: [dpdk-dev] [PATCH] ethdev: fix one MAC address occupies two index in mac addrs

2021-09-22 Thread Huisong Li
在 2021/9/22 16:02, Andrew Rybchenko 写道: On 9/22/21 10:43 AM, Huisong Li wrote: 在 2021/9/22 14:39, Andrew Rybchenko 写道: On 9/22/21 6:36 AM, Min Hu (Connor) wrote: From: Huisong Li Use the testpmd to perform the following operations: 1) mac_addr add 0 00:18:2D:00:00:90 2) mac_addr add 0 00

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-26 Thread Huisong Li
在 2021/9/18 16:46, Thomas Monjalon 写道: 18/09/2021 05:24, Huisong Li: 在 2021/9/17 20:50, Thomas Monjalon 写道: 17/09/2021 04:13, Huisong Li: 在 2021/9/16 18:36, Thomas Monjalon 写道: 16/09/2021 10:01, Huisong Li: 在 2021/9/8 15:20, Thomas Monjalon 写道: 08/09/2021 04:01, Huisong Li: 在 2021/9/7

Re: [dpdk-dev] [RFC V1] examples/l3fwd-power: fix memory leak for rte_pci_device

2021-09-26 Thread Huisong Li
在 2021/9/27 3:16, Thomas Monjalon 写道: 26/09/2021 14:20, Huisong Li: 在 2021/9/18 16:46, Thomas Monjalon 写道: 18/09/2021 05:24, Huisong Li: 在 2021/9/17 20:50, Thomas Monjalon 写道: 17/09/2021 04:13, Huisong Li: How should PMD free it? What should we do? Any good suggestions? Check that there

Re: [dpdk-dev] [PATCH 1/4] ethdev: fix max Rx packet length

2021-07-22 Thread Huisong Li
在 2021/7/21 23:29, Ferruh Yigit 写道: On 7/19/2021 4:35 AM, Huisong Li wrote: Hi, Ferruh Hi Huisong, Thanks for the review. 在 2021/7/10 1:29, Ferruh Yigit 写道: There is a confusion on setting max Rx packet length, this patch aims to clarify it. 'rte_eth_dev_configure()' API acce

Re: [dpdk-dev] [PATCH v2 5/6] ethdev: unify MTU checks

2021-07-22 Thread Huisong Li
Also this has benefit to have common error logs. Suggested-by: Huisong Li Signed-off-by: Ferruh Yigit --- lib/ethdev/rte_ethdev.c | 82 ++--- lib/ethdev/rte_ethdev.h | 2 +- 2 files changed, 54 insertions(+), 30 deletions(-) diff --git a/lib/ethdev/r

[dpdk-dev] [RFC V1] ethdev: fix the issue that dev uninit may be called twice

2021-08-02 Thread Huisong Li
bad scenario, the primary process may be fine, but it may cause that dev_unint() in the secondary process will be called twice, and even other serious problems. So this patch fixes it. Fixes: 99a2dd955fba ("lib: remove librte_ prefix from directory names") Signed-off-by: Huisong Li ---

[dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-02 Thread Huisong Li
brte_ prefix from directory names") Signed-off-by: Huisong Li --- v2: fix commit description --- lib/ethdev/ethdev_pci.h | 13 + 1 file changed, 13 insertions(+) diff --git a/lib/ethdev/ethdev_pci.h b/lib/ethdev/ethdev_pci.h index 8edca82..429c4c7 100644 --- a/lib/ethdev/ethdev_p

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-12 Thread Huisong Li
Hi, all This patch can enhance the security of device uninstallation to eliminate dependency on user usage methods. Can you check this patch? 在 2021/8/3 10:30, Huisong Li 写道: Ethernet devices in DPDK can be released by rte_eth_dev_close() and rte_dev_remove(). These APIs both call

Re: [dpdk-dev] [RFC V2] ethdev: fix issue that dev close in PMD calls twice

2021-08-13 Thread Huisong Li
在 2021/8/13 14:12, Thomas Monjalon 写道: 13/08/2021 04:11, Huisong Li: Hi, all This patch can enhance the security of device uninstallation to eliminate dependency on user usage methods. Can you check this patch? 在 2021/8/3 10:30, Huisong Li 写道: Ethernet devices in DPDK can be released by

Re: [dpdk-dev] [PATCH v3 1/3] ethdev: fix MTU doesn't update when jumbo frame disabled

2021-01-24 Thread Huisong Li
Hi Steve, In the current modification, the MTU is updated based on 'max_rx_pkt_len' regardless of whether jumbo frame is enabled. Now, MTU is correct when jumbo frmae is disabled. However, when jumbo frame is enabled, the MTU value may be inconsistent with the definition of the enabled jumb

[PATCH] mem: fix displaying heap ID failed for heap info command

2023-02-08 Thread Huisong Li
also misspelling. So use 'Heap_id' to replace 'Head id'. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- lib/eal/common/eal_common_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/li

[PATCH v2] mem: fix displaying heap ID failed for heap info command

2023-02-21 Thread Huisong Li
7;heap' is also misspelling. So use 'Heap_id' to replace 'Head id'. Fixes: e6732d0d6e26 ("mem: add telemetry infos") Fixes: 2537fb0c5f34 ("telemetry: limit characters allowed in dictionary names") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chen

[PATCH V9] ethdev: fix one address occupies two entries in MAC addrs

2023-05-18 Thread Huisong Li
st. So this patch adds a check on whether the new default address was already in the list and if so requires the user to remove it first. In addition, this patch documents the position of the default MAC address and address unique in the list. Signed-off-by: Huisong Li Acked-by: Chengwen Fen

[PATCH V10] ethdev: fix one address occupies two entries in MAC addrs

2023-05-19 Thread Huisong Li
st. So this patch adds a check on whether the new default address was already in the list and if so requires the user to remove it first. In addition, this patch documents the position of the default MAC address and address unique in the list. Signed-off-by: Huisong Li Acked-by: Chengwen Fen

[PATCH V6 3/5] app/testpmd: check the validity of the port

2023-05-26 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testp

[PATCH V6 1/5] drivers/bus: restore driver assignment at front of probing

2023-05-26 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH V6 5/5] app/testpmd: stop forwarding in new or destroy event

2023-05-26 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li --- app/test-pmd/testpmd.c | 4 1 file changed, 4 insertions(+) diff

[PATCH V6 0/5] app/testpmd: support multiple process attach and detach port

2023-05-26 Thread Huisong Li
a misspelling. -v3: #1 merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for other bus type. #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong Li (5): drivers

[PATCH V6 2/5] ethdev: fix skip valid port in probing callback

2023-05-26 Thread Huisong Li
be8cd210379a ("ethdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_driver.h | 12

[PATCH V6 4/5] app/testpmd: add attach and detach port for multiple process

2023-05-26 Thread Huisong Li
state is changed from 'ATTACHED' to 'UNUSED' only after the event callback finished. But the remove_invalid_ports() function removes invalid port only if ethdev state is 'UNUSED'. If we don't add alarm callback, this detached port information can not be removed. Sig

[RFC] ethdev: introduce PTP device capability

2024-01-29 Thread Huisong Li
ome to jumping into discussion. [1] https://patchwork.dpdk.org/project/dpdk/patch/20230203132810.14187-1-tho...@monjalon.net/ [2] https://inbox.dpdk.org/dev/20230817084226.55327-1-lihuis...@huawei.com/ Signed-off-by: Huisong Li --- lib/ethdev/rte_ethdev.h | 6 ++ 1 file changed, 6 insertions(+) diff

[PATCH v7 0/5] app/testpmd: support multiple process attach and detach port

2024-01-29 Thread Huisong Li
i break. -v4: fix a misspelling. -v3: #1 merge patch 1/6 and patch 2/6 into patch 1/5, and add modification for other bus type. #2 add a RTE_ETH_DEV_ALLOCATED state in rte_eth_dev_state to resolve the probelm in patch 2/5. -v2: resend due to CI unexplained failure. Huisong L

[PATCH v7 3/5] app/testpmd: check the validity of the port

2024-01-29 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh Acked-by: Chengwen Feng --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/ap

[PATCH v7 2/5] ethdev: fix skip valid port in probing callback

2024-01-29 Thread Huisong Li
be8cd210379a ("ethdev: fix port probing notification") Cc: sta...@dpdk.org Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- drivers/net/bnxt/bnxt_ethdev.c | 3 ++- drivers/net/mlx5/mlx5.c| 2 +- lib/ethdev/ethdev_driver.c | 13 ++--- lib/ethdev/ethdev_drive

[PATCH v7 1/5] drivers/bus: restore driver assignment at front of probing

2024-01-29 Thread Huisong Li
need to be updated if we do that. The driver pointer in rte_device is set before probing and needs to be reset if probing failed. And rte_dev_is_probed can not be called inside probing. Fixes: 391797f04208 ("drivers/bus: move driver assignment to end of probing") Cc: sta...@dpdk.org Si

[PATCH v7 5/5] app/testpmd: stop forwarding in new or destroy event

2024-01-29 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- app/test-pmd/testpmd.c | 4 1 file

[PATCH v7 4/5] app/testpmd: add attach and detach port for multiple process

2024-01-29 Thread Huisong Li
state is changed from 'ATTACHED' to 'UNUSED' only after the event callback finished. But the remove_invalid_ports() function removes invalid port only if ethdev state is 'UNUSED'. If we don't add alarm callback, this detached port information can not be removed. Sign

[PATCH v2 0/2] power: introduce PM QoS interface

2024-06-13 Thread Huisong Li
27;s idle state selection and limit just enter the shallowest idle state to low the delay after sleep by setting strict resume latency (zero value). [1] https://www.kernel.org/doc/html/latest/admin-guide/abi-testing.html?highlight=pm_qos_resume_latency_us#abi-sys-devices-power-pm-qos-resume-latency

  1   2   3   4   5   >