RE: [PATCH v5] mempool cache: add zero-copy get and put functions

2023-01-23 Thread Kamalakshitha Aligeri
-Original Message- From: Bruce Richardson Sent: Monday, January 23, 2023 6:31 AM To: Morten Brørup Cc: Konstantin Ananyev ; Konstantin Ananyev ; olivier.m...@6wind.com; andrew.rybche...@oktetlabs.ru; Honnappa Nagarahalli ; Kamalakshitha Aligeri ; dev@dpdk.org; nd Subject: Re

[RFCv2 1/2] net/i40e: replace get and put functions

2023-01-24 Thread Kamalakshitha Aligeri
Integrated zero-copy get and put API's in mempool cache in i40e PMD Signed-off-by: Kamalakshitha Aligeri --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ 1. Added support for mempools without cache (Morten Brorup) .ma

[RFCv2 2/2] test/mempool: add zero-copy API's

2023-01-24 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ 1. Added mempool test cases with zero-copy get and put API's app/test/test_mempo

RE: [PATCH 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2023-02-08 Thread Kamalakshitha Aligeri
Hi all, Can you please check the patch and provide comments? Thanks, Kamalakshitha > -Original Message- > From: Kamalakshitha Aligeri > Sent: Monday, November 14, 2022 1:26 PM > To: jer...@marvell.com; tho...@monjalon.net; > david.march...@redhat.com > Cc

[PATCH 1/2] net/i40e: replace put function

2023-02-08 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/

[PATCH 2/2] test/mempool: add zero-copy API's

2023-02-08 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20221227151700.80887-1...@smartsharesystems.com/ app/test/test_mempool.c

[PATCH v2 0/2] Integrated mempool cache zero-copy API's

2023-02-09 Thread Kamalakshitha Aligeri
5% with the new API v2: Fixed the code for n > RTE_MEMPOOL_CACHE_MAX_SIZE (Morten Brorup) v1: 1. Integrated the zc_put API in i40e PMD 2. Added mempool test cases with the zero-cpoy API's Kamalakshitha Aligeri (2): net/i40e: replace put function test/mempool: add zero-copy API'

[PATCH v2 1/2] net/i40e: replace put function

2023-02-09 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/

[PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-09 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20230209145833.129986-1...@smartsharesystems.com/ app/test/test_mempool.c

RE: [PATCH v9] mempool cache: add zero-copy get and put functions

2023-02-13 Thread Kamalakshitha Aligeri
Patch looks good to me Acked-by: Kamalakshitha Aligeri > -Original Message- > From: Morten Brørup > Sent: Monday, February 13, 2023 4:25 AM > To: olivier.m...@6wind.com; andrew.rybche...@oktetlabs.ru; Honnappa > Nagarahalli ; Kamalakshitha Aligeri > ; bruce.ri

[PATCH v3 0/2] Integrated mempool cache zero-copy API's

2023-02-13 Thread Kamalakshitha Aligeri
improves by 5% with the new API v3: Fixed the way mbufs are accessed from txep (Morten Brorup) v2: Fixed the code for n > RTE_MEMPOOL_CACHE_MAX_SIZE (Morten Brorup) v1: 1. Integrated the zc_put API in i40e PMD 2. Added mempool test cases with the zero-cpoy API's Kamalakshitha Aligeri (2):

[PATCH v3 1/2] net/i40e: replace put function

2023-02-13 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: http://patches.dpdk.org/project/dpdk/

[PATCH v3 2/2] test/mempool: add zero-copy API's

2023-02-13 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Acked-by: Morten Brørup --- Link: http://patches.dpdk.org/project/dpdk/patch/20230213122437.122858-1...@smartsharesystems.com/ app

[PATCH v4 0/2] Integrated mempool cache zero-copy API's

2023-02-20 Thread Kamalakshitha Aligeri
I's Kamalakshitha Aligeri (2): net/i40e: replace put function test/mempool: add zero-copy API's .mailmap| 1 + app/test/test_mempool.c | 81 ++--- drivers/net/i40e/i40e_rxtx_vec_common.h | 27 +++-- 3 files changed, 83 inse

[PATCH v4 1/2] net/i40e: replace put function

2023-02-20 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Reviewed-by: Morten Brørup --- Depends-on: series-

[PATCH v4 2/2] test/mempool: add zero-copy API's

2023-02-20 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Acked-by: Morten Brørup --- Depends-on: series-26984 ("[v9] mempool cache: add zero-copy get and put functions") app/test/test

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-21 Thread Kamalakshitha Aligeri
..@6wind.com; andrew.rybche...@oktetlabs.ru; Morten > Brørup > Cc: Kamalakshitha Aligeri ; > yuying.zh...@intel.com; beilei.x...@intel.com; > bruce.richard...@intel.com; konstantin.anan...@huawei.com; Honnappa > Nagarahalli ; Ruifeng Wang > ; Feifei Wang ; > david.march...@redhat.com

[PATCH v10 0/2] zero-copy get and put functions

2023-02-24 Thread Kamalakshitha Aligeri
This version combines the following two patches from Morten Brørup and Kamalakshitha Aligeri 1. https://patches.dpdk.org/project/dpdk/patch/20230213122437.122858-1...@smartsharesystems.com/ 2. https://patches.dpdk.org/project/dpdk/patch/20230221055205.22984-3-kamalakshitha.alig...@arm.com/ The

[PATCH v10 1/2] mempool cache: add zero-copy get and put functions

2023-02-24 Thread Kamalakshitha Aligeri
Signed-off-by: Kamalakshitha Aligeri --- v10: * Added mempool test cases with zero-copy API's v9: * Also set rte_errno in zero-copy put function, if returning NULL. (Honnappa) * Revert v3 comparison to prevent overflow if n is really huge and len is non-zero. (Olivier) v8: * Actually includ

[PATCH v10 2/2] net/i40e: replace put function

2023-02-24 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang Reviewed-by: Morten Brørup --- v3: Fixed the way mbuf

RE: [PATCH v10 2/2] net/i40e: replace put function

2023-03-02 Thread Kamalakshitha Aligeri
Hi all, This patch shows a couple of failures in patchwork. I checked it and it is not related to the patch. It shows as service_autotest failure. Anybody know how to fix this? > -Original Message- > From: Kamalakshitha Aligeri > Sent: Friday, February 24, 2023 10:11 AM > T

[PATCH v2 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2023-03-06 Thread Kamalakshitha Aligeri
The check_ptype function is not considering the ptype of the incoming traffic. --parse-ptype flag must be provided only when the NIC does not support parsing the ptype of the incoming traffic Suggested-by: Nathan Brown Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by

[PATCH v2 2/3] examples/l3fwd: removed hash entry number

2023-03-06 Thread Kamalakshitha Aligeri
ned-off-by: Kamalakshitha Aligeri Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd.h | 1 - examples/l3fwd/main.c | 37 + 2 files changed, 1 insertion(+), 37 deletions(-) diff --git a/examples/l3fwd/l3fwd.h b/examples/l3fwd/l3fwd.h index ca1426a687..b55855c

[PATCH v2 3/3] doc/l3fwd: lpm supports IPv4 and IPv6 forwarding

2023-03-06 Thread Kamalakshitha Aligeri
LPM based lookup supports both IPv4 and IPv6 forwarding. Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") Cc: sta...@dpdk.org Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang --- doc/guides/sample_app_ug/l3_forwa

[PATCH] net/i40e: avx512 fast-free path bug fix

2023-03-07 Thread Kamalakshitha Aligeri
.@dpdk.org Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- .mailmap| 1 + drivers/net/i40e/i40e_rxtx_vec_avx512.c | 12 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.mailmap b/.mai

[PATCH v11 1/2] mempool cache: add zero-copy get and put functions

2023-07-05 Thread Kamalakshitha Aligeri
code in those PMDs has not been kept up to date with the improvements of the mempool library, so when they bypass the mempool API, mempool trace is missing and mempool statistics is not updated. Bugzilla ID: 1052 Signed-off-by: Morten Brørup Signed-off-by: Kamalakshitha Aligeri v11: * Changed

[PATCH v11 2/2] net/i40e: replace put function

2023-07-05 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- .mailmap

[PATCH v11 1/2] mempool cache: add zero-copy get and put functions

2023-07-05 Thread Kamalakshitha Aligeri
code in those PMDs has not been kept up to date with the improvements of the mempool library, so when they bypass the mempool API, mempool trace is missing and mempool statistics is not updated. Bugzilla ID: 1052 Signed-off-by: Morten Brørup Signed-off-by: Kamalakshitha Aligeri v11: * Changed

[PATCH v11 2/2] net/i40e: replace put function

2023-07-05 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- drivers/net/i40e/i40e_rxtx_vec_common.h

[RFC] mempool: add API to return pointer to free space on per-core cache

2022-11-07 Thread Kamalakshitha Aligeri
Expose the pointer to free space in per core cache in PMD, so that the objects can be directly copied to cache without any temporary storage Signed-off-by: Kamalakshitha Aligeri --- Pending Work: 1. Internal review needs to be done. 2. Make the changes in i40e_tx_free_bufs_avx512 app/test

[PATCH 1/3] examples/l3fwd: validate ptype only for type of traffic sent

2022-11-14 Thread Kamalakshitha Aligeri
The check_ptype function is not considering the ptype of the incoming traffic. --parse-ptype flag must be provided only when the NIC does not support parsing the ptype of the incoming traffic Suggested-by: Nathan Brown Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by

[PATCH 2/3] examples/l3fwd: removed hash entry number

2022-11-14 Thread Kamalakshitha Aligeri
hash_entry_number in l3fwd is not being used by both lpm and em lookup method. Removed the global variable hash_entry_number and the function that parses the hash-entry-number flag. Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Honnappa Nagarahalli --- examples/l3fwd/l3fwd.h | 1

[PATCH 3/3] doc/l3fwd: lpm supports IPv4 and IPv6 forwarding

2022-11-14 Thread Kamalakshitha Aligeri
LPM based lookup supports both IPv4 and IPv6 forwarding. Fixes: 6a094e328598 ("examples/l3fwd: implement FIB lookup method") Cc: sta...@dpdk.org Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Honnappa Nagarahalli --- doc/guides/sample_app_ug/l3_forward.rst | 3 +-- 1 file

[RFC v2] mempool: add API to return pointer to free space on per-core cache

2022-11-16 Thread Kamalakshitha Aligeri
Expose the pointer to free space in per core cache in PMD, so that the objects can be directly copied to cache without any temporary storage Signed-off-by: Kamalakshitha Aligeri --- v2: Integration of API in vector PMD v1: API to return pointer to free space on per-core cache and integration

RE: [PATCH v2] mempool cache: add zero-copy get and put functions

2022-11-29 Thread Kamalakshitha Aligeri
> -Original Message- > From: Morten Brørup > Sent: Wednesday, November 16, 2022 12:04 PM > To: olivier.m...@6wind.com; andrew.rybche...@oktetlabs.ru; Honnappa > Nagarahalli ; Kamalakshitha Aligeri > ; bruce.richard...@intel.com; > dev@dpdk.org > Cc: nd ; Morten B

[RFC] net/i40e: replace get and put functions

2023-01-09 Thread Kamalakshitha Aligeri
Integrated zero-copy get and put API's in mempool cache in i40e PMD Signed-off-by: Kamalakshitha Aligeri --- 1. I have replaced the rte_mempool_get_bulk and rte_mempool_put_bulk in net/i40e with the zero-copy get and put API's drivers/net/i40e/i40e_rxtx_vec_avx512.c | 10 +