Re: [dpdk-dev] [PATCH v3 2/2] lib/mempool: distinguish debug counters from cache and pool

2021-04-23 Thread Kinsella, Ray
On 21/04/2021 17:29, Olivier Matz wrote: > Hi Dharmik, > > Please see some comments below. > > On Mon, Apr 19, 2021 at 07:08:00PM -0500, Dharmik Thakkar wrote: >> From: Joyce Kong >> >> If cache is enabled, objects will be retrieved/put from/to cache, >> subsequently from/to the common pool.

Re: [dpdk-dev] [PATCH v2 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Kinsella, Ray
On 22/04/2021 02:18, Haiyue Wang wrote: > This adds the support to set 'Bus Master Enable' bit in the PCI command > register. > > Signed-off-by: Haiyue Wang > Tested-by: Qi Zhang > --- > drivers/bus/pci/pci_common.c | 20 > drivers/bus/pci/rte_bus_pci.h | 12 +++

Re: [dpdk-dev] [PATCH] doc: announce modification in eventdev structure

2021-04-23 Thread Kinsella, Ray
On 15/04/2021 10:08, gak...@marvell.com wrote: > From: Akhil Goyal > > A new field ``ca_enqueue`` is added in ``rte_eventdev`` > in the end to maintain ABI. It needs to be moved above > in the structure to align with other enqueue callbacks. > > Signed-off-by: Akhil Goyal > --- > doc/guides

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-23 Thread Kinsella, Ray
On 14/04/2021 20:49, Thomas Monjalon wrote: > 13/04/2021 05:14, Xueming Li: >> Xueming Li (5): >> devargs: unify scratch buffer storage >> devargs: fix memory leak on parsing error >> kvargs: add get by key function >> bus: add device arguments name parsing API >> devargs: parse global

Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 16/04/2021 10:57, Thomas Monjalon wrote: > 16/04/2021 11:41, Ferruh Yigit: >> On 4/16/2021 9:58 AM, Thomas Monjalon wrote: >>> 16/04/2021 10:46, Lijun Ou: Currently, upper-layer application could get queue state only through pointers such as dev->data->tx_queue_state[queue_id],

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 17/04/2021 04:09, Lijun Ou wrote: > Currently, upper-layer application could get queue state only > through pointers such as dev->data->tx_queue_state[queue_id], > this is not the recommended way to access it. So this patch > add get queue state when call rte_eth_rx_queue_info_get and > rte_e

Re: [dpdk-dev] [PATCH v3 1/3] bus/pci: enable PCI master in command register

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:39, Haiyue Wang wrote: > This adds the support to set 'Bus Master Enable' bit in the PCI command > register. > > Signed-off-by: Haiyue Wang > Tested-by: Qi Zhang > --- > drivers/bus/pci/pci_common.c | 20 > drivers/bus/pci/rte_bus_pci.h | 12 +++

Re: [dpdk-dev] [PATCH v5 0/5] eal: enable global device syntax by default

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:39, Gaëtan Rivet wrote: > On Fri, Apr 23, 2021, at 13:06, Kinsella, Ray wrote: >> >> >> On 14/04/2021 20:49, Thomas Monjalon wrote: >>> 13/04/2021 05:14, Xueming Li: >>>> Xueming Li (5): >>>> devargs: unify scratch buf

Re: [dpdk-dev] [PATCH V5] ethdev: add queue state when retrieve queue information

2021-04-23 Thread Kinsella, Ray
On 23/04/2021 12:26, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: dev On Behalf Of Kinsella, Ray >> Sent: Friday, April 23, 2021 12:17 PM >> To: Lijun Ou ; tho...@monjalon.net; Yigit, Ferruh >> >> Cc: dev@dpdk.org; linux.

Re: [dpdk-dev] [PATCH V4] ethdev: add queue state when retrieve queue information

2021-04-26 Thread Kinsella, Ray
On 25/04/2021 17:42, Thomas Monjalon wrote: > Kinsella, Ray: >> On 16/04/2021 10:57, Thomas Monjalon wrote: >>> 16/04/2021 11:41, Ferruh Yigit: >>>> On 4/16/2021 9:58 AM, Thomas Monjalon wrote: >>>>> 16/04/2021 10:46, Lijun Ou: >>>>&g

Re: [dpdk-dev] [PATCH v2 01/33] event/cnxk: add build infra and device setup

2021-04-27 Thread Kinsella, Ray
On 26/04/2021 18:44, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add meson build infra structure along with the event device > SSO initialization and teardown functions. > > Signed-off-by: Shijith Thotton > Signed-off-by: Pavan Nikhilesh > --- > MAINTAINERS

Re: [dpdk-dev] [PATCH v4 1/3] bus/pci: set PCI master in command register

2021-04-27 Thread Kinsella, Ray
On 27/04/2021 14:39, Haiyue Wang wrote: > Add the API to set 'Bus Master Enable' bit to be enabled or disabled in > the PCI command register. > > Signed-off-by: Haiyue Wang > --- > drivers/bus/pci/pci_common.c | 28 > drivers/bus/pci/rte_bus_pci.h | 14 ++

Re: [dpdk-dev] [PATCH 2/3] common/sfc_efx/base: add MAE VLAN presence match bits

2021-04-28 Thread Kinsella, Ray
On 28/04/2021 10:49, Ivan Malov wrote: > Introduce necessary infrastructure for these fields to > be set, validated and compared during class comparison. > Enumeration and mappings envisaged are MCDI-compatible. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy

Re: [dpdk-dev] [PATCH v6 01/10] eal: add thread id and simple thread functions

2021-04-29 Thread Kinsella, Ray
On 29/04/2021 08:44, Thomas Monjalon wrote: > 29/04/2021 02:50, Dmitry Kozlyuk: >> 2021-04-02 18:38 (UTC-0700), Narcisa Ana Maria Vasile: >>> --- /dev/null >>> +++ b/lib/librte_eal/windows/include/rte_windows_thread_types.h >>> @@ -0,0 +1,12 @@ >>> +/* SPDX-License-Identifier: BSD-3-Clause >>> +

Re: [dpdk-dev] [PATCH 2/3] common/sfc_efx/base: add MAE VLAN presence match bits

2021-04-30 Thread Kinsella, Ray
On 28/04/2021 10:49, Ivan Malov wrote: > Introduce necessary infrastructure for these fields to > be set, validated and compared during class comparison. > Enumeration and mappings envisaged are MCDI-compatible. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Reviewed-by: Andy

Re: [dpdk-dev] [EXT] Re: [PATCH] doc: announce modification in eventdev structure

2021-05-04 Thread Kinsella, Ray
On 03/05/2021 12:18, Akhil Goyal wrote: > Hi Ray, >>> @@ -127,6 +127,10 @@ Deprecation Notices >>>values to the function ``rte_event_eth_rx_adapter_queue_add`` using >>>the structure ``rte_event_eth_rx_adapter_queue_add``. >>> >>> +* eventdev: The function pointer ``ca_enqueue`` in struc

Re: [dpdk-dev] [PATCH v5 21/35] event/cnxk: add event port and queue xstats

2021-05-04 Thread Kinsella, Ray
On 04/05/2021 01:27, pbhagavat...@marvell.com wrote: > From: Pavan Nikhilesh > > Add support for retrieving statistics from SSO HWS and HWGRP. > > Signed-off-by: Pavan Nikhilesh > --- > drivers/common/cnxk/roc_sso.c| 63 + > drivers/common/cnxk/roc_sso.h| 19 ++

Re: [dpdk-dev] [PATCH v2 2/2] buildtools: check symbol maps in developer mode

2021-05-06 Thread Kinsella, Ray
On 05/05/2021 15:30, David Marchand wrote: > Hook check-symbol-maps.sh in the symbol check when in developer mode to > help developers catch issues before submitting their changes. > > Signed-off-by: David Marchand > --- > Changes since v1: > - now that we have the developer mode, added this c

Re: [dpdk-dev] [PATCH] devtools: script to track map symbols

2021-06-21 Thread Kinsella, Ray
> > pylint reports some things that should be fixed. Don't worry about the naming > style > and docstring but others should be addressed. [SNIP] Ah, rookie mistake, I ran checkpatch and thought that I was all good. I will sort it out thanks. Ray K

[dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
Hi Declan and Goyal, The following security experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_security_get_userd

[dpdk-dev] Experimental symbols in net lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following net experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_net_make_rarp_packet * rte_net_s

[dpdk-dev] Experimental symbols in mbuf lib

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following mbuf experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mbuf_check * rte_mbuf_dynfield_

[dpdk-dev] Experimental symbols in vhost lib

2021-06-24 Thread Kinsella, Ray
Hi Maxime and Chenbo, The following vhost experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_vhost_driver_get_pro

[dpdk-dev] Experimental symbols in flow_classify lib

2021-06-24 Thread Kinsella, Ray
Hi Bernard, The following flow_classify experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_flow_classifier_create

[dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Hi Anatoly & Thomas, The following eal experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mp_action_register * r

[dpdk-dev] Experimental symbols in port lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian The following port experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_eventdev_writer_nodrop_ops

[dpdk-dev] Experimental symbols in compressdev lib

2021-06-24 Thread Kinsella, Ray
Hi Fiona & Ashish, The following compressdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_compressdev_capabi

[dpdk-dev] Experimental symbols in sched lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian & Jasvinder, The following sched experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_sched_subport_pipe

[dpdk-dev] Experimental symbols in cryptodev lib

2021-06-24 Thread Kinsella, Ray
Hi Declan, The following cryptodev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_cryptodev_asym_capability_ge

[dpdk-dev] Experimental symbols in rib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir The following rib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_rib_create, * rte_rib_find_existin

[dpdk-dev] Experimental symbols in pipeline lib

2021-06-24 Thread Kinsella, Ray
Hi Cristian, The following pipeline experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_port_in_action_create * rte_

[dpdk-dev] Experimental symbols in ip_frag

2021-06-24 Thread Kinsella, Ray
Hi Konstantin The following ip_frag experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_frag_table_del_expired_entri

[dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
Hi Nicolas The following bbdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_bbdev_allocate * rte_bbdev_callba

[dpdk-dev] Experimental Symbols in ethdev lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, Ferruh and Andrew, The following ethdev experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_mtr_capabili

[dpdk-dev] Experimental Symbols in kvargs

2021-06-24 Thread Kinsella, Ray
Hi Oliver, The following kvargs experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kvargs_parse_delim * rte_kvargs_

[dpdk-dev] Experimental symbols in power lib

2021-06-24 Thread Kinsella, Ray
Hi David, The following power experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_empty_poll_detection * rte_power

[dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Hi Ferruh, The following kni experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_kni_update_link Ray K

[dpdk-dev] Experimental symbols in metrics lib

2021-06-24 Thread Kinsella, Ray
Hi Thomas, The following metrics experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_metrics_deinit Ray K

[dpdk-dev] Experimental symbols in fib lib

2021-06-24 Thread Kinsella, Ray
Hi Vladimir, The following fib experimental symbols are present in both v21.05 and v19.11 release. These symbols should be considered for promotion to stable as part of the v22 ABI in DPDK 21.11, as they have been experimental for >= 2yrs at this point. * rte_fib_add * rte_fib_create * rt

Re: [dpdk-dev] Experimental symbols in hash lib

2021-06-24 Thread Kinsella, Ray
+ dpdk dev (missed the dev list the first time, apologies). On 24/06/2021 11:41, Kinsella, Ray wrote: > Hi Yipeng, Sameh, Bruce and Vladimir, > > The following hash experimental symbols are present in both v21.05 and v19.11 > release. These symbols should be considered for promoti

Re: [dpdk-dev] Experimental symbols in security lib

2021-06-24 Thread Kinsella, Ray
(correcting Goyals address, apologies for the resend) On 24/06/2021 11:28, Kinsella, Ray wrote: > Hi Declan and Goyal, > > The following security experimental symbols are present in both v21.05 and > v19.11 release. These symbols should be considered for promotion to stable as &

Re: [dpdk-dev] Experimental symbols in eal lib

2021-06-24 Thread Kinsella, Ray
Good point, that one is very up to the lib maintainer to make that call. Ray K On 24/06/2021 13:14, David Marchand wrote: > On Thu, Jun 24, 2021 at 12:31 PM Kinsella, Ray wrote: >> >> Hi Anatoly & Thomas, >> >> The following eal experimental symbols are pr

Re: [dpdk-dev] Experimental symbols in kni lib

2021-06-24 Thread Kinsella, Ray
Sounds more than reasonable, +1 from me. Ray K On 24/06/2021 14:24, Ferruh Yigit wrote: > On 6/24/2021 11:42 AM, Kinsella, Ray wrote: >> Hi Ferruh, >> >> The following kni experimental symbols are present in both v21.05 and v19.11 >> release. These symbols should be

Re: [dpdk-dev] Experimental symbols in bbdev lib

2021-06-24 Thread Kinsella, Ray
at request was considered for 20.11. But this was deferred by the community > while waiting for other vendors who may be willing to contribute their own > PMDs. > Any specific concern with this not being on a tracked ABI? > > Thanks > Nic > > >> -----Original

Re: [dpdk-dev] Experimental symbols in compressdev lib

2021-06-25 Thread Kinsella, Ray
On 25/06/2021 08:49, David Marchand wrote: > On Thu, Jun 24, 2021 at 12:33 PM Kinsella, Ray wrote: >> >> Hi Fiona & Ashish, >> >> The following compressdev experimental symbols are present in both v21.05 >> and v19.11 release. These symbols should be cons

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-06-29 Thread Kinsella, Ray
On 29/06/2021 17:28, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 05:00:31PM +0100, Ray Kinsella wrote: >> Clarifying the ABI policy on the promotion of experimental APIS to stable. >> We have a fair number of APIs that have been experimental for more than >> 2 years. This policy ammendment i

Re: [dpdk-dev] [PATCH] net: prepare the outer ipv4 hdr for checksum

2021-06-29 Thread Kinsella, Ray
Please mark [PATCH v2], and record changes under the --- Ray K > -Original Message- > From: Mohsin Kazmi > Sent: Tuesday 29 June 2021 18:07 > To: dev@dpdk.org > Cc: Kinsella, Ray ; Mohsin Kazmi > ; sta...@dpdk.org; Olivier Matz > ; Ananyev, Konstantin > ; Th

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-07-01 Thread Kinsella, Ray
On 30/06/2021 20:56, Tyler Retzlaff wrote: > On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >> >> >>>> +Promotion to stable >>>> +~~~ >>>> + >>>> +Ordinarily APIs marked as ``experimental`` will be

Re: [dpdk-dev] [PATCH v1] doc: policy on promotion of experimental APIs

2021-07-01 Thread Kinsella, Ray
On 01/07/2021 16:09, Tyler Retzlaff wrote: > On Thu, Jul 01, 2021 at 11:19:27AM +0100, Kinsella, Ray wrote: >> >> >> On 30/06/2021 20:56, Tyler Retzlaff wrote: >>> On Tue, Jun 29, 2021 at 07:38:05PM +0100, Kinsella, Ray wrote: >>

Re: [dpdk-dev] [PATCH] eal: move DMA mapping from bus-specific to generic driver

2021-04-01 Thread Kinsella, Ray
On 31/03/2021 23:53, Thomas Monjalon wrote: > 01/04/2021 00:45, Thomas Monjalon: >> The operations of DMA mapping and unmapping are controlled in some >> bus drivers, following rte_bus specification. >> If the device driver don't provide any specific mapping operation, >> the bus driver may have

Re: [dpdk-dev] [PATCH v2 1/2] vhost: Add API to get negotiated protocol features

2021-04-01 Thread Kinsella, Ray
On 31/03/2021 17:45, Ferruh Yigit wrote: > On 3/22/2021 7:22 AM, Keiichi Watanabe wrote: >> Add rte_vhost_get_negotiated_protocol_features, which returns a set of >> enabled protocol features. >> >> Signed-off-by: Keiichi Watanabe > > <...> > >> diff --git a/lib/librte_vhost/version.map b/lib

Re: [dpdk-dev] [PATCH v3 1/5] devargs: unify scratch buffer storage

2021-04-01 Thread Kinsella, Ray
On 30/03/2021 13:15, Xueming Li wrote: > In current design, legacy parser rte_devargs_parse() saved scratch > buffer to devargs.args while new parser rte_devargs_layers_parse() saved > to devargs.data. Code using devargs had to know the difference and > cleaned up memory accordingly - error pron

Re: [dpdk-dev] [PATCH v3 3/5] kvargs: add get by key function

2021-04-01 Thread Kinsella, Ray
On 30/03/2021 13:15, Xueming Li wrote: > Adds a new function to get value of a specific key from kvargs list. > > Signed-off-by: Xueming Li > --- > lib/librte_kvargs/rte_kvargs.c | 20 > lib/librte_kvargs/rte_kvargs.h | 21 + > lib/librte_kvargs/versio

Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file

2021-04-07 Thread Kinsella, Ray
On 06/04/2021 17:50, Bruce Richardson wrote: > On Tue, Apr 06, 2021 at 06:32:30PM +0200, David Marchand wrote: >> Rather than have two files that keeps getting out of sync, let's >> annotate the version.map to generate the Windows export file. >> >> Note: EAL version.map annotation achieved with

Re: [dpdk-dev] [PATCH] eal: move DMA mapping from bus-specific to generic driver

2021-04-12 Thread Kinsella, Ray
On 31/03/2021 23:53, Thomas Monjalon wrote: > 01/04/2021 00:45, Thomas Monjalon: >> The operations of DMA mapping and unmapping are controlled in some >> bus drivers, following rte_bus specification. >> If the device driver don't provide any specific mapping operation, >> the bus driver may have a

Re: [dpdk-dev] [PATCH v9 05/10] kvargs: update parser to support multiple lists

2021-04-12 Thread Kinsella, Ray
On 11/03/2021 13:13, Xueming Li wrote: > This patch updates kvargs parser to support value of multiple lists or > ranges: > k1=v[1,2]v[3-5] > > Signed-off-by: Xueming Li > Acked-by: Viacheslav Ovsiienko > Acked-by: Thomas Monjalon > --- > app/test/test_kvargs.c | 46 +

Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

2021-04-13 Thread Kinsella, Ray
On 13/04/2021 09:45, Thomas Monjalon wrote: > The eventdev driver DLB was removed in DPDK 21.05, > breaking the ABI check. > The exception was agreed so we just need to skip this check. > > Note: complete removal of a driver cannot be ignored > in devtools/libabigail.abignore, so the script mus

Re: [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined meter policy API

2021-04-13 Thread Kinsella, Ray
On 13/04/2021 01:14, Li Zhang wrote: > Currently, the flow meter policy does not support multiple actions > per color; also the allowed action types per color are very limited. > In addition, the policy cannot be pre-defined. > > Due to the growing in flow actions offload abilities there is a p

Re: [dpdk-dev] [PATCH v2 3/5] common/mlx5: add mlx5 APIs for single flow dump feature

2021-04-13 Thread Kinsella, Ray
On 07/04/2021 07:09, Haifei Luo wrote: > add mlx5 APIs for single flow dump feature > > Signed-off-by: Haifei Luo > --- > drivers/common/mlx5/linux/meson.build | 2 ++ > drivers/common/mlx5/linux/mlx5_glue.c | 13 + > drivers/common/mlx5/linux/mlx5_glue.h

Re: [dpdk-dev] [PATCH] devtools: skip removed DLB driver in ABI check

2021-04-13 Thread Kinsella, Ray
On 13/04/2021 17:44, Thomas Monjalon wrote: > 13/04/2021 18:09, Kinsella, Ray: >> On 13/04/2021 09:45, Thomas Monjalon wrote: >>> The eventdev driver DLB was removed in DPDK 21.05, >>> breaking the ABI check. >>> The exception was agreed so we just n

Re: [dpdk-dev] [PATCH v2 07/13] common/mlx5: add DevX API to create ASO flow meter object

2021-04-13 Thread Kinsella, Ray
On 02/04/2021 16:16, Li Zhang wrote: > Add DevX API to create ASO flow meter object. > > Signed-off-by: Li Zhang > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 54 > drivers/common/mlx5/mlx5_devx_cmds.h | 18 +- > drivers/common/mlx5/version.map | 1

Re: [dpdk-dev] [PATCH v7 4/4] log: add option argument help

2021-04-13 Thread Kinsella, Ray
On 08/04/2021 17:47, Thomas Monjalon wrote: > The option --log-level was not completely described in the usage text, > and it was difficult to guess the names of the log types and levels. > > A new value "help" is accepted after --log-level to give more details > about the syntax and listing th

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
; > Doherty, Declan ; ma...@nvidia.com; > g.si...@nxp.com; Zhang, Roy Fan ; > jianjay.z...@huawei.com; asoma...@amd.com; ruifeng.w...@arm.com; > Ananyev, Konstantin ; Nicolau, Radu > ; ajit.khapa...@broadcom.com; Nagadheeraj > Rottela ; Ankur Dwivedi > ; Power, Ciara ; Kinsella, > Ra

Re: [dpdk-dev] [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > In struct rte_security_ipsec_sa_options, for every new option > added, there is an ABI breakage, to avoid, a reserved_opts > bitfield is added to for the remaining bits available in the > structure. > Now for every new sa option, these reserved_opts can

Re: [dpdk-dev] [PATCH v2 2/3] security: hide internal API

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > rte_security_dynfield_register() is an internal > API to be used by the driver, hence moving it to internal. > > Signed-off-by: Akhil Goyal > Acked-by: Konstantin Ananyev > --- > v2: no change > > lib/security/rte_security_driver.h | 2 +- > lib/sec

Re: [dpdk-dev] [EXT] Re: [PATCH v2 3/3] security: add reserved bitfields

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 07:59, Thomas Monjalon wrote: > 11/10/2021 18:58, Akhil Goyal: >>> 08/10/2021 22:45, Akhil Goyal: In struct rte_security_ipsec_sa_options, for every new option added, there is an ABI breakage, to avoid, a reserved_opts bitfield is added to for the remaining bits avai

Re: [dpdk-dev] [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 08/10/2021 21:45, Akhil Goyal wrote: > Remove *_LIST_END enumerators from asymmetric crypto > lib to avoid ABI breakage for every new addition in > enums. > > Signed-off-by: Akhil Goyal > --- > v2: no change > > app/test/test_cryptodev_asym.c | 4 ++-- > drivers/crypto/qat/qat_asym.c |

Re: [dpdk-dev] [PATCH v1] eventdev/rx-adapter: add telemetry callbacks

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 10:26, Jerin Jacob wrote: > On Tue, Oct 12, 2021 at 2:40 PM Thomas Monjalon wrote: >> >> 12/10/2021 10:47, Jerin Jacob: >>> On Tue, Oct 12, 2021 at 2:05 PM Kundapura, Ganapati >>> wrote: From: Jerin Jacob >> --- a/lib/eventdev/rte_event_eth_rx_adapter.h >> +++ b/lib

Re: [dpdk-dev] [PATCH] mempool: enforce valid flags at creation

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 08:28, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- Acked-by: Ray Kinsella

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 11:50, Anoob Joseph wrote: > Hi Ray, Akhil, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Akhil Goyal >> Sent: Tuesday, October 12, 2021 3:49 PM >> To: Kinsella, Ray ; dev@dpdk.org >>

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-12 Thread Kinsella, Ray
On 12/10/2021 15:18, Anoob Joseph wrote: > Hi Thomas, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Thomas Monjalon >> Sent: Tuesday, October 12, 2021 7:25 PM >> To: Kinsella, Ray ; Akhil Goyal ; >

Re: [dpdk-dev] [PATCH] mbuf: enforce no option for dynamic fields and flags

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > As stated in the API, dynamic field and flags should be created with no > additional flag (simply in the API for future changes). > > Fix the dynamic flag register helper which was not enforcing it and add > unit tests. > > Fixes: 4958ca3a443a ("mbu

Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/3] cryptodev: remove LIST_END enumerators

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 08:04, Anoob Joseph wrote: > Hi Akhil, Ray, Thomas, > > Please see inline. > > Thanks, > Anoob > >> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, October 13, 2021 12:32 PM >> To: Akhil Goyal ; dev@dpd

Re: [dpdk-dev] [PATCH v3 04/10] common/sfc_efx/base: add RECIRC ID match in action rules API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 01:24, Ivan Malov wrote: > Currently, there is an API for setting recirculation ID in > outer rules. Add an API to let action rules match on it. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > --- > drivers/common/sfc_efx/base/efx.h | 13 ++ > driver

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 22:52, Thomas Monjalon wrote: > 12/10/2021 22:34, Dumitrescu, Cristian: >> From: Thomas Monjalon >>> 01/09/2021 14:20, Jasvinder Singh: These APIs were introduced in 18.05, therefore removing experimental tag to promote them to stable state. Signed-off-by: Jasv

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 21:34, Dumitrescu, Cristian wrote: > > >> -Original Message- >> From: Singh, Jasvinder >> Sent: Wednesday, September 1, 2021 1:20 PM >> To: dev@dpdk.org >> Cc: Dumitrescu, Cristian ; m...@ashroe.eu; >> Zhang, Roy Fan >> Subject: [PATCH] pipeline: remove experimental tag

Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:20, Jasvinder Singh wrote: > This API was introduced in 18.08, therefore removing > experimental tag to promote it to stable state. > > Signed-off-by: Jasvinder Singh > --- > drivers/net/softnic/rte_eth_softnic.h | 1 - > drivers/net/softnic/version.map | 7 +-- > 2

Re: [dpdk-dev] [PATCH] sched: remove experimental tag from the API

2021-10-13 Thread Kinsella, Ray
On 01/09/2021 13:19, Jasvinder Singh wrote: > This API was introduced in 18.05, therefore removing > experimental tag to promote it to stable state > > Signed-off-by: Jasvinder Singh > --- > lib/sched/rte_sched.h | 4 > lib/sched/version.map | 2 +- > 2 files changed, 1 insertion(+), 5 d

Re: [dpdk-dev] [PATCH v5] net: introduce IPv4 ihl and version fields

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 13:29, Gregory Etelson wrote: > RTE IPv4 header definition combines the `version' and `ihl' fields > into a single structure member. > This patch introduces dedicated structure members for both `version' > and `ihl' IPv4 fields. Separated header fields definitions allow to > creat

Re: [dpdk-dev] [PATCH] memzone: enforce valid flags when reserving

2021-10-13 Thread Kinsella, Ray
On 12/10/2021 20:39, David Marchand wrote: > If we do not enforce valid flags are passed by an application, this > application might face issues in the future when we add more flags. > > Signed-off-by: David Marchand > --- > app/test/test_memzone.c | 24 >

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:40, Thomas Monjalon wrote: > 13/10/2021 10:51, Kinsella, Ray: >> >> On 12/10/2021 22:52, Thomas Monjalon wrote: >>> 12/10/2021 22:34, Dumitrescu, Cristian: >>>> From: Thomas Monjalon >>>>> 01/09/2021 14:20, Jasvinder Singh: &g

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 10:49, Thomas Monjalon wrote: > 13/10/2021 11:43, Kinsella, Ray: >> On 13/10/2021 10:40, Thomas Monjalon wrote: >>> 13/10/2021 10:51, Kinsella, Ray: >>>> On 12/10/2021 22:52, Thomas Monjalon wrote: >>>>> 12/10/2021 22:34, Dumit

Re: [dpdk-dev] [PATCH] pipeline: remove experimental tag from API

2021-10-13 Thread Kinsella, Ray
On 13/10/2021 12:11, Bruce Richardson wrote: > On Wed, Oct 13, 2021 at 11:02:02AM +0100, Kinsella, Ray wrote: >> >> >> On 13/10/2021 10:49, Thomas Monjalon wrote: >>> 13/10/2021 11:43, Kinsella, Ray: >>>> On 13/10/2021 10:40, Thomas Monjalon wr

Re: [dpdk-dev] [PATCH v3 08/18] eal: fix typos in comments

2021-10-20 Thread Kinsella, Ray
On 14/10/2021 22:56, Stephen Hemminger wrote: Minor spelling errors. Signed-off-by: Stephen Hemminger Acked-by: Ray Kinsella

Re: [dpdk-dev] [PATCH v5 1/4] mempool: add event callbacks

2021-10-20 Thread Kinsella, Ray
On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Data path performance can benefit if the PMD knows which memory it will need to handle in advance, before the first mbuf is sent to the PMD. It is impractical, however, to consider all allocated memory for this purpose. Most often mbuf memory comes fr

Re: [dpdk-dev] [PATCH v5 3/4] common/mlx5: add mempool registration facilities

2021-10-20 Thread Kinsella, Ray
On 15/10/2021 17:02, Dmitry Kozlyuk wrote: Add internal API to register mempools, that is, to create memory regions (MR) for their memory and store them in a separate database. Implementation deals with multi-process, so that class drivers don't need to. Each protection domain has its own data

Re: [dpdk-dev] [PATCH v2 02/13] common/mlx5: support receive memory pool

2021-10-20 Thread Kinsella, Ray
On 16/10/2021 10:12, Xueming Li wrote: Adds DevX supports of PRM shared receive memory pool(RMP) object. RMP is used to support shared Rx queue. Multiple RQ could share same RMP. Memory buffers are supplied to RMP. This patch makes RMP RQ optional, created only if mlx5_devx_rq.rmp is set. Si

Re: [dpdk-dev] [PATCH] ip_frag: promote APIs to stable

2021-10-20 Thread Kinsella, Ray
On 18/10/2021 16:36, Konstantin Ananyev wrote: Promote rte_frag_table_del_expired_entries() function to stable. It was around for few years by now without any changes. Signed-off-by: Konstantin Ananyev --- lib/ip_frag/rte_ip_frag.h | 1 - lib/ip_frag/version.map | 7 +-- 2 files ch

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-10-20 Thread Kinsella, Ray
On 13/10/2021 13:12, Thomas Monjalon wrote: +Cc Cristian, the maintainer 10/09/2021 15:40, Kinsella, Ray: On 10/09/2021 08:36, David Marchand wrote: On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: On 09/09/2021 17:40, Rahul Shah wrote: rte_port_eventdev_reader_ops

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See https://github.com/pcapng/pcapng/ Signed-off-by: Stephen Hemminger Acked-by:

Re: [dpdk-dev] [PATCH v15 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the

Re: [dpdk-dev] [PATCH v15 05/12] bpf: add function to dump eBPF instructions

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meso

Re: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version numbe

Re: [dpdk-dev] [PATCH] ethdev: promote port ownership API as stable

2021-10-28 Thread Kinsella, Ray
On 28/10/2021 09:34, Thomas Monjalon wrote: The port ownership concept was introduced in ethdev in DPDK 18.02. Not sure it is used by applications except those using failsafe or netvsc. It can also be used by libraries or applications to sort out how ports are controlled. Hiding sub-ports con

Re: [dpdk-dev] [PATCH] ethdev: promote device removal check function as stable

2021-10-28 Thread Kinsella, Ray
On 28/10/2021 09:35, Thomas Monjalon wrote: The function rte_eth_dev_is_removed() was introduced in DPDK 18.02, and is integrated in error checks of ethdev library. It is promoted as stable ABI. Signed-off-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.h | 4 lib/ethdev/version.map

Re: [dpdk-dev] Doubt regarding DPDK hash Library implementation

2021-11-04 Thread Kinsella, Ray
I would guess it - I would say it is related to cache alignment. Assuming each entry is 8 bytes 😊 Ray K > -Original Message- > From: Thomas Monjalon > Sent: Thursday 4 November 2021 14:12 > To: Syam Prasad N Pearson > Cc: us...@dpdk.org; dev@dpdk.org; Wang, Yipeng1 > ; Gobriel, Sameh ;

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-09-10 Thread Kinsella, Ray
On 09/09/2021 17:40, Rahul Shah wrote: > rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, > rte_port_eventdev_writer_ops symbols promoted > > Signed-off-by: Rahul Shah > --- > lib/port/version.map | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > Hi Rahul,

Re: [dpdk-dev] [PATCH] port: eventdev port api promoted

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 08:36, David Marchand wrote: > On Fri, Sep 10, 2021 at 9:31 AM Kinsella, Ray wrote: >> On 09/09/2021 17:40, Rahul Shah wrote: >>> rte_port_eventdev_reader_ops, rte_port_eventdev_writer_nodrops_ops, >>> rte_port_eventdev_writer_ops symbols promoted &

Re: [dpdk-dev] [PATCH v1 1/7] eal: promote IPC API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_eal.h | 24 > lib/eal/version.map | 14 ++ > 2 files changed

Re: [dpdk-dev] [PATCH v1 2/7] fbarray: promote API's to stable

2021-09-10 Thread Kinsella, Ray
On 10/09/2021 13:30, Anatoly Burakov wrote: > As per ABI policy, move the formerly experimental API's to the stable > section. > > Signed-off-by: Anatoly Burakov > --- > lib/eal/include/rte_fbarray.h | 26 -- > lib/eal/version.map | 52 +--

  1   2   3   4   >