RE: [PATCH v4 2/2] app/dma-perf: add SG copy support

2023-09-28 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Gowrishankar Muthukrishnan > Sent: Sunday, September 24, 2023 3:02 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Cheng Jiang > ; Kevin Laatz ; Bruce > Richardson ; Pavan Nikhilesh Bhagavatula > ; Gowrishankar Muthukrishnan > > S

RE: [EXT] Re: [PATCH v4 0/3] Introduce event link profiles

2023-09-29 Thread Pavan Nikhilesh Bhagavatula
> On Thu, Sep 28, 2023 at 3:42 PM wrote: > > > > From: Pavan Nikhilesh > > + @Thomas Monjalon @David Marchand @Aaron Conole @Michael > Santana > > There is CI failure in apply stage[1] where it is taking main tree > commit. Not sure why it is taking main tree? > > Pavan, > > Could you rese

RE: [EXT] Re: [PATCH v6 0/3] Introduce event link profiles

2023-10-03 Thread Pavan Nikhilesh Bhagavatula
> On Tue, Oct 3, 2023 at 7:43 PM Bruce Richardson > wrote: > > > > On Tue, Oct 03, 2023 at 04:06:10PM +0530, Jerin Jacob wrote: > > > On Tue, Oct 3, 2023 at 3:17 PM wrote: > > > > > > > > From: Pavan Nikhilesh > > > > > > > > A collection of event queues linked to an event port can be associated

RE: [EXT] [PATCH] event/cnxk: fix symbol map

2023-10-17 Thread Pavan Nikhilesh Bhagavatula
> Caught while rebasing a series that check map files. > > Remove superfluous whitespace. > Current ABI number is 24. > Sort experimental symbols and annotate them with the version they are > introduced in. > > Fixes: 03714a41bd26 ("event/cnxk: add event port flow context API") > > Signed-off-by

RE: [EXT] [PATCH v5 1/5] examples/l3fwd: fix port group mask generation

2022-10-20 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Monday, October 17, 2022 5:36 PM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > Kollanukkaran ; David Christensen > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; sta...@dpdk.org > Subject: RE: [E

Re: [dpdk-dev] [EXT] [PATCH] app/testeventdev: fix buffer overflow

2021-04-23 Thread Pavan Nikhilesh Bhagavatula
>Tainted and unvalidated integer 'idx' used as an index, which may >lead to buffer overflow. > >This patch fixed it. > >Fixes: 89e5eb118017 ("app/testeventdev: add string parsing helpers") >Cc: sta...@dpdk.org > >Signed-off-by: Min Hu (Connor) Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/

Re: [dpdk-dev] [PATCH v1 2/2] event/octeontx2: configure crypto adapter xaq pool

2021-04-26 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Shijith Thotton >Sent: Friday, April 16, 2021 12:40 AM >To: dev@dpdk.org >Cc: Shijith Thotton ; Jerin Jacob Kollanukkaran >; Akhil Goyal ; Anoob >Joseph ; Ankur Dwivedi >; Pavan Nikhilesh Bhagavatula > >Subject: [PATCH v1 2

Re: [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev

2021-04-30 Thread Pavan Nikhilesh Bhagavatula
+Cc: jay.jayatheert...@intel.com> >This patch set contains two bugfixes for lib eventdev. > >Chengwen Feng (2): > eventdev: remove redundant setting thread name > eventdev: fix memory leakage when create thread fail > > lib/eventdev/rte_event_eth_rx_adapter.c | 5 ++--- > 1 file changed, 2 inser

Re: [dpdk-dev] [EXT] Re: [PATCH] eal: avoid side effects in RTE_ALIGN_MUL_NEAR(v, mul) for v and mul

2021-05-06 Thread Pavan Nikhilesh Bhagavatula
>On Wed, May 5, 2021 at 6:30 PM Tyler Retzlaff > wrote: >> >> On Fri, Mar 12, 2021 at 09:07:22AM +0100, David Marchand wrote: >> > On Thu, Mar 11, 2021 at 10:08 PM Tyler Retzlaff >> > wrote: >> > > >> > > Avoid expanding v and mul parameters multiple times in the >macro. based >> > > on usage of t

Re: [dpdk-dev] [EXT] [PATCH] event/cnxk: fix clang warning on Arm

2021-06-18 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Ruifeng Wang >Sent: Thursday, June 10, 2021 12:55 PM >To: Pavan Nikhilesh Bhagavatula ; Shijith >Thotton >Cc: dev@dpdk.org; n...@arm.com; Ruifeng Wang > >Subject: [EXT] [PATCH] event/cnxk: fix clang warning

RE: [PATCH] doc: deprecate graph data structures

2024-07-18 Thread Pavan Nikhilesh Bhagavatula
Thomas, Ping can this deprecation notice be merged > Acked-by: Zhirun Yan > > > -Original Message- > > From: Nithin Dabilpuram > > Sent: Tuesday, March 19, 2024 1:21 PM > > To: pbhagavat...@marvell.com > > Cc: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; >

RE: [PATCH] examples/eventdev: fix segment fault with generic pipeline

2024-08-18 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Van Haaren, Harry > Sent: Thursday, August 1, 2024 6:14 PM > To: Chengwen Feng ; tho...@monjalon.net; > dev@dpdk.org > Cc: wangchenxin...@huawei.com; Pavan Nikhilesh Bhagavatula > > Subject: [EXTERNAL] Re: [PATCH] examples/eventdev

RE: [PATCH] app/test-eventdev: wait for workers before cryptodev destroy

2022-06-12 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Thursday, June 2, 2022 5:15 PM > To: Jerin Jacob Kollanukkaran > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > Nikhilesh Bhagavatula > Subject: [PATCH] app/test-eventdev: wait for workers before cryptodev >

Re: [dpdk-dev] [PATCH v9 4/8] eventdev: add Rx adapter event vector support

2021-03-30 Thread Pavan Nikhilesh Bhagavatula
>> -Original Message- >> From: pbhagavat...@marvell.com >> Sent: Tuesday, March 30, 2021 1:52 PM >> To: jer...@marvell.com; Jayatheerthan, Jay >; Carrillo, Erik G >; Gujjar, >> Abhinandan S ; McDaniel, Timothy >; hemant.agra...@nxp.com; Van >> Haaren, Harry ; mattias.ronnblom >; Ma, Liang

Re: [dpdk-dev] [EXT] [PATCH v18 2/3] build: add 'platform' meson option and Arm SoC config

2021-04-09 Thread Pavan Nikhilesh Bhagavatula
>Add Arm SoC configuration sets to Arm meson.build and add an arch >agnostic meson option, 'platform', to select from these SoC >configurations for meson native builds. This is preferable to >specifying a cross file when doing aarch64 -> aarch64 builds, since the >cross file specifies the toolchain

Re: [dpdk-dev] [EXT] [PATCH v19 0/3] Arm build options rework

2021-04-12 Thread Pavan Nikhilesh Bhagavatula
Hi Juraj, >The current way of specifying Arm configuration options is insufficient >since we can't identify the SoC we're building for from the MIDR >information. For example, we can't distinguish between N1SDP, >Graviton2 >or Ampere Altra. > >We also want to be able to enable/disable which driver

RE: [EXT] Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

2022-01-20 Thread Pavan Nikhilesh Bhagavatula
>On Mon, Nov 8, 2021 at 8:15 AM Ruifeng Wang > wrote: >> >> > -Original Message- >> > From: pbhagavat...@marvell.com >> > Sent: Friday, November 5, 2021 4:57 PM >> > To: Ruifeng Wang ; >david.march...@redhat.com; >> > jer...@marvell.com >> > Cc: dev@dpdk.org; Pavan Nikhilesh >> > Subject:

Re: [dpdk-dev] [EXT] Re: [PATCH v6 1/3] net/thunderx: enable build only on 64-bit Linux

2021-10-15 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Ferruh Yigit >Sent: Friday, October 15, 2021 4:09 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; Maciej Czekaj [C] > >Cc: dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH v6 1/3] net/thunderx: enab

Re: [dpdk-dev] [EXT] [PATCH v3] app/test-eventdev: add burst enqueue support

2021-10-18 Thread Pavan Nikhilesh Bhagavatula
>This commit introduces a new command line option prod_enq_burst_sz >to set burst size for eventdev enqueue at producer in perf_queue >test. The newly added function perf_producer_burst is called when >prod_enq_burst_sz is greater than 1. > >Signed-off-by: Rashmi Shetty > LGTM Acked-by: Pavan Ni

Re: [dpdk-dev] [EXT] [PATCH] app/test-eventdev: fix terminal colour after control-c exit

2021-10-18 Thread Pavan Nikhilesh Bhagavatula
>Before this commit, a Control^C exit of the test-eventdev application >would print the worker packet percentages, and leave the terminal with >a green colour despite the colour reset being issued after the newline. >By moving the colour reset command before the \n the issue is fixed. > >Fixes: 6b1

Re: [dpdk-dev] [EXT] Re: [PATCH v4 14/14] eventdev: mark trace variables as internal

2021-10-18 Thread Pavan Nikhilesh Bhagavatula
>On Sat, Oct 16, 2021 at 12:34 AM wrote: >> >> From: Pavan Nikhilesh >> >> Mark rte_trace global variables as internal i.e. remove them >> from experimental section of version map. >> Some of them are used in inline APIs, mark those as global. >> >> Signed-off-by: Pavan Nikhilesh >> Acked-by: Ra

RE: [EXT] Re: [PATCH] doc: update Linux core isolation guide

2022-05-10 Thread Pavan Nikhilesh Bhagavatula
> On Mon, 2 May 2022 12:54:14 +0530 > Pavan Nikhilesh wrote: > > > Update Linux core isolation guide to include isolation from > > timers, rcu processing and IRQs. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > doc/guides/linux_gsg/enable_func.rst | 10 +- > > 1 file changed, 5 inse

RE: [EXT] Re: [PATCH v2] doc: update Linux core isolation guide

2022-05-17 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 17 May 2022 23:38:55 +0530 > wrote: > > > + > > +.. Note:: > > + > > + For more fine grained control over resource management and > performance tuning one can look > > + into ``Linux cgroups``. > > Please provide a better link than just search terms: > Sure, I will add

Re: [dpdk-dev] [EXT] [PATCH] eventdev: fix free of adapters storage

2021-10-21 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Erik Gabriel Carrillo >Sent: Thursday, October 21, 2021 1:50 AM >To: Jerin Jacob Kollanukkaran ; Pavan Nikhilesh >Bhagavatula >Cc: dev@dpdk.org >Subject: [EXT] [PATCH] eventdev: fix free of adapters stor

Re: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf when adding routes

2021-11-05 Thread Pavan Nikhilesh Bhagavatula
>> From: dev On Behalf Of >> pbhagavat...@marvell.com >> Sent: Sunday 3 October 2021 21:11 >> To: jer...@marvell.com >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH 2/3] examples/l3fwd: print port bdf >when >> adding routes >> >> From: Pavan Nikhilesh >> >> Since the number of

Re: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase number of routes

2021-11-05 Thread Pavan Nikhilesh Bhagavatula
>> From: dev On Behalf Of >> pbhagavat...@marvell.com >> Sent: Sunday 3 October 2021 21:25 >> To: david.march...@redhat.com; jer...@marvell.com >> Cc: dev@dpdk.org; Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH v4 1/3] examples/l3fwd: increase >number of >> routes >> >> From: Pavan Nikhilesh >>

Re: [dpdk-dev] [EXT] Re: [PATCH v4 3/3] examples/l3fwd: use reserved addresses for EM mode

2021-11-05 Thread Pavan Nikhilesh Bhagavatula
>On Sun, Oct 3, 2021 at 10:25 PM wrote: >> >> From: Pavan Nikhilesh >> >> The l3fwd example should use the reserved IPv4/v6 reserved address >> ranges defined in RFC5735, RFC5180 and RFC863 discard protocol for >> the port number in the exact match mode of L3 forwarding. >> >> Signed-off-by: Pava

Re: [dpdk-dev] [EXT] Re: compilation time of cnxk event driver

2021-11-08 Thread Pavan Nikhilesh Bhagavatula
alon ; Pavan Nikhilesh >Bhagavatula ; Shijith Thotton > >Cc: Jerin Jacob Kollanukkaran ; >david.march...@redhat.com; dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] compilation time of cnxk event driver > >External Email > >-

Re: [dpdk-dev] [EXT] [PATCH] app: fix buffer overrun

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>This patch fixes a possible buffer overrun problem in crypto perf test. >Previously when user configured aad size is over 12 bytes the copy of >template aad will cause a buffer overrun. >The problem is fixed by only copy up to 12 bytes of aad template. > >Fixes: 761a321acf91 ("event/cnxk: support

Re: [dpdk-dev] [EXT] [PATCH v2 1/5] eventdev/rx_adapter: add support to configure event buffer size

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>Currently Rx event buffer is static array with a default size >of 192(6*BATCH_SIZE). > >``rte_event_eth_rx_adapter_create_with_params`` api is added which >takes >``struct rte_event_eth_rx_adapter_params`` to configure event >buffer size in addition other params . The event buffer is >allocated fr

Re: [dpdk-dev] [EXT] [PATCH v2 2/5] test/event: add unit test for event buffer size config api

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>this patch adds unit test for >rte_event_eth_rx_adapter_create_with_params >api and validate all possible input combinations. > >Signed-off-by: Naga Harish K S V >--- > app/test/test_event_eth_rx_adapter.c | 53 >+--- > 1 file changed, 49 insertions(+), 4 deletions(-) > >di

Re: [dpdk-dev] [EXT] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Naga Harish K S V >Sent: Tuesday, September 21, 2021 2:52 PM >To: Jerin Jacob Kollanukkaran ; >jay.jayatheert...@intel.com >Cc: dev@dpdk.org >Subject: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per >queue event buffer configure su

Re: [dpdk-dev] [EXT] [PATCH v2 4/5] eventdev/rx_adapter: implement per queue event buffer

2021-09-21 Thread Pavan Nikhilesh Bhagavatula
>this patch implement the per queue event buffer after >required validations. > >Signed-off-by: Naga Harish K S V >--- > lib/eventdev/rte_event_eth_rx_adapter.c | 188 >++-- > 1 file changed, 139 insertions(+), 49 deletions(-) > >@@ -2277,6 +2356,8 @@ >rte_event_eth_rx_adapte

Re: [dpdk-dev] Arm roadmap for 21.11

2021-09-22 Thread Pavan Nikhilesh Bhagavatula
>> -Original Message- >> From: Thomas Monjalon >> Sent: Wednesday, September 22, 2021 3:27 PM >> To: Honnappa Nagarahalli ; Pavan >> Nikhilesh Bhagavatula ; >jer...@marvell.com >> Cc: dev@dpdk.org; David Marchand ; >> Ruifeng Wang ; nd >

Re: [dpdk-dev] [EXT] [PATCH v3] config/arm: split march cfg into arch and features

2021-07-20 Thread Pavan Nikhilesh Bhagavatula
>Older compilers may not support all arch versions and all features that >the target SoC supports, in which case it's better to figure out the >highest arch version and features that the compiler supports. >Implement >a way to achieve this: >1. Find the highest arch version that the compiler suppor

Re: [dpdk-dev] [EXT] Re: [PATCH v9 2/7] event/cnxk: add Rx adapter fastpath ops

2021-07-20 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: David Marchand >Sent: Tuesday, July 20, 2021 4:33 PM >To: Pavan Nikhilesh Bhagavatula >Cc: Jerin Jacob Kollanukkaran ; Shijith Thotton >; dev >Subject: [EXT] Re: [dpdk-dev] [PATCH v9 2/7] event/cnxk: add Rx >adapter fastpa

Re: [dpdk-dev] [EXT] Re: [PATCH] config/arm: add ability to express arch extensions

2021-07-29 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Juraj Linkeš >Sent: Tuesday, July 27, 2021 6:35 PM >To: Thomas Monjalon ; Bruce Richardson >; Pavan Nikhilesh Bhagavatula >; Honnappa Nagarahalli > >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; >Jan Viktorin ; R

RE: [dpdk-dev] [EXT] Re: compilation time of cnxk event driver

2021-11-11 Thread Pavan Nikhilesh Bhagavatula
' >{standard input}:4249: Error: reg pair must start from even reg at >operand 1 -- `caspl x25,x26,x25,x26,[x2]' >{standard input}:5262: Error: reg pair must start from even reg at >operand 1 -- `caspl x25,x26,x25,x26,[x2]' > >Regards, >Nipun > >

Re: [dpdk-dev] [EXT] [PATCH v1 2/5] app/eventdev: remove unnecessary barriers for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For "processed_pkts" and "total_latency" functions, no operations >should >keep the order that being executed before loading >"worker[i].processed_pkts". Thus rmb is unnecessary before loading. > >For "perf_launch_lcores" function, wmb after that the main lcore >updates the variable "t->done", whi

Re: [dpdk-dev] [EXT] [PATCH v1 5/5] app/eventdev: remove unnecessary barriers for order test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For the wmb in order_process_stage_1 and >order_process_stage_invalid in >the order test, they can be removed. This is because when the test >results >are wrong, the worker core writes 'true' to t->err. Then other worker >cores, producer cores and the main core will load the 'error' index and >sto

Re: [dpdk-dev] [EXT] [PATCH v1 3/5] app/eventdev: replace wmb with thread fence for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>Simply replace rte_smp barrier with atomic threand fence. > >Signed-off-by: Phil Yang >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_perf_common.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > >diff --g

Re: [dpdk-dev] [EXT] [PATCH v1 4/5] app/eventdev: remove unnecessary barriers for pipeline test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>For "processed_pkts" function, no operations should keep the order >that >being executed before loading "worker[i].processed_pkts". > >Signed-off-by: Feifei Wang >Reviewed-by: Ruifeng Wang Acked-by: Pavan Nikhilesh >--- > app/test-eventdev/test_pipeline_common.c | 1 - > 1 file changed, 1 deleti

Re: [dpdk-dev] [EXT] [PATCH v1 1/5] app/eventdev: fix SMP barrier bugs for perf test

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>This patch fixes RTE SMP barrier bugs for the perf test of eventdev. > >For the "perf_process_last_stage" function, wmb after storing >processed_pkts should be moved before it. This is because the worker >lcore should ensure it has really finished data processing, e.g. event >stored into buffers,

Re: [dpdk-dev] [EXT] [PATCH v4 3/3] examples/eventdev: move eth stop to the end

2021-01-25 Thread Pavan Nikhilesh Bhagavatula
>Move eth stop code from "signal_handler" function to the end of >"main" >function. There are two reasons for this: > >First, this improves code maintenance and makes code look simple and >clear. Based on this change, after receiving the interrupt signal, >"fdata->done" is set as 1. Then the main t

Re: [dpdk-dev] [PATCH v14 00/12] Arm build options rework

2021-01-27 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: dev On Behalf Of Honnappa >Nagarahalli >Sent: Wednesday, January 27, 2021 7:11 PM >To: Juraj Linkeš ; Pavan Nikhilesh >Bhagavatula ; >bruce.richard...@intel.com; Ruifeng Wang >; Phil Yang ; >vcchu...@amazon.com; Dharmik Thakk

Re: [dpdk-dev] [RFC PATCH] eventdev: use shared memory to store timer adapter

2021-02-12 Thread Pavan Nikhilesh Bhagavatula
>-Original Message- >From: Shijith Thotton >Sent: Friday, February 12, 2021 3:44 PM >To: Erik Gabriel Carrillo >Cc: Shijith Thotton ; Pavan Nikhilesh >Bhagavatula ; Jerin Jacob Kollanukkaran >; dev@dpdk.org >Subject: [RFC PATCH] eventdev: use shared memory

RE: [PATCH v1] event/cnxk: fix setting event attributes in empty get work

2023-04-26 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Shijith Thotton > Sent: Thursday, April 27, 2023 11:58 AM > To: Jerin Jacob Kollanukkaran > Cc: Shijith Thotton ; dev@dpdk.org; Pavan > Nikhilesh Bhagavatula ; sta...@dpdk.org > Subject: [PATCH v1] event/cnxk: fix setting event at

RE: [EXT] [PATCH v5 02/15] graph: split graph worker into common and default model

2023-04-27 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Zhirun Yan > Sent: Friday, March 31, 2023 9:33 AM > To: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Kiran > Kumar Kokkilagadda ; Nithin Kumar Dabilpuram > ; step...@networkplumber.org > Cc: cunming.li...@intel.com; haiyue.w...@intel.com; Zhirun Yan > > Subjec

RE: [EXT] [PATCH v5 09/15] graph: introduce stream moving cross cores

2023-04-27 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces key functions to allow a worker thread to > enable enqueue and move streams of objects to the next nodes over > different cores. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/graph_private.h| 27

RE: [EXT] [PATCH v5 11/15] graph: introduce graph walk by cross-core dispatch

2023-04-27 Thread Pavan Nikhilesh Bhagavatula
> This patch introduces the task scheduler mechanism to enable dispatching > tasks to another worker cores. Currently, there is only a local work > queue for one graph to walk. We introduce a scheduler worker queue in > each worker core for dispatching tasks. It will perform the walk on > scheduler

RE: [EXT] [PATCH v5 03/15] graph: move node process into inline function

2023-04-27 Thread Pavan Nikhilesh Bhagavatula
> Node process is a single and reusable block, move the code into an inline > function. > > Signed-off-by: Haiyue Wang > Signed-off-by: Cunming Liang > Signed-off-by: Zhirun Yan > --- > lib/graph/rte_graph_model_rtc.h | 20 ++--- > lib/graph/rte_graph_worker_common.h | 33 > +++

RE: [PATCH v2 2/3] ip_frag: improve reassembly lookup performance

2023-05-23 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Tuesday, May 23, 2023 9:39 AM > > To: jer...@marvell.com; Honnappa Nagarahalli > > ; nd ; Konstantin > Ananyev > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [PATCH v2 2/3] ip_frag: improve reassembly lookup perf

RE: [PATCH v2 2/3] ip_frag: improve reassembly lookup performance

2023-05-23 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Tuesday, May 23, 2023 11:29 PM > To: Honnappa Nagarahalli ; Jerin Jacob > Kollanukkaran ; nd ; Konstantin > Ananyev > Cc: dev@dpdk.org; nd ; nd > Subject: RE: [PATCH v2 2/3] ip_frag: i

RE: [EXT] Re: [PATCH v2 2/3] ip_frag: improve reassembly lookup performance

2023-05-29 Thread Pavan Nikhilesh Bhagavatula
> On Tue, 23 May 2023 20:09:20 +0530 > wrote: > > > From: Pavan Nikhilesh > > > > Improve reassembly lookup performance by using NEON intrinsics for > > key validation. > > > > Signed-off-by: Pavan Nikhilesh > > --- > > lib/ip_frag/ip_frag_internal.c | 224 +-- >

RE: [EXT] Re: [PATCH v3 1/2] ip_frag: optimize key compare and hash generation

2023-05-30 Thread Pavan Nikhilesh Bhagavatula
> On Mon, 29 May 2023 20:25:01 +0530 > wrote: > > > + return (k1->id_key_len != k2->id_key_len) || > > + (k1->key_len == IPV4_KEYLEN ? k1->src_dst[0] != k2->src_dst[0] : > > +rte_hash_k32_cmp_eq(k1, k2, > 32)); > > If you make another version, o

RE: [PATCH v2] event/cnxk: fix LMTST write for single event mode

2023-05-31 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Srujana Challa > Sent: Wednesday, May 31, 2023 4:03 PM > To: Pavan Nikhilesh Bhagavatula ; Shijith > Thotton ; Rahul Bhansali ; > Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Srujana Challa ; Nithin Kumar > Dabilpuram > Sub

RE: [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts

2024-02-06 Thread Pavan Nikhilesh Bhagavatula
> > On Feb 5, 2024, at 10:10 PM, Wathsala Wathawana Vithanage > wrote: > > > > Hi Pavan, > > > >> The compiler options march and mtune are a subset of mcpu and will lead > to > >> conflicts if improper march is chosen for a given mcpu. > >> To avoid conflicts, force part number march when mcpu is

RE: [EXT] Re: [PATCH] dmadev: standardize alignment and allocation

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> Hi Pavan, > > Alloc fp_objects from rte_memory is a good idea, but this may cause > the rte_memory memory leak, especially in multi-process scenario. > > Currently, there is no mechanism for releasing such a rte_memory which > don't belong to any driver. > Yeah, secondary process will leak rte

RE: [PATCH v2 3/3] config/arm: allow WFE to be enabled config time

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> > On Feb 1, 2024, at 3:57 PM, pbhagavat...@marvell.com wrote: > > > > From: Pavan Nikhilesh > > > > Allow RTE_ARM_USE_WFE to be enabled at meson configuration > > time by passing it via c_args instead of modifying > > `config/arm/meson.build`. > > > > Example usage: > > meson build -Dc_args='-DR

RE: [PATCH v3 1/3] config/arm: avoid mcpu and march conflicts

2024-02-09 Thread Pavan Nikhilesh Bhagavatula
> > > wrote: > > > > > > > > Hi Pavan, > > > > > > > >> The compiler options march and mtune are a subset of mcpu and will > > > >> lead > > > to > > > >> conflicts if improper march is chosen for a given mcpu. > > > >> To avoid conflicts, force part number march when mcpu is available > > > >> a

RE: [PATCH v2 3/3] config/arm: allow WFE to be enabled config time

2024-02-10 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Honnappa Nagarahalli > Sent: Saturday, February 10, 2024 10:07 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; juraj.lin...@pantheon.tech; nd > ; Ruifeng Wang ; Bruce Richardson > ; dev@dpdk.org; Chengwen Feng > ; Wath

RE: [EXT] Re: [PATCH v4 1/3] config/arm: avoid mcpu and march conflicts

2024-02-22 Thread Pavan Nikhilesh Bhagavatula
> > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 36f21d2259..e77b696d8e 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > > @@ -695,13 +698,31 @@ if update_flags > > > > machine_args = [] # Clear previous machine args > > > > +candidate

RE: [EXT] Re: [PATCH v4 2/3] config/arm: add support for fallback march

2024-02-22 Thread Pavan Nikhilesh Bhagavatula
> On Wed, Feb 21, 2024 at 9:20 PM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [EXT] [PATCH v4 01/12] eventdev: improve doxygen introduction text

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Make some textual improvements to the introduction to eventdev and event > devices in the eventdev header file. This text appears in the doxygen > output for the header file, and introduces the key concepts, for > example: events, event devices, queues, ports and scheduling. > > This patch makes

RE: [EXT] [PATCH v4 02/12] eventdev: move text on driver internals to proper section

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Inside the doxygen introduction text, some internal details of how > eventdev works was mixed in with application-relevant details. Move > these details on probing etc. to the driver-relevant section. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > --- > lib/eventdev/rte_eve

RE: [EXT] [PATCH v4 03/12] eventdev: update documentation on device capability flags

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Update the device capability docs, to: > > * include more cross-references > * split longer text into paragraphs, in most cases with each flag having > a single-line summary at the start of the doc block > * general comment rewording and clarification as appropriate > > Signed-off-by: Bruce R

RE: [EXT] [PATCH v4 04/12] eventdev: cleanup doxygen comments on info structure

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Some small rewording changes to the doxygen comments on struct > rte_event_dev_info. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > > --- > V3: reworked following feedback > - added closing "." on comments > - added more cross-reference links > - reworded priority level com

RE: [EXT] [PATCH v4 05/12] eventdev: improve function documentation for query fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> General improvements to the doxygen docs for eventdev functions for > querying basic information: > * number of devices > * id for a particular device > * socket id of device > * capability information for a device > > Signed-off-by: Bruce Richardson > Acked-by: Pavan Nikhilesh > --- > V3:

RE: [EXT] [PATCH v4 06/12] eventdev: improve doxygen comments on configure struct

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> General rewording and cleanup on the rte_event_dev_config structure. > Improved the wording of some sentences and created linked > cross-references out of the existing references to the dev_info > structure. > > As part of the rework, fix issue with how single-link port-queue pairs > were counte

RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments on config fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Improve the documentation text for the configuration functions and > structures for configuring an eventdev, as well as ports and queues. > Clarify text where possible, and ensure references come through as links > in the html output. > > Signed-off-by: Bruce Richardson Pavan Nikhilesh > >

RE: [EXT] [PATCH v4 08/12] eventdev: improve doxygen comments for control APIs

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The doxygen comments for the port attributes, start and stop (and > related functions) are improved. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > > --- > V3: add missing "." on end of sentences/lines. > --- > lib/eventdev/rte_eventdev.h | 47 +++--

RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments on config fns

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Pavan Nikhilesh Bhagavatula > Sent: Monday, February 26, 2024 12:13 PM > To: Bruce Richardson ; dev@dpdk.org; Jerin > Jacob ; mattias.ronnb...@ericsson.com > Subject: RE: [EXT] [PATCH v4 07/12] eventdev: improve doxygen comments > on conf

RE: [EXT] [PATCH v4 09/12] eventdev: improve comments on scheduling types

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The description of ordered and atomic scheduling given in the eventdev > doxygen documentation was not always clear. Try and simplify this so > that it is clearer for the end-user of the application > > Signed-off-by: Bruce Richardson > Acked-by: Pavan Nikhilesh > --- > V4: reworked follow

RE: [EXT] [PATCH v4 10/12] eventdev: clarify docs on event object fields and op types

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Clarify the meaning of the NEW, FORWARD and RELEASE event types. > For the fields in "rte_event" struct, enhance the comments on each to > clarify the field's use, and whether it is preserved between enqueue and > dequeue, and it's role, if any, in scheduling. > > Signed-off-by: Bruce Richardson

RE: [EXT] [PATCH v4 11/12] eventdev: drop comment for anon union from doxygen

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Make the comments on the unnamed unions in the rte_event structure > regular comments rather than doxygen ones. The comments do not add > anything meaningful to the doxygen output. > > Signed-off-by: Bruce Richardson Acked-by: Pavan Nikhilesh > --- > lib/eventdev/rte_eventdev.h | 4 ++-- >

RE: [EXT] [PATCH v4 12/12] eventdev: fix doxygen processing of event vector struct

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> The event vector struct was missing comments on two members, and also > was inadvertently creating a local variable called "__rte_aligned" in > the doxygen output. > > Correct the comment markers to fix the former issue, and fix the latter > by putting "#ifdef __DOXYGEN" around the alignment con

RE: [EXT] Re: [PATCH v5 1/3] config/arm: avoid mcpu and march conflicts

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> Other than the one point below, > Reviewed-by: Juraj Linkeš > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > index 36f21d2259..d05d54b564 100644 > > --- a/config/arm/meson.build > > +++ b/config/arm/meson.build > > > @@ -695,13 +698,37 @@ if update_flags > > > > mach

RE: [EXT] Re: [PATCH v5 2/3] config/arm: add support for fallback march

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> On Thu, Feb 22, 2024 at 1:45 PM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; > > Yan, Zhirun ; Pavan Nikhilesh > > ; Ruifeng Wang ; > > Richardson, Bruce ; Konstantin Ananyev > > > >

RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors

2024-02-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Thursday, February 22, 2024 8:24 PM > > To: jer...@marvell.com; ndabilpu...@marvell.com; > kirankum...@marvell.com; > > Yan, Zhirun > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subject: [24.11 PATCH v3 1/5] graph: add suppo

RE: [EXT] [PATCH v1] app/test: fix segfault in Tx adapter autotest

2024-02-26 Thread Pavan Nikhilesh Bhagavatula
> Uninitialized mbufs are enqueued to eventdev which causes segfault > on freeing the mbuf in tx adapter. > Fixed by initializing mbufs before enqueuing to eventdev. > > Fixes: 46cf97e4bbfa ("eventdev: add test for eth Tx adapter") > > Signed-off-by: Ganapati Kundapura Acked-by: Pavan Nikhilesh

RE: [PATCH v2] app/eventdev: support DMA adapter test

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Amit Prakash Shukla > Sent: Wednesday, February 28, 2024 11:31 AM > To: Jerin Jacob > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > ; Vamsi Krishna Attunuru > ; Nithin Kumar Dabilpuram > ; Anoob Joseph ; Aakash > Sasid

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, March 1, 2024 10:10 PM > To: dev@dpdk.org > Cc: Jerin Jacob ; Pavan Nikhilesh Bhagavatula > ; Konstantin Ananyev > ; sta...@dpdk.org > Subject: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not re

RE: [EXTERNAL] [PATCH] examples/l3fwd: fix Rx over not ready port

2024-03-01 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Konstantin Ananyev > Sent: Friday, March 1, 2024 10:43 PM > To: Pavan Nikhilesh Bhagavatula ; Konstantin > Ananyev ; dev@dpdk.org > Cc: Jerin Jacob ; sta...@dpdk.org > Subject: RE: [EXTERNAL] [PATCH] examples/l3fwd: fix R

RE: [PATCH v4 1/2] config: correct cpu instruction set for cross build

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Joyce Kong > Sent: Friday, December 8, 2023 8:21 AM > To: Stephen Hemminger > Cc: tho...@monjalon.net; Ruifeng Wang ; > bruce.richard...@intel.com; dev@dpdk.org; nd ; > sta...@dpdk.org > Subject: [EXT] RE: [PATCH v4 1/2] config: correct cpu instruction set

RE: [EXT] Re: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Stephen Hemminger > Sent: Friday, December 8, 2023 4:12 AM > To: Joyce Kong > Cc: tho...@monjalon.net; ruifeng.w...@arm.com; > bruce.richard...@intel.com; dev@dpdk.org; n...@arm.com; Honnappa > Nagarahalli > Subject: [EXT] Re: [PATCH v4 2/2] config/arm: us

RE: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimum march requirement

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Ruifeng Wang > Sent: Thursday, January 18, 2024 7:32 AM > To: Pavan Nikhilesh Bhagavatula ; Jerin Jacob > ; Bruce Richardson > Cc: dev@dpdk.org; sta...@dpdk.org; n...@arm.com > Subject: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimu

RE: [EXT] Re: [PATCH 2/2] config/arm: add armv9-a march

2024-01-19 Thread Pavan Nikhilesh Bhagavatula
> On 2024/1/4 5:18 PM, pbhagavat...@marvell.com wrote: > > From: Pavan Nikhilesh > > > > Now that major versions of GCC recognize armv9-a march option, > > add it to the list of supported march. > > Update neoverse-n2 part number to include march as armv9-a. > > > > Signed-off-by: Pavan Nikhilesh

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-22 Thread Pavan Nikhilesh Bhagavatula
> On Sun, Jan 21, 2024 at 10:37 AM wrote: > > > > From: Pavan Nikhilesh > > > > The compiler options march and mtune are a subset > > of mcpu and will lead to conflicts if improper march > > is chosen for a given mcpu. > > To avoid conflicts, force part number march when > > mcpu is available and

RE: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback march

2024-01-22 Thread Pavan Nikhilesh Bhagavatula
> On Sun, Jan 21, 2024 at 10:37 AM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:57 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 1/2] config/a

RE: [EXT] Re: [PATCH 2/2] config/arm: add support for fallback march

2024-01-24 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 22, 2024 9:59 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 2/2] config/arm:

RE: [EXT] Re: [PATCH 1/2] config/arm: avoid mcpu and march conflicts

2024-01-30 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Juraj Linkeš > Sent: Monday, January 29, 2024 2:15 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; ruifeng.w...@arm.com; > n...@arm.com; Bruce Richardson ; > dev@dpdk.org > Subject: Re: [EXT] Re: [PATCH 1/2] config/a

RE: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files

2024-05-28 Thread Pavan Nikhilesh Bhagavatula
> On Mon, May 27, 2024 at 09:04:29PM +0530, pbhagavat...@marvell.com > wrote: > > From: Pavan Nikhilesh > > > > Disable building template files when CNXK_DIS_TMPLT_FUNC > > is defined as a part of c_args. > > This option can be used when reworking datapath or debugging > > issues to reduce Rx/Tx p

RE: [EXTERNAL] Re: [PATCH v5] cnxk: disable building template files

2024-05-28 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, May 28, 2024 3:10 PM > To: Pavan Nikhilesh Bhagavatula > Cc: Jerin Jacob ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Harman K

RE: [EXTERNAL] Re: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops

2024-05-30 Thread Pavan Nikhilesh Bhagavatula
msi Krishna Attunuru > > > > > > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula > > > > > > Subject: [PATCH v3 1/2] eventdev/dma: reorganize event DMA ops > > > > > > From: Pavan Nikhilesh > > > > > > Re-organize event DMA ops

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-04 Thread Pavan Nikhilesh Bhagavatula
> > 03/07/2024 15:27, Wathsala Wathawana Vithanage: > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED #ifdef block. > > > > > This patch fixes this issue by moving __RTE_ARM_WFE out of > > > > > RTE_WAIT_UNTIL_EQUAL_ARCH_DEFINED block. > > > > > > > > > > Perhaps we should change RTE_ARM_USE_WFE to somethi

RE: [EXTERNAL] Re: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> 04/07/2024 16:55, Stephen Hemminger: > > On Thu, 04 Jul 2024 16:14:42 +0200 > > Thomas Monjalon wrote: > > > > > > > Let’s ask Pavan why this flag is used in cn10k driver. > > > > > > > > > > From our perspective, WFE is available on all the supported arm > platforms in > > > > > DPDK. > > > > >

RE: [PATCH v2 2/2] eal: add Arm WFET in power management intrinsics

2024-07-05 Thread Pavan Nikhilesh Bhagavatula
> -Original Message- > From: Wathsala Wathawana Vithanage > Sent: Friday, July 5, 2024 9:32 PM > To: Pavan Nikhilesh Bhagavatula ; > tho...@monjalon.net > Cc: Tyler Retzlaff ; Ruifeng Wang > ; dev@dpdk.org; nd ; Dhruv > Tripathi ; Honnappa Nagarahalli >

RE: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops

2023-07-25 Thread Pavan Nikhilesh Bhagavatula
> > -Original Message- > > From: Ferruh Yigit > > Sent: Tuesday, July 25, 2023 2:11 PM > > To: Sivaprasad Tummala ; dev@dpdk.org > > Cc: bruce.richard...@intel.com; david.march...@redhat.com; > > tho...@monjalon.net; jerinjac...@gmail.com; techbo...@dpdk.org > > Subject: Re: [PATCH v1] doc

  1   2   3   4   5   6   >