[dpdk-dev] [PATCH 1/4] bnx2x: fix build as shared library

2015-07-28 Thread Thomas Monjalon
Build log: Must Specify a librte_pmd_bnx2x.so..1 ABI version Signed-off-by: Thomas Monjalon --- drivers/net/bnx2x/Makefile | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnx2x/Makefile b/drivers/net/bnx2x/Makefile index 0de5db9..87f31b6 100644 --- a/drivers/net

[dpdk-dev] [PATCH 2/4] bnx2x: fix build with debug enabled

2015-07-28 Thread Thomas Monjalon
using WARN instead of WARNING. Some debug messages had some extra parameters. Signed-off-by: Thomas Monjalon --- drivers/net/bnx2x/bnx2x.c | 22 +++--- drivers/net/bnx2x/bnx2x_logs.h | 2 +- drivers/net/bnx2x/ecore_init.h | 3 +-- drivers/net/bnx2x/ecore_sp.c | 12

[dpdk-dev] [PATCH 3/4] bnx2x: fix build with clang

2015-07-28 Thread Thomas Monjalon
Build log: error: unused function 'bnx2x_hilo' No need to keep an unused function. Signed-off-by: Thomas Monjalon --- drivers/net/bnx2x/bnx2x_stats.c | 12 1 file changed, 12 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index

[dpdk-dev] [PATCH] config: disable bnx2x driver

2015-07-28 Thread Thomas Monjalon
issues are not fixed in the next release 2.2, the driver must be removed. Signed-off-by: Thomas Monjalon --- config/common_linuxapp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/common_linuxapp b/config/common_linuxapp index 72373b6..bda9a63 100644 --- a/config

[dpdk-dev] [PATCH] hash: fix crash when adding already inserted keys

2015-07-28 Thread Thomas Monjalon
> > When adding with cuckoo hash a key which was already inserted > > a new slot is dequeued and then enqueued back, but the enqueue > > operation was not done properly. > > > > Signed-off-by: Xavier Simonart > Acked-by: Sergio Gonzalez Monroy Fixes: 48a399119619 ("hash: replace with cuckoo

[dpdk-dev] [PATCH] config: disable bnx2x driver

2015-07-29 Thread Thomas Monjalon
2015-07-28 19:16, Thomas Monjalon: > This driver has too many issues: > - too big > - bad coding style > - no git history (dropped in 2 patches) > - no documentation > - no BSD support > - no maintainer > And the biggest one, con

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 06:48, Helin Zhang: > It fixes the build error of implicit declaration of function. What is the error? Please show the build log and describe the case when it happens (compiler, version).

[dpdk-dev] [PATCH] test-pmd: show pci address in port info

2015-07-29 Thread Thomas Monjalon
2015-07-29 09:05, Michael Qiu: > pci address is one important info for port. > This patch make it visible for port info. > > Signed-off-by: Michael Qiu Maybe you missed this thread: http://dpdk.org/ml/archives/dev/2015-July/022107.html > + if (strncmp(":00:00.0", pci_addr, 12))

[dpdk-dev] [PATCH 2/2] virtio: allow running w/o vlan filtering

2015-07-29 Thread Thomas Monjalon
Back on this old patch, it seems justified but nobody agreed. --- a/lib/librte_pmd_virtio/virtio_ethdev.c +++ b/lib/librte_pmd_virtio/virtio_ethdev.c @@ -1288,7 +1288,6 @@ virtio_dev_configure(struct rte_eth_dev *dev) && !vtpci_with_feature(hw, VIRTIO_NET_F_CTRL_VLAN)) {

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
tle to: eal: fix build with pci config enabled and add this into the message: Build log: lib/librte_eal/common/eal_common_pci.c:188:4: error: implicit declaration of function pci_config_space_set > > -Original Message- > > From: Thomas

[dpdk-dev] [PATCH] eal: fix build

2015-07-29 Thread Thomas Monjalon
2015-07-29 15:09, Zhang, Helin: > From: Gonzalez Monroy, Sergio > > Fixes: 4d4ebca4 ("pci: merge probing and closing functions for linux and > > bsd") > > > > The function rte_eal_pci_probe_one_driver, which calls pci_config_space_set, > > was moved to eal_common_pci.c, but pci_config_space_set

[dpdk-dev] [PATCH 1/2] virtio: initialize iopl when device is initialized

2015-07-29 Thread Thomas Monjalon
2015-03-06 08:20, Stephen Hemminger: > The issue is that virtio has no place it can do iopl() and have the IRQ thread > work. It only shows up on real code where application is daemon, not in a toy > demo or test application. > > Right now: > gcc start >rte_virtio_pmd_init >

[dpdk-dev] [PATCH] testpmd: Fix segment fault when port ID greater than 76

2015-07-30 Thread Thomas Monjalon
2015-07-29 02:32, Michael Qiu: > In testpmd, when using "rx_vlan add 1 77", it will be a segment fault > Because the port ID should be less than 32. > > Signed-off-by: Michael Qiu Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Applied, thanks

[dpdk-dev] [PATCH] testpmd: Fix wrong message in testpmd

2015-07-30 Thread Thomas Monjalon
2015-06-24 15:56, Michael Qiu: > When close one port twice, testpmd will give out wrong messagse. > > testpmd> port stop 0 > Stopping ports... > Checking link statuses... > Port 0 Link Up - speed 0 Mbps - full-duplex > Port 1 Link Up - speed 0 Mbps - full-duplex > Done > testpmd> port close 0 >

[dpdk-dev] [PATCH v3] i40evf: fix crash when setup tx queues on vf port

2015-07-30 Thread Thomas Monjalon
> This patch fixes the issue: > Testpmd crashed with Segmentation fault when setup tx queues on vf > Steps for reproduce: > - create one vf device from i40e driver > - bind vf device to igb_uio and start testpmd > > With debugging tools, we saw the struct i40e_vf is cleared after >

[dpdk-dev] [PATCHv2 0/2] ixgbe: Two fixes for RX scatter functions.

2015-07-30 Thread Thomas Monjalon
> Acked-by: Wenzhuo Lu Applied, thanks

[dpdk-dev] [PATCH v1 1/1] ixgbe: Fix oerrors by setting it to 0

2015-07-30 Thread Thomas Monjalon
> > Fix afebc86be1346136125af8026dc215f81c202c50. oerrors was txdgpc - > > hw_stats->gptc, txdgpc is the number of packets DMA'ed by the host > > and was being reset on every call to read stats so it could be < gptc. > > Because we currently have no way to add txdgpc to struct hw_stats so > > that

[dpdk-dev] [PATCH v4] ixgbe: fix data access on big endian cpu.

2015-07-30 Thread Thomas Monjalon
> > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...) > > 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...) > > 3. checking pci status with converted constant > > > > Signed-off-by: Xuelin Shi > > Acked-by: Konstantin Ananyev Applied without added blank lines, thanks

[dpdk-dev] [PATCH v2] Make the thash library arch-independent

2015-07-30 Thread Thomas Monjalon
2015-07-29 09:56, Vladimir Medvedkin: > v2 changes > - Fix SSE to SSE3 typo > - remove unnecessary comments > - Leave unalligned union rte_thash_tuple if no support for SSE3 > - Makes 32bit compiler happy by adding ULL suffix > > Signed-off-by: Vladimir Medvedkin Applied, thanks

[dpdk-dev] [PATCH] eal: fix build

2015-07-30 Thread Thomas Monjalon
2015-07-29 17:08, Thomas Monjalon: > 2015-07-29 15:00, Zhang, Helin: > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pci.c: > > In function ???rte_eal_pci_probe_one_driver???: > > /home/hzhan75/r22/isg_cid-dpdk_org/lib/librte_eal/common/eal_common_pc

[dpdk-dev] abi change announce

2015-07-30 Thread Thomas Monjalon
2015-07-30 09:25, Xie, Huawei: > Hi Thomas: > I am doing virtio/vhost performance optimization, so there is possibly > some change, for example to virtio or vhost virtqueue data structure. > Do i need to announce the ABI change even if the change hasn't been > determined? I have no strong

[dpdk-dev] how to compile kernel drivers only

2015-07-30 Thread Thomas Monjalon
2015-07-30 12:17, Montorsi, Francesco: > How can I avoid building any app like dump_cfg? In app/Makefile, you'll find the options to disable: DIRS-$(CONFIG_RTE_APP_TEST) += test DIRS-$(CONFIG_RTE_LIBRTE_ACL) += test-acl

[dpdk-dev] how to compile kernel drivers only

2015-07-30 Thread Thomas Monjalon
Francesco, please reply below (easier to follow the thread). 2015-07-30 12:48, Montorsi, Francesco: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-07-30 12:17, Montorsi, Francesco: > > > How can I avoid building any app like dump_cfg? > > > >

[dpdk-dev] [PATCH] pci: fix build on FreeBSD

2015-07-30 Thread Thomas Monjalon
twice: .pi_data = *(u_int32_t *)buf memcpy(_data, buf, len); Signed-off-by: Thomas Monjalon --- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c index

[dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions

2015-07-30 Thread Thomas Monjalon
2015-07-30 10:12, Olivier MATZ: > Hi Thomas & Ravi, > > On 07/27/2015 02:59 AM, Thomas Monjalon wrote: > > 2015-07-27 02:56, Thomas Monjalon: > >> v9 was a subset of previous deduplications by Ravi Kerur. > >> This v10 address the comments I've done on v9.

[dpdk-dev] Issue with non-scattered rx in ixgbe and i40e when mbuf private area size is odd

2015-07-30 Thread Thomas Monjalon
2015-07-30 13:22, Olivier MATZ: > On 07/30/2015 11:43 AM, Ananyev, Konstantin wrote: > > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > >> On 07/30/2015 11:00 AM, Ananyev, Konstantin wrote: > >>> From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > On 07/29/2015 10:24 PM, Zhang,

[dpdk-dev] [PACTH v2 2/2] mlx4: fix shared library dependency

2015-07-30 Thread Thomas Monjalon
2015-07-30 16:48, Nelio Laranjeiro: > librte_pmd_mlx4.so needs to be linked with libiverbs otherwise, the PMD is not > able to open Mellanox devices and the following message is printed by testpmd > at startup "librte_pmd_mlx4: cannot access device, is mlx4_ib loaded?". > > Applications

[dpdk-dev] [PATCH v3 0/6] log de-spamming

2015-07-30 Thread Thomas Monjalon
2015-07-09 16:01, Stephen Hemminger: > From: Stephen Hemminger > > These patches were sent earlier, updated to current tree. > > They make Intel drivers not spam the log with information > messages that cause questions in production. > > Unfortunately, developers seem to get attached to log

[dpdk-dev] [PATCH v3 3/6] ixgbe: allow pruning log during build

2015-07-30 Thread Thomas Monjalon
2015-07-09 16:01, Stephen Hemminger: > From: Stephen Hemminger > > The ixgbe driver was not following DPDK convention and > was leaving loggin always in even if LOG_LEVEL was configured > to disable debug logs. > > Signed-off-by: Stephen Hemminger This series is fixing e1000 and ixgbe. There

[dpdk-dev] [PATCH v2] enic: silence log message unless debug enabled

2015-07-30 Thread Thomas Monjalon
2015-07-30 10:03, Stephen Hemminger: > --- a/drivers/net/enic/enic_compat.h > +++ b/drivers/net/enic/enic_compat.h > @@ -82,7 +82,11 @@ > #define dev_err(x, args...) dev_printk(ERR, args) > #define dev_info(x, args...) dev_printk(INFO, args) > #define dev_warning(x, args...)

[dpdk-dev] config files maintenance

2015-07-31 Thread Thomas Monjalon
Hi, Currently most of the build options are duplicated in 2 config files. They should be merged in a common file to avoid this kind of differences: --- config/common_bsdapp +++ config/common_linuxapp -CONFIG_RTE_IXGBE_INC_VECTOR=n +CONFIG_RTE_IXGBE_INC_VECTOR=y

[dpdk-dev] config files maintenance

2015-07-31 Thread Thomas Monjalon
2015-07-31 15:29, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Can we remove i40e bulk alloc option? > > As the receiving functions are different for bulk_alloc or not, we need this > flag. What brings the non bulk alloc function? Why is it disabled for BSD?

[dpdk-dev] conflict between ether_addr defined in rte_ether.h and the same structure in

2015-07-31 Thread Thomas Monjalon
Hi Francesco, 2015-07-31 15:18, Montorsi, Francesco: > I 'm attempting to integrate DPDK code in an existing application, > which includes . > That standard glibc header already provides a structure named ether_addr Yes it's a known problem. See http://dpdk.org/dev/patchwork/patch/2175/

[dpdk-dev] config files maintenance

2015-07-31 Thread Thomas Monjalon
2015-07-31 15:39, Zhang, Helin: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-07-31 15:29, Zhang, Helin: > > > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > > > Can we remove i40e bulk alloc option? > > > > &g

[dpdk-dev] config files maintenance

2015-07-31 Thread Thomas Monjalon
2015-07-31 17:08, Thomas Monjalon: > Can we enable ixgbe SSE on BSD? > CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE must be renamed to > CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE, or can we remove this option? > Can we remove i40e bulk alloc option? > Why IEEE1588 is disabled? Can we remove this op

[dpdk-dev] [PATCH 0/3] sync linux/bsd config options

2015-08-01 Thread Thomas Monjalon
Fix config options for ixgbe, i40e and KNI for BSD. Thomas Monjalon (3): ixgbe: fix offload config option name config: enable same drivers options for linux and bsd config: remove kni options for bsd config/common_bsdapp | 17 +++-- doc/guides/nics/ixgbe.rst | 6

[dpdk-dev] [PATCH 1/3] ixgbe: fix offload config option name

2015-08-01 Thread Thomas Monjalon
The RX_OLFLAGS option was renamed from DISABLE to ENABLE in driver code and linux config. It is now renamed also in bsd config and documentation. Fixes: 359f106a69a9 ("ixgbe: prefer enabling olflags rather than not disabling") Signed-off-by: Thomas Monjalon --- config/common_bsdap

[dpdk-dev] [PATCH 2/3] config: enable same drivers options for linux and bsd

2015-08-01 Thread Thomas Monjalon
Enable vector ixgbe and i40e bulk alloc for bsd as it is already done for linux. Fixes: 304caba12643 ("config: fix bsd options") Fixes: 0ff3324da2eb ("ixgbe: rework vector pmd following mbuf changes") Signed-off-by: Thomas Monjalon --- config/common_bsdapp | 4 ++-

[dpdk-dev] [PATCH 3/3] config: remove kni options for bsd

2015-08-01 Thread Thomas Monjalon
KNI is a Linux-only kernel module. Signed-off-by: Thomas Monjalon --- config/common_bsdapp | 11 --- 1 file changed, 11 deletions(-) diff --git a/config/common_bsdapp b/config/common_bsdapp index 1e0c625..b37dcf4 100644 --- a/config/common_bsdapp +++ b/config/common_bsdapp @@ -414,17

[dpdk-dev] [PATCH] cxgbe: fix build with clang

2015-07-01 Thread Thomas Monjalon
GCC_VERSION is empty in case of clang: /bin/sh: line 0: test: -ge: unary operator expected It cannot be quoted because an integer is expected. So the fix is to check empty value in a separate test. Signed-off-by: Thomas Monjalon --- drivers/net/cxgbe/Makefile | 4 ++-- 1 file changed

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-01 Thread Thomas Monjalon
2015-05-12 05:30, Qiu, Michael: > Hi, thomas > > What about this patch? It seems this patch was not *really* sent to dev at dpdk.org. Please re-send, keeping the Acked-by line. > On 4/16/2015 4:09 PM, Chen, Jing D wrote: > > From: Michael Qiu [mailto:qiudayu at cn.ibm.com] > >> From: Michael

[dpdk-dev] [PATCH 1/2] ethdev: add api to set default mac address

2015-06-02 Thread Thomas Monjalon
2015-06-02 10:52, Ananyev, Konstantin: > From: Wang, Liang-min > > int > > +rte_eth_dev_default_mac_addr_set(uint8_t port_id, struct ether_addr *addr) > > +{ > > + struct rte_eth_dev *dev; > > + > > + if (!rte_eth_dev_is_valid_port(port_id)) { > > + PMD_DEBUG_TRACE("Invalid

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
2015-05-29 15:26, Liang-Min Larry Wang: > adding a new library based upon ethdev APIs to provide API's that bear > the same functionality as ethtool_ops (linux/ethtool.h) and net_device_ops > (linux/netdevice.h). > > Signed-off-by: Liang-Min Larry Wang > --- > MAINTAINERS

[dpdk-dev] [PATCH] doc: add coding standards documentation

2015-06-02 Thread Thomas Monjalon
2015-05-13 16:30, Bruce Richardson: > Add coding standards document to guides directory. This document > codifies the current DPDK C coding conventions, to make it easier for > contributors to see the format their code should be in. > > Signed-off-by: Bruce Richardson > Signed-off-by: Siobhan

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
Wang, hope it's clear that any new development is welcomed. One step before integration is to clearly explain why your code is needed. That's why a nack vote may help to discuss and decide. Comments below 2015-06-02 13:15, Wang, Liang-min: > >2015-05-29 15:26, Liang-Min Larry Wang: > >> adding a

[dpdk-dev] [PATCH] examples/load_balancer: fix build with gcc 5.1

2015-06-02 Thread Thomas Monjalon
GCC 5.1 detects more out-of-bounds accesses: error: array subscript is above array bounds [-Werror=array-bounds] Signed-off-by: Thomas Monjalon --- examples/load_balancer/config.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/examples

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
2015-06-02 15:47, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to > > >>rte_ethtool_net_change_mtu() will help anyone. > >> > >> As described, this

[dpdk-dev] [PATCH] librte_pmd_fm10k: Fix max_vfs issue in fm10k PMD

2015-06-02 Thread Thomas Monjalon
2015-06-02 10:28, Michael Qiu: > In DPDK, max_vfs means vf numbers created, not the max number vfs > the device supported. > > Signed-off-by: Michael Qiu > Acked-by Jing Chen Applied, thanks

[dpdk-dev] [PATCH] config:enlarge the default value of RTE_MAX_QUEUES_PER_PORT to 1024

2015-06-02 Thread Thomas Monjalon
2015-06-01 01:00, Zhang, Helin: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Jijiang Liu > > The default value of RTE_MAX_QUEUES_PER_PORT is 256, which is too small for > > some configurations for i40e. There will return an error when configured > > queue > > number is larger than

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-02 Thread Thomas Monjalon
I have the feeling we are not progressing in this discussion. Please bring new explanations or I'll give up. David Harton already acked it so maybe he could explain why it is useful. Comments below 2015-06-02 17:06, Wang, Liang-min: > >2015-06-02 15:47, Wang, Liang-min: > >&g

[dpdk-dev] [PATCH] examples: add ip version check for l3fwd app

2015-06-03 Thread Thomas Monjalon
2015-05-15 17:08, Andrey Chilikin: > Added optional ip version check to l3fwd app to allow to detect > the ip version if mbuf ol_flags are not set in case of running > in a VM with emulated network controllers > > Signed-off-by: Andrey Chilikin [...] > +#define DO_IP_VERSION_CHECK 0

[dpdk-dev] [PATCH v2] l3fwd: make destination mac address configurable

2015-06-03 Thread Thomas Monjalon
2015-05-18 13:13, Andrey Chilikin: > Add a command-line parameter to l3fwd, to allow the user to specify the > destination mac address for each ethernet port used. > > v2 changes: > - apply command-line parameter to fast path as well (val_eth) > > Signed-off-by: Andrey Chilikin >

[dpdk-dev] [PATCH] examples: add ip version check for l3fwd app

2015-06-03 Thread Thomas Monjalon
2015-06-03 08:24, Chilikin, Andrey: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > 2015-05-15 17:08, Andrey Chilikin: > > > Added optional ip version check to l3fwd app to allow to detect the ip > > > version if mbuf ol_flags are not set

[dpdk-dev] [PATCH v2] Add toeplitz hash algorithm used by RSS

2015-06-03 Thread Thomas Monjalon
2015-05-08 10:58, Vladimir Medvedkin: > Software implementation of the Toeplitz hash function used by RSS. > Can be used either for packet distribution on single queue NIC > or for simulating of RSS computation on specific NIC (for example > after GRE header decapsulating). > > v3 changes > -

[dpdk-dev] [PATCH v2 0/4] fix compilation on Fedora 22

2015-06-03 Thread Thomas Monjalon
2015-05-29 12:57, Neil Horman: > On Fri, May 29, 2015 at 03:34:12PM +0100, Bruce Richardson wrote: > > V2 Changes: > > * use RTE_MIN instead of additional comparison checks > > in some loops, as suggested by Neil. > > * For stats reset in null PMD, just use the size of the > > array [which is

[dpdk-dev] [PATCH] examples/load_balancer: fix build with gcc 5.1

2015-06-03 Thread Thomas Monjalon
2015-06-03 14:06, Bruce Richardson: > On Tue, Jun 02, 2015 at 04:38:48PM +0200, Thomas Monjalon wrote: > > GCC 5.1 detects more out-of-bounds accesses: > > error: array subscript is above array bounds [-Werror=array-bounds] > > > > Signed-off-by: Thomas Mon

[dpdk-dev] [PATCH] eal: fix linuxapp numa node detection

2015-06-03 Thread Thomas Monjalon
2015-04-22 08:44, Stephen Hemminger: > On Wed, 22 Apr 2015 14:31:55 +0100 > Bruce Richardson wrote: > > > Using the "physical_package_id" as a fallback for determining the > > numa node of a core tends to be unreliable. Fix this by using a > > detection routine which reads the numa information

[dpdk-dev] [PATCH v2] doc: add coding standards documentation

2015-06-03 Thread Thomas Monjalon
2015-06-03 14:58, Bruce Richardson: > Add coding standards document to guides directory. This document > codifies the current DPDK C coding conventions, to make it easier for > contributors to see the format their code should be in. > > Signed-off-by: Siobhan Butler > Signed-off-by: Bruce

[dpdk-dev] [RFC PATCH] eal:Add new API for parsing args at rte_eal_init time

2015-06-03 Thread Thomas Monjalon
Hi Keith, 2015-06-03 13:49, Keith Wiles: > Signed-off-by: Keith Wiles > --- > lib/librte_eal/bsdapp/eal/eal.c | 20 > lib/librte_eal/common/include/rte_eal.h | 32 > 2 files changed, 52 insertions(+) These comments would be useful:

[dpdk-dev] Any chance someone could fix the SPF records for this mailing list?

2015-06-04 Thread Thomas Monjalon
2015-06-03 20:09, Matthew Hall: > 2015-06-03 19:54, Alexander Duyck: > > I have noticed a number of emails from this list are going to spam. It > > looks like it might be gmail filtering based on the fact that most of > > the list has a valid SPF based on an IPv4 address that reports out like > >

[dpdk-dev] [PATCH 0/3] get rid of unnecessary memset's

2015-06-04 Thread Thomas Monjalon
t > null: remove unnecessary memset Acked-by: Thomas Monjalon Applied, thanks

[dpdk-dev] [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it to the UT

2015-06-04 Thread Thomas Monjalon
2015-06-03 18:45, Konstantin Ananyev: > v2: > - reorder code a bit to avoid gcc 5.1 warnings. > > Konstantin Ananyev (3): > ACL: fix a problem in acl_merge_trie > ACL: add new test case for ranges build > ACL: remove subtree_id calculations at build stage Applied, thanks

[dpdk-dev] [PATCH 0/8] ACL: various fixes and cleanups

2015-06-04 Thread Thomas Monjalon
Hi Konstantin, 2015-06-04 00:10, Konstantin Ananyev: > This patch-set is based on: > [PATCHv2 0/3] ACL: Fix bug in acl_merge_trie() and add a new test-case for it > to the UT. > > Konstantin Ananyev (8): > ACL: fix invalid rule wildness calculation for RTE_ACL_FIELD_TYPE_BITMASK > ACL: code

[dpdk-dev] [PATCH v2] doc: add coding standards documentation

2015-06-04 Thread Thomas Monjalon
2015-06-04 10:33, Bruce Richardson: > On Wed, Jun 03, 2015 at 07:35:32PM +0200, Thomas Monjalon wrote: > > 2015-06-03 14:58, Bruce Richardson: > > > Add coding standards document to guides directory. This document > > > codifies the current DPDK C coding con

[dpdk-dev] [PATCH v3] i40evf: fix of supporting jumbo frame

2015-06-04 Thread Thomas Monjalon
2015-06-04 14:54, Helin Zhang: > It wouldn't check the configured maximum packet length, and then > the scattered receiving function wouldn't be selected at all even > if it wants to receive a jumbo frame. The fix is to select the > correct RX function according to the configurations. > >

[dpdk-dev] [PATCH] vhost: enable live migration

2015-06-04 Thread Thomas Monjalon
2015-06-01 04:47, Ouyang, Changchun: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Huawei Xie > > When we migrate VM, without this feature, qemu will report error: > > "migrate: Migration disabled: vhost lacks VHOST_F_LOG_ALL feature". > > Is this enough for vhost to support migrate

[dpdk-dev] [PATCH 1/9] kni: fix whitespace

2015-06-04 Thread Thomas Monjalon
2015-06-04 07:43, Stephen Hemminger: > From: Stephen Hemminger > > Ran this code base through a script which: > - removes trailing whitespace > - removes space before tabs > - removes blank lines at end of file > > Signed-off-by: Stephen Hemminger > --- >

[dpdk-dev] [PATCH 1/3] kni: minor opto

2015-06-04 Thread Thomas Monjalon
2015-06-04 14:40, Bruce Richardson: > On Thu, Jun 04, 2015 at 02:39:17PM +0100, Bruce Richardson wrote: > > On Wed, Jun 03, 2015 at 02:18:55PM -0500, Jay Rolette wrote: > > > Don't need the 'safe' version of list_for_each_entry() if you aren't > > > deleting from the list as you iterate over it >

[dpdk-dev] [PATCH] fm10k: fix PF/VF MAC address register and clean up bug

2015-06-05 Thread Thomas Monjalon
Hi, 2015-06-05 11:24, Shaopeng He: > MAC address with fixed VLAN 0 was removed. VF MAC/VLAN filter was enabled > for the default value. Removed all VLAN and MAC address table entries when > the system(e.g. testpmd) was closed. > > Signed-off-by: Shaopeng He Sorry, it's difficult to understand

[dpdk-dev] Mac ageing functionality.

2015-06-05 Thread Thomas Monjalon
Hi, 2015-06-04 16:03, Yeddula, Avinash: > Does dpdk provide any kind of ageing functionality > ( To be specific, Mac ageing functionality is what I'm looking for). As stated on the homepage, the DPDK focus on packet processing. It provides the plumbing to do some userspace networking and shows

[dpdk-dev] The use of --log-level and its default state

2015-06-05 Thread Thomas Monjalon
2015-05-27 15:10, Wiles, Keith: > I would like to have the log-level default changed to not log everything, > but the user needs to enable the log messages if he needs to see more > information. Normally applications or systems are not so verbose, but if > needed the user enables the verbose or

[dpdk-dev] [PATCH v3] pipeline: add statistics for librte_pipeline

2015-06-05 Thread Thomas Monjalon
2015-05-28 19:26, Dumitrescu, Cristian: > I think we have the following options identified so far for stats collection > configuration: > > 1. Stats configuration through the RTE_LOG_LEVEL > 2. Single configuration flag global for all DPDK libraries > 3. Single configuration flag per DPDK

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-05 Thread Thomas Monjalon
2015-06-04 22:10, Andrew Harvey: > On 6/4/15, 7:58 AM, "Stephen Hemminger" wrote: > >"Andrew Harvey (agh)" wrote: > >> I believe that their is value in this interface for software stacks not > >> based on Linux being moved toward DPDK that need simple operations like > >> getting the mac

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-05 Thread Thomas Monjalon
2015-06-05 11:25, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Stephen and me say the same thing about using the ethdev API. > > We don't understand why using a fake ethtool lib would be easier. > > Though you are saying it "facilitat

[dpdk-dev] The use of --log-level and its default state

2015-06-05 Thread Thomas Monjalon
Keith, your mail is very long but it's maybe on purpose to show that there are too many logs ;) 2015-06-05 12:32, Wiles, Keith: > On 6/5/15, 5:00 AM, "Thomas Monjalon" wrote: > >2015-05-27 15:10, Wiles, Keith: > >> I would like to have the log-level default chang

[dpdk-dev] [PATCH] examples/distributor: fix missing "; " in debug macro

2015-06-05 Thread Thomas Monjalon
2015-06-05 17:01, Bruce Richardson: > The macro to turn on additional debug output when the app was compiled > with "-DDEBUG" was missing a ";". It shows that such dead code is almost never tested. It would be saner if this command would return no result: git grep 'ifdef.*DEBUG' examples

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-05 Thread Thomas Monjalon
2015-06-05 16:07, Andrew Harvey: > On 6/5/15, 3:46 AM, "Thomas Monjalon" wrote: > >Stephen and me say the same thing about using the ethdev API. > > And your would have a point would be valid if dpdk were available to every > interface we support (it is not) and on

[dpdk-dev] [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs

2015-06-06 Thread Thomas Monjalon
2015-06-05 17:24, Andrew Harvey: > On 6/5/15, 5:47 AM, "Bruce Richardson" wrote: > >> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > >> > That's why we need to understand what we (or you) are missing. > >> > Maybe that it would b

[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-06 Thread Thomas Monjalon
2015-06-05 18:35, Maryam Tahhan: > Extend dump_cfg to also display statistcs information for given DPDK > ports and rename the application to proc_info as it's now a utility > doing a little more than just dumping the memory information for DPDK. > > Signed-off-by: Maryam Tahhan > --- >

[dpdk-dev] [PATCH 4/4] app: replace dump_cfg with proc_info

2015-06-08 Thread Thomas Monjalon
2015-06-08 13:45, Tahhan, Maryam: > > > Extend dump_cfg to also display statistcs information for given DPDK > > > ports and rename the application to proc_info as it's now a utility > > > doing a little more than just dumping the memory information for DPDK. > > > > > > Signed-off-by: Maryam

[dpdk-dev] Headers files with BSD license in kernel

2015-06-10 Thread Thomas Monjalon
2015-06-10 01:20, Zhang, Helin: > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote: > > > > > Hi, > > > > > > > > > > I'm working on Clear Linux project, and when I was integrating > > > > > DPDK kernel

[dpdk-dev] Headers files with BSD license in kernel

2015-06-10 Thread Thomas Monjalon
2015-06-10 09:01, Burakov, Anatoly: > > 2015-06-10 01:20, Zhang, Helin: > > > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > > > > > > On Tue, Jun 09, 2015 at 12:40:57PM -0500, Miguel Bernal Marin wrote: > > > > > > > Hi, > > > > > > > > > > > > > > I'm working on Clear Linux

[dpdk-dev] [PATCH] mk: fix combined library building

2015-06-10 Thread Thomas Monjalon
2015-06-10 10:48, Li Wei: > On 06/09/2015 05:37 PM, Sergio Gonzalez Monroy wrote: > > The combined lib was being created after building the lib root dir. > > With the new directory hierarchy, it should be created after the > > drivers root dir instead. > > > > Fixes: 980ed498eb1dd0 ("drivers:

[dpdk-dev] [RFC-PATCH-v3 0/6] pktdev update

2015-06-10 Thread Thomas Monjalon
2015-06-10 14:07, Bruce Richardson: > Following on from the feedback received from the community about the pktdev > idea, > I've decided not to push this approach further for DPDK 2.1. > > Instead, for future releases, I'll look at taking some of what was > investigated in > this work and see

[dpdk-dev] [PATCH v6 01/18] mbuf: redefine packet_type in rte_mbuf

2015-06-10 Thread Thomas Monjalon
2015-06-10 16:32, Olivier MATZ: > On 06/02/2015 03:27 PM, O'Driscoll, Tim wrote: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Olivier MATZ > >> On 06/01/2015 09:33 AM, Helin Zhang wrote: > >>> In order to unify the packet type, the field of 'packet_type' in > >>> 'struct rte_mbuf'

[dpdk-dev] deadline notice

2015-06-10 Thread Thomas Monjalon
Hi, As described in the roadmap (http://dpdk.org/dev/roadmap), starting from this week, every new feature submission will be postponed to release 2.2. The below features, which were submitted earlier, will be accepted in the release 2.1 if they are correctly reviewed and acknowledged before the

[dpdk-dev] deadline notice

2015-06-11 Thread Thomas Monjalon
2015-06-11 09:27, Simon Kagstrom: > Hi! > > On Wed, 10 Jun 2015 20:39:59 +0200 > Thomas Monjalon wrote: > > > As described in the roadmap (http://dpdk.org/dev/roadmap), > > starting from this week, > > every new feature submission will be postponed to release 2

[dpdk-dev] deadline notice

2015-06-11 Thread Thomas Monjalon
2015-06-11 10:30, Tetsuya Mukawa: > On 2015/06/11 3:39, Thomas Monjalon wrote: > > Hi, > > > > As described in the roadmap (http://dpdk.org/dev/roadmap), > > starting from this week, > > every new feature submission will be postponed to release 2.2. > > T

[dpdk-dev] [PATCH v2 1/2] Added ETH_SPEED_CAP bitmap in rte_eth_dev_info

2015-06-11 Thread Thomas Monjalon
2015-06-08 10:50, Marc Sune: > On 29/05/15 20:23, Thomas Monjalon wrote: > > 2015-05-27 11:15, Marc Sune: > >> On 27/05/15 06:02, Thomas Monjalon wrote: > >>>> +#define ETH_SPEED_CAP_10M_HD(1 << 0) /*< 10 Mbps half-duplex> */ > >>>>

[dpdk-dev] deadline notice

2015-06-11 Thread Thomas Monjalon
2015-06-11 09:30, Iremonger, Bernard: > The following patch was submitted on 10th March 2015, but does not seem to be > on DPDK patchwork. > > [dpdk-dev] [RFC] af_packet: support port hotplug Good catch. It was classified as RFC: http://dpdk.org/dev/patchwork/patch/3963/ A v2 should

[dpdk-dev] deadline notice

2015-06-11 Thread Thomas Monjalon
2015-06-11 10:04, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Note: [RFC] should be preferred for incomplete patches or trials. > > Should RFC PATCH be retained for v2 and subsequent patches or should RFC be > dropped? If you tar

[dpdk-dev] [PATCH] doc: guidelines for library statistics

2015-06-11 Thread Thomas Monjalon
Hi Cristian, Thanks for trying to make a policy clearer. We need to make a decision in the coming week. Below are comments on the style and content. 2015-06-08 15:50, Cristian Dumitrescu: > doc/guides/guidelines/statistics.rst | 42 > Maybe we should have a

[dpdk-dev] [PATCH] vmxnet3: fix spelling

2015-06-11 Thread Thomas Monjalon
> >Signed-off-by: Stephen Hemminger > > Acked-by: Yong Wang Applied, thanks

[dpdk-dev] deadline notice

2015-06-11 Thread Thomas Monjalon
2015-06-10 17:13, Abdul, Jaffar: > Is there any document which explains the features that are planned for DPDK > 2.1 > > I am just trying to understand the some features such as KNI optimization, > KNI multicast, etc. > > Could you please point me to some documentation related to these

[dpdk-dev] [PATCH 0/9] whitespace cleanups

2015-06-11 Thread Thomas Monjalon
2015-06-04 07:43, Stephen Hemminger: > Ran the current code base through a script which: > - removes trailing whitespace > - removes space before tabs > - removes blank lines at end of file > > Stephen Hemminger (9): > kni: fix whitespace > eal: fix whitespace > cmdline: fix

[dpdk-dev] [PATCH] pmd: change initialization to indicate pci drivers

2015-06-12 Thread Thomas Monjalon
much easier. > > Signed-off-by: Stpehen Hemminger There is a (fixed) typo in this line. Please use --signoff. Acked-by: Thomas Monjalon Applied, thanks Next step would be to avoid this strange assumption: struct eth_driver { struct rte_pci_driver pci_drv;/**< The PMD is also a PCI driver. */

[dpdk-dev] [PATCH 0/5 v3] virtio: patches

2015-06-12 Thread Thomas Monjalon
2015-06-11 08:53, Stephen Hemminger: > This is update to earlier virtio patches, the only change is to > handle the rename to drivers/net > > Stephen Hemminger (5): > virtio: remove blank lines > virtio: don't enable/disable rx modes unless supported > virtio: don't set mac table unless

[dpdk-dev] [PATCH] virtio: fix crash if CQ is not negotiated

2015-06-12 Thread Thomas Monjalon
> > Fix NULL dereference if virtio control queue is not negotiated. > > > > Signed-off-by: Damjan Marion > > This is good belt and suspenders thing to have, but did you see early > patches to check the feature bits and not call this code? > > Acked-by: Stephen Hemminger Applied, thanks

[dpdk-dev] [PATCH 0/5] multicast address filtering

2015-06-12 Thread Thomas Monjalon
2015-05-28 17:05, Ivan Boule: > Introduce PMD API to set the list of multicast MAC addresses filtered > by a port. > Implemented in the following PMDs: igb, igbvf, em, ixgbe, and ixgbevf. > Implementation for physical PMDs i40e, i40evf, enic, and fm10k left > to their respective maintainers. > >

[dpdk-dev] [PATCH v2] mbuf: optimize rte_mbuf_refcnt_update

2015-06-12 Thread Thomas Monjalon
2015-06-09 13:57, Bruce Richardson: > On Mon, Jun 08, 2015 at 04:57:22PM +0200, Olivier Matz wrote: > > In __rte_pktmbuf_prefree_seg(), there was an optimization to avoid using > > a costly atomic operation when updating the mbuf reference counter if > > its value is 1. Indeed, it means that we

<    1   2   3   4   5   6   7   8   9   10   >