On 2024/11/14 8:12, Stephen Hemminger wrote:
> There was useless loop when looking at the DMA address.
> It looks like it was meant to skip whitespace before
> calling strtok.
>
> Good time to replace strtok with strtok_r as well.
Incomplete modification for strtok, I suggest the strtok adopt Hai
On 2024/11/14 2:56, Stephen Hemminger wrote:
> Doing memset before free maybe removed by compiler, and
> is flagged by security scanning tools as potential problem.
> In this case the memset is unnecessary.
>
> Signed-off-by: Stephen Hemminger
> ---
> drivers/bus/uacce/uacce.c | 1 -
> 1 file ch
On 2024/11/16 4:06, Stephen Hemminger wrote:
> There was useless loop when looking at the DMA address.
> It looks like it was meant to skip whitespace before
> calling strtok.
>
> Good time to replace strtok with strtok_r as well.
Please delete this line, with this fixed:
Acked-by: Chengwen Feng
Series-acked-by: Chengwen Feng
Thanks
On 2024/12/7 3:27, Andre Muezerie wrote:
> The first patch eliminates undefined behavior in the dmadev lib:
>
> lib\dmadev\rte_dmadev_trace_fp.h(36):
> warning C5101: use of preprocessor directive in
> function-like macro argument list is undefined
On 2025/1/30 2:06, Bruce Richardson wrote:
> On Wed, Jan 29, 2025 at 09:17:38AM -0800, Stephen Hemminger wrote:
>> On Wed, 29 Jan 2025 10:54:16 +0200
>> Shani Peretz wrote:
>>
>>> DPDK provides two formats for specifying PCI device numbers:
>>> a full version (":08:00.0") and a short version (
Acked-by: Chengwen Feng
On 2025/2/7 22:32, Bruce Richardson wrote:
> The test case "test_multi_alloc_statistics" was brittle in that it did
> some allocations and frees and then checked statistics without
> considering the initial state of the malloc heaps. This meant that,
> depending on what al
On 2025/2/6 19:40, Bruce Richardson wrote:
> On Fri, Jan 24, 2025 at 03:18:11PM +0800, fengchengwen wrote:
>> The new impl don't support re-test, how about add a wrap:
>> 1. rename test_multi_alloc_statistics with do_test_multi_alloc_statistics,
>> and make it tak
On 2024/12/10 7:21, Jerin Jacob wrote:
>
>
>> -Original Message-
>> From: Bruce Richardson
>> Sent: Monday, December 9, 2024 4:58 AM
>> To: Andre Muezerie ; Jerin Jacob
>>
>> Cc: Chengwen Feng ; Kevin Laatz
>> ; dev@dpdk.org
>> Subject: [EXTERNAL] Re: [PATCH 1/2] lib/dmadev: eliminate u
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support optional C11 VLAs. When building for Windows
> enable -Wvla so that mingw and clang also fail if a VLA is used.
>
> Signed-off-by: Tyler Retzlaff
> Acked-by: Bruce Richardson
>
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The loop over policy actions will always exit when it sees
> the flow end action, so the next check is redundant.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: f29fa2c59b85 ("app/testpmd: support policy
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The order of comparison is wrong, and potentially allows
> referencing past the array.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 3e3edab530a1 ("ethdev: add flow quota")
> Cc: getel...@nvidia.com
> C
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> Do not use same variable for outer and inner loop in bonding test.
> Since the loop is just freeing the resulting burst use bulk free.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond:
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Tyler Retzlaff
>
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Tyler Ret
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/ethdev/rte_ethdev.c:3244:16
> : warning: ISO C90 forbids variable length array ‘xstats_names’
> 2) ./lib/ethdev/rte_ethdev.c:3345:17
> : warning: ISO C90 forbids variable length array ‘ids_copy’
> 3) ./lib/e
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_cuckoo_hash.c:2362:9
> : warning: ISO C90 forbids variable length array ‘positions’
> 2) ../lib/hash/rte_cuckoo_hash.c:2478:9
> : warning: ISO C90 forbids variable length a
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The parenthesis were in the wrong place so that comparison
> took precedence over assignment in handling IPv6 extension
> headers. Break up the loop condition to avoid the problem.
>
> Link: https://pvs-studio.com/en/blog/po
Acked-by: Chengwen Feng
On 2024/11/22 2:23, Stephen Hemminger wrote:
> The first argument of 'memcmp' function was equal to the second argument.
> Therefore ASSERT would always be true.
>
> Link: https://pvs-studio.com/en/blog/posts/cpp/1179/
>
> Fixes: 92073ef961ee ("bond: unit tests")
> Cc: d
On 2024/11/22 5:41, Andre Muezerie wrote:
> From: Konstantin Ananyev
>
> 1) ./lib/hash/rte_thash.c:774:9
> : warning: ISO C90 forbids variable length array ‘tmp_tuple’
>
> The tuple can exceed sizeof(union rte_thash_tuple), for example if any
> tunneling header is used in the RSS hash calcul
Acked-by: Chengwen Feng
On 2024/11/22 5:41, Andre Muezerie wrote:
> MSVC does not support VLAs, replace VLAs with standard C arrays
> or alloca(). alloca() is available for all toolchain/platform
> combinations officially supported by DPDK.
>
> Signed-off-by: Andre Muezerie
> ---
> app/test-pm
On 2024/11/22 18:08, Konstantin Ananyev wrote:
>
>
>> -Original Message-----
>> From: Fengchengwen
>> Sent: Friday, November 22, 2024 1:33 AM
>> To: Andre Muezerie ; dev@dpdk.org
>> Cc: Konstantin Ananyev
>> Subject: Re: [PATCH v12 04/21] et
The new impl don't support re-test, how about add a wrap:
1. rename test_multi_alloc_statistics with do_test_multi_alloc_statistics, and
make it take socket as parameter
2. create a new function test_multi_alloc_statistics {
// prepare a new malloc heap
ret = do_test_multi_alloc_statistics
Series-acked-by: Chengwen Feng
On 2025/1/17 17:12, Huisong Li wrote:
> I've had some issues when I add the verification of the port id in the
> event callback, which are discussed in another patch series[1]. So this
> series clarify something about RTE_ETH_EVENT_NEW based on the previous
> discu
LGTM
Acked-by: Chengwen Feng
On 2025/1/21 21:40, Morten Brørup wrote:
> When putting an mbuf back into its mempool, there are certain requirements
> to the mbuf. Specifically, some of its fields must be initialized.
>
> These requirements are in fact invariants about free mbufs, held in
> mempoo
Acked-by: Chengwen Feng
On 2025/1/20 20:21, Ariel Otilibili wrote:
> When returning from rte_mempool_set_ops_byname(), rte_errno is not set
> for error exits.
>
> The API requires rte_errno to be set in that case.
>
> Bugzilla ID: 1559
> Fixes: c2c6b2f41305 ("mempool: fix default ops for an emp
Acked-by: Chengwen Feng
On 2024/12/4 10:06, Jie Hai wrote:
> The application send packets only when the buffer is full, or the
> buffer is empty and the packets to be sent extends TX_PKT_BURST.
> The change of MAX_PKT_BURST make TX buffer size and TX_PKT_BURST
> increase, while the default cache
Signed-off-by: Chengwen Feng
On 2025/2/12 6:02, Andre Muezerie wrote:
> Compiling with MSVC results in the warning below:
>
> app/test-pmd/cmdline_flow.c(13964): warning C4098: 'cmd_set_raw_parsed':
> 'void' function returning a value
>
> Signed-off-by: Andre Muezerie
Signed-off-by: Chengwen Feng
On 2025/2/12 6:02, Andre Muezerie wrote:
> Compiling with MSVC results in the error below:
>
> app/test/test_ring_perf.c(197): error C7712: address argument to atomic
> operation must be a pointer to an atomic integer,
> 'volatile unsigned int *' is not valid
Signed-off-by: Chengwen Feng
On 2025/2/12 1:35, Stephen Hemminger wrote:
> Since tmp is not used later in the function, this memset
> is unnecessary. Even though this is harmless,
> it causes tools that look for security issues
> around memset to flag this a bug.
>
> Signed-off-by: Stephen Hemmi
Signed-off-by: Chengwen Feng
On 2025/2/12 1:35, Stephen Hemminger wrote:
> When memset() is used before a release function such as free,
> the compiler if allowed to optimize the memset away under
> the as-if rules. This is normally ok, but in certain cases such
> as passwords or security keys it
Series-acked-by: Chengwen Feng
On 2025/2/11 5:31, David Marchand wrote:
> As I had reported in 24.11-rc2, the lcore variables allocation have a
> noticeable impact on applications consuming DPDK, even when such
> applications does not use DPDK, or use features associated to
> some lcore variables
Signed-off-by: Chengwen Feng
On 2025/2/12 6:01, Andre Muezerie wrote:
> There's no MSVC equivalent for compiler extension __builtin_constant_p.
> EAL already had __rte_constant which was used as a first attempt to
> workaround __builtin_constant_p when using MSVC. However, there are
> pieces of c
Signed-off-by: Chengwen Feng
On 2025/2/12 6:01, Andre Muezerie wrote:
> Compiling with MSVC results in the warning below:
>
> app/test/test_alarm.c(54): warning C4090: 'function':
> different '_Atomic' qualifiers
>
> The fix is to use a macro to explicitly drop the qualifier.
>
> Signed-of
Signed-off-by: Chengwen Feng
On 2025/2/12 6:01, Andre Muezerie wrote:
> Compiling with MSVC results in warnings like the one below:
>
> app/test-pmd/csumonly.c(1085): warning C4477: 'printf' : format string
> '%d' requires an argument of type 'int',
> but variadic argument 1 has type 'ui
Signed-off-by: Chengwen Feng
On 2025/2/12 6:02, Andre Muezerie wrote:
> Compiling with MSVC results in warnings like the one below:
>
> app/test-pmd/util.c(201): warning C4334: '<<': result of 32-bit shift
> implicitly converted to 64 bits (was 64-bit shift intended?)
>
> Signed-off-by: And
Signed-off-by: Chengwen Feng
On 2025/2/12 6:02, Andre Muezerie wrote:
> Compiling with MSVC results in warnings like below:
>
> app/test-pmd/cmdline.c(9023): warning C5101: use of preprocessor
> directive in function-like macro argument list is undefined behavior
>
> Signed-off-by: Andre Mu
Signed-off-by: Chengwen Feng
On 2025/2/12 6:02, Andre Muezerie wrote:
> Compiling with MSVC results in errors like the one below:
>
> app/test-pmd/cmdline_flow.c(8819): error C2099: initializer
> is not a constant
>
> Signed-off-by: Andre Muezerie
On 2025/2/12 1:35, Stephen Hemminger wrote:
> Although internally rte_free does poison the buffer in most
> cases, it is useful to have function that explicitly does
> this to avoid any security issues.
>
> Signed-off-by: Stephen Hemminger
> ---
> lib/eal/common/rte_malloc.c | 30 ++
Acked-by: Chengwen Feng
On 2025/4/3 18:01, lihuisong (C) wrote:
>
> 在 2025/4/2 16:47, Jie Hai 写道:
>> I am moving on to other things and dengdui is going to
>> take over the role of hns3 maintainer. Update the
>> MAINTAINERS accordingly.
>>
>> Signed-off-by: Jie Hai
> Thanks for your contributio
On 2025/4/28 23:49, Stephen Hemminger wrote:
> On Mon, 28 Apr 2025 16:20:22 +0800
> fengchengwen wrote:
>
>> Hi all,
>>
>> Currently, we supported several DPI application scenarios performance tuning,
>> in these scenarios, the DPDK library ethdev, ring
Hi Pavan,
On 2025/4/16 18:09, pbhagavat...@marvell.com wrote:
> From: Pavan Nikhilesh
>
> Add enqueue/dequeue operations that use struct rte_dma_op
> to communicate with the dma device.
> These operations need to be enabled at dma device configuration
> time by setting the flag rte_dma_conf::ena
Hi all,
Currently, we supported several DPI application scenarios performance tuning,
in these scenarios, the DPDK library ethdev, ring, mbuf and hash APIs are used.
One of the scenarios is:
-
|
Acked-by: Chengwen Feng
On 2025/2/18 23:37, David Marchand wrote:
> Rather than use weak symbols, expose stubs symbols when needed.
>
> Signed-off-by: David Marchand
Acked-by: Chengwen Feng
On 2025/2/18 23:37, David Marchand wrote:
> Rather than use weak symbols, expose stubs symbols when needed.
>
> Signed-off-by: David Marchand
Acked-by: Chengwen Feng
On 2025/2/18 23:37, David Marchand wrote:
> Mark __rte_weak as deprecated.
> It will avoid having to support such feature with other linkers,
> plus this was never really needed.
>
> Signed-off-by: David Marchand
On 2025/2/18 19:58, Thierry Herbelot wrote:
> 'width' and 'offset' are input parameters when dumping the register
> info of an Ethernet device. They should be copied in the new request
> before calling the device callback function.
>
> Fixes: 083db2ed9e9 ('ethdev: add report of register names and
On 2025/2/20 2:45, Stephen Hemminger wrote:
> On Tue, 18 Feb 2025 12:58:28 +0100
> Thierry Herbelot wrote:
>
>> 'width' and 'offset' are input parameters when dumping the register
>> info of an Ethernet device. They should be copied in the new request
>> before calling the device callback functio
Acked-by: Chengwen Feng
Thanks
On 2025/3/4 9:55, Andre Muezerie wrote:
> With the outstanding issues preventing dmadev from being compiled
> with MSVC being fixed, the lib can be enabled to be compiled with MSVC.
>
> Signed-off-by: Andre Muezerie
> ---
> lib/dmadev/meson.build | 6 --
> 1
Hi,
This commit modify the test-dma-perf and rte_mempool.h, but I can't get useful
info
from the commit log.
So I recommend you split it to multiple commits, each commit implements a small
function,
and well doc in commit log, this will help reviewer better understand.
Thanks
On 2025/3/9 16:4
Acked-by: Chengwen Feng
On 2025/3/10 18:08, Kevin Traynor wrote:
> LTS length was updated to 3 years, but a sentence saying
> when the final release would be was not updated.
>
> Fixes: 3c60ea7b289a ("doc: update LTS maintenance to 3 years")
> Cc: sta...@dpdk.org
>
> Signed-off-by: Kevin Trayno
Reviewed-by: Chengwen Feng
On 2025/2/27 21:27, Bruce Richardson wrote:
> When running without IOMMU for address translation, i.e. IOVAs are
> physical rather than virtual addresses, we need to translate the
> pointers to IOVAs for the completion API tests.
>
> Fixes: 9942ebb9c698 ("test/dma: add
Acked-by: Chengwen Feng
On 2025/2/20 10:32, Stephen Hemminger wrote:
> The expression *dev->dev_ops->dev_info_get and
> dev->dev_ops->dev_info_get are equivalent.
>
> Signed-off-by: Stephen Hemminger
Acked-by: Chengwen Feng
On 2025/2/19 22:23, Konstantin Ananyev wrote:
> This change addresses the CID 455328: Uninitialized variables (UNINIT).
> Strictly speaking right now it should never happen, as role_mask is not
> zero. But that might change in future, as more test-cases will be
> introduc
Acked-by: Chengwen Feng
On 2025/2/22 3:52, Andre Muezerie wrote:
> There's no MSVC equivalent for compiler extension __builtin_constant_p,
> so a workaround is needed.
>
> Signed-off-by: Andre Muezerie
Acked-by: Chengwen Feng
On 2025/2/22 3:52, Andre Muezerie wrote:
> Enabled "app" directory to be compiled with MSVC along with all its
> contents.
>
> Removed flag Wno-deprecated-declarations which is not needed anymore.
>
> Signed-off-by: Andre Muezerie
> Acked-by: Bruce Richardson
It looks more clear and user-friendly for splitting the flag.
Acked-by: Chengwen Feng
On 2025/5/27 17:21, Bruce Richardson wrote:
> The use of lists of #defines with _MAX entries at the end causes issues
> for ABI compatibility as those MAX values often leak through to
> applications and can caus
Thanks for this patchset, Bruce.
Series-acked-by: Chengwen Feng
On 2025/6/3 23:32, Bruce Richardson wrote:
> This patchset is based off the work to adjust how we do argument parsing
> inside EAL. To enable argparse to be effectively used for EAL, we have
> new features and some changes in the fir
On 2025/5/27 17:21, Bruce Richardson wrote:
> The argparse library was missing two key features which made it
> unsuitable for use by EAL or any program wanting similar behaviour.
>
> 1. It didn't stop parsing arguments when it hit a "--" character
> 2. It never returned the number of arguments pa
Acked-by: Chengwen Feng
On 2025/5/27 17:21, Bruce Richardson wrote:
> Sometimes we don't want to parse the string at all, when doing arg
> parsing, and just save it off for later. Add support for that.
>
> Also, rather than assuming boolean values have to be the same size as
> uint8 (or some oth
Hi Vidya,
How about add a wrap function and keep this function (could modify it's name).
static int
test_enqueue_fill() {
uint64_t pattern[3] = {0x0, 0xfedcba9876543210, 0x};
int i;
for (i = 0; i < RTE_DIM(pattern); i++) {
ret = test_enqueue
Hi Vidya,
On 2025/6/9 11:03, Vidya Sagar Velumuri wrote:
> Run the sg test in a loop to verify wrap around case.
> Total number commands submitted to be more than the number descriptors
> allocated to verify the scenario.
>
> Signed-off-by: Vidya Sagar Velumuri
> Acked-by: Amit Prakash Shukla
>
On 2025/6/10 14:42, huangdengdui wrote:
>
> On 2025/6/9 23:21, Stephen Hemminger wrote:
>> On Mon, 9 Jun 2025 09:58:27 +
>> Sivaprasad Tummala wrote:
>>
>>> Previously, the TX burst size was fixed at 256, leading to performance
>>> degradation in certain scenarios.
>>>
>>> This patch introduc
601 - 661 of 661 matches
Mail list logo
