[dpdk-dev] disable hugepages

2016-11-09 Thread Christian Ehrhardt
On Wed, Nov 9, 2016 at 1:55 PM, Keren Hochman wrote: > how can I create mempool without hugepages?My application is running on a > pcap file so no huge pages is needed ? > Not sure if that is what you really want (Debug use only), but in general no-huge is available as EAL arg >From

[dpdk-dev] [PATCH] mk: add missing *CPPFLAGS to rte.compile-pre.mk

2016-09-14 Thread Christian Ehrhardt
y the > dpkg-buildpackage environment, like hardening flags, are not > correctly passed to all objects builds. > > Signed-off-by: Luca Boccassi > Acked-by: Christian Ehrhardt -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH] mk: use ?= instead of := for RTE_DEVEL_BUILD

2016-09-14 Thread Christian Ehrhardt
ent variable as well. > > Cc: > Signed-off-by: Luca Boccassi > Acked-by: Christian Ehrhardt -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH v2 4/4] doc: add basic invocation info for dpdk-devbind

2016-08-31 Thread Christian Ehrhardt
root only program in sbin it should belong to section 8 "8 System administration commands (usually only for root)" Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 4 +- doc/guides/tools/devbind.rst | 143 +++ doc/guides/too

[dpdk-dev] [PATCH v2 3/4] doc: add basic invocation info for dpdk-pmdinfo

2016-08-31 Thread Christian Ehrhardt
This summarizes the "how to call dpdk-pmdinfo" in one place to be picked up by html/pdf/man-page docs. Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 4 +++- doc/guides/tools/index.rst | 1 + doc/guides/tools/pmdinf

[dpdk-dev] [PATCH v2 2/4] doc: rendering and installation of man pages

2016-08-31 Thread Christian Ehrhardt
there is no change to the old behaviour. Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 8 mk/rte.sdkdoc.mk | 2 +- mk/rte.sdkinstall.mk | 6 ++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/guides/conf.py b/doc/guides/conf.py index cd6a4f7..55b6b2f 1

[dpdk-dev] [PATCH v2 1/4] doc: move tool guides in their own subdirectory

2016-08-31 Thread Christian Ehrhardt
This is to clarify the scope of these documents that are more tools than sample applications. Also this is a preparation step to add more tools and generate man pages off of their rst files. Signed-off-by: Christian Ehrhardt --- doc/guides/index.rst | 1 + doc/guides

[dpdk-dev] [PATCH v2 0/4] provide man pages for binaries provided by DPDK

2016-08-31 Thread Christian Ehrhardt
tch #4 please let me know. Christian Ehrhardt (4): doc: move tool guides in their own subdirectory doc: rendering and installation of man pages doc: add basic invocation info for dpdk-pmdinfo doc: add basic invocation info for dpdk-devbind doc/guides/conf.py |

[dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk-devbind

2016-08-31 Thread Christian Ehrhardt
g] On Behalf Of Christian Ehrhardt > > Sent: Thursday, August 4, 2016 12:17 PM > > To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com; > > dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk

[dpdk-dev] [PATCH 2/4] doc: add basic invocation info for dpdk-pmdinfo

2016-08-31 Thread Christian Ehrhardt
On Tue, Aug 30, 2016 at 4:59 PM, Mcnamara, John wrote: > > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt > > Sent: Thursday, August 4, 2016 12:17 PM > > To: christian.ehrhardt at canonical.com; thomas.mon

[dpdk-dev] [PATCH 0/4] provide man pages for binaries provided by DPDK

2016-08-31 Thread Christian Ehrhardt
t dpdk.org] On Behalf Of Christian Ehrhardt >>> Sent: Thursday, August 4, 2016 12:17 PM >>> To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com; >>> dev at dpdk.org >>> Subject: [dpdk-dev] [PATCH 0/4] provide man pages for binaries provided >>

[dpdk-dev] [PATCH 4/4] doc: make the devbind man page be part of section 8

2016-08-31 Thread Christian Ehrhardt
inal Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Christian Ehrhardt > > Sent: Thursday, August 4, 2016 12:17 PM > > To: christian.ehrhardt at canonical.com; thomas.monjalon at 6wind.com; > > dev at dpdk.org > > Subject: [dpdk-dev] [PATCH 4

[dpdk-dev] [PATCH 0/3] fix virtio_user issues

2016-08-29 Thread Christian Ehrhardt
On Fri, Aug 5, 2016 at 1:36 PM, Jianfeng Tan wrote: > Patch 1: fix issue when using virtio_user with OVS-DPDK. > Patch 2: fix issue when using virtio_user with VPP. > Patch 3: fix issue when failing to start virtio_user devices. > > Signed-off-by: Jianfeng Tan > > Jianfeng Tan (3): >

[dpdk-dev] [PATCH 0/3] Hash library fixes

2016-08-29 Thread Christian Ehrhardt
#1 and #2 for stable as well once discussed and applied to master - opinions?. -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH 4/4] doc: make the devbind man page be part of section 8

2016-08-04 Thread Christian Ehrhardt
As a root only program in sbin it should belong to section 8 "8 System administration commands (usually only for root)" Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 2 +- mk/rte.sdkinstall.mk | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/

[dpdk-dev] [PATCH 3/4] doc: add basic invocation info for dpdk-devbind

2016-08-04 Thread Christian Ehrhardt
Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 4 +- doc/guides/sample_app_ug/devbind.rst | 150 +++ doc/guides/sample_app_ug/index.rst | 1 + 3 files changed, 154 insertions(+), 1 deletion(-) create mode 100644 doc/guides/sam

[dpdk-dev] [PATCH 2/4] doc: add basic invocation info for dpdk-pmdinfo

2016-08-04 Thread Christian Ehrhardt
This summarizes the "how to call dpdk-pmdinfo" in one place to be picked up by html/pdf/man-page docs. Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 4 ++- doc/guides/sample_app_ug/index.rst | 1 + doc/guides/sample_app_ug/pmdinf

[dpdk-dev] [PATCH 1/4] doc: rendering and installation of man pages

2016-08-04 Thread Christian Ehrhardt
no change to the old behaviour. Signed-off-by: Christian Ehrhardt --- doc/guides/conf.py | 8 mk/rte.sdkdoc.mk | 2 +- mk/rte.sdkinstall.mk | 6 ++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/doc/guides/conf.py b/doc/guides/conf.py index 2c5610f..4435974 1

[dpdk-dev] [PATCH 0/4] provide man pages for binaries provided by DPDK

2016-08-04 Thread Christian Ehrhardt
ptic lines with many special chars. Yet if someone has something reasonable to unify the copy in patch #4 please let me know. Christian Ehrhardt (4): doc: rendering and installation of man pages doc: add basic invocation info for dpdk-pmdinfo doc: add basic invocation info for dpdk-devbind d

[dpdk-dev] [PATCH v2] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
*Updates in v2* - drop the #!/bin/echo now that it is no more executable Quoting the first line of the script: "#! /bin/echo must be loaded with ." Given that we should drop the .sh file ending as well as the executable flag - both are not needed to source the file. Signed-off-by:

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
drop the #!/bin/echo. That is to avoid the https://lintian.debian.org/tags/unusual-interpreter.html warning that still is emitted. Will submit a v2 soon. -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH] doc: fix old dpdk-nic-bind.py references

2016-08-03 Thread Christian Ehrhardt
("unify tools naming") > > Signed-off-by: Pablo de Lara > I like the cleanups for consistency! Acked-by: Christian Ehrhardt -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
be executed, I think > dropping the > extension will reduce confusion. > > Acked-by: Bruce Richardson > Thank you Bruce @Thomas - given we are 2:1 now, the patch would stay as-is. Do you want me to resubmit as-is but without RFC tag or would you accept it as already submitted? --

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-03 Thread Christian Ehrhardt
for commands in the path, but that doesn't count here. Could we have anybodies opinion as a tie breaker so I can submit a v2 without RFC then? P.S. I understand there was no objection on changing the file mode - which might be quite unobvious in the diff? -- Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [RFC] scripts: make load-devel-config not to appear as executable

2016-08-02 Thread Christian Ehrhardt
Quoting the first line of the script: "#! /bin/echo must be loaded with ." Given that we should drop the .sh file ending as well as the executable flag - both are not needed to source the file. Signed-off-by: Christian Ehrhardt --- MAINTAINERS | 2 +- scripts/check

[dpdk-dev] [PATCH v2] examples: fix unusual-interpreter

2016-08-02 Thread Christian Ehrhardt
("examples/ip_pipeline: add config diagram generator") Fixes: fa667b46 ("examples/ip_pipeline: add core mappings script") Signed-off-by: Christian Ehrhardt --- examples/ip_pipeline/config/diagram-generator.py| 2 +- examples/ip_pipeline/config/pipeline-to-core-mapping.py | 2

[dpdk-dev] [PATCH] examples: fix unusual-interpreter

2016-08-01 Thread Christian Ehrhardt
owners to change their headers. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Aug 1, 2016 at 2:50 PM, Thomas Monjalon wrote: > 2016-08-01 14:28, Christian Ehrhardt: > > Due to regular lintian checks in Debian packaging it surfaced that these > > two scri

[dpdk-dev] [PATCH] examples: fix unusual-interpreter

2016-08-01 Thread Christian Ehrhardt
eline: add core mappings script") Signed-off-by: Christian Ehrhardt --- examples/ip_pipeline/config/diagram-generator.py| 2 +- examples/ip_pipeline/config/pipeline-to-core-mapping.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/ip_pipeline/config/dia

[dpdk-dev] [PATCH] ethtool: remove triple license information

2016-08-01 Thread Christian Ehrhardt
License information is already in LICENSE.GPL. Remove two extra copies and change referred filename in the files. Signed-off-by: Christian Ehrhardt --- lib/librte_eal/linuxapp/kni/ethtool/igb/COPYING| 339 - .../linuxapp/kni/ethtool/igb/e1000_82575.c | 2

[dpdk-dev] doc: announce renaming of ethdev library

2016-07-28 Thread Christian Ehrhardt
istian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016 at 6:33 PM, Jan Viktorin wrote: > On Tue, 26 Jul 2016 18:22:21 +0200 > Thomas Monjalon wrote: > > > The right name of ethdev should be dpdk_netdev. However: > >

[dpdk-dev] doc: announce ivshmem support removal

2016-07-28 Thread Christian Ehrhardt
e-implementation more properly separated from EAL likely is the best way to go. I think it is a good change to drop rather complex code in favor of stabilizing the main paths: Acked-by: Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016

[dpdk-dev] doc: deprecate vhost-cuse

2016-07-28 Thread Christian Ehrhardt
ts to make the rest more stable: Acked-by: Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 27, 2016 at 8:59 PM, Jan Viktorin wrote: > On Fri, 15 Jul 2016 20:28:33 +0800 > Yuanhan Liu wrote: > > > Vhost-cuse was invented before v

[dpdk-dev] [PATCH] doc: announce removal of Xen Dom0 support

2016-07-28 Thread Christian Ehrhardt
no request to provide it. The person that asked for the XEN_PMD was Thiago (set to CC as he might have an opinion on that). For me I think it is a good change to drop rather unmaintained parts to make the rest more stable: Acked-by: Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server

[dpdk-dev] [PATCH v3] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
in where they belong. Thanks for updating Sergio Acked-by: Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Jul 19, 2016 at 3:40 PM, Sergio Gonzalez Monroy < sergio.gonzalez.monroy at intel.com> wrote: > The sed syntax of '0,/regexp/' is GNU

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-19 Thread Christian Ehrhardt
then. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Jul 12, 2016 at 2:08 PM, Yuanhan Liu wrote: > On Wed, Jul 06, 2016 at 09:08:12PM +0800, Yuanhan Liu wrote: > > On Wed, Jul 06, 2016 at 02:24:57PM +0200, Christian Ehrhardt wrote: > > > Hi, > > > while c

[dpdk-dev] [PATCH v2] mk: fix FreeBSD build

2016-07-19 Thread Christian Ehrhardt
using GNU-sed only syntax - http://dpdk.org/dev/patchwork/patch/14592/ ? If this would be ok - AND - if it creates the same .config as the current code I'd think that is the way to go. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Jul 19, 2016 at 12:32 PM, Ferruh Yi

[dpdk-dev] [PATCH] mk: fix FreeBSD build

2016-07-18 Thread Christian Ehrhardt
a call up to the participants of the old discussion if not working on BSD outweighs their old feedback (I guess so). Most active in the discussion back then was Ferruh IIRC - setting to CC. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Jul 18, 2016 at 3:39 PM, Sergio Gonza

[dpdk-dev] Compiling DPDK is not working on Red Hat 6.7

2016-07-12 Thread Christian Ehrhardt
Hi, checking "man clock_gettime" I see: "Link with -lrt (only for glibc versions before 2.17)." RH 6.7 is at glibc 2.12, I haven't check the build, but you might easily run the make with V=1 and see the call. Check if it contains -lrt for the linking step. Christian Ehrhar

[dpdk-dev] [PATCH v2] librte_pmd_bond: fix exported symbol versioning

2016-07-11 Thread Christian Ehrhardt
("net/bonding: allow external state machine in mode 4") Signed-off-by: Christian Ehrhardt --- drivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++-- drivers/net/bonding/rte_eth_bond_8023ad.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/n

[dpdk-dev] [PATCH] doc: announce driver name changes

2016-07-11 Thread Christian Ehrhardt
Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Sat, Jul 9, 2016 at 6:56 PM, Pablo de Lara < pablo.de.lara.guarch at intel.com> wrote: > Driver names for all the supported devices in DPDK do not have > a naming convention. Some are using a prefix, some a

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-06 Thread Christian Ehrhardt
- what the best new way of fixing this would be As this makes long term usage of dpdk aborting by a leak I hope we have a chance to get this into 16.07 still. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 6, 2016 at 2:30 PM, Christian

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-06 Thread Christian Ehrhardt
This is the series this really belongs to http://dpdk.org/dev/patchwork/patch/11581/ Message ID <1458292380-9258-1-git-send-email-patrik.r.andersson at ericsson.com > Should I wait for a v2 to point the patch at the right ID or do you prefer a fixed resubmit right away? Christian Eh

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-06 Thread Christian Ehrhardt
Sorry, please ignore the two links, the cover letter has - they belong to a different issue I have to bring up again. Everything else still applies. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 6, 2016 at 2:24 PM, Christian Ehrhardt < christian.ehrha

[dpdk-dev] [PATCH v2] vhost_user: avoid crash when exeeding file descriptors

2016-07-06 Thread Christian Ehrhardt
ussion topic exist in the ovs-discuss mailing list that can provide a little more background: http://openvswitch.org/pipermail/discuss/2016-February/020243.html Fixes: 8f972312 ("vhost: support vhost-user") Signed-off-by: Patrik Andersson Signed-off-by: Christian Ehrhardt --- lib/libr

[dpdk-dev] [PATCH v2] Memory leak when adding/removing vhost_user ports

2016-07-06 Thread Christian Ehrhardt
it would make as much sense as it made back then to fix this. Christian Ehrhardt (1): vhost_user: avoid crash when exeeding file descriptors lib/librte_vhost/vhost_user/fd_man.c | 11 ++- lib/librte_vhost/vhost_user/vhost-net-user.c | 19 +-- 2 files changed, 23

[dpdk-dev] [PATCH] librte_pmd_bond: fix exported symbol versioning

2016-07-06 Thread Christian Ehrhardt
;) Signed-off-by: Christian Ehrhardt --- drivers/net/bonding/rte_eth_bond_8023ad.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c index 48a50e4..2f7ae70 100644 --- a/drivers/n

[dpdk-dev] [PATCH v4] mk: filter duplicate configuration entries

2016-07-06 Thread Christian Ehrhardt
is important. That can confuse people changing values in .config which are then ignored. A suggested solution was to filter for duplicates at the end of the actual config step which is implemented here. Signed-off-by: Christian Ehrhardt --- mk/rte.sdkconfig.mk | 9 + 1 file changed, 9 insertions

[dpdk-dev] [PATCH v3] mk: filter duplicate configuration entries

2016-07-06 Thread Christian Ehrhardt
minute ... Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Wed, Jul 6, 2016 at 10:57 AM, Ferruh Yigit wrote: > On 7/6/2016 9:12 AM, Bruce Richardson wrote: > > On Wed, Jul 06, 2016 at 07:37:45AM +0200, Christian Ehrhardt wrote: > >> *updates in v3*

[dpdk-dev] [PATCH v3] mk: filter duplicate configuration entries

2016-07-06 Thread Christian Ehrhardt
config step which is implemented here. Signed-off-by: Christian Ehrhardt --- mk/rte.sdkconfig.mk | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mk/rte.sdkconfig.mk b/mk/rte.sdkconfig.mk index a3acfe6..d031bf4 100644 --- a/mk/rte.sdkconfig.mk +++ b/mk/rte.sdkconfig.mk @@ -79,11 +79,17

[dpdk-dev] [PATCH v2] mk: filter duplicate configuration entries

2016-06-30 Thread Christian Ehrhardt
the actual config is sourced only the last entry is important. That can confuse people changing values in .config which are then ignored. A suggested solution was to filter for duplicates at the end of the actual config step which is implemented here. Signed-off-by: Christian Ehrhardt --- mk

[dpdk-dev] [RFC] mk: filter duplicate configuration entries

2016-06-30 Thread Christian Ehrhardt
for a: "make V=1 T=x86_64-native-linuxapp-gcc config" http://paste.ubuntu.com/18163566/ Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Jun 28, 2016 at 6:48 PM, Ferruh Yigit wrote: > On 6/28/2016 5:38 PM, Christian Ehrhardt wrote: > > On Tue, Jun

[dpdk-dev] [RFC] mk: filter duplicate configuration entries

2016-06-28 Thread Christian Ehrhardt
On Tue, Jun 28, 2016 at 6:11 PM, Ferruh Yigit wrote: > On 6/13/2016 4:10 PM, Christian Ehrhardt wrote: > > Due to the hierarchy and the demand to keep the base config shoing all > > options some options end up multiple times in the .config file. > > > > A sugge

[dpdk-dev] [RFC] mk: filter duplicate configuration entries

2016-06-13 Thread Christian Ehrhardt
Due to the hierarchy and the demand to keep the base config shoing all options some options end up multiple times in the .config file. A suggested solution was to filter for duplicates at the end of the actual config step which is implemented here. Signed-off-by: Christian Ehrhardt --- mk

[dpdk-dev] Duplicate config symbols

2016-06-13 Thread Christian Ehrhardt
On Mon, Jun 13, 2016 at 3:47 PM, Thomas Monjalon wrote: > 2016-06-13 13:50, Christian Ehrhardt: > > I wondered multiple times now when changing a config symbol that some of > > them are in the .config file multiple times. > > I totally feel like I'm overlooking somethin

[dpdk-dev] [PATCH v2] xenvirt: fix compilation after mempool changes

2016-06-13 Thread Christian Ehrhardt
Yeah, working now - thanks for the fast update! Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Jun 13, 2016 at 1:24 PM, Olivier Matz wrote: > The field elt_va_start has been removed from the mempool structure, > and it was not re

[dpdk-dev] Duplicate config symbols

2016-06-13 Thread Christian Ehrhardt
WER 2 CONFIG_RTE_LIBRTE_VHOST 2 CONFIG_RTE_MACHINE 2 CONFIG_RTE_TOOLCHAIN Is there any reason to do so or is this an issue in make config? Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH v2 2/2] mk: fix missing DEPDIRS to avoid libarary underlinking

2016-06-13 Thread Christian Ehrhardt
This patch adds missing DEPDIRS to avoid any library referring to symbols they are not linked against. Signed-off-by: Christian Ehrhardt --- drivers/crypto/null/Makefile | 2 ++ drivers/net/af_packet/Makefile | 1 + drivers/net/bonding/Makefile | 2 ++ drivers/net/fm10k/Makefile | 1

[dpdk-dev] [PATCH v2 1/2] mk: fix missing vhost dependency to pthread to avoid libarary underlinking

2016-06-13 Thread Christian Ehrhardt
Add the missing external dependency to pthread to avoid referring to symbols the library is not linked against. Signed-off-by: Christian Ehrhardt --- drivers/net/vhost/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/vhost/Makefile b/drivers/net/vhost/Makefile index

[dpdk-dev] [PATCH v2 0/2] mk: fix more library underlinking

2016-06-13 Thread Christian Ehrhardt
After several cleanups libraries are now linked against the libs they refer as DEPDIR which is great. But that now also made it visible that some references where still missing. The following two patches try to fix that: [PATCH v2 1/2] mk: fix missing vhost dependency to pthread to avoid [PATCH

[dpdk-dev] [PATCH] mk: fix missing DEPDIRS to avoid libarary underlinking

2016-06-13 Thread Christian Ehrhardt
On Mon, Jun 13, 2016 at 12:08 PM, Thomas Monjalon wrote: > 2016-06-13 11:48, Christian Ehrhardt: > > --- a/drivers/net/af_packet/Makefile > > +++ b/drivers/net/af_packet/Makefile > > @@ -54,5 +54,6 @@ SRCS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += > rte_eth_

[dpdk-dev] [PATCH] mk: fix missing DEPDIRS to avoid libarary underlinking

2016-06-13 Thread Christian Ehrhardt
-shlibs). Signed-off-by: Christian Ehrhardt --- drivers/crypto/null/Makefile | 2 ++ drivers/net/af_packet/Makefile | 1 + drivers/net/bonding/Makefile | 2 ++ drivers/net/fm10k/Makefile | 1 + drivers/net/null/Makefile | 1 + drivers/net/pcap/Makefile | 1 + drivers/net/vhost

[dpdk-dev] [PATCH v3 6/6] mk: prevent overlinking in applications

2016-06-13 Thread Christian Ehrhardt
g-shlibdeps: warning: binaries to analyze should already be installed in their package's directory Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Jun 13, 2016 at 11:05 AM, Ferruh Yigit wrote: > On 6/11/2016 7:34 AM, Thomas Monjalon wrote: > > Hi Ferruh, >

[dpdk-dev] [PATCH] xenvirt: fix compilation after mempool changes

2016-06-13 Thread Christian Ehrhardt
idx) ^ cc1: all warnings being treated as errors Not too hard, changing the mp to mpool on the two places the patch has inserted it gets it working. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Jun 13, 2016 at 10:51 AM, Christian Ehrhardt < christian.eh

[dpdk-dev] [PATCH] xenvirt: fix compilation after mempool changes

2016-06-13 Thread Christian Ehrhardt
this. Acked-by: Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Jun 13, 2016 at 10:22 AM, Olivier Matz wrote: > The field elt_va_start has been removed from the mempool structure, > and it was not replaced in xenvirt. > > Fix this by getting

[dpdk-dev] Question regarding mempool changes impact to XEN PMD

2016-06-13 Thread Christian Ehrhardt
On Mon, Jun 13, 2016 at 10:14 AM, Olivier Matz wrote: > Hi Christian, > > On 06/13/2016 09:34 AM, Christian Ehrhardt wrote: > > Hi David, > > I guess this mail is for me, not for David :) > Absolutely yes, sorry to both of you to - probably read too much pa

[dpdk-dev] Question regarding mempool changes impact to XEN PMD

2016-06-13 Thread Christian Ehrhardt
thor would see if it is a trivial change that has to be made? Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH] log: deprecate history dump

2016-06-09 Thread Christian Ehrhardt
Hi, in I totally like it - thanks Thomas for picking that up. I just wanted to mention that the Makefile still refers to mempool, but David beat me in time and Detail a lot. I'll certainly try to follow and help the bit I can. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [PATCH] mk: generate internal library dependencies from DEPDIRS-y automatically

2016-06-07 Thread Christian Ehrhardt
Hi Panu, thanks for refreshing that - I'm much more happy with ldd output of most libraries now after build with that. And it comes much slimmer than my initial approach that touched all lib makefiles. Acked-by: Christian Ehrhardt FYI - for anyone else also trying this in a backported way

[dpdk-dev] RFC: DPDK Long Term Support

2016-06-07 Thread Christian Ehrhardt
LTS to see if the process we defined works out before jumping on a full 2 year cadence. So while I see that this is kind of "my problem" I would at least try to personally ask and vote for LTS being: 16.7, 17.11, 19.11, 21.11, ... Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] If 1 KVM Guest loads the virtio-pci, on top of dpdkvhostuser OVS socket interface, it slows down everything!

2016-05-25 Thread Christian Ehrhardt
. and also again - two list cross posting, but here as well it is yet unclear which it belongs to so I'll keep it as well Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Sun, May 22, 2016 at 6:35 PM, Martinx - ? wrote: > Guys, > > I'm seeing a strange problem he

[dpdk-dev] Crashing OVS+DPDK at the host, from inside of a KVM Guest

2016-05-25 Thread Christian Ehrhardt
this might come from or already existing related fixes. I mean in general nothing should be able to crash the host right? P.S. yeah two list cross posting, but it is yet unclear which it belongs to so I'll keep it Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Sun, May 15, 2016

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-24 Thread Christian Ehrhardt
Hi Panu, I already agreed to Thomas on IRC but won't have time until next week. Thanks for making a patch that does that already - I'll give it a look and some test on my end next week then. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, May 24, 2016 at 11:56 AM

[dpdk-dev] [PATCH] mk: fix underlinking issues of most librte libraries

2016-05-20 Thread Christian Ehrhardt
The individual libraries have various cross dependencies. This is already refelcted in the DEPDIR dependency, but not yet in proper DT_NEEDED flags in the .so's. This adds the -l flags so that is properly stored in the .so's ELF headers. Signed-off-by: Christian Ehrhardt --- lib/librte_acl

[dpdk-dev] Underlinked libs and overlinked applications - an issue?

2016-05-20 Thread Christian Ehrhardt
for now, have a great Weekend Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, May 20, 2016 at 2:41 PM, Christian Ehrhardt < christian.ehrhardt at canonical.com> wrote: > On Fri, May 20, 2016 at 1:01 PM, Panu Matilainen > wrote: > >> O

[dpdk-dev] Suggestions for the dpdk stable tree

2016-05-20 Thread Christian Ehrhardt
The active maintainer you provide would do the usual auto-backport of fixes once they come up upstream. While us others would provide input from real exposure to users that flows in via bug tracking tools. Looking forward for you coming back to the list once you have found one. Christian Ehrhard

[dpdk-dev] Underlinked libs and overlinked applications - an issue?

2016-05-20 Thread Christian Ehrhardt
On Fri, May 20, 2016 at 1:01 PM, Panu Matilainen wrote: > On 05/19/2016 09:17 PM, Thomas Monjalon wrote: > >> 2016-05-19 17:38, Christian Ehrhardt: >> >>> Hi, >>> I was working on the new 16.04 build system to adapt deb packaging to it. >>> I reme

[dpdk-dev] Compilation failed on dpdk-16.04

2016-05-20 Thread Christian Ehrhardt
atex-extra Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, May 20, 2016 at 2:03 PM, Sheroo Pratap < sheroopratapresearch at gmail.com> wrote: > Hi All, > > I m trying to install dpdk-16.04 on my VM ubuntu. > I tried to make the build but it failed wi

[dpdk-dev] Suggestions for the dpdk stable tree

2016-05-20 Thread Christian Ehrhardt
Hi, I guess over time/releases less people mind the 2.2-stable. But I still see a lot of people referring to 2.2 - so why not giving this thread a ping again. ack / nack / opinions ? Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Thu, Mar 24, 2016 at 8:14 AM, Christian

[dpdk-dev] Underlinked libs and overlinked applications - an issue?

2016-05-19 Thread Christian Ehrhardt
f it should be fixed are there obvious suggestions where/how? And if it is intentional - could one be so nice to elaborate it a bit for me - thanks in advance. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] [RFC] eal: provide option to set vhost_user socket owner/permissions

2016-04-26 Thread Christian Ehrhardt
ion, but I don't feel deeply enough involved yet on the API level to give it any judgement. So I look forward for more opinions on it. P.S. the patch bot hit me hard with 2 pages of space/bracket issues, sorry for that - but it was only meant as RFC after all :-) Christian Ehrhardt Software Engine

[dpdk-dev] Git repository might be down

2016-04-25 Thread Christian Ehrhardt
Hi, we were discussing on #DPDK about the same. So far it seems via git:// it fails, but http works for now - thanks to David Marchland for identifying this fallback. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Apr 25, 2016 at 11:59 AM, Tetsuya Mukawa wrote

[dpdk-dev] [RFC] eal: provide option to set vhost_user socket owner/permissions

2016-04-25 Thread Christian Ehrhardt
? Signed-off-by: Christian Ehrhardt --- doc/guides/testpmd_app_ug/run_app.rst| 19 +++ lib/librte_eal/common/eal_common_options.c | 4 + lib/librte_eal/common/eal_internal_cfg.h | 2 + lib/librte_eal/common/eal_options.h | 4 + lib/librte_eal/common/include/rte_eal.h

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Christian Ehrhardt
Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Thu, Apr 21, 2016 at 1:01 PM, Ilya Maximets wrote: > Hi, Christian. > You're, likely, using tar archive with openvswitch from openvswitch.org. > It doesn't contain many bug fixes from git/branch-2.5 unfortunately. > &

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-21 Thread Christian Ehrhardt
st-add-remove-leak/ovs-vswitchd.log.bz2 Kind Regards, Christian Ehrhardt Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Thu, Apr 21, 2016 at 7:54 AM, Yuanhan Liu wrote: > On Wed, Apr 20, 2016 at 08:18:49AM +0200, Christian Ehrhardt wrote: > > On Wed, Apr 2

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-20 Thread Christian Ehrhardt
On Wed, Apr 20, 2016 at 7:04 AM, Yuanhan Liu wrote: > On Tue, Apr 19, 2016 at 06:33:50PM +0200, Christian Ehrhardt wrote: > [...] > > With that applied one (and only one) of my two guests looses > connectivity after > > removing the ports the first time. > > Yeah,

[dpdk-dev] basic forwarding example not working

2016-04-20 Thread Christian Ehrhardt
monly used (=usually work better). Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Tue, Apr 19, 2016 at 7:30 PM, Subbu CS wrote: > Hi Christian, > > I unbind two interfaces and then bound them to uio_pci_generic driver. > > [root at localhost tools]# ./

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-19 Thread Christian Ehrhardt
host_user/vhost-net-user.h +++ dpdk/lib/librte_vhost/vhost_user/vhost-net-user.h @@ -43,6 +43,7 @@ struct vhost_server { char *path; /**< The path the uds is bind to. */ int listenfd; /**< The listener sockfd. */ + uint32_t fh; }; /* refer to hw/virtio/vhost-user.c */ Christi

[dpdk-dev] basic forwarding example not working

2016-04-19 Thread Christian Ehrhardt
Hi, for virtio-pci devices you should either just unbind them or bind them to one of the generic drivers like uio_pci_generic. At least I never saw igb_uio on virtio-pci devices. There might be more complete answers, but I think that should get you going. Christian Ehrhardt Software Engineer

[dpdk-dev] Memory leak when adding/removing vhost_user ports

2016-04-18 Thread Christian Ehrhardt
h-dpdk 2.5 and DPDK 2.2; Retest with DPDK 16.04 and Openvswitch master is planned. I will go on debugging this and let you know, but I wanted to give a heads up to everyone. In case this is a known issue for some of you please let me know. Kind Regards, Christian Ehrhardt Software Engineer, Ubuntu Server

[dpdk-dev] compile error on ubuntu 14.4.4 kernel 4.2.0-27-generic in qemu

2016-04-18 Thread Christian Ehrhardt
you need. Or just take the build process as your starting point for your own. On the other hand I encourage you to go to 16.04 and just use the packaged version if that would suit your needs. Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Sun, Apr 17, 2016 at 8:41 PM, Masaru

[dpdk-dev] [PATCH] lpm: fix freeing of rules_tbl in rte_lpm_free_v20

2016-04-12 Thread Christian Ehrhardt
ion style of rte_lpm_free_v20 is to not remove it. The newer rte_lpm_free_v1604 is safe because in rte_lpm_create_v1604 rules_tbl is a separate allocation. Fixes: d4c18f0a1d5d ("lpm: fix missing free") Signed-off-by: Christian Ehrhardt --- lib/librte_lpm/rte_lpm.c | 1 - 1 file changed,

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-11 Thread Christian Ehrhardt
ver fdset\n", vserver->listenfd); free(vserver->path); + close(vserver->listenfd); free(vserver); return -1; } Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Mon, Apr 11, 2016 at 8:

[dpdk-dev] [RFC] vhost user: add error handling for fd > 1023

2016-04-07 Thread Christian Ehrhardt
; I totally agree to that there is no deterministic rule what to expect. The only rule is that #fd certainly always is > #vhost_user devices. In various setup variants I've crossed fd 1024 anywhere between 475 and 970 vhost_user ports. Once the discussion continues and we have an updates version o

[dpdk-dev] Updating bnx2x firmware

2016-03-29 Thread Christian Ehrhardt
it upstream. Then later on (next dpdk release and it being packaged) it would always detect and use the latest available - wouldn't that be what everybody would want? Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Mar 25, 2016 at 2:31 AM, Martinx - ? wrote

[dpdk-dev] Suggestions for the dpdk stable tree

2016-03-24 Thread Christian Ehrhardt
cs functions commit 9a0615af7746485d73d10561cc0743bc2fcd4bf7 virtio: fix restart Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd

[dpdk-dev] Issues with openvswitch2.5+dpdk2.2+kvm/virtio-pci

2016-03-23 Thread Christian Ehrhardt
On Tue, Mar 22, 2016 at 9:47 PM, Daniele Di Proietto wrote: > Hi Christian, > > thanks for the report. I've managed to reproduce the problem and I > observed two separate issues: > > 1) short version: it appears to be a problem in DPDK 2.2 and it should be > fixed by 9a0615af7746("virtio: fix

[dpdk-dev] [PATCH v4 5/5] lpm: fix missing free of rules_tbl and lpm in rte_lpm_free*

2016-03-21 Thread Christian Ehrhardt
As found in rte_lpm6_free the two lpm interfaces rte_lpm_free_v20 and rte_lpm_free_v1604 had a leak. rte_lpm_free_v20 might have missed to free rules_tbl rte_lpm_free_v1604 due to an early exit might have missed to free rules_tbl and lpm itself. Acked-by: Olivier Matz Signed-off-by: Christian

[dpdk-dev] [PATCH v4 4/5] lpm: fix use after free of lpm in rte_lpm_create*

2016-03-21 Thread Christian Ehrhardt
There were further chances for a use after free by returning an already freed pointer in rte_lpm_create for v20 and v1604. Along that is also makes the RTE_LOG messages of the failed allocations unique. Acked-by: Olivier Matz Signed-off-by: Christian Ehrhardt --- lib/librte_lpm/rte_lpm.c | 6

[dpdk-dev] [PATCH v4 3/5] lpm: fix missing free of lpm

2016-03-21 Thread Christian Ehrhardt
Fixing lpm6 regarding a similar issue showed that that in rte_lpm_free lpm might not be freed if it didn't find a te (early return) Acked-by: Bruce Richardson Acked-by: Olivier Matz Signed-off-by: Christian Ehrhardt --- lib/librte_lpm/rte_lpm.c | 8 ++-- 1 file changed, 2 insertions(+), 6

[dpdk-dev] [PATCH v4 2/5] lpm6: fix missing free of rules_tbl and lpm

2016-03-21 Thread Christian Ehrhardt
ght not be freed if it didn't find a te (early return) - lpm->rules_tbl was not freed ever Acked-by: Bruce Richardson Acked-by: Olivier Matz Signed-off-by: Christian Ehrhardt --- lib/librte_lpm/rte_lpm6.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_lpm/rt

  1   2   >