[dpdk-dev] [PATCH 3/3] maintainers: add stable mailing list

Signed-off-by: Yuanhan Liu --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3df1754..076e86c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -35,6 +35,7 @@ F: scripts/test-build.sh Stable Branches --- T: git://dpdk.org/dpdk-stable

[dpdk-dev] [PATCH 2/3] maintainers: update virtio section name

Signed-off-by: Yuanhan Liu --- hmm.., maybe we could seperate lib vhost and virtio pmd, into two different sections? --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cc1ab68..3df1754 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[dpdk-dev] [PATCH 1/3] maintainers: update virtio maintainer

Huawei has left DPDK team for months, and he hasn't showed up since then. Remove him. Cc: Huawei Xie Signed-off-by: Yuanhan Liu --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 26d9590..cc1ab68 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

[dpdk-dev] [PATCH 0/3] maintainers: minor updates to virtio and stable

--- Yuanhan Liu (3): maintainers: update virtio maintainer maintainers: update virtio section name maintainers: add stable mailing list MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.9.0

[dpdk-dev] [dpdk-announce] DPDK 16.07.2 released

allocation of flow director queues net/mlx5: fix flow director drop mode Yong Wang (1): net/vmxnet3: fix mbuf release on reset/stop Yuanhan Liu (2): net/virtio: revert fix restart version: 16.07.2 Zhihong Wang (1): vhost: fix Windows VM hang

[dpdk-dev] [PATCH v2] virtio: tx with can_push when VERSION_1 is set

On Wed, Nov 30, 2016 at 09:18:42AM +, Pierre Pfister (ppfister) wrote: > Current virtio driver advertises VERSION_1 support, > but does not handle device's VERSION_1 support when > sending packets (it looks for ANY_LAYOUT feature, > which is absent). > > This patch enables 'can_push' in tx

[dpdk-dev] [PATCH] doc: introduce PVP reference benchmark

On Thu, Nov 24, 2016 at 08:35:51AM +0100, Maxime Coquelin wrote: > > > On 11/24/2016 06:07 AM, Yuanhan Liu wrote: > >First of all, thanks for the doc! It's a great one. > Thanks. > I would be interested to know if you have other tuning I don't mention > in this doc. I

[dpdk-dev] [PATCH] tools: add tags and cscope index file generation support

t(T=) > > example usage: > make tags T=x86_64-native-linuxapp-gcc > make cscope T=x86_64-native-linuxapp-gcc > make gtags T=x86_64-native-linuxapp-gcc > > Signed-off-by: Jerin Jacob It's handy. Thanks! Reviewed-by: Yuanhan Liu --yliu

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

On Thu, Nov 24, 2016 at 09:30:49AM +, Kevin Traynor wrote: > On 11/24/2016 06:31 AM, Yuanhan Liu wrote: > > On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: > >>>> You keep assuming that you have the VM started first and > >>>> figu

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

On Tue, Nov 22, 2016 at 04:53:05PM +0200, Michael S. Tsirkin wrote: > > > You keep assuming that you have the VM started first and > > > figure out things afterwards, but this does not work. > > > > > > Think about a cluster of machines. You want to start a VM in > > > a way that will ensure

[dpdk-dev] Proposal for a new Committer model

On Wed, Nov 23, 2016 at 03:19:19PM -0500, Neil Horman wrote: > On Wed, Nov 23, 2016 at 11:41:20PM +0800, Yuanhan Liu wrote: > > On Wed, Nov 23, 2016 at 09:11:54AM -0500, Neil Horman wrote: > > > > Could we define some of the potential subtrees now and look to &

[dpdk-dev] [PATCH] doc: introduce PVP reference benchmark

First of all, thanks for the doc! It's a great one. On Wed, Nov 23, 2016 at 10:00:06PM +0100, Maxime Coquelin wrote: > +Qemu build > +~~ > + > + .. code-block:: console > + > +git clone git://dpdk.org/dpdk > +cd dpdk > +export RTE_SDK=$PWD > +make install

[dpdk-dev] Proposal for a new Committer model

On Wed, Nov 23, 2016 at 09:11:54AM -0500, Neil Horman wrote: > > Could we define some of the potential subtrees now and look to introduce > > them in the this release cycle? EAL and the Core libs, as suggested by > > Thomas, seem like 2 obvious ones. > > > Sure, I'd suggest the following: I

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

On Thu, Nov 17, 2016 at 07:37:09PM +0200, Michael S. Tsirkin wrote: > On Thu, Nov 17, 2016 at 05:49:36PM +0800, Yuanhan Liu wrote: > > On Thu, Nov 17, 2016 at 09:47:09AM +0100, Maxime Coquelin wrote: > > > > > > > > > On 11/17/2016 09:29 AM, Yuanhan Liu wro

[dpdk-dev] 16.07.2 stable patches review and test

in flow director net/mlx5: refactor allocation of flow director queues net/mlx5: fix flow director drop mode Yong Wang (1): net/vmxnet3: fix mbuf release on reset/stop Yuanhan Liu (1): net/virtio: revert fix restart Zhihong Wang (1): vhost: fix Windows VM hang

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

On Thu, Nov 17, 2016 at 09:47:09AM +0100, Maxime Coquelin wrote: > > > On 11/17/2016 09:29 AM, Yuanhan Liu wrote: > >As usaual, sorry for late response :/ > > > >On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S. Tsirkin wrote: > >>Hi! > >>So it lo

[dpdk-dev] dpdk/vpp and cross-version migration for vhost

As usaual, sorry for late response :/ On Thu, Oct 13, 2016 at 08:50:52PM +0300, Michael S. Tsirkin wrote: > Hi! > So it looks like we face a problem with cross-version > migration when using vhost. It's not new but became more > acute with the advent of vhost user. > > For users to be able to

[dpdk-dev] [PATCH v2 10/10] net/virtio: fix multiple queue enabling

On Sat, Nov 05, 2016 at 05:41:05PM +0800, Yuanhan Liu wrote: > When queue number shrinks to 1 from X, the following code stops us > sending the multiple queue ctrl message: > > if (nb_queues > 1) { > if (virtio_set_multiple_queues(de

[dpdk-dev] [PATCH v2 09/10] net/virtio: fix less queues being enabled issue

queue number. Say, 2 Tx queues and 1 Rx queues. This would end up with 1 quues being enabled. Which is wrong. The fix is straightforward. Just pick a bigger number and enable that many of queues. Fixes: 823ad647950a ("virtio: support multiple queues") Signed-off-by: Yuanhan Liu --- dr

[dpdk-dev] [PATCH v2 08/10] net/virtio: remove started field

The "hw->started" field was introduced to stop touching queues on restart. We never touches queues on restart any more, thus it's safe to remove this flag. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 15 ++- drive

[dpdk-dev] [PATCH v2 07/10] net/virtio: complete init stage at the right place

Invoking vtpci_reinit_complete() at port start stage doesn't make any sense, instead, it should be done at the end of dev init stage. So move it here. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2

[dpdk-dev] [PATCH v2 06/10] net/virtio: move queue configure code to proper place

The only piece of code of virtio_dev_rxtx_start() is actually doing queue configure/setup work. So, move it to corresponding queue_setup callback. Once that is done, virtio_dev_rxtx_start() becomes an empty function, thus it's being removed. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime

[dpdk-dev] [PATCH v2 05/10] net/virtio: initiate vring at init stage

virtio_dev_vring_start() is actually doing the vring initiation job. And the vring initiation job should be done at the dev init stage, as stated with great details in former commit. So move it there, and rename it to virtio_init_vring(). Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin

[dpdk-dev] [PATCH v2 04/10] net/virtio: allocate queue at init stage

d also moved from the rx/tx_queue_release to dev close stage. That leading we could do nothing an empty rx/tx_queue_release() implementation. Signed-off-by: Yuanhan Liu --- v2: - free queues on dev close --- drivers/net/virtio/virtio_ethdev.c | 162 + drivers/net/virt

[dpdk-dev] [PATCH v2 03/10] net/virtio: simplify queue allocation

Let rxq/txq/cq be the union field of the virtqueue struct. This would simplifies the vq allocation a bit: we don't need calculate the vq_size any more based on the queue type. Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.c | 18

[dpdk-dev] [PATCH v2 01/10] net/virtio: revert fix restart

PMD driver and vhost-user would be inconsistent, leading some issue like above. Thus this patch is reverted. Fixes: 9a0615af7746 ("virtio: fix restart") Cc: Jianfeng Tan Cc: Reported-by: Kyle Larose Signed-off-by: Yuanhan Liu Reviewed-by: Maxime Coquelin --- drivers/net/virtio/vir

[dpdk-dev] [PATCH v2 00/10] net/virtio: fix queue reconfigure issue

v2: - fix two more minor issues regarding to queue enabling; see patch 9 and 10. - refined commit log a bit. Thanks. --yliu --- Yuanhan Liu (10): net/virtio: revert fix restart net/virtio: simplify queue memzone name net/virtio: simplify queue allocation net/virtio: allo

[dpdk-dev] [PATCH 4/8] net/virtio: allocate queue at init stage

On Fri, Nov 04, 2016 at 08:30:00PM +, Kevin Traynor wrote: > On 11/04/2016 03:21 PM, Kevin Traynor wrote: > > On 11/03/2016 04:09 PM, Yuanhan Liu wrote: > >> Queue allocation should be done once, since the queue related info (such > >> as vring addreess) will only be

[dpdk-dev] [PATCH v2] net/virtio: cache Rx/Tx offload ability check

It's not a good idea to do the check of whether Rx/Tx offload is enabled at the data path. Instead, we could do the check at init stage and store the result, so that we could avoid the check again and again at the critical datapath. Cc: Olivier Matz Signed-off-by: Yuanhan Liu --- v2: - rebase

[dpdk-dev] [PATCH 1/8] net/virtio: revert "virtio: fix restart"

On Fri, Nov 04, 2016 at 09:09:22AM +0100, Maxime Coquelin wrote: > > > On 11/04/2016 03:00 AM, Yuanhan Liu wrote: > >On Thu, Nov 03, 2016 at 09:36:52PM +0100, Maxime Coquelin wrote: > >>Hi Yuanhan, > >> > >>On 11/03/2016 05:09 PM, Yuanhan Liu wrote: >

[dpdk-dev] [PATCH 3/3] vhost: update comments

On Fri, Nov 04, 2016 at 01:28:45PM +, Mcnamara, John wrote: > > > > -Original Message- > > From: Yuanhan Liu [mailto:yuanhan.liu at linux.intel.com] > > Sent: Wednesday, November 2, 2016 3:15 AM > > To: dev at dpdk.org > > Cc: Mcnamara, John ; Yuan

[dpdk-dev] [PATCH RESEND v2] net/i40e: fix floating VEB issue

From: Beilei Xing Turning off S-TAG identification will impact floating VEB, VFs can't communicate with each other. This patch fixes this issue by judging whether floating VEB is enabled, S-TAG identification will be turned off only when floating VEB is disabled. Fixes:

[dpdk-dev] [PATCH RESEND v2] net/i40e: fix floating VEB issue

On Fri, Nov 04, 2016 at 05:33:20PM +0800, Yuanhan Liu wrote: > Turning off S-TAG identification will impact floating VEB, > VFs can't communicate with each other. > This patch fixes this issue by judging whether floating > VEB is enabled, S-TAG identification will be turned off

[dpdk-dev] [PATCH RESEND v2] net/i40e: fix floating VEB issue

Turning off S-TAG identification will impact floating VEB, VFs can't communicate with each other. This patch fixes this issue by judging whether floating VEB is enabled, S-TAG identification will be turned off only when floating VEB is disabled. Fixes: 4d61120d5ce7 ("net/i40e: fix dropping

[dpdk-dev] [PATCH] net/virtio: cache Rx/Tx offload enabled check

It's not a good idea to do Rx/Tx offload enabled check at the data path. Instead, we could do the check at init stage and store the result, so that we could avoid the check again and again at the critical datapath. Cc: Olivier Matz Signed-off-by: Yuanhan Liu --- drivers/net/virtio

[dpdk-dev] [PATCH v2] scripts: show fixes with release version of bug

xes of fixes are explored to find the oldest origin. > Fixes of not released bugs are ignored. Thomas, that saves my life! It helps a lot when I'm trying to pick commits for 16.07.2. So, Reviewed-by: Yuanhan Liu Thanks for the patch (and sorry for late reply). --yliu

[dpdk-dev] [PATCH 1/8] net/virtio: revert "virtio: fix restart"

On Thu, Nov 03, 2016 at 09:36:52PM +0100, Maxime Coquelin wrote: > Hi Yuanhan, > > On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > >This reverts commit 9a0615af7746 ("virtio: fix restart"); conflict is > >manually addressed. > > > >Kyle reported an issue w

[dpdk-dev] [PATCH 3/8] net/virtio: simplify queue allocation

On Thu, Nov 03, 2016 at 09:48:03PM +0100, Maxime Coquelin wrote: > > > On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > >Let rxq/txq/cq be the union field of the virtqueue struct. This would > >simplifies the vq allocation a bit: we don't need calculate the vq_size > >

[dpdk-dev] [PATCH 4/8] net/virtio: allocate queue at init stage

On Thu, Nov 03, 2016 at 10:11:43PM +0100, Maxime Coquelin wrote: > > > On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > >Queue allocation should be done once, since the queue related info (such > >as vring addreess) will only be informed to the vhost-user backend once > >

[dpdk-dev] [PATCH 8/8] net/virtio: remove started field

The "hw->started" field was introduced to stop touching queues on restart. We never touches queues on restart any more, thus it's safe to remove this flag. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 15 ++- drivers/net/virtio/virtio_pci.h|

[dpdk-dev] [PATCH 7/8] net/virtio: complete init stage at the right place

Invoking vtpci_reinit_complete() at port start stage doesn't make any sense, instead, it should be done at the end of dev init stage. So move it here. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[dpdk-dev] [PATCH 6/8] net/virtio: move queue configure code to proper place

The only piece of code of virtio_dev_rxtx_start() is actually doing queue configure/setup work. So, move it to corresponding queue_setup callback. Once that is done, virtio_dev_rxtx_start() becomes an empty function, thus it's being removed. Signed-off-by: Yuanhan Liu --- drivers/net/virtio

[dpdk-dev] [PATCH 5/8] net/virtio: initiate vring at init stage

virtio_dev_vring_start() is actually doing the vring initiation job. And the vring initiation job should be done at the dev init stage, as stated with great details in former commit. So move it there, and rename it to virtio_init_vring(). Signed-off-by: Yuanhan Liu --- drivers/net/virtio

[dpdk-dev] [PATCH 4/8] net/virtio: allocate queue at init stage

ice supports, but not nr queue pairs firstly configured, to make following case work. $ start_testpmd.sh ... --txq=1 --rxq=1 ... > port stop 0 > port config all txq 2 > port config all rxq 2 > port start 0 Signed-off-by: Yuanhan Liu --- drivers/net/virt

[dpdk-dev] [PATCH 3/8] net/virtio: simplify queue allocation

Let rxq/txq/cq be the union field of the virtqueue struct. This would simplifies the vq allocation a bit: we don't need calculate the vq_size any more based on the queue time. Signed-off-by: Yuanhan Liu --- drivers/net/virtio/virtio_ethdev.c | 18 +++--- drivers/net/virtio

[dpdk-dev] [PATCH 2/8] net/virtio: simplify queue memzone name

Instead of setting up a queue memzone name like "port0_rxq0", "port0_txq0", it could be simplified a bit to something like "port0_vq0", "port0_vq1" ... Meanwhile, the code is also simplified a bit. Signed-off-by: Yuanhan Liu --- drivers/net/virtio

[dpdk-dev] [PATCH 1/8] net/virtio: revert "virtio: fix restart"

started would be set to 1. Now, calling stop sets hw->started to 0, which means the next call to start will "touch the queues". This is the unintended side-effect that causes the problem. Fixes: 9a0615af7746 ("virtio: fix restart") Cc: Jianfeng Tan Cc: Reported-by: Kyl

[dpdk-dev] [PATCH 0/8] net/virtio: fix queue reconfigure issue

"fix" tag in none of those patches. All below patches work together to fix this issue. Thanks. --yliu --- Yuanhan Liu (8): net/virtio: revert "virtio: fix restart" net/virtio: simplify queue memzone name net/virtio: simplify queue allocation net/virtio: allo

[dpdk-dev] [PATCH 3/3] vhost: update comments

vhost-cuse is removed, update corresponding comments that are still referencing it. Signed-off-by: Yuanhan Liu --- examples/tep_termination/main.c | 7 ++- examples/vhost/main.c | 4 +--- examples/vhost_xen/main.c | 3 +-- lib/librte_vhost/rte_virtio_net.h | 5

[dpdk-dev] [PATCH 2/3] doc: update the vhost sample guide

of the doc and replace it with a simple test guide. For tep_term sample, mainly for removing the part has "vhost-cuse". Signed-off-by: Yuanhan Liu --- The test is simplified a bit (from using two virtio-net devices to one), meaning few figures doesn't apply anymore; thus, vhost_

[dpdk-dev] [PATCH 1/3] doc: update vhost programming guide

vhost-cuse has been removed in this release. Update the doc, with the vhost-cuse part being removed. Signed-off-by: Yuanhan Liu --- doc/guides/prog_guide/vhost_lib.rst | 62 + 1 file changed, 7 insertions(+), 55 deletions(-) diff --git a/doc/guides

[dpdk-dev] [PATCH 0/3] vhost: comments and doc update due to vhost-cuse removal

Here is a small patchset of updating vhost programming and sample guide and comments, due to the removal of vhost-cuse. --- Yuanhan Liu (3): doc: update vhost programming guide doc: update the vhost sample guide vhost: update comments doc/guides/prog_guide/vhost_lib.rst

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Tue, Nov 01, 2016 at 10:39:35AM +0100, Thomas Monjalon wrote: > 2016-11-01 16:15, Yuanhan Liu: > > On Fri, Oct 28, 2016 at 09:58:51AM +0200, Maxime Coquelin wrote: > > > Agree, what we need is to be able to disable Virtio PMD features > > > without having to rebui

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Fri, Oct 28, 2016 at 09:58:51AM +0200, Maxime Coquelin wrote: > >From my experience, and as Michael pointed out, the best mode for small > >packets is obviously > >ANY_LAYOUT so it uses a single descriptor per packet. > Of course, having a single descriptor is in theory the best way. > But, in

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Thu, Oct 27, 2016 at 12:35:11PM +0200, Maxime Coquelin wrote: > > > On 10/27/2016 12:33 PM, Yuanhan Liu wrote: > >On Thu, Oct 27, 2016 at 11:10:34AM +0200, Maxime Coquelin wrote: > >>Hi Zhihong, > >> > >>On 10/27/2016 11:00 AM, Wang, Zhihong wrote:

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

>Zhihong > > > >>-Original Message- > >>From: Maxime Coquelin [mailto:maxime.coquelin at redhat.com] > >>Sent: Monday, October 17, 2016 10:15 PM > >>To: Yuanhan Liu > >>Cc: Wang, Zhihong ; Xie, Huawei > >>; de

[dpdk-dev] [PATCH v7 3/7] vhost: simplify mergeable Rx vring reservation

On Wed, Oct 26, 2016 at 12:08:49AM +0200, Thomas Monjalon wrote: > 2016-10-14 17:34, Yuanhan Liu: > > -static inline uint32_t __attribute__((always_inline)) > > +static inline int __attribute__((always_inline)) > > copy_mbuf_to_desc_mergeable(struct virtio_net *dev, s

[dpdk-dev] [PATCH v2 1/3] drivers: add name alias registration for rte_driver

-by: Pablo de Lara Series Reviewed-by: Yuanhan Liu --yliu

[dpdk-dev] [PATCH 0/2] vhost: Add support to indirect descriptors on Rx path

On Tue, Oct 18, 2016 at 05:35:37PM +0200, Maxime Coquelin wrote: > Indirect descriptor feature has been enabled in v16.11-rc1, but only TX path > was implemented. > However, some configurations expect it is supported for the Rx path: > - Windows guests with and without mergeable buffers enabled >

[dpdk-dev] [PATCH v7 0/7] vhost: optimize mergeable Rx path

Applied to dpdk-next-virtio. And thanks for testing and reviewing. --yliu On Fri, Oct 14, 2016 at 05:34:31PM +0800, Yuanhan Liu wrote: > This is a new set of patches to optimize the mergeable Rx code path. > No refactoring (rewrite) was made this time. It just applies some >

[dpdk-dev] [PATCH] drivers: make driver names consistent

On Tue, Oct 18, 2016 at 06:46:40PM +0200, Thomas Monjalon wrote: > 2016-10-18 22:18, Yuanhan Liu: > > On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > > > 2016-10-18 21:06, Yuanhan Liu: > > > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Bl

[dpdk-dev] [PATCH] vhost: fix use after free issue

Fix the coverity USE_AFTER_FREE issue. Fixes: a277c7159876 ("vhost: refactor code structure") Coverity issue: 137884 Reported-by: John McNamara Signed-off-by: Yuanhan Liu --- lib/librte_vhost/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/li

[dpdk-dev] [PATCH v3] vhost: Only access header if offloading is supported in dequeue path

On Fri, Oct 14, 2016 at 10:07:07AM +0200, Maxime Coquelin wrote: > If offloading features are not negotiated, parsing the virtio header > is not needed. > > Micro-benchmark with testpmd shows that the gain is +4% with indirect > descriptors, +1% when using direct descriptors. > > Signed-off-by:

[dpdk-dev] [PATCH] drivers: make driver names consistent

On Tue, Oct 18, 2016 at 03:42:54PM +0200, Thomas Monjalon wrote: > 2016-10-18 21:06, Yuanhan Liu: > > On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > > > >From my understanding this is a massive API breakage. This forces all > > > existing users

[dpdk-dev] [PATCH] drivers: make driver names consistent

On Tue, Oct 18, 2016 at 02:50:16PM +0200, Jan Blunck wrote: > >From my understanding this is a massive API breakage. This forces all > existing users of the virtual PMDs to change with zero benefit. Even > if that isn't enough it also makes it impossible to switch between > releases by

[dpdk-dev] [PATCH] vhost: disable indirect descriptors feature

On Tue, Oct 18, 2016 at 10:13:54AM +0200, Maxime Coquelin wrote: > >>Thanks to Zhihong series you reworked, the changes to be done for > >>mergeable buffers case is greatly simplified. > >>I'll send the series later today. > > > >Do you mean the v6 from Zhihong? Unluckily, it will not be merged.

[dpdk-dev] [PATCH v4] vhost: Add indirect descriptors support to the TX path

On Mon, Oct 17, 2016 at 01:23:23PM +0200, Maxime Coquelin wrote: > >On my side, I just setup 2 Windows 2016 VMs, and confirm the issue. > >I'll continue the investigation early next week. > > The root cause is identified. > When INDIRECT_DESC feature is negotiated, Windows guest uses indirect >

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

On Thu, Oct 13, 2016 at 11:23:44AM +0200, Maxime Coquelin wrote: > I was going to re-run some PVP benchmark with 0% pkt loss, as I had > some strange results last week. > > Problem is that your series no more apply cleanly due to > next-virtio's master branch history rewrite. > Any chance you

[dpdk-dev] [PATCH v7 7/7] vhost: retrieve avail head once

ecause the virtio driver could be updating it while vhost is reading it (for each packet). Signed-off-by: Yuanhan Liu Signed-off-by: Zhihong Wang --- lib/librte_vhost/virtio_net.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_vhost/virtio_net.c

[dpdk-dev] [PATCH v7 6/7] vhost: prefetch avail ring

Signed-off-by: Yuanhan Liu Signed-off-by: Zhihong Wang --- lib/librte_vhost/virtio_net.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c index 2bdc2fe..12a037b 100644 --- a/lib/librte_vhost/virtio_net.c +++ b/lib/librte_vhost

[dpdk-dev] [PATCH v7 5/7] vhost: shadow used ring update

w many descs will be used. Which means we could update the shadow used ring at the reservation time. It also introduce another slight advantage: we don't need access the desc->flag any more inside copy_mbuf_to_desc_mergeable(). Signed-off-by: Zhihong Wang Signed-off-by: Yuanhan Liu

[dpdk-dev] [PATCH v7 3/7] vhost: simplify mergeable Rx vring reservation

Let it return "num_buffers" we reserved, so that we could re-use it with copy_mbuf_to_desc_mergeable() directly, instead of calculating it again there. Meanwhile, the return type of copy_mbuf_to_desc_mergeable is changed to "int". -1 will be return on error. Signed-off-by:

[dpdk-dev] [PATCH v7 2/7] vhost: optimize cache access

ssible. On a Haswell machine, about 100 cycles can be saved per packet by this patch alone. Taking 64B packets traffic for example, this means about 60% efficiency improvement for the enqueue operation. Signed-off-by: Zhihong Wang Signed-off-by: Yuanhan Liu --- lib/librte_vhost/virtio_net.

[dpdk-dev] [PATCH v7 1/7] vhost: remove useless volatile

From: Zhihong Wang last_used_idx is a local var, there is no need to decorate it by "volatile". Signed-off-by: Zhihong Wang --- lib/librte_vhost/vhost.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost.h

[dpdk-dev] [PATCH v7 0/7] vhost: optimize mergeable Rx path

- we already update used ring in batch in both path: it's not shadowed first though. - it's a bit too late too make many changes at this stage: RC1 is out. Please help testing. Thanks. --yliu Cc: Jianbo Liu --- Yuanhan Liu (4): vhost: simplify mergeable Rx vring reservation vhost

[dpdk-dev] 16.07.1 stable patches review and test

Hi, I have applied most of bug fixing patches (listed below) to the 16.07 stable branch at http://dpdk.org/browse/dpdk-stable/ Please help reviewing and testing. The planned date for the final release is 26th, Oct. Before that, please shout if anyone has objections with these patches being

[dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support

On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote: > +/* When doing TSO, the IP length is not included in the pseudo header > + * checksum of the packet given to the PMD, but for virtio it is > + * expected. > + */ > +static void > +virtio_tso_fix_cksum(struct rte_mbuf *m) > +{ > +

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Thu, Oct 13, 2016 at 05:45:21PM +0200, Olivier Matz wrote: > >> If you have a packet split like this: > >> > >> mbuf segment 1 mbuf segment 2 > >> -- > >> | Ethernet header | IP hea| |der | TCP header |

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Thu, Oct 13, 2016 at 05:15:24PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 05:01 PM, Yuanhan Liu wrote: > >On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: > >> > >> > >>On 10/13/2016 04:16 PM, Yuanhan Liu wrote: > >>>

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: > >In the "else" clause, the ip header is still in the mbuf, right? > >Why do you have to access it the way like: > > > > ip_version = *rte_pktmbuf_mtod_offset(m, uint8_t *, > > m->l2_len) >> 4; > > > >Why can't you just

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Thu, Oct 13, 2016 at 04:52:25PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 04:16 PM, Yuanhan Liu wrote: > >On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: > >> > >> > >>On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > >>>

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Thu, Oct 13, 2016 at 04:02:49PM +0200, Olivier MATZ wrote: > > > On 10/13/2016 10:18 AM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > >>+/* When doing TSO, the IP length is not included in the pseudo header > >>

[dpdk-dev] [PATCH v2 10/12] virtio: add Tx checksum offload support

On Mon, Oct 03, 2016 at 11:00:21AM +0200, Olivier Matz wrote: > + /* Checksum Offload */ > + switch (cookie->ol_flags & PKT_TX_L4_MASK) { > + case PKT_TX_UDP_CKSUM: > + hdr->csum_start = cookie->l2_len + cookie->l3_len; > + hdr->csum_offset = 6; > +

[dpdk-dev] [PATCH v2 12/12] virtio: add Tso support

On Mon, Oct 03, 2016 at 11:00:23AM +0200, Olivier Matz wrote: > +/* When doing TSO, the IP length is not included in the pseudo header > + * checksum of the packet given to the PMD, but for virtio it is > + * expected. > + */ > +static void > +virtio_tso_fix_cksum(struct rte_mbuf *m) > +{ > +

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

On Wed, Oct 12, 2016 at 06:01:25PM +0200, Olivier MATZ wrote: > Hello Yuanhan, > > On 10/12/2016 04:41 PM, Yuanhan Liu wrote: > >On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: > >>@@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) >

[dpdk-dev] [dpdk-stable] [PATCH v6 1/6] vhost: fix windows vm hang

On Mon, Sep 19, 2016 at 10:00:12PM -0400, Zhihong Wang wrote: > This patch fixes a Windows VM compatibility issue in DPDK 16.07 vhost code > which causes the guest to hang once any packets are enqueued when mrg_rxbuf > is turned on by setting the right id and len in the used ring. > > As defined

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

On Wed, Oct 12, 2016 at 12:22:08PM +, Wang, Zhihong wrote: > > > >> > 3. How many percentage of drop are you seeing? > > > The testing result: > > > size (bytes) improvement (%) > > > 64 3.92 > > > 128 11.51 > > > 256 24.16 > > > 512

[dpdk-dev] [PATCH v2 03/12] virtio: reinitialize the device in configure callback

On Mon, Oct 03, 2016 at 11:00:14AM +0200, Olivier Matz wrote: > @@ -1344,6 +1347,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) > { > const struct rte_eth_rxmode *rxmode = >data->dev_conf.rxmode; > struct virtio_hw *hw = dev->data->dev_private; > + uint64_t req_features; >

[dpdk-dev] [PATCH v2 09/12] virtio: add Rx checksum offload support

On Wed, Oct 05, 2016 at 03:27:47PM +0200, Maxime Coquelin wrote: > >/* Update offload features */ > >- if (virtio_rx_offload(rxm, hdr) < 0) { > >+ if ((features & VIRTIO_NET_F_GUEST_CSUM) && > s/VIRTIO_NET_F_GUEST_CSUM/(1u << VIRTIO_NET_F_GUEST_CSUM)/

[dpdk-dev] [PATCH v3 0/7] vhost: add dequeue zero copy support

On Sun, Oct 09, 2016 at 03:27:53PM +0800, Yuanhan Liu wrote: > This patch set enables vhost dequeue zero copy. The majority work goes > to patch 4: "vhost: add dequeue zero copy". Applied to dpdk-next-virtio. --yliu > > The basic idea of dequeue zero copy is, i

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Tue, Oct 11, 2016 at 02:57:49PM +0800, Yuanhan Liu wrote: > > > > > > There was an example: the vhost enqueue optmization patchset from > > > > > > Zhihong [0] uses memset, and it introduces more than 15% drop (IIRC) Though it doesn't matter n

[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue

On Thu, Sep 22, 2016 at 01:47:45PM +0800, Jianbo Liu wrote: > On 22 September 2016 at 10:29, Yuanhan Liu > wrote: > > On Wed, Sep 21, 2016 at 08:54:11PM +0800, Jianbo Liu wrote: > >> >> > My setup consists of one host running a guest. > >> >>

[dpdk-dev] [PATCH v2 00/12] net/virtio: add offload support

On Tue, Oct 11, 2016 at 02:14:10PM +0200, Olivier MATZ wrote: > Hi Yuanhan, > > On 10/11/2016 01:35 PM, Yuanhan Liu wrote: > >Hi, > > > >Firstly, apologize for so late review. It's been forgotten :( > > > >BTW, please feel free to ping me in future if I

[dpdk-dev] [PATCH v2 00/12] net/virtio: add offload support

Hi, Firstly, apologize for so late review. It's been forgotten :( BTW, please feel free to ping me in future if I made no response in one or two weeks! I haven't reviewed it carefully yet (something I will do tomorrow). Before that, few quick questions. Firstly, would you write down some test

[dpdk-dev] [PATCH v2] vhost: Only access header if offloading is supported in dequeue path

On Tue, Oct 11, 2016 at 09:45:27AM +0200, Maxime Coquelin wrote: > @@ -684,12 +699,12 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct > vring_desc *descs, > struct rte_mempool *mbuf_pool) > { > struct vring_desc *desc; > - uint64_t desc_addr; > + uint64_t

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Mon, Oct 10, 2016 at 07:39:59AM +0300, Michael S. Tsirkin wrote: > > > > > > 1. why is this memset expensive? > > > > > > > > > > I don't have the exact answer, but just some rough thoughts: > > > > > > > > > > It's an external clib function: there is a call stack and the > > > > > IP register

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Tue, Oct 11, 2016 at 08:39:54AM +0200, Maxime Coquelin wrote: > > > On 10/11/2016 08:04 AM, Yuanhan Liu wrote: > >On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote: > >> > >> > >>On 10/10/2016 04:42 PM, Yuanhan Liu wrote: > >&g

[dpdk-dev] [Qemu-devel] [PATCH 1/2] vhost: enable any layout feature

On Mon, Oct 10, 2016 at 04:54:39PM +0200, Maxime Coquelin wrote: > > > On 10/10/2016 04:42 PM, Yuanhan Liu wrote: > >On Mon, Oct 10, 2016 at 02:40:44PM +0200, Maxime Coquelin wrote: > >>>>>At that time, a packet always use 2 descs. Since indirect desc i

[dpdk-dev] 17.02 Roadmap

On Mon, Oct 10, 2016 at 10:42:58PM +0200, Thomas Monjalon wrote: > > Support New Device Types in Vhost-User: Support will be added to vhost-user > > for new device types including vhost-scsi and vhost-blk. > > Great! > Is it only related to networking or should we expect some storage-related >

[dpdk-dev] [PATCH V2 2/2] virtio: support IOMMU platform

On Fri, Oct 07, 2016 at 07:24:44AM +0300, Michael S. Tsirkin wrote: > On Wed, Sep 28, 2016 at 04:25:12PM +0800, Jason Wang wrote: > > Negotiate VIRTIO_F_IOMMU_PLATFORM to have IOMMU support. > > > > Signed-off-by: Jason Wang > > --- > > Changes from v1: > > - remove unnecessary NEED_MAPPING

  1   2   3   4   5   6   7   8   9   10   >