Re: Review Request 30965: Follow up on DRILL-133 (LocalExchange) to save CPU cycles on hash generation when using in HashToLocalExchange

2015-03-03 Thread Yuliya Feldman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30965/ --- (Updated March 3, 2015, 12:59 a.m.) Review request for drill, Jacques Nadeau, J

Join us for the Hangout today

2015-03-03 Thread Yash Sharma
Hi Drillers, Lets meet up for the monthly G+ Hangout usual time (10 AM PDT) - to discuss stuffs we are working on. I would be talking on the suggestions provided on Cassandra Storage and how we can allow Drill-Cassandra interoperability. Would encourage new developers join and share what they are

Re: Review Request 30313: Fixing Mongo join issue when * is selected

2015-03-03 Thread Mariano Ruiz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/#review74955 --- This patch solve the issue #DRILL-2352 reported by me. Thanks! - Ma

Re: Review Request 30313: Fixing Mongo join issue when * is selected

2015-03-03 Thread Kamesh B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- (Updated March 3, 2015, 3:54 p.m.) Review request for drill, Jacques Nadeau and

Re: Review Request 30313: Fixing Mongo join issue when * is selected

2015-03-03 Thread Mariano Ruiz
> On Marzo 3, 2015, 3:10 p.m., Mariano Ruiz wrote: > > This patch solve the issue #DRILL-2352 reported by me. Thanks! Ups, I made some extra tests, and found some errors. I not sure if they are related to this patch. Please check my comments in the bug reported [here](https://issues.apache.org

Re: Would someone be able to lead the hangout today?

2015-03-03 Thread Jason Altekruse
I did not see Yash's message before I sent this, please see his message for more info. On Tue, Mar 3, 2015 at 8:15 AM, Jason Altekruse wrote: > I will not have time this morning to lead the hangout, anyone with topics > to discuss is welcome to still attend and post minutes to the list. If > any

Would someone be able to lead the hangout today?

2015-03-03 Thread Jason Altekruse
I will not have time this morning to lead the hangout, anyone with topics to discuss is welcome to still attend and post minutes to the list. If anyone knows they can make it feel free to raise your hand for leading the meeting. You don't have to do prep, just collect discussion topics from the att

Re: Would someone be able to lead the hangout today?

2015-03-03 Thread Yash Sharma
Thanks Jason. I will be there to take the notes and share them across. On 3 Mar 2015 9:52 pm, "Jason Altekruse" wrote: > I did not see Yash's message before I sent this, please see his message for > more info. > > On Tue, Mar 3, 2015 at 8:15 AM, Jason Altekruse > wrote: > > > I will not have tim

Re: Review Request 31553: DRILL-2262: selecting columns of certain datatypes from a dictionary encoded parquet file created by drill fails

2015-03-03 Thread abdelhakim deneche
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31553/ --- (Updated March 3, 2015, 5:39 p.m.) Review request for drill and Steven Phillips

Re: Join us for the Hangout today

2015-03-03 Thread Yash Sharma
The hangout is on. On Tue, Mar 3, 2015 at 8:17 PM, Yash Sharma wrote: > Hi Drillers, > Lets meet up for the monthly G+ Hangout usual time (10 AM PDT) - to > discuss stuffs we are working on. > > I would be talking on the suggestions provided on Cassandra Storage and > how we can allow Drill-Cass

Re: Review Request 31651: DRILL-2322: CSV record reader should log which file and which record caused an error in the reader

2015-03-03 Thread Sudheesh Katkam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31651/ --- (Updated March 3, 2015, 6:12 p.m.) Review request for drill and Venki Korukanti

Review Request 31688: DRILL-1385.2-1-hygiene.patch.txt: options cleanup done while working on scalar replacement

2015-03-03 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31688/ --- Review request for drill and Jacques Nadeau. Bugs: DRILL-1385 https://issue

Re: Join us for the Hangout today

2015-03-03 Thread Yash Sharma
Attendees : Anh, Byron, Krystine, Xiao, Shadi, Shudhakar, Norris, Alexander, Yash Meeting minutes - Anh : - Exploring Drill for his use case on SQL native files on shared drive. Anh do share any issues you face with Drill or any part of Drill you would like to have more info on. Krystine : - L

Review Request 31691: DRILL-1385.4.patch.txt: rebase squashed single patch for scalar replacement with option handling cleanup

2015-03-03 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31691/ --- Review request for drill and Jacques Nadeau. Bugs: DRILL-1385 https://issue

Re: Loggers should be private

2015-03-03 Thread Chris Westin
I've been making them private as I go -- that's how this came up, form a code review. On Mon, Mar 2, 2015 at 8:49 PM, Hanifi Gunes wrote: > Agreed. > > - Does anyone object to making all the loggers in the Drill codebase > private > from now on? > Does this include making existing ones private a

Re: Loggers should be private

2015-03-03 Thread Chris Westin
Re: "If they are private you get an unused exception unless you suppress the warning. Making them package private means no warning and no suppression required." Given the enormous number of other warnings that are present, this seems pretty weak. And yes, I've been cleaning up all those warnings a

Re: Loggers should be private

2015-03-03 Thread Chris Westin
Re: "If they are private you get an unused exception unless you suppress the warning. Making them package private means no warning and no suppression required." Given the enormous number of other warnings that are present, this seems pretty weak. And yes, I've been cleaning up all those warnings a

Re: Review Request 30313: Fixing Mongo join issue when * is selected

2015-03-03 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/#review75019 --- Ship it! - Hanifi Gunes On March 3, 2015, 3:54 p.m., Kamesh B wro

Review Request 31697: DRILL-2323: Parquet record reader should log which file and which record caused an error in the reader

2015-03-03 Thread Sudheesh Katkam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31697/ --- Review request for drill and Venki Korukanti. Repository: drill-git Descripti

[jira] [Created] (DRILL-2362) QueryInfo collection grows without bound

2015-03-03 Thread Chris Westin (JIRA)
Chris Westin created DRILL-2362: --- Summary: QueryInfo collection grows without bound Key: DRILL-2362 URL: https://issues.apache.org/jira/browse/DRILL-2362 Project: Apache Drill Issue Type: Bug

Re: Review Request 30701: DRILL-2173 partition queries for dynamic partition pruning

2015-03-03 Thread Jason Altekruse
> On Feb. 28, 2015, 12:26 a.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/DirectoryExplorers.java, > > line 71 > > > > > > Is there a reason to use java.io. here? In the c

Re: Review Request 31521: fix broken links in gh-pages-master docs

2015-03-03 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31521/ --- (Updated March 3, 2015, 8:42 p.m.) Review request for drill and Bridget Bridget

Re: Review Request 31521: fix broken links in gh-pages-master docs

2015-03-03 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31521/ --- (Updated March 3, 2015, 8:43 p.m.) Review request for drill and Bridget Bridget

[jira] [Created] (DRILL-2363) Support user impersonation in Drill

2015-03-03 Thread Venki Korukanti (JIRA)
Venki Korukanti created DRILL-2363: -- Summary: Support user impersonation in Drill Key: DRILL-2363 URL: https://issues.apache.org/jira/browse/DRILL-2363 Project: Apache Drill Issue Type: New

[jira] [Resolved] (DRILL-2316) Docs Enhancement: Data Sources and File Formats, Basics Tutorial

2015-03-03 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2316. -- Resolution: Fixed Review #31459 completed, patch committed. > Docs Enhancement: Data Sources an

Re: Loggers should be private

2015-03-03 Thread Jacques Nadeau
Seems like a good consensus to go private. Unless any other objections, this seems decided. On Tue, Mar 3, 2015 at 10:50 AM, Chris Westin wrote: > I've been making them private as I go -- that's how this came up, form a > code review. > > On Mon, Mar 2, 2015 at 8:49 PM, Hanifi Gunes wrote: > >

[jira] [Resolved] (DRILL-2336) configuration storage plugin docs update

2015-03-03 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2336. -- Resolution: Fixed Review #31655 completed, patch committed. > configuration storage plugin doc

[jira] [Created] (DRILL-2364) JSON Data Model Reference 2nd draft

2015-03-03 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-2364: Summary: JSON Data Model Reference 2nd draft Key: DRILL-2364 URL: https://issues.apache.org/jira/browse/DRILL-2364 Project: Apache Drill Issue Type: Task

Re: Review Request 30051: DRILL-1908: new window function implementation

2015-03-03 Thread abdelhakim deneche
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30051/ --- (Updated March 3, 2015, 10 p.m.) Review request for drill and Jacques Nadeau.

Re: Review Request 31521: fix broken links in gh-pages-master docs

2015-03-03 Thread Bridget Bridget
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31521/#review75057 --- Ship it! Looks good! - Bridget Bridget On March 3, 2015, 8:43 p.

Review Request 31707: DRILL-2207: New Union-All Implementation

2015-03-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/ --- Review request for drill, Aman Sinha and Jinfeng Ni. Bugs: DRILL-2207 https

Re: Review Request 31707: DRILL-2207: New Union-All Implementation

2015-03-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/ --- (Updated March 3, 2015, 10:37 p.m.) Review request for drill, Aman Sinha and Ji

Re: Review Request 31707: DRILL-2207: New Union-All Implementation

2015-03-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/ --- (Updated March 3, 2015, 10:37 p.m.) Review request for drill, Aman Sinha and Ji

[jira] [Created] (DRILL-2365) populate values for 'kind' for sys.options with type == 'BOOT'

2015-03-03 Thread Zhiyong Liu (JIRA)
Zhiyong Liu created DRILL-2365: -- Summary: populate values for 'kind' for sys.options with type == 'BOOT' Key: DRILL-2365 URL: https://issues.apache.org/jira/browse/DRILL-2365 Project: Apache Drill

[jira] [Created] (DRILL-2366) Query nested lists causing IllegalArgumentException

2015-03-03 Thread Chun Chang (JIRA)
Chun Chang created DRILL-2366: - Summary: Query nested lists causing IllegalArgumentException Key: DRILL-2366 URL: https://issues.apache.org/jira/browse/DRILL-2366 Project: Apache Drill Issue Type

[jira] [Created] (DRILL-2367) drill.exec.storage.file.partition.column.label appears as an option for both BOOT and SYSTEM

2015-03-03 Thread Zhiyong Liu (JIRA)
Zhiyong Liu created DRILL-2367: -- Summary: drill.exec.storage.file.partition.column.label appears as an option for both BOOT and SYSTEM Key: DRILL-2367 URL: https://issues.apache.org/jira/browse/DRILL-2367

Re: Review Request 31707: DRILL-2207: New Union-All Implementation

2015-03-03 Thread Jason Altekruse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31707/#review75077 --- exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java

[jira] [Created] (DRILL-2368) sqlline hangs when drill is in a bad state

2015-03-03 Thread Zhiyong Liu (JIRA)
Zhiyong Liu created DRILL-2368: -- Summary: sqlline hangs when drill is in a bad state Key: DRILL-2368 URL: https://issues.apache.org/jira/browse/DRILL-2368 Project: Apache Drill Issue Type: Bug

[jira] [Created] (DRILL-2369) It takes too long to plan inner join query with 10 join predicates

2015-03-03 Thread Victoria Markman (JIRA)
Victoria Markman created DRILL-2369: --- Summary: It takes too long to plan inner join query with 10 join predicates Key: DRILL-2369 URL: https://issues.apache.org/jira/browse/DRILL-2369 Project: Apach

[jira] [Created] (DRILL-2370) Missing cancellation acknowledgements leave orphaned cancelled queries around

2015-03-03 Thread Chris Westin (JIRA)
Chris Westin created DRILL-2370: --- Summary: Missing cancellation acknowledgements leave orphaned cancelled queries around Key: DRILL-2370 URL: https://issues.apache.org/jira/browse/DRILL-2370 Project: Ap

[jira] [Created] (DRILL-2371) quoted and unquoted boolean values in BOOT options have strange behavior

2015-03-03 Thread Zhiyong Liu (JIRA)
Zhiyong Liu created DRILL-2371: -- Summary: quoted and unquoted boolean values in BOOT options have strange behavior Key: DRILL-2371 URL: https://issues.apache.org/jira/browse/DRILL-2371 Project: Apache Dr

Re: Review Request 31435: DRILL-2245-core: core changes for improved drillbit stability

2015-03-03 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31435/ --- (Updated March 3, 2015, 4:21 p.m.) Review request for drill and Jacques Nadeau.

Re: Review Request 31435: DRILL-2245-core: core changes for improved drillbit stability

2015-03-03 Thread Chris Westin
> On Feb. 26, 2015, 9:56 p.m., Jacques Nadeau wrote: > > exec/java-exec/src/test/java/org/apache/drill/exec/TestWithZookeeper.java, > > line 31 > > > > > > why commented? I see no downside to having an not-yet used lo

[jira] [Created] (DRILL-2372) current_date() should convert input to UTC before storing in vector

2015-03-03 Thread Mehant Baid (JIRA)
Mehant Baid created DRILL-2372: -- Summary: current_date() should convert input to UTC before storing in vector Key: DRILL-2372 URL: https://issues.apache.org/jira/browse/DRILL-2372 Project: Apache Drill

[jira] [Created] (DRILL-2373) JSON query request returns all types as strings

2015-03-03 Thread Adam Gilmore (JIRA)
Adam Gilmore created DRILL-2373: --- Summary: JSON query request returns all types as strings Key: DRILL-2373 URL: https://issues.apache.org/jira/browse/DRILL-2373 Project: Apache Drill Issue Type

Review Request 31719: fold in tech review changes to json doc on gh-pages-master

2015-03-03 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31719/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2364 https://issu

[jira] [Created] (DRILL-2374) Sqlline prompt history needs improvements

2015-03-03 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-2374: -- Summary: Sqlline prompt history needs improvements Key: DRILL-2374 URL: https://issues.apache.org/jira/browse/DRILL-2374 Project: Apache Drill Issue Type

Build failed in Jenkins: drill-scm #246

2015-03-03 Thread Apache Jenkins Server
See Changes: [pchandra] DRILL-1875: getTransferClone should ignore given wrappers [pchandra] DRILL-2118: inform user with a user friendly error message if kvgen fails due to heterogenous types -- [...

Re: Review Request 30313: Fixing Mongo join issue when * is selected

2015-03-03 Thread Kamesh B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30313/ --- (Updated March 4, 2015, 2:11 a.m.) Review request for drill, Jacques Nadeau and

[jira] [Created] (DRILL-2375) project more than one column from nested array causes indexoutofbounds exception

2015-03-03 Thread Chun Chang (JIRA)
Chun Chang created DRILL-2375: - Summary: project more than one column from nested array causes indexoutofbounds exception Key: DRILL-2375 URL: https://issues.apache.org/jira/browse/DRILL-2375 Project: Apa

[jira] [Resolved] (DRILL-2211) Define realloc(), allocationMonitor behavior when using fixed size allocation methods in ValueVectors

2015-03-03 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-2211. Resolution: Fixed Fixed in 9c0738d94f246443554a1b6d03c7a8d4d21d29a8 > Define realloc(), allocationM

[jira] [Resolved] (DRILL-2112) Throw helpful error message with unsupported KVGen functionality

2015-03-03 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-2112. Resolution: Duplicate > Throw helpful error message with unsupported KVGen functionality >

[jira] [Created] (DRILL-2376) UNION ALL on Aggregates with GROUP BY returns incomplete results

2015-03-03 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-2376: -- Summary: UNION ALL on Aggregates with GROUP BY returns incomplete results Key: DRILL-2376 URL: https://issues.apache.org/jira/browse/DRILL-2376 Project: Apache Dr

[jira] [Created] (DRILL-2377) UNION ALL on Aggregates with GROUP BY returns null when column aliases don't match

2015-03-03 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-2377: -- Summary: UNION ALL on Aggregates with GROUP BY returns null when column aliases don't match Key: DRILL-2377 URL: https://issues.apache.org/jira/browse/DRILL-2377

[jira] [Created] (DRILL-2378) UNION ALL on Aggregates with GROUP BY and ORDER BY fails when column aliases don't match

2015-03-03 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-2378: -- Summary: UNION ALL on Aggregates with GROUP BY and ORDER BY fails when column aliases don't match Key: DRILL-2378 URL: https://issues.apache.org/jira/browse/DRILL-2378

[jira] [Created] (DRILL-2379) UNION ALL with ORDER BY fails when column aliases don't match

2015-03-03 Thread Abhishek Girish (JIRA)
Abhishek Girish created DRILL-2379: -- Summary: UNION ALL with ORDER BY fails when column aliases don't match Key: DRILL-2379 URL: https://issues.apache.org/jira/browse/DRILL-2379 Project: Apache Drill