[jira] [Created] (DRILL-2673) Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Venki Korukanti (JIRA)
Venki Korukanti created DRILL-2673: -- Summary: Update UserServer <==> UserClient RPC to handle handshake response better Key: DRILL-2673 URL: https://issues.apache.org/jira/browse/DRILL-2673 Project:

[jira] [Created] (DRILL-2674) Add user authenticator interface and PAM based implementation

2015-04-03 Thread Venki Korukanti (JIRA)
Venki Korukanti created DRILL-2674: -- Summary: Add user authenticator interface and PAM based implementation Key: DRILL-2674 URL: https://issues.apache.org/jira/browse/DRILL-2674 Project: Apache Drill

Re: Review Request 31160: DRILL-2244: Implicit cast for join conditions

2015-04-03 Thread Mehant Baid
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/ --- (Updated April 3, 2015, 8:13 a.m.) Review request for drill and Aman Sinha. C

[jira] [Resolved] (DRILL-2511) Assert with full outer join when one of the join predicates is of a required type (nullabe parquet)

2015-04-03 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-2511. Resolution: Cannot Reproduce Assignee: Victoria Markman (was: Mehant Baid) The files uploaded

[jira] [Resolved] (DRILL-2546) Implicit Cast : Joining 2 tables on columns which are float and double should succeed when the values are equal

2015-04-03 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-2546. Resolution: Invalid Certain floating point values cannot be represented accurately in binary, hence

Re: Review Request 31160: DRILL-2244: Implicit cast for join conditions

2015-04-03 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31160/#review78788 --- Ship it! Updated patch looks ok to me. Couple of suggestions about

[jira] [Created] (DRILL-2675) Implement a subset of User Exceptions to improve how errors are reported to the user

2015-04-03 Thread Deneche A. Hakim (JIRA)
Deneche A. Hakim created DRILL-2675: --- Summary: Implement a subset of User Exceptions to improve how errors are reported to the user Key: DRILL-2675 URL: https://issues.apache.org/jira/browse/DRILL-2675

Re: Review Request 32634: DRILL-2612: Union All involving empty JSON file on right input to union all returns zero results

2015-04-03 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32634/#review78792 --- This looks like the wrong patch.. can you pls upload the correct pat

Re: Review Request 32634: DRILL-2612: Union All involving empty JSON file on right input to union all returns zero results

2015-04-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32634/ --- (Updated April 3, 2015, 4:37 p.m.) Review request for drill and Aman Sinha. C

Review Request 32799: DRILL-2596: CTAS plan should be shown in the Web UI

2015-04-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32799/ --- Review request for drill, Aman Sinha and Jason Altekruse. Bugs: DRILL-2596

Timing out unit tests on master

2015-04-03 Thread Jason Altekruse
Drillers, I have a series of unit test consistently timing out when I run against master, as well as a few different recent commits. I will be doing some more digging today, but just a heads up for those running unit tests on a linux VM. The problem occurs even if I just ask Maven to run the one t

Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32819/ --- Review request for drill, Jacques Nadeau and Parth Chandra. Bugs: DRILL-2673

Re: Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32819/ --- (Updated April 3, 2015, 4:57 p.m.) Review request for drill, Jacques Nadeau and

[jira] [Resolved] (DRILL-1810) Scalability issues with kvgen

2015-04-03 Thread Mehant Baid (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mehant Baid resolved DRILL-1810. Resolution: Fixed This issue seems to be only tracking the memory leak in kvgen, which I think was

Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in the Web UI

2015-04-03 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32799/#review78810 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Dril

Re: Timing out unit tests on master

2015-04-03 Thread Sudheesh Katkam
I am getting these on my Mac: Four timeouts, other than the ones mentioned by Jason. > TestParquetWriter.testTPCHReadWrite7:131->runTestAndValidate:465->BaseTestQuery.testRunAndReturn:205 > » > testTPCHReadWrite7(org.apache.drill.exec.physical.impl.writer.TestParquetWriter) > Time elapsed: 50.5

[jira] [Created] (DRILL-2676) Review Drill casting combinations re SQL standard (ISO 9705:2011 part 2 § 6.13)

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2676: - Summary: Review Drill casting combinations re SQL standard (ISO 9705:2011 part 2 § 6.13) Key: DRILL-2676 URL: https://issues.apache.org/jira/browse/DRILL-2676

Re: Timing out unit tests on master

2015-04-03 Thread Abdel Hakim Deneche
Do you still get timeouts if you reduce the forkCount to 2 in the main pom.xml ? On Fri, Apr 3, 2015 at 10:58 AM, Sudheesh Katkam wrote: > I am getting these on my Mac: > > Four timeouts, other than the ones mentioned by Jason. > > > TestParquetWriter.testTPCHReadWrite7:131->runTestAndValidate:4

Re: Timing out unit tests on master

2015-04-03 Thread Sudheesh Katkam
Well, I ran the tests again. There are no timeouts this time but the IOOB still happens. Both runs the forkCount was 2. > On Apr 3, 2015, at 11:18 AM, Abdel Hakim Deneche > wrote: > > Do you still get timeouts if you reduce the forkCount to 2 in the main > pom.xml ? > > On Fri, Apr 3, 2015

Re: Timing out unit tests on master

2015-04-03 Thread Mehant Baid
I am consistently seeing timeouts on the test: TestJdbcMetadata.allColumns(). I am able to reproduce it fairly consistently (even running this one test in isolation). This might be related to the fact that we are generating a huge amount of run time generated source as part of this test. Than

Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected

2015-04-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32590/ --- (Updated April 3, 2015, 8:04 p.m.) Review request for drill and Aman Sinha. B

Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in the Web UI

2015-04-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32799/ --- (Updated April 3, 2015, 8:07 p.m.) Review request for drill, Aman Sinha and Jas

Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in the Web UI

2015-04-03 Thread Sean Hsuan-Yi Chu
> On April 3, 2015, 5:56 p.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java, > > line 137 > > > > > > Is it necessary to create a separate getSqlHandler meth

Re: Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32819/ --- (Updated April 3, 2015, 8:29 p.m.) Review request for drill, Jacques Nadeau and

Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32831/ --- Review request for drill, Jacques Nadeau and Parth Chandra. Bugs: DRILL-2674

[jira] [Created] (DRILL-2677) Query does not go beyond 4096 lines in small JSON files

2015-04-03 Thread Alexander Reshetov (JIRA)
Alexander Reshetov created DRILL-2677: - Summary: Query does not go beyond 4096 lines in small JSON files Key: DRILL-2677 URL: https://issues.apache.org/jira/browse/DRILL-2677 Project: Apache Drill

Re: Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32831/ --- (Updated April 3, 2015, 8:37 p.m.) Review request for drill, Jacques Nadeau and

Re: Error using Hive storage Plugin: IOException: No FileSystem for scheme: maprfs

2015-04-03 Thread Ramana Inukonda
Please check if your drill-env.sh contains the following: export DRILL_JAVA_OPTS="$DRILL_JAVA_OPTS -Djava.security.auth.login.config=/opt/mapr/conf/mapr.login.conf -Dzookeeper.sasl.client=false " Regards Ramana On Thu, Apr 2, 2015 at 8:51 PM, Alexander Zarei wrote: > Hi, > > > I am suing Dr

Re: [jira] [Resolved] (DRILL-2629) Initial concurrent queries executed on separate Connections fail

2015-04-03 Thread Daniel Barclay
Note that Emer said "temporarily." Apparently he or she wants to disable his subscription without completely destroying it (and needing to re-establish it). Does the mailing list have that option? Abhishek Girish wrote: Please send a mail to dev-unsubscr...@drill.apache.org On Thu, Apr 2, 2

Re: Timing out unit tests on master

2015-04-03 Thread Abdel Hakim Deneche
I launched a build on my macbook and got an IOOB in the following test: TestExampleQueries.testCreateTableSameColumnNames On Fri, Apr 3, 2015 at 11:41 AM, Mehant Baid wrote: > I am consistently seeing timeouts on the test: > TestJdbcMetadata.allColumns(). I am able to reproduce it fairly > cons

Re: Error using Hive storage Plugin: IOException: No FileSystem for scheme: maprfs

2015-04-03 Thread Ramana Inukonda
Also is drill running on the same node as a MapR cluster? In that case you just can specify maprfs:/// for the connection value. Regards Ramana On Fri, Apr 3, 2015 at 1:40 PM, Ramana Inukonda wrote: > Please check if your drill-env.sh contains the following: > > export DRILL_JAVA_OPTS="$DRILL_

Re: Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32831/ --- (Updated April 3, 2015, 9:10 p.m.) Review request for drill, Jacques Nadeau and

[jira] [Created] (DRILL-2678) JSON appender not packaged with Drill

2015-04-03 Thread Bridget Bevens (JIRA)
Bridget Bevens created DRILL-2678: - Summary: JSON appender not packaged with Drill Key: DRILL-2678 URL: https://issues.apache.org/jira/browse/DRILL-2678 Project: Apache Drill Issue Type: Bug

Re: Timing out unit tests on master

2015-04-03 Thread Hanifi Gunes
Why is the forkCount set to 4 at the first place? It would make more sense if it was proportional to number of cores.[1] I believe we should fix this. Also my unit tests keep hanging or kernel-killed seemingly due to memory scarcity. It completes cleanly when forkCount is reduced. -Hanifi [1] ht

[jira] [Resolved] (DRILL-2301) Query fails when multiple table aliases are provided for CTEs

2015-04-03 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2301. -- Resolution: Fixed > Query fails when multiple table aliases are provided for CTEs >

[jira] [Resolved] (DRILL-2301) Query fails when multiple table aliases are provided for CTEs

2015-04-03 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2301. -- Resolution: Duplicate > Query fails when multiple table aliases are provided for CTEs >

[jira] [Resolved] (DRILL-1514) Joins are not working with mongo

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-1514. --- Resolution: Fixed Fix Version/s: (was: 0.9.0) 0.8.0 Marking as fixed bas

Re: Review Request 32795: DRILL-2383: Add exception and pause injections for testing drillbit stability

2015-04-03 Thread Chris Westin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32795/#review78815 --- exec/java-exec/src/main/java/org/apache/drill/exec/planner/Physical

[jira] [Resolved] (DRILL-2075) Subquery not projecting the order by column is causing issues when used along with flatten

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2075. --- Resolution: Duplicate > Subquery not projecting the order by column is causing issues when used along

[jira] [Resolved] (DRILL-2176) IndexOutOfBoundsException for count(*) on a subquery which does order-by

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2176. --- Resolution: Duplicate Pls re-test after re-basing on Calcite master branch. > IndexOutOfBoundsExcept

Review Request 32839: enhance sql functions docs, fix sandbox link

2015-04-03 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32839/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2667 https://issu

Re: Review Request 30701: DRILL-2173 partition queries for dynamic partition pruning

2015-04-03 Thread Jason Altekruse
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30701/ --- (Updated April 3, 2015, 11:12 p.m.) Review request for drill, Jacques Nadeau, M

[jira] [Resolved] (DRILL-2458) Extra hash column added when running CTAS with order by

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2458. --- Resolution: Fixed > Extra hash column added when running CTAS with order by >

[jira] [Created] (DRILL-2679) Out-of-range messages should report range bounds

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2679: - Summary: Out-of-range messages should report range bounds Key: DRILL-2679 URL: https://issues.apache.org/jira/browse/DRILL-2679 Project: Apache Drill

[jira] [Resolved] (DRILL-2481) Querying individual column from view results in AssertionError

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2481. --- Resolution: Fixed The error message when running the second query is appropriate behavior here, since

[jira] [Resolved] (DRILL-1941) select from subquery having an order by fails

2015-04-03 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-1941. -- Resolution: Duplicate the same issue where subquery order by a column which is not prese

[jira] [Resolved] (DRILL-1302) Order by using table.col in subquery fails with ArrayIndexOutOfBoundsException

2015-04-03 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-1302. -- Resolution: Duplicate the same issue where subquery order by a column which is not prese

[jira] [Created] (DRILL-2680) Assertions and thrown AssertionsErrors should include some message text

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2680: - Summary: Assertions and thrown AssertionsErrors should include some message text Key: DRILL-2680 URL: https://issues.apache.org/jira/browse/DRILL-2680

Re: Review Request 32839: enhance sql functions docs, fix sandbox link

2015-04-03 Thread Bridget Bridget
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32839/#review78866 --- Ship it! Ship It! - Bridget Bridget On April 3, 2015, 11:06 p.m.

[jira] [Created] (DRILL-2681) add sql functions docs (string, convert_to/from)

2015-04-03 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-2681: Summary: add sql functions docs (string, convert_to/from) Key: DRILL-2681 URL: https://issues.apache.org/jira/browse/DRILL-2681 Project: Apache Drill Issue T

Re: Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32819/#review78865 --- Ship it! Looks good. One minor comment. exec/java-exec/src/main/j

[jira] [Created] (DRILL-2682) SQL type syntax "FLOAT(30)" yields AssertionError

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2682: - Summary: SQL type syntax "FLOAT(30)" yields AssertionError Key: DRILL-2682 URL: https://issues.apache.org/jira/browse/DRILL-2682 Project: Apache Dril

[jira] [Resolved] (DRILL-2667) Document Date/Time functions

2015-04-03 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2667. -- Resolution: Fixed > Document Date/Time functions > > >

Re: Review Request 32799: DRILL-2596: CTAS plan should be shown in the Web UI

2015-04-03 Thread Aman Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32799/#review78868 --- Ship it! Ship It! - Aman Sinha On April 3, 2015, 8:07 p.m., Sean

[jira] [Resolved] (DRILL-2596) CTAS plan should be shown in the Web UI

2015-04-03 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-2596. --- Resolution: Fixed Fix Version/s: 0.9.0 > CTAS plan should be shown in the Web UI > ---

[jira] [Created] (DRILL-2683) SQL type REAL is not supported

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2683: - Summary: SQL type REAL is not supported Key: DRILL-2683 URL: https://issues.apache.org/jira/browse/DRILL-2683 Project: Apache Drill Issue T

Re: Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation

2015-04-03 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32831/#review78872 --- Ship it! Loggs good if the comment is addressed. exec/java-exec/s

Re: Review Request 32819: DRILL-2673 Update UserServer <==> UserClient RPC to handle handshake response better

2015-04-03 Thread Venki Korukanti
> On April 4, 2015, 12:03 a.m., Parth Chandra wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java, > > line 118 > > > > > > Is this block redundant now? Status will not be success if

[jira] [Created] (DRILL-2684) Unique-ify view names in TestUnionAll & TestExampleQueries test suites

2015-04-03 Thread Hanifi Gunes (JIRA)
Hanifi Gunes created DRILL-2684: --- Summary: Unique-ify view names in TestUnionAll & TestExampleQueries test suites Key: DRILL-2684 URL: https://issues.apache.org/jira/browse/DRILL-2684 Project: Apache Dr

[jira] [Created] (DRILL-2685) Unique-ify local Hive metastore directory or unit test fails

2015-04-03 Thread Hanifi Gunes (JIRA)
Hanifi Gunes created DRILL-2685: --- Summary: Unique-ify local Hive metastore directory or unit test fails Key: DRILL-2685 URL: https://issues.apache.org/jira/browse/DRILL-2685 Project: Apache Drill

Re: Review Request 32831: DRILL-2674: Add user authenticator interface and PAM based implementation

2015-04-03 Thread Venki Korukanti
> On April 4, 2015, 12:49 a.m., Parth Chandra wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java, > > line 201 > > > > > > Initialize this to empty string? If the client does not pa

[jira] [Created] (DRILL-2686) Move writeJson() methods from PhysicalPlanReader to corresponding classes

2015-04-03 Thread Sudheesh Katkam (JIRA)
Sudheesh Katkam created DRILL-2686: -- Summary: Move writeJson() methods from PhysicalPlanReader to corresponding classes Key: DRILL-2686 URL: https://issues.apache.org/jira/browse/DRILL-2686 Project:

Re: Review Request 32795: DRILL-2383: Add exception and pause injections for testing drillbit stability

2015-04-03 Thread Sudheesh Katkam
> On April 3, 2015, 10:58 p.m., Chris Westin wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/planner/PhysicalPlanReader.java, > > line 91 > > > > > > I'm not thrilled with the pattern that's emerging here

[jira] [Created] (DRILL-2687) TINYINT/SMALLINT's clean not-implemented-yet messages are missing or late for views

2015-04-03 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2687: - Summary: TINYINT/SMALLINT's clean not-implemented-yet messages are missing or late for views Key: DRILL-2687 URL: https://issues.apache.org/jira/browse/DRILL-26

Review Request 32849: DRILL-2672: C++ Client - Update for authentication changes

2015-04-03 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32849/ --- Review request for drill, Alexander zarei, Norris Lee, Venki Korukanti, and Xiao

Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected

2015-04-03 Thread Sean Hsuan-Yi Chu
> On April 3, 2015, 12:15 a.m., Aman Sinha wrote: > > exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java, > > line 123 > > > > > > It's not clear to me why we have to check

Re: Review Request 32590: DRILL-2591: In UnionAllRecordBactch, the mechansim to detect schema change is corrected

2015-04-03 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32590/ --- (Updated April 4, 2015, 3:08 a.m.) Review request for drill and Aman Sinha. C

[jira] [Created] (DRILL-2688) Use of ORDER BY on right side of Union All results in SqlValidatorException

2015-04-03 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-2688: - Summary: Use of ORDER BY on right side of Union All results in SqlValidatorException Key: DRILL-2688 URL: https://issues.apache.org/jira/browse/DRILL-2688 Project:

Re: Review Request 32849: DRILL-2672: C++ Client - Update for authentication changes

2015-04-03 Thread Venki Korukanti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32849/#review78877 --- LGTM. I have couple of qns. contrib/native/client/src/clientlib/dr