Re: Review Request 32800: C++ Client Authentication API passing std::string across DLL boundaries

2015-04-06 Thread Norris Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32800/ --- (Updated April 6, 2015, 6:30 p.m.) Review request for drill, Alexander zarei,

[jira] [Created] (DRILL-2697) Pause injections should pause indefinitely until signalled

2015-04-06 Thread Sudheesh Katkam (JIRA)
Sudheesh Katkam created DRILL-2697: -- Summary: Pause injections should pause indefinitely until signalled Key: DRILL-2697 URL: https://issues.apache.org/jira/browse/DRILL-2697 Project: Apache Drill

[jira] [Resolved] (DRILL-2637) Schema change reported incorrectly although both the input columns are of same datatype

2015-04-06 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2637. -- Resolution: Fixed Schema change reported incorrectly although both the input columns

[jira] [Resolved] (DRILL-2591) Aggregate in left input to Union All does not work

2015-04-06 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2591. -- Resolution: Fixed Aggregate in left input to Union All does not work

[jira] [Resolved] (DRILL-708) TRUNC(n1) function returns a decimal instead of int

2015-04-06 Thread Parth Chandra (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Chandra resolved DRILL-708. - Resolution: Won't Fix TRUNC(n1) function returns a decimal instead of int

Re: drill-interpreter project errors

2015-04-06 Thread Daniel Barclay
You can safely delete the module from your working directory. Thanks. Why didn't my rebasing of my branch on master remove the module? Daniel Jason Altekruse wrote: The interpreter module was removed in a recent commit to make the interpreter usable at planning time. The interpreter code

[jira] [Resolved] (DRILL-2226) Create test utilities for checking plans for patterns

2015-04-06 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2226. Resolution: Fixed Fix Version/s: (was: 1.0.0) 0.8.0 Fixed in

Re: drill-interpreter project errors

2015-04-06 Thread Jason Altekruse
The interpreter module was removed in a recent commit to make the interpreter usable at planning time. The interpreter code was committed a few months ago, but only had unit tests written against it in its own module. To make the interpreter work with the other modules and hook it up to planning

Review Request 32904: SQL scalar functions docs

2015-04-06 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32904/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2681

[jira] [Created] (DRILL-2704) Schema change not reported in Union All query

2015-04-06 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-2704: - Summary: Schema change not reported in Union All query Key: DRILL-2704 URL: https://issues.apache.org/jira/browse/DRILL-2704 Project: Apache Drill Issue

Re: unit test failure

2015-04-06 Thread Hanifi Gunes
@Jason and those who had successful runs, how many forks did you guys run with? -Hanifi On Mon, Apr 6, 2015 at 3:37 PM, Jason Altekruse altekruseja...@gmail.com wrote: I just had a successful run on my linux machine and two runs on my mac. The logs from my linux machine do not show the

[jira] [Resolved] (DRILL-2681) add sql functions docs (string, convert_to/from)

2015-04-06 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2681. -- Resolution: Fixed add sql functions docs (string, convert_to/from)

[jira] [Resolved] (DRILL-1840) Cloning the source repository as documented in the wiki

2015-04-06 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-1840. -- Resolution: Fixed Sorry for the delay. Thanks for letting us know about the broken links. We

Re: unit test failure

2015-04-06 Thread Jason Altekruse
On both the linux VM and my mac I ran with a fork count of 2. On Mon, Apr 6, 2015 at 3:43 PM, Hanifi Gunes hgu...@maprtech.com wrote: @Jason and those who had successful runs, how many forks did you guys run with? -Hanifi On Mon, Apr 6, 2015 at 3:37 PM, Jason Altekruse

Regarding unit test failures -- patterns possible fixes

2015-04-06 Thread Hanifi Gunes
Hey devs, I have been dealing with sporadic unit test failures since last week. I'd like to share my findings on failing unit tests outlining the patterns causing these. The general advice I was given was to run tests lowering the fork count (the default is 4). This sounds ok to get around the

Fwd: unit test failure

2015-04-06 Thread Parth Chandra
I'm seeing the following in the Unit tests (the test seem to be passing though). Anyone else see these or is it just my branch? *Running org.apache.drill.TestUnionAll#testUnionAllImplicitCastingFailure* key 52459253098448904 1116675951 Exception (no rows returned):

[jira] [Created] (DRILL-2700) Missing/deleted drillbit.log files on cluster are not reported

2015-04-06 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-2700: - Summary: Missing/deleted drillbit.log files on cluster are not reported Key: DRILL-2700 URL: https://issues.apache.org/jira/browse/DRILL-2700 Project: Apache Drill

Re: unit test failure

2015-04-06 Thread Jason Altekruse
I just had a successful run on my linux machine and two runs on my mac. The logs from my linux machine do not show the stacktrace or error message, but searching the output from my mac I do see it, on the same test. - Jason Altekruse On Mon, Apr 6, 2015 at 2:57 PM, Parth Chandra

Re: unit test failure

2015-04-06 Thread Hsuan Yi Chu
Hi, Actually, that unit test was written by me. The failure was the expected behavior. The annotation = @Test(expected = RpcException.class) On Mon, Apr 6, 2015 at 3:37 PM, Jason Altekruse altekruseja...@gmail.com wrote: I just had a successful run on my linux machine and two runs on my mac.

Review Request 32910: minor doc changes

2015-04-06 Thread Kristine Hahn
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32910/ --- Review request for drill and Bridget Bridget. Bugs: DRILL-2701

[jira] [Created] (DRILL-2701) configuration options

2015-04-06 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-2701: Summary: configuration options Key: DRILL-2701 URL: https://issues.apache.org/jira/browse/DRILL-2701 Project: Apache Drill Issue Type: Task

Re: Regarding unit test failures -- patterns possible fixes

2015-04-06 Thread Abdel Hakim Deneche
From my personal experience, using a forkCount of 4 makes some tests to timeout, not because there are some concurrent problems but just because my machine is not powerful enough to run as many tests in parallel. On Mon, Apr 6, 2015 at 5:06 PM, Hanifi Gunes hgu...@maprtech.com wrote: Hey devs,

Re: Review Request 32494: DRILL-2565: Add AlreadyClosedSqlException, some key checks, and test for future DRILL-2489 fix.

2015-04-06 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32494/#review79105 --- Ship it! Sqlline does not seem to be an issue. - Parth Chandra

Re: Review Request 32800: C++ Client Authentication API passing std::string across DLL boundaries

2015-04-06 Thread Parth Chandra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32800/#review79116 --- Ship it! Ship It! - Parth Chandra On April 6, 2015, 6:30 p.m.,

Re: Regarding unit test failures -- patterns possible fixes

2015-04-06 Thread Hanifi Gunes
I have just seen Jacques' comment under the patch. I am not sure whether we should set forks to a fraction of available cores. Any ideas? On Mon, Apr 6, 2015 at 5:52 PM, Hanifi Gunes hgu...@maprtech.com wrote: @Ted, I actually have a patch pending review for this at

[jira] [Resolved] (DRILL-2646) CONVERT_TO/CONVERT_FROM syntax (arguments) not specified

2015-04-06 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2646. -- Resolution: Fixed CONVERT_TO/CONVERT_FROM syntax (arguments) not specified

[jira] [Created] (DRILL-2707) Projecting a varchar column from a parquet file after a full outer join with a json file results in IOOBException

2015-04-06 Thread Rahul Challapalli (JIRA)
Rahul Challapalli created DRILL-2707: Summary: Projecting a varchar column from a parquet file after a full outer join with a json file results in IOOBException Key: DRILL-2707 URL:

Re: Regarding unit test failures -- patterns possible fixes

2015-04-06 Thread Ted Dunning
My mac knows it has 2 physical and 4 logical cores: ted:spy$ sysctl hw | grep cpu hw.ncpu: 4 hw.activecpu: 4 hw.physicalcpu: 2 hw.physicalcpu_max: 2 hw.logicalcpu: 4 hw.logicalcpu_max: 4 hw.cputype: 7 hw.cpusubtype: 4 hw.cpu64bit_capable: 1 hw.cpufamily: 526772277 hw.cpufrequency: 29

Re: Review Request 32867: DRILL-2695: Add support for large in lists via values operator

2015-04-06 Thread Hanifi Gunes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32867/#review79089 ---

Re: Review Request 32713: DRILL-2638: Regularize startup/shutdown logging a bit in/near Drillbit.

2015-04-06 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32713/#review79115 ---

Re: Review Request 32795: DRILL-2383: Add exception and pause injections for testing drillbit stability

2015-04-06 Thread abdelhakim deneche
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32795/#review79118 ---

Re: Review Request 32910: minor doc changes

2015-04-06 Thread Bridget Bridget
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32910/#review79098 --- Ship it! Ship It! - Bridget Bridget On April 6, 2015, 11:48

Re: drill-interpreter project errors

2015-04-06 Thread Daniel Barclay
Chris Westin wrote: That's not going to remove the project from your IDE. Of course, but shouldn't it have deleted all the files from Git? Daniel When I saw Jason's commit went through, I removed the project, updated maven modules metadata, and rebuilt after the next time I rebased. Then

[jira] [Resolved] (DRILL-2214) Aggregate function documentation needs to be corrected

2015-04-06 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2214. -- Resolution: Fixed The info about DISTINCT and ALL has been added to the doc. Included your

[jira] [Resolved] (DRILL-2215) COALESCE function needs to be documented

2015-04-06 Thread Kristine Hahn (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kristine Hahn resolved DRILL-2215. -- Resolution: Fixed Now covered on http://drill.apache.org/docs/functions-for-handling-nulls/ and

[jira] [Created] (DRILL-2706) doc configuration options

2015-04-06 Thread Kristine Hahn (JIRA)
Kristine Hahn created DRILL-2706: Summary: doc configuration options Key: DRILL-2706 URL: https://issues.apache.org/jira/browse/DRILL-2706 Project: Apache Drill Issue Type: Task

Re: Review Request 32795: DRILL-2383: Add exception and pause injections for testing drillbit stability

2015-04-06 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32795/#review79108 --- Some initial thoughts. Still working on second half of patch.

Review Request 32801: DRILL-2668: Fix: CAST(1.1 AS FLOAT) was yielding DOUBLE.

2015-04-06 Thread Daniel Barclay
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32801/ --- Review request for drill, Mehant Baid and Parth Chandra. Bugs: DRILL-2668

[jira] [Created] (DRILL-2708) Query failed: AssertionError: VARCHAR

2015-04-06 Thread Daniel Barclay (Drill) (JIRA)
Daniel Barclay (Drill) created DRILL-2708: - Summary: Query failed: AssertionError: VARCHAR Key: DRILL-2708 URL: https://issues.apache.org/jira/browse/DRILL-2708 Project: Apache Drill

Re: User Authentication patch: question with regards to UserCredentials versus properties.

2015-04-06 Thread Venki Korukanti
Currently we add UserCredentials to every PlanFragment we generate as part of the query. PlanFragments are distributed across the Drillbits in cluster. Adding password to UserCredentials will expose the password to all Drillbits beyond the Drillbit where the UserSession is. This is main reason I

Review Request 32886: DRILL-2639: Planner bug - RelOptPlanner.CannotPlanExceptio

2015-04-06 Thread Sean Hsuan-Yi Chu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32886/ --- Review request for drill and Aman Sinha. Bugs: DRILL-2639