Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-07-02 Thread Sudheesh Katkam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34603/#review90193 --- Add to my never ending comments on this patch :) I was facing

[jira] [Created] (DRILL-3455) If a drillbit, that contains fragments for the current query, dies the QueryManager will fail the query even if those fragments already finished successfully

2015-07-02 Thread Deneche A. Hakim (JIRA)
Deneche A. Hakim created DRILL-3455: --- Summary: If a drillbit, that contains fragments for the current query, dies the QueryManager will fail the query even if those fragments already finished successfully Key: DRILL-3455

Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-07-02 Thread abdelhakim deneche
On July 2, 2015, 6:34 a.m., Sudheesh Katkam wrote: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/WorkEventBus.java, line 97 https://reviews.apache.org/r/34603/diff/4/?file=996192#file996192line97 What about the race condition that you fixed in DRILL-3061? I

Re: Review Request 35887: DRILL-3312: PageReader.allocatePageData() calls BufferAllocator.buffer(int) but doesn't check if the result is null

2015-07-02 Thread abdelhakim deneche
On July 2, 2015, 5:17 a.m., Hanifi Gunes wrote: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java, line 305 https://reviews.apache.org/r/35887/diff/1/?file=992327#file992327line305 This change does not seem needed after 3445. Should we

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Hsuan Yi Chu
+1 (non-binding) Unit tests passed on mac linux VM. Tried a few queries on 2-node VM. All worked out. On Thu, Jul 2, 2015 at 1:24 PM, Norris Lee norr...@simba.com wrote: I built from source on Linux and ran queries against different data sources/file types through ODBC. Also ran our internal

[jira] [Resolved] (DRILL-1395) UNION ALL query fails while setting up Foreman

2015-07-02 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-1395. -- Resolution: Fixed UNION ALL query fails while setting up Foreman

[jira] [Resolved] (DRILL-2095) Order by on a repeated index inside a sub query results in an NPE

2015-07-02 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2095. -- Resolution: Fixed Order by on a repeated index inside a sub query results in an NPE

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Hanifi GUNES
* Jinfeng* *- Verified checksum for both the source and binary tar files.* * Hanifi, Sudheesh* *- manually inspected maven repo- built a query submitter importing jdbc-all artifact from the repo at [jacques:3]* Is there a guideline on verifying maven artifacts besides inspecting published

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Aman Sinha
(Followup to my previous email). I ran several queries against TPCH SF1 on my Mac and did not find any issues, apart from the version # shown in sqlline (which I think is a non-blocker). +1 (binding) Aman On Thu, Jul 2, 2015 at 8:36 PM, Hanifi GUNES hanifigu...@gmail.com wrote: * Jinfeng*

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Aman Sinha
Downloaded the binary tar-ball. Installed on my macbook. Started sqlline in embedded mode. Saw that sqlline is showing version 1.0.0 instead of 1.1.0, although 'select * from sys.version' is showing the right commit. Anyone else sees this ? /sqlline -u jdbc:drill:zk=local -n admin -p admin

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Hanifi Gunes
- fully built and tested Drill from source on CentOS - deployed on 3 nodes - ran concurrent queries - manually inspected maven repo - built a Scala query submitter importing jdbc-all artifact from the repo at [jacques:3] overall, great job! +1 (binding) On Thu, Jul 2, 2015 at 3:16 PM, rahul

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Mehant Baid
+1 (binding) * Downloaded src tar-ball, was able to build and run unit tests successfully. * Brought up DrillBit in embedded and distributed mode. * Ran some TPC-H queries via Sqlline and the web UI. * Checked the UI for profiles Looks good. Thanks Mehant On 7/2/15 5:36 PM, Sudheesh Katkam

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Jason Altekruse
+1 binding - downloaded and built the source tarball, all tests passed (on MAC osx) - started sqlline, issued a few queries - tried a basic update of storage plugin from the web UI and looked over a few query profiles On Thu, Jul 2, 2015 at 5:42 PM, Mehant Baid baid.meh...@gmail.com wrote: +1

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Sudheesh Katkam
+1 (non-binding) * downloaded binary tar-ball * ran queries (including cancellations) in embedded mode on Mac; verified states in web UI * downloaded and built from source tar-ball; ran unit tests on Mac * ran queries (including cancellations) on a 3 node cluster; verified states in web UI *

[jira] [Resolved] (DRILL-2770) Aggregate query returns AssertionError: star should have been expanded

2015-07-02 Thread Khurram Faraaz (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khurram Faraaz resolved DRILL-2770. --- Resolution: Fixed Fix Version/s: (was: 1.2.0) 1.1.0 Verified. I

Re: Improving the default JIRA assignments for those working on Drill full time

2015-07-02 Thread Parth Chandra
I would like to suggest that Hanifi be component owner for Datatypes and Mehant be component owner for Drill-Functions. They are the ones who have been picking up and fixing issues for those components. Daniel since you're the current owner for these components, would you agree? Parth On Wed,

[jira] [Resolved] (DRILL-1938) Fix error message when reserved words are used in query.

2015-07-02 Thread Aman Sinha (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aman Sinha resolved DRILL-1938. --- Resolution: Fixed Fix error message when reserved words are used in query.

[jira] [Resolved] (DRILL-1754) Flatten nested within another flatten fails

2015-07-02 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-1754. Resolution: Duplicate Fix Version/s: (was: 1.2.0) Flatten nested within another

[jira] [Resolved] (DRILL-1770) Flatten on top a subquery which applies flatten over kvgen results in a ClassCastException

2015-07-02 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-1770. Resolution: Fixed Fix Version/s: (was: 1.2.0) 0.8.0 This was

[jira] [Resolved] (DRILL-1753) Flatten fails on a repeated map, where the maps being flattened contain repeated lists

2015-07-02 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-1753. Resolution: Fixed Fix Version/s: (was: 1.2.0) 1.1.0 Flatten

Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-07-02 Thread abdelhakim deneche
On July 1, 2015, 5:23 p.m., Sudheesh Katkam wrote: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java, line 182 https://reviews.apache.org/r/34603/diff/4/?file=996195#file996195line182 Doc fix: (1) Not recent inactive

Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-07-02 Thread abdelhakim deneche
On July 2, 2015, 12:20 a.m., Sudheesh Katkam wrote: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryManager.java, line 296 https://reviews.apache.org/r/34603/diff/4/?file=996197#file996197line296 Please add more information to the MinorFragmentProfile,

Re: Review Request 34603: DRILL-3167: When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

2015-07-02 Thread Sudheesh Katkam
On July 1, 2015, 5:23 p.m., Sudheesh Katkam wrote: exec/java-exec/src/main/java/org/apache/drill/exec/work/batch/ControlMessageHandler.java, line 182 https://reviews.apache.org/r/34603/diff/4/?file=996195#file996195line182 Doc fix: (1) Not recent inactive

[jira] [Resolved] (DRILL-2694) Correlated subquery can not be planned

2015-07-02 Thread Khurram Faraaz (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Khurram Faraaz resolved DRILL-2694. --- Resolution: Fixed Fix Version/s: (was: 1.2.0) 1.1.0 Verified

[jira] [Resolved] (DRILL-2105) Query fails when using flatten on JSON data where some documents have an empty array

2015-07-02 Thread Jason Altekruse (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Altekruse resolved DRILL-2105. Resolution: Fixed Fix Version/s: (was: 1.2.0) 0.8.0 It looks

Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException

2015-07-02 Thread abdelhakim deneche
On July 1, 2015, 9:44 p.m., Hanifi Gunes wrote: exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector2.java, line 94 https://reviews.apache.org/r/36103/diff/1/?file=997588#file997588line94 Not a show stopper but I would suggest renaming this to

[jira] [Created] (DRILL-3456) Need support for default values for column in CTAS

2015-07-02 Thread Khurram Faraaz (JIRA)
Khurram Faraaz created DRILL-3456: - Summary: Need support for default values for column in CTAS Key: DRILL-3456 URL: https://issues.apache.org/jira/browse/DRILL-3456 Project: Apache Drill

Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException

2015-07-02 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36103/#review90279 --- Ship it! Ship It! - Jacques Nadeau On July 1, 2015, 9:21 p.m.,

RE: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Norris Lee
I built from source on Linux and ran queries against different data sources/file types through ODBC. Also ran our internal ODBC test suite. Looks good. +1 (non-binding) Norris -Original Message- From: Jinfeng Ni [mailto:jinfengn...@gmail.com] Sent: Wednesday, July 01, 2015 4:03 PM

Re: Review Request 36103: DRILL-3445: BufferAllocator.buffer() implementations should throw an OutOfMemoryRuntimeException

2015-07-02 Thread Jacques Nadeau
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36103/#review90278 ---

[jira] [Resolved] (DRILL-3258) Add support for non-scalar subqueries in expressions within HAVING clause

2015-07-02 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-3258. -- Resolution: Fixed Add support for non-scalar subqueries in expressions within HAVING

[jira] [Resolved] (DRILL-2777) CTAS, order by and flatten of repeated list result in ExpandConversionRule error

2015-07-02 Thread Jinfeng Ni (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinfeng Ni resolved DRILL-2777. --- Resolution: Fixed CTAS, order by and flatten of repeated list result in ExpandConversionRule error

[jira] [Resolved] (DRILL-2724) Implicit cast test fails in Union All query (reports type mismatch)

2015-07-02 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2724. -- Resolution: Won't Fix Implicit cast test fails in Union All query (reports type

Re: [VOTE] Release Apache Drill 1.1.0 (rc0)

2015-07-02 Thread Parth Chandra
+1 (binding) Release looks good. Built from source (mvn clean install). Verified src checksum. Built C++ client, ran multiple parallel queries from C++ client against drillbit. Tested all datatypes with C++ client. On Thu, Jul 2, 2015 at 1:49 PM, Hsuan Yi Chu hyi...@maprtech.com wrote: +1

[jira] [Resolved] (DRILL-2874) Concat operator is not supported with complex types, we should throw an error early

2015-07-02 Thread Sean Hsuan-Yi Chu (JIRA)
[ https://issues.apache.org/jira/browse/DRILL-2874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Hsuan-Yi Chu resolved DRILL-2874. -- Resolution: Won't Fix It is not possible to make that judgement at planning time. Drill