[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user yufeldman commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192171659 Couple of general comments: 1. Since you are using Hadoop UGI it probably makes sense to be more compliant with Hadoop auth definitions. Which are: "superuser" can p

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user asfgit closed the pull request at: https://github.com/apache/drill/pull/401 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Time for the 1.6 Release

I think we need to include DRILL-4467 . I think it is a one line patch and it provides unpredictable plans at a minimum but may also present invalid result. Still need to think through the second half. I've seen this plan instability in some of my r

Re: Time for the 1.6 Release

Updated list (I'll follow up with the folks named here separately) - Committed for 1.6 - DRILL-4384 - Query profile is missing important information on WebUi - Merged DRILL-3488/pr 388 (Java 1.8 support) - Merged. DRILL-4410/pr 380 (listvector should initiatlize bits...) - Merged DRILL-4383/pr 3

Re: Time for the 1.6 Release

Right. My mistake. Thanks, Jacques, for reviewing. On Thu, Mar 3, 2016 at 9:08 PM, Zelaine Fong wrote: > DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to > review) > > Sudheesh is the fixer of DRILL-4281, so I don't think he can be the > reviewer :). > > -- Zelaine > >

[GitHub] drill pull request: DRILL-4437: Operator unit tests

Github user parthchandra commented on the pull request: https://github.com/apache/drill/pull/394#issuecomment-192114749 +1. Great to have this framework; nicely done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

Re: Time for the 1.6 Release

I've been reviewing 4281. It's really close to ready. -- Jacques Nadeau CTO and Co-Founder, Dremio On Thu, Mar 3, 2016 at 9:08 PM, Zelaine Fong wrote: > DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to > review) > > Sudheesh is the fixer of DRILL-4281, so I don't thin

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54990639 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Soft

Re: Time for the 1.6 Release

DRILL-4281/pr 400 (Drill should support inbound impersonation) (Sudheesh to review) Sudheesh is the fixer of DRILL-4281, so I don't think he can be the reviewer :). -- Zelaine On Thu, Mar 3, 2016 at 6:30 PM, Parth Chandra wrote: > Here's an updated list with names of reviewers added. If anyone

Re: Time for the 1.6 Release

Yes. I noticed the comment after I sent out the email. Removing it from the list. On Thu, Mar 3, 2016 at 7:02 PM, Hanifi Gunes wrote: > DRILL-4416 is going to make it to 1.7. The patch causes a leak and I will > look into it once I make some time but 1.6 is too early. > > On Thu, Mar 3, 2016 at

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54987453 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4416: quote path separator for cross pla...

Github user hnfgns commented on the pull request: https://github.com/apache/drill/pull/385#issuecomment-192074959 This patch causes a random leak. I am backing it off for a while. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Time for the 1.6 Release

DRILL-4416 is going to make it to 1.7. The patch causes a leak and I will look into it once I make some time but 1.6 is too early. On Thu, Mar 3, 2016 at 6:30 PM, Parth Chandra wrote: > Here's an updated list with names of reviewers added. If anyone else is > reviewing the open PRs please let me

Re: Time for the 1.6 Release

Here's an updated list with names of reviewers added. If anyone else is reviewing the open PRs please let me know. Some PRs have owners names that I will follow up with. Jason, I've included your JIRA in the list. Committed for 1.6 - DRILL-4384 - Query profile is missing important information on

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54980440 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Sof

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54979630 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/testing/UserAuthenticatorToTestDelegation.java --- @@ -0,0 +1,72 @@ +pac

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192046477 Generally looks good. +1 with the few small items above addressed. Updating the names to something else would be good. Since this is also impersonation (just client imp

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54977484 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/delegation/TestUserDelegation.java --- @@ -0,0 +1,124 @@ +/** + * Licensed to the Apach

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54977306 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/delegation/TestDelegationPrivileges.java --- @@ -0,0 +1,137 @@ +/** + * Licensed to the

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54977178 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Soft

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54977126 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache Soft

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54976899 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserSession.java --- @@ -116,14 +137,38 @@ public OptionManager getOptions() {

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54976762 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -88,6 +89,7 @@ String USER_AUTHENTICATION_ENABLED = "drill.exe

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-192036063 I don't think they are common. How about "principals" and "can_delegate_for"? I am not strongly against "can_impersonate", but I want to avoid confusion with user

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on the pull request: https://github.com/apache/drill/pull/401#issuecomment-192034285 Overall, looks good to me. The patch simplifies Calcite integration, make the code cleaner, and make it easier to extend in Drill. +1 --- If your pro

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54970576 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/SqlConverter.java --- @@ -0,0 +1,364 @@ +/** + * Licensed to the Apache Sof

Re: Time for the 1.6 Release

I have updated the PR for the parquet date corruption issue that didn't make it into 1.5. https://github.com/apache/drill/pull/341 https://issues.apache.org/jira/browse/DRILL-4203 If this can get reviewed, I think it would be good to get into the release. Any takers? On Wed, Mar 2, 2016 at 11:07

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54965064 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,60 @@ */ package org.apache.drill

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54964989 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54964785 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54963651 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54957475 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54956465 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java --- @@ -100,8 +108,13 @@ public void onMatch(RelOp

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54956169 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java --- @@ -100,8 +108,13 @@ public void onMatch(RelOp

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54955354 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54955232 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlWrapper.java --- @@ -0,0 +1,33 @@ +/** + * Licensed to the Apa

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54955290 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54954482 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -770,6 +770,65 @@ public void eval() { } // end

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54954517 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java --- @@ -17,18 +17,51 @@ */ package org.apache.drill.exec.plann

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54952796 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +112,58 @@ public DrillFunctionRegistry(ScanResu

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54952798 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,60 @@ */ package org.apache.drill

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54952793 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +112,58 @@ public DrillFunctionRegistry(ScanResu

[GitHub] drill pull request: DRILL-3623: Use shorter query path for LIMIT 0...

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/193#issuecomment-191973058 Moving to #405. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] drill pull request: DRILL-3623: Use shorter query path for LIMIT 0...

Github user sudheeshkatkam closed the pull request at: https://github.com/apache/drill/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-3623: For limit 0 queries, use a shorter...

GitHub user sudheeshkatkam opened a pull request: https://github.com/apache/drill/pull/405 DRILL-3623: For limit 0 queries, use a shorter path when result column types are known Moving from #193 to here. + There is a pull request open for first commit (DRILL-4372: #397).

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/400#issuecomment-191963668 Are delegate and delegator common used terms for these things? Frankly, I would have to look these up to confirm which is which and could see making a mistake reversing

Re: Apache drill on Android devices!

Interesting. Wondering if this is a fun project or one has some serious intentions to build a Drill cluster of droids. Either way, good luck with Dalvik and unsafe. NoSql on Android has certain advantages and use cases but wondering how Drill as a query engine would come handy. Thoughts? -Hanifi

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on the pull request: https://github.com/apache/drill/pull/397#issuecomment-191911233 Also, commit says I am the author ;) [caused due to squashing] --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54926507 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ExecConstants.java --- @@ -281,4 +283,12 @@ */ String ADMIN_USER_GROUPS_KEY

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54926134 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,60 @@ */ package org.apach

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54925324 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54924830 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[jira] [Created] (DRILL-4471) Add unit test for the Drill Web UI

Jason Altekruse created DRILL-4471: -- Summary: Add unit test for the Drill Web UI Key: DRILL-4471 URL: https://issues.apache.org/jira/browse/DRILL-4471 Project: Apache Drill Issue Type: Test

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54923253 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54923238 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54923299 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

Re: Apache drill on Android devices!

No one has tried to do this yet. The first question I would investigate is if Android supports java direct memory, which Drill makes extensive use of, but is not considered a standard feature in all implementations of the JVM. A quick glance at the docs seems to indicate that it is supported (the a

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54923222 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54923241 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922890 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,568 @@ +/** + * Licensed to the

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922840 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillCalciteSqlWrapper.java --- @@ -0,0 +1,33 @@ +/** + * Licensed to

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922784 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/Checker.java --- @@ -17,18 +17,51 @@ */ package org.apache.drill.exe

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922761 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillReduceAggregatesRule.java --- @@ -100,8 +108,13 @@ public void onMatc

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922538 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -17,40 +17,60 @@ */ package org.apach

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922555 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +112,58 @@ public DrillFunctionRegistry(S

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922569 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StringFunctions.java --- @@ -770,6 +770,65 @@ public void eval() { }

[GitHub] drill pull request: Drill 4372 review

Github user sudheeshkatkam commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54922552 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +112,58 @@ public DrillFunctionRegistry(S

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/401#issuecomment-191890837 @jinfengni: I've addressed your review comments. Let me know any additional feedback. thanks! --- If your project is set up for it, you can reply to this em

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54916226 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,571 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54916249 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlOperator.java --- @@ -18,69 +18,43 @@ package org.apache.drill.exe

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54916158 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,571 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54916066 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,571 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54915844 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/TypeInferenceUtils.java --- @@ -0,0 +1,571 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: Drill 4372 review

Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/397#discussion_r54915765 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/DrillFunctionRegistry.java --- @@ -92,38 +94,110 @@ public DrillFunctionRegistry(ScanResu

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54912350 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlParser.java --- @@ -0,0 +1,349 @@ +/** + * Licensed to the Apache S

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54912629 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlParser.java --- @@ -0,0 +1,349 @@ +/** + * Licensed to the Apache S

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54908424 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/SqlHandlerConfig.java --- @@ -18,30 +18,41 @@ package org.apach

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54907758 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java --- @@ -273,12 +282,90 @@ public RelNode visit(RelN

[GitHub] drill pull request: DRILL-4465: Simplify Calcite parsing & plannin...

Github user jinfengni commented on a diff in the pull request: https://github.com/apache/drill/pull/401#discussion_r54907078 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/DefaultSqlHandler.java --- @@ -273,12 +282,90 @@ public RelNode visit(RelN

Apache drill on Android devices!

Dear Team, I am looking for running the Apache Drill on Android (linux + java based) devices, these devices are 4-8 cores and 2-4 GB RAM + storage speed around to SSD speed! Is there any way to compile or run it? I think it will be great for Apache Drill too as an advantage, there are many No-SQ

[jira] [Created] (DRILL-4470) TPC-H dataset 404

Michael Mior created DRILL-4470: --- Summary: TPC-H dataset 404 Key: DRILL-4470 URL: https://issues.apache.org/jira/browse/DRILL-4470 Project: Apache Drill Issue Type: Bug Reporter: Mi

[jira] [Created] (DRILL-4469) SUM window query returns incorrect results over integer data

Khurram Faraaz created DRILL-4469: - Summary: SUM window query returns incorrect results over integer data Key: DRILL-4469 URL: https://issues.apache.org/jira/browse/DRILL-4469 Project: Apache Drill

[GitHub] drill pull request: DRILL-3688: Drill should honor "skip.header.li...

Github user arina-ielchiieva closed the pull request at: https://github.com/apache/drill/pull/382 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur