[GitHub] drill pull request: Drill 4484: NPE when querying empty directory

2016-03-10 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/424#issuecomment-195140460 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: Drill 4484: NPE when querying empty directory

2016-03-10 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/424#discussion_r55780247 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java --- @@ -547,29 +559,72 @@ public long getRowCount() {

[GitHub] drill pull request: DRILL-4476: Allow UnionAllRecordBatch to manag...

2016-03-10 Thread amansinha100
Github user amansinha100 commented on the pull request: https://github.com/apache/drill/pull/407#issuecomment-195138369 Updated changes LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] drill pull request: DRILL-4476: Allow UnionAllRecordBatch to manag...

2016-03-10 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/407#discussion_r55779800 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -294,13 +313,41 @@ public UnionAllInput(

Re: Time for the 1.6 Release

2016-03-10 Thread Parth Chandra
Done - Version in master branch updated to 1.7.0-SNAPSHOT On Thu, Mar 10, 2016 at 4:46 PM, Jacques Nadeau wrote: > You want to roll forward the current branch to 1.7.0-SNAPSHOT so we can > continue developing/merging stuff? > > -- > Jacques Nadeau > CTO and Co-Founder, Dremio > > >

Re: Time for the 1.6 Release

2016-03-10 Thread Jacques Nadeau
You want to roll forward the current branch to 1.7.0-SNAPSHOT so we can continue developing/merging stuff? -- Jacques Nadeau CTO and Co-Founder, Dremio On Thu, Mar 10, 2016 at 4:09 PM, Parth Chandra wrote: > Hi guys, > > I've created the 1.6.0 branch and will be rolling out the first release

Re: Time for the 1.6 Release

2016-03-10 Thread Parth Chandra
Hi guys, I've created the 1.6.0 branch and will be rolling out the first release candidate as soon as I get the go ahead from the QA team, in the next couple of hours. Thanks Parth On Thu, Mar 10, 2016 at 3:20 PM, Parth Chandra wrote: > It is usually not a good idea to try to rush in a patc

Re: Time for the 1.6 Release

2016-03-10 Thread Parth Chandra
It is usually not a good idea to try to rush in a patch at the last minute. One of the reasons for having monthly releases is so people don't have to wait too long for fixes and developers don't rush fixes in. QA is almost done with their validation, so I'm afraid this might have to go into the nex

Re: Time for the 1.6 Release

2016-03-10 Thread Stefán Baxter
thank you On Thu, Mar 10, 2016 at 9:19 PM, Jason Altekruse wrote: > I hadn't actually tested out the patch, what I had said was that I could > add a flag to make avro files behave like parquet and JSON, without schema > validation. The patch made it so the behavior of directories would be > diff

Re: Time for the 1.6 Release

2016-03-10 Thread Jason Altekruse
I hadn't actually tested out the patch, what I had said was that I could add a flag to make avro files behave like parquet and JSON, without schema validation. The patch made it so the behavior of directories would be different from that of individual files, removing the schema validation. I tried

[GitHub] drill pull request: DRILL-4476: Allow UnionAllRecordBatch to manag...

2016-03-10 Thread amansinha100
Github user amansinha100 commented on a diff in the pull request: https://github.com/apache/drill/pull/407#discussion_r55749381 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java --- @@ -162,6 +162,25 @@ private IterOutcome do

[GitHub] drill pull request: DRILL-4490: Ensure the count generated by Conv...

2016-03-10 Thread hsuanyi
Github user hsuanyi commented on a diff in the pull request: https://github.com/apache/drill/pull/423#discussion_r55730852 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunctions.java --- @@ -460,4 +466,23 @@ public void testGroupBySystemFuncFil

[GitHub] drill pull request: Drill 4484: NPE when querying empty directory

2016-03-10 Thread adeneche
GitHub user adeneche opened a pull request: https://github.com/apache/drill/pull/424 Drill 4484: NPE when querying empty directory this PR also includes the fix for DRILL-4376. I will rebase once that fix has been merged into master You can merge this pull request into a Git repos

Re: Time for the 1.6 Release

2016-03-10 Thread Stefán Baxter
Hi, This issue is still unresolved: https://issues.apache.org/jira/browse/DRILL-4120 It would mean a great deal to us if it was. The solution is, as I understood Jason and Jacques, ready and only needs to be merged. Regards, -Stefán On Thu, Mar 10, 2016 at 3:50 AM, Parth Chandra wrote: > Hi

Re: Time for the 1.6 Release

2016-03-10 Thread Stefán Baxter
You are correct, it was, sorry. On Thu, Mar 10, 2016 at 9:02 AM, Abdel Hakim Deneche wrote: > Hey Stefán, I just left a comment in the JIRA. I think the issue is related > to the double quotes. > > On Thu, Mar 10, 2016 at 9:55 AM, Stefán Baxter > wrote: > > > Hi, > > > > I noticed that using th

Re: Time for the 1.6 Release

2016-03-10 Thread Abdel Hakim Deneche
Hey Stefán, I just left a comment in the JIRA. I think the issue is related to the double quotes. On Thu, Mar 10, 2016 at 9:55 AM, Stefán Baxter wrote: > Hi, > > I noticed that using the IN operator with a sub structure has stopped > working: > > select s.client_ip.ip from dfs.asa.`/processed/ve

[jira] [Created] (DRILL-4495) IN operator does not work

2016-03-10 Thread JIRA
Stefán Baxter created DRILL-4495: Summary: IN operator does not work Key: DRILL-4495 URL: https://issues.apache.org/jira/browse/DRILL-4495 Project: Apache Drill Issue Type: Bug Comp

Re: Time for the 1.6 Release

2016-03-10 Thread Stefán Baxter
Hi, I noticed that using the IN operator with a sub structure has stopped working: select s.client_ip.ip from dfs.asa.`/processed/venuepoint/transactions` as s where s.client_ip.ip in ("unknown") limit 2; Error: PARSE ERROR: Encountered "\"" at line 1, column 103. Was expecting one of: ... SQL Qu